@vellumai/assistant 0.11.0 → 0.11.1-staging.2

package/src/home/relationship-state-writer.ts

@@ -128,10 +128,17 @@ export function writeOnboardingSidecar(ctx: OnboardingContext): void {
 function readOnboardingSidecar(): OnboardingContext | null {
   try {
     const path = getOnboardingSidecarPath();
-    if (!existsSync(path)) return null;
+    if (!existsSync(path)) {
+      return null;
+    }
     const parsed = JSON.parse(readFileSync(path, "utf-8")) as OnboardingContext;
-    if (!parsed || !Array.isArray(parsed.tools) || !Array.isArray(parsed.tasks))
+    if (
+      !parsed ||
+      !Array.isArray(parsed.tools) ||
+      !Array.isArray(parsed.tasks)
+    ) {
       return null;
+    }
     return parsed;
   } catch (err) {
     log.warn({ err }, "Failed to read onboarding-context.json sidecar");
@@ -340,7 +347,9 @@ function publishRelationshipStateUpdated(updatedAt: string): void {
  */
 export async function backfillRelationshipStateIfMissing(): Promise<void> {
   const path = getRelationshipStatePath();
-  if (existsSync(path)) return; // idempotent — only runs once
+  if (existsSync(path)) {
+    return;
+  } // idempotent — only runs once
   log.info("Backfilling relationship-state.json for existing or upgraded user");
   await writeRelationshipState();
 }
@@ -371,7 +380,9 @@ function resolveGuardianUserContent(): string {
     const guardianPath = resolveGuardianPersonaPath();
     if (guardianPath) {
       const content = safeRead(guardianPath);
-      if (content) return content;
+      if (content) {
+        return content;
+      }
     }
   } catch (err) {
     log.warn(
@@ -386,7 +397,9 @@ function resolveGuardianUserContent(): string {
   try {
     const defaultUserPath = join(getWorkspaceDir(), "users", "default.md");
     const defaultContent = safeRead(defaultUserPath);
-    if (defaultContent) return defaultContent;
+    if (defaultContent) {
+      return defaultContent;
+    }
   } catch (err) {
     log.warn({ err }, "Failed to read users/default.md; trying legacy USER.md");
   }
@@ -395,7 +408,9 @@ function resolveGuardianUserContent(): string {
   // that predate migration 031.
   const legacyPath = getWorkspacePromptPath("USER.md");
   const legacy = safeRead(legacyPath);
-  if (legacy) return legacy;
+  if (legacy) {
+    return legacy;
+  }
 
   return "";
 }
@@ -409,7 +424,9 @@ function resolveGuardianUserContent(): string {
  */
 function safeRead(path: string): string {
   try {
-    if (!existsSync(path)) return "";
+    if (!existsSync(path)) {
+      return "";
+    }
     return readFileSync(path, "utf-8");
   } catch {
     return "";
@@ -460,7 +477,9 @@ function extractFacts(input: {
   if (input.onboarding) {
     for (const tool of input.onboarding.tools) {
       const text = tool.trim();
-      if (!text) continue;
+      if (!text) {
+        continue;
+      }
       facts.push({
         id: nextId("onboarding"),
         category: "world",
@@ -471,7 +490,9 @@ function extractFacts(input: {
     }
     for (const task of input.onboarding.tasks) {
       const text = task.trim();
-      if (!text) continue;
+      if (!text) {
+        continue;
+      }
       facts.push({
         id: nextId("onboarding"),
         category: "priorities",
@@ -509,9 +530,13 @@ function extractFacts(input: {
 
   for (const line of iterateBulletLines(input.userContent)) {
     const parsed = parseBulletLabelValue(line);
-    if (!parsed) continue;
+    if (!parsed) {
+      continue;
+    }
     const { label, value } = parsed;
-    if (!value) continue;
+    if (!value) {
+      continue;
+    }
     const lower = label.toLowerCase();
     const isPriority = priorityKeywords.some((k) => lower.startsWith(k));
     const category: Fact["category"] = isPriority ? "priorities" : "world";
@@ -526,9 +551,13 @@ function extractFacts(input: {
 
   for (const line of iterateBulletLines(input.soulContent)) {
     const parsed = parseBulletLabelValue(line);
-    if (!parsed) continue;
+    if (!parsed) {
+      continue;
+    }
     const { label, value } = parsed;
-    if (!value) continue;
+    if (!value) {
+      continue;
+    }
     facts.push({
       id: nextId("soul"),
       category: "voice",
@@ -547,14 +576,24 @@ function extractFacts(input: {
  * trimmed bullet body, without the leading `-` or `*`.
  */
 function* iterateBulletLines(content: string): Generator<string> {
-  if (!content) return;
+  if (!content) {
+    return;
+  }
   for (const raw of content.split("\n")) {
     const line = raw.trim();
-    if (!line) continue;
-    if (line.startsWith("_")) continue;
-    if (!line.startsWith("- ") && !line.startsWith("* ")) continue;
+    if (!line) {
+      continue;
+    }
+    if (line.startsWith("_")) {
+      continue;
+    }
+    if (!line.startsWith("- ") && !line.startsWith("* ")) {
+      continue;
+    }
     const body = line.slice(2).trim();
-    if (body.length === 0) continue;
+    if (body.length === 0) {
+      continue;
+    }
     yield body;
   }
 }
@@ -568,10 +607,14 @@ function parseBulletLabelValue(
 ): { label: string; value: string } | null {
   const stripped = body.replace(/\*\*/g, "").replace(/__/g, "");
   const idx = stripped.indexOf(":");
-  if (idx <= 0) return null;
+  if (idx <= 0) {
+    return null;
+  }
   const label = stripped.slice(0, idx).trim();
   const value = stripped.slice(idx + 1).trim();
-  if (!label) return null;
+  if (!label) {
+    return null;
+  }
   return { label, value };
 }
 
@@ -581,7 +624,9 @@ function parseBulletLabelValue(
  */
 function capitalizeLabel(label: string): string {
   const trimmed = label.trim();
-  if (!trimmed) return trimmed;
+  if (!trimmed) {
+    return trimmed;
+  }
   return trimmed.charAt(0).toUpperCase() + trimmed.slice(1).toLowerCase();
 }
 
@@ -643,7 +688,9 @@ function resolveConnectedProviders(): Set<string> {
     const rows = listConnections();
     const set = new Set<string>();
     for (const row of rows) {
-      if (row.status === "active") set.add(row.provider);
+      if (row.status === "active") {
+        set.add(row.provider);
+      }
     }
     return set;
   } catch (err) {
@@ -699,7 +746,9 @@ function parseIdentity(identityPath: string): {
 
   for (const line of iterateBulletLines(content)) {
     const parsed = parseBulletLabelValue(line);
-    if (!parsed || !parsed.value) continue;
+    if (!parsed || !parsed.value) {
+      continue;
+    }
     const lower = parsed.label.toLowerCase();
     // Accept any label whose lowercased form looks like a "name"
     // label: `Name`, `Assistant Name`, `Preferred Name`, etc.
@@ -741,10 +790,14 @@ function parseIdentity(identityPath: string): {
  * is present so the caller can leave `userName` off the wire.
  */
 function parseUserName(content: string): string | undefined {
-  if (!content) return undefined;
+  if (!content) {
+    return undefined;
+  }
   for (const line of iterateBulletLines(content)) {
     const parsed = parseBulletLabelValue(line);
-    if (!parsed) continue;
+    if (!parsed) {
+      continue;
+    }
     const lower = parsed.label.toLowerCase();
     if (
       (lower === "user" ||

package/src/ipc/__tests__/exit-helper.test.ts

@@ -17,9 +17,9 @@ describe("exitFromIpcResult", () => {
   let stderrSpy: ReturnType<typeof spyOn>;
 
   const setupSpies = () => {
-    exitSpy = spyOn(process, "exit").mockImplementation(
-      (code?: number) => { throw new Error(`exit:${code}`); },
-    );
+    exitSpy = spyOn(process, "exit").mockImplementation((code?: number) => {
+      throw new Error(`exit:${code}`);
+    });
     stderrSpy = spyOn(process.stderr, "write").mockImplementation(() => true);
   };
 
@@ -73,16 +73,18 @@ describe("exitFromIpcResult", () => {
   test("writes error message to stderr", () => {
     setupSpies();
     expect(() =>
-      exitFromIpcResult({ ok: false, error: "Something went wrong", statusCode: 404 }),
+      exitFromIpcResult({
+        ok: false,
+        error: "Something went wrong",
+        statusCode: 404,
+      }),
     ).toThrow();
     expect(stderrSpy).toHaveBeenCalledWith("Something went wrong\n");
   });
 
   test("falls back to 'Unknown error' when error is undefined", () => {
     setupSpies();
-    expect(() =>
-      exitFromIpcResult({ ok: false }),
-    ).toThrow("exit:10");
+    expect(() => exitFromIpcResult({ ok: false })).toThrow("exit:10");
     expect(stderrSpy).toHaveBeenCalledWith("Unknown error\n");
   });
 });
@@ -97,7 +99,9 @@ describe("daemon-down message", () => {
     const { cliIpcCall } = await import("../cli-client.js");
     const r = await cliIpcCall("any_method", {}, { timeoutMs: 100 });
     expect(r.ok).toBe(false);
-    if (r.ok) return;
+    if (r.ok) {
+      return;
+    }
     expect(r.error).toContain("connect to the assistant at ");
     expect(r.error).toContain("assistant status");
   });

package/src/ipc/__tests__/streaming-client.test.ts

@@ -12,9 +12,10 @@ import { afterEach, describe, expect, mock, test } from "bun:test";
 // system socket (e.g. stale root-owned /run/assistant-ipc/assistant.sock).
 delete process.env.ASSISTANT_IPC_SOCKET_DIR;
 
+import { writeMessage } from "@vellumai/ipc-server-utils";
+
 import { AssistantIpcServer } from "../assistant-server.js";
 import { cliIpcCallBinary, cliIpcCallStream } from "../cli-client.js";
-import { writeMessage } from "../ipc-framing.js";
 
 // ---------------------------------------------------------------------------
 // Fixture routes
@@ -56,10 +57,20 @@ const SLOW_STREAM_FIXTURE_ROUTE = {
   handler: async (params: Record<string, unknown> | undefined) => {
     slowStreamAborted = false;
     const signal = (params as { abortSignal?: AbortSignal })?.abortSignal;
-    signal?.addEventListener("abort", () => { slowStreamAborted = true; }, { once: true });
+    signal?.addEventListener(
+      "abort",
+      () => {
+        slowStreamAborted = true;
+      },
+      { once: true },
+    );
     await new Promise((r) => setTimeout(r, 50));
     return {
-      stream: new ReadableStream<Uint8Array>({ start(ctrl) { ctrl.close(); } }),
+      stream: new ReadableStream<Uint8Array>({
+        start(ctrl) {
+          ctrl.close();
+        },
+      }),
       headers: {} as Record<string, string>,
     };
   },
@@ -84,10 +95,14 @@ const CANCEL_FIXTURE_ROUTE = {
             ctrl.error(new DOMException("Aborted", "AbortError"));
             return;
           }
-          signal?.addEventListener("abort", () => {
-            cancelAborted = true;
-            ctrl.error(new DOMException("Aborted", "AbortError"));
-          }, { once: true });
+          signal?.addEventListener(
+            "abort",
+            () => {
+              cancelAborted = true;
+              ctrl.error(new DOMException("Aborted", "AbortError"));
+            },
+            { once: true },
+          );
           // Hold open — no close() until aborted
         },
       }),
@@ -97,7 +112,12 @@ const CANCEL_FIXTURE_ROUTE = {
 };
 
 mock.module("../../runtime/routes/index.js", () => ({
-  ROUTES: [STREAM_FIXTURE_ROUTE, BINARY_FIXTURE_ROUTE, CANCEL_FIXTURE_ROUTE, SLOW_STREAM_FIXTURE_ROUTE],
+  ROUTES: [
+    STREAM_FIXTURE_ROUTE,
+    BINARY_FIXTURE_ROUTE,
+    CANCEL_FIXTURE_ROUTE,
+    SLOW_STREAM_FIXTURE_ROUTE,
+  ],
 }));
 
 // ---------------------------------------------------------------------------
@@ -128,13 +148,17 @@ describe("cliIpcCallStream", () => {
     await startServer();
     const r = await cliIpcCallStream("stream_fixture");
     expect(r.ok).toBe(true);
-    if (!r.ok) return;
+    if (!r.ok) {
+      return;
+    }
     expect(r.headers["x-fixture"]).toBe("streaming");
     // Drain the body to avoid resource leaks
     const reader = r.body.getReader();
     while (true) {
       const { done } = await reader.read();
-      if (done) break;
+      if (done) {
+        break;
+      }
     }
   });
 
@@ -142,14 +166,18 @@ describe("cliIpcCallStream", () => {
     await startServer();
     const r = await cliIpcCallStream("stream_fixture");
     expect(r.ok).toBe(true);
-    if (!r.ok) return;
+    if (!r.ok) {
+      return;
+    }
 
     const chunks: string[] = [];
     const reader = r.body.getReader();
     const dec = new TextDecoder();
     while (true) {
       const { done, value } = await reader.read();
-      if (done) break;
+      if (done) {
+        break;
+      }
       chunks.push(dec.decode(value));
     }
     expect(chunks.join("")).toBe("chunk1chunk2");
@@ -159,7 +187,9 @@ describe("cliIpcCallStream", () => {
     await startServer();
     const r = await cliIpcCallStream("cancel_fixture");
     expect(r.ok).toBe(true);
-    if (!r.ok) return;
+    if (!r.ok) {
+      return;
+    }
 
     const bodyReader = r.body.getReader();
     r.abort();
@@ -185,7 +215,9 @@ describe("cliIpcCallStream", () => {
     await startServer();
     const r = await cliIpcCallStream("cancel_fixture");
     expect(r.ok).toBe(true);
-    if (!r.ok) return;
+    if (!r.ok) {
+      return;
+    }
 
     // Cancel the ReadableStream body — the cancel() callback should call abort()
     // which sends $cancel on the wire and ends the socket.
@@ -204,7 +236,11 @@ describe("cliIpcCallStream", () => {
     // request, before slow_stream_fixture's 50ms handler delay expires.
     const rawSocket = new Socket();
     await new Promise<void>((res) => rawSocket.connect(socketPath, res));
-    writeMessage(rawSocket, { id: crypto.randomUUID(), method: "slow_stream_fixture", params: {} });
+    writeMessage(rawSocket, {
+      id: crypto.randomUUID(),
+      method: "slow_stream_fixture",
+      params: {},
+    });
     rawSocket.destroy();
 
     // Wait for the handler to complete and sendStreamingResponse to run
@@ -225,7 +261,9 @@ describe("cliIpcCallBinary", () => {
     await startServer();
     const r = await cliIpcCallBinary("binary_fixture");
     expect(r.ok).toBe(true);
-    if (!r.ok) return;
+    if (!r.ok) {
+      return;
+    }
     expect(new TextDecoder().decode(r.bytes)).toBe("hello");
     expect(r.headers["content-type"]).toBe("application/octet-stream");
   });

package/src/ipc/__tests__/streaming-framing.test.ts

@@ -4,7 +4,10 @@
 
 import { describe, expect, test } from "bun:test";
 
-import { IpcFrameReader, type StreamCallbacks } from "../ipc-framing.js";
+import {
+  IpcFrameReader,
+  type StreamCallbacks,
+} from "@vellumai/ipc-server-utils";
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -32,7 +35,10 @@ describe("IpcFrameReader", () => {
     const json = Buffer.from(JSON.stringify(envelope), "utf-8");
     const frame = buildFrame(json);
 
-    const received: Array<{ envelope: unknown; binary: Uint8Array | undefined }> = [];
+    const received: Array<{
+      envelope: unknown;
+      binary: Uint8Array | undefined;
+    }> = [];
 
     const reader = new IpcFrameReader((env, binary) => {
       received.push({ envelope: env, binary });
@@ -53,12 +59,17 @@ describe("IpcFrameReader", () => {
       result: "ok",
       headers: { "content-length": "5" },
     };
-    const jsonFrame = buildFrame(Buffer.from(JSON.stringify(envelope), "utf-8"));
+    const jsonFrame = buildFrame(
+      Buffer.from(JSON.stringify(envelope), "utf-8"),
+    );
     const binaryFrame = buildFrame(Buffer.from(binaryData));
 
     const allData = Buffer.concat([jsonFrame, binaryFrame]);
 
-    const received: Array<{ envelope: unknown; binary: Uint8Array | undefined }> = [];
+    const received: Array<{
+      envelope: unknown;
+      binary: Uint8Array | undefined;
+    }> = [];
 
     const reader = new IpcFrameReader((env, binary) => {
       received.push({ envelope: env, binary });
@@ -70,7 +81,9 @@ describe("IpcFrameReader", () => {
     expect(received[0].envelope).toEqual(envelope);
     expect(received[0].binary).toBeInstanceOf(Uint8Array);
     expect(received[0].binary).toHaveLength(5);
-    expect(Array.from(received[0].binary!)).toEqual([0x01, 0x02, 0x03, 0x04, 0x05]);
+    expect(Array.from(received[0].binary!)).toEqual([
+      0x01, 0x02, 0x03, 0x04, 0x05,
+    ]);
   });
 
   test("parses chunked stream (transfer-encoding: chunked)", () => {
@@ -81,12 +94,19 @@ describe("IpcFrameReader", () => {
       id: "req-3",
       headers: { "transfer-encoding": "chunked" },
     };
-    const jsonFrame = buildFrame(Buffer.from(JSON.stringify(envelope), "utf-8"));
+    const jsonFrame = buildFrame(
+      Buffer.from(JSON.stringify(envelope), "utf-8"),
+    );
     const chunk1Frame = buildFrame(Buffer.from(chunk1));
     const chunk2Frame = buildFrame(Buffer.from(chunk2));
     const terminator = buildTerminator();
 
-    const allData = Buffer.concat([jsonFrame, chunk1Frame, chunk2Frame, terminator]);
+    const allData = Buffer.concat([
+      jsonFrame,
+      chunk1Frame,
+      chunk2Frame,
+      terminator,
+    ]);
 
     const events: string[] = [];
     let startEnvelope: unknown = null;
@@ -127,7 +147,10 @@ describe("IpcFrameReader", () => {
     const legacyPayload = JSON.stringify({ id: "x", result: 1 }) + "\n";
     const buf = Buffer.from(legacyPayload, "utf-8");
 
-    const received: Array<{ envelope: unknown; binary: Uint8Array | undefined }> = [];
+    const received: Array<{
+      envelope: unknown;
+      binary: Uint8Array | undefined;
+    }> = [];
 
     const reader = new IpcFrameReader((env, binary) => {
       received.push({ envelope: env, binary });

package/src/ipc/__tests__/ui-request-route.test.ts

@@ -48,7 +48,9 @@ mock.module("../../daemon/conversation-surfaces.js", () => ({
     _request: unknown,
     _surfaceId: string,
   ) => {
-    if (mockSurfaceThrows) throw mockSurfaceThrows;
+    if (mockSurfaceThrows) {
+      throw mockSurfaceThrows;
+    }
     return mockSurfaceResult;
   },
 }));

package/src/ipc/__tests__/watcher-ipc.test.ts

@@ -136,7 +136,9 @@ describe("watcher IPC routes", () => {
 
     // Remove from cleanup tracking since we already deleted it.
     const idx = createdWatcherIds.indexOf(watcher.id);
-    if (idx >= 0) createdWatcherIds.splice(idx, 1);
+    if (idx >= 0) {
+      createdWatcherIds.splice(idx, 1);
+    }
 
     // Confirm gone
     const afterDelete = await cliIpcCall<Watcher[]>("watcher_list", {
@@ -271,7 +273,9 @@ describe("watcher IPC routes", () => {
 
     // Remove from cleanup tracking.
     const idx = createdWatcherIds.indexOf(watcher.id);
-    if (idx >= 0) createdWatcherIds.splice(idx, 1);
+    if (idx >= 0) {
+      createdWatcherIds.splice(idx, 1);
+    }
   });
 
   test("watcher_digest alias works identically to watcher/digest", async () => {

package/src/ipc/assistant-server.ts

@@ -31,7 +31,16 @@
 import { existsSync, unlinkSync } from "node:fs";
 import { createServer, type Server, type Socket } from "node:net";
 
-import { ensureSocketDir, SocketWatchdog } from "@vellumai/ipc-server-utils";
+import {
+  ensureSocketDir,
+  type IpcEnvelope,
+  IpcFrameReader,
+  SocketWatchdog,
+  writeLegacyMessage,
+  writeMessage,
+  writeStreamChunk,
+  writeStreamEnd,
+} from "@vellumai/ipc-server-utils";
 
 import {
   getDbMigrationReadiness,
@@ -47,14 +56,6 @@ import type {
 } from "../runtime/routes/types.js";
 import { RouteResponse } from "../runtime/routes/types.js";
 import { getLogger } from "../util/logger.js";
-import {
-  type IpcEnvelope,
-  IpcFrameReader,
-  writeLegacyMessage,
-  writeMessage,
-  writeStreamChunk,
-  writeStreamEnd,
-} from "./ipc-framing.js";
 import { CONTACTS_INFO_IPC_METHODS } from "./routes/contacts-info-ipc-routes.js";
 import { CONTACTS_MIRROR_IPC_METHODS } from "./routes/contacts-mirror-ipc-routes.js";
 import { CONVERSATION_SYNC_IPC_METHODS } from "./routes/conversation-sync-ipc-routes.js";
@@ -385,8 +386,6 @@ export class AssistantIpcServer {
       return;
     }
 
-    void binary;
-
     // Skip AbortController for the $cancel meta-method itself
     const needsAbortTracking = req.method !== "$cancel";
     let abortController: AbortController | undefined;
@@ -398,6 +397,11 @@ export class AssistantIpcServer {
     try {
       const handlerArgs = {
         ...injectLocalActorHeader(req.params),
+        // A binary frame on the request is the caller's raw body. Route
+        // handlers already model this as `rawBody` and pass it through
+        // untouched, so a caller that sends bytes gets them delivered as
+        // bytes rather than having them re-encoded as JSON.
+        ...(binary && { rawBody: binary }),
         ...(abortController && { abortSignal: abortController.signal }),
       };
       const result = handler(handlerArgs);
@@ -451,9 +455,13 @@ export class AssistantIpcServer {
     id: string,
   ): IpcResponse | null {
     // `$cancel` only aborts an in-flight request and never reads the DB.
-    if (method === "$cancel" || isDbMigrationGateBypassed(method)) return null;
+    if (method === "$cancel" || isDbMigrationGateBypassed(method)) {
+      return null;
+    }
     const readiness = getDbMigrationReadiness();
-    if (readiness.ready) return null;
+    if (readiness.ready) {
+      return null;
+    }
     return {
       id,
       error: `Database migrations ${readiness.state}; IPC method '${method}' is temporarily unavailable`,