@useatlas/create 0.0.1 → 0.0.3

package/templates/nextjs-standalone/src/lib/tools/__tests__/explore-nsjail.test.ts

@@ -1,10 +1,33 @@
-import { describe, expect, it, beforeEach, afterEach, spyOn } from "bun:test";
+import { describe, expect, it, beforeEach, afterEach, spyOn, mock } from "bun:test";
 import * as fs from "fs";
 
 // ---------------------------------------------------------------------------
 // Mocks
 // ---------------------------------------------------------------------------
 
+// Mock structured logger — must be before explore-nsjail import
+let logWarnCalls: unknown[][] = [];
+let logErrorCalls: unknown[][] = [];
+
+const mockLogger = {
+  info: () => {},
+  warn: (...args: unknown[]) => { logWarnCalls.push(args); },
+  error: (...args: unknown[]) => { logErrorCalls.push(args); },
+  debug: () => {},
+  fatal: () => {},
+  trace: () => {},
+  child: () => mockLogger,
+  level: "info",
+};
+
+mock.module("@atlas/api/lib/logger", () => ({
+  createLogger: () => mockLogger,
+  getLogger: () => mockLogger,
+  withRequestContext: (_ctx: unknown, fn: () => unknown) => fn(),
+  getRequestContext: () => undefined,
+  redactPaths: [],
+}));
+
 // Track Bun.spawn calls
 let spawnCalls: { args: unknown[]; options: unknown }[] = [];
 let spawnResult: {
@@ -50,7 +73,8 @@ const callbacks = {
   },
 };
 
-import { isNsjailAvailable, createNsjailBackend, testNsjailCapabilities } from "@atlas/api/lib/tools/explore-nsjail";
+const { isNsjailAvailable, createNsjailBackend, testNsjailCapabilities } =
+  await import("@atlas/api/lib/tools/explore-nsjail");
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -145,6 +169,8 @@ describe("exec", () => {
     spawnCalls = [];
     invalidateCalled = false;
     markFailedCalled = false;
+    logWarnCalls = [];
+    logErrorCalls = [];
     setSpawnResult("", "", 0);
   });
 
@@ -311,8 +337,6 @@ describe("exec", () => {
       new Set(["/usr/local/bin/nsjail", SEMANTIC_ROOT]),
     );
 
-    const warnSpy = spyOn(console, "warn").mockImplementation(() => {});
-
     const backend = await createNsjailBackend(SEMANTIC_ROOT, callbacks);
     await backend.exec("ls");
 
@@ -320,7 +344,6 @@ describe("exec", () => {
     const tIndex = args.indexOf("-t");
     expect(args[tIndex + 1]).toBe("10"); // default
 
-    warnSpy.mockRestore();
     spy.mockRestore();
   });
 
@@ -331,8 +354,6 @@ describe("exec", () => {
       new Set(["/usr/local/bin/nsjail", SEMANTIC_ROOT]),
     );
 
-    const warnSpy = spyOn(console, "warn").mockImplementation(() => {});
-
     const backend = await createNsjailBackend(SEMANTIC_ROOT, callbacks);
     await backend.exec("ls");
 
@@ -340,7 +361,6 @@ describe("exec", () => {
     const tIndex = args.indexOf("-t");
     expect(args[tIndex + 1]).toBe("10"); // default
 
-    warnSpy.mockRestore();
     spy.mockRestore();
   });
 
@@ -351,8 +371,6 @@ describe("exec", () => {
       new Set(["/usr/local/bin/nsjail", SEMANTIC_ROOT]),
     );
 
-    const warnSpy = spyOn(console, "warn").mockImplementation(() => {});
-
     const backend = await createNsjailBackend(SEMANTIC_ROOT, callbacks);
     await backend.exec("ls");
 
@@ -360,7 +378,6 @@ describe("exec", () => {
     const memIndex = args.indexOf("--rlimit_as");
     expect(args[memIndex + 1]).toBe("256"); // default
 
-    warnSpy.mockRestore();
     spy.mockRestore();
   });
 
@@ -371,7 +388,6 @@ describe("exec", () => {
     );
 
     setSpawnResult("", "nsjail setup failure", 109);
-    const errorSpy = spyOn(console, "error").mockImplementation(() => {});
 
     const backend = await createNsjailBackend(SEMANTIC_ROOT, callbacks);
     const result = await backend.exec("ls");
@@ -379,7 +395,6 @@ describe("exec", () => {
     expect(result.exitCode).toBe(109);
     expect(markFailedCalled).toBe(true);
 
-    errorSpy.mockRestore();
     spy.mockRestore();
   });
 
@@ -391,17 +406,16 @@ describe("exec", () => {
 
     // Exit code 137 = 128 + 9 (SIGKILL)
     setSpawnResult("", "", 137);
-    const warnSpy = spyOn(console, "warn").mockImplementation(() => {});
 
     const backend = await createNsjailBackend(SEMANTIC_ROOT, callbacks);
     const result = await backend.exec("sleep 999");
 
     expect(result.exitCode).toBe(137);
-    expect(warnSpy).toHaveBeenCalled();
-    const warnMsg = warnSpy.mock.calls[0]?.[0] as string;
-    expect(warnMsg).toContain("signal 9");
+    // log.warn({ signal, command }, "nsjail child killed by signal")
+    expect(logWarnCalls.length).toBeGreaterThanOrEqual(1);
+    const warnObj = logWarnCalls[0][0] as { signal: number };
+    expect(warnObj.signal).toBe(9);
 
-    warnSpy.mockRestore();
     spy.mockRestore();
   });
 });

package/templates/nextjs-standalone/src/lib/tools/__tests__/explore-plugin.test.ts

@@ -67,7 +67,7 @@ mock.module("@atlas/api/lib/plugins/hooks", () => ({
 
 let mockSandboxPlugins: Array<{
   id: string;
-  type: string;
+  types: string[];
   version: string;
   sandbox: {
     create(root: string): Promise<ExploreBackend> | ExploreBackend;
@@ -146,7 +146,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "plugin-a",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: { create: async () => backend },
       },
@@ -165,7 +165,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "low-priority",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => makeMockBackend("low"),
@@ -174,7 +174,7 @@ describe("explore sandbox plugin integration", () => {
       },
       {
         id: "high-priority",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => makeMockBackend("high"),
@@ -196,7 +196,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "broken-plugin",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => { throw new Error("init failed"); },
@@ -205,7 +205,7 @@ describe("explore sandbox plugin integration", () => {
       },
       {
         id: "working-plugin",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => makeMockBackend("working"),
@@ -228,7 +228,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "broken-1",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => { throw new Error("fail 1"); },
@@ -236,7 +236,7 @@ describe("explore sandbox plugin integration", () => {
       },
       {
         id: "broken-2",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => { throw new Error("fail 2"); },
@@ -255,7 +255,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "my-sandbox",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "2.0.0",
         sandbox: { create: async () => makeMockBackend("my-sandbox") },
       },
@@ -274,7 +274,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "test-plugin",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: { create: async () => makeMockBackend("test") },
       },
@@ -297,7 +297,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "clearable-plugin",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: { create: async () => makeMockBackend("clearable") },
       },
@@ -321,7 +321,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "should-be-skipped",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: { create: async () => makeMockBackend("skipped") },
       },
@@ -343,7 +343,7 @@ describe("explore sandbox plugin integration", () => {
     mockSandboxPlugins = [
       {
         id: "explicit-low",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           create: async () => makeMockBackend("explicit-low"),
@@ -352,7 +352,7 @@ describe("explore sandbox plugin integration", () => {
       },
       {
         id: "default-priority",
-        type: "sandbox",
+        types: ["sandbox"],
         version: "1.0.0",
         sandbox: {
           // No priority — defaults to 60 (SANDBOX_DEFAULT_PRIORITY)

package/templates/nextjs-standalone/src/lib/tools/__tests__/explore-sdk-compat.test.ts

@@ -7,7 +7,7 @@
  * assertions will fail at compile time.
  *
  * Both types are defined in this file to avoid a cross-package import
- * (@atlas/api does not depend on @atlas/plugin-sdk by design).
+ * (@atlas/api does not depend on @useatlas/plugin-sdk by design).
  */
 import { describe, test, expect } from "bun:test";
 import type { ExecResult, ExploreBackend } from "../explore";

package/templates/nextjs-standalone/src/lib/tools/__tests__/explore-sidecar.test.ts

@@ -70,10 +70,12 @@ describe("sidecar exec", () => {
     expect(result.stderr).toBe("");
     expect(result.exitCode).toBe(0);
 
-    expect(fetchCalls).toHaveLength(1);
-    expect(fetchCalls[0].url).toBe("http://localhost:8080/exec");
+    // Filter out the health check call made during createSidecarBackend init
+    const execCalls = fetchCalls.filter((c) => c.url.endsWith("/exec"));
+    expect(execCalls).toHaveLength(1);
+    expect(execCalls[0].url).toBe("http://localhost:8080/exec");
 
-    const body = JSON.parse(fetchCalls[0].options.body as string);
+    const body = JSON.parse(execCalls[0].options.body as string);
     expect(body.command).toBe("ls");
     expect(body.timeout).toBe(10_000);
   });