@uluops/setup 0.4.0 → 0.6.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +21 -0
- package/README.md +67 -50
- package/assets/auto-tracker-save.mjs +142 -0
- package/assets/{agents → claude-code/agents}/api-contract-validator-agent.md +9 -228
- package/assets/{agents → claude-code/agents}/aristotle-analyst-agent.md +51 -4
- package/assets/{agents → claude-code/agents}/aristotle-explorer-agent.md +6 -2
- package/assets/{agents → claude-code/agents}/aristotle-forecaster-agent.md +15 -230
- package/assets/{agents → claude-code/agents}/aristotle-validator-agent.md +12 -252
- package/assets/{agents → claude-code/agents}/assumption-excavator-agent.md +21 -247
- package/assets/{agents → claude-code/agents}/code-auditor-agent.md +12 -255
- package/assets/{agents → claude-code/agents}/code-optimizer-agent.md +15 -236
- package/assets/{agents → claude-code/agents}/code-validator-agent.md +31 -300
- package/assets/claude-code/agents/docs-validator-agent.md +472 -0
- package/assets/{agents → claude-code/agents}/frontend-validator-agent.md +15 -258
- package/assets/{agents → claude-code/agents}/mcp-validator-agent.md +8 -252
- package/assets/{agents → claude-code/agents}/pre-implementation-architect-agent.md +8 -224
- package/assets/{agents → claude-code/agents}/prompt-engineer-agent.md +57 -290
- package/assets/{agents → claude-code/agents}/prompt-pattern-analyzer-agent.md +10 -225
- package/assets/{agents → claude-code/agents}/prompt-quality-validator-agent.md +11 -249
- package/assets/{agents → claude-code/agents}/public-interface-validator-agent.md +15 -268
- package/assets/claude-code/agents/release-readiness-agent.md +495 -0
- package/assets/{agents → claude-code/agents}/security-analyst-agent.md +236 -480
- package/assets/{agents → claude-code/agents}/test-architect-agent.md +16 -259
- package/assets/{agents → claude-code/agents}/type-safety-validator-agent.md +23 -266
- package/assets/{agents → claude-code/agents}/workflow-synthesis-agent.md +23 -226
- package/assets/{commands → claude-code/commands}/agents/anxiety-reader.md +12 -15
- package/assets/{commands → claude-code/commands}/agents/api-contract.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/architect.md +156 -136
- package/assets/claude-code/commands/agents/aristotle-analyst.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-explorer.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-forecaster.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-validator.md +157 -0
- package/assets/{commands → claude-code/commands}/agents/assumption-excavator.md +49 -7
- package/assets/{commands → claude-code/commands}/agents/audit.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/docs-validate.md +156 -134
- package/assets/{commands → claude-code/commands}/agents/frontend.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/mcp-validate.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/optimize.md +156 -134
- package/assets/{commands → claude-code/commands}/agents/pattern-analyzer.md +150 -127
- package/assets/{commands → claude-code/commands}/agents/prompt-quality.md +155 -135
- package/assets/claude-code/commands/agents/prompt-validate.md +155 -0
- package/assets/{commands → claude-code/commands}/agents/public-interface.md +156 -135
- package/assets/{commands → claude-code/commands}/agents/release.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/security.md +156 -138
- package/assets/{commands → claude-code/commands}/agents/test-review.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/type-safety.md +156 -136
- package/assets/{commands/agents/code-validate.md → claude-code/commands/agents/validate.md} +156 -135
- package/assets/claude-code/commands/agents/workflow-synthesis.md +157 -0
- package/assets/{commands → claude-code/commands}/pipelines/aristotle.md +8 -8
- package/assets/{commands → claude-code/commands}/pipelines/ship.md +8 -8
- package/assets/claude-code/commands/workflows/post-implementation.md +60 -0
- package/assets/claude-code/commands/workflows/pre-implementation.md +46 -0
- package/assets/{commands → claude-code/commands}/workflows/prompt-audit.md +2 -2
- package/assets/codex/agents/anxiety-reader-agent.toml +462 -0
- package/assets/codex/agents/api-contract-validator-agent.toml +738 -0
- package/assets/codex/agents/aristotle-analyst-agent.toml +750 -0
- package/assets/codex/agents/aristotle-explorer-agent.toml +155 -0
- package/assets/codex/agents/aristotle-forecaster-agent.toml +449 -0
- package/assets/codex/agents/aristotle-validator-agent.toml +424 -0
- package/assets/codex/agents/assumption-excavator-agent.toml +1126 -0
- package/assets/codex/agents/code-auditor-agent.toml +815 -0
- package/assets/codex/agents/code-optimizer-agent.toml +652 -0
- package/assets/codex/agents/code-validator-agent.toml +573 -0
- package/assets/codex/agents/docs-validator-agent.toml +468 -0
- package/assets/codex/agents/frontend-validator-agent.toml +598 -0
- package/assets/codex/agents/mcp-validator-agent.toml +580 -0
- package/assets/codex/agents/pre-implementation-architect-agent.toml +817 -0
- package/assets/codex/agents/prompt-engineer-agent.toml +922 -0
- package/assets/codex/agents/prompt-pattern-analyzer-agent.toml +689 -0
- package/assets/codex/agents/prompt-quality-validator-agent.toml +777 -0
- package/assets/codex/agents/public-interface-validator-agent.toml +695 -0
- package/assets/codex/agents/release-readiness-agent.toml +491 -0
- package/assets/codex/agents/security-analyst-agent.toml +847 -0
- package/assets/codex/agents/test-architect-agent.toml +615 -0
- package/assets/codex/agents/type-safety-validator-agent.toml +686 -0
- package/assets/codex/agents/workflow-synthesis-agent.toml +631 -0
- package/assets/gemini-cli/agents/anxiety-reader-agent.md +470 -0
- package/assets/gemini-cli/agents/api-contract-validator-agent.md +747 -0
- package/assets/gemini-cli/agents/aristotle-analyst-agent.md +758 -0
- package/assets/gemini-cli/agents/aristotle-explorer-agent.md +163 -0
- package/assets/gemini-cli/agents/aristotle-forecaster-agent.md +457 -0
- package/assets/gemini-cli/agents/aristotle-validator-agent.md +432 -0
- package/assets/gemini-cli/agents/assumption-excavator-agent.md +1134 -0
- package/assets/gemini-cli/agents/code-auditor-agent.md +827 -0
- package/assets/gemini-cli/agents/code-optimizer-agent.md +661 -0
- package/assets/gemini-cli/agents/code-validator-agent.md +582 -0
- package/assets/gemini-cli/agents/docs-validator-agent.md +477 -0
- package/assets/gemini-cli/agents/frontend-validator-agent.md +610 -0
- package/assets/gemini-cli/agents/mcp-validator-agent.md +589 -0
- package/assets/gemini-cli/agents/pre-implementation-architect-agent.md +826 -0
- package/assets/gemini-cli/agents/prompt-engineer-agent.md +931 -0
- package/assets/gemini-cli/agents/prompt-pattern-analyzer-agent.md +698 -0
- package/assets/gemini-cli/agents/prompt-quality-validator-agent.md +786 -0
- package/assets/gemini-cli/agents/public-interface-validator-agent.md +707 -0
- package/assets/gemini-cli/agents/release-readiness-agent.md +500 -0
- package/assets/gemini-cli/agents/security-analyst-agent.md +859 -0
- package/assets/gemini-cli/agents/test-architect-agent.md +624 -0
- package/assets/gemini-cli/agents/type-safety-validator-agent.md +695 -0
- package/assets/gemini-cli/agents/workflow-synthesis-agent.md +639 -0
- package/assets/gemini-cli/commands/agents/anxiety-reader.toml +155 -0
- package/assets/gemini-cli/commands/agents/api-contract.toml +154 -0
- package/assets/gemini-cli/commands/agents/architect.toml +154 -0
- package/assets/gemini-cli/commands/agents/aristotle-analyst.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-explorer.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-forecaster.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-validator.toml +155 -0
- package/assets/gemini-cli/commands/agents/assumption-excavator.toml +155 -0
- package/assets/gemini-cli/commands/agents/audit.toml +154 -0
- package/assets/gemini-cli/commands/agents/docs-validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/frontend.toml +154 -0
- package/assets/gemini-cli/commands/agents/mcp-validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/optimize.toml +154 -0
- package/assets/gemini-cli/commands/agents/pattern-analyzer.toml +148 -0
- package/assets/gemini-cli/commands/agents/prompt-quality.toml +153 -0
- package/assets/gemini-cli/commands/agents/prompt-validate.toml +153 -0
- package/assets/gemini-cli/commands/agents/public-interface.toml +154 -0
- package/assets/gemini-cli/commands/agents/release.toml +154 -0
- package/assets/gemini-cli/commands/agents/security.toml +154 -0
- package/assets/gemini-cli/commands/agents/test-review.toml +154 -0
- package/assets/gemini-cli/commands/agents/type-safety.toml +154 -0
- package/assets/gemini-cli/commands/agents/validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/workflow-synthesis.toml +155 -0
- package/assets/gemini-cli/commands/pipelines/aristotle.toml +139 -0
- package/assets/gemini-cli/commands/pipelines/ship.toml +184 -0
- package/assets/gemini-cli/commands/workflows/post-implementation.toml +56 -0
- package/assets/gemini-cli/commands/workflows/pre-implementation.toml +42 -0
- package/assets/gemini-cli/commands/workflows/prompt-audit.toml +40 -0
- package/assets/opencode/agents/anxiety-reader-agent.md +472 -0
- package/assets/opencode/agents/api-contract-validator-agent.md +749 -0
- package/assets/opencode/agents/aristotle-analyst-agent.md +760 -0
- package/assets/opencode/agents/aristotle-explorer-agent.md +164 -0
- package/assets/opencode/agents/aristotle-forecaster-agent.md +459 -0
- package/assets/opencode/agents/aristotle-validator-agent.md +434 -0
- package/assets/opencode/agents/assumption-excavator-agent.md +1136 -0
- package/assets/opencode/agents/code-auditor-agent.md +826 -0
- package/assets/opencode/agents/code-optimizer-agent.md +663 -0
- package/assets/opencode/agents/code-validator-agent.md +584 -0
- package/assets/opencode/agents/docs-validator-agent.md +479 -0
- package/assets/opencode/agents/frontend-validator-agent.md +609 -0
- package/assets/opencode/agents/mcp-validator-agent.md +591 -0
- package/assets/opencode/agents/pre-implementation-architect-agent.md +828 -0
- package/assets/opencode/agents/prompt-engineer-agent.md +933 -0
- package/assets/opencode/agents/prompt-pattern-analyzer-agent.md +700 -0
- package/assets/opencode/agents/prompt-quality-validator-agent.md +788 -0
- package/assets/opencode/agents/public-interface-validator-agent.md +706 -0
- package/assets/opencode/agents/release-readiness-agent.md +502 -0
- package/assets/opencode/agents/security-analyst-agent.md +858 -0
- package/assets/opencode/agents/test-architect-agent.md +626 -0
- package/assets/opencode/agents/type-safety-validator-agent.md +697 -0
- package/assets/opencode/agents/workflow-synthesis-agent.md +641 -0
- package/dist/cli.js +12 -414
- package/dist/commands/helpers.d.ts +73 -0
- package/dist/commands/helpers.js +274 -0
- package/dist/commands/setup.d.ts +13 -0
- package/dist/commands/setup.js +93 -0
- package/dist/commands/uninstall.d.ts +3 -0
- package/dist/commands/uninstall.js +126 -0
- package/dist/commands/verify.d.ts +1 -0
- package/dist/commands/verify.js +28 -0
- package/dist/harnesses/claude-code.d.ts +1 -1
- package/dist/harnesses/claude-code.js +3 -1
- package/dist/harnesses/codex.js +6 -5
- package/dist/harnesses/gemini-cli.d.ts +4 -8
- package/dist/harnesses/gemini-cli.js +47 -21
- package/dist/harnesses/index.d.ts +10 -1
- package/dist/harnesses/index.js +11 -2
- package/dist/harnesses/opencode.d.ts +1 -1
- package/dist/harnesses/opencode.js +15 -6
- package/dist/harnesses/types.d.ts +19 -0
- package/dist/harnesses/types.js +2 -0
- package/dist/lib/asset-catalog.js +2 -2
- package/dist/lib/config-merger.d.ts +2 -1
- package/dist/lib/config-merger.js +12 -4
- package/dist/lib/file-ops.d.ts +5 -0
- package/dist/lib/file-ops.js +18 -3
- package/dist/lib/hash.d.ts +1 -1
- package/dist/lib/hash.js +2 -2
- package/dist/lib/manifest.d.ts +30 -1
- package/dist/lib/manifest.js +5 -7
- package/dist/lib/paths.d.ts +16 -1
- package/dist/lib/paths.js +31 -3
- package/dist/lib/settings-merger.d.ts +24 -9
- package/dist/lib/settings-merger.js +57 -22
- package/dist/lib/version.d.ts +2 -0
- package/dist/lib/version.js +10 -0
- package/dist/steps/agents.d.ts +1 -2
- package/dist/steps/agents.js +7 -18
- package/dist/steps/cli.d.ts +53 -0
- package/dist/steps/cli.js +90 -0
- package/dist/steps/commands.d.ts +1 -1
- package/dist/steps/commands.js +20 -71
- package/dist/steps/detect.js +4 -0
- package/dist/steps/mcp.js +7 -15
- package/dist/steps/metrics.d.ts +12 -0
- package/dist/steps/metrics.js +52 -22
- package/dist/steps/shell.js +11 -1
- package/dist/steps/signup.d.ts +2 -2
- package/dist/steps/signup.js +9 -12
- package/dist/steps/verify.js +47 -8
- package/package.json +12 -11
- package/assets/agents/docs-validator-agent.md +0 -490
- package/assets/agents/release-readiness-agent.md +0 -482
- package/assets/commands/agents/aristotle-analyst.md +0 -116
- package/assets/commands/agents/aristotle-explorer.md +0 -93
- package/assets/commands/agents/aristotle-forecaster.md +0 -115
- package/assets/commands/agents/aristotle-validator.md +0 -115
- package/assets/commands/agents/prompt-validate.md +0 -136
- package/assets/commands/agents/workflow-synthesis.md +0 -102
- package/assets/commands/workflows/post-implementation.md +0 -577
- package/assets/commands/workflows/pre-implementation.md +0 -670
- /package/assets/{agents → claude-code/agents}/anxiety-reader-agent.md +0 -0
|
@@ -1,12 +1,9 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: code-auditor
|
|
3
|
-
version: "2.
|
|
3
|
+
version: "2.4.0"
|
|
4
4
|
description: Deep inspection for runtime correctness issues that pass compilation, linting, and tests but could fail in production. Focuses on async safety, null handling, error propagation, and edge cases. Use as FINAL gate in ship workflow. Catches the bugs that will wake someone up at 3 AM.
|
|
5
|
-
|
|
6
5
|
tools: Read, Grep, Glob, Bash
|
|
7
6
|
model: opus
|
|
8
|
-
adl_schema: /home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/code-auditor.agent.yaml
|
|
9
|
-
taxonomy_version: "0.2.2"
|
|
10
7
|
threshold: 80
|
|
11
8
|
auto_fail_severity: [critical, high]
|
|
12
9
|
---
|
|
@@ -44,6 +41,12 @@ Every issue you identify MUST include a failure classification code from the tax
|
|
|
44
41
|
- Do NOT accept 'AUDIT-OK' comments without verifying the justification is valid
|
|
45
42
|
|
|
46
43
|
|
|
44
|
+
### Epistemic Nature
|
|
45
|
+
- **Verifiability:** Mechanically Checkable
|
|
46
|
+
- **Determinism:** Stochastic
|
|
47
|
+
- **Claim Type:** Factual
|
|
48
|
+
|
|
49
|
+
|
|
47
50
|
## Reference Examples
|
|
48
51
|
|
|
49
52
|
Use these examples to calibrate your judgment.
|
|
@@ -354,40 +357,6 @@ Use these examples to classify issues with the correct failure codes:
|
|
|
354
357
|
Domain: Semantic (type handling) Mode: INC (Inconsistency - zero treated as falsy) Severity: H (High - valid value incorrectly rejected)
|
|
355
358
|
|
|
356
359
|
|
|
357
|
-
## Failure Taxonomy Reference
|
|
358
|
-
|
|
359
|
-
Compact format: `DOMAIN-MODE/SEVERITY` where:
|
|
360
|
-
- **Domain:** STR (Structural), SEM (Semantic), PRA (Pragmatic), EPI (Epistemic)
|
|
361
|
-
- **Mode:** 3-letter code (e.g., OMI=Omission, EXC=Excess, INC=Inconsistency, AMB=Ambiguity)
|
|
362
|
-
- **Severity:** C (Critical), H (High), M (Medium), L (Low), I (Info)
|
|
363
|
-
|
|
364
|
-
### Domain Reference
|
|
365
|
-
| Code | Domain | Description |
|
|
366
|
-
|------|--------|-------------|
|
|
367
|
-
| STR | Structural | Form, syntax, organization issues |
|
|
368
|
-
| SEM | Semantic | Meaning, correctness, completeness issues |
|
|
369
|
-
| PRA | Pragmatic | Practical effectiveness, efficiency issues |
|
|
370
|
-
| EPI | Epistemic | Knowledge, claims, confidence issues |
|
|
371
|
-
|
|
372
|
-
### Common Mode Codes
|
|
373
|
-
| Code | Mode | Domain | Meaning |
|
|
374
|
-
|------|------|--------|---------|
|
|
375
|
-
| OMI | Omission | STR | Missing required element |
|
|
376
|
-
| EXC | Excess | STR | Unnecessary/redundant element |
|
|
377
|
-
| MAL | Malformation | STR | Incorrectly structured |
|
|
378
|
-
| INC | Inconsistency | STR/SEM | Internal contradictions |
|
|
379
|
-
| COM | Incompleteness | SEM | Partial implementation |
|
|
380
|
-
| AMB | Ambiguity | SEM | Unclear meaning |
|
|
381
|
-
| COH | Incoherence | SEM | Logical disconnect |
|
|
382
|
-
| ALI | Misalignment | PRA | Doesn't match requirements |
|
|
383
|
-
| MAT | Mismatch | PRA | Interface/contract violation |
|
|
384
|
-
| EFF | Inefficiency | PRA | Performance issues |
|
|
385
|
-
| FRA | Fragility | PRA | Brittleness, poor error handling |
|
|
386
|
-
| OVR | Overclaiming | EPI | Claims exceed evidence |
|
|
387
|
-
| UND | Underclaiming | EPI | Evidence exceeds claims |
|
|
388
|
-
| GRN | Granularity | EPI | Wrong level of detail |
|
|
389
|
-
| FAL | Fallacy | EPI | Logical reasoning error |
|
|
390
|
-
|
|
391
360
|
## Code Auditor Framework
|
|
392
361
|
|
|
393
362
|
### Category Overview
|
|
@@ -423,16 +392,16 @@ Each criterion has a default failure code—use it when that criterion fails.
|
|
|
423
392
|
- [ ] Errors propagate to actionable handlers (4 pts) `→ SEM-COM/H` *Verify:* Errors reach handlers that log, return message, retry, or exit, No catch blocks that neither rethrow nor indicate error
|
|
424
393
|
|
|
425
394
|
### 4. Data Integrity (15 points)
|
|
426
|
-
- [ ] No truthy checks on potentially-zero values (5 pts) `→ SEM-
|
|
395
|
+
- [ ] No truthy checks on potentially-zero values (5 pts) `→ SEM-LOG/H` *Verify:* Numeric values checked with !== undefined or != null, No if (value) where value could be 0
|
|
427
396
|
- [ ] JSON.parse has try/catch (4 pts) `→ SEM-COM/C` *Verify:* Every JSON.parse call wrapped in try/catch, Safe parser used for external data
|
|
428
397
|
- [ ] No mutation of shared state (3 pts) `→ SEM-INC/H` *Verify:* Objects passed between functions cloned before modification, Arrays cloned before push/pop/splice on parameters
|
|
429
|
-
- [ ] Type coercion handled explicitly (3 pts) `→ SEM-
|
|
398
|
+
- [ ] Type coercion handled explicitly (3 pts) `→ SEM-TYP/M` *Verify:* String-to-number uses parseInt/parseFloat with validation, No implicit type coercion (use === not ==)
|
|
430
399
|
|
|
431
400
|
### 5. API Boundary Safety (15 points)
|
|
432
401
|
- [ ] HTTP responses validated (5 pts) `→ SEM-COM/H` *Verify:* response.ok or response.status checked before body access, Non-2xx responses throw or return error object
|
|
433
402
|
- [ ] External data validated before use (4 pts) `→ SEM-COM/H` *Verify:* API responses validated via Zod, yup, or manual checks, Destructuring external data uses defaults
|
|
434
403
|
- [ ] Timeout handling present (3 pts) `→ SEM-COM/M` *Verify:* Network calls have timeout (AbortController, axios timeout), Long operations have timeout or progress indication
|
|
435
|
-
- [ ] Retry logic is safe (3 pts) `→ SEM-
|
|
404
|
+
- [ ] Retry logic is safe (3 pts) `→ SEM-LOG/H` *Verify:* Retries have exponential backoff and max attempts, POST/PUT/DELETE not retried unless idempotent
|
|
436
405
|
|
|
437
406
|
**Total Score: /100**
|
|
438
407
|
|
|
@@ -530,6 +499,7 @@ Before finalizing your decision, verify:
|
|
|
530
499
|
|
|
531
500
|
- **Target:** ~3500 tokens
|
|
532
501
|
- **Maximum:** 8000 tokens
|
|
502
|
+
|
|
533
503
|
Target ~3500 tokens for typical audits. Include actual code snippets for all findings. Expand for larger codebases with many issues. Critical issues warrant detailed explanation.
|
|
534
504
|
|
|
535
505
|
|
|
@@ -621,177 +591,7 @@ OR
|
|
|
621
591
|
|
|
622
592
|
Reasoning: [Explain decision]
|
|
623
593
|
|
|
624
|
-
|
|
625
|
-
|
|
626
|
-
<!-- Machine-readable output for API consumption and validation-tracker integration -->
|
|
627
|
-
<!-- Schema: udl/agent-output-schema-v1.4.json -->
|
|
628
|
-
```json
|
|
629
|
-
{
|
|
630
|
-
"schema_version": "1.3.0",
|
|
631
|
-
"validator": {
|
|
632
|
-
"name": "code-auditor",
|
|
633
|
-
"model": "opus",
|
|
634
|
-
"adl_schema": "/home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/code-auditor.agent.yaml",
|
|
635
|
-
"tokens": {
|
|
636
|
-
"input_tokens": 0,
|
|
637
|
-
"output_tokens": 0
|
|
638
|
-
}
|
|
639
|
-
},
|
|
640
|
-
"target": "[path/to/validated/directory]",
|
|
641
|
-
"timestamp": "[ISO 8601 timestamp]",
|
|
642
|
-
"result": {
|
|
643
|
-
"score": "[X]",
|
|
644
|
-
"max_score": 100,
|
|
645
|
-
"decision": "[SOUND|REVIEW|UNSOUND]",
|
|
646
|
-
"threshold": 80
|
|
647
|
-
},
|
|
648
|
-
"categories": [
|
|
649
|
-
{
|
|
650
|
-
"name": "Async Safety",
|
|
651
|
-
"score": "[X]",
|
|
652
|
-
"max_points": 25,
|
|
653
|
-
"findings": [
|
|
654
|
-
{
|
|
655
|
-
"criterion": "[criterion name from framework]",
|
|
656
|
-
"points_earned": "[X]",
|
|
657
|
-
"points_possible": "[X]",
|
|
658
|
-
"issues": [
|
|
659
|
-
{
|
|
660
|
-
"title": "[Short issue title]",
|
|
661
|
-
"priority": "[critical|suggested|backlog]",
|
|
662
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
663
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
664
|
-
"file_path": "[path/to/file]",
|
|
665
|
-
"line_number": "[N]",
|
|
666
|
-
"description": "[Full explanation]"
|
|
667
|
-
}
|
|
668
|
-
]
|
|
669
|
-
}
|
|
670
|
-
]
|
|
671
|
-
},
|
|
672
|
-
{
|
|
673
|
-
"name": "Null/Undefined Safety",
|
|
674
|
-
"score": "[X]",
|
|
675
|
-
"max_points": 25,
|
|
676
|
-
"findings": [
|
|
677
|
-
{
|
|
678
|
-
"criterion": "[criterion name from framework]",
|
|
679
|
-
"points_earned": "[X]",
|
|
680
|
-
"points_possible": "[X]",
|
|
681
|
-
"issues": [
|
|
682
|
-
{
|
|
683
|
-
"title": "[Short issue title]",
|
|
684
|
-
"priority": "[critical|suggested|backlog]",
|
|
685
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
686
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
687
|
-
"file_path": "[path/to/file]",
|
|
688
|
-
"line_number": "[N]",
|
|
689
|
-
"description": "[Full explanation]"
|
|
690
|
-
}
|
|
691
|
-
]
|
|
692
|
-
}
|
|
693
|
-
]
|
|
694
|
-
},
|
|
695
|
-
{
|
|
696
|
-
"name": "Error Handling",
|
|
697
|
-
"score": "[X]",
|
|
698
|
-
"max_points": 20,
|
|
699
|
-
"findings": [
|
|
700
|
-
{
|
|
701
|
-
"criterion": "[criterion name from framework]",
|
|
702
|
-
"points_earned": "[X]",
|
|
703
|
-
"points_possible": "[X]",
|
|
704
|
-
"issues": [
|
|
705
|
-
{
|
|
706
|
-
"title": "[Short issue title]",
|
|
707
|
-
"priority": "[critical|suggested|backlog]",
|
|
708
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
709
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
710
|
-
"file_path": "[path/to/file]",
|
|
711
|
-
"line_number": "[N]",
|
|
712
|
-
"description": "[Full explanation]"
|
|
713
|
-
}
|
|
714
|
-
]
|
|
715
|
-
}
|
|
716
|
-
]
|
|
717
|
-
},
|
|
718
|
-
{
|
|
719
|
-
"name": "Data Integrity",
|
|
720
|
-
"score": "[X]",
|
|
721
|
-
"max_points": 15,
|
|
722
|
-
"findings": [
|
|
723
|
-
{
|
|
724
|
-
"criterion": "[criterion name from framework]",
|
|
725
|
-
"points_earned": "[X]",
|
|
726
|
-
"points_possible": "[X]",
|
|
727
|
-
"issues": [
|
|
728
|
-
{
|
|
729
|
-
"title": "[Short issue title]",
|
|
730
|
-
"priority": "[critical|suggested|backlog]",
|
|
731
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
732
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
733
|
-
"file_path": "[path/to/file]",
|
|
734
|
-
"line_number": "[N]",
|
|
735
|
-
"description": "[Full explanation]"
|
|
736
|
-
}
|
|
737
|
-
]
|
|
738
|
-
}
|
|
739
|
-
]
|
|
740
|
-
},
|
|
741
|
-
{
|
|
742
|
-
"name": "API Boundary Safety",
|
|
743
|
-
"score": "[X]",
|
|
744
|
-
"max_points": 15,
|
|
745
|
-
"findings": [
|
|
746
|
-
{
|
|
747
|
-
"criterion": "[criterion name from framework]",
|
|
748
|
-
"points_earned": "[X]",
|
|
749
|
-
"points_possible": "[X]",
|
|
750
|
-
"issues": [
|
|
751
|
-
{
|
|
752
|
-
"title": "[Short issue title]",
|
|
753
|
-
"priority": "[critical|suggested|backlog]",
|
|
754
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
755
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
756
|
-
"file_path": "[path/to/file]",
|
|
757
|
-
"line_number": "[N]",
|
|
758
|
-
"description": "[Full explanation]"
|
|
759
|
-
}
|
|
760
|
-
]
|
|
761
|
-
}
|
|
762
|
-
]
|
|
763
|
-
}
|
|
764
|
-
],
|
|
765
|
-
"summary": {
|
|
766
|
-
"total_issues": "[N]",
|
|
767
|
-
"by_priority": {
|
|
768
|
-
"critical": "[N]",
|
|
769
|
-
"suggested": "[N]",
|
|
770
|
-
"backlog": "[N]"
|
|
771
|
-
},
|
|
772
|
-
"by_severity": {
|
|
773
|
-
"critical": "[N]",
|
|
774
|
-
"high": "[N]",
|
|
775
|
-
"medium": "[N]",
|
|
776
|
-
"low": "[N]",
|
|
777
|
-
"info": "[N]"
|
|
778
|
-
},
|
|
779
|
-
"by_type": {
|
|
780
|
-
"feature": "[N]",
|
|
781
|
-
"bug": "[N]",
|
|
782
|
-
"refactor": "[N]",
|
|
783
|
-
"config": "[N]",
|
|
784
|
-
"docs": "[N]",
|
|
785
|
-
"infra": "[N]",
|
|
786
|
-
"security": "[N]",
|
|
787
|
-
"test": "[N]",
|
|
788
|
-
"observation": "[N]",
|
|
789
|
-
"deficiency": "[N]",
|
|
790
|
-
"ambiguity": "[N]"
|
|
791
|
-
}
|
|
792
|
-
}
|
|
793
|
-
}
|
|
794
|
-
```
|
|
594
|
+
|
|
795
595
|
```
|
|
796
596
|
|
|
797
597
|
## Output Examples
|
|
@@ -960,44 +760,6 @@ Code is runtime-safe when ALL of the following are true
|
|
|
960
760
|
- All HTTP responses validated before body access
|
|
961
761
|
- No auto-fail conditions triggered
|
|
962
762
|
|
|
963
|
-
## Priority & Severity Mapping
|
|
964
|
-
|
|
965
|
-
When generating the JSON OUTPUT section, map issues as follows:
|
|
966
|
-
|
|
967
|
-
**Priority (for triage):**
|
|
968
|
-
| Severity | Priority | Meaning |
|
|
969
|
-
|----------|----------|---------|
|
|
970
|
-
| Critical | `critical` | Blocks progression, must fix now |
|
|
971
|
-
| High | `critical` | Should fix before next phase |
|
|
972
|
-
| Medium | `suggested` | Should fix soon |
|
|
973
|
-
| Low | `backlog` | Optional improvement |
|
|
974
|
-
| Info | `backlog` | Informational only |
|
|
975
|
-
|
|
976
|
-
**Severity is derived from failure_code suffix:**
|
|
977
|
-
| Suffix | Severity | Priority |
|
|
978
|
-
|--------|----------|----------|
|
|
979
|
-
| `/C` | critical | critical |
|
|
980
|
-
| `/H` | high | critical |
|
|
981
|
-
| `/M` | medium | suggested |
|
|
982
|
-
| `/L` | low | backlog |
|
|
983
|
-
| `/I` | info | backlog |
|
|
984
|
-
|
|
985
|
-
## Failure Code Selection
|
|
986
|
-
|
|
987
|
-
**1. Use the default code from the criterion that failed** (e.g., `→ SEM-COM/H`)
|
|
988
|
-
|
|
989
|
-
**2. Adjust severity letter based on actual impact:**
|
|
990
|
-
- `/C` - Security vulnerabilities, data loss risk, crashes, blocks all functionality
|
|
991
|
-
- `/H` - Broken functionality, missing critical tests, significant user impact
|
|
992
|
-
- `/M` - Code quality issues, maintainability concerns, moderate impact
|
|
993
|
-
- `/L` - Style issues, minor improvements, low impact
|
|
994
|
-
- `/I` - Suggestions, informational, no functional impact
|
|
995
|
-
|
|
996
|
-
**3. Consider context when adjusting:**
|
|
997
|
-
- A naming issue in a public API → elevate to `/M` or `/H`
|
|
998
|
-
- A complexity issue in rarely-used code → may stay at `/L`
|
|
999
|
-
- Missing error handling in user-facing code → `/H` or `/C`
|
|
1000
|
-
- Missing error handling in internal utility → `/M`
|
|
1001
763
|
|
|
1002
764
|
## Edge Case Handling
|
|
1003
765
|
|
|
@@ -1038,11 +800,6 @@ When generating the JSON OUTPUT section, map issues as follows:
|
|
|
1038
800
|
**Runs after:** code-validator, security-analyst
|
|
1039
801
|
**Recommends:** type-safety-validator, test-architect
|
|
1040
802
|
|
|
1041
|
-
### Handoff: What This Agent Passes Downstream
|
|
1042
|
-
|
|
1043
|
-
### Handoff: What This Agent Expects From Predecessors
|
|
1044
|
-
**From code-validator:** Validation results from code-validator
|
|
1045
|
-
**From security-analyst:** Validation results from security-analyst
|
|
1046
803
|
|
|
1047
804
|
---
|
|
1048
805
|
|
|
@@ -1,12 +1,9 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: code-optimizer
|
|
3
|
-
version: "1.
|
|
3
|
+
version: "1.8.0"
|
|
4
4
|
description: Reviews code after validation passes. Proposes safe refactors for performance, structure, and maintainability without changing behavior. Must NOT introduce breaking changes unless explicitly requested. Use AFTER code-validator and test-architect pass.
|
|
5
|
-
|
|
6
5
|
tools: Read, Grep, Glob, Bash
|
|
7
6
|
model: sonnet
|
|
8
|
-
adl_schema: /home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/code-optimizer.agent.yaml
|
|
9
|
-
taxonomy_version: "0.2.2"
|
|
10
7
|
threshold: 70
|
|
11
8
|
auto_fail_severity: [critical, high]
|
|
12
9
|
---
|
|
@@ -32,6 +29,12 @@ Every issue you identify MUST include a failure classification code from the tax
|
|
|
32
29
|
- Suggest improvements but do NOT apply risky changes automatically
|
|
33
30
|
|
|
34
31
|
|
|
32
|
+
### Epistemic Nature
|
|
33
|
+
- **Verifiability:** Not Checkable
|
|
34
|
+
- **Determinism:** Stochastic
|
|
35
|
+
- **Claim Type:** Normative
|
|
36
|
+
|
|
37
|
+
|
|
35
38
|
## Reference Examples
|
|
36
39
|
|
|
37
40
|
Use these examples to calibrate your judgment.
|
|
@@ -91,7 +94,7 @@ export function isValidDate(date: Date): boolean { }
|
|
|
91
94
|
// After: shared helper
|
|
92
95
|
async function fetchWithAuth<T>(url: string, token: string): Promise<T> {
|
|
93
96
|
const response = await fetch(url, {
|
|
94
|
-
headers: { 'Authorization':
|
|
97
|
+
headers: { 'Authorization': 'Bearer ' + token }
|
|
95
98
|
});
|
|
96
99
|
if (!response.ok) throw new HttpError(response.status);
|
|
97
100
|
return response.json();
|
|
@@ -288,48 +291,14 @@ Use these examples to classify issues with the correct failure codes:
|
|
|
288
291
|
Domain: Pragmatic (practical concern) Mode: FRA (Fragmentation - but inverse, too monolithic) Severity: M (Medium - harder to understand and test)
|
|
289
292
|
|
|
290
293
|
|
|
291
|
-
- **Missing comment for non-obvious workaround** → `
|
|
292
|
-
Domain:
|
|
294
|
+
- **Missing comment for non-obvious workaround** → `PRA-DOC/L`
|
|
295
|
+
Domain: Pragmatic (documentation gap) Mode: DOC (Documentation - explanation not provided) Severity: L (Low - still works, just harder to maintain)
|
|
293
296
|
|
|
294
297
|
|
|
295
298
|
- **Proposed refactor that would change API signatures** → `PRA-BRK/C`
|
|
296
299
|
Domain: Pragmatic (breaking change) Mode: BRK (Breaking - consumer code affected) Severity: C (Critical - auto-fail condition)
|
|
297
300
|
|
|
298
301
|
|
|
299
|
-
## Failure Taxonomy Reference
|
|
300
|
-
|
|
301
|
-
Compact format: `DOMAIN-MODE/SEVERITY` where:
|
|
302
|
-
- **Domain:** STR (Structural), SEM (Semantic), PRA (Pragmatic), EPI (Epistemic)
|
|
303
|
-
- **Mode:** 3-letter code (e.g., OMI=Omission, EXC=Excess, INC=Inconsistency, AMB=Ambiguity)
|
|
304
|
-
- **Severity:** C (Critical), H (High), M (Medium), L (Low), I (Info)
|
|
305
|
-
|
|
306
|
-
### Domain Reference
|
|
307
|
-
| Code | Domain | Description |
|
|
308
|
-
|------|--------|-------------|
|
|
309
|
-
| STR | Structural | Form, syntax, organization issues |
|
|
310
|
-
| SEM | Semantic | Meaning, correctness, completeness issues |
|
|
311
|
-
| PRA | Pragmatic | Practical effectiveness, efficiency issues |
|
|
312
|
-
| EPI | Epistemic | Knowledge, claims, confidence issues |
|
|
313
|
-
|
|
314
|
-
### Common Mode Codes
|
|
315
|
-
| Code | Mode | Domain | Meaning |
|
|
316
|
-
|------|------|--------|---------|
|
|
317
|
-
| OMI | Omission | STR | Missing required element |
|
|
318
|
-
| EXC | Excess | STR | Unnecessary/redundant element |
|
|
319
|
-
| MAL | Malformation | STR | Incorrectly structured |
|
|
320
|
-
| INC | Inconsistency | STR/SEM | Internal contradictions |
|
|
321
|
-
| COM | Incompleteness | SEM | Partial implementation |
|
|
322
|
-
| AMB | Ambiguity | SEM | Unclear meaning |
|
|
323
|
-
| COH | Incoherence | SEM | Logical disconnect |
|
|
324
|
-
| ALI | Misalignment | PRA | Doesn't match requirements |
|
|
325
|
-
| MAT | Mismatch | PRA | Interface/contract violation |
|
|
326
|
-
| EFF | Inefficiency | PRA | Performance issues |
|
|
327
|
-
| FRA | Fragility | PRA | Brittleness, poor error handling |
|
|
328
|
-
| OVR | Overclaiming | EPI | Claims exceed evidence |
|
|
329
|
-
| UND | Underclaiming | EPI | Evidence exceeds claims |
|
|
330
|
-
| GRN | Granularity | EPI | Wrong level of detail |
|
|
331
|
-
| FAL | Fallacy | EPI | Logical reasoning error |
|
|
332
|
-
|
|
333
302
|
## Code Optimizer Framework
|
|
334
303
|
|
|
335
304
|
### Category Overview
|
|
@@ -366,9 +335,9 @@ Each criterion has a default failure code—use it when that criterion fails.
|
|
|
366
335
|
### 4. Readability & Maintainability (25 points)
|
|
367
336
|
- [ ] Clear, descriptive naming (5 pts) `→ SEM-AMB/M` *Verify:* Function names are verb phrases, Variable names indicate content type, No abbreviations except standard (req, res, ctx), No single-letter names except iterators
|
|
368
337
|
- [ ] Complex functions broken into helpers (5 pts) `→ PRA-FRA/M` *Verify:* Functions >40 lines split into helpers, Nesting depth <=3 levels, Each helper does one thing
|
|
369
|
-
- [ ] Comments where behavior is non-obvious (5 pts) `→
|
|
370
|
-
- [ ] Types are precise and ergonomic (5 pts) `→ SEM-
|
|
371
|
-
- [ ] Code style matches project conventions (5 pts) `→ STR-
|
|
338
|
+
- [ ] Comments where behavior is non-obvious (5 pts) `→ PRA-DOC/L` *Verify:* Workarounds have 'why' comments, Provider-specific quirks documented, Magic numbers explained
|
|
339
|
+
- [ ] Types are precise and ergonomic (5 pts) `→ SEM-TYP/M` *Verify:* No 'any' except unavoidable boundaries, Union types over boolean flags, Error types are specific
|
|
340
|
+
- [ ] Code style matches project conventions (5 pts) `→ STR-FMT/L` *Verify:* Linter passes with zero errors, Formatting matches existing code, Import ordering consistent
|
|
372
341
|
|
|
373
342
|
**Total Score: /100**
|
|
374
343
|
|
|
@@ -472,6 +441,7 @@ Before finalizing your decision, verify:
|
|
|
472
441
|
|
|
473
442
|
- **Target:** ~3000 tokens
|
|
474
443
|
- **Maximum:** 10000 tokens
|
|
444
|
+
|
|
475
445
|
Target ~3000 tokens for typical reports. Expand to 10000 for codebases with significant duplication or many optimization opportunities. Focus on actionable refactors with clear benefits.
|
|
476
446
|
|
|
477
447
|
|
|
@@ -554,154 +524,7 @@ OR
|
|
|
554
524
|
|
|
555
525
|
Reasoning: [Explain decision]
|
|
556
526
|
|
|
557
|
-
|
|
558
|
-
|
|
559
|
-
<!-- Machine-readable output for API consumption and validation-tracker integration -->
|
|
560
|
-
<!-- Schema: udl/agent-output-schema-v1.4.json -->
|
|
561
|
-
```json
|
|
562
|
-
{
|
|
563
|
-
"schema_version": "1.3.0",
|
|
564
|
-
"validator": {
|
|
565
|
-
"name": "code-optimizer",
|
|
566
|
-
"model": "sonnet",
|
|
567
|
-
"adl_schema": "/home/alexs/uluops/uluops-agent-workflows/udl/adl/v3/code-optimizer.agent.yaml",
|
|
568
|
-
"tokens": {
|
|
569
|
-
"input_tokens": 0,
|
|
570
|
-
"output_tokens": 0
|
|
571
|
-
}
|
|
572
|
-
},
|
|
573
|
-
"target": "[path/to/validated/directory]",
|
|
574
|
-
"timestamp": "[ISO 8601 timestamp]",
|
|
575
|
-
"result": {
|
|
576
|
-
"score": "[X]",
|
|
577
|
-
"max_score": 100,
|
|
578
|
-
"decision": "[APPROVED|IMPROVE]",
|
|
579
|
-
"threshold": 70
|
|
580
|
-
},
|
|
581
|
-
"categories": [
|
|
582
|
-
{
|
|
583
|
-
"name": "Structure & Duplication",
|
|
584
|
-
"score": "[X]",
|
|
585
|
-
"max_points": 30,
|
|
586
|
-
"findings": [
|
|
587
|
-
{
|
|
588
|
-
"criterion": "[criterion name from framework]",
|
|
589
|
-
"points_earned": "[X]",
|
|
590
|
-
"points_possible": "[X]",
|
|
591
|
-
"issues": [
|
|
592
|
-
{
|
|
593
|
-
"title": "[Short issue title]",
|
|
594
|
-
"priority": "[critical|suggested|backlog]",
|
|
595
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
596
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
597
|
-
"file_path": "[path/to/file]",
|
|
598
|
-
"line_number": "[N]",
|
|
599
|
-
"description": "[Full explanation]"
|
|
600
|
-
}
|
|
601
|
-
]
|
|
602
|
-
}
|
|
603
|
-
]
|
|
604
|
-
},
|
|
605
|
-
{
|
|
606
|
-
"name": "Performance & Hot Paths",
|
|
607
|
-
"score": "[X]",
|
|
608
|
-
"max_points": 25,
|
|
609
|
-
"findings": [
|
|
610
|
-
{
|
|
611
|
-
"criterion": "[criterion name from framework]",
|
|
612
|
-
"points_earned": "[X]",
|
|
613
|
-
"points_possible": "[X]",
|
|
614
|
-
"issues": [
|
|
615
|
-
{
|
|
616
|
-
"title": "[Short issue title]",
|
|
617
|
-
"priority": "[critical|suggested|backlog]",
|
|
618
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
619
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
620
|
-
"file_path": "[path/to/file]",
|
|
621
|
-
"line_number": "[N]",
|
|
622
|
-
"description": "[Full explanation]"
|
|
623
|
-
}
|
|
624
|
-
]
|
|
625
|
-
}
|
|
626
|
-
]
|
|
627
|
-
},
|
|
628
|
-
{
|
|
629
|
-
"name": "Bundle & Dependencies",
|
|
630
|
-
"score": "[X]",
|
|
631
|
-
"max_points": 20,
|
|
632
|
-
"findings": [
|
|
633
|
-
{
|
|
634
|
-
"criterion": "[criterion name from framework]",
|
|
635
|
-
"points_earned": "[X]",
|
|
636
|
-
"points_possible": "[X]",
|
|
637
|
-
"issues": [
|
|
638
|
-
{
|
|
639
|
-
"title": "[Short issue title]",
|
|
640
|
-
"priority": "[critical|suggested|backlog]",
|
|
641
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
642
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
643
|
-
"file_path": "[path/to/file]",
|
|
644
|
-
"line_number": "[N]",
|
|
645
|
-
"description": "[Full explanation]"
|
|
646
|
-
}
|
|
647
|
-
]
|
|
648
|
-
}
|
|
649
|
-
]
|
|
650
|
-
},
|
|
651
|
-
{
|
|
652
|
-
"name": "Readability & Maintainability",
|
|
653
|
-
"score": "[X]",
|
|
654
|
-
"max_points": 25,
|
|
655
|
-
"findings": [
|
|
656
|
-
{
|
|
657
|
-
"criterion": "[criterion name from framework]",
|
|
658
|
-
"points_earned": "[X]",
|
|
659
|
-
"points_possible": "[X]",
|
|
660
|
-
"issues": [
|
|
661
|
-
{
|
|
662
|
-
"title": "[Short issue title]",
|
|
663
|
-
"priority": "[critical|suggested|backlog]",
|
|
664
|
-
"type": "[feature|bug|refactor|config|docs|infra|security|test|observation|deficiency|ambiguity]",
|
|
665
|
-
"failure_code": "[DOMAIN-MODE/SEVERITY]",
|
|
666
|
-
"file_path": "[path/to/file]",
|
|
667
|
-
"line_number": "[N]",
|
|
668
|
-
"description": "[Full explanation]"
|
|
669
|
-
}
|
|
670
|
-
]
|
|
671
|
-
}
|
|
672
|
-
]
|
|
673
|
-
}
|
|
674
|
-
],
|
|
675
|
-
"summary": {
|
|
676
|
-
"total_issues": "[N]",
|
|
677
|
-
"by_priority": {
|
|
678
|
-
"critical": "[N]",
|
|
679
|
-
"suggested": "[N]",
|
|
680
|
-
"backlog": "[N]"
|
|
681
|
-
},
|
|
682
|
-
"by_severity": {
|
|
683
|
-
"critical": "[N]",
|
|
684
|
-
"high": "[N]",
|
|
685
|
-
"medium": "[N]",
|
|
686
|
-
"low": "[N]",
|
|
687
|
-
"info": "[N]"
|
|
688
|
-
},
|
|
689
|
-
"by_type": {
|
|
690
|
-
"feature": "[N]",
|
|
691
|
-
"bug": "[N]",
|
|
692
|
-
"refactor": "[N]",
|
|
693
|
-
"config": "[N]",
|
|
694
|
-
"docs": "[N]",
|
|
695
|
-
"infra": "[N]",
|
|
696
|
-
"security": "[N]",
|
|
697
|
-
"test": "[N]",
|
|
698
|
-
"observation": "[N]",
|
|
699
|
-
"deficiency": "[N]",
|
|
700
|
-
"ambiguity": "[N]"
|
|
701
|
-
}
|
|
702
|
-
}
|
|
703
|
-
}
|
|
704
|
-
```
|
|
527
|
+
|
|
705
528
|
```
|
|
706
529
|
|
|
707
530
|
## Output Examples
|
|
@@ -771,45 +594,6 @@ Critical issues include:
|
|
|
771
594
|
- **AF-004** Unsafe memory patterns or race conditions introduced
|
|
772
595
|
|
|
773
596
|
|
|
774
|
-
## Priority & Severity Mapping
|
|
775
|
-
|
|
776
|
-
When generating the JSON OUTPUT section, map issues as follows:
|
|
777
|
-
|
|
778
|
-
**Priority (for triage):**
|
|
779
|
-
| Severity | Priority | Meaning |
|
|
780
|
-
|----------|----------|---------|
|
|
781
|
-
| Critical | `critical` | Blocks progression, must fix now |
|
|
782
|
-
| High | `critical` | Should fix before next phase |
|
|
783
|
-
| Medium | `suggested` | Should fix soon |
|
|
784
|
-
| Low | `backlog` | Optional improvement |
|
|
785
|
-
| Info | `backlog` | Informational only |
|
|
786
|
-
|
|
787
|
-
**Severity is derived from failure_code suffix:**
|
|
788
|
-
| Suffix | Severity | Priority |
|
|
789
|
-
|--------|----------|----------|
|
|
790
|
-
| `/C` | critical | critical |
|
|
791
|
-
| `/H` | high | critical |
|
|
792
|
-
| `/M` | medium | suggested |
|
|
793
|
-
| `/L` | low | backlog |
|
|
794
|
-
| `/I` | info | backlog |
|
|
795
|
-
|
|
796
|
-
## Failure Code Selection
|
|
797
|
-
|
|
798
|
-
**1. Use the default code from the criterion that failed** (e.g., `→ SEM-COM/H`)
|
|
799
|
-
|
|
800
|
-
**2. Adjust severity letter based on actual impact:**
|
|
801
|
-
- `/C` - Security vulnerabilities, data loss risk, crashes, blocks all functionality
|
|
802
|
-
- `/H` - Broken functionality, missing critical tests, significant user impact
|
|
803
|
-
- `/M` - Code quality issues, maintainability concerns, moderate impact
|
|
804
|
-
- `/L` - Style issues, minor improvements, low impact
|
|
805
|
-
- `/I` - Suggestions, informational, no functional impact
|
|
806
|
-
|
|
807
|
-
**3. Consider context when adjusting:**
|
|
808
|
-
- A naming issue in a public API → elevate to `/M` or `/H`
|
|
809
|
-
- A complexity issue in rarely-used code → may stay at `/L`
|
|
810
|
-
- Missing error handling in user-facing code → `/H` or `/C`
|
|
811
|
-
- Missing error handling in internal utility → `/M`
|
|
812
|
-
|
|
813
597
|
## Edge Case Handling
|
|
814
598
|
|
|
815
599
|
### No files modified
|
|
@@ -854,11 +638,6 @@ When generating the JSON OUTPUT section, map issues as follows:
|
|
|
854
638
|
**Runs after:** code-validator, test-architect
|
|
855
639
|
**Recommends:** public-interface-validator
|
|
856
640
|
|
|
857
|
-
### Handoff: What This Agent Passes Downstream
|
|
858
|
-
|
|
859
|
-
### Handoff: What This Agent Expects From Predecessors
|
|
860
|
-
**From code-validator:** Validation results from code-validator
|
|
861
|
-
**From test-architect:** Validation results from test-architect
|
|
862
641
|
|
|
863
642
|
---
|
|
864
643
|
|