@uluops/setup 0.4.0 → 0.6.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +21 -0
- package/README.md +67 -50
- package/assets/auto-tracker-save.mjs +142 -0
- package/assets/{agents → claude-code/agents}/api-contract-validator-agent.md +9 -228
- package/assets/{agents → claude-code/agents}/aristotle-analyst-agent.md +51 -4
- package/assets/{agents → claude-code/agents}/aristotle-explorer-agent.md +6 -2
- package/assets/{agents → claude-code/agents}/aristotle-forecaster-agent.md +15 -230
- package/assets/{agents → claude-code/agents}/aristotle-validator-agent.md +12 -252
- package/assets/{agents → claude-code/agents}/assumption-excavator-agent.md +21 -247
- package/assets/{agents → claude-code/agents}/code-auditor-agent.md +12 -255
- package/assets/{agents → claude-code/agents}/code-optimizer-agent.md +15 -236
- package/assets/{agents → claude-code/agents}/code-validator-agent.md +31 -300
- package/assets/claude-code/agents/docs-validator-agent.md +472 -0
- package/assets/{agents → claude-code/agents}/frontend-validator-agent.md +15 -258
- package/assets/{agents → claude-code/agents}/mcp-validator-agent.md +8 -252
- package/assets/{agents → claude-code/agents}/pre-implementation-architect-agent.md +8 -224
- package/assets/{agents → claude-code/agents}/prompt-engineer-agent.md +57 -290
- package/assets/{agents → claude-code/agents}/prompt-pattern-analyzer-agent.md +10 -225
- package/assets/{agents → claude-code/agents}/prompt-quality-validator-agent.md +11 -249
- package/assets/{agents → claude-code/agents}/public-interface-validator-agent.md +15 -268
- package/assets/claude-code/agents/release-readiness-agent.md +495 -0
- package/assets/{agents → claude-code/agents}/security-analyst-agent.md +236 -480
- package/assets/{agents → claude-code/agents}/test-architect-agent.md +16 -259
- package/assets/{agents → claude-code/agents}/type-safety-validator-agent.md +23 -266
- package/assets/{agents → claude-code/agents}/workflow-synthesis-agent.md +23 -226
- package/assets/{commands → claude-code/commands}/agents/anxiety-reader.md +12 -15
- package/assets/{commands → claude-code/commands}/agents/api-contract.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/architect.md +156 -136
- package/assets/claude-code/commands/agents/aristotle-analyst.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-explorer.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-forecaster.md +157 -0
- package/assets/claude-code/commands/agents/aristotle-validator.md +157 -0
- package/assets/{commands → claude-code/commands}/agents/assumption-excavator.md +49 -7
- package/assets/{commands → claude-code/commands}/agents/audit.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/docs-validate.md +156 -134
- package/assets/{commands → claude-code/commands}/agents/frontend.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/mcp-validate.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/optimize.md +156 -134
- package/assets/{commands → claude-code/commands}/agents/pattern-analyzer.md +150 -127
- package/assets/{commands → claude-code/commands}/agents/prompt-quality.md +155 -135
- package/assets/claude-code/commands/agents/prompt-validate.md +155 -0
- package/assets/{commands → claude-code/commands}/agents/public-interface.md +156 -135
- package/assets/{commands → claude-code/commands}/agents/release.md +156 -136
- package/assets/{commands → claude-code/commands}/agents/security.md +156 -138
- package/assets/{commands → claude-code/commands}/agents/test-review.md +156 -137
- package/assets/{commands → claude-code/commands}/agents/type-safety.md +156 -136
- package/assets/{commands/agents/code-validate.md → claude-code/commands/agents/validate.md} +156 -135
- package/assets/claude-code/commands/agents/workflow-synthesis.md +157 -0
- package/assets/{commands → claude-code/commands}/pipelines/aristotle.md +8 -8
- package/assets/{commands → claude-code/commands}/pipelines/ship.md +8 -8
- package/assets/claude-code/commands/workflows/post-implementation.md +60 -0
- package/assets/claude-code/commands/workflows/pre-implementation.md +46 -0
- package/assets/{commands → claude-code/commands}/workflows/prompt-audit.md +2 -2
- package/assets/codex/agents/anxiety-reader-agent.toml +462 -0
- package/assets/codex/agents/api-contract-validator-agent.toml +738 -0
- package/assets/codex/agents/aristotle-analyst-agent.toml +750 -0
- package/assets/codex/agents/aristotle-explorer-agent.toml +155 -0
- package/assets/codex/agents/aristotle-forecaster-agent.toml +449 -0
- package/assets/codex/agents/aristotle-validator-agent.toml +424 -0
- package/assets/codex/agents/assumption-excavator-agent.toml +1126 -0
- package/assets/codex/agents/code-auditor-agent.toml +815 -0
- package/assets/codex/agents/code-optimizer-agent.toml +652 -0
- package/assets/codex/agents/code-validator-agent.toml +573 -0
- package/assets/codex/agents/docs-validator-agent.toml +468 -0
- package/assets/codex/agents/frontend-validator-agent.toml +598 -0
- package/assets/codex/agents/mcp-validator-agent.toml +580 -0
- package/assets/codex/agents/pre-implementation-architect-agent.toml +817 -0
- package/assets/codex/agents/prompt-engineer-agent.toml +922 -0
- package/assets/codex/agents/prompt-pattern-analyzer-agent.toml +689 -0
- package/assets/codex/agents/prompt-quality-validator-agent.toml +777 -0
- package/assets/codex/agents/public-interface-validator-agent.toml +695 -0
- package/assets/codex/agents/release-readiness-agent.toml +491 -0
- package/assets/codex/agents/security-analyst-agent.toml +847 -0
- package/assets/codex/agents/test-architect-agent.toml +615 -0
- package/assets/codex/agents/type-safety-validator-agent.toml +686 -0
- package/assets/codex/agents/workflow-synthesis-agent.toml +631 -0
- package/assets/gemini-cli/agents/anxiety-reader-agent.md +470 -0
- package/assets/gemini-cli/agents/api-contract-validator-agent.md +747 -0
- package/assets/gemini-cli/agents/aristotle-analyst-agent.md +758 -0
- package/assets/gemini-cli/agents/aristotle-explorer-agent.md +163 -0
- package/assets/gemini-cli/agents/aristotle-forecaster-agent.md +457 -0
- package/assets/gemini-cli/agents/aristotle-validator-agent.md +432 -0
- package/assets/gemini-cli/agents/assumption-excavator-agent.md +1134 -0
- package/assets/gemini-cli/agents/code-auditor-agent.md +827 -0
- package/assets/gemini-cli/agents/code-optimizer-agent.md +661 -0
- package/assets/gemini-cli/agents/code-validator-agent.md +582 -0
- package/assets/gemini-cli/agents/docs-validator-agent.md +477 -0
- package/assets/gemini-cli/agents/frontend-validator-agent.md +610 -0
- package/assets/gemini-cli/agents/mcp-validator-agent.md +589 -0
- package/assets/gemini-cli/agents/pre-implementation-architect-agent.md +826 -0
- package/assets/gemini-cli/agents/prompt-engineer-agent.md +931 -0
- package/assets/gemini-cli/agents/prompt-pattern-analyzer-agent.md +698 -0
- package/assets/gemini-cli/agents/prompt-quality-validator-agent.md +786 -0
- package/assets/gemini-cli/agents/public-interface-validator-agent.md +707 -0
- package/assets/gemini-cli/agents/release-readiness-agent.md +500 -0
- package/assets/gemini-cli/agents/security-analyst-agent.md +859 -0
- package/assets/gemini-cli/agents/test-architect-agent.md +624 -0
- package/assets/gemini-cli/agents/type-safety-validator-agent.md +695 -0
- package/assets/gemini-cli/agents/workflow-synthesis-agent.md +639 -0
- package/assets/gemini-cli/commands/agents/anxiety-reader.toml +155 -0
- package/assets/gemini-cli/commands/agents/api-contract.toml +154 -0
- package/assets/gemini-cli/commands/agents/architect.toml +154 -0
- package/assets/gemini-cli/commands/agents/aristotle-analyst.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-explorer.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-forecaster.toml +155 -0
- package/assets/gemini-cli/commands/agents/aristotle-validator.toml +155 -0
- package/assets/gemini-cli/commands/agents/assumption-excavator.toml +155 -0
- package/assets/gemini-cli/commands/agents/audit.toml +154 -0
- package/assets/gemini-cli/commands/agents/docs-validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/frontend.toml +154 -0
- package/assets/gemini-cli/commands/agents/mcp-validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/optimize.toml +154 -0
- package/assets/gemini-cli/commands/agents/pattern-analyzer.toml +148 -0
- package/assets/gemini-cli/commands/agents/prompt-quality.toml +153 -0
- package/assets/gemini-cli/commands/agents/prompt-validate.toml +153 -0
- package/assets/gemini-cli/commands/agents/public-interface.toml +154 -0
- package/assets/gemini-cli/commands/agents/release.toml +154 -0
- package/assets/gemini-cli/commands/agents/security.toml +154 -0
- package/assets/gemini-cli/commands/agents/test-review.toml +154 -0
- package/assets/gemini-cli/commands/agents/type-safety.toml +154 -0
- package/assets/gemini-cli/commands/agents/validate.toml +154 -0
- package/assets/gemini-cli/commands/agents/workflow-synthesis.toml +155 -0
- package/assets/gemini-cli/commands/pipelines/aristotle.toml +139 -0
- package/assets/gemini-cli/commands/pipelines/ship.toml +184 -0
- package/assets/gemini-cli/commands/workflows/post-implementation.toml +56 -0
- package/assets/gemini-cli/commands/workflows/pre-implementation.toml +42 -0
- package/assets/gemini-cli/commands/workflows/prompt-audit.toml +40 -0
- package/assets/opencode/agents/anxiety-reader-agent.md +472 -0
- package/assets/opencode/agents/api-contract-validator-agent.md +749 -0
- package/assets/opencode/agents/aristotle-analyst-agent.md +760 -0
- package/assets/opencode/agents/aristotle-explorer-agent.md +164 -0
- package/assets/opencode/agents/aristotle-forecaster-agent.md +459 -0
- package/assets/opencode/agents/aristotle-validator-agent.md +434 -0
- package/assets/opencode/agents/assumption-excavator-agent.md +1136 -0
- package/assets/opencode/agents/code-auditor-agent.md +826 -0
- package/assets/opencode/agents/code-optimizer-agent.md +663 -0
- package/assets/opencode/agents/code-validator-agent.md +584 -0
- package/assets/opencode/agents/docs-validator-agent.md +479 -0
- package/assets/opencode/agents/frontend-validator-agent.md +609 -0
- package/assets/opencode/agents/mcp-validator-agent.md +591 -0
- package/assets/opencode/agents/pre-implementation-architect-agent.md +828 -0
- package/assets/opencode/agents/prompt-engineer-agent.md +933 -0
- package/assets/opencode/agents/prompt-pattern-analyzer-agent.md +700 -0
- package/assets/opencode/agents/prompt-quality-validator-agent.md +788 -0
- package/assets/opencode/agents/public-interface-validator-agent.md +706 -0
- package/assets/opencode/agents/release-readiness-agent.md +502 -0
- package/assets/opencode/agents/security-analyst-agent.md +858 -0
- package/assets/opencode/agents/test-architect-agent.md +626 -0
- package/assets/opencode/agents/type-safety-validator-agent.md +697 -0
- package/assets/opencode/agents/workflow-synthesis-agent.md +641 -0
- package/dist/cli.js +12 -414
- package/dist/commands/helpers.d.ts +73 -0
- package/dist/commands/helpers.js +274 -0
- package/dist/commands/setup.d.ts +13 -0
- package/dist/commands/setup.js +93 -0
- package/dist/commands/uninstall.d.ts +3 -0
- package/dist/commands/uninstall.js +126 -0
- package/dist/commands/verify.d.ts +1 -0
- package/dist/commands/verify.js +28 -0
- package/dist/harnesses/claude-code.d.ts +1 -1
- package/dist/harnesses/claude-code.js +3 -1
- package/dist/harnesses/codex.js +6 -5
- package/dist/harnesses/gemini-cli.d.ts +4 -8
- package/dist/harnesses/gemini-cli.js +47 -21
- package/dist/harnesses/index.d.ts +10 -1
- package/dist/harnesses/index.js +11 -2
- package/dist/harnesses/opencode.d.ts +1 -1
- package/dist/harnesses/opencode.js +15 -6
- package/dist/harnesses/types.d.ts +19 -0
- package/dist/harnesses/types.js +2 -0
- package/dist/lib/asset-catalog.js +2 -2
- package/dist/lib/config-merger.d.ts +2 -1
- package/dist/lib/config-merger.js +12 -4
- package/dist/lib/file-ops.d.ts +5 -0
- package/dist/lib/file-ops.js +18 -3
- package/dist/lib/hash.d.ts +1 -1
- package/dist/lib/hash.js +2 -2
- package/dist/lib/manifest.d.ts +30 -1
- package/dist/lib/manifest.js +5 -7
- package/dist/lib/paths.d.ts +16 -1
- package/dist/lib/paths.js +31 -3
- package/dist/lib/settings-merger.d.ts +24 -9
- package/dist/lib/settings-merger.js +57 -22
- package/dist/lib/version.d.ts +2 -0
- package/dist/lib/version.js +10 -0
- package/dist/steps/agents.d.ts +1 -2
- package/dist/steps/agents.js +7 -18
- package/dist/steps/cli.d.ts +53 -0
- package/dist/steps/cli.js +90 -0
- package/dist/steps/commands.d.ts +1 -1
- package/dist/steps/commands.js +20 -71
- package/dist/steps/detect.js +4 -0
- package/dist/steps/mcp.js +7 -15
- package/dist/steps/metrics.d.ts +12 -0
- package/dist/steps/metrics.js +52 -22
- package/dist/steps/shell.js +11 -1
- package/dist/steps/signup.d.ts +2 -2
- package/dist/steps/signup.js +9 -12
- package/dist/steps/verify.js +47 -8
- package/package.json +12 -11
- package/assets/agents/docs-validator-agent.md +0 -490
- package/assets/agents/release-readiness-agent.md +0 -482
- package/assets/commands/agents/aristotle-analyst.md +0 -116
- package/assets/commands/agents/aristotle-explorer.md +0 -93
- package/assets/commands/agents/aristotle-forecaster.md +0 -115
- package/assets/commands/agents/aristotle-validator.md +0 -115
- package/assets/commands/agents/prompt-validate.md +0 -136
- package/assets/commands/agents/workflow-synthesis.md +0 -102
- package/assets/commands/workflows/post-implementation.md +0 -577
- package/assets/commands/workflows/pre-implementation.md +0 -670
- /package/assets/{agents → claude-code/agents}/anxiety-reader-agent.md +0 -0
|
@@ -1,670 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: pre-impl
|
|
3
|
-
description: Validates proposed design and architecture BEFORE implementation begins. Reviews design/plan against existing architecture patterns. Blocks implementation if design has critical flaws. Use when you have a design document, PRD, or implementation plan ready for review.
|
|
4
|
-
tools: Read, Grep, Glob, Bash
|
|
5
|
-
model: sonnet
|
|
6
|
-
---
|
|
7
|
-
|
|
8
|
-
# Pre-Implementation Review
|
|
9
|
-
|
|
10
|
-
Validate design and architecture before implementation begins.
|
|
11
|
-
|
|
12
|
-
**Philosophy**: "Measure twice, cut once." Time spent validating design is cheaper than time spent refactoring bad architecture.
|
|
13
|
-
|
|
14
|
-
---
|
|
15
|
-
|
|
16
|
-
## Workflow Overview
|
|
17
|
-
|
|
18
|
-
```
|
|
19
|
-
┌─────────────────────────────────────────────────────────────────────┐
|
|
20
|
-
│ PRE-IMPL VALIDATION PIPELINE │
|
|
21
|
-
├─────────────────────────────────────────────────────────────────────┤
|
|
22
|
-
│ │
|
|
23
|
-
│ ┌──────────────┐ ┌────────────────────────────┐ │
|
|
24
|
-
│ │ Gather │ │ Validation Phase │ │
|
|
25
|
-
│ │ Context │ ──▶│ (Sequential or Parallel) │ │
|
|
26
|
-
│ │ │ │ │ │
|
|
27
|
-
│ └──────────────┘ │ ┌─────────────────────┐ │ │
|
|
28
|
-
│ │ │ Architect Review │ │ │
|
|
29
|
-
│ │ │ (≥75) │ │ │
|
|
30
|
-
│ │ └─────────────────────┘ │ │
|
|
31
|
-
│ │ + │ │
|
|
32
|
-
│ │ ┌─────────────────────┐ │ │
|
|
33
|
-
│ │ │ Docs Validator │ │ │
|
|
34
|
-
│ │ │ (≥75, optional) │ │ │
|
|
35
|
-
│ │ └─────────────────────┘ │ │
|
|
36
|
-
│ └────────────────────────────┘ │
|
|
37
|
-
│ │ │
|
|
38
|
-
│ ▼ │
|
|
39
|
-
│ ┌────────────────────────────┐ │
|
|
40
|
-
│ │ Summary + Save Tracker │ │
|
|
41
|
-
│ └────────────────────────────┘ │
|
|
42
|
-
│ │
|
|
43
|
-
│ Duration: 3-10 minutes (parallel: 3-6 min) │
|
|
44
|
-
│ Run: Before writing any code │
|
|
45
|
-
│ │
|
|
46
|
-
└─────────────────────────────────────────────────────────────────────┘
|
|
47
|
-
```
|
|
48
|
-
|
|
49
|
-
---
|
|
50
|
-
|
|
51
|
-
## Agent Handoff Formats
|
|
52
|
-
|
|
53
|
-
Pre-implementation passes structured context to downstream workflows:
|
|
54
|
-
|
|
55
|
-
| From | To | Passes | Purpose |
|
|
56
|
-
|------|-----|--------|---------|
|
|
57
|
-
| Pre-Impl | Implementation Phase | Design approval, scope bounds, risk assessment | Guides implementation within validated constraints |
|
|
58
|
-
| Pre-Impl | Post-Impl (later) | Design baseline, original requirements | Post-impl compares implementation against original design |
|
|
59
|
-
| Pre-Impl | Uluops Tracker | Score, gaps, recommendations | Historical tracking of design decisions |
|
|
60
|
-
|
|
61
|
-
**Validators in this workflow:**
|
|
62
|
-
|
|
63
|
-
| Phase | Validator | Threshold | Condition |
|
|
64
|
-
|-------|-----------|-----------|-----------|
|
|
65
|
-
| 2 | pre-implementation-architect | ≥75 | Always |
|
|
66
|
-
| 3 | docs-validator | ≥75 | If design docs exist |
|
|
67
|
-
|
|
68
|
-
**Handoff Contract:**
|
|
69
|
-
- Implementation receives: approved design scope (files, LOC, dependencies)
|
|
70
|
-
- Post-impl receives: design context for architectural drift detection
|
|
71
|
-
- Tracker receives: all critical gaps and suggestions for correlation across runs
|
|
72
|
-
|
|
73
|
-
**Key Data Passed Forward:**
|
|
74
|
-
```
|
|
75
|
-
design_approval:
|
|
76
|
-
score: 82
|
|
77
|
-
status: PROCEED
|
|
78
|
-
scope_bounds:
|
|
79
|
-
max_files: 10
|
|
80
|
-
max_loc: 500
|
|
81
|
-
max_dependencies: 3
|
|
82
|
-
risk_assessment: LOW
|
|
83
|
-
critical_gaps: []
|
|
84
|
-
suggestions:
|
|
85
|
-
- "Consider caching strategy for token validation"
|
|
86
|
-
- "Document rate limiting approach"
|
|
87
|
-
```
|
|
88
|
-
|
|
89
|
-
---
|
|
90
|
-
|
|
91
|
-
## Agent Metrics
|
|
92
|
-
|
|
93
|
-
Metrics are auto-captured to the buffer. For tracker-ready format:
|
|
94
|
-
|
|
95
|
-
```bash
|
|
96
|
-
agent-metrics buffer list --since 5m -f tracker
|
|
97
|
-
```
|
|
98
|
-
|
|
99
|
-
The validator name is auto-detected from the buffer. Output includes all token fields:
|
|
100
|
-
|
|
101
|
-
```json
|
|
102
|
-
{
|
|
103
|
-
"name": "pre-implementation-architect",
|
|
104
|
-
"model": "claude-sonnet-4-5-20250929",
|
|
105
|
-
"tokens": {
|
|
106
|
-
"input_tokens": 42000,
|
|
107
|
-
"output_tokens": 5800,
|
|
108
|
-
"cache_creation_tokens": 28000,
|
|
109
|
-
"cache_read_tokens": 14000,
|
|
110
|
-
"total_effective_tokens": 47800
|
|
111
|
-
},
|
|
112
|
-
"duration_ms": 45000
|
|
113
|
-
}
|
|
114
|
-
```
|
|
115
|
-
|
|
116
|
-
**Use these metrics** when saving to the uluops tracker instead of estimates.
|
|
117
|
-
|
|
118
|
-
---
|
|
119
|
-
|
|
120
|
-
## Pre-Flight: Target Detection and Configuration
|
|
121
|
-
|
|
122
|
-
Before running validation, verify the target directory and gather context.
|
|
123
|
-
|
|
124
|
-
### Step 1: Parse Arguments
|
|
125
|
-
|
|
126
|
-
**Usage**: `/workflows:pre-impl <directory>`
|
|
127
|
-
|
|
128
|
-
**Examples**:
|
|
129
|
-
- `/workflows:pre-impl ./services/new-service`
|
|
130
|
-
- `/workflows:pre-impl ./packages/feature`
|
|
131
|
-
- `/workflows:pre-impl .`
|
|
132
|
-
|
|
133
|
-
**Target Directory**: $ARGUMENTS
|
|
134
|
-
|
|
135
|
-
1. **Extract target path**: Use the first argument as the target path. If no path provided, use the current working directory (`.`).
|
|
136
|
-
2. **Resolve absolute path**: Convert relative paths to absolute paths for consistent reporting.
|
|
137
|
-
3. **Extract target name**: Use the directory basename for status reporting (e.g., `new-service` from `./services/new-service`).
|
|
138
|
-
|
|
139
|
-
Report the configuration:
|
|
140
|
-
- "📋 Target: {absolute_path}"
|
|
141
|
-
- "📁 Project: {target_name}"
|
|
142
|
-
|
|
143
|
-
### Step 2: Verify Directory Existence
|
|
144
|
-
|
|
145
|
-
Check if the target directory exists:
|
|
146
|
-
|
|
147
|
-
```bash
|
|
148
|
-
if [ -d "$ARGUMENTS" ]; then echo "✅ Directory exists: $ARGUMENTS"; else echo "ℹ️ Directory does not exist yet (new project): $ARGUMENTS"; parent_dir=`dirname "$ARGUMENTS"`; if [ -d "$parent_dir" ]; then echo "✅ Parent directory exists: $parent_dir"; else echo "❌ Parent directory does not exist: $parent_dir"; echo "Create parent directory before running pre-implementation review"; exit 1; fi; fi
|
|
149
|
-
```
|
|
150
|
-
|
|
151
|
-
### Step 3: Display Target Structure (if exists)
|
|
152
|
-
|
|
153
|
-
If the directory exists, show its current state:
|
|
154
|
-
|
|
155
|
-
```bash
|
|
156
|
-
if [ -d "$ARGUMENTS" ]; then
|
|
157
|
-
echo "📂 Current structure:"
|
|
158
|
-
ls -la "$ARGUMENTS" 2>/dev/null | head -20
|
|
159
|
-
fi
|
|
160
|
-
```
|
|
161
|
-
|
|
162
|
-
### Step 4: Detect Design Documentation
|
|
163
|
-
|
|
164
|
-
Check for existing design documentation that docs-validator can validate:
|
|
165
|
-
|
|
166
|
-
```bash
|
|
167
|
-
echo ""
|
|
168
|
-
echo "📄 DESIGN DOCUMENTATION CHECK"
|
|
169
|
-
echo "=============================="
|
|
170
|
-
|
|
171
|
-
# Check for design-related files
|
|
172
|
-
DESIGN_DOCS=`find . -maxdepth 3 -type f \( -name "*design*" -o -name "*spec*" -o -name "*prd*" -o -name "*plan*" -o -name "README.md" \) -not -path "*/node_modules/*" 2>/dev/null | head -10`
|
|
173
|
-
|
|
174
|
-
if [ -n "$DESIGN_DOCS" ]; then
|
|
175
|
-
echo "✅ Design documentation found:"
|
|
176
|
-
echo "$DESIGN_DOCS"
|
|
177
|
-
echo ""
|
|
178
|
-
echo "✅ Docs Validator: ENABLED"
|
|
179
|
-
else
|
|
180
|
-
echo "ℹ️ No design documentation found"
|
|
181
|
-
echo "ℹ️ Docs Validator: SKIPPED (no docs to validate)"
|
|
182
|
-
fi
|
|
183
|
-
```
|
|
184
|
-
|
|
185
|
-
Report the detection result:
|
|
186
|
-
- **If design docs found**: "✅ Docs Validator: ENABLED"
|
|
187
|
-
- **If no docs found**: "ℹ️ Docs Validator: SKIPPED (no docs to validate)"
|
|
188
|
-
|
|
189
|
-
### Step 5: Execution Mode Selection
|
|
190
|
-
|
|
191
|
-
**After completing detection, ask the user to choose execution mode using AskUserQuestion:**
|
|
192
|
-
|
|
193
|
-
| Mode | Description | Best For |
|
|
194
|
-
|------|-------------|----------|
|
|
195
|
-
| Sequential | Run agents one at a time, stop on first failure | Debugging, first runs, when you want early feedback |
|
|
196
|
-
| Parallel | Run both agents concurrently | Speed, CI/CD, when design is well-documented |
|
|
197
|
-
|
|
198
|
-
**Parallel execution groups (when parallel mode selected AND docs detected):**
|
|
199
|
-
|
|
200
|
-
```
|
|
201
|
-
Group 1 (Parallel): pre-implementation-architect + docs-validator
|
|
202
|
-
│
|
|
203
|
-
▼
|
|
204
|
-
Group 2 (Always): Summary + Save to Tracker
|
|
205
|
-
```
|
|
206
|
-
|
|
207
|
-
**Note:** If docs-validator is skipped (no docs detected), only pre-implementation-architect runs regardless of mode selection.
|
|
208
|
-
|
|
209
|
-
**Important:** Even in parallel mode, if ANY agent fails with a blocking result, stop the pipeline and report all results collected so far.
|
|
210
|
-
|
|
211
|
-
**For parallel execution:** Use multiple Task tool calls in a single message:
|
|
212
|
-
|
|
213
|
-
```
|
|
214
|
-
// Example: Running both validators in parallel (when docs exist)
|
|
215
|
-
Task(subagent_type: "pre-implementation-architect", prompt: "[validator:pre-implementation-architect] ...", description: "Architecture review")
|
|
216
|
-
Task(subagent_type: "docs-validator", prompt: "[validator:docs-validator] ...", description: "Docs validation")
|
|
217
|
-
```
|
|
218
|
-
|
|
219
|
-
---
|
|
220
|
-
|
|
221
|
-
## Agent Invocation Method
|
|
222
|
-
|
|
223
|
-
**CRITICAL: Use the Task tool directly to invoke agents. Do NOT use the Skill tool.**
|
|
224
|
-
|
|
225
|
-
Each agent is invoked via the Task tool with the appropriate `subagent_type`:
|
|
226
|
-
|
|
227
|
-
```
|
|
228
|
-
Task(
|
|
229
|
-
subagent_type: "{agent-name}",
|
|
230
|
-
prompt: "[validator:{agent-name}] Validate {target-directory}. This is the pre-implementation pipeline.
|
|
231
|
-
Return structured JSON OUTPUT for tracker integration.",
|
|
232
|
-
description: "Run {agent-name}"
|
|
233
|
-
)
|
|
234
|
-
```
|
|
235
|
-
|
|
236
|
-
**Available subagent_types for this workflow:**
|
|
237
|
-
|
|
238
|
-
| Phase | subagent_type | Model | Condition |
|
|
239
|
-
|-------|---------------|-------|-----------|
|
|
240
|
-
| 2 | `pre-implementation-architect` | sonnet | Always |
|
|
241
|
-
| 3 | `docs-validator` | sonnet | If design docs detected |
|
|
242
|
-
|
|
243
|
-
---
|
|
244
|
-
|
|
245
|
-
## Execution
|
|
246
|
-
|
|
247
|
-
Run each agent in sequence (or parallel if selected). Stop and request design revisions if any agent fails with a blocking result. **Collect all recommendations for the features list.**
|
|
248
|
-
|
|
249
|
-
### Phase 1: Gather Context
|
|
250
|
-
|
|
251
|
-
**Purpose**: Understand what's being proposed before evaluating its architectural fit.
|
|
252
|
-
|
|
253
|
-
**Actions**:
|
|
254
|
-
|
|
255
|
-
1. **Check for design documents**:
|
|
256
|
-
|
|
257
|
-
```bash
|
|
258
|
-
# Search for design-related files
|
|
259
|
-
find . -type f \( -name "*design*" -o -name "*spec*" -o -name "*prd*" -o -name "*plan*" \) -not -path "*/node_modules/*" 2>/dev/null | head -10
|
|
260
|
-
```
|
|
261
|
-
|
|
262
|
-
2. **Check for README with implementation plan**:
|
|
263
|
-
|
|
264
|
-
```bash
|
|
265
|
-
# Display README if it exists in target directory
|
|
266
|
-
if [ -f "$ARGUMENTS/README.md" ]; then
|
|
267
|
-
echo "📄 Found README.md - checking for design details:"
|
|
268
|
-
head -50 "$ARGUMENTS/README.md"
|
|
269
|
-
fi
|
|
270
|
-
```
|
|
271
|
-
|
|
272
|
-
3. **Check for implementation plan files**:
|
|
273
|
-
|
|
274
|
-
```bash
|
|
275
|
-
# Look for common planning file patterns
|
|
276
|
-
find . -type f \( -name "*implementation-plan*.md" -o -name "*task-list*.md" \) -not -path "*/node_modules/*" 2>/dev/null | head -5
|
|
277
|
-
```
|
|
278
|
-
|
|
279
|
-
**If no design documentation found**, ask the user to provide:
|
|
280
|
-
- **What**: What feature/functionality is being implemented?
|
|
281
|
-
- **Components**: What new components will be created?
|
|
282
|
-
- **Changes**: What existing code will be modified?
|
|
283
|
-
- **APIs**: What are the API contracts (if applicable)?
|
|
284
|
-
- **Data Flow**: How will data flow through the system?
|
|
285
|
-
- **Error Handling**: What error scenarios need to be handled?
|
|
286
|
-
- **Testing**: What testing strategy will be used?
|
|
287
|
-
|
|
288
|
-
**Do not proceed to Phase 2 without design documentation or user-provided design details.**
|
|
289
|
-
|
|
290
|
-
---
|
|
291
|
-
|
|
292
|
-
### Phase 2: Architecture Review with Validation Checklist
|
|
293
|
-
|
|
294
|
-
**Purpose**: Run the pre-implementation-architect agent and validate the design against measurable criteria.
|
|
295
|
-
|
|
296
|
-
**Invoke via Task tool:**
|
|
297
|
-
```
|
|
298
|
-
Task(
|
|
299
|
-
subagent_type: "pre-implementation-architect",
|
|
300
|
-
prompt: "[validator:pre-implementation-architect] Review the architecture and design for {TARGET_DIRECTORY}. This is the pre-implementation pipeline. Validate against architectural fit, design quality, scope/complexity, and completeness criteria. Return structured JSON OUTPUT with score, decision, and all findings.",
|
|
301
|
-
description: "Architecture review"
|
|
302
|
-
)
|
|
303
|
-
```
|
|
304
|
-
|
|
305
|
-
**Threshold**: ≥75 to proceed
|
|
306
|
-
|
|
307
|
-
#### Error Handling
|
|
308
|
-
|
|
309
|
-
**If agent invocation fails** (command not found, agent errors, or malformed output):
|
|
310
|
-
|
|
311
|
-
1. **Report the error**:
|
|
312
|
-
```
|
|
313
|
-
⚠️ ARCHITECT AGENT INVOCATION FAILED
|
|
314
|
-
|
|
315
|
-
Error: [specific error message]
|
|
316
|
-
|
|
317
|
-
Possible causes:
|
|
318
|
-
- Agent command not properly configured
|
|
319
|
-
- Target directory path is invalid
|
|
320
|
-
- Agent file is malformed
|
|
321
|
-
|
|
322
|
-
Resolution:
|
|
323
|
-
- Verify /agents:architect command exists
|
|
324
|
-
- Check target directory path: $ARGUMENTS
|
|
325
|
-
- Try running agent manually to diagnose
|
|
326
|
-
```
|
|
327
|
-
|
|
328
|
-
2. **Request manual design review**: If the agent cannot run, perform a manual architectural assessment using the criteria below.
|
|
329
|
-
|
|
330
|
-
3. **Do not proceed without resolution**: Block implementation until either the agent runs successfully OR a manual review is completed.
|
|
331
|
-
|
|
332
|
-
#### Validation Checklist
|
|
333
|
-
|
|
334
|
-
After the architect review completes (either via agent or manual), validate the design against these measurable criteria:
|
|
335
|
-
|
|
336
|
-
**Architectural Fit** (Pass/Fail per item):
|
|
337
|
-
- [ ] New code follows naming conventions matching existing files (e.g., if existing files use `UserService.ts`, new services use `*Service.ts` pattern)
|
|
338
|
-
- [ ] Directory structure matches existing project layout (e.g., if existing structure is `src/services/`, `src/controllers/`, new files go in appropriate directories)
|
|
339
|
-
- [ ] No modifications to existing module internals required (integration uses only public APIs/exports)
|
|
340
|
-
- [ ] Import patterns match project standards (e.g., if existing code uses absolute imports via path aliases, new code follows same pattern)
|
|
341
|
-
|
|
342
|
-
**Design Quality** (Pass/Fail per item):
|
|
343
|
-
- [ ] Each component has ≤3 primary responsibilities (single responsibility principle verified by function/class count)
|
|
344
|
-
- [ ] No circular import chains introduced (verify via dependency graph or import analysis)
|
|
345
|
-
- [ ] No god classes planned (components ≤500 LOC based on design estimate)
|
|
346
|
-
- [ ] No anemic wrappers planned (components ≥20 LOC or contain business logic)
|
|
347
|
-
- [ ] Dependencies flow from high-level to low-level modules only (e.g., controllers → services → repositories, never reversed)
|
|
348
|
-
|
|
349
|
-
**Scope & Complexity** (Measurable Thresholds):
|
|
350
|
-
- [ ] New code estimate ≤500 LOC (estimate based on design detail)
|
|
351
|
-
- [ ] New files count ≤10 files (count planned components from design)
|
|
352
|
-
- [ ] New external dependencies ≤3 packages (count npm/pip/etc packages to be added)
|
|
353
|
-
- [ ] Complexity is proportional to requirements (no more than 2 abstraction layers for a single-feature implementation)
|
|
354
|
-
- [ ] Simpler alternative identified and documented (or explicitly noted why this is the simplest approach)
|
|
355
|
-
|
|
356
|
-
**Completeness** (Pass/Fail per item):
|
|
357
|
-
- [ ] Edge cases documented with expected behavior (minimum: null/undefined inputs, empty arrays/objects, boundary values)
|
|
358
|
-
- [ ] Error scenarios have defined handling strategy (minimum: validation errors, network failures, database errors documented with retry/fallback/fail-fast strategy)
|
|
359
|
-
- [ ] Data flow documented from entry point to exit point (minimum: request → processing → response path clearly defined)
|
|
360
|
-
- [ ] API contracts defined with types/schemas (if applicable: input/output types, status codes, error response formats specified)
|
|
361
|
-
- [ ] Testing strategy outlined with coverage targets (minimum: unit test approach defined, integration test scope identified)
|
|
362
|
-
|
|
363
|
-
#### Gate Decision
|
|
364
|
-
|
|
365
|
-
- ✅ **PROCEED** (Score ≥75, no critical gaps) → Continue to Phase 3 (if docs exist) or Summary
|
|
366
|
-
- 🔄 **REVISE** (Score <75 OR critical gaps exist) → **STOP** - Refine design first
|
|
367
|
-
|
|
368
|
-
**Critical Gaps (Auto-Fail Conditions)**:
|
|
369
|
-
|
|
370
|
-
Even if score ≥75, the following issues block implementation:
|
|
371
|
-
- Design contradicts existing architecture without documented justification
|
|
372
|
-
- Missing error handling strategy for critical paths (authentication, payment, data persistence)
|
|
373
|
-
- Scope exceeds single-phase threshold (>500 LOC, >10 files, or >3 new dependencies)
|
|
374
|
-
- Circular dependencies would be introduced
|
|
375
|
-
- No clear data flow or API contracts for user-facing features
|
|
376
|
-
- Breaking changes to existing APIs without migration strategy
|
|
377
|
-
|
|
378
|
-
**Capture for decision**: All critical gaps, concerns, and suggestions from the architect review.
|
|
379
|
-
|
|
380
|
-
---
|
|
381
|
-
|
|
382
|
-
### Phase 3: Documentation Validator (Conditional)
|
|
383
|
-
|
|
384
|
-
**Runs when**: Design documentation files detected in Step 4 (README.md, design docs, specs, PRDs, or implementation plans)
|
|
385
|
-
|
|
386
|
-
**Purpose**: Validate that design documentation meets quality standards before implementation begins. Well-documented designs reduce implementation ambiguity and post-implementation drift.
|
|
387
|
-
|
|
388
|
-
**Invoke via Task tool (if docs detected):**
|
|
389
|
-
```
|
|
390
|
-
Task(
|
|
391
|
-
subagent_type: "docs-validator",
|
|
392
|
-
prompt: "[validator:docs-validator] Validate documentation quality for {TARGET_DIRECTORY}. This is the pre-implementation pipeline. Focus on design documentation completeness: do design docs clearly describe components, data flow, API contracts, and error handling? Return structured JSON OUTPUT with score, decision, and all findings.",
|
|
393
|
-
description: "Docs validation"
|
|
394
|
-
)
|
|
395
|
-
```
|
|
396
|
-
|
|
397
|
-
**Threshold**: ≥75 to proceed
|
|
398
|
-
|
|
399
|
-
**Focus**:
|
|
400
|
-
- Design documentation clarity and completeness
|
|
401
|
-
- Consistency between design docs and any existing README
|
|
402
|
-
- API contract documentation (if applicable)
|
|
403
|
-
- Data flow and architecture diagrams/descriptions
|
|
404
|
-
|
|
405
|
-
**Capture for features list**: All documentation issues, especially those that could cause implementation ambiguity.
|
|
406
|
-
|
|
407
|
-
#### Gate Decision
|
|
408
|
-
|
|
409
|
-
- ✅ **DOCUMENTED** (Score ≥75) → Continue to Summary
|
|
410
|
-
- ⚠️ **PARTIALLY_DOCUMENTED** (Score 60-74) → Note gaps, proceed with caution
|
|
411
|
-
- 🔄 **UNDERDOCUMENTED** (Score <60) → **STOP** - Improve documentation before coding
|
|
412
|
-
|
|
413
|
-
**Note:** Unlike architecture review, docs-validator is advisory. Score <75 generates warnings but doesn't block implementation if architect review passed. However, poor documentation often leads to implementation drift.
|
|
414
|
-
|
|
415
|
-
---
|
|
416
|
-
|
|
417
|
-
## Completion Status
|
|
418
|
-
|
|
419
|
-
**Fill instructions**: Replace all bracketed placeholders with actual values from the review:
|
|
420
|
-
- `$ARGUMENTS` → actual target directory path
|
|
421
|
-
- `[✅ PROCEED / 🔄 REVISE]` → choose one based on architect score
|
|
422
|
-
- `[X]` → actual numeric score
|
|
423
|
-
- `[✅ Complete / ⚠️ Gaps identified]` → based on completeness checklist results
|
|
424
|
-
- `[✅ Appropriate / ⚠️ Too large]` → based on scope metrics (LOC, files, dependencies)
|
|
425
|
-
- `[✅ Low / ⚠️ Medium / 🔴 High]` → based on risk assessment from architect review
|
|
426
|
-
- `[DOCUMENTED / PARTIALLY / SKIPPED]` → based on docs-validator result (or skipped if no docs)
|
|
427
|
-
- `[Specific item to address]` → actual critical gaps or concerns from the review
|
|
428
|
-
|
|
429
|
-
```
|
|
430
|
-
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
431
|
-
PRE-IMPLEMENTATION SUMMARY
|
|
432
|
-
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
433
|
-
|
|
434
|
-
📁 Target: $ARGUMENTS
|
|
435
|
-
|
|
436
|
-
Architecture Review: [✅ PROCEED / 🔄 REVISE]
|
|
437
|
-
Score: [X]/100
|
|
438
|
-
Design Completeness: [✅ Complete / ⚠️ Gaps identified]
|
|
439
|
-
Scope Assessment: [✅ Appropriate / ⚠️ Too large]
|
|
440
|
-
Risk Assessment: [✅ Low / ⚠️ Medium / 🔴 High]
|
|
441
|
-
|
|
442
|
-
Docs Validation: [✅ DOCUMENTED / ⚠️ PARTIALLY / ℹ️ SKIPPED]
|
|
443
|
-
Score: [X]/100 (or N/A if skipped)
|
|
444
|
-
|
|
445
|
-
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
446
|
-
|
|
447
|
-
[✅ PROCEED - Ready to begin implementation]
|
|
448
|
-
OR
|
|
449
|
-
[🔄 REVISE - Address the following before coding:]
|
|
450
|
-
|
|
451
|
-
1. [Specific item to address]
|
|
452
|
-
2. [Specific item to address]
|
|
453
|
-
3. [Specific item to address]
|
|
454
|
-
|
|
455
|
-
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
456
|
-
```
|
|
457
|
-
|
|
458
|
-
---
|
|
459
|
-
|
|
460
|
-
## Save to Uluops Tracker (MANDATORY)
|
|
461
|
-
|
|
462
|
-
After completing validation, **you must also** save results to the uluops-tracker MCP server for persistent tracking and cross-run correlation.
|
|
463
|
-
|
|
464
|
-
**Call the MCP tool** `mcp__uluops-tracker__save_features_list` with:
|
|
465
|
-
|
|
466
|
-
```
|
|
467
|
-
project: {TARGET_NAME}
|
|
468
|
-
workflow_type: "pre-implementation"
|
|
469
|
-
timestamp: {ISO8601 timestamp, e.g., "2025-01-15T14:30:00Z"}
|
|
470
|
-
validators: [
|
|
471
|
-
{
|
|
472
|
-
"name": "pre-implementation-architect",
|
|
473
|
-
"score": {numeric score from architect review},
|
|
474
|
-
"status": "{PROCEED|REVISE}",
|
|
475
|
-
"model": "sonnet",
|
|
476
|
-
"tokens": { "input_tokens": {number}, "output_tokens": {number} }
|
|
477
|
-
},
|
|
478
|
-
// Include docs-validator only if it ran (docs detected)
|
|
479
|
-
{
|
|
480
|
-
"name": "docs-validator",
|
|
481
|
-
"score": {numeric score from docs review},
|
|
482
|
-
"status": "{DOCUMENTED|PARTIALLY_DOCUMENTED|UNDERDOCUMENTED}",
|
|
483
|
-
"model": "sonnet",
|
|
484
|
-
"tokens": { "input_tokens": {number}, "output_tokens": {number} }
|
|
485
|
-
}
|
|
486
|
-
]
|
|
487
|
-
recommendations: [
|
|
488
|
-
{
|
|
489
|
-
"validator": "pre-implementation-architect",
|
|
490
|
-
"title": "{short title of gap or concern}",
|
|
491
|
-
"priority": "{critical|suggested|backlog}",
|
|
492
|
-
"severity": "{critical|high|medium|low|info}",
|
|
493
|
-
"failure_code": "{DOMAIN-MODE/SEVERITY}",
|
|
494
|
-
"description": "{optional details}",
|
|
495
|
-
"file_path": "{optional file path if applicable}",
|
|
496
|
-
"line_number": {optional line number if applicable}
|
|
497
|
-
},
|
|
498
|
-
// Include docs-validator recommendations if it ran
|
|
499
|
-
{
|
|
500
|
-
"validator": "docs-validator",
|
|
501
|
-
"title": "{short title of doc issue}",
|
|
502
|
-
"priority": "{critical|suggested|backlog}",
|
|
503
|
-
"severity": "{critical|high|medium|low|info}",
|
|
504
|
-
"failure_code": "{DOMAIN-MODE/SEVERITY}",
|
|
505
|
-
"description": "{optional details}",
|
|
506
|
-
"file_path": "{doc file path}"
|
|
507
|
-
},
|
|
508
|
-
// ... one entry per recommendation/gap
|
|
509
|
-
]
|
|
510
|
-
```
|
|
511
|
-
|
|
512
|
-
**Priority mapping:**
|
|
513
|
-
- Critical gaps (auto-fail conditions) → `"critical"`
|
|
514
|
-
- Architectural concerns/suggestions → `"suggested"`
|
|
515
|
-
- Future considerations/tech debt → `"backlog"`
|
|
516
|
-
|
|
517
|
-
**Token estimation guidance:**
|
|
518
|
-
|
|
519
|
-
Each agent run typically uses 35,000-60,000+ tokens:
|
|
520
|
-
|
|
521
|
-
| Component | Typical Range | Notes |
|
|
522
|
-
|-----------|---------------|-------|
|
|
523
|
-
| System context | ~15,000 | Claude Code system prompt, tools, history |
|
|
524
|
-
| Agent prompt | 2,000-5,000 | The agent's markdown prompt file |
|
|
525
|
-
| Code context | 10,000-30,000 | Files analyzed (varies by project) |
|
|
526
|
-
| **Total Input** | **30,000-50,000** | Sum of above |
|
|
527
|
-
| Agent output | 3,000-8,000 | Analysis and recommendations |
|
|
528
|
-
|
|
529
|
-
**Quick estimation by project size:**
|
|
530
|
-
- Small (<10 files): ~35,000 input / ~4,000 output
|
|
531
|
-
- Medium (10-30 files): ~45,000 input / ~6,000 output
|
|
532
|
-
- Large (30+ files): ~60,000+ input / ~8,000 output
|
|
533
|
-
|
|
534
|
-
**Example MCP call (both validators ran):**
|
|
535
|
-
|
|
536
|
-
```
|
|
537
|
-
mcp__uluops-tracker__save_features_list({
|
|
538
|
-
project: "new-auth-service",
|
|
539
|
-
workflow_type: "pre-implementation",
|
|
540
|
-
timestamp: "2025-01-15T10:30:00Z",
|
|
541
|
-
validators: [
|
|
542
|
-
{ name: "pre-implementation-architect", score: 82, status: "PROCEED", model: "sonnet", tokens: { input_tokens: 42000, output_tokens: 5800 } },
|
|
543
|
-
{ name: "docs-validator", score: 78, status: "DOCUMENTED", model: "sonnet", tokens: { input_tokens: 35000, output_tokens: 4200 } }
|
|
544
|
-
],
|
|
545
|
-
recommendations: [
|
|
546
|
-
{
|
|
547
|
-
validator: "pre-implementation-architect",
|
|
548
|
-
title: "Consider caching strategy",
|
|
549
|
-
priority: "suggested",
|
|
550
|
-
description: "Token validation could benefit from caching layer"
|
|
551
|
-
},
|
|
552
|
-
{
|
|
553
|
-
validator: "pre-implementation-architect",
|
|
554
|
-
title: "Document rate limiting approach",
|
|
555
|
-
priority: "backlog",
|
|
556
|
-
description: "Rate limiting mentioned but not fully specified"
|
|
557
|
-
},
|
|
558
|
-
{
|
|
559
|
-
validator: "docs-validator",
|
|
560
|
-
title: "Missing API contract documentation",
|
|
561
|
-
priority: "suggested",
|
|
562
|
-
severity: "medium",
|
|
563
|
-
failure_code: "STR-OMI/M",
|
|
564
|
-
description: "Design doc mentions REST endpoints but no OpenAPI spec or input/output schemas",
|
|
565
|
-
file_path: "docs/design.md"
|
|
566
|
-
}
|
|
567
|
-
]
|
|
568
|
-
})
|
|
569
|
-
```
|
|
570
|
-
|
|
571
|
-
**Benefits of uluops-tracker integration:**
|
|
572
|
-
- **Cross-run correlation**: Track design decisions across pre-impl and post-impl phases
|
|
573
|
-
- **Regression detection**: Alerts when addressed concerns reappear in later reviews
|
|
574
|
-
- **Design debt tracking**: Architectural suggestions that weren't immediately addressed
|
|
575
|
-
- **Historical trends**: Track architect scores across projects over time
|
|
576
|
-
- **Queryable backlog**: Search and filter design concerns by status/priority
|
|
577
|
-
|
|
578
|
-
---
|
|
579
|
-
|
|
580
|
-
## Next Steps
|
|
581
|
-
|
|
582
|
-
**If approved (PROCEED)**:
|
|
583
|
-
- Begin implementation following the validated design
|
|
584
|
-
- After each implementation phase, run `/workflows:post-impl $ARGUMENTS`
|
|
585
|
-
- Refer back to this review if design questions arise during implementation
|
|
586
|
-
|
|
587
|
-
**If revision needed (REVISE)**:
|
|
588
|
-
- Address all critical gaps identified in the review
|
|
589
|
-
- Update design documentation with resolutions
|
|
590
|
-
- Re-run `/workflows:pre-impl $ARGUMENTS` to validate the updated design
|
|
591
|
-
- Do not begin implementation until PROCEED status achieved
|
|
592
|
-
|
|
593
|
-
---
|
|
594
|
-
|
|
595
|
-
## When to Run This Workflow
|
|
596
|
-
|
|
597
|
-
**Run pre-implementation review when**:
|
|
598
|
-
- Starting a new feature or service
|
|
599
|
-
- Refactoring existing architecture
|
|
600
|
-
- Implementing a user story with technical design
|
|
601
|
-
- Adding significant new functionality (>100 LOC)
|
|
602
|
-
|
|
603
|
-
**Skip pre-implementation review for**:
|
|
604
|
-
- Bug fixes that don't change architecture
|
|
605
|
-
- Documentation-only changes
|
|
606
|
-
- Test-only additions
|
|
607
|
-
- Configuration tweaks
|
|
608
|
-
- Dependency version updates without API changes
|
|
609
|
-
|
|
610
|
-
---
|
|
611
|
-
|
|
612
|
-
## Quick Reference
|
|
613
|
-
|
|
614
|
-
| Phase | Focus | Threshold | Condition |
|
|
615
|
-
|-------|-------|-----------|-----------|
|
|
616
|
-
| Gather Context | Find design docs, understand requirements | N/A (informational) | Always |
|
|
617
|
-
| Architecture Review | Pattern fit, complexity, completeness | ≥75 to proceed | Always |
|
|
618
|
-
| Docs Validation | Documentation quality and completeness | ≥75 (advisory) | If docs detected |
|
|
619
|
-
|
|
620
|
-
**Execution Modes**: Sequential (default) or Parallel (user-selected)
|
|
621
|
-
|
|
622
|
-
**Decision Pairs**:
|
|
623
|
-
- Architecture: PROCEED (✅) / REVISE (🔄)
|
|
624
|
-
- Documentation: DOCUMENTED (✅) / PARTIALLY_DOCUMENTED (⚠️) / UNDERDOCUMENTED (🔄)
|
|
625
|
-
|
|
626
|
-
**Critical Success Factors**:
|
|
627
|
-
- Design documentation exists and is specific
|
|
628
|
-
- Architect review score ≥75
|
|
629
|
-
- No critical gaps identified
|
|
630
|
-
- Scope is appropriate for one implementation phase
|
|
631
|
-
- Documentation quality score ≥75 (if docs exist)
|
|
632
|
-
|
|
633
|
-
**Integration Points**:
|
|
634
|
-
- **Before**: Project planning, PRD creation, design discussions
|
|
635
|
-
- **After**: `/workflows:post-impl` (run after each implementation phase)
|
|
636
|
-
|
|
637
|
-
---
|
|
638
|
-
|
|
639
|
-
## Troubleshooting
|
|
640
|
-
|
|
641
|
-
### "Agent Task invocation fails"
|
|
642
|
-
|
|
643
|
-
If the Task tool invocation fails for either agent:
|
|
644
|
-
1. Verify the `subagent_type` is correct: `pre-implementation-architect` or `docs-validator`
|
|
645
|
-
2. Check that the target directory path is valid
|
|
646
|
-
3. Ensure the `[validator:NAME]` tag is included in the prompt
|
|
647
|
-
4. Fall back to manual review using the checklist above
|
|
648
|
-
|
|
649
|
-
### "Design docs not found but design is verbal/in conversation"
|
|
650
|
-
|
|
651
|
-
If the design was discussed but not documented:
|
|
652
|
-
1. Capture the key design decisions in a brief README or design.md
|
|
653
|
-
2. Include: components, data flow, API contracts, testing approach
|
|
654
|
-
3. Re-run the workflow with the documented design
|
|
655
|
-
|
|
656
|
-
### "Score is borderline (70-75)"
|
|
657
|
-
|
|
658
|
-
If the architect score is close to threshold:
|
|
659
|
-
1. Review critical gaps carefully - any auto-fail condition should trigger REVISE
|
|
660
|
-
2. Consider if proceeding creates significant refactoring risk
|
|
661
|
-
3. When in doubt, add clarity to the design and re-run
|
|
662
|
-
|
|
663
|
-
### "Validation tracker MCP not available"
|
|
664
|
-
|
|
665
|
-
If the `mcp__uluops-tracker__save_features_list` tool is not available:
|
|
666
|
-
1. Check if the uluops-tracker MCP server is configured in your Claude Code settings
|
|
667
|
-
2. Verify the MCP server is running
|
|
668
|
-
3. The workflow can complete without saving to tracker, but historical tracking will be unavailable
|
|
669
|
-
|
|
670
|
-
The pre-implementation review is always performed regardless of MCP availability. The uluops-tracker integration is additive—it enables historical tracking but is not required for the workflow to complete.
|
|
File without changes
|