@tyvm/knowhow 0.0.159 → 0.0.160

package/tests/patching/transcriptMangleRegression.test.ts

@@ -1,125 +0,0 @@
-import { patchFile } from "../../src/agents/tools/patch";
-import * as fs from "fs";
-import * as os from "os";
-import * as path from "path";
-
-type Fixture = {
-  taskId: string;
-  sourceBefore: string;
-  patch: string;
-  observedAfter: string;
-  expectedAfter?: string;
-  agentStatement: string;
-};
-
-const fixtureDir = path.join(__dirname, "fixtures", "transcript-mangles");
-const loadFixture = (name: string): Fixture =>
-  JSON.parse(fs.readFileSync(path.join(fixtureDir, `${name}.json`), "utf8"));
-const mockToolService = { getContext: () => ({ Events: null }) };
-const boundPatch = (patchFile as any).bind(mockToolService);
-
-function replaceOnce(source: string, before: string, after: string): string {
-  expect(source.split(before)).toHaveLength(2);
-  return source.replace(before, after);
-}
-
-function expectedAgentSyncFs(source: string): string {
-  let expected = replaceOnce(
-    source,
-    `   * consecutive calls can reveal when a cache prefix was invalidated.\n   */`,
-    `   * consecutive calls can reveal when a cache prefix was invalidated.\n   *\n   * To prevent exponential file growth, if the new entry's message thread\n   * fully contains the previous entry's thread as a prefix, the previous\n   * thread is replaced with { PREV_CACHE_HIT: true } so only the new\n   * messages (the delta) are stored alongside the new usage data.\n   */`
-  );
-  expected = replaceOnce(
-    expected,
-    `      entries.push(entry);`,
-    `      // If the new entry's messages are a superset of the last entry's\n      // messages (i.e. the last thread is a prefix of the new thread),\n      // collapse the last entry's messages to { PREV_CACHE_HIT: true }\n      // and store only the new delta — preventing exponential growth.\n      if (entries.length > 0) {\n        const lastEntry = entries[entries.length - 1];\n        const prevMessages: any[] = lastEntry?.messages;\n        const newMessages: any[] = entry?.messages;\n        if (\n          Array.isArray(prevMessages) &&\n          Array.isArray(newMessages) &&\n          prevMessages.length > 0 &&\n          newMessages.length >= prevMessages.length &&\n          JSON.stringify(newMessages.slice(0, prevMessages.length)) ===\n            JSON.stringify(prevMessages)\n        ) {\n          // Replace the previous full thread with a compact sentinel\n          lastEntry.messages = [{ PREV_CACHE_HIT: true }];\n        }\n      }\n\n      entries.push(entry);`
-  );
-  return expected;
-}
-
-function expectedAutomation(source: string): string {
-  const anchor = `export function automationPath(name: string): string {\n  const safe = name.replace(/[^a-zA-Z0-9_-]/g, "_");\n  return path.join(STORE_DIR, \`\${safe}.ts\`);\n}\n`;
-  const parser = `\n/**\n * Extract the structured "skill card" from an automation script. We look for a\n * leading block comment (before any executable code) and read JSDoc-style tags:\n *   @description  one-liner of what it does\n *   @useWhen      the situation/trigger that should make an agent pick this\n *   @startState   what the screen must look like BEFORE running\n *   @endState     what the screen will look like AFTER it finishes\n *   @window       the required window (title/app) it operates on\n *   @notes        anything else worth knowing (limits, caveats)\n * Tag text may wrap onto continuation lines. Returns undefined when no\n * recognizable header is present.\n */\nexport function parseAutomationDoc(script: string): AutomationDoc | undefined {\n  const block = script.match(/^\\s*\\/\\*\\*?([\\s\\S]*?)\\*\\//);\n  if (!block) return undefined;\n  // Strip leading " * " decoration from each comment line.\n  const body = block[1]\n    .split("\\n")\n    .map((l) => l.replace(/^\\s*\\*?\\s?/, ""))\n    .join("\\n");\n\n  const tags: Record<string, string> = {};\n  let current: string | null = null;\n  const known = new Set([\n    "description",\n    "usewhen",\n    "startstate",\n    "endstate",\n    "window",\n    "notes",\n  ]);\n  for (const rawLine of body.split("\\n")) {\n    const line = rawLine.trimEnd();\n    const m = line.match(/^@(\\w+)\\s*(.*)$/);\n    if (m && known.has(m[1].toLowerCase())) {\n      current = m[1].toLowerCase();\n      tags[current] = m[2].trim();\n    } else if (current && line.trim()) {\n      tags[current] = (tags[current] + " " + line.trim()).trim();\n    }\n  }\n  if (!Object.keys(tags).length) return undefined;\n  const doc: AutomationDoc = {\n    description: tags["description"],\n    useWhen: tags["usewhen"],\n    startState: tags["startstate"],\n    endState: tags["endstate"],\n    window: tags["window"],\n    notes: tags["notes"],\n  };\n  // Drop empty keys for a tidy summary.\n  for (const k of Object.keys(doc) as (keyof AutomationDoc)[]) {\n    if (!doc[k]) delete doc[k];\n  }\n  return Object.keys(doc).length ? doc : undefined;\n}\n`;
-  let expected = replaceOnce(source, anchor, anchor + parser);
-  expected = replaceOnce(
-    expected,
-    `  return spec;`,
-    `  return { ...spec, doc: parseAutomationDoc(spec.script), filePath: automationPath(spec.name) };`
-  );
-  expected = replaceOnce(
-    expected,
-    `      return { name, script: fs.readFileSync(p, "utf8") };`,
-    `      const script = fs.readFileSync(p, "utf8");\n      return { name, script, doc: parseAutomationDoc(script), filePath: p };`
-  );
-  expected = replaceOnce(
-    expected,
-    `    return { name, script: parsed.script };`,
-    `    return {\n      name,\n      script: parsed.script,\n      doc: parseAutomationDoc(parsed.script || ""),\n      filePath: legacy,\n    };`
-  );
-  return expected;
-}
-
-describe("patchFile transcript-derived mangling regressions", () => {
-  async function expectExactEditOrSafeRejection(
-    name: string,
-    buildExpected: (source: string) => string
-  ): Promise<void> {
-    const fixture = loadFixture(name);
-    const dir = fs.mkdtempSync(path.join(os.tmpdir(), "patch-transcript-"));
-    const testFile = path.join(dir, `${name}.ts`);
-    fs.writeFileSync(testFile, fixture.sourceBefore);
-
-    try {
-      const result = await boundPatch(testFile, fixture.patch);
-      const actual = fs.readFileSync(testFile, "utf8");
-      if (result.includes("❌ Patch failed")) {
-        expect(actual).toBe(fixture.sourceBefore);
-      } else {
-        expect(actual).toBe(buildExpected(fixture.sourceBefore));
-      }
-    } finally {
-      fs.rmSync(dir, { recursive: true, force: true });
-    }
-  }
-
-  // Regression from task 1785613689: malformed hunk counts previously caused
-  // `diff.applyPatch` to move the catch and duplicate entries.push.
-  it(
-    "agent-sync-fs patch applies exactly or rejects without changing the file",
-    async () => {
-      await expectExactEditOrSafeRejection(
-        "agent-sync-fs-nested-catch",
-        expectedAgentSyncFs
-      );
-    }
-  );
-
-  it("automation patch applies exactly or rejects without changing the file", async () => {
-    await expectExactEditOrSafeRejection(
-      "automation-functions-crossed",
-      expectedAutomation
-    );
-  });
-
-  // Regression from task 1785784065: the malformed final hunk's declared
-  // counts omit the remainder of sdk.log. The current autofix reconstructs
-  // the intended edit exactly instead of crossing the two adjacent blocks.
-  it(
-    "fruit-ninja confirmed-retirement patch applies exactly",
-    async () => {
-      const fixture = loadFixture("fruit-ninja-confirmed-retirement");
-      const dir = fs.mkdtempSync(path.join(os.tmpdir(), "patch-transcript-"));
-      const testFile = path.join(dir, "fruitNinjaPrecision.ts");
-      fs.writeFileSync(testFile, fixture.sourceBefore);
-
-      try {
-        const result = await boundPatch(testFile, fixture.patch);
-        expect(result).not.toContain("❌ Patch failed");
-        const actual = fs.readFileSync(testFile, "utf8");
-        expect(actual).toBe(fixture.expectedAfter);
-      } finally {
-        fs.rmSync(dir, { recursive: true, force: true });
-      }
-    }
-  );
-});

package/tests/plugins/language/languagePlugin-content-triggers.test.ts

@@ -1,346 +0,0 @@
-import { LanguagePlugin } from "../../../src/plugins/language";
-import { EventService } from "../../../src/services/EventService";
-import { PluginService } from "../../../src/plugins/plugins";
-import * as utils from "../../../src/utils";
-import { getConfig, getLanguageConfig } from "../../../src/config";
-
-jest.mock("../../../src/utils", () => ({
-  readFile: jest.fn(),
-  fileExists: jest.fn().mockReturnValue(true),
-  fileStat: jest.fn().mockResolvedValue({
-    isDirectory: jest.fn().mockReturnValue(false),
-    isFile: jest.fn().mockReturnValue(true),
-    size: 1024,
-  }),
-}));
-
-jest.mock("../../../src/services/EventService", () => ({
-  EventService: jest.fn().mockImplementation(() => ({
-    on: jest.fn(),
-    emit: jest.fn(),
-    log: jest.fn(),
-  })),
-}));
-
-jest.mock("../../../src/config", () => ({
-  getConfig: jest.fn(),
-  getConfigSync: jest.fn(),
-  getLanguageConfig: jest.fn(),
-}));
-
-jest.mock("../../../src/plugins/plugins", () => ({
-  PluginService: jest.fn().mockImplementation(() => ({
-    listPlugins: jest.fn(),
-    call: jest.fn(),
-  })),
-}));
-
-const mockedConfig = getConfig as jest.MockedFunction<typeof getConfig>;
-const mockedLanguageConfig = getLanguageConfig as jest.MockedFunction<
-  typeof getLanguageConfig
->;
-const mockedReadFile = utils.readFile as jest.MockedFunction<
-  typeof utils.readFile
->;
-
-describe("LanguagePlugin - Content-Based Triggering", () => {
-  let mockEventService: any;
-  let mockPluginService: any;
-  let eventHandlers: Map<string, Function>;
-
-  beforeEach(() => {
-    eventHandlers = new Map();
-    mockEventService = {
-      on: jest.fn((event: string, handler: Function) => {
-        eventHandlers.set(event, handler);
-      }),
-      emit: jest.fn(),
-      log: jest.fn(),
-    };
-
-    mockPluginService = {
-      listPlugins: jest.fn().mockReturnValue(["github"]),
-      call: jest.fn().mockResolvedValue(["plugin context data"]),
-    };
-
-    jest.clearAllMocks();
-  });
-
-  test("should trigger on file content containing test functions", async () => {
-    // Mock file content that contains test functions
-    const fileContentWithTests = `
-      import { expect } from 'jest';
-
-      describe('MyComponent', () => {
-        test('should render correctly', () => {
-          expect(component).toBeTruthy();
-        });
-
-        it('should handle click events', () => {
-          // test implementation
-        });
-      });
-    `;
-
-    mockedReadFile.mockResolvedValue(Buffer.from(fileContentWithTests));
-    mockedConfig.mockResolvedValue({
-      plugins: { enabled: [], disabled: [] },
-      modules: [],
-      promptsDir: ".knowhow/prompts",
-      sources: [],
-      embedSources: [],
-      embeddingModel: "text-embedding-ada-002",
-      agents: [],
-      mcps: [],
-      modelProviders: [],
-    });
-    mockedLanguageConfig.mockResolvedValue({
-      "test(": {
-        events: ["file:post-read"],
-        sources: [
-          { kind: "text", data: ["Jest testing best practices"] },
-          { kind: "file", data: ["docs/testing-guidelines.md"] },
-        ],
-      },
-    });
-
-    new LanguagePlugin({
-      Events: mockEventService,
-      Plugins: mockPluginService,
-    } as any);
-
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    // Trigger file:post-read event
-    const fileReadHandler = eventHandlers.get("file:post-read");
-    expect(fileReadHandler).toBeDefined();
-
-    await fileReadHandler!({
-      filePath: "src/components/MyComponent.spec.ts",
-      operation: "read",
-    });
-
-    await new Promise((resolve) => setTimeout(resolve, 10));
-
-    // Verify that the content-based trigger was activated
-    expect(mockEventService.emit).toHaveBeenCalledWith(
-      "agent:msg",
-      expect.stringMatching(
-        /<Workflow>[\s\S]*language_context_trigger[\s\S]*<\/Workflow>/
-      )
-    );
-
-    const emitCall = mockEventService.emit.mock.calls.find(
-      (call) => call[0] === "agent:msg"
-    );
-    expect(emitCall).toBeDefined();
-
-    // Extract JSON from <Workflow> tags
-    const workflowContent = emitCall![1].match(/<Workflow>\s*(\{[\s\S]*?\})\s*<\/Workflow>/);
-    expect(workflowContent).toBeDefined();
-    const eventData = JSON.parse(workflowContent![1]);
-    expect(eventData.type).toBe("language_context_trigger");
-    expect(eventData.matchingTerms).toContain("test(");
-    expect(eventData.contextMessage).toContain("Jest testing best practices");
-  });
-
-  test("should not trigger when file content doesn't match", async () => {
-    // Mock file content without trigger terms
-    const fileContent = `
-      const config = {
-        database: 'postgresql',
-        port: 5432
-      };
-    `;
-
-    mockedReadFile.mockResolvedValue(Buffer.from(fileContent));
-    mockedConfig.mockResolvedValue({
-      plugins: { enabled: [], disabled: [] },
-      modules: [],
-      promptsDir: ".knowhow/prompts",
-      sources: [],
-      embedSources: [],
-      embeddingModel: "text-embedding-ada-002",
-      agents: [],
-      mcps: [],
-      modelProviders: [],
-    });
-    mockedLanguageConfig.mockResolvedValue({
-      "test(": {
-        events: ["file:post-read"],
-        sources: [{ kind: "text", data: ["Jest testing best practices"] }],
-      },
-    });
-
-    new LanguagePlugin({
-      Events: mockEventService,
-      Plugins: mockPluginService,
-    } as any);
-
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    // Trigger file:post-read event
-    const fileReadHandler = eventHandlers.get("file:post-read");
-    expect(fileReadHandler).toBeDefined();
-
-    await fileReadHandler!({
-      filePath: "src/config.js",
-      operation: "read",
-    });
-
-    await new Promise((resolve) => setTimeout(resolve, 10));
-
-    // Verify no trigger was activated
-    expect(mockEventService.emit).not.toHaveBeenCalled();
-  });
-
-  test("should handle file read errors gracefully", async () => {
-    // Mock readFile to throw an error
-    mockedReadFile.mockRejectedValue(new Error("File not found"));
-    mockedConfig.mockResolvedValue({
-      plugins: { enabled: [], disabled: [] },
-      modules: [],
-      promptsDir: ".knowhow/prompts",
-      sources: [],
-      embedSources: [],
-      embeddingModel: "text-embedding-ada-002",
-      agents: [],
-      mcps: [],
-      modelProviders: [],
-    });
-    mockedLanguageConfig.mockResolvedValue({
-      "test(": {
-        events: ["file:post-read"],
-        sources: [{ kind: "text", data: ["Jest testing best practices"] }],
-      },
-    });
-
-    new LanguagePlugin({
-      Events: mockEventService,
-      Plugins: mockPluginService,
-    } as any);
-
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    // Trigger file:post-read event
-    const fileReadHandler = eventHandlers.get("file:post-read");
-    expect(fileReadHandler).toBeDefined();
-
-    await fileReadHandler!({
-      filePath: "src/nonexistent.test.js",
-      operation: "read",
-    });
-
-    await new Promise((resolve) => setTimeout(resolve, 10));
-
-    // Verify no crash occurred and no trigger was activated
-    expect(mockEventService.emit).not.toHaveBeenCalled();
-  });
-
-  test("should work with case-insensitive matching", async () => {
-    // Mock file content with uppercase TEST
-    const fileContent = `
-      function myTEST() {
-        return true;
-      }
-    `;
-
-    mockedReadFile.mockResolvedValue(Buffer.from(fileContent));
-    mockedConfig.mockResolvedValue({
-      plugins: { enabled: [], disabled: [] },
-      modules: [],
-      promptsDir: ".knowhow/prompts",
-      sources: [],
-      embedSources: [],
-      embeddingModel: "text-embedding-ada-002",
-      agents: [],
-      mcps: [],
-      modelProviders: [],
-    });
-    mockedLanguageConfig.mockResolvedValue({
-      "test(": {
-        events: ["file:post-read"],
-        sources: [{ kind: "text", data: ["Jest testing best practices"] }],
-      },
-    });
-
-    new LanguagePlugin({
-      Events: mockEventService,
-      Plugins: mockPluginService,
-    } as any);
-
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    // Trigger file:post-read event
-    const fileReadHandler = eventHandlers.get("file:post-read");
-    expect(fileReadHandler).toBeDefined();
-
-    await fileReadHandler!({
-      filePath: "src/utils.js",
-      operation: "read",
-    });
-
-    await new Promise((resolve) => setTimeout(resolve, 10));
-
-    // Verify that case-insensitive matching worked
-    expect(mockEventService.emit).toHaveBeenCalledWith(
-      "agent:msg",
-      expect.stringMatching(
-        /<Workflow>[\s\S]*language_context_trigger[\s\S]*<\/Workflow>/
-      )
-    );
-  });
-
-  test("should trigger on file:post-edit events", async () => {
-    const fileContent = `
-      test('new test case', () => {
-        expect(true).toBe(true);
-      });
-    `;
-
-    mockedReadFile.mockResolvedValue(Buffer.from(fileContent));
-    mockedConfig.mockResolvedValue({
-      plugins: { enabled: [], disabled: [] },
-      modules: [],
-      promptsDir: ".knowhow/prompts",
-      sources: [],
-      embedSources: [],
-      embeddingModel: "text-embedding-ada-002",
-      agents: [],
-      mcps: [],
-      modelProviders: [],
-    });
-    mockedLanguageConfig.mockResolvedValue({
-      "test(": {
-        events: ["file:post-read", "file:post-edit"],
-        sources: [{ kind: "text", data: ["Jest testing best practices"] }],
-      },
-    });
-
-    new LanguagePlugin({
-      Events: mockEventService,
-      Plugins: mockPluginService,
-    } as any);
-
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    // Trigger file:post-edit event instead of read
-    const fileEditHandler = eventHandlers.get("file:post-edit");
-    expect(fileEditHandler).toBeDefined();
-
-    await fileEditHandler!({
-      filePath: "src/newFeature.test.js",
-      operation: "edit",
-    });
-
-    await new Promise((resolve) => setTimeout(resolve, 10));
-
-    // Verify that edit events also trigger content analysis
-    expect(mockEventService.emit).toHaveBeenCalledWith(
-      "agent:msg",
-      expect.stringMatching(
-        /<Workflow>[\s\S]*language_context_trigger[\s\S]*<\/Workflow>/
-      )
-    );
-  });
-});