@truedat/dq 7.5.9 → 7.5.11

package/src/selectors/__tests__/getRuleImplementationForm.spec.js

@@ -2,12 +2,12 @@ import {
   getSystemInRuleDetail,
   getGroupsInRuleDetail,
   getStructuresInRuleDetail,
-  getFieldsInRuleDetail
+  getFieldsInRuleDetail,
 } from "..";
 
 const system = [
   { name: "SYS1", resource_type: "system", resource_id: "SYS1" },
-  { name: "SYS2", resource_type: "system", resource_id: "SYS2" }
+  { name: "SYS2", resource_type: "system", resource_id: "SYS2" },
 ];
 
 const group = [
@@ -15,14 +15,14 @@ const group = [
     name: "group1",
     resource_type: "group",
     resource_id: "group1",
-    parent_key: "SYS1"
+    parent_key: "SYS1",
   },
   {
     name: "group2",
     resource_type: "group",
     resource_id: "group2",
-    parent_key: "SYS2"
-  }
+    parent_key: "SYS2",
+  },
 ];
 
 const table = [
@@ -30,14 +30,14 @@ const table = [
     name: "table1",
     resource_type: "table",
     resource_id: "1",
-    parent_key: "group1"
+    parent_key: "group1",
   },
   {
     name: "table2",
     resource_type: "table",
     resource_id: "2",
-    parent_key: "group2"
-  }
+    parent_key: "group2",
+  },
 ];
 
 const column = [
@@ -45,14 +45,14 @@ const column = [
     name: "column1",
     resource_type: "table",
     resource_id: "1",
-    parent_key: "1"
+    parent_key: "1",
   },
   {
     name: "column2",
     resource_type: "column",
     resource_id: "2",
-    parent_key: "2"
-  }
+    parent_key: "2",
+  },
 ];
 
 const system_values = { system, group, table, column };
@@ -64,7 +64,7 @@ describe("selectors: getRuleImplementationForm", () => {
     expect(systems.length).toBe(2);
     expect(systems).toEqual([
       { text: "SYS1", value: "SYS1" },
-      { text: "SYS2", value: "SYS2" }
+      { text: "SYS2", value: "SYS2" },
     ]);
   });
 
@@ -72,7 +72,7 @@ describe("selectors: getRuleImplementationForm", () => {
     const groups = getGroupsInRuleDetail({ rule });
     expect(groups).toEqual({
       SYS1: [{ text: "group1", value: "group1" }],
-      SYS2: [{ text: "group2", value: "group2" }]
+      SYS2: [{ text: "group2", value: "group2" }],
     });
   });
 
@@ -80,15 +80,15 @@ describe("selectors: getRuleImplementationForm", () => {
     const tables = getStructuresInRuleDetail({ rule });
     expect(tables).toEqual({
       group1: [{ text: "table1", value: "1" }],
-      group2: [{ text: "table2", value: "2" }]
+      group2: [{ text: "table2", value: "2" }],
     });
   });
 
   it("should return all fields on getFieldsInRuleDetail", () => {
     const fields = getFieldsInRuleDetail({ rule });
     expect(fields).toEqual({
-      "1": [{ text: "column1", value: "1" }],
-      "2": [{ text: "column2", value: "2" }]
+      1: [{ text: "column1", value: "1" }],
+      2: [{ text: "column2", value: "2" }],
     });
   });
 });

package/src/selectors/__tests__/getRuleImplementationSelectedFilterActiveValues.spec.js

@@ -11,12 +11,12 @@ describe("selectors: getRuleImplementationSelectedFilterActiveValues", () => {
   const state = {
     ruleImplementationFilters,
     ruleImplementationActiveFilters,
-    ruleImplementationSelectedFilter
+    ruleImplementationSelectedFilter,
   };
 
   it("should return the active values of the currently selected ruleImplementation filters", () => {
     expect(getRuleImplementationSelectedFilterActiveValues(state)).toEqual([
-      "foo1"
+      "foo1",
     ]);
   });
 });

package/src/selectors/getImplementationStructureLinksColumns.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import PropTypes from "prop-types";
 import { Icon, Label, List } from "semantic-ui-react";
 import { createSelector } from "reselect";

package/src/selectors/getImplementationsExecution.js

@@ -1,11 +1,11 @@
 import _ from "lodash/fp";
 import { createSelector } from "reselect";
 
-const getStateImplementationsExecution = state =>
+const getStateImplementationsExecution = (state) =>
   state.implementationsExecution;
 
 export const getImplementationsExecution = createSelector(
   getStateImplementationsExecution,
-  stateImplementationsExecution =>
+  (stateImplementationsExecution) =>
     _.defaultTo(true)(stateImplementationsExecution)
 );

package/src/selectors/getLinkedImplementationsToRulesColumns.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import { createSelector } from "reselect";
 import { FormattedMessage } from "react-intl";
 import DateTime from "@truedat/core/components/DateTime";

package/src/selectors/getPreviousRuleImplementationQuery.js

@@ -1,3 +1,3 @@
 export const getPreviousRuleImplementationQuery = ({
-  previousRuleImplementationQuery: q = {}
+  previousRuleImplementationQuery: q = {},
 }) => q;

package/src/selectors/getRuleImplementationColumns.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import { createSelector } from "reselect";
 import { FormattedMessage } from "react-intl";
 import DateTime from "@truedat/core/components/DateTime";

package/src/selectors/getRuleImplementationForm.js

@@ -3,18 +3,18 @@ import { createSelector } from "reselect";
 
 import { getRule } from "./getRule";
 
-export const getSystemInRuleDetail = createSelector([getRule], rule =>
+export const getSystemInRuleDetail = createSelector([getRule], (rule) =>
   _.flow(
     _.propOr({}, "system_values"),
     _.propOr([], "system"),
     _.map(({ resource_id, name }) => ({
       value: resource_id,
-      text: name
+      text: name,
     }))
   )(rule)
 );
 
-export const getGroupsInRuleDetail = createSelector([getRule], rule =>
+export const getGroupsInRuleDetail = createSelector([getRule], (rule) =>
   _.flow(
     _.propOr({}, "system_values"),
     _.propOr([], "group"),
@@ -25,7 +25,7 @@ export const getGroupsInRuleDetail = createSelector([getRule], rule =>
   )(rule)
 );
 
-export const getStructuresInRuleDetail = createSelector([getRule], rule =>
+export const getStructuresInRuleDetail = createSelector([getRule], (rule) =>
   _.flow(
     _.propOr({}, "system_values"),
     _.propOr([], "table"),
@@ -36,7 +36,7 @@ export const getStructuresInRuleDetail = createSelector([getRule], rule =>
   )(rule)
 );
 
-export const getFieldsInRuleDetail = createSelector([getRule], rule =>
+export const getFieldsInRuleDetail = createSelector([getRule], (rule) =>
   _.flow(
     _.propOr({}, "system_values"),
     _.propOr([], "column"),

package/src/selectors/getRuleImplementationSelectedFilters.js

@@ -3,6 +3,6 @@ import { createSelector } from "reselect";
 
 export const getRuleImplementationSelectedFilters = createSelector(
   [_.prop("ruleImplementationActiveFilters")],
-  ruleImplementationActiveFilters =>
+  (ruleImplementationActiveFilters) =>
     _.without(["executable"])(_.keys(ruleImplementationActiveFilters))
 );

package/src/selectors/ruleColumnsSelector.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import { Label } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
 import { createSelector } from "reselect";

package/src/styles/ruleSummary.less

@@ -40,27 +40,27 @@
   }
 }
 
-.rule-summary {
-  @import "~semantic-ui-less/definitions/globals/site";
-  .over-goal-color {
-    background-color: @overGoalRuleColor;
-  }
-  .under-goal-color {
-    background-color: @underGoalRuleColor;
-  }
-  .under-minimum-color {
-    background-color: @underMinimumRuleColor;
-  }
-  .not-executed-color {
-    background-color: @notExecutedRuleColor;
-  }
-  .failed-color {
-    background-color: @failedRuleColor;
-  }
-  .empty-dataset-color {
-    background-color: @emptyDataColor;
-  }
-}
+// .rule-summary {
+//   @import "~semantic-ui-less/definitions/globals/site";
+//   .over-goal-color {
+//     background-color: @overGoalRuleColor;
+//   }
+//   .under-goal-color {
+//     background-color: @underGoalRuleColor;
+//   }
+//   .under-minimum-color {
+//     background-color: @underMinimumRuleColor;
+//   }
+//   .not-executed-color {
+//     background-color: @notExecutedRuleColor;
+//   }
+//   .failed-color {
+//     background-color: @failedRuleColor;
+//   }
+//   .empty-dataset-color {
+//     background-color: @emptyDataColor;
+//   }
+// }
 
 .pointer {
   span {

package/src/components/RuleRangeNumber.js

@@ -1,46 +0,0 @@
-import React from "react";
-import PropTypes from "prop-types";
-import { List, Icon } from "semantic-ui-react";
-import { connect } from "react-redux";
-import { FormattedMessage } from "react-intl";
-import "rc-slider/assets/index.css";
-
-export const RuleRangeNumber = ({ goal, minimum }) => (
-  <List.Item>
-    <List.Header>
-      <FormattedMessage id="quality.range" /> (
-      <FormattedMessage id="quality.range.errors_number" />)
-    </List.Header>
-    <List.Description>
-      <List>
-        <List.Item>
-          <Icon name="circle" color="yellow" />
-          <List.Content>
-            <List.Description>
-              <FormattedMessage id={`quality.threshold`} />
-              {`: ${minimum}`}
-            </List.Description>
-          </List.Content>
-        </List.Item>
-        <List.Item>
-          <Icon name="circle" color="green" />
-          <List.Content>
-            <List.Description>
-              <FormattedMessage id={`quality.goal`} />
-              {`: ${goal}`}
-            </List.Description>
-          </List.Content>
-        </List.Item>
-      </List>
-    </List.Description>
-  </List.Item>
-);
-
-RuleRangeNumber.propTypes = {
-  goal: PropTypes.number,
-  minimum: PropTypes.number,
-};
-
-const mapStateToProps = ({ rule }) => rule;
-
-export default connect(mapStateToProps)(RuleRangeNumber);

package/src/components/RuleRangePercentage.js

@@ -1,116 +0,0 @@
-import _ from "lodash/fp";
-import React from "react";
-import PropTypes from "prop-types";
-import { FormattedMessage, useIntl } from "react-intl";
-import { connect } from "react-redux";
-import { Range } from "rc-slider";
-import { List, Icon } from "semantic-ui-react";
-import "rc-slider/assets/index.css";
-
-const RED = "#d95c5c";
-const YELLOW = "#feca03";
-const GREEN = "#78be20";
-
-const TRACK_STYLE = [
-  { backgroundColor: RED },
-  { backgroundColor: YELLOW },
-  { backgroundColor: GREEN },
-];
-const HANDLE_STYLE = [
-  { borderColor: RED, backgroundColor: RED, cursor: "default" },
-  { borderColor: YELLOW, backgroundColor: YELLOW, cursor: "default" },
-  { borderColor: GREEN, backgroundColor: GREEN, cursor: "default" },
-  { borderColor: GREEN, backgroundColor: GREEN, cursor: "default" },
-];
-const DEVIATION_TRACK_STYLE = _.reverse(TRACK_STYLE);
-const DEVIATION_HANDLE_STYLE = _.reverse(HANDLE_STYLE);
-
-export const RuleRangePercentage = ({ goal, minimum, result_type }) => {
-  const { formatMessage } = useIntl();
-
-  const trackStyle =
-    result_type === "deviation" ? DEVIATION_TRACK_STYLE : TRACK_STYLE;
-
-  const handleStyle =
-    result_type === "deviation" ? DEVIATION_HANDLE_STYLE : HANDLE_STYLE;
-
-  const defaultValue =
-    result_type === "deviation"
-      ? [0, goal, minimum, 100]
-      : [0, minimum, goal, 100];
-
-  const marks = {
-    [minimum]: `${formatMessage({ id: "quality.threshold" })}`,
-    [goal]: {
-      label:
-        minimum != goal
-          ? `${formatMessage({ id: "quality.goal" })}`
-          : `${formatMessage({ id: "quality.threshold" })} - ${formatMessage({
-              id: "quality.goal",
-            })}`,
-      style: { paddingTop: Math.abs(goal - minimum) < 10 ? "15px" : "0px" },
-    },
-    0: {
-      label: "0%",
-      style: { bottom: minimum < 10 ? "22px" : "" },
-    },
-    100: {
-      label: "100%",
-      style: { bottom: goal > 90 ? "22px" : "" },
-    },
-  };
-
-  return (
-    <List.Item>
-      <List.Header>
-        <FormattedMessage id="quality.range" /> (
-        <FormattedMessage id={`quality.range.${result_type}`} />)
-      </List.Header>
-      <List.Description>
-        <Range
-          defaultValue={defaultValue}
-          disabled
-          handleStyle={handleStyle}
-          marks={marks}
-          railStyle={{ boxShadow: "0px 1px 3px lightgrey" }}
-          style={{
-            maxWidth: "600px",
-            margin: "25px",
-            backgroundColor: "white",
-          }}
-          trackStyle={trackStyle}
-        />
-        <List>
-          <List.Item>
-            <Icon name="circle" color="yellow" />
-            <List.Content>
-              <List.Description>
-                <FormattedMessage id="quality.threshold" />
-                {`: ${minimum} %`}
-              </List.Description>
-            </List.Content>
-          </List.Item>
-          <List.Item>
-            <Icon name="circle" color="green" />
-            <List.Content>
-              <List.Description>
-                <FormattedMessage id="quality.goal" />
-                {`: ${goal} %`}
-              </List.Description>
-            </List.Content>
-          </List.Item>
-        </List>
-      </List.Description>
-    </List.Item>
-  );
-};
-
-RuleRangePercentage.propTypes = {
-  goal: PropTypes.number,
-  minimum: PropTypes.number,
-  result_type: PropTypes.string,
-};
-
-const mapStateToProps = ({ rule }) => rule;
-
-export default connect(mapStateToProps)(RuleRangePercentage);

package/src/components/__tests__/RuleRangeNumber.spec.js

@@ -1,20 +0,0 @@
-import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
-import { RuleRangeNumber } from "../RuleRangeNumber";
-
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-
-describe("<RuleRangeNumber />", () => {
-  it("matches the latest snapshot", () => {
-    const props = {
-      goal: 10,
-      minimum: 1,
-      result_type: "errors_number",
-    };
-    const wrapper = shallow(<RuleRangeNumber {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-});

package/src/components/__tests__/RuleRangePercentage.spec.js

@@ -1,34 +0,0 @@
-import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
-import { RuleRangePercentage } from "../RuleRangePercentage";
-
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-
-describe("<RuleRangePercentage />", () => {
-  const props = {
-    result_type: "percentage",
-    minimum: 80,
-    goal: 90,
-  };
-
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<RuleRangePercentage {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-});
-
-describe("<RuleRangePercentage />", () => {
-  const props = {
-    result_type: "deviation",
-    minimum: 90,
-    goal: 80,
-  };
-
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<RuleRangePercentage {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
-});

package/src/components/__tests__/UploadModal.spec.js

@@ -1,158 +0,0 @@
-import React from "react";
-import { Dropdown } from "semantic-ui-react";
-import { render } from "@truedat/test/render";
-import { waitFor, fireEvent } from "@testing-library/react";
-import userEvent from "@testing-library/user-event";
-import { UploadModal } from "@truedat/core/components";
-
-describe("<ImplementationsUploadButton />", () => {
-  const trigger = <Dropdown.Item icon="upload" text="Trigger element" />;
-  const onClickExtraAction = jest.fn();
-  const onClickYesAction = jest.fn();
-
-  // See https://react-dropzone.js.org/ "Testing" section
-  const mockData = (files) => {
-    return {
-      dataTransfer: {
-        files,
-        items: files.map((file) => ({
-          kind: "file",
-          type: file.type,
-          getAsFile: () => file,
-        })),
-        types: ["Files"],
-      },
-    };
-  };
-
-  const extraAction = {
-    key: "yesWithAutoPublish",
-    primary: true,
-    content: "Extra action button",
-    onClick: onClickExtraAction,
-  };
-
-  it("shows the modal", async () => {
-    const { getByRole, getByText } = render(
-      <UploadModal
-        {...{
-          trigger,
-          extraAction,
-          header: "header",
-          content: "content",
-          param: "implementations",
-          handleSubmit: onClickYesAction,
-        }}
-      />
-    );
-
-    await waitFor(() => {
-      userEvent.click(getByRole("option", { name: "Trigger element" }));
-    });
-
-    const yesActionButton = getByRole("button", { name: "Upload and update" });
-    expect(yesActionButton).toBeDisabled();
-
-    const extraActionButton = getByRole("button", {
-      name: "Extra action button",
-    });
-    expect(extraActionButton).toBeDisabled();
-
-    expect(getByText("Trigger element")).toBeInTheDocument();
-    expect(
-      getByText("Drag an drop file or click to select file")
-    ).toBeInTheDocument();
-  });
-
-  it("clicks yes action button", async () => {
-    const { getByRole, getByText, queryByRole } = render(
-      <UploadModal
-        {...{
-          trigger,
-          header: "header",
-          content: "content",
-          param: "implementations",
-          handleSubmit: onClickYesAction,
-        }}
-      />
-    );
-
-    await waitFor(() => {
-      userEvent.click(getByRole("option", { name: "Trigger element" }));
-    });
-
-    const yesActionButton = getByRole("button", { name: "Upload and update" });
-    expect(yesActionButton).toBeDisabled();
-
-    const extraActionButton = queryByRole("button", {
-      name: "Extra action button",
-    });
-    expect(extraActionButton).not.toBeInTheDocument();
-
-    const fakeFile = new File(["implementations"], "implementations.csv", {
-      type: "text/csv",
-    });
-
-    const dropZone = getByText("Drag an drop file or click to select file");
-    const data = mockData([fakeFile]);
-
-    await waitFor(() => {
-      fireEvent.drop(dropZone, data);
-    });
-
-    expect(yesActionButton).toBeEnabled();
-
-    await waitFor(() => {
-      userEvent.click(yesActionButton);
-    });
-
-    expect(onClickYesAction).toHaveBeenCalled();
-  });
-
-  it("clicks extra action button", async () => {
-    const { getByRole, getByText } = render(
-      <UploadModal
-        {...{
-          trigger,
-          extraAction,
-          header: "header",
-          content: "content",
-          param: "implementations",
-          handleSubmit: onClickYesAction,
-        }}
-      />
-    );
-
-    await waitFor(() => {
-      userEvent.click(getByRole("option", { name: "Trigger element" }));
-    });
-
-    const yesActionButton = getByRole("button", { name: "Upload and update" });
-    expect(yesActionButton).toBeDisabled();
-
-    const extraActionButton = getByRole("button", {
-      name: "Extra action button",
-    });
-    expect(extraActionButton).toBeDisabled();
-
-    const fakeFile = new File(["implementations"], "implementations.csv", {
-      type: "text/csv",
-    });
-
-    const dropZone = getByText("Drag an drop file or click to select file");
-    const data = mockData([fakeFile]);
-
-    await waitFor(() => {
-      fireEvent.drop(dropZone, data);
-    });
-
-    expect(yesActionButton).toBeEnabled();
-    expect(extraActionButton).toBeEnabled();
-
-    await waitFor(() => {
-      userEvent.click(extraActionButton);
-    });
-
-    expect(onClickExtraAction).toHaveBeenCalled();
-  });
-});