@truedat/dq 7.5.9 → 7.5.11

package/src/components/ruleImplementationForm/__tests__/__snapshots__/ValueConditions.spec.js.snap

@@ -4,7 +4,6 @@ exports[`<ValueConditions /> matches the latest snapshot when siblings provided
 <div>
   <div
     class="row"
-    style="display: none;"
   >
     <div
       class="fourteen wide column"
@@ -18,19 +17,60 @@ exports[`<ValueConditions /> matches the latest snapshot when siblings provided
           >
             <div
               class="field"
-            />
+            >
+              <label>
+                filtersGrid.field.label
+              </label>
+              <div
+                aria-expanded="false"
+                class="ui search dropdown selection"
+                label="filtersGrid.field.label"
+                role="combobox"
+              >
+                <input
+                  aria-autocomplete="list"
+                  autocomplete="off"
+                  class="search"
+                  tabindex="0"
+                  type="text"
+                  value=""
+                />
+                <div
+                  aria-atomic="true"
+                  aria-live="polite"
+                  class="divider text"
+                  role="alert"
+                >
+                  structureFields.dropdown.placeholder
+                </div>
+                <i
+                  aria-hidden="true"
+                  class="dropdown icon"
+                />
+                <div
+                  class="menu transition"
+                  role="listbox"
+                >
+                  <div
+                    class="message"
+                  >
+                    No results found.
+                  </div>
+                </div>
+              </div>
+            </div>
           </div>
         </div>
         <div
           class="field"
         >
           <label>
-            Operator
+            filtersGrid.field.operator
           </label>
           <div
             aria-expanded="false"
             class="ui search dropdown selection"
-            label="Operator"
+            label="filtersGrid.field.operator"
             role="combobox"
           >
             <input
@@ -47,7 +87,7 @@ exports[`<ValueConditions /> matches the latest snapshot when siblings provided
               class="divider text"
               role="alert"
             >
-              Operator Dropdown
+              operator.dropdown.placeholder
             </div>
             <i
               aria-hidden="true"
@@ -67,7 +107,30 @@ exports[`<ValueConditions /> matches the latest snapshot when siblings provided
         </div>
         <div
           class="nine wide field"
-        />
+        >
+          <div
+            class="field"
+          >
+            <label>
+              ruleImplementation.props.structure
+            </label>
+            <div
+              class="required fifteen wide field"
+            >
+              <div
+                class="ui fluid icon input"
+              >
+                <input
+                  class="action-pointer"
+                  placeholder="ruleImplementation.props.structure.placeholder"
+                  required=""
+                  type="text"
+                  value=""
+                />
+              </div>
+            </div>
+          </div>
+        </div>
       </div>
     </div>
     <div

package/src/components/ruleImplementationForm/limitsValidation.js

@@ -31,11 +31,11 @@ export default function generateValidationMessages(ruleImplementation) {
           goal: ["ruleImplementation.form.validation.max_goal"],
         }
       : minimum > goal
-      ? {
-          minimum: "ruleImplementation.form.validation.minimum_greater",
-          goal: "ruleImplementation.form.validation.goal_less",
-        }
-      : {};
+        ? {
+            minimum: "ruleImplementation.form.validation.minimum_greater",
+            goal: "ruleImplementation.form.validation.goal_less",
+          }
+        : {};
 
   const errorsNumberResultValidationMessages = () =>
     minimum < goal
@@ -51,11 +51,12 @@ export default function generateValidationMessages(ruleImplementation) {
           minimum: "ruleImplementation.form.validation.max_minimum",
         }
       : minimum < goal
-      ? {
-          minimum: "ruleImplementation.form.validation.minimum.greater_eq.goal",
-          goal: "ruleImplementation.form.validation.goal.less_eq.minimum",
-        }
-      : {};
+        ? {
+            minimum:
+              "ruleImplementation.form.validation.minimum.greater_eq.goal",
+            goal: "ruleImplementation.form.validation.goal.less_eq.minimum",
+          }
+        : {};
   switch (ruleImplementation.result_type) {
     case "percentage":
       return percentageResultValidationMessages();

package/src/hooks/useConcept.js

@@ -6,7 +6,10 @@ import { apiJson } from "@truedat/core/services/api";
 const toApiPath = compile(API_BUSINESS_CONCEPT_VERSION);
 
 export const useConcept = (business_concept_id, id) => {
-  const url = toApiPath({ business_concept_id, id });
+  const url = toApiPath({
+    business_concept_id: `${business_concept_id}`,
+    id: `${id}`,
+  });
   const { data, error } = useSWR(url, apiJson);
   const concept = data?.data;
   return { concept, error, loading: !error && !data };

package/src/sagas/__tests__/createImplementationStructure.spec.js

@@ -32,8 +32,8 @@ describe("sagas: createImplementationStructureRequestSaga", () => {
 });
 
 describe("sagas: createImplementationStructureSaga", () => {
-  const implementationId = 1;
-  const dataStructureId = 2;
+  const implementationId = "1";
+  const dataStructureId = "2";
   const type = "dataset";
   const redirectUrl = "uri";
 

package/src/sagas/__tests__/createRemediation.spec.js

@@ -29,10 +29,10 @@ describe("sagas: createRemediationRequestSaga", () => {
 });
 
 describe("sagas: createRemediationSaga", () => {
-  const implementationId = 1;
-  const ruleResultId = 1;
+  const implementationId = "1";
+  const ruleResultId = "1";
   const remediation = {
-    id: 1,
+    id: "1",
     df_name: "remediation_template",
     df_content: { text: { value: "some_text", origin: "user" } },
   };

package/src/sagas/__tests__/deleteImplementation.spec.js

@@ -29,7 +29,7 @@ describe("sagas: deleteImplementationRequestSaga", () => {
 });
 
 describe("sagas: deleteImplementationSaga", () => {
-  const id = 1;
+  const id = "1";
   const redirectUrl = "foo";
   const url = compile(API_RULE_IMPLEMENTATION)({ id });
   const payload = { id, redirectUrl };

package/src/sagas/__tests__/deleteImplementationStructure.spec.js

@@ -35,8 +35,8 @@ describe("sagas: deleteImplementationStructureRequestSaga", () => {
 });
 
 describe("sagas: deleteImplementationStructureSaga", () => {
-  const implementationId = 1;
-  const id = 2;
+  const implementationId = "1";
+  const id = "2";
 
   const url = compile(API_IMPLEMENTATIONS_STRUCTURE)({
     implementationId,

package/src/sagas/__tests__/deleteRemediation.spec.js

@@ -29,10 +29,10 @@ describe("sagas: deleteRemediationRequestSaga", () => {
 });
 
 describe("sagas: deleteRemediationSaga", () => {
-  const ruleResultId = 1;
-  const implementationId = 1;
+  const ruleResultId = "1";
+  const implementationId = "1";
   const remediation = {
-    id: 1,
+    id: "1",
     df_name: "remediation_template",
     df_content: { text: { value: "some_text", origin: "user" } },
   };

package/src/sagas/__tests__/deleteRule.spec.js

@@ -26,7 +26,7 @@ describe("sagas: deleteRuleRequestSaga", () => {
 });
 
 describe("sagas: deleteRuleSaga", () => {
-  const id = 1;
+  const id = "1";
   const url = compile(API_RULE)({ id });
   const payload = { id };
   const data = {};

package/src/sagas/__tests__/deleteRuleResult.spec.js

@@ -29,7 +29,7 @@ describe("sagas: deleteRuleResultRequestSaga", () => {
 });
 
 describe("sagas: deleteRuleResultSaga", () => {
-  const payload = { id: 1, rule_implementation_id: 3 };
+  const payload = { id: "1", rule_implementation_id: "3" };
   const { id } = payload;
   const url = compile(API_RULE_RESULT)({ id });
 
@@ -41,7 +41,7 @@ describe("sagas: deleteRuleResultSaga", () => {
         .next()
         .call(apiJsonDelete, url, JSON_OPTS)
         .next({ data: payload })
-        .put(deleteRuleResult.success({ rule_implementation_id: 3 }))
+        .put(deleteRuleResult.success({ rule_implementation_id: "3" }))
         .next()
         .put(deleteRuleResult.fulfill())
         .next()

package/src/sagas/__tests__/fetchRemediation.spec.js

@@ -30,7 +30,7 @@ describe("sagas: fetchRemediationRequestSaga", () => {
 
 describe("sagas: fetchRemediaitonSaga", () => {
   it("should put a success action when a response is returned", () => {
-    const ruleResultId = 1;
+    const ruleResultId = "1";
     const url = compile(API_REMEDIATION_PLAN)({ rule_result_id: ruleResultId });
     const payload = { rule_result_id: ruleResultId };
     const data = {
@@ -57,7 +57,7 @@ describe("sagas: fetchRemediaitonSaga", () => {
   it("should put a failure action when the call returns an error", () => {
     const message = "Request failed";
     const error = { message };
-    const ruleResultId = 1;
+    const ruleResultId = "1";
     const url = compile(API_REMEDIATION_PLAN)({ rule_result_id: ruleResultId });
     const payload = { rule_result_id: ruleResultId };
 

package/src/sagas/__tests__/fetchRule.spec.js

@@ -27,7 +27,7 @@ describe("sagas: fetchRuleRequestSaga", () => {
 
 describe("sagas: fetchRuleSaga", () => {
   it("should put a success action when a response is returned", () => {
-    const id = 1;
+    const id = "1";
     const url = compile(API_RULE)({ id });
     const payload = { id };
     const data = { id: 1, name: "Rule 1", description: "desc1" };
@@ -50,7 +50,7 @@ describe("sagas: fetchRuleSaga", () => {
   it("should put a failure action when the call returns an error", () => {
     const message = "Request failed";
     const error = { message };
-    const id = 1;
+    const id = "1";
     const url = compile(API_RULE)({ id });
     const payload = { id };
 

package/src/sagas/__tests__/fetchRuleImplementation.spec.js

@@ -32,10 +32,10 @@ describe("sagas: fetchRuleImplementationRequestSaga", () => {
 });
 
 describe("sagas: fetchRuleImplementationSaga", () => {
-  const id = 1;
+  const id = "1";
   const url = compile(API_RULE_IMPLEMENTATION)({ id });
   const payload = { id };
-  const data = { id: 1, implementation_key: "Structure 1" };
+  const data = { id: "1", implementation_key: "Structure 1" };
 
   it("should put a success action when a response is returned", () => {
     expect(() => {
@@ -56,7 +56,7 @@ describe("sagas: fetchRuleImplementationSaga", () => {
   it("should put a failure action when the call returns an error", () => {
     const message = "Request failed";
     const error = { message };
-    const id = 1;
+    const id = "1";
     const url = compile(API_RULE_IMPLEMENTATION)({ id });
     const payload = { id };
 

package/src/sagas/__tests__/fetchRuleImplementations.spec.js

@@ -32,13 +32,13 @@ describe("sagas: fetchRuleImplementationsRequestSaga", () => {
 });
 
 describe("sagas: fetchRuleImplementationsSaga", () => {
-  const id = 1;
+  const id = "1";
   const url = compile(API_RULE_IMPLEMENTATIONS_FROM_RULE)({ id });
   const payload = { id };
   const data = {
     collection: [
-      { id: 1, name: "Structure 1" },
-      { id: 2, name: "Structure 2" },
+      { id: "1", name: "Structure 1" },
+      { id: "2", name: "Structure 2" },
     ],
   };
 

package/src/sagas/__tests__/fetchSegmentResults.spec.js

@@ -30,11 +30,11 @@ describe("sagas: fetchSegmentResultsRequestSaga", () => {
 
 describe("sagas: fetchRemediaitonSaga", () => {
   it("should put a success action when a response is returned", () => {
-    const ruleResultId = 1;
+    const ruleResultId = "1";
     const url = compile(API_SEGMENT_RESULTS)({ rule_result_id: ruleResultId });
     const payload = { rule_result_id: ruleResultId };
     const data = {
-      id: 1,
+      id: "1",
       df_name: "remediation_template",
       df_content: { text: { value: "some_text", origin: "user" } },
     };
@@ -57,7 +57,7 @@ describe("sagas: fetchRemediaitonSaga", () => {
   it("should put a failure action when the call returns an error", () => {
     const message = "Request failed";
     const error = { message };
-    const ruleResultId = 1;
+    const ruleResultId = "1";
     const url = compile(API_SEGMENT_RESULTS)({ rule_result_id: ruleResultId });
     const payload = { rule_result_id: ruleResultId };
 

package/src/sagas/__tests__/updateRemediation.spec.js

@@ -29,10 +29,10 @@ describe("sagas: updateRemediationRequestSaga", () => {
 });
 
 describe("sagas: updateRemediationSaga", () => {
-  const implementationId = 1;
-  const ruleResultId = 1;
+  const implementationId = "1";
+  const ruleResultId = "1";
   const remediation = {
-    id: 1,
+    id: "1",
     df_name: "remediation_template",
     df_content: { text: { value: "some_text", origin: "user" } },
   };

package/src/sagas/__tests__/updateRule.spec.js

@@ -26,7 +26,7 @@ describe("sagas: updateRuleRequestSaga", () => {
 });
 
 describe("sagas: updateRuleSaga", () => {
-  const id = 124;
+  const id = "124";
   const description = "A new description";
   const url = compile(API_RULE)({ id });
   const rule = { id, description };

package/src/sagas/__tests__/updateRuleImplementation.spec.js

@@ -36,9 +36,9 @@ describe("sagas: updateRuleImplementationRequestSaga", () => {
 
 describe("sagas: updateRuleImplementationSaga", () => {
   const rule_implementation = {
-    id: 1,
+    id: "1",
     implementation_key: "impl_key",
-    dataset: [{ structure: { id: 1 } }],
+    dataset: [{ structure: { id: "1" } }],
     populations: [
       [
         {
@@ -51,11 +51,11 @@ describe("sagas: updateRuleImplementationSaga", () => {
     validations: [
       {
         operator: { name: "between", value_type: "field" },
-        structure: { id: 3 },
-        value: [{ id: 4 }, { id: 5 }],
+        structure: { id: "3" },
+        value: [{ id: "4" }, { id: "5" }],
       },
     ],
-    rule_id: 1,
+    rule_id: "1",
   };
   const data = { rule_implementation };
   const url = toApiPath(rule_implementation);

package/src/sagas/createImplementationStructure.js

@@ -7,7 +7,9 @@ import { API_IMPLEMENTATIONS_STRUCTURES } from "../api";
 export function* createImplementationStructureSaga({ payload }) {
   try {
     const { implementationId, dataStructureId, type, redirectUrl } = payload;
-    const url = compile(API_IMPLEMENTATIONS_STRUCTURES)({ implementationId });
+    const url = compile(API_IMPLEMENTATIONS_STRUCTURES)({
+      implementationId: `${implementationId}`,
+    });
     const requestData = { data_structure_id: dataStructureId, type };
     yield put(createImplementationStructure.request(payload));
     const { data } = yield call(apiJsonPost, url, requestData, JSON_OPTS);

package/src/sagas/createRemediation.js

@@ -8,7 +8,9 @@ export function* createRemediationSaga({ payload }) {
   const { remediation, implementation_id, rule_result_id } = payload;
   try {
     const requestData = { remediation };
-    const url = compile(API_REMEDIATION_PLAN)({ rule_result_id });
+    const url = compile(API_REMEDIATION_PLAN)({
+      rule_result_id: `${rule_result_id}`,
+    });
     yield put(createRemediation.request(remediation));
     const { data } = yield call(apiJsonPost, url, requestData, JSON_OPTS);
     yield put(createRemediation.success({ ...payload, ...data }));

package/src/sagas/deleteImplementation.js

@@ -7,7 +7,7 @@ import { API_RULE_IMPLEMENTATION } from "../api";
 export function* deleteImplementationSaga({ payload }) {
   try {
     const { id, redirectUrl } = payload;
-    const url = compile(API_RULE_IMPLEMENTATION)({ id });
+    const url = compile(API_RULE_IMPLEMENTATION)({ id: `${id}` });
     yield put(deleteImplementation.request());
     yield call(apiJsonDelete, url, JSON_OPTS);
     yield put(deleteImplementation.success({ redirectUrl }));

package/src/sagas/deleteImplementationStructure.js

@@ -11,7 +11,7 @@ export function* deleteImplementationStructureSaga({ payload }) {
   try {
     const { implementationId, id } = payload;
 
-    const url = compile(API_IMPLEMENTATIONS_STRUCTURE)({ id });
+    const url = compile(API_IMPLEMENTATIONS_STRUCTURE)({ id: `${id}` });
     yield put(deleteImplementationStructure.request());
     const { data } = yield call(apiJsonDelete, url, JSON_OPTS);
     yield put(deleteImplementationStructure.success(data));

package/src/sagas/deleteRemediation.js

@@ -7,7 +7,9 @@ import { API_REMEDIATION_PLAN } from "../api";
 export function* deleteRemediationSaga({ payload }) {
   try {
     const { remediation, implementation_id, rule_result_id } = payload;
-    const url = compile(API_REMEDIATION_PLAN)({ rule_result_id });
+    const url = compile(API_REMEDIATION_PLAN)({
+      rule_result_id: `${rule_result_id}`,
+    });
     yield put(deleteRemediation.request(remediation));
     const { data } = yield call(apiJsonDelete, url, JSON_OPTS);
     yield put(deleteRemediation.success({ ...payload, ...data }));

package/src/sagas/deleteRule.js

@@ -8,8 +8,8 @@ const toApiPath = compile(API_RULE);
 
 export function* deleteRuleSaga({ payload }) {
   try {
-    const id = payload;
-    const url = toApiPath(id);
+    const { id } = payload;
+    const url = toApiPath({ id: `${id}` });
     yield put(deleteRule.request());
     const { data } = yield call(apiJsonDelete, url, JSON_OPTS);
     yield put(deleteRule.success(data));

package/src/sagas/deleteRuleResult.js

@@ -9,7 +9,7 @@ const toApiPath = compile(API_RULE_RESULT);
 export function* deleteRuleResultSaga({ payload }) {
   try {
     const { id, rule_implementation_id } = payload;
-    const url = toApiPath({ id });
+    const url = toApiPath({ id: `${id}` });
     yield put(deleteRuleResult.request());
     yield call(apiJsonDelete, url, JSON_OPTS);
     yield put(deleteRuleResult.success({ rule_implementation_id }));

package/src/sagas/fetchConceptRules.js

@@ -8,7 +8,7 @@ export function* fetchConceptRulesSaga({ payload }) {
   try {
     const { business_concept_id } = payload;
     const url = compile(API_CONCEPT_RULES)({
-      id: business_concept_id
+      id: `${business_concept_id}`,
     });
     yield put(fetchConceptRules.request());
     const { data } = yield call(apiJson, url, JSON_OPTS);

package/src/sagas/fetchExecutionGroup.js

@@ -9,7 +9,7 @@ const toApiPath = compile(API_EXECUTION_GROUP);
 export function* fetchExecutionGroupSaga({ payload }) {
   try {
     const { id } = payload;
-    const url = toApiPath({ id });
+    const url = toApiPath({ id: `${id}` });
     yield put(fetchExecutionGroup.request());
     const { data } = yield call(apiJson, url, JSON_OPTS);
     yield put(fetchExecutionGroup.success(data));

package/src/sagas/fetchRemediation.js

@@ -8,7 +8,7 @@ export function* fetchRemediationSaga({ payload }) {
   try {
     const { rule_result_id } = payload;
     const url = compile(API_REMEDIATION_PLAN)({
-      rule_result_id,
+      rule_result_id: `${rule_result_id}`,
     });
     yield put(fetchRemediation.request());
     const { data } = yield call(apiJson, url, JSON_OPTS);

package/src/sagas/fetchRuleImplementations.js

@@ -17,7 +17,7 @@ const fetchPayload = (deleted, filters) => {
 export function* fetchRuleImplementationsSaga({ payload }) {
   try {
     const { id, deleted, filters } = payload;
-    const url = compile(API_RULE_IMPLEMENTATIONS_FROM_RULE)({ id });
+    const url = compile(API_RULE_IMPLEMENTATIONS_FROM_RULE)({ id: `${id}` });
 
     yield put(fetchRuleImplementations.request());
     yield delay(600);

package/src/sagas/fetchSegmentResults.js

@@ -8,7 +8,7 @@ export function* fetchSegmentResultsSaga({ payload }) {
   try {
     const { rule_result_id } = payload;
     const url = compile(API_SEGMENT_RESULTS)({
-      rule_result_id,
+      rule_result_id: `${rule_result_id}`,
     });
     yield put(fetchSegmentResults.request());
     const { data } = yield call(apiJson, url, JSON_OPTS);

package/src/sagas/updateRemediation.js

@@ -8,7 +8,9 @@ export function* updateRemediationSaga({ payload }) {
   try {
     const { remediation, rule_result_id } = payload;
     const requestData = { remediation };
-    const url = compile(API_REMEDIATION_PLAN)({ rule_result_id });
+    const url = compile(API_REMEDIATION_PLAN)({
+      rule_result_id: `${rule_result_id}`,
+    });
     yield put(updateRemediation.request(remediation));
     const { data } = yield call(apiJsonPut, url, requestData, JSON_OPTS);
     yield put(updateRemediation.success({ ...payload, ...data }));

package/src/sagas/updateRule.js

@@ -11,7 +11,7 @@ export function* updateRuleSaga({ payload }) {
   const { rule, ids } = payload;
   const redirectUrl = linkTo.RULE({ id: ids.id });
   const meta = { redirectUrl };
-  const url = toApiPath(rule);
+  const url = toApiPath({ id: `${rule.id}` });
   const requestData = { rule };
   try {
     yield put({ meta, ...updateRule.request() });

package/src/sagas/updateRuleImplementation.js

@@ -10,7 +10,7 @@ const toApiPath = compile(API_RULE_IMPLEMENTATION);
 export function* updateRuleImplementationSaga({ payload }) {
   try {
     const { rule_implementation } = payload;
-    const url = toApiPath(rule_implementation);
+    const url = toApiPath({ id: `${rule_implementation.id}` });
     yield put(updateRuleImplementation.request());
     const encoded = yield call(encodeRawContent, rule_implementation);
     const requestData = { rule_implementation: encoded };

package/src/selectors/__tests__/getPreviousRuleImplementationQuery.spec.js

@@ -4,10 +4,10 @@ describe("selectors: getPreviousRuleImplementationQuery", () => {
   it("returns previousRuleImplementationQuery", () => {
     const previousRuleImplementationQuery = {
       query: "A",
-      filters: { foo: "bar" }
+      filters: { foo: "bar" },
     };
     const res = getPreviousRuleImplementationQuery({
-      previousRuleImplementationQuery
+      previousRuleImplementationQuery,
     });
     expect(res).toEqual(previousRuleImplementationQuery);
   });

package/src/selectors/__tests__/getRuleImplementationColumns.spec.js

@@ -4,7 +4,7 @@ describe("selectors: getRuleImplementationColumns", () => {
   it("should return custom ruleColumns when present", () => {
     const ruleImplementationColumns = [{ name: "test" }];
     const res = getRuleImplementationColumns({
-      ruleImplementationColumns
+      ruleImplementationColumns,
     });
     expect(res).toHaveLength(1);
     expect(res).toEqual(ruleImplementationColumns);