@truedat/dq 4.43.0 → 4.43.3

package/src/components/ruleImplementationForm/__tests__/__snapshots__/RuleImplementationForm.spec.js.snap

@@ -1,100 +1,324 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`<RuleImplementationForm /> matches the latest snapshot 1`] = `
-<GridColumn>
-  <GridRow
-    stretched={true}
-    textAlign="center"
+<div>
+  <div
+    class="column"
   >
-    <StepGroup
-      size="small"
+    <div
+      class="stretched center aligned row"
     >
-      <RuleImplementationStep
-        activeStep="information"
-        icon={
-          Object {
-            "name": "info",
-          }
-        }
-        key="0"
-        name="information"
+      <div
+        class="ui small steps"
+      >
+        <div
+          class="active step"
+        >
+          <i
+            aria-hidden="true"
+            class="info icon"
+          />
+          <div
+            class="content"
+          >
+            <div
+              class="title"
+            >
+              ruleImplementationForm.step.information
+            </div>
+          </div>
+        </div>
+        <div
+          class="step"
+        >
+          <i
+            aria-hidden="true"
+            class="database icon"
+          />
+          <div
+            class="content"
+          >
+            <div
+              class="title"
+            >
+              ruleImplementationForm.step.dataset
+            </div>
+          </div>
+        </div>
+        <div
+          class="step"
+        >
+          <i
+            aria-hidden="true"
+            class="user icon"
+          />
+          <div
+            class="content"
+          >
+            <div
+              class="title"
+            >
+              ruleImplementationForm.step.populations
+            </div>
+          </div>
+        </div>
+        <div
+          class="step"
+        >
+          <i
+            aria-hidden="true"
+            class="setting icon"
+          />
+          <div
+            class="content"
+          >
+            <div
+              class="title"
+            >
+              ruleImplementationForm.step.validations
+            </div>
+          </div>
+        </div>
+        <div
+          class="step"
+        >
+          <i
+            aria-hidden="true"
+            class="grid layout icon"
+          />
+          <div
+            class="content"
+          >
+            <div
+              class="title"
+            >
+              ruleImplementationForm.step.segments
+            </div>
+          </div>
+        </div>
+      </div>
+      <div
+        class="ui fitted hidden divider"
       />
-      <RuleImplementationStep
-        activeStep="information"
-        icon={
-          Object {
-            "name": "database",
-          }
-        }
-        key="1"
-        name="dataset"
-      />
-      <RuleImplementationStep
-        activeStep="information"
-        icon={
-          Object {
-            "name": "user",
-          }
-        }
-        key="2"
-        name="populations"
-      />
-      <RuleImplementationStep
-        activeStep="information"
-        icon={
-          Object {
-            "name": "setting",
-          }
-        }
-        key="3"
-        name="validations"
-      />
-    </StepGroup>
-    <Divider
-      fitted={true}
-      hidden={true}
-    />
-  </GridRow>
-  <GridRow
-    className="rule-impl-form-row"
-    stretched={true}
-  >
-    <Form
-      as="form"
+    </div>
+    <div
+      class="stretched row rule-impl-form-row"
     >
-      <Connect(InformationForm)
-        ruleImplementation={
-          Object {
-            "executable": true,
-            "implementationKey": "foo",
-          }
-        }
-      />
-    </Form>
-  </GridRow>
-  <Divider
-    hidden={true}
-  />
-  <GridRow
-    stretched={true}
-  >
-    <Button
-      as="button"
-      content="actions.next"
-      disabled={true}
-      floated="right"
-      loading={false}
-      onClick={[Function]}
-      primary={true}
-      type="submit"
+      <form
+        class="ui form"
+      >
+        <div
+          class="field"
+        >
+          <div
+            class="ui checked toggle checkbox"
+          >
+            <input
+              checked=""
+              class="hidden"
+              name="executable"
+              readonly=""
+              tabindex="0"
+              type="radio"
+              value=""
+            />
+            <label>
+              ruleImplementation.props.executable
+            </label>
+          </div>
+        </div>
+        <div
+          class="field"
+        >
+          <label>
+            ruleImplementation.props.name
+            <i
+              aria-hidden="true"
+              class="question circle outline icon rule-form-popup"
+            />
+          </label>
+          <div
+            class="field"
+          >
+            <div
+              class="ui input"
+            >
+              <input
+                autocomplete="off"
+                name="implementation_key"
+                placeholder="ruleImplementation.props.name.placeholder"
+                type="text"
+                value="foo"
+              />
+            </div>
+          </div>
+        </div>
+        <div
+          class="ui segment"
+        >
+          <div
+            class="field"
+          >
+            <label
+              class="rule-form-label"
+            >
+              ruleImplementations.props.result_type
+              <span>
+                *
+              </span>
+              <i
+                aria-hidden="true"
+                class="question circle outline icon rule-form-popup"
+              />
+            </label>
+            <div
+              class="inline fields"
+            >
+              <div
+                class="field"
+              >
+                <div
+                  class="ui checked radio checkbox"
+                >
+                  <input
+                    checked=""
+                    class="hidden"
+                    name="result_type"
+                    readonly=""
+                    tabindex="0"
+                    type="radio"
+                    value="percentage"
+                  />
+                  <label>
+                    ruleImplementations.props.result_type.percentage
+                  </label>
+                </div>
+              </div>
+              <div
+                class="field"
+              >
+                <div
+                  class="ui radio checkbox"
+                >
+                  <input
+                    class="hidden"
+                    name="result_type"
+                    readonly=""
+                    tabindex="0"
+                    type="radio"
+                    value="deviation"
+                  />
+                  <label>
+                    ruleImplementations.props.result_type.deviation
+                  </label>
+                </div>
+              </div>
+              <div
+                class="field"
+              >
+                <div
+                  class="ui radio checkbox"
+                >
+                  <input
+                    class="hidden"
+                    name="result_type"
+                    readonly=""
+                    tabindex="0"
+                    type="radio"
+                    value="errors_number"
+                  />
+                  <label>
+                    ruleImplementations.props.result_type.errors_number
+                  </label>
+                </div>
+              </div>
+            </div>
+          </div>
+          <div
+            class="field"
+          >
+            <label
+              class="rule-form-label"
+            >
+              ruleImplementations.props.minimum
+              <span>
+                *
+              </span>
+              <i
+                aria-hidden="true"
+                class="question circle outline icon rule-form-popup"
+              />
+            </label>
+            <div
+              class="field"
+            >
+              <div
+                class="ui input"
+              >
+                <input
+                  autocomplete="off"
+                  name="minimum"
+                  placeholder="ruleImplementations.props.minimum.placeholder"
+                  type="text"
+                  value="10"
+                />
+              </div>
+            </div>
+          </div>
+          <div
+            class="field"
+          >
+            <label
+              class="rule-form-label"
+            >
+              ruleImplementations.props.goal
+              <span>
+                *
+              </span>
+              <i
+                aria-hidden="true"
+                class="question circle outline icon rule-form-popup"
+              />
+            </label>
+            <div
+              class="field"
+            >
+              <div
+                class="ui input"
+              >
+                <input
+                  autocomplete="off"
+                  name="goal"
+                  placeholder="ruleImplementations.props.goal.placeholder"
+                  type="text"
+                  value="20"
+                />
+              </div>
+            </div>
+          </div>
+        </div>
+      </form>
+    </div>
+    <div
+      class="ui hidden divider"
     />
-    <Button
-      as="button"
-      content="actions.cancel"
-      floated="right"
-      onClick={[Function]}
-      secondary={true}
-    />
-  </GridRow>
-</GridColumn>
+    <div
+      class="stretched row"
+    >
+      <button
+        class="ui loading primary disabled right floated button"
+        disabled=""
+        tabindex="-1"
+        type="submit"
+      >
+        actions.next
+      </button>
+      <button
+        class="ui secondary right floated button"
+      >
+        actions.cancel
+      </button>
+    </div>
+  </div>
+</div>
 `;

package/src/messages/en.js

@@ -456,6 +456,7 @@ export default {
   "ruleImplementationForm.step.information": "Information",
   "ruleImplementationForm.step.dataset": "Data Set",
   "ruleImplementationForm.step.populations": "Populations",
+  "ruleImplementationForm.step.segments": "Segments",
   "ruleImplementationForm.step.validations": "Validations",
   "ruleImplementationRawForm.props.database": "Database",
   "ruleImplementationRawForm.props.database.placeholder": "Select database",
@@ -528,6 +529,7 @@ export default {
   "ruleImplementations.summary.headers.implementation": "Rule Implementation",
   "ruleImplementations.summary.headers.population": "Population",
   "ruleImplementations.summary.headers.populations": "Populations",
+  "ruleImplementations.summary.headers.segments": "Segments",
   "ruleImplementations.summary.headers.validations": "Validation",
   "ruleImplementations.upload.success.errors":
     "Error in {implementation_key} attribute: {key} message: {message} ",
@@ -551,6 +553,7 @@ export default {
   "ruleResult.props.errors": "Errors",
   "ruleResult.props.quality": "Quality",
   "ruleResult.props.records": "Records",
+  "ruleResultSegment.props.name": "Name",
   "ruleSubscription.actions.remove": "Eliminar",
   "rule_result.actions.delete.confirmation.content":
     "This rule result will be deleted. Are you sure?",
@@ -578,6 +581,7 @@ export default {
     "Error uploading file. No rules have been created.",
   "rules.upload.failed.misssing_required_columns":
     "Missing required columns. Expected [{expected}]. Found [{found}].",
+  "segmentsForm.add.text": "Add Segment",
   "structureSelector.union.criteria": "Union criteria",
   "structureFields.dropdown.label": "Select Field",
   "structureFields.dropdown.placeholder": "Fields",
@@ -591,6 +595,9 @@ export default {
   "tabs.dq.ruleImplementation.details": "Details",
   "tabs.dq.ruleImplementation.results": "Results",
   "tabs.dq.ruleImplementations": "Implementations",
+  "tabs.dq.ruleImplementationResult.info": "Information",
+  "tabs.dq.ruleImplementationResult.segmentResult": "Segments Results",
+  "tabs.dq.ruleImplementationResult.remediationPlan": "Remedy Plan",
   "tabs.qualityRules": "Quality Rules",
   "updateRuleImplementation.error.implementation_key.duplicated":
     "Duplicated implementation key",

package/src/messages/es.js

@@ -471,6 +471,7 @@ export default {
   "ruleImplementationForm.step.dataset": "Datos",
   "ruleImplementationForm.step.information": "Información",
   "ruleImplementationForm.step.populations": "Poblaciones",
+  "ruleImplementationForm.step.segments": "Segmentos",
   "ruleImplementationForm.step.validations": "Validaciones",
   "ruleImplementationRawForm.props.database.placeholder":
     "Seleccionar base de datos",
@@ -551,6 +552,7 @@ export default {
     "Implementación de una Regla",
   "ruleImplementations.summary.headers.population": "Población",
   "ruleImplementations.summary.headers.populations": "Poblaciones",
+  "ruleImplementations.summary.headers.segments": "Segmentos",
   "ruleImplementations.summary.headers.validations": "Validaciones",
   "ruleImplementations.upload.success.errors":
     "Error en {name} atributo: {key} mensaje: {message} ",
@@ -575,6 +577,7 @@ export default {
   "ruleResult.props.header.information": "Información",
   "ruleResult.props.quality": "Calidad",
   "ruleResult.props.records": "Registros",
+  "ruleResultSegment.props.name": "Nombre",
   "rules.actions.activate_execution": "Activar ejecución",
   "rules.actions.create": "Nueva regla de calidad",
   "rules.actions.delete.confirmation.content":
@@ -605,6 +608,7 @@ export default {
   "rules.upload.failed.misssing_required_columns":
     "Faltan columnas obligatorias en el fichero. Esperado [{expected}]. Recibido [{found}].",
   "ruleSubscription.actions.remove": "Eliminar",
+  "segmentsForm.add.text": "Añadir segmentación",
   "structureSelector.union.criteria": "Criterio de unión",
   "structureFields.dropdown.label": "Seleccionar Campo",
   "structureFields.dropdown.placeholder": "Campos",
@@ -618,6 +622,9 @@ export default {
   "tabs.dq.ruleImplementation.results": "Resultados",
   "tabs.dq.ruleImplementation": "Implementación",
   "tabs.dq.ruleImplementations": "Implementaciones",
+  "tabs.dq.ruleImplementationResult.info": "Información",
+  "tabs.dq.ruleImplementationResult.segmentResult": "Resultados de Segmentación",
+  "tabs.dq.ruleImplementationResult.remediationPlan": "Plan de remediación",
   "tabs.qualityRules": "Reglas de Calidad",
   "updateRule.error.domain_id.required": "El dominio es requerido",
   "updateRuleImplementation.error.implementation_key.duplicated":

package/src/reducers/__tests__/segmentResult.spec.js

@@ -0,0 +1,46 @@
+import { fetchSegmentResults, clearSegmentResults } from "../../routines";
+import { segmentResults } from "../segmentResults";
+
+const fooState = { foo: "bar" };
+
+describe("reducers: segmentResults", () => {
+  const initialState = {};
+
+  it("should provide the initial state", () => {
+    expect(segmentResults(undefined, {})).toEqual(initialState);
+  });
+
+  it("should handle the fetchSegmentResults.TRIGGER action", () => {
+    expect(
+      segmentResults(fooState, { type: fetchSegmentResults.TRIGGER })
+    ).toEqual(initialState);
+  });
+
+  it("should handle the fetchSegmentResults.SUCCESS action", () => {
+    const segmentResult = {
+      id: 2,
+      errors: 2,
+      records: 10,
+      result: "80.0",
+      params: "foo=bar",
+    };
+    const payload = { data: segmentResult };
+
+    expect(
+      segmentResults(fooState, {
+        type: fetchSegmentResults.SUCCESS,
+        payload,
+      })
+    ).toMatchObject(segmentResult);
+  });
+
+  it("should handle the clearSegmentResults.TRIGGER action", () => {
+    expect(
+      segmentResults(fooState, { type: clearSegmentResults.TRIGGER })
+    ).toEqual(initialState);
+  });
+
+  it("should ignore unknown actions", () => {
+    expect(segmentResults(fooState, { type: "FOO" })).toBe(fooState);
+  });
+});

package/src/reducers/index.js

@@ -44,6 +44,7 @@ import { ruleUpdating } from "./ruleUpdating";
 import { rules } from "./rules";
 import { rulesLoading } from "./rulesLoading";
 import { rulesPageSize } from "./rulesPageSize";
+import { segmentResults } from "./segmentResults";
 import { uploadingImplementationsFile } from "./uploadingImplementationsFile";
 import { uploadingRulesFile } from "./uploadingRulesFile";
 import { userImplementationsPermissions } from "./userImplementationsPermissions";
@@ -97,6 +98,7 @@ export {
   rules,
   rulesLoading,
   rulesPageSize,
+  segmentResults,
   uploadingImplementationsFile,
   uploadingRulesFile,
   userImplementationsPermissions,

package/src/reducers/ruleImplementation.js

@@ -17,6 +17,7 @@ const pickFields = _.pick([
   "implementation_key",
   "implementation_type",
   "populations",
+  "segments",
   "raw_content",
   "results",
   "rule_id",

package/src/reducers/segmentResults.js

@@ -0,0 +1,19 @@
+import _ from "lodash/fp";
+import { fetchSegmentResults, clearSegmentResults } from "../routines";
+
+const initialState = {};
+
+const segmentResults = (state = initialState, { type, payload }) => {
+  switch (type) {
+    case fetchSegmentResults.TRIGGER:
+      return initialState;
+    case fetchSegmentResults.SUCCESS:
+      return _.prop("data")(payload);
+    case clearSegmentResults.TRIGGER:
+      return initialState;
+    default:
+      return state;
+  }
+};
+
+export { segmentResults };

package/src/routines.js

@@ -59,6 +59,9 @@ export const searchRuleImplementations = createRoutine(
 
 export const deleteRuleResult = createRoutine("DELETE_RULE_RESULT");
 
+export const fetchSegmentResults = createRoutine("FETCH_SEGMENT_RESULTS");
+export const clearSegmentResults = createRoutine("CLEAR_SEGMENT_RESULTS");
+
 export const clearImplementationFilters = createRoutine(
   "CLEAR_IMPLEMENTATION_FILTERS"
 );

package/src/sagas/__tests__/fetchSegmentResults.spec.js

@@ -0,0 +1,78 @@
+import { compile } from "path-to-regexp";
+import { testSaga } from "redux-saga-test-plan";
+import { apiJson, JSON_OPTS } from "@truedat/core/services/api";
+import {
+  fetchSegmentResultsRequestSaga,
+  fetchSegmentResultsSaga,
+} from "../fetchSegmentResults";
+import { fetchSegmentResults } from "../../routines";
+import { API_SEGMENT_RESULTS } from "../../api";
+
+describe("sagas: fetchSegmentResultsRequestSaga", () => {
+  it("should invoke fetchSegmentResultsSaga on trigger", () => {
+    expect(() => {
+      testSaga(fetchSegmentResultsRequestSaga)
+        .next()
+        .takeLatest(fetchSegmentResults.TRIGGER, fetchSegmentResultsSaga)
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(fetchSegmentResultsRequestSaga)
+        .next()
+        .takeLatest("FOO", fetchSegmentResultsSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: fetchRemediaitonSaga", () => {
+  it("should put a success action when a response is returned", () => {
+    const ruleResultId = 1;
+    const url = compile(API_SEGMENT_RESULTS)({ rule_result_id: ruleResultId });
+    const payload = { rule_result_id: ruleResultId };
+    const data = {
+      id: 1,
+      df_name: "remediation_template",
+      df_content: { text: "some_text" },
+    };
+
+    expect(() => {
+      testSaga(fetchSegmentResultsSaga, { payload })
+        .next()
+        .put(fetchSegmentResults.request())
+        .next()
+        .call(apiJson, url, JSON_OPTS)
+        .next({ data })
+        .put(fetchSegmentResults.success(data))
+        .next()
+        .put(fetchSegmentResults.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+    const ruleResultId = 1;
+    const url = compile(API_SEGMENT_RESULTS)({ rule_result_id: ruleResultId });
+    const payload = { rule_result_id: ruleResultId };
+
+    expect(() => {
+      testSaga(fetchSegmentResultsSaga, { payload })
+        .next()
+        .put(fetchSegmentResults.request())
+        .next()
+        .call(apiJson, url, JSON_OPTS)
+        .throw(error)
+        .put(fetchSegmentResults.failure(message))
+        .next()
+        .put(fetchSegmentResults.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});