@truedat/dq 4.43.0 → 4.43.3

package/src/components/RuleRoutes.js

@@ -31,7 +31,8 @@ import {
   getImplementationStructuresLoaded,
 } from "../selectors";
 import EditRule from "./EditRule";
-import ExecutionDetails from "./ExecutionDetails";
+import RuleResultDetails from "./RuleResultDetails";
+import RuleResultsRoutes from "./RuleResultsRoutes";
 import ImplementationStructures from "./ImplementationStructures";
 import ImplementationStructuresNew from "./ImplementationStructuresNew";
 import MoveImplementation from "./MoveImplementation";
@@ -415,27 +416,16 @@ const ImplementationRoutes = ({
                   <Segment>
                     {ruleLoaded && ruleImplementationLoaded && (
                       <RuleImplementation>
-                        <ExecutionDetails ruleResultId={latest.id} />
+                        <RuleResultDetails ruleResultId={latest.id} />
                       </RuleImplementation>
                     )}
                   </Segment>
                 </>
               )}
             />
-
             <Route
-              exact
               path={RULE_IMPLEMENTATION_RESULT_DETAILS}
-              render={() => (
-                <>
-                  <Segment>
-                    <>
-                      <RuleCrumbs />
-                      <ExecutionDetails />
-                    </>
-                  </Segment>
-                </>
-              )}
+              render={() => <RuleResultsRoutes />}
             />
           </>
         )}

package/src/components/RuleSelector.js

@@ -29,14 +29,17 @@ export const RuleSelector = ({ rules, control, loading }) => {
       control={control}
       name="rule_id"
       rules={{ required: true }}
-      render={({ onBlur, onChange, value }, { invalid }) => (
+      render={({
+        field: { onBlur, onChange, value },
+        fieldState: { error },
+      }) => (
         <Form.Select
           label={{
             children: formatMessage({ id: "rule" }),
             htmlFor: "rule_id",
           }}
           deburr
-          error={invalid}
+          error={!!error}
           loading={loading}
           onBlur={onBlur}
           onChange={(_e, { value }) => onChange(value)}

package/src/components/__test_samples__/NewRuleImplementationProps.js

@@ -239,9 +239,29 @@ export const newRuleImplementationProps = {
         ],
       },
     ],
+    segments: [
+      {
+        structure: {
+          external_id:
+            "/home/alberto/projects/connectors/td-connector-txt-files/data/########_D_PELAYO_POLIZAS_20201202033016_I.txt[Agencia]",
+          id: 4814766,
+          metadata: {
+            order: "6",
+          },
+          name: "Agencia",
+          path: ["Area_Vida", "########_D_PELAYO_POLIZAS_20201202033016_I.txt"],
+          system: {
+            external_id: "file_system",
+            id: 33,
+            name: "File System",
+          },
+          type: "Column",
+        },
+      },
+    ],
     result_type: "errors_number",
-    minimum: 2010,
-    goal: 1,
+    minimum: 20,
+    goal: 10,
     raw_content: {},
   },
   ruleImplementationRaw: {},

package/src/components/__tests__/ExecutionDetails.spec.js

@@ -1,7 +1,7 @@
 import React, { Suspense } from "react";
 import { render } from "@truedat/test/render";
 import messages from "@truedat/dq/messages";
-import { ExecutionDetails } from "../ExecutionDetails";
+import { RuleResultDetails } from "../RuleResultDetails";
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
@@ -18,7 +18,7 @@ const renderOpts = {
   },
 };
 
-describe("<ExecutionDetails>", () => {
+describe("<RuleResultDetails>", () => {
   it("matches the latest snapshot", () => {
     const props = {
       ruleImplementation: {
@@ -27,7 +27,7 @@ describe("<ExecutionDetails>", () => {
     };
     const { container } = render(
       <Suspense fallback={null}>
-        <ExecutionDetails {...props} />
+        <RuleResultDetails {...props} />
       </Suspense>,
       renderOpts
     );
@@ -51,7 +51,7 @@ describe("<ExecutionDetails>", () => {
     };
     const { getByText } = render(
       <Suspense fallback={null}>
-        <ExecutionDetails {...props} />
+        <RuleResultDetails {...props} />
       </Suspense>,
       renderOpts
     );
@@ -67,7 +67,7 @@ describe("<ExecutionDetails>", () => {
     };
     const { container } = render(
       <Suspense fallback={null}>
-        <ExecutionDetails {...propsWithoutDetails} />
+        <RuleResultDetails {...propsWithoutDetails} />
       </Suspense>,
       renderOpts
     );

package/src/components/__tests__/NewRuleImplementation.spec.js

@@ -1,9 +1,16 @@
-import React from "react";
-import { shallow } from "enzyme";
+import React, { Suspense } from "react";
+// import { shallow } from "enzyme";
+import { render } from "@truedat/test/render";
 import { NewRuleImplementation } from "../NewRuleImplementation";
 import { newRuleImplementationProps } from "../__test_samples__/NewRuleImplementationProps";
+import messages from "../../messages/en";
 
 describe("<NewRuleImplementation />", () => {
+  const renderOpts = {
+    messages: { en: messages },
+    state: { ruleImplementationCreating: false },
+  };
+
   const createRuleImplementation = jest.fn();
   const updateRuleImplementation = jest.fn();
   const sources = [{ id: 1, external_id: "foo", config: { alias: ["foo"] } }];
@@ -16,14 +23,27 @@ describe("<NewRuleImplementation />", () => {
   };
 
   it("matches the latest snapshot", () => {
-    const wrapper = shallow(<NewRuleImplementation {...props} />);
-    expect(wrapper).toMatchSnapshot();
+    const { container } = render(
+      <Suspense fallback={null}>
+        <NewRuleImplementation {...props} />
+      </Suspense>,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
   });
 
   it("calculate aliases when not informed", () => {
-    const wrapper = shallow(
-      <NewRuleImplementation {...newRuleImplementationProps} />
+    const applyTemplate = jest.fn();
+    const props = {
+      ...newRuleImplementationProps,
+      applyTemplate: applyTemplate,
+    };
+    const { container } = render(
+      <Suspense fallback={null}>
+        <NewRuleImplementation {...props} />
+      </Suspense>,
+      renderOpts
     );
-    expect(wrapper).toMatchSnapshot();
+    expect(container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleResultSegmentsLoader.spec.js

@@ -0,0 +1,32 @@
+import React from "react";
+import { mount } from "enzyme";
+import { RuleResultSegmentsLoader } from "../RuleResultSegmentsLoader";
+
+jest.mock("react-router-dom", () => ({
+  ...jest.requireActual("react-router-dom"),
+  useParams: () => ({ rule_result_id: 123 }),
+}));
+
+describe("<RuleResultSegmentsLoader />", () => {
+  it("calls fetchSegmentResults when component mounts but not when it unmounts", () => {
+    const props = {
+      clearSegmentResults: jest.fn(),
+      fetchSegmentResults: jest.fn(),
+    };
+    const wrapper = mount(<RuleResultSegmentsLoader {...props} />);
+    expect(props.fetchSegmentResults.mock.calls.length).toBe(1);
+    wrapper.unmount();
+    expect(props.fetchSegmentResults.mock.calls.length).toBe(1);
+  });
+
+  it("calls clearSegmentResults when component unmounts but not when it mounts", () => {
+    const props = {
+      clearSegmentResults: jest.fn(),
+      fetchSegmentResults: jest.fn(),
+    };
+    const wrapper = mount(<RuleResultSegmentsLoader {...props} />);
+    expect(props.clearSegmentResults.mock.calls.length).toBe(0);
+    wrapper.unmount();
+    expect(props.clearSegmentResults.mock.calls.length).toBe(1);
+  });
+});

package/src/components/__tests__/__snapshots__/ExecutionDetails.spec.js.snap

@@ -1,24 +1,9 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ExecutionDetails> matches the latest snapshot 1`] = `
+exports[`<RuleResultDetails> matches the latest snapshot 1`] = `
 <div>
-  <h2
-    class="ui header"
-    style="display: none;"
-  >
-    <i
-      aria-hidden="true"
-      class="chart pie circular icon"
-    />
-    <div
-      class="content"
-    >
-      Rule execution result
-    </div>
-  </h2>
   <table
     class="ui table implementation-results medium"
-    style="display: none;"
   >
     <thead
       class=""
@@ -128,21 +113,8 @@ exports[`<ExecutionDetails> matches the latest snapshot 1`] = `
 </div>
 `;
 
-exports[`<ExecutionDetails> without details 1`] = `
+exports[`<RuleResultDetails> without details 1`] = `
 <div>
-  <h2
-    class="ui header"
-  >
-    <i
-      aria-hidden="true"
-      class="chart pie circular icon"
-    />
-    <div
-      class="content"
-    >
-      Rule execution result
-    </div>
-  </h2>
   <table
     class="ui table implementation-results medium"
   >