@truedat/dq 4.33.7 → 4.34.0

package/src/components/__tests__/ImplementationResultBar.spec.js

@@ -0,0 +1,98 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import ImplementationResultBar from "../ImplementationResultBar";
+import messages from "../../messages/en";
+
+describe("<ImplementationResultBar />", () => {
+  const renderOpts = {
+    messages: { en: messages },
+  };
+  const base = {
+    id: 1,
+    rule_id: 8,
+    goal: 80,
+    minimum: 50,
+    result_type: "percentage",
+  };
+  const overGoalProps = {
+    implementation: {
+      ...base,
+      results: [{ date: "2021-07-19T00:01:20Z", result: "99.99" }],
+    },
+  };
+  const underGoalProps = {
+    implementation: {
+      ...base,
+      results: [{ date: "2021-07-19T00:01:20Z", result: "70" }],
+    },
+  };
+  const underMinimumProps = {
+    implementation: {
+      ...base,
+      results: [{ date: "2021-07-19T00:01:20Z", result: "40" }],
+    },
+  };
+  const notExecutedProps = {
+    implementation: {
+      ...base,
+      results: [],
+    },
+  };
+  const failedProps = {
+    implementation: {
+      ...base,
+      results: [],
+      event_type: "FAILED",
+    },
+  };
+
+  it("render overGoal implementation", () => {
+    const { container } = render(
+      <ImplementationResultBar {...overGoalProps} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+    expect(container.querySelector(".over-goal-color")).not.toBeNull();
+    expect(container).toHaveTextContent("99.99% at 2021-07-19 00:01");
+  });
+
+  it("render underGoal implementation", () => {
+    const { container } = render(
+      <ImplementationResultBar {...underGoalProps} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+    expect(container.querySelector(".under-goal-color")).not.toBeNull();
+    expect(container).toHaveTextContent("70% at 2021-07-19 00:01");
+  });
+
+  it("render underMinimum implementation", () => {
+    const { container } = render(
+      <ImplementationResultBar {...underMinimumProps} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+    expect(container.querySelector(".under-minimum-color")).not.toBeNull();
+    expect(container).toHaveTextContent("40% at 2021-07-19 00:01");
+  });
+
+  it("render not executed implementation", () => {
+    const { container } = render(
+      <ImplementationResultBar {...notExecutedProps} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+    expect(container.querySelector(".not-executed-color")).not.toBeNull();
+    expect(container).toHaveTextContent("No information about quality");
+  });
+
+  it("render failed implementation", () => {
+    const { container } = render(
+      <ImplementationResultBar {...failedProps} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+    expect(container.querySelector(".failed-color")).not.toBeNull();
+    expect(container).toHaveTextContent("Latest execution failed");
+  });
+});

package/src/components/__tests__/ImplementationSummary.spec.js

@@ -7,6 +7,12 @@ import { ImplementationSummary } from "../ImplementationSummary";
 const renderOpts = {
   messages: {
     en: {
+      "ruleImplementationForm.step.information": "information",
+      "quality.thresholds": "thresholds",
+      "quality.threshold": "threshold",
+      "quality.goal": "goal",
+      "ruleImplementations.props.result_type.percentage": "percentage",
+
       "ruleImplementation.summary.field": "Field",
       "ruleImplementation.summary.operator": "Operator",
       "ruleImplementation.summary.structure": "Structure",
@@ -47,6 +53,9 @@ const ruleImplementation = {
       value: [{ raw: ["4", "5", "6"] }],
     },
   ],
+  goal: 50,
+  minimum: 10,
+  result_type: "percentage",
   implementationType: "",
   rawContent: { system: "", dataset: "", population: "", validations: "" },
 };
@@ -82,32 +91,6 @@ describe("<ImplementationSummary />", () => {
     expect(queryByText('"4, 5, 6"')).not.toBeNull();
   });
 
-  it("displays correctly general summary", () => {
-    const props = {
-      ruleImplementation,
-    };
-    const { container, queryByText } = render(
-      <ImplementationSummary {...props} />,
-      renderOpts
-    );
-    expect(container).toMatchSnapshot();
-    expect(queryByText("Executable")).not.toBeNull();
-    expect(queryByText('"ImplKey"')).not.toBeNull();
-  });
-
-  it("renders executable as internal when it is false", () => {
-    const props = {
-      ruleImplementation: { ...ruleImplementation, executable: false },
-    };
-    const { container, queryByText } = render(
-      <ImplementationSummary {...props} />,
-      renderOpts
-    );
-    expect(container).toMatchSnapshot();
-    expect(queryByText("Internal")).not.toBeNull();
-    expect(queryByText('"ImplKey"')).not.toBeNull();
-  });
-
   it("getValues returns array of values that contain required keys and adds optional keys for operator with field value_type", () => {
     expect(
       getValues({

package/src/components/__tests__/InformationSummary.spec.js

@@ -0,0 +1,35 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import InformationSummary from "../InformationSummary";
+import messages from "../../messages/en";
+
+describe("<InformationSummary />", () => {
+  const renderOpts = {
+    messages: { en: messages },
+  };
+  const ruleImplementation = {
+    id: 1,
+    rule_id: 8,
+    goal: 80,
+    minimum: 50,
+  };
+
+  it("renders percentage result_type", () => {
+    const props = {
+      ruleImplementation: { ...ruleImplementation, result_type: "percentage" },
+    };
+    const { container } = render(<InformationSummary {...props} />, renderOpts);
+    expect(container).toMatchSnapshot();
+  });
+
+  it("renders errors_number result_type", () => {
+    const props = {
+      ruleImplementation: {
+        ...ruleImplementation,
+        result_type: "errors_number",
+      },
+    };
+    const { container } = render(<InformationSummary {...props} />, renderOpts);
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/NewRuleImplementation.spec.js

@@ -11,7 +11,7 @@ describe("<NewRuleImplementation />", () => {
     ruleImplementationProps,
     createRuleImplementation,
     updateRuleImplementation,
-    sources
+    sources,
   };
 
   it("matches the latest snapshot", () => {

package/src/components/__tests__/RuleForm.spec.js

@@ -23,8 +23,6 @@ describe("<RuleForm />", () => {
       },
     },
     current_business_concept_version: { name: "My Concept" },
-    goal: 10,
-    minimum: 1,
   };
   const handleSubmit = jest.fn();
   const selectDomain = jest.fn();
@@ -52,9 +50,6 @@ describe("<RuleForm />", () => {
   const eventMock = {
     preventDefault: jest.fn(),
   };
-
-  const findLabel = (wrapper, field) =>
-    wrapper.find("FieldLabelWrapping").find({ label: `rule.props.${field}` });
   const findField = (wrapper, name) => wrapper.find({ name });
 
   it("matches the latest snapshot for editMode", () => {
@@ -112,192 +107,6 @@ describe("<RuleForm />", () => {
     expect(handleSubmit.mock.calls.length).toBe(1);
   });
 
-  it("shows and hides required label", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-
-    const requiredValidation = "rule.form.validation.empty_required";
-
-    const testLabelOnChange = (name, value) => {
-      expect(findLabel(wrapper, name).props().messages).toEqual([
-        requiredValidation,
-      ]);
-      findField(wrapper, name).simulate("change", eventMock, { name, value });
-      expect(findLabel(wrapper, name).props().messages).toEqual(undefined);
-    };
-
-    testLabelOnChange("name", "value");
-    testLabelOnChange("minimum", "2");
-    testLabelOnChange("goal", "3");
-  });
-
-  it("doesnt change goal and minimum fields values when not valid number", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-
-    const testValueOnChange = (name, beforeValue, value, expectedValue) => {
-      expect(findField(wrapper, name).props().value).toEqual(beforeValue);
-      findField(wrapper, name).simulate("change", eventMock, { name, value });
-      expect(findField(wrapper, name).props().value).toEqual(expectedValue);
-    };
-
-    testValueOnChange("minimum", "", "invalid", "");
-    testValueOnChange("minimum", "", "4", 4);
-    testValueOnChange("minimum", 4, "invalid", 4);
-    testValueOnChange("minimum", 4, "", "");
-    testValueOnChange("goal", "", "invalid", "");
-    testValueOnChange("goal", "", "5", 5);
-    testValueOnChange("goal", 5, "invalid", 5);
-    testValueOnChange("goal", 5, "", "");
-  });
-
-  it("shows correct messages for minimum and goal number ranges", () => {
-    const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
-
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "4",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "101",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.max_goal",
-    ]);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "5",
-    });
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "10",
-    });
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual(undefined);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "15",
-    });
-
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual([
-      "rule.form.validation.minimum_greater",
-    ]);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.goal_less",
-    ]);
-  });
-
-  it("shows correct messages for minimum and goal number ranges in a Rule with result_type deviation", () => {
-    const props = {
-      rule: { ...rule, result_type: "deviation" },
-      handleSubmit,
-      templatesLoaded,
-      isSubmitting,
-      template,
-      business_concept_id,
-      applyTemplate: applyTemplate(template),
-    };
-
-    const wrapper = shallowWithIntl(<RuleForm {...props} />);
-
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "11",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.goal.less_eq.minimum",
-    ]);
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "0",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "70",
-    });
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "80",
-    });
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual([
-      "rule.form.validation.minimum.greater_eq.goal",
-    ]);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.goal.less_eq.minimum",
-    ]);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "90",
-    });
-
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual(undefined);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "101",
-    });
-
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual([
-      "rule.form.validation.max_minimum",
-    ]);
-  });
-
-  it("shows correct messages for minimum and goal number ranges in a Rule with result_type numeric", () => {
-    const props = {
-      rule: { ...rule, result_type: "errors_number" },
-      handleSubmit,
-      templatesLoaded,
-      isSubmitting,
-      template,
-      business_concept_id,
-      applyTemplate: applyTemplate(template),
-    };
-
-    const wrapper = shallowWithIntl(<RuleForm {...props} />);
-
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "4",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.goal.less_eq.minimum",
-    ]);
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "1",
-    });
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "5",
-    });
-    findField(wrapper, "goal").simulate("change", eventMock, {
-      name: "goal",
-      value: "10",
-    });
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual([
-      "rule.form.validation.minimum.greater_eq.goal",
-    ]);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual([
-      "rule.form.validation.goal.less_eq.minimum",
-    ]);
-
-    findField(wrapper, "minimum").simulate("change", eventMock, {
-      name: "minimum",
-      value: "15",
-    });
-
-    expect(findLabel(wrapper, "minimum").props().messages).toEqual(undefined);
-    expect(findLabel(wrapper, "goal").props().messages).toEqual(undefined);
-  });
-
   it("handles correctly active field", () => {
     const wrapper = shallowWithIntl(<RuleForm {...defaultProps} />);
 

package/src/components/__tests__/RuleImplementation.spec.js

@@ -6,6 +6,7 @@ const state = {
   authentication: { role: "admin" },
   rule: { id: 1, name: "foo" },
   ruleImplementation: {
+    rule_id: 1,
     implementation_key: "impl key",
     id: 1,
   },

package/src/components/__tests__/RuleImplementationProperties.spec.js

@@ -8,10 +8,7 @@ describe("<RuleImplementationProperties />", () => {
       rule: {
         business_concept_id: "2D2B3",
         description: "desc1",
-        goal: 10,
-        minimum: 1,
         rule_type: { name: "type1" },
-        result_type: "percentage"
       },
       ruleImplementation: {
         id: 10,
@@ -22,7 +19,7 @@ describe("<RuleImplementationProperties />", () => {
         system: {
           external_id: "Microstrategy",
           id: 1,
-          name: "Microstrategy"
+          name: "Microstrategy",
         },
         system_params: {
           table: { name: "aaaxxx" },
@@ -34,15 +31,18 @@ describe("<RuleImplementationProperties />", () => {
               "Objetos Públicos",
               "Informes",
               "Validación",
-              "ACGC - 01.00 Análisis General Compañía"
-            ]
-          }
-        }
+              "ACGC - 01.00 Análisis General Compañía",
+            ],
+          },
+        },
+        goal: 10,
+        minimum: 1,
+        result_type: "percentage",
       },
       ruleImplementationResults: [
         { date: "2019-08-12T02:00:00Z", result: 34 },
-        { date: "2019-08-12T01:00:00Z", result: 33 }
-      ]
+        { date: "2019-08-12T01:00:00Z", result: 33 },
+      ],
     };
     const wrapper = shallowWithIntl(
       <RuleImplementationProperties {...props} />
@@ -55,10 +55,7 @@ describe("<RuleImplementationProperties />", () => {
       rule: {
         business_concept_id: "2D2B3",
         description: "desc1",
-        goal: 10,
-        minimum: 1,
         rule_type: { name: "type1" },
-        result_type: "percentage"
       },
       ruleImplementation: {
         id: 10,
@@ -69,7 +66,7 @@ describe("<RuleImplementationProperties />", () => {
         system: {
           external_id: "Microstrategy",
           id: 1,
-          name: "Microstrategy"
+          name: "Microstrategy",
         },
         system_params: {
           table: { name: "aaaxxx" },
@@ -81,33 +78,26 @@ describe("<RuleImplementationProperties />", () => {
               "Objetos Públicos",
               "Informes",
               "Validación",
-              "ACGC - 01.00 Análisis General Compañía"
-            ]
-          }
-        }
+              "ACGC - 01.00 Análisis General Compañía",
+            ],
+          },
+        },
+        goal: 10,
+        minimum: 1,
+        result_type: "percentage",
       },
       ruleImplementationResults: [
         { date: "2019-08-12T02:00:00Z", result: 34 },
-        { date: "2019-08-12T01:00:00Z", result: 33 }
-      ]
+        { date: "2019-08-12T01:00:00Z", result: 33 },
+      ],
     };
     const wrapper = shallowWithIntl(
       <RuleImplementationProperties {...props} />
     );
-    expect(
-      wrapper
-        .find("Label")
-        .at(0)
-        .prop("color")
-    ).toEqual("olive");
+    expect(wrapper.find("Label").at(0).prop("color")).toEqual("olive");
     wrapper.setProps({
-      ruleImplementation: { ...props.ruleImplementation, executable: false }
+      ruleImplementation: { ...props.ruleImplementation, executable: false },
     });
-    expect(
-      wrapper
-        .find("Label")
-        .at(0)
-        .prop("color")
-    ).toEqual("teal");
+    expect(wrapper.find("Label").at(0).prop("color")).toEqual("teal");
   });
 });

package/src/components/__tests__/RuleImplementationsActions.spec.js

@@ -24,7 +24,7 @@ describe("<RuleImplementationsActions />", () => {
     addImplementationFilter,
     executeImplementationsOn: false,
     setMode,
-    removeImplementationFilter
+    removeImplementationFilter,
   };
   it("matches the latest snapshot", () => {
     const wrapper = shallow(<RuleImplementationsActions {...props} />);
@@ -43,11 +43,11 @@ describe("<RuleImplementationsActions />", () => {
       executionGroupLoading: false,
       ruleImplementationCount: 12,
       implementationsExecution: true,
-      role: "user"
+      role: "user",
     };
     const wrapper = shallow(<RuleImplementationsActions {...props} />);
     expect(wrapper.find({ id: "execute_checkbox" }).length).toBe(1);
-    expect(wrapper.find("ConfirmModal").length).toBe(1);
+    expect(wrapper.find("Connect(ExecutionPopup)").length).toBe(1);
   });
 
   it("as user I do not see execute rules actions if I have no permission", () => {
@@ -55,11 +55,11 @@ describe("<RuleImplementationsActions />", () => {
       canExecute: false,
       executionGroupLoading: false,
       ruleImplementationCount: 12,
-      implementationsExecution: true
+      implementationsExecution: true,
     };
     const wrapper = shallow(<RuleImplementationsActions {...props} />);
     expect(wrapper.find("Checkbox").length).toBe(0);
-    expect(wrapper.find("ConfirmModal").length).toBe(0);
+    expect(wrapper.find("Connect(ExecutionPopup)").length).toBe(0);
     expect(wrapper.find({ id: "execute_button" }).length).toBe(0);
   });
 
@@ -69,12 +69,12 @@ describe("<RuleImplementationsActions />", () => {
       executionGroupLoading: false,
       ruleImplementationCount: 12,
       implementationsExecution: true,
-      executeImplementationsOn: true
+      executeImplementationsOn: true,
     };
     const wrapper = shallow(<RuleImplementationsActions {...props} />);
     expect(wrapper.find("Checkbox").length).toBe(1);
     expect(wrapper.find("Checkbox").props().checked).toBeTruthy();
-    expect(wrapper.find("ConfirmModal").length).toBe(1);
+    expect(wrapper.find("Connect(ExecutionPopup)").length).toBe(1);
   });
 
   it("handles checkbox onChange", () => {
@@ -85,11 +85,11 @@ describe("<RuleImplementationsActions />", () => {
     toCheck.simulate("change");
     expect(setMode).toHaveBeenCalledWith(true);
     expect(addImplementationFilter).toHaveBeenCalledWith({
-      filter: "executable"
+      filter: "executable",
     });
     expect(toggleImplementationFilterValue).toHaveBeenCalledWith({
       filter: "executable",
-      value: true
+      value: true,
     });
     wrapper.setProps({ executeImplementationsOn: true });
     setMode.mockReset();
@@ -98,29 +98,7 @@ describe("<RuleImplementationsActions />", () => {
     toUncheck.simulate("change");
     expect(setMode).toHaveBeenCalledWith(false);
     expect(removeImplementationFilter).toHaveBeenCalledWith({
-      filter: "executable"
-    });
-  });
-
-  it("as user I can submit an execution", () => {
-    const createExecutionGroup = jest.fn();
-    const props = {
-      canExecute: true,
-      executionGroupLoading: false,
-      ruleImplementationCount: 12,
-      implementationsExecution: true,
-      executeImplementationsOn: true,
-      createExecutionGroup,
-      selectedImplementations: [],
-      implementationQuery: { filters: { concept: ["foo"] } }
-    };
-    const wrapper = shallow(<RuleImplementationsActions {...props} />);
-    _.find({ key: "yes" })(
-      wrapper.find("ConfirmModal").props().actions
-    ).onClick({ preventDefault() {} });
-    expect(props.createExecutionGroup.mock.calls.length).toBe(1);
-    expect(props.createExecutionGroup).toHaveBeenCalledWith({
-      filters: { concept: ["foo"] }
+      filter: "executable",
     });
   });
 });

package/src/components/__tests__/RuleProperties.spec.js

@@ -3,12 +3,12 @@ import { shallowWithIntl } from "@truedat/test/intl-stub";
 import { RuleProperties } from "../RuleProperties";
 
 const mockHistory = {
-  push: jest.fn()
+  push: jest.fn(),
 };
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useHistory: () => mockHistory
+  useHistory: () => mockHistory,
 }));
 
 describe("<RuleProperties />", () => {
@@ -24,14 +24,12 @@ describe("<RuleProperties />", () => {
           nodes: [
             {
               data: {},
-              nodes: [{ marks: [{ data: {}, object: "text", text: "desc1" }] }]
-            }
-          ]
-        }
+              nodes: [{ marks: [{ data: {}, object: "text", text: "desc1" }] }],
+            },
+          ],
+        },
       },
-      goal: 10,
-      minimum: 1,
-      rule_type: { name: "type1" }
+      rule_type: { name: "type1" },
     };
     const wrapper = shallowWithIntl(<RuleProperties {...props} />);
     expect(wrapper).toMatchSnapshot();