@truedat/dq 4.33.7 → 4.34.0

package/src/components/RuleImplementationResults.js

@@ -3,8 +3,9 @@ import React from "react";
 import PropTypes from "prop-types";
 import { useIntl } from "react-intl";
 import { connect } from "react-redux";
-import { Table, Message } from "semantic-ui-react";
+import { Table, Message, Divider } from "semantic-ui-react";
 import { columnDecorator } from "@truedat/core/services";
+import Moment from "react-moment";
 import { getRuleResultsColumns } from "../selectors";
 import RuleResultRow from "./RuleResultRow";
 
@@ -25,65 +26,98 @@ export const RuleImplementationResults = ({
   customColumns,
   isAdmin,
 }) => {
-  const { formatMessage } = useIntl();
+  const { formatMessage, locale } = useIntl();
 
   if (_.isEmpty(rule) || _.isEmpty(ruleImplementation)) return null;
 
   const ruleResults = ruleImplementation.results;
   const optionalColumns = getOptionalColumnsWithData(ruleResults);
 
-  return _.isEmpty(ruleResults) ? (
-    <Message
-      style={{ marginTop: "14px" }}
-      header={formatMessage({ id: "rule.ruleImplementation.results.empty" })}
-    />
-  ) : (
-    <Table className="implementation-results small" selectable>
-      <Table.Header>
-        <Table.Row>
-          <Table.HeaderCell
-            content={formatMessage({ id: "ruleResult.props.quality" })}
+  return (
+    <>
+      {ruleImplementation.event_type === "FAILED" && (
+        <Message negative style={{ marginTop: "14px" }}>
+          <Message.Header>
+            {formatMessage({
+              id: "quality.error",
+            })}
+          </Message.Header>
+          <Divider />
+          <Moment
+            style={{
+              position: "absolute",
+              top: "14px",
+              right: "21px",
+            }}
+            locale={locale}
+            date={ruleImplementation.event_inserted_at}
+            format="YYYY-MM-DD HH:mm"
           />
-          <Table.HeaderCell
-            content={formatMessage({ id: "ruleResult.props.date" })}
-          />
-          {_.includes("records")(optionalColumns) && (
-            <Table.HeaderCell
-              content={formatMessage({ id: "ruleResult.props.records" })}
-            />
-          )}
-          {_.includes("errors")(optionalColumns) && (
-            <Table.HeaderCell
-              content={formatMessage({ id: "ruleResult.props.errors" })}
-            />
-          )}
-          {customColumns.map((column, index) => (
-            <Table.HeaderCell
-              key={index}
-              content={formatMessage({
-                id: `ruleResult.props.${column.name}`,
-                defaultMessage: column.name,
-              })}
-            />
-          ))}
-          {<Table.HeaderCell />}
-          {isAdmin && <Table.HeaderCell />}
-        </Table.Row>
-      </Table.Header>
-      <Table.Body>
-        {ruleResults.map((result, i) => (
-          <RuleResultRow
-            key={i}
-            optionalColumns={optionalColumns}
-            ruleResult={result}
-            customColumns={customColumns}
-            isAdmin={isAdmin}
-            ruleImplementation={ruleImplementation}
-            rule={rule}
-          />
-        ))}
-      </Table.Body>
-    </Table>
+          <p
+            style={{
+              whiteSpace: "pre-wrap",
+            }}
+          >
+            {ruleImplementation.event_message}
+          </p>
+        </Message>
+      )}
+      {_.isEmpty(ruleResults) ? (
+        <Message
+          style={{ marginTop: "14px" }}
+          header={formatMessage({
+            id: "rule.ruleImplementation.results.empty",
+          })}
+        />
+      ) : (
+        <Table className="implementation-results small" selectable>
+          <Table.Header>
+            <Table.Row>
+              <Table.HeaderCell
+                content={formatMessage({ id: "ruleResult.props.quality" })}
+              />
+              <Table.HeaderCell
+                content={formatMessage({ id: "ruleResult.props.date" })}
+              />
+              {_.includes("records")(optionalColumns) && (
+                <Table.HeaderCell
+                  content={formatMessage({ id: "ruleResult.props.records" })}
+                />
+              )}
+              {_.includes("errors")(optionalColumns) && (
+                <Table.HeaderCell
+                  content={formatMessage({ id: "ruleResult.props.errors" })}
+                />
+              )}
+              {customColumns.map((column, index) => (
+                <Table.HeaderCell
+                  key={index}
+                  content={formatMessage({
+                    id: `ruleResult.props.${column.name}`,
+                    defaultMessage: column.name,
+                  })}
+                />
+              ))}
+              {<Table.HeaderCell />}
+              {isAdmin && <Table.HeaderCell />}
+            </Table.Row>
+          </Table.Header>
+          <Table.Body>
+            {ruleResults.map((result, i) => (
+              <RuleResultRow
+                key={i}
+                optionalColumns={optionalColumns}
+                ruleResult={result}
+                customColumns={customColumns}
+                isAdmin={isAdmin}
+                ruleImplementation={ruleImplementation}
+                rule={rule}
+              />
+            ))}
+          </Table.Body>
+        </Table>
+      )}
+    </>
   );
 };
 

package/src/components/RuleImplementationsActions.js

@@ -4,8 +4,6 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Button, Checkbox } from "semantic-ui-react";
 import { useIntl } from "react-intl";
-import { FormattedMessage } from "react-intl";
-import { ConfirmModal } from "@truedat/core/components";
 import { downloadImplementations } from "../routines";
 import { getImplementationsExecution } from "../selectors";
 import {
@@ -14,6 +12,7 @@ import {
   removeImplementationFilter,
   createExecutionGroup,
 } from "../routines";
+import ExecutionPopup from "./ExecutionPopup";
 
 const staticHeaderLabels = [
   "implementation_key",
@@ -39,20 +38,6 @@ const staticContentLabels = [
   "executable.false",
 ];
 
-const actions = (handleSubmit) => [
-  {
-    key: "no",
-    secondary: true,
-    content: <FormattedMessage id="confirmation.no" />,
-  },
-  {
-    key: "yes",
-    primary: true,
-    content: <FormattedMessage id="confirmation.yes" />,
-    onClick: handleSubmit,
-  },
-];
-
 export const RuleImplementationsActions = ({
   addImplementationFilter,
   canExecute,
@@ -60,7 +45,6 @@ export const RuleImplementationsActions = ({
   executeImplementationsOn,
   toggleImplementationFilterValue,
   removeImplementationFilter,
-  executionGroupLoading,
   createExecutionGroup,
   selectedImplementations,
   implementationQuery,
@@ -99,11 +83,11 @@ export const RuleImplementationsActions = ({
     checked ? showExecutableInfo() : hideExecutableInfo();
   };
 
-  const handleSubmit = () => {
+  const handleSubmit = (df_content) => {
     const query = _.isEmpty(selectedImplementations)
       ? implementationQuery
       : { filters: { id: selectedImplementations } };
-    createExecutionGroup({ ...query });
+    createExecutionGroup({ ...query, df_content });
   };
   return (
     <div style={{ float: "right" }}>
@@ -117,32 +101,14 @@ export const RuleImplementationsActions = ({
             checked={executeImplementationsOn}
             style={{ top: "6px", marginRight: "7.5px" }}
           />
-          <ConfirmModal
-            actions={actions(handleSubmit)}
-            trigger={
-              <Button
-                id="execute_button"
-                secondary
-                disabled={!executeImplementationsOn}
-                loading={executionGroupLoading}
-                content={
-                  <FormattedMessage id="implementations.actions.do_execution" />
-                }
-              />
-            }
-            header={
-              <FormattedMessage id="implementations.actions.execution.confirmation.header" />
-            }
-            content={
-              <FormattedMessage
-                id="implementations.actions.execution.confirmation.content"
-                values={{
-                  implementations_count: _.isEmpty(selectedImplementations)
-                    ? ruleImplementationCount
-                    : selectedImplementations.length,
-                }}
-              />
+          <ExecutionPopup
+            disabled={!executeImplementationsOn}
+            count={
+              _.isEmpty(selectedImplementations)
+                ? ruleImplementationCount
+                : selectedImplementations.length
             }
+            handleSubmit={handleSubmit}
           />
         </>
       )}
@@ -170,7 +136,6 @@ RuleImplementationsActions.propTypes = {
   canExecute: PropTypes.bool,
   createExecutionGroup: PropTypes.func,
   executeImplementationsOn: PropTypes.bool,
-  executionGroupLoading: PropTypes.bool,
   implementationsExecution: PropTypes.bool,
   implementationQuery: PropTypes.object,
   removeImplementationFilter: PropTypes.func,
@@ -184,7 +149,6 @@ RuleImplementationsActions.propTypes = {
 
 const mapStateToProps = (state) => ({
   canExecute: _.propOr(false, "userImplementationsPermissions.execute")(state),
-  executionGroupLoading: state.executionGroupLoading,
   ruleImplementationCount: state.ruleImplementationCount,
   implementationsExecution: getImplementationsExecution(state),
   ruleImplementationsDownloading: state.ruleImplementationsDownloading,

package/src/components/RuleProperties.js

@@ -3,12 +3,10 @@ import React from "react";
 import PropTypes from "prop-types";
 import { FormattedMessage } from "react-intl";
 import { connect } from "react-redux";
-import { useHistory, Link } from "react-router-dom";
+import { Link } from "react-router-dom";
 import { List, Label } from "semantic-ui-react";
 import "rc-slider/assets/index.css";
 import { linkTo } from "@truedat/core/routes";
-import RuleRangeNumber from "./RuleRangeNumber";
-import RuleRangePercentage from "./RuleRangePercentage";
 
 const RichTextEditor = React.lazy(() =>
   import("@truedat/core/components/RichTextEditor")
@@ -27,7 +25,6 @@ export const RuleProperties = ({
   domain,
   domain_id,
   active,
-  result_type,
 }) => {
   return (
     <List size="big" relaxed>
@@ -67,11 +64,6 @@ export const RuleProperties = ({
             </Link>
           </List.Item>
         )}
-      {["percentage", "deviation"].includes(result_type) ? (
-        <RuleRangePercentage />
-      ) : (
-        <RuleRangeNumber />
-      )}
     </List>
   );
 };
@@ -83,7 +75,6 @@ RuleProperties.propTypes = {
   description: PropTypes.object,
   domain: PropTypes.object,
   domain_id: PropTypes.number,
-  result_type: PropTypes.string,
 };
 
 const mapStateToProps = ({ rule }) => rule;

package/src/components/RuleResultDecorator.js

@@ -10,31 +10,30 @@ const nilResult = (ruleResult) =>
   isNil(ruleResult) ||
   (has("result_text")(ruleResult) && isNil(ruleResult?.result_text));
 
-export const RuleResultDecorator = ({ ruleResult, rule, date }) => {
-  const { formatMessage, formatNumber: _formatNumber } = useIntl();
+export const calculateResultDecoration = ({
+  ruleResult,
+  ruleImplementation,
+  date,
+  intl: { formatMessage, formatNumber: _formatNumber },
+}) => {
   const formatNumber = (num) => (isNil(num) ? num : _formatNumber(num));
-  if (nilResult(ruleResult) && isNil(date)) {
-    return null;
-  }
+
   if (ruleResult?.result_text === "quality_result.failed") {
-    return (
-      <>
-        <Icon
-          name="warning circle"
-          color="red"
-          title={formatMessage({ id: "quality_result.failed" })}
-        />
-        {formatMessage({ id: "quality_result.failed" })}
-      </>
-    );
+    const resultText = formatMessage({ id: "quality_result.failed" });
+    return {
+      iconName: "warning circle",
+      resultText: resultText,
+      color: "red",
+      resultText,
+    };
   }
-  const resultText = ruleResult?.result_text;
-  const resultType = rule?.result_type;
+
+  const resultType = ruleImplementation?.result_type;
   const result =
     resultType === "errors_number"
       ? formatNumber(ruleResult?.errors)
       : ruleResult?.result;
-  const resultTitle = isNil(result)
+  const resultText = isNil(result)
     ? formatMessage({ id: "quality.result.no.data" })
     : date
     ? formatMessage(
@@ -45,23 +44,41 @@ export const RuleResultDecorator = ({ ruleResult, rule, date }) => {
         { id: `quality.result.${resultType}.description` },
         { result }
       );
-  const color = selectColor({ ...rule, ...ruleResult });
+  const color = selectColor({ ...ruleImplementation, ...ruleResult });
+  const iconTitle = ruleResult?.result_text
+    ? formatMessage({ id: ruleResult?.result_text })
+    : null;
+
+  return { iconName: "circle", color, resultText, iconTitle };
+};
+
+export const RuleResultDecorator = ({
+  ruleResult,
+  ruleImplementation,
+  date,
+}) => {
+  const intl = useIntl();
+  if (nilResult(ruleResult) && isNil(date)) {
+    return null;
+  }
+  const { iconName, color, resultText, iconTitle } = calculateResultDecoration({
+    ruleResult,
+    ruleImplementation,
+    date,
+    intl,
+  });
 
   return (
     <>
-      <Icon
-        name="circle"
-        title={resultText ? formatMessage({ id: resultText }) : null}
-        color={color}
-      />
-      {resultTitle}
+      <Icon name={iconName} title={iconTitle} color={color} />
+      {resultText}
     </>
   );
 };
 
 RuleResultDecorator.propTypes = {
   ruleResult: PropTypes.object,
-  rule: PropTypes.object,
+  ruleImplementation: PropTypes.object,
   date: PropTypes.string,
 };
 

package/src/components/RuleResultRow.js

@@ -41,7 +41,10 @@ export const RuleResultRow = ({
       }
     >
       <Table.Cell>
-        <Icon name="circle" color={selectColor({ ...rule, ...ruleResult })} />
+        <Icon
+          name="circle"
+          color={selectColor({ ...ruleImplementation, ...ruleResult })}
+        />
         {`${parseFloat(ruleResult.result)} %`}
       </Table.Cell>
       <Table.Cell>

package/src/components/RuleRoutes.js

@@ -66,7 +66,6 @@ const RuleRoutes = ({
   templatesLoaded,
   template,
   structuresAliasesLoading,
-  templateImpl,
   ruleImplementation,
 }) => {
   const latest = _.head(ruleImplementation.results);
@@ -227,14 +226,6 @@ const RuleRoutes = ({
                             <RuleImplementationProperties />
                           </RuleImplementation>
                         )}
-                        {!_.isEmpty(templateImpl) && ruleImplementationLoaded && (
-                          <Segment attached="bottom">
-                            <DynamicFormViewer
-                              template={templateImpl}
-                              content={ruleImplementation.df_content}
-                            />
-                          </Segment>
-                        )}
                       </Segment>
                     </>
                   )}
@@ -305,7 +296,6 @@ RuleRoutes.propTypes = {
   implementationStructures: PropTypes.array,
   ruleLoaded: PropTypes.bool,
   template: PropTypes.object,
-  templateImpl: PropTypes.object,
   ruleImplementation: PropTypes.object,
   ruleImplementationLoaded: PropTypes.bool,
   implementationStructuresLoaded: PropTypes.bool,
@@ -325,9 +315,6 @@ const mapStateToProps = (state) => ({
   templatesLoaded: !state.templatesLoading && !_.isEmpty(state.templates),
   template: _.find(_.propEq("name", state.rule.df_name))(state.templates),
   structuresAliasesLoading: state.structuresAliasesLoading,
-  templateImpl: _.find(_.propEq("name", state.ruleImplementation.df_name))(
-    state.templates
-  ),
   ruleImplementation: state.ruleImplementation,
 });
 

package/src/components/RuleSummary.js

@@ -22,8 +22,12 @@ const mapSummary = (implementations) => {
   const failed = _.size(failedImplementations);
   const quality = _.reduce(
     (summary, implementation) => {
-      const { errors, result } = implementation.execution_result_info;
-      const { goal, minimum, result_type } = implementation.rule;
+      const {
+        goal,
+        minimum,
+        result_type,
+        execution_result_info: { errors, result },
+      } = implementation;
       const color = selectColor({ errors, result, minimum, goal, result_type });
       return _.set(color, summary[color] + 1)(summary);
     },
@@ -71,6 +75,15 @@ const SummaryBar = ({
   </>
 );
 
+SummaryBar.propTypes = {
+  key: PropTypes.string,
+  className: PropTypes.string,
+  summary: PropTypes.object,
+  percentages: PropTypes.array,
+  showPercentages: PropTypes.bool,
+  tooltip: PropTypes.string,
+};
+
 const SummaryBars = (props) => {
   return (
     <div className="rule-summary">

package/src/components/__tests__/ExecutionForm.spec.js

@@ -0,0 +1,25 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { ExecutionForm } from "../ExecutionForm";
+
+describe("<ExecutionForm />", () => {
+  const handleSubmit = jest.fn();
+  const selectTemplate = jest.fn();
+  const props = { count: 1, templates: [], handleSubmit, selectTemplate };
+  const renderOpts = {
+    messages: {
+      en: {
+        "actions.cancel": "cancel",
+        "actions.create": "create",
+        "implementations.actions.execution.confirmation.content": "content",
+        "implementations.actions.execution.confirmation.header": "header",
+        "implementations.actions.execution.confirmation.legend": "legend",
+      },
+    },
+  };
+
+  it("matches the latest snapshot", () => {
+    const { container } = render(<ExecutionForm {...props} />, renderOpts);
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/ExecutionGroup.spec.js

@@ -11,11 +11,15 @@ describe("<ExecutionGroup />", () => {
   const rule = {
     id: 1,
     name: "rule_name",
+  };
+  const implementation = {
+    id: 1,
+    implementation_key: "foo",
+    rule_id: 1,
     result_type: "percentage",
     minimum: 10,
-    goal: 20
+    goal: 20,
   };
-  const implementation = { id: 1, implementation_key: "foo", rule_id: 1 };
   const result = {
     id: 1,
     implementation_key: "foo",
@@ -25,7 +29,7 @@ describe("<ExecutionGroup />", () => {
     errors: 30,
     result_type: "percentage",
     minimum: 10,
-    goal: 20
+    goal: 20,
   };
   const quality_events = [
     {
@@ -33,14 +37,14 @@ describe("<ExecutionGroup />", () => {
       execution_id: 1,
       id: 1,
       type: "SUCCESS",
-      message: ""
-    }
+      message: "",
+    },
   ];
   const executions = [
-    { id: 1, _embedded: { rule, implementation, result, quality_events } }
+    { id: 1, _embedded: { rule, implementation, result, quality_events } },
   ];
   const props = {
-    executionGroup: { id: 1, _embedded: { executions } }
+    executionGroup: { id: 1, _embedded: { executions } },
   };
 
   it("matches the latest snapshot", () => {

package/src/components/__tests__/ExecutionPopup.spec.js

@@ -0,0 +1,20 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { ExecutionPopup } from "../ExecutionPopup";
+
+describe("<ExecutionPopup />", () => {
+  const handleSubmit = jest.fn();
+  const props = { count: 1, handleSubmit };
+  const renderOpts = {
+    messages: {
+      en: {
+        "implementations.actions.do_execution": "do_execution",
+      },
+    },
+  };
+
+  it("matches the latest snapshot", () => {
+    const { container } = render(<ExecutionPopup {...props} />, renderOpts);
+    expect(container).toMatchSnapshot();
+  });
+});