@truedat/dq 4.33.10 → 4.35.2

package/src/components/ruleImplementationForm/__tests__/LimitsForm.spec.js

@@ -0,0 +1,186 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import { fireEvent } from "@testing-library/react";
+import LimitsForm from "../LimitsForm";
+import messages from "../../../messages/en";
+
+describe("<LimitsForm />", () => {
+  const renderOpts = {
+    messages: { en: messages },
+  };
+
+  it("input changes calls onChange prop", () => {
+    const onChange = jest.fn();
+    const props = {
+      ruleImplementation: {
+        goal: null,
+        minimum: null,
+        result_type: "percentage",
+      },
+      onChange,
+    };
+
+    const { container } = render(<LimitsForm {...props} />, renderOpts);
+
+    fireEvent.change(container.querySelector("input[name=goal]"), {
+      target: { name: "goal", value: "5" },
+    });
+
+    expect(onChange).toBeCalledWith("goal", "5");
+  });
+
+  it("shows required label", () => {
+    const props = {
+      ruleImplementation: {
+        goal: null,
+        minimum: null,
+        result_type: "percentage",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    const errorText = "Required field is empty";
+    expect(getByText("Goal")).toHaveTextContent(errorText);
+    expect(getByText("Threshold")).toHaveTextContent(errorText);
+  });
+
+  it("shows invalid number label", () => {
+    const props = {
+      ruleImplementation: {
+        goal: "text",
+        minimum: "text",
+        result_type: "percentage",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    const errorText = "Invalid number format";
+    expect(getByText("Goal")).toHaveTextContent(errorText);
+    expect(getByText("Threshold")).toHaveTextContent(errorText);
+  });
+
+  it("shows label for percentage goal over 100", () => {
+    const props = {
+      ruleImplementation: {
+        goal: "200",
+        minimum: "1",
+        result_type: "percentage",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    const errorText = "Goal percentage cannot be greater than 100";
+    expect(getByText("Goal")).toHaveTextContent(errorText);
+  });
+
+  it("shows label for percentage goal greater than minimum", () => {
+    const props = {
+      ruleImplementation: {
+        goal: 20,
+        minimum: 30,
+        result_type: "percentage",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    expect(getByText("Goal")).toHaveTextContent(
+      "Goal must be greater than (or equal to) the threshold (higher goal is better)."
+    );
+    expect(getByText("Threshold")).toHaveTextContent(
+      "Threshold must be lower than (or equal to) the goal"
+    );
+  });
+
+  it("shows label for deviation minimum greater than 100", () => {
+    const props = {
+      ruleImplementation: {
+        goal: "1",
+        minimum: "200",
+        result_type: "deviation",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    expect(getByText("Threshold")).toHaveTextContent(
+      "Threshold percentage cannot be greater than 100"
+    );
+  });
+
+  it("shows label for deviation minimum greater than goal", () => {
+    const props = {
+      ruleImplementation: {
+        goal: "50",
+        minimum: "10",
+        result_type: "deviation",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    expect(getByText("Goal")).toHaveTextContent(
+      "Goal must be less than (or equal to) the threshold (lower goal is better)"
+    );
+    expect(getByText("Threshold")).toHaveTextContent(
+      "Threshold must greater than (or equal to) the goal"
+    );
+  });
+
+  it("shows label for errors_number minimum greater than goal", () => {
+    const props = {
+      ruleImplementation: {
+        goal: "200",
+        minimum: "100",
+        result_type: "errors_number",
+      },
+      onChange: jest.fn(),
+    };
+
+    const { container, getByText } = render(
+      <LimitsForm {...props} />,
+      renderOpts
+    );
+    expect(container).toMatchSnapshot();
+
+    expect(getByText("Goal")).toHaveTextContent(
+      "Goal must be less than (or equal to) the threshold (lower goal is better)"
+    );
+    expect(getByText("Threshold")).toHaveTextContent(
+      "Threshold must greater than (or equal to) the goal"
+    );
+  });
+});

package/src/components/ruleImplementationForm/__tests__/RuleImplementationRawForm.spec.js

@@ -9,7 +9,7 @@ import { RuleImplementationRawForm } from "../RuleImplementationRawForm";
 jest.spyOn(React, "useContext").mockImplementation(() => intl);
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useHistory: () => ({ push: jest.fn() })
+  useHistory: () => ({ push: jest.fn() }),
 }));
 
 describe("<RuleImplementationRawForm />", () => {
@@ -20,36 +20,42 @@ describe("<RuleImplementationRawForm />", () => {
     {
       id: 1,
       config: { alias: "source1", job_types: ["quality"] },
-      external_id: "ext_id_1"
+      external_id: "ext_id_1",
     },
     {
       id: 2,
       config: {
         alias: "source2",
         job_types: ["quality"],
-        databases: ["db1", "db2"]
+        databases: ["db1", "db2"],
       },
-      external_id: "ext_id_2"
+      external_id: "ext_id_2",
     },
-    { id: 3, config: {}, external_id: "ext_id_3" }
+    { id: 3, config: {}, external_id: "ext_id_3" },
   ];
   const setImplementationRawContent = jest.fn();
 
   const props = {
     implementationKey: "",
     setImplementationKey: jest.fn(),
-    ruleImplementation: { id: 1, executable: true },
+    ruleImplementation: {
+      id: 1,
+      executable: true,
+      goal: "10",
+      minimum: "1",
+      result_type: "percentage",
+    },
     rawContent: {
       dataset: "",
       source_id: 1,
       population: "",
-      validations: ""
+      validations: "",
     },
     setImplementationRawContent: setImplementationRawContent,
     handleSubmit,
     isSubmitting,
     sources,
-    onChange
+    onChange,
   };
 
   it("matches the latest snapshot", () => {
@@ -63,8 +69,8 @@ describe("<RuleImplementationRawForm />", () => {
       rawContent: {
         dataset: "cliente c join address a on c.address_id=a.id",
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
 
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
@@ -79,8 +85,8 @@ describe("<RuleImplementationRawForm />", () => {
         dataset: "cliente c join address a on c.address_id=a.id",
         source_id: 2,
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
 
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
@@ -95,8 +101,8 @@ describe("<RuleImplementationRawForm />", () => {
         dataset: "cliente c join address a on c.address_id=a.id",
         source_id: 1,
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
 
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
@@ -112,8 +118,10 @@ describe("<RuleImplementationRawForm />", () => {
         source_id: 2,
         database: "db2",
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
+      template: { id: 1 },
+      dfContent: {},
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");
@@ -127,8 +135,8 @@ describe("<RuleImplementationRawForm />", () => {
         dataset: "address a on c.address_id=a.id",
         source_id: 2,
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");
@@ -138,12 +146,9 @@ describe("<RuleImplementationRawForm />", () => {
   it("calls setImplementationRawContent when filling raw content input fields", () => {
     const wrapper = shallow(<RuleImplementationRawForm {...props} />);
     expect(setImplementationRawContent.mock.calls).toHaveLength(0);
-    wrapper
-      .find("FormTextArea")
-      .at(0)
-      .simulate("change", null, {
-        value: "cliente c join address a on c.address_id=a.id"
-      });
+    wrapper.find("FormTextArea").at(0).simulate("change", null, {
+      value: "cliente c join address a on c.address_id=a.id",
+    });
     expect(setImplementationRawContent.mock.calls).toHaveLength(1);
   });
 
@@ -151,7 +156,7 @@ describe("<RuleImplementationRawForm />", () => {
     const setImplementationRawContent = jest.fn();
     const customProps = {
       ...props,
-      setImplementationRawContent
+      setImplementationRawContent,
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
 
@@ -160,7 +165,7 @@ describe("<RuleImplementationRawForm />", () => {
       .find("FormDropdown[name='source_id']")
       .at(0)
       .simulate("change", null, {
-        value: 2
+        value: 2,
       });
     expect(setImplementationRawContent.mock.calls).toHaveLength(1);
     expect(setImplementationRawContent).toHaveBeenCalledWith({
@@ -168,7 +173,7 @@ describe("<RuleImplementationRawForm />", () => {
       dataset: "",
       population: "",
       source_id: 2,
-      validations: ""
+      validations: "",
     });
   });
 
@@ -179,8 +184,10 @@ describe("<RuleImplementationRawForm />", () => {
         dataset: "cliente c join address a on c.address_id=a.id",
         source_id: 1,
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
+      template: { id: 1 },
+      dfContent: {},
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");
@@ -193,8 +200,8 @@ describe("<RuleImplementationRawForm />", () => {
       rawContent: {
         dataset: "insert into cliente c join address a on c.address_id=a.id",
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const submitButton = wrapper.find("FormButton[type='submit']");
@@ -208,8 +215,8 @@ describe("<RuleImplementationRawForm />", () => {
         dataset: "insert into cliente c join address a on c.address_id=a.id",
         source_id: 1,
         population: "",
-        validations: "a.city='MADRID'"
-      }
+        validations: "a.city='MADRID'",
+      },
     };
     const wrapper = shallow(<RuleImplementationRawForm {...customProps} />);
     const datasetTextArea = wrapper.find("FormTextArea").at(0);
@@ -219,7 +226,7 @@ describe("<RuleImplementationRawForm />", () => {
           id="ruleImplementationRawForm.rawText.error"
           values={{ invalid_content: <i>insert</i> }}
         />
-      )
+      ),
     });
   });
 
@@ -228,7 +235,7 @@ describe("<RuleImplementationRawForm />", () => {
     const radio = wrapper.find({ name: "executable" }).at(0);
 
     radio.simulate("change", null, {
-      checked: false
+      checked: false,
     });
 
     expect(onChange).toHaveBeenCalledWith("executable", false);