@truedat/dq 4.33.10 → 4.35.2

package/src/components/__tests__/RuleResultRow.spec.js

@@ -16,15 +16,15 @@ describe("<RuleResultRow />", () => {
       customColumns: [
         {
           name: "m_parm1",
-          fieldSelector: _.path("params.p1")
+          fieldSelector: _.path("params.p1"),
         },
         {
           name: "m_parm2",
-          fieldSelector: _.path("params.p2")
-        }
+          fieldSelector: _.path("params.p2"),
+        },
       ],
       date: "2019-08-12T02:00:00Z",
-      rule: { minimum: 1, goal: 10, result_type: "percentage" }
+      ruleImplementation: { minimum: 1, goal: 10, result_type: "percentage" },
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
@@ -53,26 +53,19 @@ describe("<RuleResultRow />", () => {
       id: 10,
       ruleResult: { result: 80 },
       date: "2019-08-12T02:00:00Z",
-      rule: {
+      ruleImplementation: {
         minimum: 1,
         goal: 10,
-        result_type: "percentage"
-      }
+        result_type: "percentage",
+      },
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(0)
-      .dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
-    const icon = cell
-      .find("td")
-      .find("Icon")
-      .at(0);
+    const icon = cell.find("td").find("Icon").at(0);
 
     expect(icon.props().color).toBe("green");
   });
@@ -82,26 +75,19 @@ describe("<RuleResultRow />", () => {
       id: 10,
       ruleResult: { result: 80 },
       date: "2019-08-12T02:00:00Z",
-      rule: {
+      ruleImplementation: {
         minimum: 81,
         goal: 90,
-        result_type: "percentage"
-      }
+        result_type: "percentage",
+      },
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(0)
-      .dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
-    const icon = cell
-      .find("td")
-      .find("Icon")
-      .at(0);
+    const icon = cell.find("td").find("Icon").at(0);
 
     expect(icon.props().color).toBe("red");
   });
@@ -109,28 +95,21 @@ describe("<RuleResultRow />", () => {
   it("yellow icon when result is between minimum and goal", () => {
     const ruleResultRowProps = {
       id: 10,
-      rule: {
+      ruleImplementation: {
         minimum: 81,
         goal: 90,
-        result_type: "percentage"
+        result_type: "percentage",
       },
       ruleResult: { result: 82 },
-      date: "2019-08-12T02:00:00Z"
+      date: "2019-08-12T02:00:00Z",
     };
 
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
-    const cell = wrapper
-      .find("TableRow")
-      .find("TableCell")
-      .at(0)
-      .dive();
+    const cell = wrapper.find("TableRow").find("TableCell").at(0).dive();
 
     expect(cell.find("td").find("Icon")).toHaveLength(1);
 
-    const icon = cell
-      .find("td")
-      .find("Icon")
-      .at(0);
+    const icon = cell.find("td").find("Icon").at(0);
 
     expect(icon.props().color).toBe("yellow");
   });
@@ -138,15 +117,15 @@ describe("<RuleResultRow />", () => {
   it("renders delete cell in RuleResultRow when user isAdmin is true", () => {
     const ruleResultRowProps = {
       id: 10,
-      rule: {
+      ruleImplementation: {
         minimum: 81,
         goal: 90,
-        result_type: "percentage"
+        result_type: "percentage",
       },
       ruleResult: { result: 82 },
       date: "2019-08-12T02:00:00Z",
       isAdmin: true,
-      deleteRuleResult: jest.fn()
+      deleteRuleResult: jest.fn(),
     };
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
     const modal = wrapper
@@ -160,15 +139,15 @@ describe("<RuleResultRow />", () => {
   it("does not render delete cell in RuleResultRow when user isAdmin is false", () => {
     const ruleResultRowProps = {
       id: 10,
-      rule: {
+      ruleImplementation: {
         minimum: 81,
         goal: 90,
-        result_type: "percentage"
+        result_type: "percentage",
       },
       ruleResult: { result: 82 },
       date: "2019-08-12T02:00:00Z",
       isAdmin: false,
-      deleteRuleResult: jest.fn()
+      deleteRuleResult: jest.fn(),
     };
     const wrapper = shallow(<RuleResultRow {...ruleResultRowProps} />);
     const modal = wrapper.find("ConfirmModal");

package/src/components/__tests__/RuleResultsUpload.spec.js

@@ -0,0 +1,18 @@
+import _ from "lodash/fp";
+import React from "react";
+import { shallow } from "enzyme";
+import { intl } from "@truedat/test/intl-stub";
+import { RuleResultsUpload } from "../RuleResultsUpload";
+
+jest.spyOn(React, "useContext").mockImplementation(() => intl);
+
+describe("<RuleResultsUpload />", () => {
+  it("matches the latest snapshot", () => {
+    const props = {
+      uploadResults: jest.fn(),
+      loading: false,
+    };
+    const wrapper = shallow(<RuleResultsUpload {...props} />);
+    expect(wrapper).toMatchSnapshot();
+  });
+});

package/src/components/__tests__/RuleRow.spec.js

@@ -20,8 +20,6 @@ const default_rule = {
   deleted_at: null,
   name: "2s",
   description: "aaaaa",
-  goal: 22,
-  minimum: 1,
   active: true,
 };
 
@@ -46,8 +44,6 @@ describe("<RuleRow />", () => {
       id: 55,
       name: "foo is the rule name",
       description: "aaaaa",
-      goal: 22,
-      minimum: 1,
       result_type: "percentage",
     };
     const columns = _.concat(defaultRuleColumns("es"), [

package/src/components/__tests__/RuleSummary.spec.js

@@ -5,13 +5,13 @@ import { RuleSummary } from "../RuleSummary";
 import messages from "../../messages/en";
 
 describe("<RuleSummary />", () => {
-  const rule = {
+  const implementationLimits = {
     goal: 90,
     minimum: 80,
     result_type: "percentage",
   };
   const overGoalExecution = {
-    rule,
+    ...implementationLimits,
     execution_result_info: {
       date: "2021-07-19T00:01:20Z",
       result: "99.99",
@@ -19,22 +19,22 @@ describe("<RuleSummary />", () => {
     },
   };
   const underGoalExecution = {
-    rule,
+    ...implementationLimits,
     execution_result_info: {
       date: "2021-03-21T19:08:19Z",
       result: "85",
     },
   };
   const underMinimumExecution = {
-    rule,
+    ...implementationLimits,
     execution_result_info: {
       date: "2021-03-21T19:08:19Z",
       result: "50",
     },
   };
-  const notExecuted = { rule, execution_result_info: {} };
+  const notExecuted = { ...implementationLimits, execution_result_info: {} };
   const failedExecution = {
-    rule,
+    ...implementationLimits,
     execution_result_info: {
       date: "2021-07-19T00:01:20Z",
     },

package/src/components/__tests__/Rules.spec.js

@@ -10,23 +10,19 @@ describe("<Rules />", () => {
       business_concept_id: "2D2B3",
       name: "control1",
       description: "desc1",
-      goal: 10,
-      minimum: 1,
       type: "type1",
       type_params: {},
-      status: "status1"
+      status: "status1",
     },
     {
       id: 122,
       business_concept_id: "2D2B4",
       name: "control2",
       description: "desc2",
-      goal: 10,
-      minimum: 1,
       type: "type2",
       type_params: {},
-      status: "status2"
-    }
+      status: "status2",
+    },
   ];
   const columns = ruleColumnsSelector({}, { locale: "es" });
   const rulesSort = [{ "name.raw": "desc" }];
@@ -47,44 +43,24 @@ describe("<Rules />", () => {
   it("sorts column in the direction set", () => {
     const props = { rules, columns, rulesSort };
     const wrapper = shallow(<Rules {...props} />);
-    expect(
-      wrapper
-        .find("TableHeaderCell")
-        .at(0)
-        .props().sorted
-    ).toEqual("descending");
+    expect(wrapper.find("TableHeaderCell").at(0).props().sorted).toEqual(
+      "descending"
+    );
 
-    expect(
-      wrapper
-        .find("TableHeaderCell")
-        .at(1)
-        .props().sorted
-    ).toEqual(null);
+    expect(wrapper.find("TableHeaderCell").at(1).props().sorted).toEqual(null);
   });
 
   it("handles sort when column header is clicked", () => {
     const props = { rules, columns, sortRules };
     const wrapper = shallow(<Rules {...props} />);
-    wrapper
-      .find("TableHeaderCell")
-      .at(0)
-      .simulate("click");
-    expect(
-      wrapper
-        .find("TableHeaderCell")
-        .at(0)
-        .props().sorted
-    ).toEqual("ascending");
+    wrapper.find("TableHeaderCell").at(0).simulate("click");
+    expect(wrapper.find("TableHeaderCell").at(0).props().sorted).toEqual(
+      "ascending"
+    );
 
-    wrapper
-      .find("TableHeaderCell")
-      .at(0)
-      .simulate("click");
-    expect(
-      wrapper
-        .find("TableHeaderCell")
-        .at(0)
-        .props().sorted
-    ).toEqual("descending");
+    wrapper.find("TableHeaderCell").at(0).simulate("click");
+    expect(wrapper.find("TableHeaderCell").at(0).props().sorted).toEqual(
+      "descending"
+    );
   });
 });

package/src/components/__tests__/__snapshots__/ConditionSummary.spec.js.snap

@@ -15,71 +15,75 @@ exports[`<ConditionSummary /> matches the latest snapshot 1`] = `
       filters
     </div>
   </h3>
-  <table
-    class="ui very basic table"
+  <div
+    class="ui segment"
   >
-    <thead
-      class=""
+    <table
+      class="ui very basic table"
     >
-      <tr
+      <thead
         class=""
       >
-        <th
+        <tr
           class=""
         >
-          field
-        </th>
-        <th
-          class=""
-        >
-          operator
-        </th>
-        <th
-          class=""
-        >
-          values
-        </th>
-      </tr>
-    </thead>
-    <tbody
-      class=""
-    >
-      <tr
+          <th
+            class=""
+          >
+            field
+          </th>
+          <th
+            class=""
+          >
+            operator
+          </th>
+          <th
+            class=""
+          >
+            values
+          </th>
+        </tr>
+      </thead>
+      <tbody
         class=""
       >
-        <td
-          class="five wide"
+        <tr
+          class=""
         >
-          <a
-            href="/structures/2598"
+          <td
+            class="five wide"
+          >
+            <a
+              href="/structures/2598"
+            >
+              <span
+                class="highlighted"
+              >
+                "Mes"
+              </span>
+            </a>
+          </td>
+          <td
+            class="five wide"
           >
             <span
               class="highlighted"
             >
-              "Mes"
+              "in_list"
             </span>
-          </a>
-        </td>
-        <td
-          class="five wide"
-        >
-          <span
-            class="highlighted"
-          >
-            "in_list"
-          </span>
-        </td>
-        <td
-          class="five wide"
-        >
-          <span
-            class="highlighted"
+          </td>
+          <td
+            class="five wide"
           >
-            "4, 5, 6"
-          </span>
-        </td>
-      </tr>
-    </tbody>
-  </table>
+            <span
+              class="highlighted"
+            >
+              "4, 5, 6"
+            </span>
+          </td>
+        </tr>
+      </tbody>
+    </table>
+  </div>
 </div>
 `;

package/src/components/__tests__/__snapshots__/ExecutionGroup.spec.js.snap

@@ -4,7 +4,8 @@ exports[`<ExecutionGroup /> matches the latest snapshot 1`] = `
 <Fragment>
   <ExecutionGroupMessage
     count={1}
-    pending={0}
+    error={1}
+    pending={-1}
   />
   <Table
     as="table"
@@ -64,8 +65,11 @@ exports[`<ExecutionGroup /> matches the latest snapshot 1`] = `
           Object {
             "_embedded": Object {
               "implementation": Object {
+                "goal": 20,
                 "id": 1,
                 "implementation_key": "foo",
+                "minimum": 10,
+                "result_type": "percentage",
                 "rule_id": 1,
               },
               "quality_events": Array [
@@ -89,11 +93,8 @@ exports[`<ExecutionGroup /> matches the latest snapshot 1`] = `
                 "result_type": "percentage",
               },
               "rule": Object {
-                "goal": 20,
                 "id": 1,
-                "minimum": 10,
                 "name": "rule_name",
-                "result_type": "percentage",
               },
             },
             "id": 1,

package/src/components/__tests__/__snapshots__/ImplementationResultBar.spec.js.snap

@@ -0,0 +1,141 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ImplementationResultBar /> render failed implementation 1`] = `
+<div>
+  <div
+    class="rule-summary-wrapper"
+  >
+    <a
+      as="div"
+      class="rule-summary pointer"
+      href="/rules/8/implementations/1/results"
+    >
+      <span
+        class="failed-color"
+        style="width: 100%;"
+      >
+        <span
+          class="value"
+        >
+          Latest execution failed
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationResultBar /> render not executed implementation 1`] = `
+<div>
+  <div
+    class="rule-summary-wrapper"
+  >
+    <a
+      as="div"
+      class="rule-summary pointer"
+      href="/rules/8/implementations/1/results"
+    >
+      <span
+        class="not-executed-color"
+        style="width: 100%;"
+      >
+        <span
+          class="value"
+        >
+          No information about quality
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationResultBar /> render overGoal implementation 1`] = `
+<div>
+  <div
+    class="rule-summary-wrapper"
+  >
+    <a
+      as="div"
+      class="rule-summary pointer"
+      href="/rules/8/implementations/1/results"
+    >
+      <span
+        class="over-goal-color"
+        style="width: 100%;"
+      >
+        <span
+          class="value"
+        >
+          99.99% at 
+          <time
+            datetime="1626652880000"
+          >
+            2021-07-19 00:01
+          </time>
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationResultBar /> render underGoal implementation 1`] = `
+<div>
+  <div
+    class="rule-summary-wrapper"
+  >
+    <a
+      as="div"
+      class="rule-summary pointer"
+      href="/rules/8/implementations/1/results"
+    >
+      <span
+        class="under-goal-color"
+        style="width: 100%;"
+      >
+        <span
+          class="value"
+        >
+          70% at 
+          <time
+            datetime="1626652880000"
+          >
+            2021-07-19 00:01
+          </time>
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;
+
+exports[`<ImplementationResultBar /> render underMinimum implementation 1`] = `
+<div>
+  <div
+    class="rule-summary-wrapper"
+  >
+    <a
+      as="div"
+      class="rule-summary pointer"
+      href="/rules/8/implementations/1/results"
+    >
+      <span
+        class="under-minimum-color"
+        style="width: 100%;"
+      >
+        <span
+          class="value"
+        >
+          40% at 
+          <time
+            datetime="1626652880000"
+          >
+            2021-07-19 00:01
+          </time>
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;