@transitrix/diagrams 1.0.0 → 1.0.1

package/src/products/validate.ts

@@ -1,112 +1,112 @@
-import type { ProductsCatalogueFile, ProductType, ProductStatus } from './types.js';
-import type { ValidationError, ValidationWarning, ValidationResult } from '../validation-types.js';
-
-export type { ValidationError, ValidationWarning, ValidationResult };
-
-const VALID_TYPES = new Set<ProductType>(['digital_product', 'service', 'platform', 'bundle']);
-const VALID_STATUSES = new Set<ProductStatus>(['Draft', 'Active', 'Deprecated']);
-const DATE_RE = /^\d{4}-\d{2}-\d{2}$/;
-
-export function validateProductsCatalogue(input: unknown): ValidationResult {
-  const errors: ValidationError[] = [];
-  const warnings: ValidationWarning[] = [];
-
-  if (!input || typeof input !== 'object') {
-    return { valid: false, errors: [{ code: 'PROD-001', message: 'Input must be an object' }], warnings };
-  }
-
-  const raw = input as Record<string, unknown>;
-
-  // PROD-001: notation header
-  if (!('notation' in raw)) {
-    errors.push({ code: 'PROD-001', message: 'Missing required field: notation' });
-  } else if (raw['notation'] !== 'products') {
-    errors.push({ code: 'PROD-001', message: `notation must be "products", got "${raw['notation']}"` });
-  }
-
-  if (errors.length > 0) return { valid: false, errors, warnings };
-
-  // PROD-002: catalogue header fields
-  const cat = (raw['products_catalogue'] ?? {}) as Record<string, unknown>;
-  if (!raw['products_catalogue'] || typeof raw['products_catalogue'] !== 'object') {
-    errors.push({ code: 'PROD-002', message: 'Missing required field: products_catalogue' });
-    return { valid: false, errors, warnings };
-  }
-  if (!cat['id'] || typeof cat['id'] !== 'string' || !(cat['id'] as string).trim()) {
-    errors.push({ code: 'PROD-002', message: 'products_catalogue.id is required' });
-  }
-  if (!cat['name'] || typeof cat['name'] !== 'string' || !(cat['name'] as string).trim()) {
-    errors.push({ code: 'PROD-002', message: 'products_catalogue.name is required' });
-  }
-  if (!cat['updated_at'] || typeof cat['updated_at'] !== 'string') {
-    errors.push({ code: 'PROD-002', message: 'products_catalogue.updated_at is required' });
-  }
-
-  if (errors.length > 0) return { valid: false, errors, warnings };
-
-  // PROD-007: updated_at format
-  if (!DATE_RE.test(cat['updated_at'] as string)) {
-    errors.push({ code: 'PROD-007', message: `products_catalogue.updated_at must be YYYY-MM-DD, got "${cat['updated_at']}"` });
-  }
-
-  const products = cat['products'];
-  if (!Array.isArray(products)) {
-    errors.push({ code: 'PROD-002', message: 'products_catalogue.products must be an array' });
-    return { valid: false, errors, warnings };
-  }
-
-  // PROD-008: unique product_id
-  const seenIds = new Set<string>();
-
-  for (let i = 0; i < products.length; i++) {
-    const rawProduct = products[i];
-    const idx = `products[${i}]`;
-
-    if (!rawProduct || typeof rawProduct !== 'object') {
-      errors.push({ code: 'PROD-003', message: `${idx} must be an object` });
-      continue;
-    }
-    const p = rawProduct as Record<string, unknown>;
-
-    // PROD-003: required per-product fields
-    if (!p['product_id'] || typeof p['product_id'] !== 'string' || !(p['product_id'] as string).trim()) {
-      errors.push({ code: 'PROD-003', message: `${idx}: product_id is required` });
-    } else {
-      const pid = p['product_id'] as string;
-      if (seenIds.has(pid)) {
-        errors.push({ code: 'PROD-008', message: `Duplicate product_id: "${pid}"` });
-      }
-      seenIds.add(pid);
-    }
-
-    if (!p['name'] || typeof p['name'] !== 'string' || !(p['name'] as string).trim()) {
-      errors.push({ code: 'PROD-003', message: `${idx}: name is required` });
-    }
-    if (!p['type']) {
-      errors.push({ code: 'PROD-003', message: `${idx}: type is required` });
-    }
-    if (!p['status']) {
-      errors.push({ code: 'PROD-003', message: `${idx}: status is required` });
-    }
-
-    // PROD-004: type enum
-    if (p['type'] && !VALID_TYPES.has(p['type'] as ProductType)) {
-      errors.push({ code: 'PROD-004', message: `${idx}: type "${p['type']}" must be one of: digital_product, service, platform, bundle` });
-    }
-
-    // PROD-005: status enum
-    if (p['status'] && !VALID_STATUSES.has(p['status'] as ProductStatus)) {
-      errors.push({ code: 'PROD-005', message: `${idx}: status "${p['status']}" must be one of: Draft, Active, Deprecated` });
-    }
-
-    // PROD-006: maturity range
-    if (p['maturity'] !== undefined) {
-      const m = p['maturity'];
-      if (typeof m !== 'number' || !Number.isInteger(m) || m < 1 || m > 5) {
-        errors.push({ code: 'PROD-006', message: `${idx}: maturity must be an integer 1–5, got "${m}"` });
-      }
-    }
-  }
-
-  return { valid: errors.length === 0, errors, warnings };
-}
+import type { ProductsCatalogueFile, ProductType, ProductStatus } from './types.js';
+import type { ValidationError, ValidationWarning, ValidationResult } from '../validation-types.js';
+
+export type { ValidationError, ValidationWarning, ValidationResult };
+
+const VALID_TYPES = new Set<ProductType>(['digital_product', 'service', 'platform', 'bundle']);
+const VALID_STATUSES = new Set<ProductStatus>(['Draft', 'Active', 'Deprecated']);
+const DATE_RE = /^\d{4}-\d{2}-\d{2}$/;
+
+export function validateProductsCatalogue(input: unknown): ValidationResult {
+  const errors: ValidationError[] = [];
+  const warnings: ValidationWarning[] = [];
+
+  if (!input || typeof input !== 'object') {
+    return { valid: false, errors: [{ code: 'PROD-001', message: 'Input must be an object' }], warnings };
+  }
+
+  const raw = input as Record<string, unknown>;
+
+  // PROD-001: notation header
+  if (!('notation' in raw)) {
+    errors.push({ code: 'PROD-001', message: 'Missing required field: notation' });
+  } else if (raw['notation'] !== 'products') {
+    errors.push({ code: 'PROD-001', message: `notation must be "products", got "${raw['notation']}"` });
+  }
+
+  if (errors.length > 0) return { valid: false, errors, warnings };
+
+  // PROD-002: catalogue header fields
+  const cat = (raw['products_catalogue'] ?? {}) as Record<string, unknown>;
+  if (!raw['products_catalogue'] || typeof raw['products_catalogue'] !== 'object') {
+    errors.push({ code: 'PROD-002', message: 'Missing required field: products_catalogue' });
+    return { valid: false, errors, warnings };
+  }
+  if (!cat['id'] || typeof cat['id'] !== 'string' || !(cat['id'] as string).trim()) {
+    errors.push({ code: 'PROD-002', message: 'products_catalogue.id is required' });
+  }
+  if (!cat['name'] || typeof cat['name'] !== 'string' || !(cat['name'] as string).trim()) {
+    errors.push({ code: 'PROD-002', message: 'products_catalogue.name is required' });
+  }
+  if (!cat['updated_at'] || typeof cat['updated_at'] !== 'string') {
+    errors.push({ code: 'PROD-002', message: 'products_catalogue.updated_at is required' });
+  }
+
+  if (errors.length > 0) return { valid: false, errors, warnings };
+
+  // PROD-007: updated_at format
+  if (!DATE_RE.test(cat['updated_at'] as string)) {
+    errors.push({ code: 'PROD-007', message: `products_catalogue.updated_at must be YYYY-MM-DD, got "${cat['updated_at']}"` });
+  }
+
+  const products = cat['products'];
+  if (!Array.isArray(products)) {
+    errors.push({ code: 'PROD-002', message: 'products_catalogue.products must be an array' });
+    return { valid: false, errors, warnings };
+  }
+
+  // PROD-008: unique product_id
+  const seenIds = new Set<string>();
+
+  for (let i = 0; i < products.length; i++) {
+    const rawProduct = products[i];
+    const idx = `products[${i}]`;
+
+    if (!rawProduct || typeof rawProduct !== 'object') {
+      errors.push({ code: 'PROD-003', message: `${idx} must be an object` });
+      continue;
+    }
+    const p = rawProduct as Record<string, unknown>;
+
+    // PROD-003: required per-product fields
+    if (!p['product_id'] || typeof p['product_id'] !== 'string' || !(p['product_id'] as string).trim()) {
+      errors.push({ code: 'PROD-003', message: `${idx}: product_id is required` });
+    } else {
+      const pid = p['product_id'] as string;
+      if (seenIds.has(pid)) {
+        errors.push({ code: 'PROD-008', message: `Duplicate product_id: "${pid}"` });
+      }
+      seenIds.add(pid);
+    }
+
+    if (!p['name'] || typeof p['name'] !== 'string' || !(p['name'] as string).trim()) {
+      errors.push({ code: 'PROD-003', message: `${idx}: name is required` });
+    }
+    if (!p['type']) {
+      errors.push({ code: 'PROD-003', message: `${idx}: type is required` });
+    }
+    if (!p['status']) {
+      errors.push({ code: 'PROD-003', message: `${idx}: status is required` });
+    }
+
+    // PROD-004: type enum
+    if (p['type'] && !VALID_TYPES.has(p['type'] as ProductType)) {
+      errors.push({ code: 'PROD-004', message: `${idx}: type "${p['type']}" must be one of: digital_product, service, platform, bundle` });
+    }
+
+    // PROD-005: status enum
+    if (p['status'] && !VALID_STATUSES.has(p['status'] as ProductStatus)) {
+      errors.push({ code: 'PROD-005', message: `${idx}: status "${p['status']}" must be one of: Draft, Active, Deprecated` });
+    }
+
+    // PROD-006: maturity range
+    if (p['maturity'] !== undefined) {
+      const m = p['maturity'];
+      if (typeof m !== 'number' || !Number.isInteger(m) || m < 1 || m > 5) {
+        errors.push({ code: 'PROD-006', message: `${idx}: maturity must be an integer 1–5, got "${m}"` });
+      }
+    }
+  }
+
+  return { valid: errors.length === 0, errors, warnings };
+}

package/src/repo-validate/__tests__/validate-repo.test.ts

@@ -1,149 +1,149 @@
-import { describe, it, expect } from 'vitest';
-import { validateRepoModel } from '../validate-repo.js';
-import type { RepoDoc, RepoModelInput } from '../types.js';
-
-function el(path: string, data: Record<string, unknown> | null, parseError?: string): RepoDoc {
-  return { path, data, parseError };
-}
-
-/** A small clean model mirroring the acme_corp shape: relations use `from`/`to`
- *  and every endpoint resolves to an element. Should produce zero findings —
- *  the parity bar against lint.py on the worked example. */
-function cleanModel(): RepoModelInput {
-  return {
-    elements: [
-      el('canon/elements/01_motivation/goals/GOAL-OPS-1.yaml', { notation: 'goal', id: 'GOAL-OPS-1' }),
-      el('canon/elements/01_motivation/assessments/ASSESSMENT-1.yaml', { notation: 'assessment', id: 'ASSESSMENT-1' }),
-      el('canon/elements/02_business/capabilities/CAPABILITY-V1.yaml', { notation: 'capability', id: 'CAPABILITY-V1' }),
-      // sidecar with no `id` — must be ignored (no duplicate, not an element)
-      el('canon/elements/02_business/capabilities/CAPABILITY-V1.history.yaml', { target: 'CAPABILITY-V1', attribute_versions: [] }),
-    ],
-    relations: [
-      el('canon/relations/REL-1.yaml', { notation: 'relation', id: 'REL-1', from: 'ASSESSMENT-1', to: 'GOAL-OPS-1' }),
-    ],
-  };
-}
-
-describe('validateRepoModel — parity / clean tree', () => {
-  it('produces zero findings on a clean model (acme_corp parity)', () => {
-    expect(validateRepoModel(cleanModel())).toEqual([]);
-  });
-
-  it('ignores sidecar docs without an id (no false duplicate)', () => {
-    const findings = validateRepoModel(cleanModel());
-    expect(findings.filter((f) => f.message.includes('Duplicate'))).toEqual([]);
-  });
-
-  it('every finding carries the frozen { scope, id, message } shape', () => {
-    const model = cleanModel();
-    model.relations.push(el('canon/relations/REL-BAD.yaml', { notation: 'relation', id: 'REL-BAD', from: 'NOPE', to: 'GOAL-OPS-1' }));
-    const findings = validateRepoModel(model);
-    expect(findings.length).toBeGreaterThan(0);
-    for (const f of findings) {
-      expect(Object.keys(f).sort()).toEqual(['id', 'message', 'scope']);
-      expect(f.scope).toBe('repo');
-    }
-  });
-});
-
-describe('validateRepoModel — referential integrity', () => {
-  it('flags a relation whose `from` endpoint is unknown', () => {
-    const model = cleanModel();
-    model.relations = [el('canon/relations/REL-X.yaml', { notation: 'relation', id: 'REL-X', from: 'MISSING-1', to: 'GOAL-OPS-1' })];
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'REL-X' });
-    expect(findings[0].message).toContain('MISSING-1');
-    expect(findings[0].message).toContain('(from)');
-  });
-
-  it('flags a relation whose `to` endpoint is unknown', () => {
-    const model = cleanModel();
-    model.relations = [el('canon/relations/REL-Y.yaml', { notation: 'relation', id: 'REL-Y', from: 'GOAL-OPS-1', to: 'MISSING-2' })];
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0].message).toContain('(to)');
-  });
-
-  it('accepts lint.py-style `source`/`target` endpoint keys', () => {
-    const model = cleanModel();
-    model.relations = [el('canon/relations/REL-ST.yaml', { id: 'REL-ST', source: 'ASSESSMENT-1', target: 'GOAL-OPS-1' })];
-    expect(validateRepoModel(model)).toEqual([]);
-  });
-
-  it('resolves `{ id }` object endpoints', () => {
-    const model = cleanModel();
-    model.relations = [el('canon/relations/REL-OBJ.yaml', { id: 'REL-OBJ', from: { id: 'ASSESSMENT-1' }, to: { id: 'GOAL-OPS-1' } })];
-    expect(validateRepoModel(model)).toEqual([]);
-  });
-});
-
-describe('validateRepoModel — atomicity', () => {
-  it('flags an element file that contains an inline `relations` section', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/02_business/E.yaml', { id: 'ELEMENT-1', relations: [{ to: 'GOAL-OPS-1' }] }));
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'ELEMENT-1' });
-    expect(findings[0].message).toContain('Atomicity');
-  });
-});
-
-describe('validateRepoModel — id uniqueness', () => {
-  it('flags the same id defined in two files', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/dupe-a.yaml', { id: 'DUP-1' }));
-    model.elements.push(el('canon/elements/dupe-b.yaml', { id: 'DUP-1' }));
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'DUP-1' });
-    expect(findings[0].message).toContain('dupe-a.yaml');
-    expect(findings[0].message).toContain('dupe-b.yaml');
-  });
-
-  it('flags an element/relation id collision across zones', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/clash.yaml', { id: 'CLASH-1' }));
-    model.relations.push(el('canon/relations/clash.yaml', { id: 'CLASH-1', from: 'GOAL-OPS-1', to: 'ASSESSMENT-1' }));
-    const findings = validateRepoModel(model);
-    expect(findings.filter((f) => f.id === 'CLASH-1')).toHaveLength(1);
-  });
-});
-
-describe('validateRepoModel — policy', () => {
-  it('flags an Active element with no owner', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/svc.yaml', { id: 'SVC-1', metadata: { status: 'Active' } }));
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'SVC-1' });
-    expect(findings[0].message).toContain('Policy');
-  });
-
-  it('does not flag an Active element that has an owner', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/svc.yaml', { id: 'SVC-2', metadata: { status: 'Active', owner: 'team-a' } }));
-    expect(validateRepoModel(model)).toEqual([]);
-  });
-
-  it('does not flag elements using the canon admission record (no metadata.status)', () => {
-    // acme_corp elements use `zone`/`admitted_by`, not `metadata.status` — must not fire.
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/g.yaml', { id: 'GOAL-X', zone: 'canon', admitted_by: 'v.korobeinikov' }));
-    expect(validateRepoModel(model)).toEqual([]);
-  });
-});
-
-describe('validateRepoModel — syntax', () => {
-  it('reports a parse error and skips graph checks', () => {
-    const model = cleanModel();
-    model.elements.push(el('canon/elements/broken.yaml', null, 'bad indentation'));
-    // also add a dangling relation that would otherwise fire — it must be suppressed
-    model.relations.push(el('canon/relations/REL-Z.yaml', { id: 'REL-Z', from: 'MISSING', to: 'GOAL-OPS-1' }));
-    const findings = validateRepoModel(model);
-    expect(findings).toHaveLength(1);
-    expect(findings[0]).toMatchObject({ scope: 'repo', id: '' });
-    expect(findings[0].message).toContain('YAML syntax error');
-    expect(findings[0].message).toContain('broken.yaml');
-  });
-});
+import { describe, it, expect } from 'vitest';
+import { validateRepoModel } from '../validate-repo.js';
+import type { RepoDoc, RepoModelInput } from '../types.js';
+
+function el(path: string, data: Record<string, unknown> | null, parseError?: string): RepoDoc {
+  return { path, data, parseError };
+}
+
+/** A small clean model mirroring the acme_corp shape: relations use `from`/`to`
+ *  and every endpoint resolves to an element. Should produce zero findings —
+ *  the parity bar against lint.py on the worked example. */
+function cleanModel(): RepoModelInput {
+  return {
+    elements: [
+      el('canon/elements/01_motivation/goals/GOAL-OPS-1.yaml', { notation: 'goal', id: 'GOAL-OPS-1' }),
+      el('canon/elements/01_motivation/assessments/ASSESSMENT-1.yaml', { notation: 'assessment', id: 'ASSESSMENT-1' }),
+      el('canon/elements/02_business/capabilities/CAPABILITY-V1.yaml', { notation: 'capability', id: 'CAPABILITY-V1' }),
+      // sidecar with no `id` — must be ignored (no duplicate, not an element)
+      el('canon/elements/02_business/capabilities/CAPABILITY-V1.history.yaml', { target: 'CAPABILITY-V1', attribute_versions: [] }),
+    ],
+    relations: [
+      el('canon/relations/REL-1.yaml', { notation: 'relation', id: 'REL-1', from: 'ASSESSMENT-1', to: 'GOAL-OPS-1' }),
+    ],
+  };
+}
+
+describe('validateRepoModel — parity / clean tree', () => {
+  it('produces zero findings on a clean model (acme_corp parity)', () => {
+    expect(validateRepoModel(cleanModel())).toEqual([]);
+  });
+
+  it('ignores sidecar docs without an id (no false duplicate)', () => {
+    const findings = validateRepoModel(cleanModel());
+    expect(findings.filter((f) => f.message.includes('Duplicate'))).toEqual([]);
+  });
+
+  it('every finding carries the frozen { scope, id, message } shape', () => {
+    const model = cleanModel();
+    model.relations.push(el('canon/relations/REL-BAD.yaml', { notation: 'relation', id: 'REL-BAD', from: 'NOPE', to: 'GOAL-OPS-1' }));
+    const findings = validateRepoModel(model);
+    expect(findings.length).toBeGreaterThan(0);
+    for (const f of findings) {
+      expect(Object.keys(f).sort()).toEqual(['id', 'message', 'scope']);
+      expect(f.scope).toBe('repo');
+    }
+  });
+});
+
+describe('validateRepoModel — referential integrity', () => {
+  it('flags a relation whose `from` endpoint is unknown', () => {
+    const model = cleanModel();
+    model.relations = [el('canon/relations/REL-X.yaml', { notation: 'relation', id: 'REL-X', from: 'MISSING-1', to: 'GOAL-OPS-1' })];
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'REL-X' });
+    expect(findings[0].message).toContain('MISSING-1');
+    expect(findings[0].message).toContain('(from)');
+  });
+
+  it('flags a relation whose `to` endpoint is unknown', () => {
+    const model = cleanModel();
+    model.relations = [el('canon/relations/REL-Y.yaml', { notation: 'relation', id: 'REL-Y', from: 'GOAL-OPS-1', to: 'MISSING-2' })];
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0].message).toContain('(to)');
+  });
+
+  it('accepts lint.py-style `source`/`target` endpoint keys', () => {
+    const model = cleanModel();
+    model.relations = [el('canon/relations/REL-ST.yaml', { id: 'REL-ST', source: 'ASSESSMENT-1', target: 'GOAL-OPS-1' })];
+    expect(validateRepoModel(model)).toEqual([]);
+  });
+
+  it('resolves `{ id }` object endpoints', () => {
+    const model = cleanModel();
+    model.relations = [el('canon/relations/REL-OBJ.yaml', { id: 'REL-OBJ', from: { id: 'ASSESSMENT-1' }, to: { id: 'GOAL-OPS-1' } })];
+    expect(validateRepoModel(model)).toEqual([]);
+  });
+});
+
+describe('validateRepoModel — atomicity', () => {
+  it('flags an element file that contains an inline `relations` section', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/02_business/E.yaml', { id: 'ELEMENT-1', relations: [{ to: 'GOAL-OPS-1' }] }));
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'ELEMENT-1' });
+    expect(findings[0].message).toContain('Atomicity');
+  });
+});
+
+describe('validateRepoModel — id uniqueness', () => {
+  it('flags the same id defined in two files', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/dupe-a.yaml', { id: 'DUP-1' }));
+    model.elements.push(el('canon/elements/dupe-b.yaml', { id: 'DUP-1' }));
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'DUP-1' });
+    expect(findings[0].message).toContain('dupe-a.yaml');
+    expect(findings[0].message).toContain('dupe-b.yaml');
+  });
+
+  it('flags an element/relation id collision across zones', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/clash.yaml', { id: 'CLASH-1' }));
+    model.relations.push(el('canon/relations/clash.yaml', { id: 'CLASH-1', from: 'GOAL-OPS-1', to: 'ASSESSMENT-1' }));
+    const findings = validateRepoModel(model);
+    expect(findings.filter((f) => f.id === 'CLASH-1')).toHaveLength(1);
+  });
+});
+
+describe('validateRepoModel — policy', () => {
+  it('flags an Active element with no owner', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/svc.yaml', { id: 'SVC-1', metadata: { status: 'Active' } }));
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0]).toMatchObject({ scope: 'repo', id: 'SVC-1' });
+    expect(findings[0].message).toContain('Policy');
+  });
+
+  it('does not flag an Active element that has an owner', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/svc.yaml', { id: 'SVC-2', metadata: { status: 'Active', owner: 'team-a' } }));
+    expect(validateRepoModel(model)).toEqual([]);
+  });
+
+  it('does not flag elements using the canon admission record (no metadata.status)', () => {
+    // acme_corp elements use `zone`/`admitted_by`, not `metadata.status` — must not fire.
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/g.yaml', { id: 'GOAL-X', zone: 'canon', admitted_by: 'v.korobeinikov' }));
+    expect(validateRepoModel(model)).toEqual([]);
+  });
+});
+
+describe('validateRepoModel — syntax', () => {
+  it('reports a parse error and skips graph checks', () => {
+    const model = cleanModel();
+    model.elements.push(el('canon/elements/broken.yaml', null, 'bad indentation'));
+    // also add a dangling relation that would otherwise fire — it must be suppressed
+    model.relations.push(el('canon/relations/REL-Z.yaml', { id: 'REL-Z', from: 'MISSING', to: 'GOAL-OPS-1' }));
+    const findings = validateRepoModel(model);
+    expect(findings).toHaveLength(1);
+    expect(findings[0]).toMatchObject({ scope: 'repo', id: '' });
+    expect(findings[0].message).toContain('YAML syntax error');
+    expect(findings[0].message).toContain('broken.yaml');
+  });
+});

package/src/repo-validate/index.ts

@@ -1,2 +1,2 @@
-export { validateRepoModel } from './validate-repo.js';
-export type { RepoDoc, RepoFinding, RepoModelInput } from './types.js';
+export { validateRepoModel } from './validate-repo.js';
+export type { RepoDoc, RepoFinding, RepoModelInput } from './types.js';

package/src/repo-validate/types.ts

@@ -1,50 +1,50 @@
-// Repo-scope validation types (vkgeorgia/transitrix-studio#141).
-//
-// `validate --scope=repo` runs whole-model checks over a loaded `canon/` tree —
-// referential integrity, atomicity, ID uniqueness, policy — the checks that the
-// methodology's Python `.validators/lint.py` owns today. This converges those
-// checks onto the shared TypeScript model so there is a single validation
-// runtime (methodology ADR
-// `2026-06-11-validation-two-axis-model.md`; Studio referencing ADR
-// `docs/decisions/2026-06-11-validation-runtime-convergence.md`).
-//
-// The finding shape is deliberately minimal — `{ scope, id, message }`. The
-// richer `target` / `category` reporting taxonomy is explicitly DEFERRED per the
-// ADR until a real consumer needs it; do not add it here.
-
-/** A single repo-scope validation finding. Shape is frozen at `{ scope, id, message }`. */
-export interface RepoFinding {
-  /** Always `'repo'` — the execution axis this finding came from. */
-  scope: 'repo';
-  /**
-   * The offending element/relation id, or `''` when the finding is not tied to
-   * a single id (e.g. a YAML syntax error in a file with no parseable id).
-   */
-  id: string;
-  /** Human-readable description of the violation. */
-  message: string;
-}
-
-/** A parsed canon document fed to the repo validator. IO (the filesystem walk)
- *  lives in the CLI; the validator itself stays pure and testable. */
-export interface RepoDoc {
-  /** Source file path, relative to the scanned root — used in messages. */
-  path: string;
-  /**
-   * The parsed top-level YAML mapping, or `null` when the file failed to parse.
-   * A `null` data with a non-empty `parseError` produces a syntax finding.
-   */
-  data: Record<string, unknown> | null;
-  /** Set when the YAML failed to parse; surfaced as a syntax finding. */
-  parseError?: string;
-}
-
-/** The loaded repository model: element docs and relation docs, partitioned by
- *  canon zone exactly as `lint.py` partitions them (`canon/elements/**` vs
- *  `canon/relations/**`). */
-export interface RepoModelInput {
-  /** Documents found under `canon/elements/**`. */
-  elements: RepoDoc[];
-  /** Documents found under `canon/relations/**`. */
-  relations: RepoDoc[];
-}
+// Repo-scope validation types (vkgeorgia/transitrix-studio#141).
+//
+// `validate --scope=repo` runs whole-model checks over a loaded `canon/` tree —
+// referential integrity, atomicity, ID uniqueness, policy — the checks that the
+// methodology's Python `.validators/lint.py` owns today. This converges those
+// checks onto the shared TypeScript model so there is a single validation
+// runtime (methodology ADR
+// `2026-06-11-validation-two-axis-model.md`; Studio referencing ADR
+// `docs/decisions/2026-06-11-validation-runtime-convergence.md`).
+//
+// The finding shape is deliberately minimal — `{ scope, id, message }`. The
+// richer `target` / `category` reporting taxonomy is explicitly DEFERRED per the
+// ADR until a real consumer needs it; do not add it here.
+
+/** A single repo-scope validation finding. Shape is frozen at `{ scope, id, message }`. */
+export interface RepoFinding {
+  /** Always `'repo'` — the execution axis this finding came from. */
+  scope: 'repo';
+  /**
+   * The offending element/relation id, or `''` when the finding is not tied to
+   * a single id (e.g. a YAML syntax error in a file with no parseable id).
+   */
+  id: string;
+  /** Human-readable description of the violation. */
+  message: string;
+}
+
+/** A parsed canon document fed to the repo validator. IO (the filesystem walk)
+ *  lives in the CLI; the validator itself stays pure and testable. */
+export interface RepoDoc {
+  /** Source file path, relative to the scanned root — used in messages. */
+  path: string;
+  /**
+   * The parsed top-level YAML mapping, or `null` when the file failed to parse.
+   * A `null` data with a non-empty `parseError` produces a syntax finding.
+   */
+  data: Record<string, unknown> | null;
+  /** Set when the YAML failed to parse; surfaced as a syntax finding. */
+  parseError?: string;
+}
+
+/** The loaded repository model: element docs and relation docs, partitioned by
+ *  canon zone exactly as `lint.py` partitions them (`canon/elements/**` vs
+ *  `canon/relations/**`). */
+export interface RepoModelInput {
+  /** Documents found under `canon/elements/**`. */
+  elements: RepoDoc[];
+  /** Documents found under `canon/relations/**`. */
+  relations: RepoDoc[];
+}