@transitrix/diagrams 1.0.0 → 1.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +21 -21
- package/README.md +47 -47
- package/dist/__tests__/edge-path.test.js +8 -0
- package/dist/activity-card/__tests__/example.test.js +20 -1
- package/dist/activity-card/__tests__/layout.test.js +102 -11
- package/dist/activity-card/__tests__/resolver.test.js +139 -6
- package/dist/activity-card/index.d.ts +1 -1
- package/dist/activity-card/layout.d.ts +1 -1
- package/dist/activity-card/layout.js +220 -103
- package/dist/activity-card/resolver.js +107 -26
- package/dist/activity-card/types.d.ts +150 -27
- package/dist/activity-card/validate.js +3 -0
- package/dist/actor/__tests__/validate.test.js +63 -31
- package/dist/actor/index.d.ts +1 -1
- package/dist/actor/index.js +1 -1
- package/dist/actor/types.d.ts +7 -3
- package/dist/actor/types.js +17 -3
- package/dist/actor/validate.js +55 -26
- package/dist/assertion/types.d.ts +3 -1
- package/dist/assertion/types.js +1 -1
- package/dist/change/__tests__/validate.test.js +40 -34
- package/dist/change/index.d.ts +1 -0
- package/dist/change/types.d.ts +1 -1
- package/dist/change/types.js +2 -2
- package/dist/change/validate.d.ts +6 -1
- package/dist/change/validate.js +68 -41
- package/dist/compliance/__tests__/classify.test.js +34 -0
- package/dist/compliance/__tests__/coverage-metric.test.js +146 -46
- package/dist/compliance/__tests__/html.test.js +2 -2
- package/dist/compliance/__tests__/impact.test.js +311 -6
- package/dist/compliance/classify.d.ts +6 -0
- package/dist/compliance/classify.js +9 -1
- package/dist/compliance/coverage-metric.d.ts +31 -11
- package/dist/compliance/coverage-metric.js +149 -39
- package/dist/compliance/html.js +77 -74
- package/dist/compliance/impact.d.ts +77 -16
- package/dist/compliance/impact.js +193 -25
- package/dist/compliance/index.d.ts +2 -2
- package/dist/compliance/index.js +1 -1
- package/dist/compliance/markdown.js +1 -0
- package/dist/compliance/types.d.ts +25 -6
- package/dist/edge-path.d.ts +8 -4
- package/dist/edge-path.js +11 -6
- package/dist/factor/__tests__/validate.test.js +74 -45
- package/dist/factor/index.d.ts +3 -2
- package/dist/factor/index.js +1 -1
- package/dist/factor/types.d.ts +4 -7
- package/dist/factor/types.js +10 -5
- package/dist/factor/validate.d.ts +6 -1
- package/dist/factor/validate.js +68 -50
- package/dist/fgca/__tests__/resolver.test.js +185 -0
- package/dist/fgca/index.d.ts +2 -0
- package/dist/fgca/index.js +1 -0
- package/dist/fgca/resolver.d.ts +49 -0
- package/dist/fgca/resolver.js +124 -0
- package/dist/goals/index.d.ts +1 -1
- package/dist/index.d.ts +5 -0
- package/dist/index.js +5 -0
- package/dist/process-blueprint/__tests__/layout.test.js +37 -0
- package/dist/process-blueprint/layout.js +5 -1
- package/dist/process-blueprint/types.d.ts +22 -1
- package/dist/stakeholder/__tests__/validate.test.js +49 -47
- package/dist/stakeholder/index.d.ts +1 -0
- package/dist/stakeholder/types.d.ts +3 -4
- package/dist/stakeholder/types.js +2 -3
- package/dist/stakeholder/validate.d.ts +6 -1
- package/dist/stakeholder/validate.js +71 -50
- package/dist/target-state/__tests__/validate.test.js +43 -27
- package/dist/target-state/index.d.ts +2 -0
- package/dist/target-state/index.js +1 -0
- package/dist/target-state/types.d.ts +6 -1
- package/dist/target-state/types.js +8 -7
- package/dist/target-state/validate.d.ts +6 -1
- package/dist/target-state/validate.js +69 -45
- package/dist/theme/themes.js +69 -69
- package/dist/webview/__tests__/entry.test.js +11 -11
- package/dist/webview/render-activities.d.ts +3 -1
- package/dist/webview/render-activities.js +2 -2
- package/dist/webview/render-activity-card.js +104 -77
- package/dist/webview/render-fgca.d.ts +4 -0
- package/dist/webview/render-fgca.js +2 -5
- package/dist/webview/render-goals.d.ts +1 -0
- package/dist/webview/render-goals.js +15 -15
- package/dist/webview/render-process-blueprint.js +10 -10
- package/package.json +40 -40
- package/src/__tests__/edge-path.test.ts +58 -46
- package/src/__tests__/scope.test.ts +27 -27
- package/src/__tests__/yaml-normalize.test.ts +158 -158
- package/src/activities/__tests__/cpm.test.ts +164 -164
- package/src/activities/__tests__/gantt.test.ts +245 -245
- package/src/activities/__tests__/layout.test.ts +112 -112
- package/src/activities/__tests__/validate.test.ts +409 -409
- package/src/activities/cpm.ts +95 -95
- package/src/activities/gantt.ts +276 -276
- package/src/activities/index.ts +28 -28
- package/src/activities/layout.ts +112 -112
- package/src/activities/types.ts +148 -148
- package/src/activities/validate.ts +357 -357
- package/src/activity-card/__tests__/example.test.ts +85 -66
- package/src/activity-card/__tests__/layout.test.ts +169 -63
- package/src/activity-card/__tests__/resolver.test.ts +307 -161
- package/src/activity-card/__tests__/validate.test.ts +131 -131
- package/src/activity-card/index.ts +38 -32
- package/src/activity-card/layout.ts +324 -194
- package/src/activity-card/resolver.ts +415 -337
- package/src/activity-card/types.ts +376 -237
- package/src/activity-card/validate.ts +162 -158
- package/src/actor/__tests__/validate.test.ts +70 -31
- package/src/actor/index.ts +1 -1
- package/src/actor/types.ts +21 -7
- package/src/actor/validate.ts +59 -27
- package/src/applications/__tests__/validate.test.ts +256 -256
- package/src/applications/index.ts +11 -11
- package/src/applications/types.ts +43 -43
- package/src/applications/validate.ts +131 -131
- package/src/assertion/__tests__/example.test.ts +37 -37
- package/src/assertion/__tests__/validate.test.ts +142 -142
- package/src/assertion/index.ts +12 -12
- package/src/assertion/types.ts +60 -58
- package/src/assertion/validate.ts +145 -145
- package/src/blocks/__tests__/layout.test.ts +169 -169
- package/src/blocks/__tests__/validate.test.ts +260 -260
- package/src/blocks/index.ts +17 -17
- package/src/blocks/layout.ts +186 -186
- package/src/blocks/types.ts +62 -62
- package/src/blocks/validate.ts +206 -206
- package/src/capability-map/__tests__/validate.test.ts +238 -238
- package/src/capability-map/index.ts +8 -8
- package/src/capability-map/types.ts +29 -29
- package/src/capability-map/validate.ts +127 -127
- package/src/change/__tests__/validate.test.ts +43 -34
- package/src/change/index.ts +1 -0
- package/src/change/types.ts +5 -3
- package/src/change/validate.ts +75 -43
- package/src/compliance/__tests__/classify.test.ts +64 -27
- package/src/compliance/__tests__/confidence.test.ts +98 -98
- package/src/compliance/__tests__/coverage-metric.test.ts +300 -188
- package/src/compliance/__tests__/demo-scenario.test.ts +273 -273
- package/src/compliance/__tests__/example.test.ts +57 -57
- package/src/compliance/__tests__/gap-report.test.ts +128 -128
- package/src/compliance/__tests__/html.test.ts +141 -141
- package/src/compliance/__tests__/impact.test.ts +840 -481
- package/src/compliance/__tests__/markdown.test.ts +94 -94
- package/src/compliance/__tests__/views.test.ts +64 -64
- package/src/compliance/classify.ts +100 -84
- package/src/compliance/confidence.ts +69 -69
- package/src/compliance/coverage-metric.ts +404 -263
- package/src/compliance/gap-report.ts +94 -94
- package/src/compliance/html.ts +298 -295
- package/src/compliance/impact.ts +861 -677
- package/src/compliance/index.ts +57 -56
- package/src/compliance/markdown.ts +136 -135
- package/src/compliance/reverse-index.ts +33 -33
- package/src/compliance/types.ts +136 -120
- package/src/compliance/views.ts +46 -46
- package/src/compliance-matrix/__tests__/build.test.ts +200 -200
- package/src/compliance-matrix/__tests__/example.test.ts +57 -57
- package/src/compliance-matrix/index.ts +11 -11
- package/src/compliance-matrix/types.ts +102 -102
- package/src/edge-path.ts +50 -44
- package/src/factor/__tests__/validate.test.ts +80 -45
- package/src/factor/index.ts +3 -7
- package/src/factor/types.ts +14 -18
- package/src/factor/validate.ts +77 -51
- package/src/fgca/__tests__/chain-table.test.ts +172 -172
- package/src/fgca/__tests__/layout.test.ts +179 -179
- package/src/fgca/__tests__/parse-canonical.test.ts +248 -248
- package/src/fgca/__tests__/preview-layout.test.ts +124 -124
- package/src/fgca/__tests__/resolver.test.ts +209 -0
- package/src/fgca/__tests__/validate.test.ts +142 -142
- package/src/fgca/chain-table.ts +225 -225
- package/src/fgca/index.ts +47 -45
- package/src/fgca/layout.ts +204 -204
- package/src/fgca/nodeTypes.ts +11 -11
- package/src/fgca/nodes/FGCAActivityNode.tsx +65 -65
- package/src/fgca/nodes/FGCAChangeNode.tsx +64 -64
- package/src/fgca/nodes/FGCAFactorNode.tsx +64 -64
- package/src/fgca/nodes/FGCAGoalNode.tsx +72 -72
- package/src/fgca/parse-canonical.ts +400 -400
- package/src/fgca/preview-layout.ts +217 -217
- package/src/fgca/resolver.ts +157 -0
- package/src/fgca/types.ts +50 -50
- package/src/fgca/validate.ts +126 -126
- package/src/geometry.ts +9 -9
- package/src/goals/__tests__/layout.test.ts +175 -175
- package/src/goals/__tests__/mutations.test.ts +111 -111
- package/src/goals/__tests__/parse-canonical.test.ts +145 -145
- package/src/goals/__tests__/validate.test.ts +202 -202
- package/src/goals/index.ts +20 -21
- package/src/goals/layout.ts +172 -172
- package/src/goals/mutations.ts +123 -123
- package/src/goals/parse-canonical.ts +286 -286
- package/src/goals/types.ts +85 -85
- package/src/goals/validate.ts +136 -136
- package/src/index.ts +28 -23
- package/src/process-blueprint/__tests__/compliance-lane.test.ts +320 -320
- package/src/process-blueprint/__tests__/layout.test.ts +240 -195
- package/src/process-blueprint/__tests__/validate.test.ts +310 -310
- package/src/process-blueprint/index.ts +31 -31
- package/src/process-blueprint/layout.ts +535 -531
- package/src/process-blueprint/types.ts +263 -242
- package/src/process-blueprint/validate.ts +181 -181
- package/src/process-map/__tests__/validate.test.ts +223 -223
- package/src/process-map/index.ts +10 -10
- package/src/process-map/types.ts +36 -36
- package/src/process-map/validate.ts +135 -135
- package/src/products/__tests__/validate.test.ts +239 -239
- package/src/products/index.ts +9 -9
- package/src/products/types.ts +31 -31
- package/src/products/validate.ts +112 -112
- package/src/repo-validate/__tests__/validate-repo.test.ts +149 -149
- package/src/repo-validate/index.ts +2 -2
- package/src/repo-validate/types.ts +50 -50
- package/src/repo-validate/validate-repo.ts +196 -196
- package/src/requirement/__tests__/example.test.ts +24 -24
- package/src/requirement/__tests__/validate.test.ts +96 -96
- package/src/requirement/index.ts +4 -4
- package/src/requirement/types.ts +35 -35
- package/src/requirement/validate.ts +92 -92
- package/src/scenarios/__tests__/validate.test.ts +209 -209
- package/src/scenarios/index.ts +15 -15
- package/src/scenarios/types.ts +37 -37
- package/src/scenarios/validate.ts +122 -122
- package/src/schema-version.ts +16 -16
- package/src/scope.ts +46 -46
- package/src/stakeholder/__tests__/validate.test.ts +51 -47
- package/src/stakeholder/index.ts +1 -0
- package/src/stakeholder/types.ts +7 -7
- package/src/stakeholder/validate.ts +79 -52
- package/src/target-state/__tests__/validate.test.ts +48 -27
- package/src/target-state/index.ts +2 -0
- package/src/target-state/types.ts +11 -7
- package/src/target-state/validate.ts +76 -46
- package/src/theme/index.ts +4 -4
- package/src/theme/themes.ts +237 -237
- package/src/theme/tokens.ts +133 -133
- package/src/typed-id.ts +56 -56
- package/src/validation-types.ts +36 -36
- package/src/webview/__tests__/entry-notations.test.ts +77 -77
- package/src/webview/__tests__/entry.test.ts +64 -64
- package/src/webview/__tests__/render-goals.test.ts +72 -72
- package/src/webview/entry.ts +292 -292
- package/src/webview/render-activities.ts +5 -3
- package/src/webview/render-activity-card.ts +266 -234
- package/src/webview/render-fgca.ts +6 -5
- package/src/webview/render-goals.ts +111 -110
- package/src/webview/render-process-blueprint.ts +207 -207
- package/src/webview/styles.css +322 -323
- package/src/yaml-normalize.ts +56 -56
- package/dist/element-envelope.d.ts +0 -15
- package/dist/element-envelope.js +0 -55
- package/dist/issues/__tests__/layout.test.js +0 -62
- package/dist/issues/__tests__/validate.test.d.ts +0 -1
- package/dist/issues/__tests__/validate.test.js +0 -82
- package/dist/issues/index.d.ts +0 -4
- package/dist/issues/index.js +0 -2
- package/dist/issues/layout.d.ts +0 -10
- package/dist/issues/layout.js +0 -82
- package/dist/issues/types.d.ts +0 -61
- package/dist/issues/types.js +0 -6
- package/dist/issues/validate.d.ts +0 -3
- package/dist/issues/validate.js +0 -143
- package/dist/webview/transitrix-render.css +0 -323
- package/dist/webview/transitrix-render.js +0 -6452
- package/dist/webview/transitrix-render.js.map +0 -7
- package/src/element-envelope.ts +0 -76
- /package/dist/{issues/__tests__/layout.test.d.ts → fgca/__tests__/resolver.test.d.ts} +0 -0
|
@@ -1,175 +1,175 @@
|
|
|
1
|
-
import { describe, it, expect } from 'vitest';
|
|
2
|
-
import { layoutGoalTree } from '../layout.js';
|
|
3
|
-
import type { GoalTree } from '../types.js';
|
|
4
|
-
|
|
5
|
-
const TREE: GoalTree = {
|
|
6
|
-
goal_types: [
|
|
7
|
-
{ name: 'Strategy', level: 0 },
|
|
8
|
-
{ name: 'Business Goal', level: 1 },
|
|
9
|
-
{ name: 'Project', level: 2 },
|
|
10
|
-
],
|
|
11
|
-
goals: [
|
|
12
|
-
{ id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
|
|
13
|
-
{ id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
|
|
14
|
-
{ id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
|
|
15
|
-
{ id: 4, name: 'London Office', type: 'Project', level: 2, parent_id: 2 },
|
|
16
|
-
],
|
|
17
|
-
};
|
|
18
|
-
|
|
19
|
-
describe('layoutGoalTree', () => {
|
|
20
|
-
it('returns nodes for all goals', () => {
|
|
21
|
-
const layout = layoutGoalTree(TREE);
|
|
22
|
-
expect(layout.nodes).toHaveLength(4);
|
|
23
|
-
});
|
|
24
|
-
|
|
25
|
-
it('returns edges for parent-child pairs', () => {
|
|
26
|
-
const layout = layoutGoalTree(TREE);
|
|
27
|
-
expect(layout.edges).toHaveLength(3); // 1→2, 2→3, 2→4
|
|
28
|
-
});
|
|
29
|
-
|
|
30
|
-
it('levels map to increasing x positions', () => {
|
|
31
|
-
const layout = layoutGoalTree(TREE);
|
|
32
|
-
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
33
|
-
expect(byId.get(1)!.x).toBeLessThan(byId.get(2)!.x);
|
|
34
|
-
expect(byId.get(2)!.x).toBeLessThan(byId.get(3)!.x);
|
|
35
|
-
});
|
|
36
|
-
|
|
37
|
-
it('siblings at same level have different y positions', () => {
|
|
38
|
-
const layout = layoutGoalTree(TREE);
|
|
39
|
-
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
40
|
-
expect(byId.get(3)!.y).not.toBe(byId.get(4)!.y);
|
|
41
|
-
});
|
|
42
|
-
|
|
43
|
-
it('returns non-zero bounds for non-empty tree', () => {
|
|
44
|
-
const layout = layoutGoalTree(TREE);
|
|
45
|
-
expect(layout.bounds.width).toBeGreaterThan(0);
|
|
46
|
-
expect(layout.bounds.height).toBeGreaterThan(0);
|
|
47
|
-
});
|
|
48
|
-
|
|
49
|
-
it('returns empty layout for empty goals', () => {
|
|
50
|
-
const layout = layoutGoalTree({ goal_types: [], goals: [] });
|
|
51
|
-
expect(layout.nodes).toHaveLength(0);
|
|
52
|
-
expect(layout.edges).toHaveLength(0);
|
|
53
|
-
});
|
|
54
|
-
|
|
55
|
-
it('nodes have default 250×80 size', () => {
|
|
56
|
-
const layout = layoutGoalTree(TREE);
|
|
57
|
-
expect(layout.nodes[0].width).toBe(250);
|
|
58
|
-
expect(layout.nodes[0].height).toBe(80);
|
|
59
|
-
});
|
|
60
|
-
|
|
61
|
-
it('respects custom nodeWidth/nodeHeight', () => {
|
|
62
|
-
const layout = layoutGoalTree(TREE, { nodeWidth: 200, nodeHeight: 60 });
|
|
63
|
-
expect(layout.nodes[0].width).toBe(200);
|
|
64
|
-
expect(layout.nodes[0].height).toBe(60);
|
|
65
|
-
});
|
|
66
|
-
|
|
67
|
-
// vkgeorgia/strategy#75 — configurable spacing. The preview maps
|
|
68
|
-
// horizontalGap → rankSep and verticalGap → nodeSep.
|
|
69
|
-
it('larger rankSep widens the column step', () => {
|
|
70
|
-
const tight = layoutGoalTree(TREE, { rankSep: 80 });
|
|
71
|
-
const wide = layoutGoalTree(TREE, { rankSep: 200 });
|
|
72
|
-
const stepOf = (l: ReturnType<typeof layoutGoalTree>) => {
|
|
73
|
-
const byId = new Map(l.nodes.map(n => [n.id, n]));
|
|
74
|
-
return byId.get(2)!.x - byId.get(1)!.x;
|
|
75
|
-
};
|
|
76
|
-
expect(stepOf(wide)).toBeGreaterThan(stepOf(tight));
|
|
77
|
-
});
|
|
78
|
-
|
|
79
|
-
it('larger nodeSep increases the gap between stacked siblings', () => {
|
|
80
|
-
const gapOf = (sep: number) => {
|
|
81
|
-
const l = layoutGoalTree(TREE, { nodeSep: sep });
|
|
82
|
-
const byId = new Map(l.nodes.map(n => [n.id, n]));
|
|
83
|
-
return Math.abs(byId.get(4)!.y - byId.get(3)!.y);
|
|
84
|
-
};
|
|
85
|
-
expect(gapOf(120)).toBeGreaterThan(gapOf(24));
|
|
86
|
-
});
|
|
87
|
-
|
|
88
|
-
it('each node carries original goal data', () => {
|
|
89
|
-
const layout = layoutGoalTree(TREE);
|
|
90
|
-
const node1 = layout.nodes.find(n => n.id === 1)!;
|
|
91
|
-
expect(node1.data.name).toBe('North Star');
|
|
92
|
-
});
|
|
93
|
-
|
|
94
|
-
it('viewDepth hides nodes beyond depth', () => {
|
|
95
|
-
const layout = layoutGoalTree(TREE, { viewDepth: 1 });
|
|
96
|
-
// Level 2 nodes (id 3, 4) should be hidden
|
|
97
|
-
expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
|
|
98
|
-
});
|
|
99
|
-
|
|
100
|
-
it('compresses non-contiguous levels into adjacent columns (no phantom empty columns)', () => {
|
|
101
|
-
// Legacy / non-canonical input: goal_types skip levels 1 and 3, so
|
|
102
|
-
// goals sit at levels 0, 2, 4. Column x must advance by exactly one
|
|
103
|
-
// step per used level, not per absolute level value — otherwise the
|
|
104
|
-
// skipped levels open empty columns and double the horizontal spacing.
|
|
105
|
-
const gapped: GoalTree = {
|
|
106
|
-
goal_types: [
|
|
107
|
-
{ name: 'Strategy', level: 0 },
|
|
108
|
-
{ name: 'Strategic Goal', level: 2 },
|
|
109
|
-
{ name: 'Project Goal', level: 4 },
|
|
110
|
-
],
|
|
111
|
-
goals: [
|
|
112
|
-
{ id: 1, name: 'Root', type: 'Strategy', level: 0, parent_id: 0 },
|
|
113
|
-
{ id: 2, name: 'Mid', type: 'Strategic Goal', level: 2, parent_id: 1 },
|
|
114
|
-
{ id: 3, name: 'Leaf', type: 'Project Goal', level: 4, parent_id: 2 },
|
|
115
|
-
],
|
|
116
|
-
};
|
|
117
|
-
const layout = layoutGoalTree(gapped);
|
|
118
|
-
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
119
|
-
const step = byId.get(2)!.x - byId.get(1)!.x;
|
|
120
|
-
// Root→Mid and Mid→Leaf must use the same single-column step despite
|
|
121
|
-
// the level numbers jumping by 2 each time.
|
|
122
|
-
expect(byId.get(3)!.x - byId.get(2)!.x).toBe(step);
|
|
123
|
-
// And that step is one node width + one rank separator (250 + 80).
|
|
124
|
-
expect(step).toBe(250 + 80);
|
|
125
|
-
});
|
|
126
|
-
|
|
127
|
-
// Pre-release blocker regression (orchestrator review 2026-05-21).
|
|
128
|
-
it('[blocker] does not stack-overflow on a self-parent cycle', () => {
|
|
129
|
-
const cyclic: GoalTree = {
|
|
130
|
-
goal_types: [{ name: 'X', level: 0 }],
|
|
131
|
-
goals: [{ id: 1, name: 'self-parent', type: 'X', level: 0, parent_id: 1 }],
|
|
132
|
-
};
|
|
133
|
-
// Without a visited-set inside placeSubtree, this recurses forever.
|
|
134
|
-
expect(() => layoutGoalTree(cyclic)).not.toThrow();
|
|
135
|
-
});
|
|
136
|
-
|
|
137
|
-
it('[blocker] does not stack-overflow on a 2-node mutual cycle', () => {
|
|
138
|
-
const cyclic: GoalTree = {
|
|
139
|
-
goal_types: [{ name: 'X', level: 0 }, { name: 'Y', level: 1 }],
|
|
140
|
-
goals: [
|
|
141
|
-
{ id: 1, name: 'A', type: 'X', level: 0, parent_id: 2 },
|
|
142
|
-
{ id: 2, name: 'B', type: 'Y', level: 1, parent_id: 1 },
|
|
143
|
-
],
|
|
144
|
-
};
|
|
145
|
-
expect(() => layoutGoalTree(cyclic)).not.toThrow();
|
|
146
|
-
});
|
|
147
|
-
|
|
148
|
-
// vkgeorgia/strategy#77 — scope filtering.
|
|
149
|
-
describe('scope', () => {
|
|
150
|
-
const ids = (l: ReturnType<typeof layoutGoalTree>) => l.nodes.map(n => n.id).sort((a, b) => a - b);
|
|
151
|
-
|
|
152
|
-
it("mode 'all' matches the baseline", () => {
|
|
153
|
-
expect(ids(layoutGoalTree(TREE, { scope: { mode: 'all' } }))).toEqual(ids(layoutGoalTree(TREE)));
|
|
154
|
-
});
|
|
155
|
-
|
|
156
|
-
it("mode 'level' trims goals strictly above the cap", () => {
|
|
157
|
-
// TREE: id1 level0, id2 level1, id3/id4 level2.
|
|
158
|
-
const layout = layoutGoalTree(TREE, { scope: { mode: 'level', maxLevel: 1 } });
|
|
159
|
-
expect(ids(layout)).toEqual([1, 2]);
|
|
160
|
-
expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
|
|
161
|
-
});
|
|
162
|
-
|
|
163
|
-
it("mode 'root' keeps the chosen goal and its descendants", () => {
|
|
164
|
-
// root id2 → itself + children id3, id4.
|
|
165
|
-
const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '2' } });
|
|
166
|
-
expect(ids(layout)).toEqual([2, 3, 4]);
|
|
167
|
-
});
|
|
168
|
-
|
|
169
|
-
it("mode 'root' returns an empty layout when the root is absent", () => {
|
|
170
|
-
const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '999' } });
|
|
171
|
-
expect(layout.nodes).toHaveLength(0);
|
|
172
|
-
expect(layout.edges).toHaveLength(0);
|
|
173
|
-
});
|
|
174
|
-
});
|
|
175
|
-
});
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { layoutGoalTree } from '../layout.js';
|
|
3
|
+
import type { GoalTree } from '../types.js';
|
|
4
|
+
|
|
5
|
+
const TREE: GoalTree = {
|
|
6
|
+
goal_types: [
|
|
7
|
+
{ name: 'Strategy', level: 0 },
|
|
8
|
+
{ name: 'Business Goal', level: 1 },
|
|
9
|
+
{ name: 'Project', level: 2 },
|
|
10
|
+
],
|
|
11
|
+
goals: [
|
|
12
|
+
{ id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
|
|
13
|
+
{ id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
|
|
14
|
+
{ id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
|
|
15
|
+
{ id: 4, name: 'London Office', type: 'Project', level: 2, parent_id: 2 },
|
|
16
|
+
],
|
|
17
|
+
};
|
|
18
|
+
|
|
19
|
+
describe('layoutGoalTree', () => {
|
|
20
|
+
it('returns nodes for all goals', () => {
|
|
21
|
+
const layout = layoutGoalTree(TREE);
|
|
22
|
+
expect(layout.nodes).toHaveLength(4);
|
|
23
|
+
});
|
|
24
|
+
|
|
25
|
+
it('returns edges for parent-child pairs', () => {
|
|
26
|
+
const layout = layoutGoalTree(TREE);
|
|
27
|
+
expect(layout.edges).toHaveLength(3); // 1→2, 2→3, 2→4
|
|
28
|
+
});
|
|
29
|
+
|
|
30
|
+
it('levels map to increasing x positions', () => {
|
|
31
|
+
const layout = layoutGoalTree(TREE);
|
|
32
|
+
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
33
|
+
expect(byId.get(1)!.x).toBeLessThan(byId.get(2)!.x);
|
|
34
|
+
expect(byId.get(2)!.x).toBeLessThan(byId.get(3)!.x);
|
|
35
|
+
});
|
|
36
|
+
|
|
37
|
+
it('siblings at same level have different y positions', () => {
|
|
38
|
+
const layout = layoutGoalTree(TREE);
|
|
39
|
+
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
40
|
+
expect(byId.get(3)!.y).not.toBe(byId.get(4)!.y);
|
|
41
|
+
});
|
|
42
|
+
|
|
43
|
+
it('returns non-zero bounds for non-empty tree', () => {
|
|
44
|
+
const layout = layoutGoalTree(TREE);
|
|
45
|
+
expect(layout.bounds.width).toBeGreaterThan(0);
|
|
46
|
+
expect(layout.bounds.height).toBeGreaterThan(0);
|
|
47
|
+
});
|
|
48
|
+
|
|
49
|
+
it('returns empty layout for empty goals', () => {
|
|
50
|
+
const layout = layoutGoalTree({ goal_types: [], goals: [] });
|
|
51
|
+
expect(layout.nodes).toHaveLength(0);
|
|
52
|
+
expect(layout.edges).toHaveLength(0);
|
|
53
|
+
});
|
|
54
|
+
|
|
55
|
+
it('nodes have default 250×80 size', () => {
|
|
56
|
+
const layout = layoutGoalTree(TREE);
|
|
57
|
+
expect(layout.nodes[0].width).toBe(250);
|
|
58
|
+
expect(layout.nodes[0].height).toBe(80);
|
|
59
|
+
});
|
|
60
|
+
|
|
61
|
+
it('respects custom nodeWidth/nodeHeight', () => {
|
|
62
|
+
const layout = layoutGoalTree(TREE, { nodeWidth: 200, nodeHeight: 60 });
|
|
63
|
+
expect(layout.nodes[0].width).toBe(200);
|
|
64
|
+
expect(layout.nodes[0].height).toBe(60);
|
|
65
|
+
});
|
|
66
|
+
|
|
67
|
+
// vkgeorgia/strategy#75 — configurable spacing. The preview maps
|
|
68
|
+
// horizontalGap → rankSep and verticalGap → nodeSep.
|
|
69
|
+
it('larger rankSep widens the column step', () => {
|
|
70
|
+
const tight = layoutGoalTree(TREE, { rankSep: 80 });
|
|
71
|
+
const wide = layoutGoalTree(TREE, { rankSep: 200 });
|
|
72
|
+
const stepOf = (l: ReturnType<typeof layoutGoalTree>) => {
|
|
73
|
+
const byId = new Map(l.nodes.map(n => [n.id, n]));
|
|
74
|
+
return byId.get(2)!.x - byId.get(1)!.x;
|
|
75
|
+
};
|
|
76
|
+
expect(stepOf(wide)).toBeGreaterThan(stepOf(tight));
|
|
77
|
+
});
|
|
78
|
+
|
|
79
|
+
it('larger nodeSep increases the gap between stacked siblings', () => {
|
|
80
|
+
const gapOf = (sep: number) => {
|
|
81
|
+
const l = layoutGoalTree(TREE, { nodeSep: sep });
|
|
82
|
+
const byId = new Map(l.nodes.map(n => [n.id, n]));
|
|
83
|
+
return Math.abs(byId.get(4)!.y - byId.get(3)!.y);
|
|
84
|
+
};
|
|
85
|
+
expect(gapOf(120)).toBeGreaterThan(gapOf(24));
|
|
86
|
+
});
|
|
87
|
+
|
|
88
|
+
it('each node carries original goal data', () => {
|
|
89
|
+
const layout = layoutGoalTree(TREE);
|
|
90
|
+
const node1 = layout.nodes.find(n => n.id === 1)!;
|
|
91
|
+
expect(node1.data.name).toBe('North Star');
|
|
92
|
+
});
|
|
93
|
+
|
|
94
|
+
it('viewDepth hides nodes beyond depth', () => {
|
|
95
|
+
const layout = layoutGoalTree(TREE, { viewDepth: 1 });
|
|
96
|
+
// Level 2 nodes (id 3, 4) should be hidden
|
|
97
|
+
expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
|
|
98
|
+
});
|
|
99
|
+
|
|
100
|
+
it('compresses non-contiguous levels into adjacent columns (no phantom empty columns)', () => {
|
|
101
|
+
// Legacy / non-canonical input: goal_types skip levels 1 and 3, so
|
|
102
|
+
// goals sit at levels 0, 2, 4. Column x must advance by exactly one
|
|
103
|
+
// step per used level, not per absolute level value — otherwise the
|
|
104
|
+
// skipped levels open empty columns and double the horizontal spacing.
|
|
105
|
+
const gapped: GoalTree = {
|
|
106
|
+
goal_types: [
|
|
107
|
+
{ name: 'Strategy', level: 0 },
|
|
108
|
+
{ name: 'Strategic Goal', level: 2 },
|
|
109
|
+
{ name: 'Project Goal', level: 4 },
|
|
110
|
+
],
|
|
111
|
+
goals: [
|
|
112
|
+
{ id: 1, name: 'Root', type: 'Strategy', level: 0, parent_id: 0 },
|
|
113
|
+
{ id: 2, name: 'Mid', type: 'Strategic Goal', level: 2, parent_id: 1 },
|
|
114
|
+
{ id: 3, name: 'Leaf', type: 'Project Goal', level: 4, parent_id: 2 },
|
|
115
|
+
],
|
|
116
|
+
};
|
|
117
|
+
const layout = layoutGoalTree(gapped);
|
|
118
|
+
const byId = new Map(layout.nodes.map(n => [n.id, n]));
|
|
119
|
+
const step = byId.get(2)!.x - byId.get(1)!.x;
|
|
120
|
+
// Root→Mid and Mid→Leaf must use the same single-column step despite
|
|
121
|
+
// the level numbers jumping by 2 each time.
|
|
122
|
+
expect(byId.get(3)!.x - byId.get(2)!.x).toBe(step);
|
|
123
|
+
// And that step is one node width + one rank separator (250 + 80).
|
|
124
|
+
expect(step).toBe(250 + 80);
|
|
125
|
+
});
|
|
126
|
+
|
|
127
|
+
// Pre-release blocker regression (orchestrator review 2026-05-21).
|
|
128
|
+
it('[blocker] does not stack-overflow on a self-parent cycle', () => {
|
|
129
|
+
const cyclic: GoalTree = {
|
|
130
|
+
goal_types: [{ name: 'X', level: 0 }],
|
|
131
|
+
goals: [{ id: 1, name: 'self-parent', type: 'X', level: 0, parent_id: 1 }],
|
|
132
|
+
};
|
|
133
|
+
// Without a visited-set inside placeSubtree, this recurses forever.
|
|
134
|
+
expect(() => layoutGoalTree(cyclic)).not.toThrow();
|
|
135
|
+
});
|
|
136
|
+
|
|
137
|
+
it('[blocker] does not stack-overflow on a 2-node mutual cycle', () => {
|
|
138
|
+
const cyclic: GoalTree = {
|
|
139
|
+
goal_types: [{ name: 'X', level: 0 }, { name: 'Y', level: 1 }],
|
|
140
|
+
goals: [
|
|
141
|
+
{ id: 1, name: 'A', type: 'X', level: 0, parent_id: 2 },
|
|
142
|
+
{ id: 2, name: 'B', type: 'Y', level: 1, parent_id: 1 },
|
|
143
|
+
],
|
|
144
|
+
};
|
|
145
|
+
expect(() => layoutGoalTree(cyclic)).not.toThrow();
|
|
146
|
+
});
|
|
147
|
+
|
|
148
|
+
// vkgeorgia/strategy#77 — scope filtering.
|
|
149
|
+
describe('scope', () => {
|
|
150
|
+
const ids = (l: ReturnType<typeof layoutGoalTree>) => l.nodes.map(n => n.id).sort((a, b) => a - b);
|
|
151
|
+
|
|
152
|
+
it("mode 'all' matches the baseline", () => {
|
|
153
|
+
expect(ids(layoutGoalTree(TREE, { scope: { mode: 'all' } }))).toEqual(ids(layoutGoalTree(TREE)));
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
it("mode 'level' trims goals strictly above the cap", () => {
|
|
157
|
+
// TREE: id1 level0, id2 level1, id3/id4 level2.
|
|
158
|
+
const layout = layoutGoalTree(TREE, { scope: { mode: 'level', maxLevel: 1 } });
|
|
159
|
+
expect(ids(layout)).toEqual([1, 2]);
|
|
160
|
+
expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
|
|
161
|
+
});
|
|
162
|
+
|
|
163
|
+
it("mode 'root' keeps the chosen goal and its descendants", () => {
|
|
164
|
+
// root id2 → itself + children id3, id4.
|
|
165
|
+
const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '2' } });
|
|
166
|
+
expect(ids(layout)).toEqual([2, 3, 4]);
|
|
167
|
+
});
|
|
168
|
+
|
|
169
|
+
it("mode 'root' returns an empty layout when the root is absent", () => {
|
|
170
|
+
const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '999' } });
|
|
171
|
+
expect(layout.nodes).toHaveLength(0);
|
|
172
|
+
expect(layout.edges).toHaveLength(0);
|
|
173
|
+
});
|
|
174
|
+
});
|
|
175
|
+
});
|
|
@@ -1,111 +1,111 @@
|
|
|
1
|
-
import { describe, it, expect } from 'vitest';
|
|
2
|
-
import { reparent, addChild, deleteWithDescendants, moveToBacklog, restoreFromBacklog } from '../mutations.js';
|
|
3
|
-
import type { GoalTree } from '../types.js';
|
|
4
|
-
|
|
5
|
-
const TREE: GoalTree = {
|
|
6
|
-
goal_types: [
|
|
7
|
-
{ name: 'Strategy', level: 0 },
|
|
8
|
-
{ name: 'Business Goal', level: 1 },
|
|
9
|
-
{ name: 'Project', level: 2 },
|
|
10
|
-
],
|
|
11
|
-
goals: [
|
|
12
|
-
{ id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
|
|
13
|
-
{ id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
|
|
14
|
-
{ id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
|
|
15
|
-
],
|
|
16
|
-
};
|
|
17
|
-
|
|
18
|
-
describe('reparent', () => {
|
|
19
|
-
it('moves a goal to a new parent', () => {
|
|
20
|
-
const r = reparent(TREE, 3, 1);
|
|
21
|
-
expect(r.ok).toBe(true);
|
|
22
|
-
const moved = r.result!.goals.find(g => g.id === 3)!;
|
|
23
|
-
expect(moved.parent_id).toBe(1);
|
|
24
|
-
expect(moved.level).toBe(1);
|
|
25
|
-
});
|
|
26
|
-
|
|
27
|
-
it('refuses to create a cycle', () => {
|
|
28
|
-
const r = reparent(TREE, 1, 3);
|
|
29
|
-
expect(r.ok).toBe(false);
|
|
30
|
-
expect(r.error?.code).toBe('MUTATION_REFUSED');
|
|
31
|
-
});
|
|
32
|
-
|
|
33
|
-
it('refuses self-reparent', () => {
|
|
34
|
-
expect(reparent(TREE, 1, 1).ok).toBe(false);
|
|
35
|
-
});
|
|
36
|
-
|
|
37
|
-
it('refuses reparent that would exceed max level', () => {
|
|
38
|
-
const r = reparent(TREE, 1, 3); // would make level 3 which exceeds max 2
|
|
39
|
-
expect(r.ok).toBe(false);
|
|
40
|
-
});
|
|
41
|
-
|
|
42
|
-
it('preserves immutability — original tree unchanged', () => {
|
|
43
|
-
reparent(TREE, 3, 1);
|
|
44
|
-
expect(TREE.goals.find(g => g.id === 3)!.parent_id).toBe(2);
|
|
45
|
-
});
|
|
46
|
-
});
|
|
47
|
-
|
|
48
|
-
describe('addChild', () => {
|
|
49
|
-
it('adds a child with auto-assigned id and level', () => {
|
|
50
|
-
const r = addChild(TREE, 2, { name: 'Warsaw Office', type: 'Project', level: 2, parent_id: 2 });
|
|
51
|
-
expect(r.ok).toBe(true);
|
|
52
|
-
const newGoal = r.result!.goals.find(g => g.name === 'Warsaw Office')!;
|
|
53
|
-
expect(newGoal.id).toBeGreaterThan(3);
|
|
54
|
-
expect(newGoal.parent_id).toBe(2);
|
|
55
|
-
expect(newGoal.level).toBe(2);
|
|
56
|
-
});
|
|
57
|
-
|
|
58
|
-
it('adds root-level child when parentId is 0', () => {
|
|
59
|
-
const r = addChild(TREE, 0, { name: 'Second Strategy', type: 'Strategy', level: 0, parent_id: 0 });
|
|
60
|
-
expect(r.ok).toBe(true);
|
|
61
|
-
expect(r.result!.goals.find(g => g.name === 'Second Strategy')!.level).toBe(0);
|
|
62
|
-
});
|
|
63
|
-
|
|
64
|
-
it('refuses when parent not found', () => {
|
|
65
|
-
const r = addChild(TREE, 99, { name: 'X', type: 'Project', level: 2, parent_id: 99 });
|
|
66
|
-
expect(r.ok).toBe(false);
|
|
67
|
-
});
|
|
68
|
-
|
|
69
|
-
it('preserves immutability', () => {
|
|
70
|
-
const before = TREE.goals.length;
|
|
71
|
-
addChild(TREE, 1, { name: 'New', type: 'Business Goal', level: 1, parent_id: 1 });
|
|
72
|
-
expect(TREE.goals.length).toBe(before);
|
|
73
|
-
});
|
|
74
|
-
});
|
|
75
|
-
|
|
76
|
-
describe('deleteWithDescendants', () => {
|
|
77
|
-
it('deletes goal and all descendants', () => {
|
|
78
|
-
const r = deleteWithDescendants(TREE, 2);
|
|
79
|
-
expect(r.ok).toBe(true);
|
|
80
|
-
const ids = r.result!.goals.map(g => g.id);
|
|
81
|
-
expect(ids).not.toContain(2);
|
|
82
|
-
expect(ids).not.toContain(3);
|
|
83
|
-
expect(ids).toContain(1);
|
|
84
|
-
});
|
|
85
|
-
|
|
86
|
-
it('refuses when goal not found', () => {
|
|
87
|
-
expect(deleteWithDescendants(TREE, 99).ok).toBe(false);
|
|
88
|
-
});
|
|
89
|
-
|
|
90
|
-
it('preserves immutability', () => {
|
|
91
|
-
deleteWithDescendants(TREE, 2);
|
|
92
|
-
expect(TREE.goals.length).toBe(3);
|
|
93
|
-
});
|
|
94
|
-
});
|
|
95
|
-
|
|
96
|
-
describe('moveToBacklog', () => {
|
|
97
|
-
it('sets parent_id to 0', () => {
|
|
98
|
-
const r = moveToBacklog(TREE, 3);
|
|
99
|
-
expect(r.ok).toBe(true);
|
|
100
|
-
expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(0);
|
|
101
|
-
});
|
|
102
|
-
});
|
|
103
|
-
|
|
104
|
-
describe('restoreFromBacklog', () => {
|
|
105
|
-
it('reparents the goal to the new parent', () => {
|
|
106
|
-
const backlogged = moveToBacklog(TREE, 3).result!;
|
|
107
|
-
const r = restoreFromBacklog(backlogged, 3, 1);
|
|
108
|
-
expect(r.ok).toBe(true);
|
|
109
|
-
expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(1);
|
|
110
|
-
});
|
|
111
|
-
});
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { reparent, addChild, deleteWithDescendants, moveToBacklog, restoreFromBacklog } from '../mutations.js';
|
|
3
|
+
import type { GoalTree } from '../types.js';
|
|
4
|
+
|
|
5
|
+
const TREE: GoalTree = {
|
|
6
|
+
goal_types: [
|
|
7
|
+
{ name: 'Strategy', level: 0 },
|
|
8
|
+
{ name: 'Business Goal', level: 1 },
|
|
9
|
+
{ name: 'Project', level: 2 },
|
|
10
|
+
],
|
|
11
|
+
goals: [
|
|
12
|
+
{ id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
|
|
13
|
+
{ id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
|
|
14
|
+
{ id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
|
|
15
|
+
],
|
|
16
|
+
};
|
|
17
|
+
|
|
18
|
+
describe('reparent', () => {
|
|
19
|
+
it('moves a goal to a new parent', () => {
|
|
20
|
+
const r = reparent(TREE, 3, 1);
|
|
21
|
+
expect(r.ok).toBe(true);
|
|
22
|
+
const moved = r.result!.goals.find(g => g.id === 3)!;
|
|
23
|
+
expect(moved.parent_id).toBe(1);
|
|
24
|
+
expect(moved.level).toBe(1);
|
|
25
|
+
});
|
|
26
|
+
|
|
27
|
+
it('refuses to create a cycle', () => {
|
|
28
|
+
const r = reparent(TREE, 1, 3);
|
|
29
|
+
expect(r.ok).toBe(false);
|
|
30
|
+
expect(r.error?.code).toBe('MUTATION_REFUSED');
|
|
31
|
+
});
|
|
32
|
+
|
|
33
|
+
it('refuses self-reparent', () => {
|
|
34
|
+
expect(reparent(TREE, 1, 1).ok).toBe(false);
|
|
35
|
+
});
|
|
36
|
+
|
|
37
|
+
it('refuses reparent that would exceed max level', () => {
|
|
38
|
+
const r = reparent(TREE, 1, 3); // would make level 3 which exceeds max 2
|
|
39
|
+
expect(r.ok).toBe(false);
|
|
40
|
+
});
|
|
41
|
+
|
|
42
|
+
it('preserves immutability — original tree unchanged', () => {
|
|
43
|
+
reparent(TREE, 3, 1);
|
|
44
|
+
expect(TREE.goals.find(g => g.id === 3)!.parent_id).toBe(2);
|
|
45
|
+
});
|
|
46
|
+
});
|
|
47
|
+
|
|
48
|
+
describe('addChild', () => {
|
|
49
|
+
it('adds a child with auto-assigned id and level', () => {
|
|
50
|
+
const r = addChild(TREE, 2, { name: 'Warsaw Office', type: 'Project', level: 2, parent_id: 2 });
|
|
51
|
+
expect(r.ok).toBe(true);
|
|
52
|
+
const newGoal = r.result!.goals.find(g => g.name === 'Warsaw Office')!;
|
|
53
|
+
expect(newGoal.id).toBeGreaterThan(3);
|
|
54
|
+
expect(newGoal.parent_id).toBe(2);
|
|
55
|
+
expect(newGoal.level).toBe(2);
|
|
56
|
+
});
|
|
57
|
+
|
|
58
|
+
it('adds root-level child when parentId is 0', () => {
|
|
59
|
+
const r = addChild(TREE, 0, { name: 'Second Strategy', type: 'Strategy', level: 0, parent_id: 0 });
|
|
60
|
+
expect(r.ok).toBe(true);
|
|
61
|
+
expect(r.result!.goals.find(g => g.name === 'Second Strategy')!.level).toBe(0);
|
|
62
|
+
});
|
|
63
|
+
|
|
64
|
+
it('refuses when parent not found', () => {
|
|
65
|
+
const r = addChild(TREE, 99, { name: 'X', type: 'Project', level: 2, parent_id: 99 });
|
|
66
|
+
expect(r.ok).toBe(false);
|
|
67
|
+
});
|
|
68
|
+
|
|
69
|
+
it('preserves immutability', () => {
|
|
70
|
+
const before = TREE.goals.length;
|
|
71
|
+
addChild(TREE, 1, { name: 'New', type: 'Business Goal', level: 1, parent_id: 1 });
|
|
72
|
+
expect(TREE.goals.length).toBe(before);
|
|
73
|
+
});
|
|
74
|
+
});
|
|
75
|
+
|
|
76
|
+
describe('deleteWithDescendants', () => {
|
|
77
|
+
it('deletes goal and all descendants', () => {
|
|
78
|
+
const r = deleteWithDescendants(TREE, 2);
|
|
79
|
+
expect(r.ok).toBe(true);
|
|
80
|
+
const ids = r.result!.goals.map(g => g.id);
|
|
81
|
+
expect(ids).not.toContain(2);
|
|
82
|
+
expect(ids).not.toContain(3);
|
|
83
|
+
expect(ids).toContain(1);
|
|
84
|
+
});
|
|
85
|
+
|
|
86
|
+
it('refuses when goal not found', () => {
|
|
87
|
+
expect(deleteWithDescendants(TREE, 99).ok).toBe(false);
|
|
88
|
+
});
|
|
89
|
+
|
|
90
|
+
it('preserves immutability', () => {
|
|
91
|
+
deleteWithDescendants(TREE, 2);
|
|
92
|
+
expect(TREE.goals.length).toBe(3);
|
|
93
|
+
});
|
|
94
|
+
});
|
|
95
|
+
|
|
96
|
+
describe('moveToBacklog', () => {
|
|
97
|
+
it('sets parent_id to 0', () => {
|
|
98
|
+
const r = moveToBacklog(TREE, 3);
|
|
99
|
+
expect(r.ok).toBe(true);
|
|
100
|
+
expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(0);
|
|
101
|
+
});
|
|
102
|
+
});
|
|
103
|
+
|
|
104
|
+
describe('restoreFromBacklog', () => {
|
|
105
|
+
it('reparents the goal to the new parent', () => {
|
|
106
|
+
const backlogged = moveToBacklog(TREE, 3).result!;
|
|
107
|
+
const r = restoreFromBacklog(backlogged, 3, 1);
|
|
108
|
+
expect(r.ok).toBe(true);
|
|
109
|
+
expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(1);
|
|
110
|
+
});
|
|
111
|
+
});
|