@tradejs/app 3.1.3 → 3.1.4

package/src/app/components/Strategies/RuntimeStrategyConfigDrawer.tsx

@@ -1,501 +1,61 @@
 'use client';
 
 import {
-  type ReactNode,
-  useCallback,
-  useEffect,
-  useMemo,
-  useState,
-} from 'react';
-import {
-  Box,
   Button,
-  Checkbox,
   CloseButton,
   Drawer,
-  Field,
-  Flex,
-  Input,
-  NativeSelect,
   Portal,
   Text,
   Textarea,
 } from '@chakra-ui/react';
-import type { MarketUniverse, RuntimeStrategyView } from '@tradejs/types';
-import {
-  DEFAULT_RUNTIME_STRATEGY_MANAGED_PARAMETERS,
-  mergeRuntimeStrategyManagedParameters,
-  splitRuntimeStrategyConfig,
-} from '#app/lib/runtimeStrategyConfigForm';
-import { toaster } from '#ui';
-
-type AccountOption = {
-  id: string;
-  label: string;
-  provider: string;
-  enabled: boolean;
-  isDefault?: boolean;
-  universes: MarketUniverse[];
-};
-
-type OptionsResponse = {
-  strategyNames: string[];
-  accounts: AccountOption[];
-  intervals: string[];
-  error?: string;
-};
-
-const SelectField = ({
-  label,
-  value,
-  onChange,
-  children,
-  disabled,
-}: {
-  label: string;
-  value: string;
-  onChange: (value: string) => void;
-  children: ReactNode;
-  disabled?: boolean;
-}) => (
-  <Field.Root>
-    <Field.Label>{label}</Field.Label>
-    <NativeSelect.Root disabled={disabled}>
-      <NativeSelect.Field
-        value={value}
-        onChange={(event) => onChange(event.currentTarget.value)}
-      >
-        {children}
-      </NativeSelect.Field>
-      <NativeSelect.Indicator />
-    </NativeSelect.Root>
-  </Field.Root>
-);
+import type { RuntimeStrategyView } from '@tradejs/types';
 
 export const RuntimeStrategyConfigDrawer = ({
   open,
   strategy,
   onOpenChange,
-  onSaved,
 }: {
   open: boolean;
-  strategy?: RuntimeStrategyView | null;
+  strategy: RuntimeStrategyView;
   onOpenChange: (open: boolean) => void;
-  onSaved: () => Promise<void> | void;
-}) => {
-  const editing = Boolean(strategy);
-  const [options, setOptions] = useState<OptionsResponse>({
-    strategyNames: [],
-    accounts: [],
-    intervals: ['15'],
-  });
-  const [strategyName, setStrategyName] = useState('');
-  const [configId, setConfigId] = useState('config');
-  const [interval, setInterval] = useState('15');
-  const [universe, setUniverse] = useState<MarketUniverse>('crypto');
-  const [accountId, setAccountId] = useState('');
-  const [enabled, setEnabled] = useState(true);
-  const [maxLossValue, setMaxLossValue] = useState('1');
-  const [aiEnabled, setAiEnabled] = useState(true);
-  const [aiMode, setAiMode] = useState<'gate' | 'llm'>('gate');
-  const [minAiQuality, setMinAiQuality] = useState('4');
-  const [mlEnabled, setMlEnabled] = useState(false);
-  const [mlThreshold, setMlThreshold] = useState('0.1');
-  const [parameters, setParameters] = useState('{}');
-  const [loading, setLoading] = useState(false);
-  const [saving, setSaving] = useState(false);
-
-  const loadOptions = useCallback(async () => {
-    setLoading(true);
-    try {
-      const response = await fetch('/api/user/runtime-strategy-configs');
-      const payload = (await response.json()) as OptionsResponse;
-      if (!response.ok)
-        throw new Error(
-          payload.error || 'Failed to load configuration options',
-        );
-      setOptions(payload);
-      if (!editing && !strategyName)
-        setStrategyName(payload.strategyNames[0] ?? '');
-    } catch (error) {
-      toaster.error({
-        title: 'Failed to load strategy settings',
-        description: error instanceof Error ? error.message : String(error),
-      });
-    } finally {
-      setLoading(false);
-    }
-  }, [editing, strategyName]);
-
-  useEffect(() => {
-    if (!open) return;
-    if (strategy) {
-      const { managed, parameters: strategyParameters } =
-        splitRuntimeStrategyConfig(strategy.config);
-      setStrategyName(strategy.strategyName);
-      setConfigId(strategy.configId);
-      setInterval(String(strategy.interval ?? '15'));
-      setUniverse(strategy.universe ?? 'crypto');
-      setAccountId(String(strategy.config?.ACCOUNT_ID ?? ''));
-      setEnabled(strategy.enabled);
-      setMaxLossValue(String(managed.maxLossValue));
-      setAiEnabled(managed.aiEnabled);
-      setAiMode(managed.aiMode);
-      setMinAiQuality(String(managed.minAiQuality));
-      setMlEnabled(managed.mlEnabled);
-      setMlThreshold(String(managed.mlThreshold));
-      setParameters(JSON.stringify(strategyParameters, null, 2));
-    } else {
-      const managed = DEFAULT_RUNTIME_STRATEGY_MANAGED_PARAMETERS;
-      setConfigId('config');
-      setInterval('15');
-      setUniverse('crypto');
-      setAccountId('');
-      setEnabled(true);
-      setMaxLossValue(String(managed.maxLossValue));
-      setAiEnabled(managed.aiEnabled);
-      setAiMode(managed.aiMode);
-      setMinAiQuality(String(managed.minAiQuality));
-      setMlEnabled(managed.mlEnabled);
-      setMlThreshold(String(managed.mlThreshold));
-      setParameters('{}');
-    }
-    if (!strategy?.releaseVersion) void loadOptions();
-  }, [loadOptions, open, strategy]);
-
-  const compatibleAccounts = useMemo(
-    () =>
-      options.accounts.filter(
-        (account) =>
-          account.enabled &&
-          account.provider === 'bybit' &&
-          account.universes.includes(universe),
-      ),
-    [options.accounts, universe],
-  );
-
-  useEffect(() => {
-    if (
-      accountId &&
-      !compatibleAccounts.some((account) => account.id === accountId)
-    ) {
-      setAccountId('');
-    }
-  }, [accountId, compatibleAccounts]);
-
-  const save = async () => {
-    setSaving(true);
-    try {
-      const parsed = JSON.parse(parameters) as unknown;
-      if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
-        throw new Error('Strategy parameters must be a JSON object');
-      }
-      const parsedMaxLossValue = Number(maxLossValue);
-      if (!Number.isFinite(parsedMaxLossValue) || parsedMaxLossValue < 0) {
-        throw new Error('Max loss value must be a non-negative number');
-      }
-      const parsedMinAiQuality = Number(minAiQuality);
-      if (
-        !Number.isInteger(parsedMinAiQuality) ||
-        parsedMinAiQuality < 0 ||
-        parsedMinAiQuality > 5
-      ) {
-        throw new Error('Minimum AI quality must be an integer from 0 to 5');
-      }
-      const parsedMlThreshold = Number(mlThreshold);
-      if (
-        !Number.isFinite(parsedMlThreshold) ||
-        parsedMlThreshold < 0 ||
-        parsedMlThreshold > 1
-      ) {
-        throw new Error('ML threshold must be a number from 0 to 1');
-      }
-      const managedParameters = mergeRuntimeStrategyManagedParameters(
-        parsed as Record<string, unknown>,
-        {
-          maxLossValue: parsedMaxLossValue,
-          aiEnabled,
-          aiMode,
-          minAiQuality: parsedMinAiQuality,
-          mlEnabled,
-          mlThreshold: parsedMlThreshold,
-        },
-      );
-      const response = await fetch('/api/user/runtime-strategy-configs', {
-        method: editing ? 'PATCH' : 'POST',
-        headers: { 'content-type': 'application/json' },
-        body: JSON.stringify({
-          strategyName,
-          configId,
-          interval,
-          universe,
-          accountId: accountId || null,
-          enabled,
-          parameters: managedParameters,
-        }),
-      });
-      const payload = (await response.json()) as { error?: string };
-      if (!response.ok) throw new Error(payload.error || 'Save failed');
-      toaster.success({
-        title: editing ? 'Strategy config updated' : 'Strategy config created',
-      });
-      onOpenChange(false);
-      await onSaved();
-    } catch (error) {
-      toaster.error({
-        title: 'Could not save strategy config',
-        description: error instanceof Error ? error.message : String(error),
-      });
-    } finally {
-      setSaving(false);
-    }
-  };
-
-  if (strategy?.releaseVersion) {
-    return (
-      <Drawer.Root
-        size="lg"
-        open={open}
-        onOpenChange={(event) => onOpenChange(event.open)}
-      >
-        <Portal>
-          <Drawer.Backdrop />
-          <Drawer.Positioner>
-            <Drawer.Content bg="gray.950">
-              <Drawer.Header>
-                <Drawer.Title>
-                  {strategy.strategyName} release v{strategy.releaseVersion}
-                </Drawer.Title>
-                <Drawer.CloseTrigger asChild>
-                  <CloseButton size="sm" />
-                </Drawer.CloseTrigger>
-              </Drawer.Header>
-              <Drawer.Body display="flex" flexDirection="column" gap={4}>
-                <Text color="gray.400">
-                  Published releases are immutable. Create and publish a new
-                  release to change this configuration.
-                </Text>
-                <Textarea
-                  value={JSON.stringify(strategy.config ?? {}, null, 2)}
-                  readOnly
-                  minH="70vh"
-                  fontFamily="mono"
-                  fontSize="sm"
-                />
-              </Drawer.Body>
-              <Drawer.Footer>
-                <Button variant="outline" onClick={() => onOpenChange(false)}>
-                  Close
-                </Button>
-              </Drawer.Footer>
-            </Drawer.Content>
-          </Drawer.Positioner>
-        </Portal>
-      </Drawer.Root>
-    );
-  }
-
-  return (
-    <Drawer.Root
-      size="lg"
-      open={open}
-      onOpenChange={(event) => onOpenChange(event.open)}
-    >
-      <Portal>
-        <Drawer.Backdrop />
-        <Drawer.Positioner>
-          <Drawer.Content bg="gray.950">
-            <Drawer.Header>
-              <Drawer.Title>
-                {editing
-                  ? 'Edit strategy configuration'
-                  : 'Create strategy configuration'}
-              </Drawer.Title>
-              <Drawer.CloseTrigger asChild>
-                <CloseButton size="sm" />
-              </Drawer.CloseTrigger>
-            </Drawer.Header>
-            <Drawer.Body display="flex" flexDirection="column" gap={5}>
-              {editing ? (
-                <Field.Root>
-                  <Field.Label>Strategy</Field.Label>
-                  <Input value={strategyName} disabled />
-                </Field.Root>
-              ) : (
-                <SelectField
-                  label="Strategy"
-                  value={strategyName}
-                  onChange={setStrategyName}
-                  disabled={loading}
-                >
-                  {options.strategyNames.map((name) => (
-                    <option key={name} value={name}>
-                      {name}
-                    </option>
-                  ))}
-                </SelectField>
-              )}
-              <Field.Root>
-                <Field.Label>Configuration id</Field.Label>
-                <Input
-                  value={configId}
-                  disabled={editing}
-                  onChange={(event) => setConfigId(event.target.value)}
-                />
-              </Field.Root>
-              <Flex gap={4} align="start">
-                <Box flex="1">
-                  <SelectField
-                    label="Timeframe"
-                    value={interval}
-                    onChange={setInterval}
-                  >
-                    {options.intervals.map((value) => (
-                      <option key={value} value={value}>
-                        {value}m
-                      </option>
-                    ))}
-                  </SelectField>
-                </Box>
-                <Box flex="1">
-                  <SelectField
-                    label="Universe"
-                    value={universe}
-                    onChange={(value) => setUniverse(value as MarketUniverse)}
-                  >
-                    <option value="crypto">Crypto</option>
-                    <option value="tradfi">TradFi</option>
-                  </SelectField>
-                </Box>
-              </Flex>
-              <SelectField
-                label="Trading account"
-                value={accountId}
-                onChange={setAccountId}
-              >
-                <option value="">Default account for {universe}</option>
-                {compatibleAccounts.map((account) => (
-                  <option key={account.id} value={account.id}>
-                    {account.label}
-                    {account.isDefault ? ' (default)' : ''}
-                  </option>
-                ))}
-              </SelectField>
-              <Checkbox.Root
-                checked={enabled}
-                onCheckedChange={(event) => setEnabled(event.checked === true)}
-              >
-                <Checkbox.HiddenInput />
-                <Checkbox.Control>
-                  <Checkbox.Indicator />
-                </Checkbox.Control>
-                <Checkbox.Label>Enabled</Checkbox.Label>
-              </Checkbox.Root>
-              <Field.Root>
-                <Field.Label>Max loss value</Field.Label>
-                <Input
-                  type="number"
-                  min={0}
-                  step="0.1"
-                  value={maxLossValue}
-                  onChange={(event) => setMaxLossValue(event.target.value)}
-                />
-              </Field.Root>
-              <Text color="gray.300" fontWeight="semibold">
-                AI
-              </Text>
-              <Flex gap={4} align="start">
-                <Box flex="1">
-                  <SelectField
-                    label="AI status"
-                    value={aiEnabled ? 'enabled' : 'disabled'}
-                    onChange={(value) => setAiEnabled(value === 'enabled')}
-                  >
-                    <option value="enabled">Enabled</option>
-                    <option value="disabled">Disabled</option>
-                  </SelectField>
-                </Box>
-                <Box flex="1">
-                  <SelectField
-                    label="AI mode"
-                    value={aiMode}
-                    onChange={(value) =>
-                      setAiMode(value === 'llm' ? 'llm' : 'gate')
-                    }
-                  >
-                    <option value="gate">Gate</option>
-                    <option value="llm">LLM</option>
-                  </SelectField>
-                </Box>
-                <Box flex="1">
-                  <Field.Root>
-                    <Field.Label>Minimum quality</Field.Label>
-                    <Input
-                      type="number"
-                      min={0}
-                      max={5}
-                      step={1}
-                      value={minAiQuality}
-                      onChange={(event) => setMinAiQuality(event.target.value)}
-                    />
-                  </Field.Root>
-                </Box>
-              </Flex>
-              <Text color="gray.300" fontWeight="semibold">
-                ML
-              </Text>
-              <Flex gap={4} align="start">
-                <Box flex="1">
-                  <SelectField
-                    label="ML status"
-                    value={mlEnabled ? 'enabled' : 'disabled'}
-                    onChange={(value) => setMlEnabled(value === 'enabled')}
-                  >
-                    <option value="enabled">Enabled</option>
-                    <option value="disabled">Disabled</option>
-                  </SelectField>
-                </Box>
-                <Box flex="1">
-                  <Field.Root>
-                    <Field.Label>ML threshold</Field.Label>
-                    <Input
-                      type="number"
-                      min={0}
-                      max={1}
-                      step="0.01"
-                      value={mlThreshold}
-                      onChange={(event) => setMlThreshold(event.target.value)}
-                    />
-                  </Field.Root>
-                </Box>
-              </Flex>
-              <Field.Root flex="1">
-                <Field.Label>Strategy parameters (JSON)</Field.Label>
-                <Textarea
-                  value={parameters}
-                  onChange={(event) => setParameters(event.target.value)}
-                  minH="300px"
-                  fontFamily="mono"
-                  fontSize="sm"
-                />
-              </Field.Root>
-            </Drawer.Body>
-            <Drawer.Footer>
-              <Button variant="outline" onClick={() => onOpenChange(false)}>
-                Cancel
-              </Button>
-              <Button
-                colorPalette="teal"
-                loading={saving}
-                disabled={loading || !strategyName || !configId.trim()}
-                onClick={() => void save()}
-              >
-                {editing ? 'Save changes' : 'Create'}
-              </Button>
-            </Drawer.Footer>
-          </Drawer.Content>
-        </Drawer.Positioner>
-      </Portal>
-    </Drawer.Root>
-  );
-};
+}) => (
+  <Drawer.Root
+    size="lg"
+    open={open}
+    onOpenChange={(event) => onOpenChange(event.open)}
+  >
+    <Portal>
+      <Drawer.Backdrop />
+      <Drawer.Positioner>
+        <Drawer.Content bg="gray.950">
+          <Drawer.Header>
+            <Drawer.Title>
+              {strategy.strategyName} release v{strategy.releaseVersion}
+            </Drawer.Title>
+            <Drawer.CloseTrigger asChild>
+              <CloseButton size="sm" />
+            </Drawer.CloseTrigger>
+          </Drawer.Header>
+          <Drawer.Body display="flex" flexDirection="column" gap={4}>
+            <Text color="gray.400">
+              Published releases are immutable. Roll out a new release to change
+              this configuration.
+            </Text>
+            <Textarea
+              value={JSON.stringify(strategy.config, null, 2)}
+              readOnly
+              minH="70vh"
+              fontFamily="mono"
+              fontSize="sm"
+            />
+          </Drawer.Body>
+          <Drawer.Footer>
+            <Button variant="outline" onClick={() => onOpenChange(false)}>
+              Close
+            </Button>
+          </Drawer.Footer>
+        </Drawer.Content>
+      </Drawer.Positioner>
+    </Portal>
+  </Drawer.Root>
+);

package/src/app/api/user/runtime-strategy-configs/route.ts

@@ -1,51 +0,0 @@
-import { NextRequest, NextResponse } from 'next/server';
-import {
-  getRuntimeStrategyConfigOptions,
-  RuntimeStrategyConfigServiceError,
-  saveRuntimeStrategyConfigForUser,
-} from '#app/lib/runtimeStrategyConfigService';
-import { getCurrentUserName } from '#app/lib/currentUser';
-
-export const dynamic = 'force-dynamic';
-
-const projectRoot =
-  String(process.env.PROJECT_CWD || process.cwd()).trim() || process.cwd();
-
-export const GET = async () => {
-  const userName = await getCurrentUserName();
-  if (!userName)
-    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
-  return NextResponse.json(
-    await getRuntimeStrategyConfigOptions({ userName, projectRoot }),
-  );
-};
-
-const save = async (request: NextRequest, editing: boolean) => {
-  const userName = await getCurrentUserName();
-  if (!userName)
-    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
-  try {
-    return NextResponse.json(
-      await saveRuntimeStrategyConfigForUser({
-        userName,
-        projectRoot,
-        input: (await request.json()) as Record<string, unknown>,
-        editing,
-      }),
-    );
-  } catch (error) {
-    const message = error instanceof Error ? error.message : String(error);
-    const status =
-      error instanceof RuntimeStrategyConfigServiceError &&
-      error.code === 'conflict'
-        ? 409
-        : error instanceof RuntimeStrategyConfigServiceError &&
-            error.code === 'not_found'
-          ? 404
-          : 400;
-    return NextResponse.json({ error: message }, { status });
-  }
-};
-
-export const POST = (request: NextRequest) => save(request, false);
-export const PATCH = (request: NextRequest) => save(request, true);

package/src/app/api/user/runtime-strategy-releases/route.ts

@@ -1,60 +0,0 @@
-import { NextRequest, NextResponse } from 'next/server';
-import {
-  getRuntimeStrategyReleaseOptions,
-  publishRuntimeStrategyReleaseForUser,
-  saveRuntimeStrategyReleaseDraftForUser,
-} from '#app/lib/runtimeStrategyReleaseService';
-import { getCurrentUserName } from '#app/lib/currentUser';
-
-export const dynamic = 'force-dynamic';
-
-const projectRoot =
-  String(process.env.PROJECT_CWD || process.cwd()).trim() || process.cwd();
-
-export const GET = async () => {
-  const userName = await getCurrentUserName();
-  if (!userName)
-    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
-  return NextResponse.json(
-    await getRuntimeStrategyReleaseOptions({ userName, projectRoot }),
-  );
-};
-
-export const PATCH = async (request: NextRequest) => {
-  const userName = await getCurrentUserName();
-  if (!userName)
-    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
-  try {
-    const draft = await saveRuntimeStrategyReleaseDraftForUser({
-      userName,
-      projectRoot,
-      input: (await request.json()) as Record<string, unknown>,
-    });
-    return NextResponse.json({ draft });
-  } catch (error) {
-    return NextResponse.json(
-      { error: error instanceof Error ? error.message : String(error) },
-      { status: 400 },
-    );
-  }
-};
-
-export const POST = async (request: NextRequest) => {
-  const userName = await getCurrentUserName();
-  if (!userName)
-    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
-  try {
-    const body = (await request.json()) as { strategyName?: unknown };
-    const release = await publishRuntimeStrategyReleaseForUser({
-      userName,
-      projectRoot,
-      strategyName: String(body.strategyName ?? '').trim(),
-    });
-    return NextResponse.json({ release });
-  } catch (error) {
-    return NextResponse.json(
-      { error: error instanceof Error ? error.message : String(error) },
-      { status: 400 },
-    );
-  }
-};