@tradejs/app 3.1.3 → 3.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tradejs/app",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Installable Next.js UI for the TradeJS TypeScript framework: dashboards, backtests, charts, and runtime data.",
   "keywords": [
     "tradejs",
@@ -52,11 +52,11 @@
     "@chakra-ui/charts": "3.36.1",
     "@chakra-ui/react": "3.36.1",
     "@emotion/react": "^11.14.0",
-    "@tradejs/core": "^3.1.3",
-    "@tradejs/indicators": "^3.1.3",
-    "@tradejs/infra": "^3.1.3",
-    "@tradejs/node": "^3.1.3",
-    "@tradejs/types": "^3.1.3",
+    "@tradejs/core": "^3.1.4",
+    "@tradejs/indicators": "^3.1.4",
+    "@tradejs/infra": "^3.1.4",
+    "@tradejs/node": "^3.1.4",
+    "@tradejs/types": "^3.1.4",
     "@types/bcryptjs": "2.4.6",
     "@types/lodash": "4.17.24",
     "@types/node": "24.13.3",

package/src/app/api/user/runtime-deployments/[deploymentId]/strategies/[strategyName]/control/route.ts

@@ -42,13 +42,13 @@ export const PATCH = async (
   const reference = deployment.strategies.find(
     (strategy) => strategy.strategyName === strategyName,
   );
-  if (!reference?.releaseVersion) {
+  if (!reference) {
     return NextResponse.json(
       { error: 'Pause/resume requires a versioned strategy release' },
       { status: 400 },
     );
   }
-  const previousState = reference.controlState ?? 'active';
+  const previousState = reference.controlState;
   if (previousState === controlState) {
     return NextResponse.json({ deployment, controlState });
   }

package/src/app/api/user/runtime-deployments/route.ts

@@ -6,11 +6,33 @@ import {
 } from '@tradejs/infra/runtimeDeployments';
 import { getTradingAccount } from '@tradejs/infra/tradingAccounts';
 import { getRuntimeStrategyRelease } from '@tradejs/infra/runtimeStrategyReleases';
-import { isMarketUniverse, type RuntimeDeployment } from '@tradejs/types';
+import type {
+  MarketUniverse,
+  RuntimeDeployment,
+  RuntimeDeploymentStrategy,
+} from '@tradejs/types';
 import { getCurrentUserName } from '#app/lib/currentUser';
 
 export const dynamic = 'force-dynamic';
 
+const isRuntimeStrategyReference = (
+  value: unknown,
+): value is RuntimeDeploymentStrategy => {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) return false;
+  const record = value as Record<string, unknown>;
+  return (
+    typeof record.strategyName === 'string' &&
+    record.strategyName.trim().length > 0 &&
+    Number.isSafeInteger(record.releaseVersion) &&
+    Number(record.releaseVersion) > 0 &&
+    (record.controlState === 'active' ||
+      record.controlState === 'entries_paused') &&
+    Object.keys(record).every((key) =>
+      ['strategyName', 'releaseVersion', 'controlState'].includes(key),
+    )
+  );
+};
+
 export const GET = async () => {
   const userName = await getCurrentUserName();
   if (!userName) {
@@ -33,60 +55,38 @@ export const POST = async (request: NextRequest) => {
   }
   try {
     const body = (await request.json()) as Partial<RuntimeDeployment>;
-    const hasVersionedStrategies = Boolean(
-      body.strategies?.some((strategy) => strategy.releaseVersion != null),
-    );
     if (
-      hasVersionedStrategies &&
-      body.strategies?.some((strategy) => strategy.releaseVersion == null)
+      !Array.isArray(body.strategies) ||
+      !body.strategies.length ||
+      !body.strategies.every(isRuntimeStrategyReference)
     ) {
       return NextResponse.json(
-        { error: 'A deployment cannot mix legacy configs and releases' },
+        { error: 'Invalid runtime strategy reference' },
         { status: 400 },
       );
     }
-    const releases = hasVersionedStrategies
-      ? await Promise.all(
-          (body.strategies ?? []).map(async (strategy) => {
-            if (
-              !Number.isSafeInteger(strategy.releaseVersion) ||
-              !strategy.releaseVersion ||
-              (strategy.config && Object.keys(strategy.config).length)
-            ) {
-              throw new Error('Invalid versioned strategy reference');
-            }
-            const release = await getRuntimeStrategyRelease(
-              userName,
-              strategy.strategyName,
-              strategy.releaseVersion,
-            );
-            if (!release) {
-              throw new Error(
-                `Release not found: ${strategy.strategyName} v${strategy.releaseVersion}`,
-              );
-            }
-            return release;
-          }),
-        )
-      : [];
-    const universe = releases[0]?.config.UNIVERSE ?? body.universe;
-    const interval = releases[0]?.config.INTERVAL ?? body.interval;
+    const releases = await Promise.all(
+      body.strategies.map(async (strategy) => {
+        const release = await getRuntimeStrategyRelease(
+          userName,
+          strategy.strategyName,
+          strategy.releaseVersion,
+        );
+        if (!release) {
+          throw new Error(
+            `Release not found: ${strategy.strategyName} v${strategy.releaseVersion}`,
+          );
+        }
+        return release;
+      }),
+    );
     if (
       !body.id ||
       !body.label ||
       !body.connectorName ||
       !body.provider ||
       !body.accountId ||
-      !interval ||
-      !isMarketUniverse(universe) ||
-      !Array.isArray(body.strategies) ||
-      !body.strategies.length ||
-      body.strategies.some((strategy) =>
-        hasVersionedStrategies
-          ? !String(strategy.strategyName ?? '').trim()
-          : !String(strategy.strategyName ?? '').trim() ||
-            !String(strategy.policyProfileId ?? '').trim(),
-      )
+      typeof body.enabled !== 'boolean'
     ) {
       return NextResponse.json(
         { error: 'Invalid runtime deployment' },
@@ -104,9 +104,14 @@ export const POST = async (request: NextRequest) => {
         { status: 400 },
       );
     }
-    if (!account.universes.includes(universe)) {
+    const unsupportedUniverse = releases
+      .map((release) => release.config.UNIVERSE as MarketUniverse)
+      .find((universe) => !account.universes.includes(universe));
+    if (unsupportedUniverse) {
       return NextResponse.json(
-        { error: `Account ${account.id} does not support ${universe}` },
+        {
+          error: `Account ${account.id} does not support ${unsupportedUniverse}`,
+        },
         { status: 400 },
       );
     }
@@ -116,18 +121,8 @@ export const POST = async (request: NextRequest) => {
       connectorName: body.connectorName,
       provider: body.provider,
       accountId: body.accountId,
-      universe,
-      interval: String(interval),
-      enabled: body.enabled !== false,
-      strategies: body.strategies.map((strategy) =>
-        hasVersionedStrategies
-          ? {
-              strategyName: strategy.strategyName,
-              releaseVersion: strategy.releaseVersion,
-              controlState: strategy.controlState ?? 'active',
-            }
-          : strategy,
-      ),
+      enabled: body.enabled,
+      strategies: body.strategies,
       assetClasses: body.assetClasses,
       tickers: body.tickers,
     });

package/src/app/api/user/settings/route.ts

@@ -18,13 +18,6 @@ import { getCurrentUserName } from '#app/lib/currentUser';
 export const dynamic = 'force-dynamic';
 
 type UpdateBody =
-  | {
-      section: 'bybit';
-      data?: {
-        apiKey?: string;
-        apiSecret?: string;
-      };
-    }
   | {
       section: 'coinalyze';
       data?: {
@@ -61,6 +54,14 @@ type UpdateBody =
       };
     };
 
+const UPDATE_SECTIONS = new Set([
+  'coinalyze',
+  'coinmarketcap',
+  'ai',
+  'telegram',
+  'password',
+]);
+
 const cleanText = (value: unknown): string =>
   typeof value === 'string' ? value.trim() : '';
 
@@ -99,10 +100,6 @@ const toResponse = (rawSettings: UserSettings) => {
   return {
     userName: settings.userName,
     settings: {
-      bybit: {
-        apiKey: maskSecret(settings.BYBIT_API_KEY),
-        apiSecret: maskSecret(settings.BYBIT_API_SECRET),
-      },
       coinalyze: {
         apiKey: maskSecret(settings.COINALYZE_API_KEY),
       },
@@ -153,7 +150,12 @@ export const PATCH = async (request: Request) => {
 
   await removeLegacyPasswordlessToken(userName);
   const body = (await request.json()) as UpdateBody | null;
-  if (!body || typeof body !== 'object' || !('section' in body)) {
+  if (
+    !body ||
+    typeof body !== 'object' ||
+    !('section' in body) ||
+    !UPDATE_SECTIONS.has(String(body.section))
+  ) {
     return NextResponse.json({ error: 'Invalid payload' }, { status: 400 });
   }
 
@@ -181,24 +183,6 @@ export const PATCH = async (request: Request) => {
     return NextResponse.json(toResponse(settings));
   }
 
-  if (body.section === 'bybit') {
-    const patch: Partial<UserRecord> = {};
-    const apiKey = cleanOptionalText(body.data?.apiKey);
-    const apiSecret = cleanOptionalText(body.data?.apiSecret);
-
-    if (apiKey) {
-      patch.BYBIT_API_KEY = apiKey;
-    }
-
-    if (apiSecret) {
-      patch.BYBIT_API_SECRET = apiSecret;
-    }
-
-    if (hasKeys(patch)) {
-      await updateUserRecord(userName, patch);
-    }
-  }
-
   if (body.section === 'coinalyze') {
     const apiKey = cleanOptionalText(body.data?.apiKey);
 

package/src/app/api/user/trading-accounts/route.ts

@@ -4,7 +4,6 @@ import {
   listTradingAccounts,
   saveTradingAccount,
 } from '@tradejs/infra/tradingAccounts';
-import { getUserSettings } from '@tradejs/infra/userSettings';
 import { isMarketUniverse, type TradingAccountRef } from '@tradejs/types';
 import { getCurrentUserName } from '#app/lib/currentUser';
 
@@ -26,52 +25,12 @@ const toPublicAccount = (account: TradingAccountRef) => {
   };
 };
 
-const migrateLegacyBybitAccount = async (
-  userName: string,
-  accounts: TradingAccountRef[],
-) => {
-  const upgradedAccounts = await Promise.all(
-    accounts.map((account) =>
-      account.provider === 'bybit' && !account.universes?.includes('tradfi')
-        ? saveTradingAccount(userName, {
-            ...account,
-            universes: ['crypto', 'tradfi'],
-          })
-        : account,
-    ),
-  );
-  if (upgradedAccounts.some(({ provider }) => provider === 'bybit')) {
-    return upgradedAccounts;
-  }
-  const settings = await getUserSettings(userName);
-  if (!settings.BYBIT_API_KEY || !settings.BYBIT_API_SECRET) {
-    return upgradedAccounts;
-  }
-  const migrated = await saveTradingAccount(userName, {
-    id: 'bybit-default',
-    label: 'Bybit',
-    provider: 'bybit',
-    enabled: true,
-    isDefault: true,
-    universes: ['crypto', 'tradfi'],
-    environment: 'mainnet',
-    apiKey: settings.BYBIT_API_KEY,
-    apiSecret: settings.BYBIT_API_SECRET,
-  });
-  return [...upgradedAccounts, migrated].sort((left, right) =>
-    left.label.localeCompare(right.label),
-  );
-};
-
 export const GET = async () => {
   const userName = await getCurrentUserName();
   if (!userName) {
     return NextResponse.json({ error: 'Unauthorized' }, { status: 401 });
   }
-  const accounts = await migrateLegacyBybitAccount(
-    userName,
-    await listTradingAccounts(userName),
-  );
+  const accounts = await listTradingAccounts(userName);
   return NextResponse.json({ accounts: accounts.map(toPublicAccount) });
 };
 

package/src/app/components/Shared/Sidebar/AccountSettingsDrawer.tsx

@@ -38,10 +38,6 @@ import { TradingAccountsPanel } from './TradingAccountsPanel';
 type SettingsResponse = {
   userName: string;
   settings: {
-    bybit: {
-      apiKey: string;
-      apiSecret: string;
-    };
     coinalyze: {
       apiKey: string;
     };
@@ -67,8 +63,6 @@ type SettingsErrorResponse = {
 
 type SettingsViewState = {
   userName: string;
-  bybitApiKey: string;
-  bybitApiSecret: string;
   coinalyzeApiKey: string;
   coinmarketcapApiKey: string;
   aiApiKey: string;
@@ -87,15 +81,12 @@ type PasswordState = {
 };
 
 type SectionName =
-  | 'bybit'
   | 'password'
   | 'coinalyze'
   | 'coinmarketcap'
   | 'ai'
   | 'telegram';
 type EditableField =
-  | 'bybitApiKey'
-  | 'bybitApiSecret'
   | 'coinalyzeApiKey'
   | 'coinmarketcapApiKey'
   | 'aiApiKey'
@@ -107,8 +98,6 @@ type EditableField =
 
 const EMPTY_SETTINGS: SettingsViewState = {
   userName: '',
-  bybitApiKey: '',
-  bybitApiSecret: '',
   coinalyzeApiKey: '',
   coinmarketcapApiKey: '',
   aiApiKey: '',
@@ -120,8 +109,6 @@ const EMPTY_SETTINGS: SettingsViewState = {
 };
 
 const EMPTY_DRAFTS: SettingsDraftState = {
-  bybitApiKey: '',
-  bybitApiSecret: '',
   coinalyzeApiKey: '',
   coinmarketcapApiKey: '',
   aiApiKey: '',
@@ -138,8 +125,6 @@ const EMPTY_PASSWORDS: PasswordState = {
 };
 
 const EMPTY_EDITING: Record<EditableField, boolean> = {
-  bybitApiKey: false,
-  bybitApiSecret: false,
   coinalyzeApiKey: false,
   coinmarketcapApiKey: false,
   aiApiKey: false,
@@ -150,20 +135,7 @@ const EMPTY_EDITING: Record<EditableField, boolean> = {
   tgChatId: false,
 };
 
-const SECTION_FIELDS: Record<
-  Exclude<SectionName, 'password'>,
-  EditableField[]
-> = {
-  bybit: ['bybitApiKey', 'bybitApiSecret'],
-  coinalyze: ['coinalyzeApiKey'],
-  coinmarketcap: ['coinmarketcapApiKey'],
-  ai: ['aiApiKey', 'aiApiEndpoint', 'aiModel', 'aiResponseLanguage'],
-  telegram: ['tgBotToken', 'tgChatId'],
-};
-
 const MASKED_FIELDS = new Set<EditableField>([
-  'bybitApiKey',
-  'bybitApiSecret',
   'coinalyzeApiKey',
   'coinmarketcapApiKey',
   'aiApiKey',
@@ -172,8 +144,6 @@ const MASKED_FIELDS = new Set<EditableField>([
 
 const toViewState = (payload: SettingsResponse): SettingsViewState => ({
   userName: payload.userName,
-  bybitApiKey: payload.settings.bybit.apiKey || '',
-  bybitApiSecret: payload.settings.bybit.apiSecret || '',
   coinalyzeApiKey: payload.settings.coinalyze.apiKey || '',
   coinmarketcapApiKey: payload.settings.coinmarketcap.apiKey || '',
   aiApiKey: payload.settings.ai.apiKey || '',
@@ -349,9 +319,7 @@ export const AccountSettingsDrawer = () => {
         );
       }
 
-      return SECTION_FIELDS[section].some((field) =>
-        Boolean(drafts[field].trim()),
-      );
+      return false;
     },
     [drafts, passwords.confirmPassword, passwords.password, settings],
   );
@@ -437,56 +405,48 @@ export const AccountSettingsDrawer = () => {
 
     try {
       const body =
-        section === 'bybit'
+        section === 'coinalyze'
           ? {
               section,
               data: {
-                apiKey: getSecretUpdateValue('bybitApiKey'),
-                apiSecret: getSecretUpdateValue('bybitApiSecret'),
+                apiKey: getSecretUpdateValue('coinalyzeApiKey'),
               },
             }
-          : section === 'coinalyze'
+          : section === 'ai'
             ? {
                 section,
                 data: {
-                  apiKey: getSecretUpdateValue('coinalyzeApiKey'),
+                  apiKey: getSecretUpdateValue('aiApiKey'),
+                  apiEndpoint: drafts.aiApiEndpoint,
+                  model: drafts.aiModel.trim(),
+                  responseLanguage: drafts.aiResponseLanguage,
                 },
               }
-            : section === 'ai'
+            : section === 'coinmarketcap'
               ? {
                   section,
                   data: {
-                    apiKey: getSecretUpdateValue('aiApiKey'),
-                    apiEndpoint: drafts.aiApiEndpoint,
-                    model: drafts.aiModel.trim(),
-                    responseLanguage: drafts.aiResponseLanguage,
+                    apiKey: getSecretUpdateValue('coinmarketcapApiKey'),
                   },
                 }
-              : section === 'coinmarketcap'
+              : section === 'telegram'
                 ? {
                     section,
                     data: {
-                      apiKey: getSecretUpdateValue('coinmarketcapApiKey'),
+                      botToken: getSecretUpdateValue('tgBotToken'),
+                      chatId:
+                        drafts.tgChatId !== settings.tgChatId
+                          ? drafts.tgChatId.trim()
+                          : undefined,
                     },
                   }
-                : section === 'telegram'
-                  ? {
-                      section,
-                      data: {
-                        botToken: getSecretUpdateValue('tgBotToken'),
-                        chatId:
-                          drafts.tgChatId !== settings.tgChatId
-                            ? drafts.tgChatId.trim()
-                            : undefined,
-                      },
-                    }
-                  : {
-                      section,
-                      data: {
-                        password: passwords.password,
-                        confirmPassword: passwords.confirmPassword,
-                      },
-                    };
+                : {
+                    section,
+                    data: {
+                      password: passwords.password,
+                      confirmPassword: passwords.confirmPassword,
+                    },
+                  };
 
       const response = await fetch('/api/user/settings', {
         method: 'PATCH',

package/src/app/components/Strategies/RuntimeStrategyCard.tsx

@@ -72,7 +72,6 @@ export const RuntimeStrategyCard = ({
   );
   const { lastTrade, runtimeOrders } = viewModel;
   const setControlState = async (controlState: 'active' | 'entries_paused') => {
-    if (!strategy.deploymentId || !strategy.releaseVersion) return;
     setControlSaving(true);
     try {
       const response = await fetch(
@@ -135,25 +134,17 @@ export const RuntimeStrategyCard = ({
         <Badge colorPalette="cyan" variant="outline">
           TF: {strategy.interval}m
         </Badge>
-        {strategy.releaseVersion ? (
-          <Badge colorPalette="gray" variant="outline">
-            release: v{strategy.releaseVersion}
-          </Badge>
-        ) : (
-          <Badge colorPalette="gray" variant="outline">
-            legacy config: {strategy.configId}
-          </Badge>
-        )}
+        <Badge colorPalette="gray" variant="outline">
+          release: v{strategy.releaseVersion}
+        </Badge>
         {strategy.accountId ? (
           <Badge colorPalette="purple" variant="outline">
             account: {strategy.accountLabel ?? strategy.accountId}
           </Badge>
         ) : null}
-        {strategy.deploymentId ? (
-          <Badge colorPalette="orange" variant="outline">
-            deployment: {strategy.deploymentId}
-          </Badge>
-        ) : null}
+        <Badge colorPalette="orange" variant="outline">
+          deployment: {strategy.deploymentId}
+        </Badge>
         {strategy.policyProfileId ? (
           <Badge colorPalette="cyan" variant="outline">
             policy: {strategy.policyProfileId}
@@ -211,28 +202,24 @@ export const RuntimeStrategyCard = ({
             <Portal>
               <Menu.Positioner>
                 <Menu.Content minW="160px">
-                  {strategy.connected ? (
-                    <Menu.Item value="edit" onClick={() => setConfigOpen(true)}>
-                      {strategy.releaseVersion ? 'View config' : 'Edit'}
-                    </Menu.Item>
-                  ) : null}
-                  {strategy.releaseVersion && strategy.deploymentId ? (
-                    <Menu.Item
-                      value="control"
-                      disabled={controlSaving}
-                      onClick={() =>
-                        void setControlState(
-                          strategy.controlState === 'entries_paused'
-                            ? 'active'
-                            : 'entries_paused',
-                        )
-                      }
-                    >
-                      {strategy.controlState === 'entries_paused'
-                        ? 'Resume entries'
-                        : 'Pause new entries'}
-                    </Menu.Item>
-                  ) : null}
+                  <Menu.Item value="config" onClick={() => setConfigOpen(true)}>
+                    View config
+                  </Menu.Item>
+                  <Menu.Item
+                    value="control"
+                    disabled={controlSaving}
+                    onClick={() =>
+                      void setControlState(
+                        strategy.controlState === 'entries_paused'
+                          ? 'active'
+                          : 'entries_paused',
+                      )
+                    }
+                  >
+                    {strategy.controlState === 'entries_paused'
+                      ? 'Resume entries'
+                      : 'Pause new entries'}
+                  </Menu.Item>
                   <Menu.Item value="orders" onClick={() => setOrdersOpen(true)}>
                     Orders
                   </Menu.Item>
@@ -258,7 +245,6 @@ export const RuntimeStrategyCard = ({
         open={configOpen}
         strategy={strategy}
         onOpenChange={setConfigOpen}
-        onSaved={onUpdated}
       />
 
       <RuntimeStrategyStatsDrawer