@torrent-tv/proxy 2.80.8 → 2.80.9

package/test/coverage-follows-the-disk.test.js

@@ -0,0 +1,187 @@
+/**
+ * @file What the plan believes exists is what the disk holds — with a real
+ * store, a real directory, and no ffmpeg.
+ *
+ * The failure these are written against, field 2026-09-07, twice in one evening
+ * on `Star.Trek.Strange.New.Worlds.S04E03`:
+ *
+ * > `encode: … ready=482 zones=[p100:#0..#0 …] runs=[#0..#0@0.0x] waiting=nobody`
+ * > `encode-run stopped #0..#0 …, reached #-1 (0 segment(s)) after 2778ms,`
+ * > `signal SIGTERM: the film is no worse off without it`
+ * > `encode: … ready=482 … runs=[] waiting=nobody`
+ *
+ * The map claimed every one of the film's 482 segments while the directory held
+ * nothing a header could be lifted out of, so every arrangement scored perfect,
+ * the only encoder was taken away as unnecessary and none was placed again. The
+ * viewer's browser asked for the init segment, was never answered, and gave up.
+ *
+ * Readiness had been accumulating for the life of the process: the map was told
+ * what existed and never told what had stopped existing — the word for that
+ * existed and was called from no line of the product. So these check the one
+ * property that makes the whole class of failure impossible: what the map says
+ * is ready is what the store can prove right now, and nothing older.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { EventEmitter } from "node:events";
+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { EncodeRun } from "../services/encode/EncodeRun.js";
+import { SegmentStore } from "../services/encode/SegmentStore.js";
+import { SoftwareEncoder } from "../services/encode/SoftwareEncoder.js";
+import { EncodeOrchestrator } from "../services/orchestrators/EncodeOrchestrator.js";
+import { fmp4Format } from "../services/segment-formats/fmp4.js";
+
+const PICTURE = "torrent:abc:fmt=fmp4:grid=kf@0:video-only:v=0/copy";
+const SEGMENTS = 482;
+
+class FakeProcess extends EventEmitter {
+  constructor() {
+    super();
+    this.pid = 1;
+  }
+
+  kill(signal) {
+    this.emit("exit", null, signal);
+  }
+}
+
+/**
+ * A store on a real directory, and an orchestrator that owns it.
+ *
+ * @returns {{ made: EncodeOrchestrator, store: SegmentStore, dir: string,
+ *   root: string, lines: string[] }}
+ */
+function orchestratorWithAStore() {
+  const root = mkdtempSync(path.join(os.tmpdir(), "coverage-disk-"));
+  const lines = [];
+  const logger = { info: (line) => lines.push(line), warn: (line) => lines.push(line) };
+  const store = new SegmentStore({ root, logger });
+  store.useFormat(PICTURE, fmp4Format);
+  const dir = store.directoryFor(PICTURE);
+  /** @type {EncodeOrchestrator} */
+  let made;
+  made = new EncodeOrchestrator({
+    maxRunsFor: () => 1,
+    segmentSeconds: 6,
+    killCostSec: 0,
+    firstByteWaitSec: 0.12,
+    refetchSecPerFilmSecond: () => 0.25,
+    startingSpeedFor: () => 2,
+    segmentStore: store,
+    now: () => 1000,
+    logger,
+    makeRun: ({ address, from, to }) => new EncodeRun({
+      address,
+      encoder: new SoftwareEncoder(),
+      from,
+      to,
+      buildArgs: () => ["-i", "in", "out"],
+      spawn: () => new FakeProcess(),
+      logger,
+      now: () => 1000,
+      onEnded: (ended) => made.noteEnded(ended)
+    })
+  });
+  made.setSegmentCount(PICTURE, SEGMENTS);
+  return { made, store, dir, root, lines };
+}
+
+/** A viewer stopped at the beginning, which is what a fresh session states. */
+function aViewerAtTheStart(made) {
+  made.notePriorityMap(PICTURE, [
+    { from: 0, to: 0, priority: 100, withinSeconds: 0 },
+    { from: 1, to: SEGMENTS - 1, priority: 91, withinSeconds: 6 }
+  ]);
+}
+
+/**
+ * Every segment of the film, written and reported closed — what the store looked
+ * like while the film was being watched.
+ */
+function theWholeFilmIsOnDisk(store, dir) {
+  for (let index = 0; index < SEGMENTS; index += 1) {
+    writeFileSync(path.join(dir, fmp4Format.segmentFileName(index)), Buffer.alloc(16));
+    store.markClosed(PICTURE, index);
+  }
+}
+
+test("a film that is entirely made needs no encoder", (t) => {
+  const { made, store, dir, root } = orchestratorWithAStore();
+  t.after(() => rmSync(root, { recursive: true, force: true }));
+
+  theWholeFilmIsOnDisk(store, dir);
+  aViewerAtTheStart(made);
+  made.reconcile();
+
+  // The other half of the property, and the reason the failure looked
+  // reasonable: when the film really is all there, taking the encoder away IS
+  // right, and the viewer is served from the disk.
+  assert.equal(made.runsOn(PICTURE).length, 0, "nothing left to make");
+});
+
+test("segments the store has lost stop being ready, and an encoder is placed again", (t) => {
+  const { made, store, dir, root } = orchestratorWithAStore();
+  t.after(() => rmSync(root, { recursive: true, force: true }));
+
+  theWholeFilmIsOnDisk(store, dir);
+  aViewerAtTheStart(made);
+  made.reconcile();
+  assert.equal(made.runsOn(PICTURE).length, 0);
+
+  // THE FIELD FAILURE. The output's directory goes — dropped for room, or by the
+  // idle rule, or because a killed process left it and the sweep cleared it. The
+  // map used to keep all 482 numbers and the plan went on believing the film was
+  // made, for the life of the process.
+  store.drop(PICTURE, "the test is taking its files away");
+  store.useFormat(PICTURE, fmp4Format);
+  store.directoryFor(PICTURE);
+
+  made.reconcile();
+  const runs = made.runsOn(PICTURE);
+  assert.equal(runs.length, 1, "the film is unmade again, so somebody makes it");
+  assert.equal(runs[0].from, 0, "beginning where the viewer is stopped");
+});
+
+test("a piece discarded with the run that had it open is not ready either", (t) => {
+  const { made, store, dir, root } = orchestratorWithAStore();
+  t.after(() => rmSync(root, { recursive: true, force: true }));
+
+  theWholeFilmIsOnDisk(store, dir);
+  aViewerAtTheStart(made);
+  made.reconcile();
+  assert.equal(made.runsOn(PICTURE).length, 0);
+
+  // A run stopped the instant after opening #0 leaves a file of no bytes under a
+  // name that reads as a segment; the store throws it away. Field 2026-09-07,
+  // 20:13:13 and 20:13:57 — printed twice while the map went on saying 482.
+  rmSync(path.join(dir, fmp4Format.segmentFileName(0)), { force: true });
+
+  made.reconcile();
+  assert.equal(made.runsOn(PICTURE).length, 1, "one number missing is one encoder");
+  assert.equal(made.runsOn(PICTURE)[0].from, 0);
+});
+
+test("nobody making what somebody waits for is said out loud", (t) => {
+  const { made, root, lines } = orchestratorWithAStore();
+  t.after(() => rmSync(root, { recursive: true, force: true }));
+
+  // A HOST THAT CANNOT BUILD AN ENCODER. Whatever the reason — and there are
+  // several — the state it leaves is the one that cost two sessions on
+  // 2026-09-07: somebody is waiting, nothing is being made, and every line
+  // above reads as a healthy proxy. It ran for 41 seconds in the field with no
+  // word about it on either side, and ended at the browser's own timeout with a
+  // message naming no cause.
+  made.makeRun = () => null;
+  aViewerAtTheStart(made);
+  made.reconcile();
+
+  assert.equal(made.runsOn(PICTURE).length, 0);
+  const said = lines.find((line) => line.includes("NO ENCODER IS MAKING IT"));
+  assert.ok(said, "the state has a line of its own");
+  assert.ok(said.includes("#0"), "which number is wanted");
+  assert.ok(said.includes(PICTURE), "of which output, whole — not cut to sixty characters");
+  assert.ok(/files=\d+/.test(said), "and what the disk holds, beside what is proven");
+});

package/test/coverage-map.test.js

@@ -1,178 +1,195 @@
-/**
- * @file The three states of a segment number, and the two questions that decide
- * where an encoder goes.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { CoverageMap } from "../services/encode/CoverageMap.js";
-
-/**
- * A stand-in for a run.
- *
- * The map files a claim under the run ITSELF: a run has no name, and needs
- * none — what identifies it is that it is itself, and what identifies it in a
- * line is the stretch it was given, which no other live run of one output can
- * hold.
- *
- * @returns {object}
- */
-function aRun() {
-  return {};
-}
-
-test("a number nobody has made and nobody is making is free", () => {
-  const map = new CoverageMap({ segmentCount: 10 });
-  assert.equal(map.stateOf(3), "free");
-  assert.equal(map.firstGapFrom(0), 0);
-});
-
-test("a closed file is ready whoever made it", () => {
-  const map = new CoverageMap({ segmentCount: 10 });
-  map.markReady(0);
-  map.markReady(1);
-  assert.equal(map.stateOf(1), "ready");
-  assert.equal(map.firstGapFrom(0), 2);
-});
-
-test("a run claims a stretch, and the gap search skips it", () => {
-  // The claim is an interval and not a head, which is the whole reason two runs
-  // can work on one output: the second is sent past what the first will reach.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 0, 40);
-  assert.equal(map.stateOf(20), "making");
-  assert.equal(map.makerOf(20), runA);
-  assert.equal(map.firstGapFrom(0), 41);
-});
-
-test("a run that ends gives back what it did not finish, and keeps what it did", () => {
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 0, 40);
-  map.markReady(0);
-  map.markReady(1);
-  map.release(runA);
-  assert.equal(map.stateOf(0), "ready", "a closed file survives its maker");
-  assert.equal(map.stateOf(2), "free", "the rest of the stretch is free again");
-  assert.equal(map.firstGapFrom(0), 2);
-});
-
-test("a run with no end claims everything ahead of it", () => {
-  // Which is what every run was before ends existed, and is why a second run
-  // could never be placed.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 10, Number.POSITIVE_INFINITY);
-  assert.equal(map.firstGapFrom(10), null);
-  assert.equal(map.firstGapFrom(0), 0, "behind it is still free");
-});
-
-test("claiming again replaces the earlier claim rather than adding to it", () => {
-  // A run moved forward past ready material states its new stretch; if the two
-  // accumulated, the ground it has left would stay unavailable for ever.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 0, 20);
-  map.claim(runA, 50, 70);
-  assert.equal(map.stateOf(10), "free");
-  assert.equal(map.stateOf(60), "making");
-});
-
-test("the covered stretch ahead is measured, which is what prices a move", () => {
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  const runB = aRun();
-  for (let index = 10; index <= 24; index += 1) {
-    map.markReady(index);
-  }
-  map.claim(runB, 25, 30);
-  // Ready 10..24 then another run's 25..30, so fifteen plus six.
-  assert.equal(map.coveredRunFrom(10, runA), 21);
-  assert.equal(map.firstGapFrom(10), 31);
-});
-
-test("a run's own claim is not counted as somebody else's coverage", () => {
-  // Otherwise a run would read its own stretch as a reason to move off it.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 10, 30);
-  assert.equal(map.coveredRunFrom(10, runA), 0);
-});
-
-test("nothing free ahead answers null rather than a number past the end", () => {
-  const map = new CoverageMap({ segmentCount: 5 });
-  map.markReadyAll([0, 1, 2, 3, 4]);
-  assert.equal(map.firstGapFrom(0), null);
-});
-
-test("a file that has gone stops being ready", () => {
-  const map = new CoverageMap({ segmentCount: 10 });
-  map.markReady(4);
-  map.markGone(4);
-  assert.equal(map.stateOf(4), "free");
-});
-
-test("a run's own claim does not hide the gap it is trying to move into", () => {
-  // Found by the plan's own checks: a run that had claimed the rest of the film
-  // — which is what every run did before ends existed — could find no gap
-  // anywhere, so it was stopped instead of moved.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 0, 99);
-  map.markReadyAll([10, 11, 12]);
-  assert.equal(map.firstGapFrom(10, 90), null, "to anybody else its ground is taken");
-  assert.equal(map.firstGapFrom(10, 90, runA), 13, "to itself the ground beyond is a gap");
-});
-
-test("the free stretch ahead is measured, which is what gives a run its end", () => {
-  // A run handed the whole rest of the film would drive through the stretch
-  // another run is making. Handed the free stretch, it stops where the covered
-  // material begins.
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runB = aRun();
-  map.claim(runB, 30, 60);
-  assert.equal(map.freeRunFrom(10), 20, "free from 10 up to 29");
-  map.markReady(15);
-  assert.equal(map.freeRunFrom(10), 5, "a ready segment ends the free stretch too");
-  assert.equal(map.freeRunFrom(15), 0, "a number that is not free has no free stretch");
-});
-
-test("a run's own claim does not end its own free stretch", () => {
-  const map = new CoverageMap({ segmentCount: 100 });
-  const runA = aRun();
-  map.claim(runA, 10, 40);
-  assert.equal(map.freeRunFrom(10, runA), 90, "its own ground is still its to fill");
-  assert.equal(map.freeRunFrom(10), 0, "to anybody else it is taken");
-});
-
-test("with the length unknown, a gap search needs its own bound", () => {
-  const map = new CoverageMap();
-  assert.equal(map.firstGapFrom(0), null, "no length and no bound answers nothing");
-  assert.equal(map.firstGapFrom(0, 3), 0);
-});
-
-test("with the length unknown, the free stretch is answered without walking to it", () => {
-  // What this pins: on the addon host, 2026-09-05, a map with no length walked
-  // one number at a time to MAX_SAFE_INTEGER, scanning every claim at each step.
-  // The main thread spun at 100% from the look-ahead timer and the proxy stopped
-  // answering anything, its own log included. The length was missing because the
-  // field naming it had moved to the timeline and three readers were left on the
-  // old name — but this walk must not be able to do that even when it is.
-  //
-  // This check cannot FAIL against the old code — a synchronous walk cannot be
-  // interrupted by the runner, so it would hang the whole run instead, which is
-  // worse than no check. What it pins is the contract that replaced the walk:
-  // the answer comes from what the map holds.
-  const map = new CoverageMap();
-
-  assert.equal(map.freeRunFrom(0), Number.POSITIVE_INFINITY, "nothing is covered, so nothing bounds it");
-
-  const run = aRun();
-  map.claim(run, 500, 900);
-  assert.equal(map.freeRunFrom(0), 500, "and a claim ahead is where the free stretch ends");
-  assert.equal(map.freeRunFrom(0, run), Number.POSITIVE_INFINITY, "its own claim does not bound it");
-
-  map.markReady(200);
-  assert.equal(map.freeRunFrom(0), 200, "so is a segment somebody has already made");
-});
+/**
+ * @file The three states of a segment number, and the two questions that decide
+ * where an encoder goes.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { CoverageMap } from "../services/encode/CoverageMap.js";
+
+/**
+ * A stand-in for a run.
+ *
+ * The map files a claim under the run ITSELF: a run has no name, and needs
+ * none — what identifies it is that it is itself, and what identifies it in a
+ * line is the stretch it was given, which no other live run of one output can
+ * hold.
+ *
+ * @returns {object}
+ */
+function aRun() {
+  return {};
+}
+
+test("a number nobody has made and nobody is making is free", () => {
+  const map = new CoverageMap({ segmentCount: 10 });
+  assert.equal(map.stateOf(3), "free");
+  assert.equal(map.firstGapFrom(0), 0);
+});
+
+test("a closed file is ready whoever made it", () => {
+  const map = new CoverageMap({ segmentCount: 10 });
+  map.markReady(0);
+  map.markReady(1);
+  assert.equal(map.stateOf(1), "ready");
+  assert.equal(map.firstGapFrom(0), 2);
+});
+
+test("a run claims a stretch, and the gap search skips it", () => {
+  // The claim is an interval and not a head, which is the whole reason two runs
+  // can work on one output: the second is sent past what the first will reach.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 0, 40);
+  assert.equal(map.stateOf(20), "making");
+  assert.equal(map.makerOf(20), runA);
+  assert.equal(map.firstGapFrom(0), 41);
+});
+
+test("a run that ends gives back what it did not finish, and keeps what it did", () => {
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 0, 40);
+  map.markReady(0);
+  map.markReady(1);
+  map.release(runA);
+  assert.equal(map.stateOf(0), "ready", "a closed file survives its maker");
+  assert.equal(map.stateOf(2), "free", "the rest of the stretch is free again");
+  assert.equal(map.firstGapFrom(0), 2);
+});
+
+test("a run with no end claims everything ahead of it", () => {
+  // Which is what every run was before ends existed, and is why a second run
+  // could never be placed.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 10, Number.POSITIVE_INFINITY);
+  assert.equal(map.firstGapFrom(10), null);
+  assert.equal(map.firstGapFrom(0), 0, "behind it is still free");
+});
+
+test("claiming again replaces the earlier claim rather than adding to it", () => {
+  // A run moved forward past ready material states its new stretch; if the two
+  // accumulated, the ground it has left would stay unavailable for ever.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 0, 20);
+  map.claim(runA, 50, 70);
+  assert.equal(map.stateOf(10), "free");
+  assert.equal(map.stateOf(60), "making");
+});
+
+test("the covered stretch ahead is measured, which is what prices a move", () => {
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  const runB = aRun();
+  for (let index = 10; index <= 24; index += 1) {
+    map.markReady(index);
+  }
+  map.claim(runB, 25, 30);
+  // Ready 10..24 then another run's 25..30, so fifteen plus six.
+  assert.equal(map.coveredRunFrom(10, runA), 21);
+  assert.equal(map.firstGapFrom(10), 31);
+});
+
+test("a run's own claim is not counted as somebody else's coverage", () => {
+  // Otherwise a run would read its own stretch as a reason to move off it.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 10, 30);
+  assert.equal(map.coveredRunFrom(10, runA), 0);
+});
+
+test("nothing free ahead answers null rather than a number past the end", () => {
+  const map = new CoverageMap({ segmentCount: 5 });
+  map.setReady([0, 1, 2, 3, 4]);
+  assert.equal(map.firstGapFrom(0), null);
+});
+
+test("a file that has gone stops being ready", () => {
+  // THE CHECK THE FIELD FAILURE OF 2026-09-07 NEEDED. Readiness used to
+  // accumulate: a number told once stayed ready for the life of the process
+  // however its file ended, so the map claimed a whole film that was not there,
+  // the plan scored every arrangement as perfect and took the only encoder away.
+  const map = new CoverageMap({ segmentCount: 10 });
+  map.setReady([3, 4]);
+  assert.equal(map.stateOf(4), "ready");
+  map.setReady([3]);
+  assert.equal(map.stateOf(4), "free", "the picture is replaced, not added to");
+  assert.equal(map.stateOf(3), "ready", "and what is still there stays");
+});
+
+test("the whole picture is replaced, so nothing survives that the disk has lost", () => {
+  const map = new CoverageMap({ segmentCount: 500 });
+  for (let index = 0; index < 500; index += 1) {
+    map.markReady(index);
+  }
+  assert.equal(map.stats().ready, 500);
+  map.setReady([]);
+  assert.equal(map.stats().ready, 0, "an empty directory is an empty map");
+  assert.equal(map.firstGapFrom(0), 0, "and the first gap is the beginning again");
+});
+
+test("a run's own claim does not hide the gap it is trying to move into", () => {
+  // Found by the plan's own checks: a run that had claimed the rest of the film
+  // — which is what every run did before ends existed — could find no gap
+  // anywhere, so it was stopped instead of moved.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 0, 99);
+  map.setReady([10, 11, 12]);
+  assert.equal(map.firstGapFrom(10, 90), null, "to anybody else its ground is taken");
+  assert.equal(map.firstGapFrom(10, 90, runA), 13, "to itself the ground beyond is a gap");
+});
+
+test("the free stretch ahead is measured, which is what gives a run its end", () => {
+  // A run handed the whole rest of the film would drive through the stretch
+  // another run is making. Handed the free stretch, it stops where the covered
+  // material begins.
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runB = aRun();
+  map.claim(runB, 30, 60);
+  assert.equal(map.freeRunFrom(10), 20, "free from 10 up to 29");
+  map.markReady(15);
+  assert.equal(map.freeRunFrom(10), 5, "a ready segment ends the free stretch too");
+  assert.equal(map.freeRunFrom(15), 0, "a number that is not free has no free stretch");
+});
+
+test("a run's own claim does not end its own free stretch", () => {
+  const map = new CoverageMap({ segmentCount: 100 });
+  const runA = aRun();
+  map.claim(runA, 10, 40);
+  assert.equal(map.freeRunFrom(10, runA), 90, "its own ground is still its to fill");
+  assert.equal(map.freeRunFrom(10), 0, "to anybody else it is taken");
+});
+
+test("with the length unknown, a gap search needs its own bound", () => {
+  const map = new CoverageMap();
+  assert.equal(map.firstGapFrom(0), null, "no length and no bound answers nothing");
+  assert.equal(map.firstGapFrom(0, 3), 0);
+});
+
+test("with the length unknown, the free stretch is answered without walking to it", () => {
+  // What this pins: on the addon host, 2026-09-05, a map with no length walked
+  // one number at a time to MAX_SAFE_INTEGER, scanning every claim at each step.
+  // The main thread spun at 100% from the look-ahead timer and the proxy stopped
+  // answering anything, its own log included. The length was missing because the
+  // field naming it had moved to the timeline and three readers were left on the
+  // old name — but this walk must not be able to do that even when it is.
+  //
+  // This check cannot FAIL against the old code — a synchronous walk cannot be
+  // interrupted by the runner, so it would hang the whole run instead, which is
+  // worse than no check. What it pins is the contract that replaced the walk:
+  // the answer comes from what the map holds.
+  const map = new CoverageMap();
+
+  assert.equal(map.freeRunFrom(0), Number.POSITIVE_INFINITY, "nothing is covered, so nothing bounds it");
+
+  const run = aRun();
+  map.claim(run, 500, 900);
+  assert.equal(map.freeRunFrom(0), 500, "and a claim ahead is where the free stretch ends");
+  assert.equal(map.freeRunFrom(0, run), Number.POSITIVE_INFINITY, "its own claim does not bound it");
+
+  map.markReady(200);
+  assert.equal(map.freeRunFrom(0), 200, "so is a segment somebody has already made");
+});