@thoughtspot/visual-embed-sdk 1.44.1 → 1.44.3

package/src/embed/embed.spec.ts

@@ -1,13 +1,18 @@
 import { logger } from '../utils/logger';
 import {
     init, AuthType, SearchEmbed, EmbedEvent,
+    RuntimeFilterOp,
+    Action,
 } from '../index';
 import {
     EVENT_WAIT_TIME,
     executeAfterWait,
+    expectUrlToHaveParamsWithValues,
     getDocumentBody,
     getIFrameEl,
+    getIFrameSrc,
     getRootEl,
+    postMessageToParent,
 } from '../test/test-utils';
 import * as authInstance from '../auth';
 
@@ -24,8 +29,8 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    spyOn(window, 'alert');
-    jest.spyOn(authInstance, 'postLoginService').mockResolvedValue(true);
+    jest.spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
 });
 
 describe('test view config', () => {
@@ -52,4 +57,119 @@ describe('test view config', () => {
             expect(iframe.style.height).toBe(`${height}px`);
         });
     });
+    
+    test('should pass hideResults parameter when configured', async () => {
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            hideResults: true,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expectUrlToHaveParamsWithValues(iframeSrc, {
+                hideResult: true,
+            });
+        });
+    });
+
+    test('should pass forceTable parameter when configured', async () => {
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            forceTable: true,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expectUrlToHaveParamsWithValues(iframeSrc, {
+                forceTable: true,
+            });
+        });
+    });
+
+    test('should pass enableSearchAssist parameter when configured', async () => {
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            enableSearchAssist: true,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expectUrlToHaveParamsWithValues(iframeSrc, {
+                enableSearchAssist: true,
+            });
+        });
+    });
+
+    test('should pass hideSearchBar parameter when configured', async () => {
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            hideSearchBar: true,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expectUrlToHaveParamsWithValues(iframeSrc, {
+                hideSearchBar: true,
+            });
+        });
+    });
+
+    test('should register and trigger event listeners', async () => {
+        const searchEmbed = new SearchEmbed(getRootEl(), defaultViewConfig);
+        const mockCallback = jest.fn();
+
+        searchEmbed.on(EmbedEvent.Load, mockCallback);
+        await searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframe = getIFrameEl();
+            postMessageToParent(iframe.contentWindow, {
+                type: EmbedEvent.Load,
+            });
+        });
+
+        await executeAfterWait(() => {
+            expect(mockCallback).toHaveBeenCalled();
+        }, EVENT_WAIT_TIME);
+    });
+
+    test('should pass disabledActions parameter when configured', async () => {
+        const disabledActions = [Action.Download, Action.Share];
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            disabledActions,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expect(iframeSrc).toContain('disableAction');
+        });
+    });
+
+    test('should pass runtime filters when configured', async () => {
+        const runtimeFilters = [
+            {
+                columnName: 'revenue',
+                operator: RuntimeFilterOp.GT,
+                values: [1000],
+            },
+        ];
+        const searchEmbed = new SearchEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            runtimeFilters,
+        });
+        searchEmbed.render();
+
+        await executeAfterWait(() => {
+            const iframeSrc = getIFrameSrc();
+            expect(iframeSrc).toContain('col1=revenue');
+            expect(iframeSrc).toContain('op1=GT');
+            expect(iframeSrc).toContain('val1=1000');
+        });
+    });
 });

package/src/embed/events.spec.ts

@@ -36,8 +36,8 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    spyOn(window, 'alert');
-    jest.spyOn(authInstance, 'postLoginService').mockReturnValue(true);
+    jest.spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
 });
 
 describe('test communication between host app and ThoughtSpot', () => {

package/src/embed/hostEventClient/host-event-client.spec.ts

@@ -1,5 +1,5 @@
 import { getIFrameEl, getRootEl } from '../../test/test-utils';
-import { HostEvent } from '../../types';
+import { AuthType, HostEvent } from '../../types';
 import { processTrigger } from '../../utils/processTrigger';
 import * as EmbedConfigService from '../embedConfig';
 import {
@@ -23,7 +23,7 @@ const createHostEventClient = () => {
 describe('HostEventClient', () => {
     const mockThoughtSpotHost = 'http://localhost';
     beforeEach(() => {
-        jest.spyOn(EmbedConfigService, 'getEmbedConfig').mockReturnValue({ thoughtSpotHost: mockThoughtSpotHost });
+        jest.spyOn(EmbedConfigService, 'getEmbedConfig').mockReturnValue({ thoughtSpotHost: mockThoughtSpotHost, authType: AuthType.None } as any);
     });
 
     afterEach(() => {

package/src/embed/liveboard.spec.ts

@@ -27,6 +27,7 @@ import * as processTriggerInstance from '../utils/processTrigger';
 import * as auth from '../auth';
 import * as previewService from '../utils/graphql/preview-service';
 import * as SessionInfoService from '../utils/sessionInfoService';
+import { logger } from '../utils/logger';
 
 const defaultViewConfig = {
     frameParams: {
@@ -57,7 +58,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve({}));
+    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
 });
 
 describe('Liveboard/viz embed tests', () => {
@@ -407,6 +408,70 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
+    test('Should add showMaskedFilterChip flag set to true to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            showMaskedFilterChip: true,
+        } as LiveboardViewConfig);
+
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&showMaskedFilterChip=true${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
+    test('Should add showMaskedFilterChip flag set to false to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            showMaskedFilterChip: false,
+        } as LiveboardViewConfig);
+
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&showMaskedFilterChip=false${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
+    test('Should add isLiveboardMasterpiecesEnabled flag set to true to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            isLiveboardMasterpiecesEnabled: true,
+        } as LiveboardViewConfig);
+
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isLiveboardMasterpiecesEnabled=true${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
+    test('Should add isLiveboardMasterpiecesEnabled flag set to false to the iframe src', async () => {
+        const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            liveboardId,
+            isLiveboardMasterpiecesEnabled: false,
+        } as LiveboardViewConfig);
+
+        liveboardEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true${defaultParams}&isLiveboardMasterpiecesEnabled=false${prefixParams}#/embed/viz/${liveboardId}`,
+            );
+        });
+    });
+
     test('Should add hideIrrelevantFiltersAtTabLevel flag to the iframe src', async () => {
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             ...defaultViewConfig,
@@ -679,7 +744,7 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
     test('should process the trigger, for vizEmbed', async () => {
-        const mockProcessTrigger = spyOn(processTriggerInstance, 'processTrigger');
+        const mockProcessTrigger = jest.spyOn(processTriggerInstance, 'processTrigger').mockImplementation(jest.fn());
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
             enableVizTransformations: true,
             ...defaultViewConfig,
@@ -689,7 +754,7 @@ describe('Liveboard/viz embed tests', () => {
         liveboardEmbed.render();
         await executeAfterWait(async () => {
             await liveboardEmbed.trigger(HostEvent.Pin);
-            expect(mockProcessTrigger).toBeCalled();
+            expect(mockProcessTrigger).toHaveBeenCalled();
         });
     });
 
@@ -756,7 +821,7 @@ describe('Liveboard/viz embed tests', () => {
         });
     });
 
-    test('navigateToLiveboard should trigger the navigate event with the correct path', async (done) => {
+    test('navigateToLiveboard should trigger the navigate event with the correct path', async () => {
         mockMessageChannel();
         // mock getSessionInfo
 
@@ -766,7 +831,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         const onSpy = jest.spyOn(liveboardEmbed, 'trigger');
         await liveboardEmbed.prerenderGeneric();
-        executeAfterWait(() => {
+        await executeAfterWait(() => {
             const iframe = getIFrameEl();
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
@@ -777,13 +842,12 @@ describe('Liveboard/viz embed tests', () => {
             liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
         });
 
-        executeAfterWait(() => {
+        await executeAfterWait(() => {
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
-            done();
         }, 1002);
     });
 
-    test('navigateToLiveboard with preRender', async (done) => {
+    test('navigateToLiveboard with preRender', async () => {
         mockMessageChannel();
 
         // mock getSessionInfo
@@ -793,7 +857,7 @@ describe('Liveboard/viz embed tests', () => {
             currentOrgId: 1,
             privileges: [],
             mixpanelToken: '1234567890',
-        });
+        } as any);
         mockGetSessionInfo();
 
         const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
@@ -802,7 +866,7 @@ describe('Liveboard/viz embed tests', () => {
         } as LiveboardViewConfig);
         const onSpy = jest.spyOn(liveboardEmbed, 'trigger');
         await liveboardEmbed.prerenderGeneric();
-        executeAfterWait(() => {
+        await executeAfterWait(() => {
             const iframe = getIFrameEl();
             postMessageToParent(iframe.contentWindow, {
                 type: EmbedEvent.APP_INIT,
@@ -811,10 +875,9 @@ describe('Liveboard/viz embed tests', () => {
                 type: EmbedEvent.AuthInit,
             });
         });
-        executeAfterWait(() => {
+        await executeAfterWait(() => {
             liveboardEmbed.navigateToLiveboard('lb1', 'viz1');
             expect(onSpy).toHaveBeenCalledWith(HostEvent.Navigate, 'embed/viz/lb1/viz1');
-            done();
         }, 1002);
     });
     test('should set runtime parametere values in url params', async () => {
@@ -894,7 +957,7 @@ describe('Liveboard/viz embed tests', () => {
             const result = liveboardEmbed.trigger(HostEvent.SetActiveTab, {
                 tabId: newActiveTabId,
             });
-            expect(mockProcessTrigger).not.toBeCalled();
+            expect(mockProcessTrigger).not.toHaveBeenCalled();
         });
     });
 
@@ -924,14 +987,14 @@ describe('Liveboard/viz embed tests', () => {
                 authType: AuthType.None,
             });
         });
-        test('it should preRender generic with liveboard id is not passed', async (done) => {
+        test('it should preRender generic with liveboard id is not passed', async () => {
             const consoleSpy = jest.spyOn(console, 'error');
             const libEmbed = new LiveboardEmbed(getRootEl(), {
                 preRenderId: 'testPreRender',
             });
             const prerenderGenericSpy = jest.spyOn(libEmbed, 'prerenderGeneric');
             await libEmbed.preRender();
-            executeAfterWait(() => {
+            await executeAfterWait(() => {
                 const iFrame = document.getElementById(
                     libEmbed.getPreRenderIds().child,
                 ) as HTMLIFrameElement;
@@ -941,8 +1004,6 @@ describe('Liveboard/viz embed tests', () => {
                 expect(iFrame.src).toMatch(/http:\/\/tshost\/.*&isLiveboardEmbed=true.*#$/);
 
                 expect(consoleSpy).toHaveBeenCalledTimes(0);
-
-                done();
             });
         });
 
@@ -990,7 +1051,7 @@ describe('Liveboard/viz embed tests', () => {
             });
         });
 
-        test('it should navigateToLiveboard with liveboard id is not passed with EmbedListenerReady event', async (done) => {
+        test('it should navigateToLiveboard with liveboard id is not passed with EmbedListenerReady event', async () => {
             mockMessageChannel();
             const consoleSpy = jest.spyOn(console, 'error');
             const testPreRenderId = 'testPreRender';
@@ -1035,7 +1096,7 @@ describe('Liveboard/viz embed tests', () => {
             const navigateToLiveboardSpy = jest.spyOn(newLibEmbed, 'navigateToLiveboard');
             await newLibEmbed.showPreRender();
 
-            executeAfterWait(() => {
+            await executeAfterWait(() => {
                 const iFrame = document.getElementById(
                     libEmbed.getPreRenderIds().child,
                 ) as HTMLIFrameElement;
@@ -1045,12 +1106,10 @@ describe('Liveboard/viz embed tests', () => {
                 expect(iFrame.src).toMatch(/http:\/\/tshost\/.*&isLiveboardEmbed=true.*#$/);
 
                 expect(consoleSpy).toHaveBeenCalledTimes(0);
-
-                done();
             });
         });
 
-        test('it should navigateToLiveboard with liveboard id is not passed with AuthInit event', async (done) => {
+        test('it should navigateToLiveboard with liveboard id is not passed with AuthInit event', async () => {
             mockMessageChannel();
             const consoleSpy = jest.spyOn(console, 'error');
             const testPreRenderId = 'testPreRender';
@@ -1104,7 +1163,6 @@ describe('Liveboard/viz embed tests', () => {
                 expect(navigateToLiveboardSpy).toHaveBeenCalledWith(testLiveboardId, 'testVizId', 'testActiveTabId');
                 expect(iFrame.src).toMatch(/http:\/\/tshost\/.*&isLiveboardEmbed=true.*#$/);
                 expect(consoleSpy).toHaveBeenCalledTimes(0);
-                done();
             }, 1005);
         });
 
@@ -1213,6 +1271,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             await liveboardEmbed.render();
@@ -1266,6 +1325,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             await liveboardEmbed.render();
@@ -1284,6 +1344,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             const mockTrigger = jest.spyOn(liveboardEmbed, 'trigger');
@@ -1316,6 +1377,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             const mockTrigger = jest.spyOn(liveboardEmbed, 'trigger');
@@ -1341,6 +1403,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             await liveboardEmbed.render();
@@ -1362,6 +1425,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             await liveboardEmbed.render();
@@ -1390,6 +1454,7 @@ describe('Liveboard/viz embed tests', () => {
                 liveboardId,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as LiveboardViewConfig);
 
             // Set the iframe before render
@@ -1448,7 +1513,7 @@ describe('Liveboard/viz embed tests', () => {
                 ...defaultViewConfig,
             });
 
-            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as not loaded initially
             liveboardEmbed.isEmbedContainerLoaded = false;
@@ -1480,7 +1545,7 @@ describe('Liveboard/viz embed tests', () => {
             };
 
             jest.spyOn(liveboardEmbed as any, 'getPreRenderObj').mockReturnValue(mockPreRenderObj as any);
-            jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as not loaded initially
             liveboardEmbed.isEmbedContainerLoaded = false;
@@ -1508,7 +1573,7 @@ describe('Liveboard/viz embed tests', () => {
                 ...defaultViewConfig,
             });
 
-            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as already loaded
             liveboardEmbed.isEmbedContainerLoaded = true;
@@ -1529,7 +1594,7 @@ describe('Liveboard/viz embed tests', () => {
             });
 
             jest.spyOn(liveboardEmbed as any, 'getPreRenderObj').mockReturnValue(null);
-            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as not loaded initially
             liveboardEmbed.isEmbedContainerLoaded = false;
@@ -1557,7 +1622,7 @@ describe('Liveboard/viz embed tests', () => {
                 ...defaultViewConfig,
             });
 
-            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as already loaded
             liveboardEmbed.isEmbedContainerLoaded = true;
@@ -1575,7 +1640,7 @@ describe('Liveboard/viz embed tests', () => {
                 ...defaultViewConfig,
             });
 
-            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockResolvedValue(undefined);
+            const navigateToLiveboardSpy = jest.spyOn(liveboardEmbed, 'navigateToLiveboard').mockImplementation(() => Promise.resolve(undefined));
 
             // Mock embed container as already loaded
             liveboardEmbed.isEmbedContainerLoaded = true;
@@ -1587,4 +1652,47 @@ describe('Liveboard/viz embed tests', () => {
             expect(navigateToLiveboardSpy).toHaveBeenCalledWith(liveboardId, undefined, undefined);
         });
     });
+
+    describe('Liveboard Embed Default Height and Minimum Height Handling', () => {
+        test('should set default height to 800 when minimum height is provided', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                ...defaultViewConfig,
+                fullHeight: true,
+                defaultHeight: 700,
+                minimumHeight: 800,
+            });
+            await liveboardEmbed.render();
+            expect(liveboardEmbed['defaultHeight']).toBe(800);
+        });
+        test('should set default height to 700 when default height is provided', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                ...defaultViewConfig,
+                fullHeight: true,
+                defaultHeight: 700,
+            });
+            await liveboardEmbed.render();
+            expect(liveboardEmbed['defaultHeight']).toBe(700);
+        });
+        test('should set default height to 800 when minimum height is provided but default height is not', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                ...defaultViewConfig,
+                fullHeight: true,
+                minimumHeight: 800,
+            });
+            await liveboardEmbed.render();
+            expect(liveboardEmbed['defaultHeight']).toBe(800);
+        });
+        test('should set default height to 500 when neither default height nor minimum height is provided', async () => {
+            const liveboardEmbed = new LiveboardEmbed(getRootEl(), {
+                liveboardId,
+                ...defaultViewConfig,
+                fullHeight: true,
+            });
+            await liveboardEmbed.render();
+            expect(liveboardEmbed['defaultHeight']).toBe(500);
+        });
+    });
 });

package/src/embed/liveboard.ts

@@ -20,8 +20,10 @@ import {
     SearchLiveboardCommonViewConfig as LiveboardOtherViewConfig,
     BaseViewConfig,
     LiveboardAppEmbedViewConfig,
+    ErrorDetailsTypes,
+    EmbedErrorCodes,
 } from '../types';
-import { calculateVisibleElementData, getQueryParamString, isUndefined } from '../utils';
+import { calculateVisibleElementData, getQueryParamString, isUndefined, isValidCssMargin } from '../utils';
 import { getAuthPromise } from './base';
 import { TsEmbed, V1Embed } from './ts-embed';
 import { addPreviewStylesIfNotPresent } from '../utils/global-styles';
@@ -65,6 +67,7 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * Supported embed types: `LiveboardEmbed`
      * @version SDK: 1.5.0 | ThoughtSpot: ts7.oct.cl, 7.2.1
      * @default 500
+     * @deprecated Use `minimumHeight` instead.
      * @example
      * ```js
      * const embed = new LiveboardEmbed('#embed', {
@@ -75,6 +78,23 @@ export interface LiveboardViewConfig extends BaseViewConfig, LiveboardOtherViewC
      * ```
      */
     defaultHeight?: number;
+    /**
+     * This is the minimum height (in pixels) for a full-height Liveboard.
+     * Setting this height helps resolve issues with empty Liveboards and
+     * other screens navigable from a Liveboard.
+     *
+     * @version SDK: 1.44.2 | ThoughtSpot: 26.0.2.cl
+     * @default 500
+     * @example
+     * ```js
+     * const embed = new LiveboardEmbed('#embed', {
+     *   ... // other liveboard view config
+     *   fullHeight: true,
+     *   minimumHeight: 600,
+     * });
+     * ```
+     */
+    minimumHeight?: number;
     /**
      * @Deprecated If set to true, the context menu in visualizations will be enabled.
      * @example
@@ -467,6 +487,7 @@ export class LiveboardEmbed extends V1Embed {
             enableVizTransformations,
             fullHeight,
             defaultHeight,
+            minimumHeight,
             visibleVizs,
             liveboardV2,
             vizId,
@@ -480,6 +501,8 @@ export class LiveboardEmbed extends V1Embed {
             showLiveboardVerifiedBadge = true,
             showLiveboardReverifyBanner = true,
             hideIrrelevantChipsInLiveboardTabs = false,
+            showMaskedFilterChip = false,
+            isLiveboardMasterpiecesEnabled = false,
             isEnhancedFilterInteractivityEnabled = false,
             enableAskSage,
             enable2ColumnLayout,
@@ -505,12 +528,12 @@ export class LiveboardEmbed extends V1Embed {
             params[Param.fullHeight] = true;
             if (this.viewConfig.lazyLoadingForFullHeight) {
                 params[Param.IsLazyLoadingForEmbedEnabled] = true;
-                params[Param.RootMarginForLazyLoad] = this.viewConfig.lazyLoadingMargin;
+                if (isValidCssMargin(this.viewConfig.lazyLoadingMargin)) {
+                    params[Param.RootMarginForLazyLoad] = this.viewConfig.lazyLoadingMargin;
+                }
             }
         }
-        if (defaultHeight) {
-            this.defaultHeight = defaultHeight;
-        }
+        this.defaultHeight = minimumHeight || defaultHeight || this.defaultHeight;
         if (enableVizTransformations !== undefined) {
             params[Param.EnableVizTransformations] = enableVizTransformations.toString();
         }
@@ -589,6 +612,8 @@ export class LiveboardEmbed extends V1Embed {
         params[Param.ShowLiveboardVerifiedBadge] = showLiveboardVerifiedBadge;
         params[Param.ShowLiveboardReverifyBanner] = showLiveboardReverifyBanner;
         params[Param.HideIrrelevantFiltersInTab] = hideIrrelevantChipsInLiveboardTabs;
+        params[Param.ShowMaskedFilterChip] = showMaskedFilterChip;
+        params[Param.IsLiveboardMasterpiecesEnabled] = isLiveboardMasterpiecesEnabled;
         params[Param.IsEnhancedFilterInteractivityEnabled] = isEnhancedFilterInteractivityEnabled;
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.EnableCustomColumnGroups] = enableCustomColumnGroups;
@@ -642,7 +667,12 @@ export class LiveboardEmbed extends V1Embed {
         const liveboardId = this.viewConfig.liveboardId ?? this.viewConfig.pinboardId;
 
         if (!liveboardId) {
-            this.handleError(ERROR_MESSAGE.LIVEBOARD_VIZ_ID_VALIDATION);
+            this.handleError({
+                errorType: ErrorDetailsTypes.VALIDATION_ERROR,
+                message: ERROR_MESSAGE.LIVEBOARD_VIZ_ID_VALIDATION,
+                code: EmbedErrorCodes.LIVEBOARD_ID_MISSING,
+                error: ERROR_MESSAGE.LIVEBOARD_VIZ_ID_VALIDATION,
+            });
         }
         return `${this.getRootIframeSrc()}${this.getIframeSuffixSrc(
             liveboardId,

package/src/embed/pinboard.spec.ts

@@ -31,7 +31,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    jest.spyOn(auth, 'postLoginService').mockReturnValue(true);
+    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
 });
 
 describe('Pinboard/viz embed tests', () => {