@thoughtspot/visual-embed-sdk 1.44.1 → 1.44.3

package/src/embed/app.spec.ts

@@ -43,7 +43,7 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve({}));
+    jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
     (window as any).ResizeObserver =
         window.ResizeObserver ||
         jest.fn().mockImplementation(() => ({
@@ -542,6 +542,100 @@ describe('App embed tests', () => {
         });
     });
 
+    test('Should add showMaskedFilterChip true to the iframe src', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+            showMaskedFilterChip: true,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&showMaskedFilterChip=true${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('Should add showMaskedFilterChip false to the iframe src', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+            showMaskedFilterChip: false,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&showMaskedFilterChip=false${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('Should add default showMaskedFilterChip false when not specified', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&showMaskedFilterChip=false${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('Should add isLiveboardMasterpiecesEnabled true to the iframe src', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+            isLiveboardMasterpiecesEnabled: true,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&isLiveboardMasterpiecesEnabled=true${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('Should add isLiveboardMasterpiecesEnabled false to the iframe src', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+            isLiveboardMasterpiecesEnabled: false,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&isLiveboardMasterpiecesEnabled=false${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
+    test('Should add default isLiveboardMasterpiecesEnabled false when not specified', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+        } as AppViewConfig);
+
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&isLiveboardMasterpiecesEnabled=false${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
     test('Should add enableSearchAssist flagto the iframe src', async () => {
         const appEmbed = new AppEmbed(getRootEl(), {
             ...defaultViewConfig,
@@ -1036,13 +1130,13 @@ describe('App embed tests', () => {
         let embedHeightCallback: any = () => { };
         const onSpy = jest.spyOn(AppEmbed.prototype, 'on').mockImplementation((event, callback) => {
             if (event === EmbedEvent.RouteChange) {
-                callback({ data: { currentPath: '/answers' } }, jest.fn());
+                callback({ type: EmbedEvent.RouteChange, data: { currentPath: '/answers' } } as any, jest.fn());
             }
             if (event === EmbedEvent.EmbedHeight) {
                 embedHeightCallback = callback;
             }
             if (event === EmbedEvent.EmbedIframeCenter) {
-                callback({}, jest.fn());
+                callback({ type: EmbedEvent.EmbedIframeCenter, data: {} } as any, jest.fn());
             }
             return null;
         });
@@ -1052,6 +1146,7 @@ describe('App embed tests', () => {
             ...defaultViewConfig,
             fullHeight: true,
             lazyLoadingForFullHeight: true,
+            lazyLoadingMargin: '10px',
         } as AppViewConfig);
 
         // Set the iframe before render
@@ -1133,7 +1228,7 @@ describe('App embed tests', () => {
                 },
             });
             await appEmbed.render();
-            spyOn(logger, 'warn');
+            jest.spyOn(logger, 'warn').mockImplementation(() => {});
             appEmbed.navigateToPage(-1);
             expect(logger.warn).toHaveBeenCalledWith(
                 'Path can only by a string when triggered without noReload',
@@ -1141,7 +1236,7 @@ describe('App embed tests', () => {
         });
 
         test('navigateToPage function use before render', async () => {
-            spyOn(logger, 'log');
+            jest.spyOn(logger, 'log').mockImplementation(() => {});
             const appEmbed = new AppEmbed(getRootEl(), {
                 frameParams: {
                     width: '100%',
@@ -1223,6 +1318,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             // Set the iframe before render
@@ -1299,6 +1395,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             const mockTrigger = jest.spyOn(appEmbed, 'trigger');
@@ -1331,6 +1428,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             const mockTrigger = jest.spyOn(appEmbed, 'trigger');
@@ -1355,6 +1453,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             await appEmbed.render();
@@ -1375,6 +1474,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             await appEmbed.render();
@@ -1402,6 +1502,7 @@ describe('App embed tests', () => {
                 ...defaultViewConfig,
                 fullHeight: true,
                 lazyLoadingForFullHeight: true,
+                lazyLoadingMargin: '10px',
             } as AppViewConfig);
 
             // Set the iframe before render
@@ -1527,13 +1628,33 @@ describe('App embed tests', () => {
 
             await appEmbed.render();
             const mockEvent = {
-                data: 0, // This will make it use the scrollHeight
+                data: 0, // This will make it use the default height
                 type: EmbedEvent.EmbedHeight,
             };
             appEmbed.updateIFrameHeight(mockEvent);
 
-            // Should use the scrollHeight
+            // Should use the default height
             expect(mockIFrame.style.height).toBe('500px');
         });
     });
 });
+
+describe('App Embed Default Height and Minimum Height Handling', () => {
+    test('should set default height to 500 when neither default height nor minimum height is provided', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            fullHeight: true,
+        } as AppViewConfig);
+        await appEmbed.render();
+        expect(appEmbed['defaultHeight']).toBe(500);
+    });
+    test('should set default height to 700 when default height is provided', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            fullHeight: true,
+            minimumHeight: 700,
+        } as AppViewConfig);
+        await appEmbed.render();
+        expect(appEmbed['defaultHeight']).toBe(700);
+    });
+});

package/src/embed/app.ts

@@ -9,7 +9,7 @@
  */
 
 import { logger } from '../utils/logger';
-import { calculateVisibleElementData, getQueryParamString, isUndefined } from '../utils';
+import { calculateVisibleElementData, getQueryParamString, isUndefined, isValidCssMargin } from '../utils';
 import {
     Param,
     DOMSelector,
@@ -626,6 +626,23 @@ export interface AppViewConfig extends AllEmbedViewConfig {
      * @version SDK: 1.45.0 | ThoughtSpot: 26.2.0.cl
      */
     updatedSpotterChatPrompt?: boolean;
+    /**
+     * This is the minimum height (in pixels) for a full-height App.
+     * Setting this height helps resolve issues with empty Apps and
+     * other screens navigable from an App.
+     *
+     * @version SDK: 1.44.2 | ThoughtSpot: 26.0.2.cl
+     * @default 500
+     * @example
+     * ```js
+     * const embed = new AppEmbed('#embed', {
+     *   ... // other app view config
+     *   fullHeight: true,
+     *   minimumHeight: 600,
+     * });
+     * ```
+     */
+    minimumHeight?: number;
 }
 
 /**
@@ -635,7 +652,7 @@ export interface AppViewConfig extends AllEmbedViewConfig {
 export class AppEmbed extends V1Embed {
     protected viewConfig: AppViewConfig;
 
-    private defaultHeight = '100%';
+    private defaultHeight = 500;
 
 
     constructor(domSelector: DOMSelector, viewConfig: AppViewConfig) {
@@ -672,6 +689,8 @@ export class AppEmbed extends V1Embed {
             hideLiveboardHeader = false,
             showLiveboardTitle = true,
             showLiveboardDescription = true,
+            showMaskedFilterChip = false,
+            isLiveboardMasterpiecesEnabled = false,
             hideHomepageLeftNav = false,
             modularHomeExperience = false,
             isLiveboardHeaderSticky = true,
@@ -697,6 +716,7 @@ export class AppEmbed extends V1Embed {
             isCentralizedLiveboardFilterUXEnabled = false,
             isLinkParametersEnabled,
             updatedSpotterChatPrompt,
+            minimumHeight,
         } = this.viewConfig;
 
         let params: any = {};
@@ -707,6 +727,8 @@ export class AppEmbed extends V1Embed {
         params[Param.HideLiveboardHeader] = hideLiveboardHeader;
         params[Param.ShowLiveboardTitle] = showLiveboardTitle;
         params[Param.ShowLiveboardDescription] = !!showLiveboardDescription;
+        params[Param.ShowMaskedFilterChip] = showMaskedFilterChip;
+        params[Param.IsLiveboardMasterpiecesEnabled] = isLiveboardMasterpiecesEnabled;
         params[Param.LiveboardHeaderSticky] = isLiveboardHeaderSticky;
         params[Param.IsFullAppEmbed] = true;
         params[Param.LiveboardHeaderV2] = isLiveboardCompactHeaderEnabled;
@@ -739,7 +761,9 @@ export class AppEmbed extends V1Embed {
             params[Param.fullHeight] = true;
             if (this.viewConfig.lazyLoadingForFullHeight) {
                 params[Param.IsLazyLoadingForEmbedEnabled] = true;
-                params[Param.RootMarginForLazyLoad] = this.viewConfig.lazyLoadingMargin;
+                if (isValidCssMargin(this.viewConfig.lazyLoadingMargin)) {
+                    params[Param.RootMarginForLazyLoad] = this.viewConfig.lazyLoadingMargin;
+                }
             }
         }
 
@@ -799,6 +823,8 @@ export class AppEmbed extends V1Embed {
             ] = isCentralizedLiveboardFilterUXEnabled;
         }
 
+        this.defaultHeight = minimumHeight || this.defaultHeight;
+
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.HideHomepageLeftNav] = hideHomepageLeftNav;
         params[Param.ModularHomeExperienceEnabled] = modularHomeExperience;
@@ -900,7 +926,7 @@ export class AppEmbed extends V1Embed {
      * @param data The event payload
      */
     protected updateIFrameHeight = (data: MessagePayload) => {
-        this.setIFrameHeight(Math.max(data.data, this.iFrame?.scrollHeight));
+        this.setIFrameHeight(Math.max(data.data, this.defaultHeight));
         this.sendFullHeightLazyLoadData();
     };
 

package/src/embed/base.spec.ts

@@ -11,7 +11,7 @@ import * as base from './base';
 import * as embedConfigInstance from './embedConfig';
 import * as resetService from '../utils/resetServices';
 import * as processTrigger from '../utils/processTrigger';
-import { reloadIframe } from './base';
+import { createAndSetInitPromise, getInitPromise, getIsInitCalled, reloadIframe } from './base';
 
 import {
     executeAfterWait,
@@ -22,6 +22,7 @@ import {
 } from '../test/test-utils';
 import * as tokenizedFetchInstance from '../tokenizedFetch';
 import { logger } from '../utils/logger';
+import { ERROR_MESSAGE } from '../errors';
 
 const thoughtSpotHost = 'tshost';
 let authEE: EventEmitter;
@@ -32,14 +33,14 @@ describe('Base TS Embed', () => {
             thoughtSpotHost,
             authType: index.AuthType.None,
         }) as EventEmitter;
-        jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve({}));
+        jest.spyOn(auth, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
     });
 
     beforeEach(() => {
         document.body.innerHTML = getDocumentBody();
     });
 
-    test('Should show an alert when third party cookie access is blocked', (done) => {
+    test('Should show an alert when third party cookie access is blocked', () => {
         const tsEmbed = new index.SearchEmbed(getRootEl(), {});
         const iFrame: any = document.createElement('div');
         iFrame.contentWindow = null;
@@ -59,18 +60,17 @@ describe('Base TS Embed', () => {
         jest.spyOn(window, 'alert').mockImplementation(() => undefined);
         authEE.on(auth.AuthStatus.FAILURE, (reason) => {
             expect(reason).toEqual(auth.AuthFailureType.NO_COOKIE_ACCESS);
-            expect(window.alert).toBeCalledWith(
+            expect(window.alert).toHaveBeenCalledWith(
                 'Third-party cookie access is blocked on this browser. Please allow third-party cookies for this to work properly. \nYou can use `suppressNoCookieAccessAlert` to suppress this message.',
             );
-            done();
         });
     });
 
-    test('Should ignore cookie blocked alert if ignoreNoCookieAccess is true', async (done) => {
+    test('Should ignore cookie blocked alert if ignoreNoCookieAccess is true', async () => {
         jest.spyOn(window, 'fetch').mockResolvedValue({
             ok: true,
             json: jest.fn().mockResolvedValue({}),
-        });
+        } as any);
         const authEE = index.init({
             thoughtSpotHost,
             authType: index.AuthType.None,
@@ -96,7 +96,6 @@ describe('Base TS Embed', () => {
         authEE.on(auth.AuthStatus.FAILURE, (reason) => {
             expect(reason).toEqual(auth.AuthFailureType.NO_COOKIE_ACCESS);
             expect(window.alert).not.toHaveBeenCalled();
-            done();
         });
     });
 
@@ -104,7 +103,7 @@ describe('Base TS Embed', () => {
         jest.spyOn(window, 'fetch').mockResolvedValue({
             ok: true,
             json: jest.fn().mockResolvedValue({}),
-        });
+        } as any);
         index.init({
             thoughtSpotHost,
             authType: index.AuthType.None,
@@ -161,7 +160,7 @@ describe('Base TS Embed', () => {
         jest.spyOn(tokenizedFetchInstance, 'tokenizedFetch').mockResolvedValueOnce({
             ok: true,
             json: jest.fn().mockResolvedValue({}),
-        });
+        } as any);
         index.init({
             thoughtSpotHost,
             authType: index.AuthType.TrustedAuthTokenCookieless,
@@ -229,7 +228,7 @@ describe('Base TS Embed', () => {
         jest.spyOn(tokenizedFetchInstance, 'tokenizedFetch').mockResolvedValueOnce({
             ok: true,
             json: jest.fn().mockResolvedValue({}),
-        });
+        } as any);
         index.init({
             thoughtSpotHost,
             authType: index.AuthType.None,
@@ -388,7 +387,7 @@ describe('Base TS Embed', () => {
         });
     });
 
-    test('handleAuth notifies for SDK auth failure', (done) => {
+    test('handleAuth notifies for SDK auth failure', () => {
         jest.spyOn(auth, 'authenticate').mockResolvedValue(false);
         const authEmitter = index.init({
             thoughtSpotHost,
@@ -398,11 +397,10 @@ describe('Base TS Embed', () => {
         });
         authEmitter.on(auth.AuthStatus.FAILURE, (reason) => {
             expect(reason).toBe(auth.AuthFailureType.SDK);
-            done();
         });
     });
 
-    test('handleAuth notifies for SDK auth success', (done) => {
+    test('handleAuth notifies for SDK auth success', () => {
         jest.spyOn(auth, 'authenticate').mockResolvedValue(true);
         const failureCallback = jest.fn();
         const authEmitter = index.init({
@@ -414,16 +412,15 @@ describe('Base TS Embed', () => {
 
         authEmitter.on(auth.AuthStatus.FAILURE, failureCallback);
         authEmitter.on(auth.AuthStatus.SDK_SUCCESS, (...args) => {
-            expect(failureCallback).not.toBeCalled();
+            expect(failureCallback).not.toHaveBeenCalled();
             expect(args.length).toBe(0);
-            done();
         });
     });
 
     test('Logout method should disable autoLogin', () => {
         jest.spyOn(window, 'fetch').mockResolvedValueOnce({
             type: 'opaque',
-        });
+        } as any);
         index.init({
             thoughtSpotHost,
             authType: index.AuthType.None,
@@ -461,7 +458,7 @@ describe('Base TS Embed', () => {
             index.init({
                 authType: index.AuthType.None,
             } as EmbedConfig);
-        }).toThrowError();
+        }).toThrow();
     });
 
     test('config sanity, no username in trusted auth', () => {
@@ -470,7 +467,7 @@ describe('Base TS Embed', () => {
                 authType: index.AuthType.TrustedAuthToken,
                 thoughtSpotHost,
             } as EmbedConfig);
-        }).toThrowError();
+        }).toThrow();
     });
 
     test('config sanity, no authEndpoint and getAuthToken', () => {
@@ -480,7 +477,7 @@ describe('Base TS Embed', () => {
                 thoughtSpotHost,
                 username: 'test',
             });
-        }).toThrowError();
+        }).toThrow();
     });
     test('config backward compat, should assign inPopup when noRedirect is set', () => {
         index.init({
@@ -532,6 +529,83 @@ describe('Init tests', () => {
             thoughtSpotHost,
             authType: index.AuthType.None,
         });
-        expect(resetService.resetAllCachedServices).toBeCalled();
+        expect(resetService.resetAllCachedServices).toHaveBeenCalled();
     });
 });
+
+describe('Init Promise Functions', () => {
+    describe('SSR environment handling', () => {
+        let originalWindow: typeof globalThis.window;
+
+        beforeEach(() => {
+            originalWindow = global.window;
+            });
+
+        afterEach(() => {
+            global.window = originalWindow;
+        });
+
+        test('createAndSetInitPromise should log error in SSR environment', () => {
+            delete global.window;
+            
+            createAndSetInitPromise();
+            
+            expect(logger.error).toHaveBeenCalledWith(
+                ERROR_MESSAGE.SSR_ENVIRONMENT_ERROR
+            );
+        });
+
+        test('init should log error and return null in SSR environment', () => {
+            delete global.window;
+            
+            const result = base.init({
+                thoughtSpotHost: 'tshost',
+                authType: index.AuthType.None,
+            });
+            
+            expect(logger.error).toHaveBeenCalledWith(
+                ERROR_MESSAGE.SSR_ENVIRONMENT_ERROR
+            );
+            expect(result).toBeNull();
+        });
+    });
+    beforeEach(() => {
+        base.reset();
+        (window as any)._tsEmbedSDK = {};
+        createAndSetInitPromise();
+    });
+
+    test('getIsInitCalled should return false before init is called', () => {
+        expect(getIsInitCalled()).toBe(false);
+    });
+
+    test('getIsInitCalled should return true after init is called', () => {
+        base.init({
+            thoughtSpotHost: 'tshost',
+            authType: index.AuthType.None,
+        });
+        expect(getIsInitCalled()).toBe(true);
+    });
+
+    test('getInitPromise should return a promise', () => {
+        const promise = getInitPromise();
+        expect(promise).toBeInstanceOf(Promise);
+    });
+
+    test('getInitPromise should resolve with authEE after init is called', async () => {
+        const initPromise = getInitPromise();
+        const authEE = base.init({
+            thoughtSpotHost: 'tshost',
+            authType: index.AuthType.None,
+        });
+        const resolvedValue = await initPromise;
+        expect(resolvedValue).toBe(authEE);
+    });
+
+    test('createAndSetInitPromise should not override existing promise if ignoreIfAlreadyExists', () => {
+        const firstPromise = getInitPromise();
+        createAndSetInitPromise();
+        const secondPromise = getInitPromise();
+        expect(firstPromise).toBe(secondPromise);
+    });
+});

package/src/embed/base.ts

@@ -33,9 +33,10 @@ import {
 import '../utils/with-resolvers-polyfill';
 import { uploadMixpanelEvent, MIXPANEL_EVENT } from '../mixpanel-service';
 import { getEmbedConfig, setEmbedConfig } from './embedConfig';
-import { getQueryParamString, getValueFromWindow, storeValueInWindow } from '../utils';
+import { getQueryParamString, getValueFromWindow, isWindowUndefined, storeValueInWindow } from '../utils';
 import { resetAllCachedServices } from '../utils/resetServices';
 import { reload } from '../utils/processTrigger';
+import { ERROR_MESSAGE } from '../errors';
 
 const CONFIG_DEFAULTS: Partial<EmbedConfig> = {
     loginFailedMessage: 'Not logged in',
@@ -192,6 +193,7 @@ type InitFlagStore = {
 const initFlagKey = 'initFlagKey';
 
 export const createAndSetInitPromise = (): void => {
+    if (isWindowUndefined()) return;
     const {
         promise: initPromise,
         resolve: initPromiseResolve,
@@ -238,7 +240,8 @@ export const getIsInitCalled = (): boolean => !!getValueFromWindow(initFlagKey)?
  * @version SDK: 1.0.0 | ThoughtSpot ts7.april.cl, 7.2.1
  * @group Authentication / Init
  */
-export const init = (embedConfig: EmbedConfig): AuthEventEmitter => {
+export const init = (embedConfig: EmbedConfig): AuthEventEmitter | null => {
+    if (isWindowUndefined()) return null;
     sanity(embedConfig);
     resetAllCachedServices();
     embedConfig = setEmbedConfig(

package/src/embed/bodyless-conversation.spec.ts

@@ -22,8 +22,8 @@ describe('SpotterAgentEmbed', () => {
             thoughtSpotHost,
             authType: AuthType.None,
         });
-        jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve({}));
-        spyOn(window, 'alert');
+        jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
+        jest.spyOn(window, 'alert').mockImplementation(() => undefined);
         document.body.innerHTML = getDocumentBody();
     });
 

package/src/embed/conversation.spec.ts

@@ -2,7 +2,7 @@ import { SpotterEmbed, SpotterEmbedViewConfig, ConversationEmbed } from './conve
 import { TsEmbed } from './ts-embed';
 import * as authInstance from '../auth';
 import { Action, init } from '../index';
-import { AuthType, Param, RuntimeFilterOp } from '../types';
+import { AuthType, Param, RuntimeFilterOp, ErrorDetailsTypes, EmbedErrorCodes  } from '../types';
 import {
     getDocumentBody,
     getIFrameSrc,
@@ -19,8 +19,8 @@ beforeAll(() => {
         thoughtSpotHost,
         authType: AuthType.None,
     });
-    jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve({}));
-    spyOn(window, 'alert');
+    jest.spyOn(authInstance, 'postLoginService').mockImplementation(() => Promise.resolve(undefined));
+    jest.spyOn(window, 'alert');
     document.body.innerHTML = getDocumentBody();
 });
 
@@ -120,7 +120,12 @@ describe('ConversationEmbed', () => {
         (conversationEmbed as any).handleError = jest.fn();
         await conversationEmbed.render();
         expect((conversationEmbed as any).handleError).toHaveBeenCalledWith(
-            ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+            {
+                errorType: ErrorDetailsTypes.VALIDATION_ERROR,
+                message: ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+                code: EmbedErrorCodes.WORKSHEET_ID_NOT_FOUND,
+                error: ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+            },
         );
     });
 

package/src/embed/conversation.ts

@@ -1,6 +1,6 @@
 import isUndefined from 'lodash/isUndefined';
 import { ERROR_MESSAGE } from '../errors';
-import { Param, BaseViewConfig, RuntimeFilter, RuntimeParameter } from '../types';
+import { Param, BaseViewConfig, RuntimeFilter, RuntimeParameter, ErrorDetailsTypes, EmbedErrorCodes } from '../types';
 import { TsEmbed } from './ts-embed';
 import { getQueryParamString, getFilterQuery, getRuntimeParameters } from '../utils';
 
@@ -246,7 +246,12 @@ export class SpotterEmbed extends TsEmbed {
         } = this.viewConfig;
 
         if (!worksheetId) {
-            this.handleError(ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND);
+            this.handleError({
+                errorType: ErrorDetailsTypes.VALIDATION_ERROR,
+                message: ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+                code: EmbedErrorCodes.WORKSHEET_ID_NOT_FOUND,
+                error: ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+            });
         }
         const queryParams = this.getBaseQueryParams();
         queryParams[Param.SpotterEnabled] = true;