@things-factory/sales-base 4.3.637 → 4.3.638

package/server/service/order-package-item/order-package-item-types.ts

@@ -1,4 +1,4 @@
-import { Field, Float, ID, InputType, Int, ObjectType } from 'type-graphql'
+import { Field, ID, InputType, Int, ObjectType } from 'type-graphql'
 
 import { OrderPackageItem } from './order-package-item'
 
@@ -9,12 +9,6 @@ export class NewOrderPackageItem {
 
   @Field({ nullable: true })
   status?: string
-
-  @Field(type => Float, { nullable: true })
-  releaseQty?: number
-
-  @Field(type => Float, { nullable: true })
-  packedQty?: number
 }
 
 @InputType()
@@ -25,12 +19,9 @@ export class OrderPackageItemPatch {
   @Field({ nullable: true })
   name?: string
 
-  @Field(type => Float, { nullable: true })
+  @Field({ nullable: true })
   releaseQty?: number
 
-  @Field(type => Float, { nullable: true })
-  packedQty?: number
-
   @Field({ nullable: true })
   status?: string
 
@@ -55,6 +46,6 @@ export class TrackingInformation {
   @Field(type => String)
   sku: string
 
-  @Field(type => Float)
+  @Field(type => String)
   releaseQty: number
 }

package/server/service/order-package-item/order-package-item.ts

@@ -70,35 +70,11 @@ export class OrderPackageItem {
   @Field({ nullable: true })
   status?: string
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   releaseQty: number
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   packedQty: number
 

package/server/service/order-product/order-product-types.ts

@@ -132,25 +132,25 @@ export class OrderProductPatch {
   @Field(type => Float, { nullable: true })
   unpackUomValue: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   adjustedPackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   actualPackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   unpackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   palletQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   actualPalletQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   adjustedPalletQty: number
 
   @Field({ nullable: true })
@@ -162,7 +162,7 @@ export class OrderProductPatch {
   @Field({ nullable: true })
   totalUomValue: string
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   releaseQty: number
 
   @Field(type => Float, { nullable: true })
@@ -282,37 +282,37 @@ export class NewOrderProduct {
   @Field(type => Float, { nullable: true })
   unpackUomValue: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   adjustedPackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   actualPackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   unpackQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   palletQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   actualPalletQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   adjustedPalletQty: number
 
   @Field({ nullable: true })
-  adjustedTotalUomValue: string
+  palletId: string
 
   @Field({ nullable: true })
-  palletId: string
+  adjustedTotalUomValue: string
 
   @Field({ nullable: true })
   totalUomValue: string
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   releaseQty: number
 
   @Field(type => Float, { nullable: true })

package/server/service/order-product/order-product.ts

@@ -254,101 +254,25 @@ export class OrderProduct {
   @Field({ nullable: true })
   adjustedUomValue: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
-  @Field({ nullable: true })
-  unpackQty: number
-
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column('float', { nullable: true })
   @Field({ nullable: true })
   unpackUomValue: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
-  @Field({ nullable: true })
+  @Column()
+  @Field()
   packQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   adjustedPackQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   actualPackQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column('float', { nullable: true })
   @Field({ nullable: true })
-  releaseUomValue: number
+  unpackQty: number
 
   @Column('float', { nullable: true })
   @Field({ nullable: true })
@@ -402,22 +326,14 @@ export class OrderProduct {
   @Field({ nullable: true })
   adjustedTotalUomValue: string
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   releaseQty: number
 
+  @Column({ nullable: true, type: 'float' })
+  @Field({ nullable: true })
+  releaseUomValue: number
+
   @Column({ nullable: true })
   @Field({ nullable: true })
   remark: string

package/server/service/order-tote-item/order-tote-item-types.ts

@@ -1,4 +1,4 @@
-import { Field, Float, InputType, Int, ObjectType } from 'type-graphql'
+import { Field, InputType, Int, ObjectType } from 'type-graphql'
 
 import { ObjectRef } from '@things-factory/shell'
 
@@ -30,7 +30,7 @@ export class NewOrderToteItem {
   @Field(type => ObjectRef, { nullable: true })
   orderTote: ObjectRef
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int)
   qty: number
 }
 
@@ -51,6 +51,6 @@ export class OrderToteItemPatch {
   @Field(type => ObjectRef, { nullable: true })
   orderTote: ObjectRef
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int)
   qty: number
 }

package/server/service/order-tote-item/order-tote-item.ts

@@ -47,18 +47,7 @@ export class OrderToteItem {
   @RelationId((orderToteItem: OrderToteItem) => orderToteItem.orderTote)
   orderToteId: string
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column('int')
   @Field({ nullable: true })
   qty?: number
 

package/server/service/others/other-types.ts

@@ -37,9 +37,6 @@ export class InventoryProductGroup {
   @Field({ nullable: true })
   productBrand: string
 
-  @Field({ nullable: true })
-  isInventoryDecimal: boolean
-
   @Field({ nullable: true })
   packingType: string
 

package/server/service/release-good/release-good-mutation.ts

@@ -65,40 +65,6 @@ import { editVas } from '../vas'
 import { ReleaseGood } from './release-good'
 import { bulkReleaseGoodsAvailableItemsFunction } from './release-good-query'
 
-// Utility function for safe decimal arithmetic
-function safeDecimalOperation(value1: number, value2: number, operation: 'add' | 'subtract' | 'multiply'): number {
-  // Convert to string with fixed precision to avoid floating point issues
-  const num1 = parseFloat(value1.toFixed(3))
-  const num2 = parseFloat(value2.toFixed(3))
-
-  let result: number
-  switch (operation) {
-    case 'add':
-      result = num1 + num2
-      break
-    case 'subtract':
-      result = num1 - num2
-      break
-    case 'multiply':
-      result = num1 * num2
-      break
-    default:
-      throw new Error('Invalid operation')
-  }
-
-  // Ensure result is within valid range and has correct precision
-  if (result < 0) {
-    throw new Error('Decimal value cannot be negative')
-  }
-
-  // Check if result exceeds maximum precision (10 digits total with 3 decimal places)
-  if (result > 9999999.999) {
-    throw new Error('Decimal value exceeds maximum allowed precision')
-  }
-
-  return parseFloat(result.toFixed(3))
-}
-
 @Resolver(ReleaseGood)
 export class ReleaseGoodMutation {
   @Directive('@privilege(category: "order_customer", privilege: "mutation")')
@@ -478,8 +444,8 @@ export async function deleteReleaseGood(tx: EntityManager, name: string, user: U
 
         await tx.getRepository(Inventory).save({
           ...oi.inventory,
-          lockedQty: safeDecimalOperation(oi.inventory.lockedQty, oi.releaseQty, 'subtract'),
-          lockedUomValue: safeDecimalOperation(oi.inventory.lockedUomValue, oi.releaseUomValue, 'subtract'),
+          lockedQty: oi.inventory.lockedQty - oi.releaseQty,
+          lockedUomValue: oi.inventory.lockedUomValue - oi.releaseUomValue,
           updater: user
         })
       }
@@ -840,12 +806,8 @@ export async function generateReleaseGoodFunction(
           pbSettings.forEach(pbs => {
             splitOI = {
               ...oi,
-              releaseQty: safeDecimalOperation(oi.releaseQty, pbs.bundleQty, 'multiply'),
-              releaseUomValue: safeDecimalOperation(
-                safeDecimalOperation(oi.releaseUomValue, pbs.bundleQty, 'multiply'),
-                pbs.product.primaryValue,
-                'multiply'
-              ),
+              releaseQty: oi.releaseQty * pbs.bundleQty,
+              releaseUomValue: oi.releaseUomValue * pbs.bundleQty * pbs.product.primaryValue,
               packingType: pbs.product.packingType,
               batchId: '',
               product: {
@@ -1435,8 +1397,8 @@ export async function rejectReleaseGood(
 
             await tx.getRepository(Inventory).save({
               ...oi.inventory,
-              lockedQty: safeDecimalOperation(oi.inventory.lockedQty, oi.releaseQty, 'subtract'),
-              lockedUomValue: safeDecimalOperation(oi.inventory.lockedUomValue, oi.releaseUomValue, 'subtract'),
+              lockedQty: oi.inventory.lockedQty - oi.releaseQty,
+              lockedUomValue: oi.inventory.lockedUomValue - oi.releaseUomValue,
               updater: user
             })
           }
@@ -1927,11 +1889,7 @@ function extractRawReleaseGoods(rawReleaseGoods): Partial<ReleaseGood[]> {
 
       // if there is duplicated SKU, merge them and sum up the releaseQty
       if (duplicateSkuIdx >= 0) {
-        releaseGoods[idx].orderInventories[duplicateSkuIdx].releaseQty = safeDecimalOperation(
-          releaseGoods[idx].orderInventories[duplicateSkuIdx].releaseQty,
-          item.releaseQty,
-          'add'
-        )
+        releaseGoods[idx].orderInventories[duplicateSkuIdx].releaseQty += item.releaseQty
       } else {
         releaseGoods[idx].orderInventories.push({
           sku: item.sku,
@@ -1939,8 +1897,8 @@ function extractRawReleaseGoods(rawReleaseGoods): Partial<ReleaseGood[]> {
           packingType: item.packingType,
           packingSize: item.packingSize,
           uom: item.uom,
-          releaseQty: parseFloat(item.releaseQty.toFixed(3)),
-          releaseUomValue: parseFloat(item.releaseUomValue.toFixed(3))
+          releaseQty: item.releaseQty,
+          releaseUomValue: item.releaseUomValue
         })
       }
     } else {