@things-factory/sales-base 4.3.637 → 4.3.638

package/server/service/arrival-notice/arrival-notice-query.ts

@@ -1,15 +1,50 @@
-import { Arg, Args, Ctx, Directive, FieldResolver, Query, Resolver, Root } from 'type-graphql'
-import { EntityManager, getRepository, In, SelectQueryBuilder } from 'typeorm'
+import {
+  Arg,
+  Args,
+  Ctx,
+  Directive,
+  FieldResolver,
+  Query,
+  Resolver,
+  Root
+} from 'type-graphql'
+import {
+  EntityManager,
+  getRepository,
+  In,
+  SelectQueryBuilder
+} from 'typeorm'
 
 import { Attachment } from '@things-factory/attachment-base'
-import { checkUserBelongsDomain, User } from '@things-factory/auth-base'
-import { Bizplace, getCompanyBizplace, getPermittedBizplaceIds } from '@things-factory/biz-base'
+import {
+  checkUserBelongsDomain,
+  User
+} from '@things-factory/auth-base'
+import {
+  Bizplace,
+  getCompanyBizplace,
+  getPermittedBizplaceIds
+} from '@things-factory/biz-base'
 import { Setting } from '@things-factory/setting-base'
-import { buildQuery, Domain, ListParam } from '@things-factory/shell'
-
-import { ArrivalNoticeList, NewArrivalNotice, RawArrivalNotice } from '../'
-import { ATTACHMENT_TYPE, ORDER_STATUS } from '../../constants'
-import { OrderInventory, OrderProduct } from '../../service'
+import {
+  buildQuery,
+  Domain,
+  ListParam
+} from '@things-factory/shell'
+
+import {
+  ArrivalNoticeList,
+  NewArrivalNotice,
+  RawArrivalNotice
+} from '../'
+import {
+  ATTACHMENT_TYPE,
+  ORDER_STATUS
+} from '../../constants'
+import {
+  OrderInventory,
+  OrderProduct
+} from '../../service'
 import { convertExcelDateToISO } from '../../utils/datetime-util'
 import { ArrivalNotice } from './arrival-notice'
 
@@ -309,8 +344,8 @@ export class ArrivalNoticeQuery {
     @Arg('rawArrivalNotices', type => [NewArrivalNotice], { nullable: true }) rawArrivalNotices: NewArrivalNotice[],
     @Arg('bizplaceId', type => String) bizplaceId: string
   ): Promise<RawArrivalNotice[]> {
-    const { domain, tx }: { domain: Domain; tx: EntityManager } = context.state
-    return await validateBulkArrivalNoticesFunction(rawArrivalNotices, bizplaceId, domain, tx)
+    const {domain , tx}: {domain: Domain, tx: EntityManager} = context.state
+    return await validateBulkArrivalNoticesFunction(rawArrivalNotices, bizplaceId, domain,tx)
   }
 
   @FieldResolver(type => Domain)
@@ -367,7 +402,7 @@ export async function validateBulkArrivalNoticesFunction(
       }
     })
   )
-
+  
   const enableLotIdInput: Setting = await trxMgr.getRepository(Setting).findOne({
     where: { domain, category: 'id-rule', name: 'enable-lot-id-input' }
   })
@@ -375,25 +410,25 @@ export async function validateBulkArrivalNoticesFunction(
   //check if palletId is entered but enablelotidinput setting is false
   let lotIdInputSettingChecker = ''
   if (rawArrivalNotices.some(record => record.palletId) && enableLotIdInput.value == 'false') {
-    lotIdInputSettingChecker = 'Please enable the setting to create orders with a custom Lot ID'
+    lotIdInputSettingChecker = 'Please enable the setting to create orders with a custom Lot ID';
   }
 
-  // uncomment this to show error message as popup
-
-  // for (let item of rawArrivalNotices) {
-  //   if (item.palletId) {
-  //     const foundOrderProductsPallet = await trxMgr.getRepository(OrderProduct).findOne({
-  //       where: {
-  //         domain,
-  //         palletId: item.palletId
-  //       }
-  //     })
-
-  //     if (foundOrderProductsPallet) {
-  //       throw new Error(('Lot ID is already in used. Please enter new Lot ID.'))
-  //     }
-  //   }
-  // }
+    // uncomment this to show error message as popup 
+
+    // for (let item of rawArrivalNotices) {
+    //   if (item.palletId) {
+    //     const foundOrderProductsPallet = await trxMgr.getRepository(OrderProduct).findOne({
+    //       where: {
+    //         domain,
+    //         palletId: item.palletId
+    //       }
+    //     })
+  
+    //     if (foundOrderProductsPallet) {
+    //       throw new Error(('Lot ID is already in used. Please enter new Lot ID.'))
+    //     }
+    //   }
+    // }
 
   await trxMgr.query(
     `
@@ -415,7 +450,7 @@ export async function validateBulkArrivalNoticesFunction(
         packing_type VARCHAR(50),
         packing_size INT,
         uom VARCHAR(10),
-        pack_qty NUMERIC(19,3),
+        pack_qty INT,
         pallet_qty INT,
         pallet_id VARCHAR(50),
         unit_price VARCHAR(50),
@@ -447,7 +482,7 @@ export async function validateBulkArrivalNoticesFunction(
         )
       )
     `,
-    [json_oi, domain.id]
+    [json_oi,domain.id]
   )
 
   await trxMgr.query(
@@ -577,10 +612,6 @@ export async function validateBulkArrivalNoticesFunction(
               WHEN f.pack_qty IS NULL OR f.pack_qty <= 0 THEN 'invalid pack qty,'
               ELSE ''
             END ||
-            CASE 
-              WHEN f.pack_qty % 1 != 0 AND NOT pr.is_inventory_decimal THEN 'decimal quantities are not allowed for this product,'
-              ELSE ''
-            END ||
             CASE 
               WHEN f.batch_id IS NULL THEN 'batch no. is required,'
               ELSE ''
@@ -628,13 +659,12 @@ export async function validateBulkArrivalNoticesFunction(
       FROM 
         temp_foo f
         LEFT JOIN temp_foo_duplicates d ON f.pallet_id = d.pallet_id
-        LEFT JOIN products pr ON pr.id = f.product_id
       ORDER BY f.ref_no, f.ref_no_2, f.ref_no_3, f.sku;
     `
   )
 
   await trxMgr.query('DROP TABLE raw_arrival_notices, temp_gan, temp_foo, temp_foo_duplicates, temp_used_pallet_ids')
-
+  
   return validatedItems.map(item => {
     return {
       refNo: item.ref_no,
@@ -664,9 +694,7 @@ export async function validateBulkArrivalNoticesFunction(
       palletId: item.pallet_id,
       unitPrice: item.unit_price,
       manufactureDate: item.manufacture_date,
-      errorMsg: lotIdInputSettingChecker
-        ? lotIdInputSettingChecker + (item.error_msg ? ',' + item.error_msg : '')
-        : item.error_msg
+      errorMsg: lotIdInputSettingChecker ? lotIdInputSettingChecker + (item.error_msg ? ',' + item.error_msg : '') : item.error_msg
     }
   })
 }

package/server/service/arrival-notice/arrival-notice-types.ts

@@ -1,5 +1,5 @@
 import { Field, Float, InputType, Int, ObjectType } from 'type-graphql'
-import { OneToMany } from 'typeorm'
+import {  OneToMany } from 'typeorm'
 
 import { ObjectRef } from '@things-factory/shell'
 
@@ -112,7 +112,7 @@ export class NewArrivalNotice {
   @Field(type => Float, { nullable: true })
   packingSize?: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packQty?: number
 
   @Field(type => Float, { nullable: true })
@@ -159,7 +159,7 @@ export class ArrivalNoticePatch {
 
   @Field({ nullable: true })
   ownTransport: boolean
-
+  
   @Field({ nullable: true })
   transportVehicle: string
 
@@ -292,7 +292,7 @@ export class RawArrivalNotice {
   @Field(type => Float, { nullable: true })
   packingSize?: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packQty?: number
 
   @Field(type => Float, { nullable: true })

package/server/service/inventory-check-item/inventory-check-item-types.ts

@@ -19,22 +19,7 @@ export class NewInventoryCheckItem {
   name: string
 
   @Field({ nullable: true })
-  countNo?: number
-
-  @Field(type => Float, { nullable: true })
-  originQty?: number
-
-  @Field(type => Float, { nullable: true })
-  inspectedQty?: number
-
-  @Field(type => Float, { nullable: true })
-  originUomValue?: number
-
-  @Field(type => Float, { nullable: true })
-  inspectedUomValue?: number
-
-  @Field({ nullable: true })
-  status?: string
+  status: string
 
   @Field(type => InventoryPatch, { nullable: true })
   inventory: InventoryPatch
@@ -57,27 +42,6 @@ export class InventoryCheckItemPatch {
   @Field({ nullable: true })
   name: string
 
-  @Field({ nullable: true })
-  countNo?: number
-
-  @Field(type => Float, { nullable: true })
-  originQty?: number
-
-  @Field(type => Float, { nullable: true })
-  inspectedQty?: number
-
-  @Field(type => Float, { nullable: true })
-  originUomValue?: number
-
-  @Field(type => Float, { nullable: true })
-  inspectedUomValue?: number
-
-  @Field({ nullable: true })
-  status: string
-
-  @Field({ nullable: true })
-  cuFlag: string
-
   @Field(type => ObjectRef, { nullable: true })
   inventory: ObjectRef
 
@@ -87,6 +51,12 @@ export class InventoryCheckItemPatch {
   @Field({ nullable: true })
   batchIdRef: string
 
+  @Field(type => Int, { nullable: true })
+  inspectedQty: number
+
+  @Field(type => Float, { nullable: true })
+  inspectedUomValue: number
+
   @Field(type => ObjectRef, { nullable: true })
   inspectedLocation: ObjectRef
 
@@ -101,4 +71,7 @@ export class InventoryCheckItemPatch {
 
   @Field({ nullable: true })
   productDetailId: string
+
+  @Field({ nullable: true })
+  status: string
 }

package/server/service/inventory-check-item/inventory-check-item.ts

@@ -64,67 +64,19 @@ export class InventoryCheckItem {
   @Field({ nullable: true })
   countNo: number
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   originQty: number
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   inspectedQty: number
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   originUomValue: number
 
-  @Column({
-    type: 'decimal',
-    scale: 3,
-    nullable: true,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   inspectedUomValue: number
 

package/server/service/order-inventory/order-inventory-query.ts

@@ -294,12 +294,8 @@ export class OrderInventoryQuery {
           value: releaseGood.id,
           relation: true
         })
-      } else {
-        // If no matching release good is found, return empty result
-        return { items: [], total: 0 }
       }
     }
-
     const qb: SelectQueryBuilder<OrderInventory> = getRepository(OrderInventory).createQueryBuilder('oi')
     buildQuery(qb, params, context)
 
@@ -331,7 +327,6 @@ export class OrderInventoryQuery {
         productName: item.inventory.product.name,
         productSKU: item.inventory.product.sku,
         productBrand: item.inventory.product.brand,
-        isInventoryDecimal: item.inventory.product.isInventoryDecimal,
         packingSize: item.inventory.packingSize
       }
     })

package/server/service/order-inventory/order-inventory-types.ts

@@ -68,16 +68,16 @@ export class NewOrderInventory {
   @Field({ nullable: true })
   releaseOrderId: string
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   releaseQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   pickedQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   sortedQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packedQty: number
 
   @Field(type => Float, { nullable: true })
@@ -104,13 +104,13 @@ export class NewOrderInventory {
   @Field({ nullable: true })
   existingRow: boolean
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   returnQty: number
 
   @Field(type => Float, { nullable: true })
   returnUomValue: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   returnToLocationQty: number
 
   @Field(type => Float, { nullable: true })
@@ -146,7 +146,7 @@ export class OrderInventoryPatch {
   @Field(type => ObjectRef, { nullable: true })
   inventory: ObjectRef
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   inspectedQty: number
 
   @Field(type => Float, { nullable: true })
@@ -188,19 +188,19 @@ export class OrderInventoryPatch {
   @Field({ nullable: true })
   extraJsonData: string
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   releaseQty: number
 
   @Field({ nullable: true })
   serialNumber: string
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   sortedQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   pickedQty: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   packedQty: number
 
   @Field({ nullable: true })
@@ -221,7 +221,7 @@ export class OrderInventoryPatch {
   @Field(type => Float, { nullable: true })
   returnUomValue: number
 
-  @Field(type => Float, { nullable: true })
+  @Field(type => Int, { nullable: true })
   actualPackQty: number
 
   @Field(type => Int, { nullable: true })

package/server/service/order-inventory/order-inventory.ts

@@ -153,18 +153,7 @@ export class OrderInventory {
   @Field(type => User, { nullable: true })
   putawayBy: User
 
-  @Column({ 
-    nullable: true, 
-    type: 'decimal', 
-    scale: 3,     
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    } })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   actualPackUomValue: number
 
@@ -240,18 +229,7 @@ export class OrderInventory {
   @Field({ nullable: true })
   originQty: number
 
-  @Column({ 
-    nullable: true, 
-    type: 'decimal', 
-    scale: 3,     
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    } })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   inspectedQty: number
 
@@ -259,18 +237,7 @@ export class OrderInventory {
   @Field({ nullable: true })
   originUomValue: number
 
-  @Column({ 
-    nullable: true, 
-    type: 'decimal', 
-    scale: 3,     
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    } })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   inspectedUomValue: number
 
@@ -303,86 +270,23 @@ export class OrderInventory {
   @RelationId((orderInventory: OrderInventory) => orderInventory.binLocation)
   binLocationId: string
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   releaseQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    default: 0,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float', default: 0 })
   @Field({ nullable: true })
   pickedQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    default: 0,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float', default: 0 })
   @Field({ nullable: true })
   packedQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    default: 0,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float', default: 0 })
   @Field({ nullable: true })
   sortedQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   releaseUomValue: number
 
@@ -390,82 +294,23 @@ export class OrderInventory {
   @Field({ nullable: true })
   uom: string
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   returnQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   returnUomValue: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   returnToLocationQty: number
 
-  @Column({
-    nullable: true,
-    type: 'decimal',
-    scale: 3,
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    }
-  })
+  @Column({ nullable: true, type: 'float' })
   @Field({ nullable: true })
   returnToLocationUomValue: number
 
-  @Column({ 
-    nullable: true, 
-    type: 'decimal', 
-    scale: 3,     
-    transformer: {
-      to: (value: string | null) => value,
-      from: (value: string | null) => {
-        if (value === null || value === undefined) return null
-        const parsed = parseFloat(value)
-        return isNaN(parsed) ? null : parsed
-      }
-    } })
+  @Column({ nullable: true })
   @Field({ nullable: true })
   actualPackQty: number
 
@@ -645,9 +490,6 @@ export class OrderInventory {
   @Field({ nullable: true })
   pickingBin: string
 
-  @Field({ nullable: true })
-  isInventoryDecimal: boolean
-
   @Field(type => [ProductDetail], { nullable: true })
   productDetails: ProductDetail[]
 }