@tellescope/sdk 1.66.8 → 1.67.1

package/src/tests/tests.ts

@@ -10,6 +10,9 @@ import {
   UserDisplayInfo,
 } from "@tellescope/types-client"
 import { 
+  CreateTicketActionInfo,
+  CreateTicketAssignmentStrategies,
+  CreateTicketAssignmentStrategy,
   FormResponseValue,
   ModelName,
 } from "@tellescope/types-models"
@@ -5026,6 +5029,305 @@ const nextReminderInMS_tests = async () => {
   ])
 }
 
+const pollForResults = async <T>(f: () => Promise<T[]>, intervalInMS=500, iterations=20) => {
+  for (let i = 0; i < iterations; i++) {
+    await wait(undefined, intervalInMS)
+    const result = await f()
+    if (result.length) return result
+  }
+
+  throw new Error("failed pollForResults")
+}
+
+const test_ticket_automation_assignment_and_optimization = async () => {
+  log_header("Ticket Automation / Assignment Tests")
+
+  const users = await sdk.api.users.getSome()
+  if (users.length < 3) throw new Error("Must have at least 3 users to detect invalid assignment")
+
+  await sdk.api.users.updateOne(sdk.userInfo.id, { tags: ['tag1', 'tag2'] })
+  await sdk.api.users.updateOne(sdkNonAdmin.userInfo.id, { tags: ['tag1', 'tag3'] })
+
+  const journey = await sdk.api.journeys.createOne({ title: "Testing" })
+
+  let foregroundTestCounter = 0
+  const testForegroundTicket = async ({
+    assignedTo,
+    info,
+    validOwners,
+    enduser,
+    closedForReason,
+    testDelayedChild,
+  } : {
+    assignedTo: string[]
+    info: Pick<CreateTicketActionInfo, 'assignmentStrategy' | 'defaultAssignee'>,
+    validOwners: string[],
+    closedForReason?: string,
+    enduser?: Enduser,
+    testDelayedChild?: boolean,
+  }) => {
+    const e = enduser || await sdk.api.endusers.createOne({ assignedTo, journeys: { [journey.id]: '' } })
+
+    const step = await sdk.api.automation_steps.createOne({
+      action: { type: 'createTicket', info: { ...info, title: 'background ticket' } },
+      events: [{ 
+        type: 'ticketCompleted', 
+        info: closedForReason ? { automationStepId: PLACEHOLDER_ID, closedForReason }  : { automationStepId: PLACEHOLDER_ID } 
+      }],
+      journeyId: journey.id,
+    })
+    const statusStep = await sdk.api.automation_steps.createOne({
+      action: { type: 'setEnduserStatus', info: { status: 'Test Status' } },
+      events: [{ 
+        type: 'ticketCompleted', 
+        info: closedForReason ? { automationStepId: PLACEHOLDER_ID, closedForReason }  : { automationStepId: PLACEHOLDER_ID } 
+      }],
+      journeyId: journey.id,
+    })
+    const child = await sdk.api.automation_steps.createOne({
+      action: { type: 'setEnduserStatus', info: { status: 'Test Status' } },
+      events: [{ 
+        type: 'afterAction', 
+        info: {
+          automationStepId: step.id,
+          delay: 0, delayInMS: 0, unit: 'Days', 
+        }
+      }],
+      journeyId: journey.id,
+    })
+
+    const ticket = await sdk.api.tickets.createOne({
+      title: 'foreground ticket',
+      enduserId: e.id,
+      automationStepId: PLACEHOLDER_ID,
+      journeyId: journey.id,
+      owner: validOwners[0],
+      closedForReason,
+    })
+
+    await async_test(
+      `Foreground ticket assignment ${++foregroundTestCounter}`, 
+      () => sdk.api.tickets.close_ticket({ ticketId: ticket.id, closedForReason }),
+      { onResult: ({ generated }) => !!generated?.owner && validOwners.includes(generated.owner) }
+    ) 
+    await async_test(
+      `Foreground ticket nop, no duplicates`,
+      () => sdk.api.automated_actions.getSome({ filter: { automationStepId: step.id } }),
+      { onResult: steps => steps.length === 1 && !!steps[0].isNOP }
+    ) 
+    await async_test(
+      `Background action queued, no duplicates`,
+      () => sdk.api.automated_actions.getSome({ filter: { automationStepId: statusStep.id } }),
+      { 
+        onResult: steps => steps.length === 1 && !steps[0].isNOP 
+      }
+    ) 
+
+    // verify that ticket generated by close_ticket goes on to generate its own delayed actions
+    if (testDelayedChild) {
+      await async_test(
+        `Delayed child ticket`, 
+        () => pollForResults(() => sdk.api.automated_actions.getSome({ filter: { automationStepId: child.id } })),
+        { onResult: steps => steps.length === 1 && !steps[0].isNOP }
+      ) 
+    }
+
+    await Promise.all([
+      sdk.api.endusers.deleteOne(e.id),
+      sdk.api.automation_steps.deleteOne(step.id),
+      sdk.api.automation_steps.deleteOne(statusStep.id),
+      sdk.api.automation_steps.deleteOne(child.id),
+    ])
+  }
+
+  await testForegroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'default', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdk.userInfo.id],
+    testDelayedChild: true,
+  })
+  await testForegroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'default', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdk.userInfo.id],
+    closedForReason: "closedForReason test",
+    testDelayedChild: true,
+  })
+  await testForegroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'default', info: {} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'previous-owner', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],  
+    info: { 
+      assignmentStrategy: { type: 'care-team-primary', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'care-team-random', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag1']} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id, 
+    },
+    validOwners: [sdk.userInfo.id, sdkNonAdmin.userInfo.id, ],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag2']} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id 
+    },
+    validOwners: [sdk.userInfo.id],
+  })
+  await testForegroundTicket({ 
+    assignedTo: [],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag3']} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+
+
+  let backgroundTestCounter = 0
+  const testBackgroundTicket = async ({
+    assignedTo,
+    info,
+    validOwners,
+    enduser,
+  } : {
+    assignedTo: string[]
+    info: Pick<CreateTicketActionInfo, 'assignmentStrategy' | 'defaultAssignee'>,
+    validOwners: string[],
+    enduser?: Enduser,
+  }) => {
+    const e = enduser || await sdk.api.endusers.createOne({ assignedTo })
+    await sdk.api.automated_actions.createOne({
+      action: { type: 'createTicket', info: { ...info, title: 'background ticket' } },
+      automationStepId: PLACEHOLDER_ID,
+      enduserId: e.id,
+      event: { type: 'afterAction', info: { automationStepId: PLACEHOLDER_ID, delay: 0, delayInMS: 0, unit: 'Days' } },
+      journeyId: journey.id,
+      status: 'active',
+      processAfter: Date.now(),
+    })
+
+    await async_test(
+      `Background ticket assignment ${++backgroundTestCounter}`, 
+      () => pollForResults(() => sdk.api.tickets.getSome({ filter: { enduserId: e.id, title: 'background ticket' } })),
+      { onResult: ts => ts.length === 1 && !!ts[0].owner && validOwners.includes(ts[0].owner) }
+    ) 
+
+    await sdk.api.endusers.deleteOne(e.id)
+  }
+
+  await testBackgroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'default', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdk.userInfo.id],
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [],  
+    info: { 
+      assignmentStrategy: { type: 'default', info: {} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+
+  // ticket needs existing enduser, previous owner for test to work
+  const enduser = await sdk.api.endusers.createOne({ fname: 'previous-owner-test'})  
+  await sdk.api.tickets.createOne({ 
+    // title should be different than 'background test' so it doesn't create false positive test
+    title: 'previous-owner-test', enduserId: enduser.id, journeyId: journey.id, owner: sdkNonAdmin.userInfo.id 
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [],  
+    enduser,
+    info: { 
+      assignmentStrategy: { type: 'previous-owner', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+  
+  await testBackgroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],  
+    info: { 
+      assignmentStrategy: { type: 'care-team-primary', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'care-team-random', info: {} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag1']} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id, 
+    },
+    validOwners: [sdk.userInfo.id, sdkNonAdmin.userInfo.id, ],
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [sdkNonAdmin.userInfo.id, sdk.userInfo.id],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag2']} } , 
+      defaultAssignee: sdkNonAdmin.userInfo.id 
+    },
+    validOwners: [sdk.userInfo.id],
+  })
+  await testBackgroundTicket({ 
+    assignedTo: [],
+    info: { 
+      assignmentStrategy: { type: 'by-tags', info: { qualifier: 'One Of', values: ['tag3']} } , 
+      defaultAssignee: sdk.userInfo.id 
+    },
+    validOwners: [sdkNonAdmin.userInfo.id],
+  })
+
+  return Promise.all([
+    await sdk.api.journeys.deleteOne(journey.id)
+  ])
+}
+
 const NO_TEST = () => {}
 const tests: { [K in keyof ClientModelForName]: () => void } = {
   phone_trees: NO_TEST,
@@ -5165,6 +5467,7 @@ const validate_schema = () => {
     await mfa_tests()
     await setup_tests()
     await multi_tenant_tests() // should come right after setup tests
+    await test_ticket_automation_assignment_and_optimization()
     await role_based_access_tests()
     await automation_trigger_tests()
     await enduser_session_tests()

package/src/tests/webhooks_tests.ts

@@ -223,7 +223,7 @@ const endusers_tests = async (isSubscribed: boolean) => {
 
   const update = { assignedTo: [sdk.userInfo.id] }
   await sdk.api.endusers.updateOne(enduser.id, update)
-
+  await sdk.api.endusers.updateOne(enduser.id, { fields: { 'dontIncludeInWebhook': true } }, { dontSendWebhook: true })
   await check_next_webhook(
     a => {
       delete a.updates?.[0]?.recordBeforeUpdate.humanReadableId