@team-agent/installer 0.5.61 → 0.5.62

package/crates/team-agent/src/platform/argv.rs

@@ -1,3 +1,4 @@
+//!
 //! Process argv / environ probe.
 //!
 //! ## Batch 4 real implementation (leader msg_0689a63a9e40)
@@ -41,6 +42,7 @@
 //! same disabled default. **This is intentional**: leaking a
 //! bypass via unknown argv would be a MUST-NOT-13 假绿 failure.
 
+///
 /// Return the argv tokens for `pid`, or `None` if unavailable on
 /// this platform.
 ///
@@ -72,6 +74,7 @@ pub fn argv_tokens(pid: u32) -> Option<Vec<String>> {
     }
 }
 
+///
 /// Return the environ text (NUL-joined) for `pid`, or `None`.
 ///
 /// - Linux: `/proc/<pid>/environ` verbatim (migration of
@@ -91,6 +94,7 @@ pub fn environ_text(pid: u32) -> Option<String> {
     }
 }
 
+///
 /// Return the parent PID of `pid`, or `None` if unavailable.
 ///
 /// Byte-preserving migration of `lifecycle/launch.rs::process_parent_pid`:

package/crates/team-agent/src/platform/errors.rs

@@ -1,4 +1,3 @@
-//! Retryable OS error classifier + human-readable os_error_name.
 //!
 //! Batch 0 signature only. Batch 2 migrates the raw
 //! `libc::{EACCES, EPERM, EBUSY, ENOSPC}` matching in
@@ -8,6 +7,12 @@
 
 use std::io;
 
+///
+/// **本函数是单节点**:`#[cfg]` 在函数体内部分叉,只存在一个 `fn` 定义,
+/// 故不适用 SPEC §4「两份实现＝两个节点」——那条针对的是**多个独立 `fn` 定义**
+/// (如 `process.rs` 里 Unix/Windows 各定义一次)。
+/// `impl_notes` 只是实现说明,**不是节点身份**,不参与签名全等校验。
+///
 /// True when the OS error is a transient replace failure worth
 /// retrying (EACCES on Windows during antivirus scan, EBUSY on
 /// mounted filesystems, etc.). Batch 2 wires the callsite.
@@ -38,6 +43,10 @@ pub fn retryable_replace_error(error: &io::Error) -> bool {
     }
 }
 
+///
+/// 返回值是**对外稳定契约**:它会出现在诊断输出里被人和脚本读取,
+/// 因此已发布的名字不可改写,只可新增。
+///
 /// Human-readable name for a raw OS error code — used in diagnostics
 /// so operators see `EACCES` instead of `13`.
 #[allow(dead_code)]

package/crates/team-agent/src/platform/file_lock.rs

@@ -1,3 +1,4 @@
+//!
 //! Cross-platform exclusive file lock primitive.
 //!
 //! ## Batch 2 real implementation (leader msg_c833639b61b8)
@@ -26,12 +27,6 @@
 //! 2. `unlock(&File)` — release the lock. Called from `Drop` in both
 //!    caller sites.
 //!
-//! A high-level `try_lock_exclusive(path, timeout) -> FileLockGuard`
-//! wrapper is also provided (uses the same primitives + a bare polling
-//! loop) for future callers that don't need the metadata/waiter
-//! machinery — but the two existing product callers keep their own
-//! loops per this batch's byte-preserving constraint.
-//!
 //! ## Windows implementation
 //!
 //! Windows implementation uses `LockFileEx` /
@@ -54,9 +49,8 @@
 
 use std::fs::File;
 use std::io;
-use std::path::Path;
-use std::time::Duration;
 
+///
 /// Try to acquire an exclusive advisory lock on `file` without
 /// blocking. Returns `Ok(true)` if the lock was acquired, `Ok(false)`
 /// if the file is already locked by someone else, `Err(...)` on real
@@ -86,6 +80,7 @@ pub fn try_lock_once_nonblocking(file: &File) -> io::Result<bool> {
     }
 }
 
+///
 /// Release the exclusive lock held on `file`. Called from `Drop` in
 /// caller code so the release runs even on panic.
 ///
@@ -204,100 +199,7 @@ fn unlock_windows(file: &File) -> io::Result<()> {
 }
 
 // ─────────────────────────────────────────────────────────────────────
-// High-level convenience wrapper.
-// ─────────────────────────────────────────────────────────────────────
-
-/// Owns the underlying `File` handle + platform lock. `Drop` unlocks
-/// via `unlock(&file)`.
-///
-/// Callers that don't need the lifecycle-lock metadata/waiter/held_long
-/// event machinery can use `try_lock_exclusive(path, timeout)` directly.
-/// The existing product callers (`state/persist.rs`, `lifecycle/lock.rs`)
-/// use `try_lock_once_nonblocking` + `unlock` directly and keep their
-/// own polling loops for byte-preserving behavior.
-pub struct FileLockGuard {
-    file: Option<File>,
-}
-
-impl std::fmt::Debug for FileLockGuard {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.debug_struct("FileLockGuard")
-            .field("held", &self.file.is_some())
-            .finish()
-    }
-}
-
-impl FileLockGuard {
-    /// Test-only accessor for the wrapped file handle.
-    #[cfg(test)]
-    fn file(&self) -> &File {
-        self.file.as_ref().expect("file present until Drop")
-    }
-}
-
-impl Drop for FileLockGuard {
-    fn drop(&mut self) {
-        if let Some(file) = self.file.take() {
-            // Best-effort unlock. If it fails the OS still releases on
-            // handle close.
-            let _ = unlock(&file);
-        }
-    }
-}
-
-#[derive(Debug, thiserror::Error)]
-pub enum LockError {
-    #[error("file lock timeout after {timeout_secs:.2}s on {path}")]
-    Timeout { timeout_secs: f64, path: String },
-    #[error("file lock io error on {path}: {source}")]
-    Io {
-        path: String,
-        #[source]
-        source: io::Error,
-    },
-}
-
-/// High-level: acquire an exclusive lock on `path` within `timeout`,
-/// polling every 50ms. Returns a guard that unlocks on `Drop`.
-///
-/// Existing product callers do NOT use this — they need their own
-/// metadata/waiter/held_long event machinery. This wrapper exists for
-/// simple future callers.
-pub fn try_lock_exclusive(path: &Path, timeout: Duration) -> Result<FileLockGuard, LockError> {
-    let file = File::options()
-        .read(true)
-        .write(true)
-        .create(true)
-        .truncate(false)
-        .open(path)
-        .map_err(|e| LockError::Io {
-            path: path.display().to_string(),
-            source: e,
-        })?;
-    let start = std::time::Instant::now();
-    loop {
-        match try_lock_once_nonblocking(&file) {
-            Ok(true) => return Ok(FileLockGuard { file: Some(file) }),
-            Ok(false) => {}
-            Err(e) => {
-                return Err(LockError::Io {
-                    path: path.display().to_string(),
-                    source: e,
-                });
-            }
-        }
-        if start.elapsed() >= timeout {
-            return Err(LockError::Timeout {
-                timeout_secs: timeout.as_secs_f64(),
-                path: path.display().to_string(),
-            });
-        }
-        std::thread::sleep(Duration::from_millis(50));
-    }
-}
-
-// ─────────────────────────────────────────────────────────────────────
-// Tests: primitive + convenience wrapper on the host platform.
+// Tests: primitives on the host platform.
 // Both branches (unix + windows) exercise the same trait shape via
 // the top-level `try_lock_once_nonblocking` / `unlock` functions —
 // the test source is cfg-free.
@@ -334,24 +236,6 @@ mod tests {
         let _ = std::fs::remove_file(&path);
     }
 
-    #[test]
-    fn convenience_try_lock_exclusive_acquires_and_drop_releases() {
-        // The high-level convenience wrapper is what future callers
-        // will use. Verify the drop-releases-lock invariant.
-        let dir = std::env::temp_dir().join("ta-b2-convenience");
-        std::fs::create_dir_all(&dir).unwrap();
-        let path = dir.join("convenience-lock.tmp");
-        {
-            let guard = try_lock_exclusive(&path, Duration::from_secs(1))
-                .expect("first acquire must succeed");
-            let _ = guard.file();
-        }
-        let guard2 = try_lock_exclusive(&path, Duration::from_secs(1))
-            .expect("post-drop reacquire must succeed");
-        drop(guard2);
-        let _ = std::fs::remove_file(&path);
-    }
-
     #[test]
     fn second_acquire_blocks_until_first_releases() {
         // C-6 N38 anchor: the primitive returns `Ok(false)` for the
@@ -392,41 +276,4 @@ mod tests {
         unlock(&file2).unwrap();
         let _ = std::fs::remove_file(&path);
     }
-
-    #[test]
-    fn timeout_error_carries_path_and_seconds() {
-        // Convenience wrapper's timeout error shape.
-        //
-        // 0.5.43 debt-sweep (§6.2): the pre-0.5.43 fixed
-        // `ta-b2-timeout/timeout-lock.tmp` path let parallel test
-        // workers race for the same file across cargo threads. Each
-        // run now allocates a per-process + monotonic-atomic dir so
-        // `--test-threads=2` cannot false-fail. Timeout shape and
-        // `timeout-lock.tmp` basename are preserved so downstream
-        // guards keep firing.
-        static N: std::sync::atomic::AtomicU64 = std::sync::atomic::AtomicU64::new(0);
-        let dir = std::env::temp_dir().join(format!(
-            "ta-b2-timeout-{}-{}",
-            std::process::id(),
-            N.fetch_add(1, std::sync::atomic::Ordering::Relaxed)
-        ));
-        std::fs::create_dir_all(&dir).unwrap();
-        let path = dir.join("timeout-lock.tmp");
-        let _hold =
-            try_lock_exclusive(&path, Duration::from_secs(1)).expect("first acquire must succeed");
-        let err = try_lock_exclusive(&path, Duration::from_millis(150))
-            .expect_err("second acquire must timeout");
-        match err {
-            LockError::Timeout {
-                timeout_secs,
-                path: p,
-            } => {
-                assert!(timeout_secs > 0.0);
-                assert!(p.ends_with("timeout-lock.tmp"), "path suffix: {p}");
-            }
-            other => panic!("expected Timeout, got {other:?}"),
-        }
-        let _ = std::fs::remove_file(&path);
-        let _ = std::fs::remove_dir_all(&dir);
-    }
 }

package/crates/team-agent/src/platform/mod.rs

@@ -1,64 +1,3 @@
-//! 0.5.x Windows portability Batch 0: platform abstraction layer.
-//!
-//! Truth sources (READ-ONLY):
-//! - Design:  `.team/artifacts/0.5.x-windows-portability-survey-design.md`
-//!            (§Target Design + §Ordered Migration Plan)
-//! - CR verdict: `.team/artifacts/0.5.x-windows-portability-cr-verdict.md`
-//!            (6 constraints; C-1 through C-6 anchor into this module)
-//!
-//! ## Scope of Batch 0 (this commit)
-//!
-//! - Add the `platform` module scaffold + Unix-side implementations
-//!   populated from the current inline `libc`/`std::os::unix` code
-//!   (byte-equivalent behavior on macOS/Linux).
-//! - No caller migration yet — the three legacy fallback sites
-//!   (`mcp_server/wire.rs`, `lifecycle/restart/agent.rs`,
-//!   `state/persist.rs`) stay in place with `FIXME(portability)`
-//!   comments pointing at this design. Batch 2/3 replaces them.
-//! - Windows side is empty stubs today; every fn is `unimplemented!()`
-//!   with a `# Safety:` / `# Windows:` doc note explaining what
-//!   Batch 2/3/4 will supply.
-//! - CI adds a Windows compile-only gate (`cargo check --target
-//!   x86_64-pc-windows-msvc`), reporting RED as the burn-down baseline
-//!   for Batches 1-4. The Windows job uses `continue-on-error: true`
-//!   so it does not block the Ubuntu/macOS/Windows-binaries jobs.
-//!
-//! ## CR anchors
-//!
-//! - **C-1**: `packaging/types.rs::WindowsX8664 → PlatformSupport::Native`
-//!   claim is FALSE while `cargo check --target x86_64-pc-windows-msvc`
-//!   is RED. Downgraded to `PreviewCompileOnly` in this batch; will be
-//!   promoted back to `Native` only after Batch 6/7 real-machine gates.
-//! - **C-2**: three legacy non-Unix fallbacks
-//!   (`wire.rs::parent_pid=0`, `restart/agent.rs::pid_is_alive=true`,
-//!   `persist.rs::runtime_lock=not_implemented`) get
-//!   `FIXME(portability)` comments referencing this design. Batch 2
-//!   removes the persist.rs one; Batch 3 removes the wire.rs +
-//!   restart/agent.rs ones. Grep guards verify no reintroduction.
-//! - **C-4**: `platform::process` is NOT importable from
-//!   `messaging/` (team-worker liveness must go through the backend
-//!   `Transport`, not a shell-out process snapshot). Grep guard test
-//!   walks the source tree.
-//! - **C-6**: hard-terminate on Windows lacks Unix grace semantics —
-//!   the `terminate_pid`/`terminate_group` signatures include a
-//!   `SignalKind` enum + a caller-visible `TerminationOutcome` so
-//!   Windows callers can emit a `platform.terminate_force_only` event
-//!   when they downgrade from `TerminateGraceful` to `TerminateForce`.
-//!
-//! ## Module layout
-//!
-//! - `process`  — process lifecycle + snapshot + termination
-//! - `file_lock` — cross-platform exclusive file lock
-//! - `errors`  — retryable error classifier + os_error_name
-//! - `argv`    — process argv/environ query (Batch 4)
-//!
-//! Every submodule follows the same pattern: a `unix.rs` file with the
-//! current libc code, a `windows.rs` file with `unimplemented!()`
-//! stubs + Windows API sketch, and a `mod.rs` that re-exports the
-//! platform-appropriate impl via `cfg`.
-//!
-//! Callers see a single `crate::platform::process::pid_liveness(pid)`
-//! (etc.) with no `cfg` at the callsite.
 
 pub mod argv;
 pub mod errors;

package/crates/team-agent/src/platform/process.rs

@@ -1,3 +1,4 @@
+//!
 //! Process lifecycle + snapshot + termination platform primitives.
 //!
 //! Batch 0 provides:

package/crates/team-agent/src/provider/adapter.rs

@@ -1,3 +1,4 @@
+//!
 //! ProviderAdapter trait(per-provider 命令构造 + 能力面)+ registry facade + 占位实现。
 
 use std::path::{Path, PathBuf};

package/crates/team-agent/src/provider/adapters/claude.rs

@@ -1,3 +1,4 @@
+//!
 //! Claude / ClaudeCode provider-local command builders + permission helpers.
 //!
 //! Extracted from `provider/adapter.rs` (0.4.x decoupling step 2). Pure

package/crates/team-agent/src/provider/adapters/claude_fork.rs

@@ -1,3 +1,4 @@
+//!
 use std::path::{Path, PathBuf};
 
 use crate::provider::{ProviderError, SessionId};

package/crates/team-agent/src/provider/adapters/codex.rs

@@ -1,3 +1,4 @@
+//!
 //! Codex provider-local command builder + permission/sandbox helpers.
 //!
 //! Extracted from `provider/adapter.rs` (0.4.x decoupling step 2). Pure

package/crates/team-agent/src/provider/adapters/copilot.rs

@@ -1,3 +1,4 @@
+//!
 //! Copilot provider-local command builders + permission helpers.
 //!
 //! Extracted from `provider/adapter.rs` (0.4.x decoupling step 2). Pure

package/crates/team-agent/src/provider/adapters/copilot_fork.rs

@@ -1,3 +1,4 @@
+//!
 use std::path::{Path, PathBuf};
 
 use rusqlite::{params, Connection};

package/crates/team-agent/src/provider/adapters/fake.rs

@@ -1,3 +1,4 @@
+//!
 //! Fake provider — scripted worker built into the team-agent CLI itself.
 //! Extracted from `provider/adapter.rs` (0.4.x decoupling step 2).
 

package/crates/team-agent/src/provider/adapters/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! Provider-local adapter implementations. Split from the monolithic
 //! `provider/adapter.rs` as 0.4.x decoupling step 2. Each file owns its
 //! provider's command builders, permission/sandbox/auth helpers, and

package/crates/team-agent/src/provider/approvals/mod.rs

@@ -1,2 +1,3 @@
+//!
 pub mod parsing;
 pub mod runtime_prompts;

package/crates/team-agent/src/provider/approvals/parsing.rs

@@ -1,3 +1,4 @@
+//!
 use serde::{Deserialize, Serialize};
 
 use crate::provider::ApprovalKind;
@@ -38,11 +39,7 @@ impl ApprovalPrompt {
     }
 }
 
-pub fn capture_has_approval_prompt(capture: &str) -> bool {
-    extract_approval_prompt("agent", capture).is_some()
-}
-
-pub fn active_approval_control_index(lines: &[&str]) -> Option<usize> {
+fn active_approval_control_index(lines: &[&str]) -> Option<usize> {
     let idx = lines
         .iter()
         .enumerate()

package/crates/team-agent/src/provider/approvals/runtime_prompts.rs

@@ -1,3 +1,4 @@
+//!
 //! Runtime approval prompt decisions shared by coordinator hooks.
 
 use serde::{Deserialize, Serialize};
@@ -7,11 +8,11 @@ use crate::provider::{ApprovalFingerprint, ApprovalKind, ApprovalPrompt};
 
 pub const RUNTIME_MCP_APPROVAL_SERVER: &str = "team_orchestrator";
 
-pub fn runtime_mcp_tool_allowlisted(tool: &str) -> bool {
+fn runtime_mcp_tool_allowlisted(tool: &str) -> bool {
     !tool.trim().is_empty()
 }
 
-pub fn runtime_mcp_prompt_allowlisted(prompt: &ApprovalPrompt) -> bool {
+fn runtime_mcp_prompt_allowlisted(prompt: &ApprovalPrompt) -> bool {
     prompt.server.as_deref() == Some(RUNTIME_MCP_APPROVAL_SERVER)
         && prompt
             .tool
@@ -34,7 +35,7 @@ pub fn runtime_mcp_prompt_allowlisted(prompt: &ApprovalPrompt) -> bool {
 ///     reporting status to leader through the message bus is the same
 ///     architectural layer as `report_result` and is harmless. New tools
 ///     join only after explicit product decision (per architect note).
-pub fn runtime_mcp_tool_is_internal_control_plane(prompt: &ApprovalPrompt) -> bool {
+fn runtime_mcp_tool_is_internal_control_plane(prompt: &ApprovalPrompt) -> bool {
     if prompt.server.as_deref() != Some(RUNTIME_MCP_APPROVAL_SERVER) {
         return false;
     }
@@ -129,7 +130,7 @@ pub fn awaiting_human_confirm_reason(
     }
 }
 
-pub fn approval_prompt_fingerprint(
+fn approval_prompt_fingerprint(
     team: &str,
     agent_id: &str,
     prompt: &ApprovalPrompt,
@@ -163,7 +164,7 @@ pub fn approval_prompt_fingerprint(
     ApprovalFingerprint::new(fingerprint)
 }
 
-pub fn awaiting_human_confirm_dedupe_key(
+fn awaiting_human_confirm_dedupe_key(
     team: &str,
     agent_id: &str,
     fingerprint: &ApprovalFingerprint,

package/crates/team-agent/src/provider/classify.rs

@@ -1,3 +1,4 @@
+//!
 //! JSONL→neutral turn-state 翻译 + idle take-over predicate(`provider_state.common` +
 //! `idle_predicate` 的 Rust 等价)。leader 经注入的 TurnStateClassifier 调到这里。
 

package/crates/team-agent/src/provider/faults.rs

@@ -1,3 +1,4 @@
+//!
 //! abnormal track 消费的 fault/approval facts 抽取(`provider_state.read_fault_facts`)。
 
 use super::types::{FactKind, FaultFact, Signature, TurnId};
@@ -13,15 +14,6 @@ pub fn read_fault_facts(records: &[serde_json::Value], provider: Provider) -> Ve
         .collect()
 }
 
-pub fn explicit_error_fact(record: &serde_json::Value, provider: Provider) -> Option<FaultFact> {
-    match provider {
-        Provider::Codex => codex_explicit_error_fact(record),
-        Provider::Claude | Provider::ClaudeCode => claude_explicit_error_fact(record),
-        // copilot 一期不接 jsonl 真相源(C-3-5)。
-        Provider::Copilot | Provider::GeminiCli | Provider::Fake => None,
-    }
-}
-
 pub(crate) fn claude_explicit_error_fact(record: &serde_json::Value) -> Option<FaultFact> {
     if claude_record_is_system_api_error(record) {
         return Some(FaultFact::new(
@@ -50,23 +42,6 @@ pub(crate) fn claude_explicit_error_fact(record: &serde_json::Value) -> Option<F
     None
 }
 
-fn codex_explicit_error_fact(record: &serde_json::Value) -> Option<FaultFact> {
-    if record.get("method").and_then(serde_json::Value::as_str) != Some("turn/completed") {
-        return None;
-    }
-    let turn = record.get("params").and_then(|p| p.get("turn"))?;
-    if turn.get("status").and_then(serde_json::Value::as_str) != Some("failed") {
-        return None;
-    }
-    Some(FaultFact::new(
-        Signature::new("turn_failed"),
-        turn.get("id")
-            .and_then(serde_json::Value::as_str)
-            .map(TurnId::new),
-        FactKind::Failed,
-    ))
-}
-
 fn fault_fact(provider: Provider, record: &serde_json::Value) -> Option<FaultFact> {
     match provider {
         Provider::Claude | Provider::ClaudeCode => claude_fault_fact(record),

package/crates/team-agent/src/provider/helpers.rs

@@ -1,3 +1,4 @@
+//!
 //! provider 跨子模块共享 helper:JSONL 解析 / session_id 抽取 / 正则编译。
 
 use super::types::{ProviderError, StatusPatterns};

package/crates/team-agent/src/provider/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! step 8 · provider — type + trait SKELETON (ROUND-0).
 //!
 //! Design doc: `docs/phase0/subsystems/08-provider.md`
@@ -37,7 +38,6 @@ pub mod adapter;
 pub(crate) mod adapters;
 pub mod approvals;
 pub mod classify;
-pub mod command;
 pub mod faults;
 pub mod session;
 pub mod session_scan;

package/crates/team-agent/src/provider/session/capture.rs

@@ -1,3 +1,4 @@
+//!
 use std::collections::{BTreeMap, BTreeSet};
 use std::path::{Path, PathBuf};
 
@@ -534,10 +535,6 @@ pub fn incomplete_resumable_agent_ids(state: &Value) -> Vec<String> {
     out
 }
 
-pub fn session_capture_complete(state: &Value) -> bool {
-    incomplete_resumable_agent_ids(state).is_empty()
-}
-
 pub fn recover_resume_session_from_events(
     workspace: &Path,
     agent_id: &str,

package/crates/team-agent/src/provider/session/context_fork/claude.rs

@@ -1,3 +1,4 @@
+//!
 use super::*;
 
 pub(super) fn verify_claude_fork(

package/crates/team-agent/src/provider/session/context_fork/codex.rs

@@ -1,3 +1,4 @@
+//!
 use super::*;
 use std::collections::BTreeSet;
 use std::fs::{File, OpenOptions};

package/crates/team-agent/src/provider/session/context_fork/outcome.rs

@@ -1,3 +1,4 @@
+//!
 use super::*;
 
 #[derive(Debug, Clone)]

package/crates/team-agent/src/provider/session/context_fork.rs

@@ -1,3 +1,4 @@
+//!
 use std::collections::BTreeMap;
 use std::path::{Path, PathBuf};
 use std::time::{Duration, SystemTime};

package/crates/team-agent/src/provider/session/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! unit-6 (Stage 2) — provider session namespace.
 //!
 //! Houses session-specific provider concerns: resume preflight,
@@ -15,7 +16,4 @@ pub(crate) use context_fork::{
     PendingContextFork,
 };
 
-pub use resume::{
-    ProviderBackingCheck, RecoveryHint, ResumeDecisionDetail, ResumePreflight,
-    ResumePreflightOutcome, ResumeRefusalReason,
-};
+pub use resume::{RecoveryHint, ResumeRefusalReason};