@team-agent/installer 0.5.61 → 0.5.62

package/crates/team-agent/src/cli/send/resolve.rs

@@ -1,3 +1,4 @@
+//!
 use super::mailbox::maybe_enqueue_offline_leader_mailbox;
 use super::persist::persist_resolved_target;
 use crate::cli::{CliError, SendArgs};
@@ -207,7 +208,7 @@ pub(super) fn send_to_logical_to(
                         &args.workspace,
                         name,
                         content,
-                        args.sender.as_str(),
+                        args.sender.display_name(),
                         args.task.as_deref(),
                         &error,
                     )? {
@@ -359,3 +360,207 @@ pub(super) fn send_to_resolved_name(
     }
     Ok(value)
 }
+
+#[cfg(test)]
+mod a13_red_tests {
+    #![allow(clippy::expect_used, clippy::unwrap_used, clippy::panic)]
+
+    use super::send_to_resolved_name;
+    use crate::cli::named_address::{NamedTargetKind, ResolvedNamedAddress};
+    use crate::cli::SendArgs;
+    use crate::message_store::MessageStore;
+    use crate::messaging::TrustedSender;
+    use crate::model::ids::AgentId;
+    use serde_json::{json, Value};
+    use std::path::{Path, PathBuf};
+    use std::sync::atomic::{AtomicU64, Ordering};
+
+    fn fresh_workspace(tag: &str) -> PathBuf {
+        static NEXT: AtomicU64 = AtomicU64::new(0);
+        let workspace = std::env::temp_dir().join(format!(
+            "team-agent-a13-{tag}-{}-{}",
+            std::process::id(),
+            NEXT.fetch_add(1, Ordering::Relaxed)
+        ));
+        let _ = std::fs::remove_dir_all(&workspace);
+        std::fs::create_dir_all(workspace.join(".team/runtime")).expect("create fixture");
+        workspace
+    }
+
+    fn seed_team(workspace: &Path, team: &str) {
+        let session = format!("team-{team}");
+        let state = json!({
+            "active_team_key": team,
+            "status": "alive",
+            "session_name": session,
+            "agents": {},
+            "teams": {
+                team: {
+                    "status": "alive",
+                    "session_name": session,
+                    "agents": {},
+                    "leader_receiver": {"status": "unbound"}
+                }
+            }
+        });
+        crate::state::persist::save_runtime_state(workspace, &state).expect("save fixture state");
+        MessageStore::open(workspace).expect("create fixture store");
+    }
+
+    fn send_args(workspace: &Path) -> SendArgs {
+        SendArgs {
+            target: None,
+            message: vec!["payload".to_string()],
+            targets: None,
+            workspace: workspace.to_path_buf(),
+            team: None,
+            task: None,
+            sender: TrustedSender::from_runtime_identity_with_source(
+                AgentId::new("worker-1"),
+                workspace.display(),
+                "sender-team",
+            ),
+            no_ack: false,
+            no_wait: true,
+            watch_result: false,
+            timeout: 0.0,
+            confirm_human: false,
+            json: true,
+            message_id: None,
+            presentation: crate::messaging::presentation::PresentationRequest::default(),
+            pane: None,
+            to_name: Some("other-team/leader".to_string()),
+            to_leader: None,
+        }
+    }
+
+    fn leader_address(sender_workspace: &Path, target_workspace: &Path) -> ResolvedNamedAddress {
+        ResolvedNamedAddress {
+            raw_name: format!("{}::other-team/leader", target_workspace.display()),
+            target_kind: NamedTargetKind::Leader,
+            sender_workspace: sender_workspace.to_path_buf(),
+            target_workspace: target_workspace.to_path_buf(),
+            team_key: Some("other-team".to_string()),
+            agent_id: None,
+            pane_id: String::new(),
+            session_name: Some("team-other-team".to_string()),
+            window_name: None,
+            tmux_endpoint: None,
+            transport_kind: Some("direct_tmux".to_string()),
+            app_server: None,
+            state_pane_id: None,
+            state_pane_stale: false,
+            agent_status: None,
+            warning: None,
+        }
+    }
+
+    fn message_count(workspace: &Path) -> i64 {
+        let store = MessageStore::open(workspace).expect("open fixture store");
+        crate::db::schema::open_db(store.db_path())
+            .expect("open fixture database")
+            .query_row("select count(*) from messages", [], |row| row.get(0))
+            .expect("count fixture messages")
+    }
+
+    #[test]
+    fn a13_worker_cross_workspace_leader_send_preserves_target_scope() {
+        let sender_workspace = fresh_workspace("sender");
+        let target_workspace = fresh_workspace("target");
+        seed_team(&target_workspace, "other-team");
+        let mut args = send_args(&sender_workspace);
+        let to_name = format!("{}::other-team/leader", target_workspace.display());
+        args.to_name = Some(to_name.clone());
+        let value = super::send_to_logical_to(&args, &to_name, "payload")
+            .expect("cross-workspace leader send must preserve a structured outcome");
+        assert_eq!(
+            value["to_name"],
+            json!(to_name),
+            "cross-workspace receipt must retain the original target: {value}"
+        );
+        assert_eq!(
+            value["sender"],
+            json!(format!(
+                "{}::sender-team/worker-1",
+                sender_workspace.display()
+            )),
+            "cross-workspace receipt must retain the full sender: {value}"
+        );
+        assert_eq!(
+            message_count(&sender_workspace),
+            0,
+            "cross-workspace send must not fold into the sender workspace"
+        );
+        assert_eq!(
+            message_count(&target_workspace),
+            1,
+            "cross-workspace send must persist in the target workspace"
+        );
+
+        let _ = std::fs::remove_dir_all(sender_workspace);
+        let _ = std::fs::remove_dir_all(target_workspace);
+    }
+
+    #[test]
+    fn a13_worker_cross_workspace_identity_is_preserved_in_row_and_render() {
+        let sender_workspace = fresh_workspace("identity-sender");
+        let target_workspace = fresh_workspace("identity-target");
+        seed_team(&target_workspace, "other-team");
+        let mut args = send_args(&sender_workspace);
+        args.to_name = Some(format!("{}::other-team/leader", target_workspace.display()));
+        let resolved = leader_address(&sender_workspace, &target_workspace);
+
+        send_to_resolved_name(&args, &resolved, "identity payload")
+            .expect("cross-workspace identity send must persist");
+        let store = MessageStore::open(&target_workspace).expect("open target store");
+        let connection = crate::db::schema::open_db(store.db_path()).expect("open target db");
+        let sender: String = connection
+            .query_row("select sender from messages limit 1", [], |row| row.get(0))
+            .expect("read sender");
+        let expected = format!("{}::sender-team/worker-1", sender_workspace.display());
+        assert_eq!(
+            sender, expected,
+            "durable row must retain the full sender identity"
+        );
+        let rendered = crate::messaging::delivery::render_message(
+            &sender,
+            None,
+            "identity payload",
+            "msg-a13",
+        );
+        assert!(
+            rendered.contains(&expected),
+            "rendered pane must show full sender: {rendered}"
+        );
+        assert!(
+            !rendered.contains("from leader"),
+            "worker must not render as leader: {rendered}"
+        );
+
+        let _ = std::fs::remove_dir_all(sender_workspace);
+        let _ = std::fs::remove_dir_all(target_workspace);
+    }
+
+    #[test]
+    fn a13_worker_in_workspace_leader_send_remains_allowed() {
+        let workspace = fresh_workspace("in-workspace");
+        seed_team(&workspace, "other-team");
+        let args = send_args(&workspace);
+        let resolved = leader_address(&workspace, &workspace);
+
+        let value = send_to_resolved_name(&args, &resolved, "payload")
+            .expect("in-workspace leader send should preserve the existing path");
+        assert_ne!(
+            value["reason"],
+            Value::String("target_out_of_scope".to_string()),
+            "in-workspace send must not be classified as cross-workspace: {value}"
+        );
+        assert_eq!(
+            message_count(&workspace),
+            1,
+            "allowed send must persist once"
+        );
+
+        let _ = std::fs::remove_dir_all(workspace);
+    }
+}

package/crates/team-agent/src/cli/send.rs

@@ -1,3 +1,4 @@
+//!
 //! cli · send — `cmd_send` + target 解析(`_send_target`)+ `SendArgs`→`SendOptions` 翻译
 //! (`send_options_from_args`,旗标取反语义)。
 
@@ -180,7 +181,7 @@ pub fn send_to_canonical_leader_target(
 }
 
 /// `_send_target`(`commands.py:181-184`):`--to` comma-split fanout / `target` 单值 / None。
-pub fn send_target(targets: Option<&str>, target: Option<&str>) -> MessageTarget {
+pub(super) fn send_target(targets: Option<&str>, target: Option<&str>) -> MessageTarget {
     if let Some(targets) = targets.filter(|s| !s.is_empty()) {
         let recipients: Vec<String> = targets
             .split(',')

package/crates/team-agent/src/cli/spec.rs

@@ -1,3 +1,4 @@
+//!
 //! C1 command registry: one catalog for help visibility, known-command gates,
 //! suggestion candidates, and command-tier governance.
 

package/crates/team-agent/src/cli/status.rs

@@ -1,3 +1,4 @@
+//!
 //! cli · status — 五行 triage summary 渲染 + agent 分类计数(commands.py
 //! `_format_status_summary` / `_agent_summary_counts` / `_interaction_counts` /
 //! `_latest_result_line` + `cmd_status` 的 compact 不变量)。
@@ -100,7 +101,7 @@ fn stale_agent_bucket(agent: &Value) -> Option<SummaryBucket> {
 }
 
 /// `_interaction_counts`(`commands.py:292-306`):遍历 agents 的 `interacted` 字段。
-pub fn interaction_counts(agents: &Value) -> InteractionCounts {
+pub(super) fn interaction_counts(agents: &Value) -> InteractionCounts {
     let mut counts = InteractionCounts::default();
     let Some(agent_map) = agents.as_object() else {
         return counts;

package/crates/team-agent/src/cli/status_port/compact.rs

@@ -1,3 +1,4 @@
+//!
 use super::*;
 
 pub(super) fn compact_status(full: Value) -> Value {

package/crates/team-agent/src/cli/status_port/format.rs

@@ -1,3 +1,4 @@
+//!
 use crate::cli::CliError;
 use serde_json::{json, Value};
 

package/crates/team-agent/src/cli/status_port/inbox.rs

@@ -1,3 +1,4 @@
+//!
 use super::*;
 
 pub fn inbox(

package/crates/team-agent/src/cli/tests/verb_profile.rs

@@ -122,6 +122,44 @@ fn profile_init_routes_and_creates_secret_boundary_files() {
     let _ = std::fs::remove_dir_all(&ws);
 }
 
+#[test]
+fn compatible_api_profile_init_template_contains_common_five_fields() {
+    let ws = tmp_workspace();
+    let code = run(
+        &profile_argv(&[
+            "profile",
+            "init",
+            "compat",
+            "--workspace",
+            ".",
+            "--auth-mode",
+            "compatible_api",
+            "--json",
+        ]),
+        &ws,
+    );
+    assert_eq!(
+        code,
+        ExitCode::Ok,
+        "compatible_api profile init must route and exit 0"
+    );
+
+    let expected =
+        "AUTH_MODE=compatible_api\nPROFILE_NAME=compat\nBASE_URL=\nAPI_KEY=\nMODEL=\n";
+    let dir = profiles_dir(&ws);
+    assert_eq!(
+        std::fs::read_to_string(dir.join("compat.env")).unwrap(),
+        expected,
+        "compatible_api profile must expose the documented five-field template"
+    );
+    assert_eq!(
+        std::fs::read_to_string(dir.join("compat.example.env")).unwrap(),
+        expected,
+        "compatible_api example must expose the documented five-field template"
+    );
+    let _ = std::fs::remove_dir_all(&ws);
+}
+
 // Golden source:
 // - profiles/core.py:95-119 doctor_profile returns ok=true for existing profiles and
 //   ok=false for missing profiles; parser.py:506-508 maps result.ok false to exit 1.

package/crates/team-agent/src/cli/types.rs

@@ -1,3 +1,4 @@
+//!
 //! cli · types — 错误信封 / 退出码 / 命令结果载体 / leader passthrough 参数 /
 //! 每子命令的 clap-style arg 结构 / 五行 summary 计数桶。
 
@@ -13,7 +14,7 @@ use crate::transport::PaneId;
 /// `{ok:false, error, action, log, reason?, session_name?, next_actions?}`(字节级保留)。
 /// 人读时打 `error:`/`action:`/`log:` 三行到 stderr(`helpers.py:132-134`)。
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
-pub struct CliErrorPayload {
+pub(crate) struct CliErrorPayload {
     /// 恒 `false`(错误信封)。
     pub ok: bool,
     pub error: String,
@@ -70,7 +71,7 @@ impl From<crate::messaging::MessagingError> for CliError {
 impl CliError {
     /// `_cli_error_payload`(`helpers.py:137-155`):落盘日志后构造稳定信封。tmux session
     /// 冲突时按 command 富化 reason/session_name/next_actions(`helpers.py:158-187`)。
-    pub fn to_payload(&self, log_path: &Path, command: &str) -> CliErrorPayload {
+    pub(crate) fn to_payload(&self, log_path: &Path, command: &str) -> CliErrorPayload {
         let error = self.to_string();
         let mut payload = CliErrorPayload {
             ok: false,

package/crates/team-agent/src/communication_mode/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! Official communication modes shared by configuration and projection consumers.
 
 /// The complete product-supported communication-mode catalog.

package/crates/team-agent/src/compiler.rs

@@ -1,3 +1,4 @@
+//!
 //! step 6 · compiler — doc-driven team source → canonical `team.spec` dict.
 //!
 //! Truth source (READ-ONLY): `team-agent-public` @ v0.2.11, `team_agent/compiler.py`.

package/crates/team-agent/src/conpty/backend.rs

@@ -1,3 +1,4 @@
+//!
 //! `ConPtyBackend` — implements the existing `Transport` trait using the
 //! named-pipe protocol in `super::protocol`.
 //!

package/crates/team-agent/src/conpty/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! 0.5.x Windows-native transport Phase 1: ConPTY backend.
 //!
 //! Wire protocol + portable shim state machine live in the

package/crates/team-agent/src/coordinator/backoff.rs

@@ -1,3 +1,4 @@
+//!
 //! daemon 主循环面(`__main__.py`)—— 退避序列 + tick 间隔解析 + 子进程入口。
 
 use thiserror::Error;
@@ -10,7 +11,7 @@ use crate::provider::ProviderAdapter;
 use super::health::{coordinator_pid_path, write_coordinator_metadata};
 use super::tick::{write_coordinator_heartbeat, TickError, TickReport, HEARTBEAT_STATUS_PANIC};
 use super::types::{
-    ErrorLists, MetadataSource, Pid, ProviderRegistry, WorkspacePath, BACKOFF_MAX_SEC,
+    MetadataSource, Pid, ProviderRegistry, WorkspacePath, BACKOFF_MAX_SEC,
     DEFAULT_TICK_INTERVAL_SEC,
 };
 use super::Coordinator;
@@ -122,7 +123,7 @@ pub fn run_daemon(args: DaemonArgs) -> Result<(), DaemonError> {
     run_daemon_with_coordinator_and_boot_tmux(&args, &coordinator, Some(tmux_metadata))
 }
 
-pub fn run_daemon_with_coordinator(
+pub(crate) fn run_daemon_with_coordinator(
     args: &DaemonArgs,
     coordinator: &Coordinator,
 ) -> Result<(), DaemonError> {
@@ -519,14 +520,14 @@ fn current_ppid() -> u32 {
 
 /// 计算 tick 间隔(`_tick_interval`,`__main__.py:104-115`)。读 spec `runtime.tick_interval_sec`,
 /// 缺失/出错 → `DEFAULT_TICK_INTERVAL_SEC`;并确保 schema 存在(`MessageStore(workspace)`)。
-pub fn resolve_tick_interval(workspace: &WorkspacePath) -> Result<f64, TickError> {
+pub(super) fn resolve_tick_interval(workspace: &WorkspacePath) -> Result<f64, TickError> {
     let _ = MessageStore::open(workspace.as_path())?;
     Ok(DEFAULT_TICK_INTERVAL_SEC)
 }
 
 /// 退避序列(`__main__.py:65`):`min(interval * 2^min(failures-1, 5), 60.0)` → 5→10→20→40→60→60s。
 /// unit test 锁死本序列(card §85)。**纯函数,无 I/O,可直接 impl 钉死**(但 ROUND-0 仍占位)。
-pub fn backoff_sleep_sec(interval: f64, consecutive_failures: u32) -> f64 {
+pub(super) fn backoff_sleep_sec(interval: f64, consecutive_failures: u32) -> f64 {
     let failures = consecutive_failures.saturating_sub(1).min(5);
     let exp = i32::try_from(failures).unwrap_or(5);
     (interval * 2f64.powi(exp)).min(BACKOFF_MAX_SEC)
@@ -538,10 +539,6 @@ impl ProviderRegistry for RealProviderRegistry {
     fn adapter_for(&self, provider: Provider) -> Box<dyn ProviderAdapter> {
         crate::provider::get_adapter(provider)
     }
-
-    fn error_lists(&self, _provider: Provider) -> ErrorLists {
-        ErrorLists::default()
-    }
 }
 
 fn sleep_seconds(seconds: f64) {

package/crates/team-agent/src/coordinator/conpty_shim.rs

@@ -1,3 +1,4 @@
+//!
 //! Windows ConPTY shim lifecycle manager.
 //!
 //! 0.5.x Windows portability Batch 6 Option A. The design's
@@ -160,7 +161,7 @@ pub enum ShimError {
 ///    installations.
 /// 2. Env override `TEAM_AGENT_WINDOWS_SHIM_PATH` — tests + CI
 ///    harness (Batch 6 SSH real-machine harness sets this).
-pub fn locate_shim_binary() -> Result<PathBuf, ShimError> {
+fn locate_shim_binary() -> Result<PathBuf, ShimError> {
     if let Ok(explicit) = std::env::var("TEAM_AGENT_WINDOWS_SHIM_PATH") {
         let p = PathBuf::from(&explicit);
         if p.exists() {
@@ -218,7 +219,7 @@ fn fresh_pipe_token() -> String {
 /// downstream `transport_factory::conpty_pipe_ready(...)` opens on
 /// the next factory resolve. The `pipe_token` is NOT persisted (CR
 /// C-1); it stays in `ShimHandle` memory only.
-pub fn spawn_shim_and_handshake(
+fn spawn_shim_and_handshake(
     workspace: &Path,
     team_key: &str,
     workspace_hash: &str,

package/crates/team-agent/src/coordinator/health.rs

@@ -1,3 +1,4 @@
+//!
 //! coordinator 健康/身份 & 只读可观测面:metadata 身份原语 + coordinator 路径 + watch 实时流。
 
 use std::io::{Read, Seek, SeekFrom};

package/crates/team-agent/src/coordinator/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! step 12 · coordinator — daemon lifecycle / single-tick orchestration SKELETON (ROUND-0).
 //!
 //! Card: `docs/phase0/subsystems/12-coordinator.md`.
@@ -10,8 +11,7 @@
 //!   - `coordinator/metadata.py`     (COORDINATOR_PROTOCOL_VERSION=2, pid_is_running, read/write/ok meta)
 //!   - `coordinator/paths.py`        (coordinator.pid / coordinator.json / coordinator.log paths)
 //!   - `watch/__init__.py`           (run_watch / collect_watch_lines / render_event_line / WatchCursor)
-//!   - `abnormal_track.py`           (Gap 32 §4 provider-neutral abnormal track:
-//!     process_abnormal_records / detect_whole_team_gone)
+//!   - `abnormal_track.py`           (Gap 32 §4 provider-neutral whole-team-gone detection)
 //!
 //! 职责(card §职责):per-workspace daemon 生命周期 + 单次 tick 编排。tick 按固定顺序把
 //! step 8-11 的原子操作串成一个只读 + 投递既定 obligation 的回路 —— **绝不**在无 pending

package/crates/team-agent/src/coordinator/orphan.rs

@@ -1,18 +1,11 @@
-//! 孤儿自终止判定(Gap 37b)+ provider-neutral 异常轨(abnormal_track:整队消失检测 + 去重通知)。
-
-use std::hash::{Hash, Hasher};
-
-use serde_json::Value;
-
-use crate::model::enums::Provider;
-use crate::provider::{ProcessLiveness, Signature, TurnId, TurnState};
+//!
+//! 孤儿自终止判定(Gap 37b)+ provider-neutral 整队消失检测。
 
 use super::types::{
-    AbnormalDecision, AbnormalError, AbnormalNotification, AbnormalNotificationState,
-    AbnormalProcessOutput, MarkerStore, ProviderRegistry, TeamPresenceSnapshot, WholeTeamGoneClass,
-    WholeTeamGoneReport, WorkspacePath,
+    MarkerStore, TeamPresenceSnapshot, WholeTeamGoneClass, WholeTeamGoneReport, WorkspacePath,
 };
 
+///
 /// 孤儿自终止判定(`__main__.py:51-59`,Gap 37b)。仅当
 /// `current_ppid != initial_ppid ∧ current_ppid == 1 ∧ !workspace.exists()` 三者**同时**成立 → true。
 /// 少一个条件都不能误杀正常 daemon(card §91)。
@@ -28,104 +21,7 @@ pub fn should_orphan_self_terminate(
 // abnormal_track 公共面(abnormal_track.py)—— Gap 32 §4 provider-neutral
 // ===========================================================================
 
-/// #236 dedicated `worker.abnormal_exit` surface.
 ///
-/// This is intentionally separate from `process_abnormal_records`: the generic
-/// abnormal path is transcript-only, while `worker.abnormal_exit` requires a fresh
-/// latest explicit provider error before leader notification.
-#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
-#[serde(tag = "event")]
-pub enum WorkerAbnormalExitSurface {
-    #[serde(rename = "worker.abnormal_exit")]
-    WorkerAbnormalExit {
-        agent_id: String,
-        provider: Provider,
-        path: String,
-        provider_process_dead: bool,
-        latest_explicit_error: bool,
-        signature: Signature,
-        turn_id: Option<TurnId>,
-        process_liveness: ProcessLiveness,
-    },
-    #[serde(rename = "abnormal_exit.single_signal_suppressed")]
-    SingleSignalSuppressed {
-        agent_id: String,
-        provider: Provider,
-        path: String,
-        provider_process_dead: bool,
-        latest_explicit_error: bool,
-        reason: String,
-    },
-}
-
-/// `process_abnormal_records`(`abnormal_track.py:14`)。把原始 provider session records 经
-/// provider reader 翻译成结构化 fault facts(本 module **不命名 provider、不读屏**),catch-bias
-/// (C9)+ `(signature, turn_id|fingerprint)` 去重(C8)。`registry` 携带 provider + 黑白名单。
-pub fn process_abnormal_records(
-    records: &[Value],
-    registry: &dyn ProviderRegistry,
-    provider: Provider,
-    notification_state: &AbnormalNotificationState,
-) -> Result<AbnormalProcessOutput, AbnormalError> {
-    let lists = registry.error_lists(provider);
-    let mut state = notification_state.clone();
-    let mut notifications = Vec::new();
-    for record in records {
-        let raw = record
-            .get("raw")
-            .and_then(Value::as_str)
-            .unwrap_or_else(|| record.as_str().unwrap_or(""))
-            .to_string();
-        let signature = record
-            .get("signature")
-            .and_then(Value::as_str)
-            .unwrap_or("unknown")
-            .to_string();
-        let signature_lower = signature.to_lowercase();
-        let turn_id = record
-            .get("turn_id")
-            .and_then(Value::as_str)
-            .map(TurnId::new);
-        let bucket = match &turn_id {
-            Some(id) => id.as_str().to_string(),
-            None => stable_fingerprint(record),
-        };
-        let key = format!("{signature}\0{bucket}");
-        if state.seen.contains(&key) {
-            continue;
-        }
-        state.seen.insert(key);
-        if lists.whitelist.iter().any(|needle| raw.contains(needle)) {
-            continue;
-        }
-        let decision =
-            if lists.blacklist.iter().any(|needle| {
-                raw.contains(needle) || signature_lower.contains(&needle.to_lowercase())
-            }) {
-                AbnormalDecision::NotifyBlacklist
-            } else {
-                AbnormalDecision::NotifyDefault
-            };
-        let kind = record.get("kind").and_then(Value::as_str);
-        notifications.push(AbnormalNotification {
-            signature,
-            turn_id,
-            state: if kind == Some("approval") {
-                TurnState::BlockedOnHuman
-            } else {
-                TurnState::Abnormal
-            },
-            decision,
-            provider: Some(provider),
-            raw: record.clone(),
-        });
-    }
-    Ok(AbnormalProcessOutput {
-        notifications,
-        notification_state: state,
-    })
-}
-
 /// `detect_whole_team_gone`(`abnormal_track.py:91`,C10/C13)。coordinator-independent 整队消失检测:
 /// 全死(coordinator + leader + 所有 worker + 所有 session)且非 clean_shutdown/restart →
 /// 写 durable marker + 延迟到下条 leader 命令再 escalate。clean/restart 静默。
@@ -166,14 +62,6 @@ pub fn detect_whole_team_gone(
     )
 }
 
-fn stable_fingerprint(value: &Value) -> String {
-    let mut hasher = std::collections::hash_map::DefaultHasher::new();
-    serde_json::to_string(value)
-        .unwrap_or_else(|_| value.to_string())
-        .hash(&mut hasher);
-    format!("{:016x}", hasher.finish())
-}
-
 fn whole_team_report(
     whole_team_gone: bool,
     classification: WholeTeamGoneClass,

package/crates/team-agent/src/coordinator/runtime_detectors.rs

@@ -1,3 +1,4 @@
+//!
 use std::collections::BTreeMap;
 use std::path::Path;
 

package/crates/team-agent/src/coordinator/runtime_observation.rs

@@ -1,3 +1,4 @@
+//!
 //! Shared coordinator runtime observation seam.
 //!
 //! S0 only defines the typed capture/result surface. Lane 1 fills capture facts;

package/crates/team-agent/src/coordinator/steps/abnormal.rs

@@ -1,3 +1,4 @@
+//!
 //! unit-11 (Stage 4) — coordinator tick `abnormal` step group.
 //!
 //! Abnormal-exit detection + classification step extracted from
@@ -15,6 +16,7 @@ use super::super::health::pid_is_running;
 use super::super::tick::TickError;
 use super::super::types::Pid;
 
+///
 /// #236 `worker.abnormal_exit` watcher.
 ///
 /// Notify only when the bounded transcript/rollout tail contains a latest explicit
@@ -967,6 +969,7 @@ fn abnormal_last_error_observation_cohort(state: &Value, agent_id: &str) -> Opti
 /// P1: Python `_TAIL_BYTES` parity (idle_takeover_wiring.py:13) — RS must not read less.
 const ABNORMAL_TAIL_BYTES: u64 = 131_072;
 
+///
 /// P1: bounded tail read; a partial first line is harmless (the consumer only parses
 /// the latest complete JSONL record) and lossy UTF-8 keeps a mid-codepoint seek safe.
 pub(crate) fn read_tail_text(path: &Path, max_bytes: u64) -> std::io::Result<String> {
@@ -1347,6 +1350,7 @@ impl ApiErrorRecoveryClass {
     }
 }
 
+///
 /// 0.5.36 §7.1: rules keyed on status/error text.
 pub(crate) fn classify_api_error_recovery(
     signature: &str,
@@ -1871,6 +1875,7 @@ fn process_api_error_recovery_intent(
 // path (which owns its own save).
 // ─────────────────────────────────────────────────────────────────────────
 
+///
 /// 0.5.36 §7.3: process all due recovery intents. Called from tick.rs
 /// AFTER atomic_save has flushed the detector-written intent. Reloads a
 /// fresh state each call so the caller's stale in-memory state cannot
@@ -2168,7 +2173,7 @@ fn write_recovery_intent_result(workspace: &Path, agent_id: &str, update: Recove
 mod tests {
     use super::*;
     use crate::coordinator::tick::Coordinator;
-    use crate::coordinator::types::{ErrorLists, ProviderRegistry, WorkspacePath};
+    use crate::coordinator::types::{ProviderRegistry, WorkspacePath};
     use std::io::Write as _;
 
     struct NormalRegistry;
@@ -2180,10 +2185,6 @@ mod tests {
         ) -> Box<dyn crate::provider::ProviderAdapter> {
             crate::provider::get_adapter(provider)
         }
-
-        fn error_lists(&self, _provider: crate::provider::Provider) -> ErrorLists {
-            ErrorLists::default()
-        }
     }
     #[test]
     fn abnormal_stale_error_baselines_then_fresh_alive_error_notifies() {