@svgrid/grid 2.2.32 → 2.4.0

package/src/columns.ts

@@ -2,125 +2,10 @@
 // reading/writing controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-  applyExcelFilter,
-  normalizeForFilter,
-  createColumnVirtualizer,
-  createCoreRowModel,
-  createExpandedRowModel,
-  createFilteredRowModel,
-  createGroupedRowModel,
-  createPaginatedRowModel,
-  createSvelteVirtualizer,
-  createSortedRowModel,
-  createSvGrid,
-  filterFns,
-  getGridCellA11yProps,
-  getGridCellDomId,
-  getGridHeaderA11yProps,
-  getGridRootA11yProps,
-  getGridRowA11yProps,
-  parseEditorValue,
-  normalizeEditorOptions,
-  sortFns,
-  tableFeatures,
-  rowSortingFeature,
-  columnFilteringFeature,
-  columnGroupingFeature,
-  type CellContext,
-  type EditorContext,
-  type CellEditorOption,
-  type CellEditorType,
-  type CellFormatter,
-  type CellFormatConfig,
-  type Column,
-  type ColumnDef,
-  type Row,
   type RowData,
-  type SvGridApi,
   type TableFeatures,
 } from "./index";
 import "./sv-grid-scrollbar";
-import type { Snippet } from "svelte";
-import { getKeyboardIntent, getNextActiveCell } from "./keyboard";
-import {
-  formatNumericWithConfig,
-  getDateFormatter,
-  resolveDatePattern,
-} from "./cell-formatting";
-import {
-  RenderSnippetConfig,
-  RenderComponentConfig,
-} from "./render-component";
-import { buildFillPattern } from "./fill-patterns";
-import { buildSparkline, toSparklineValues } from "./sparkline";
-import {
-  resolveCellFormat,
-  computeColumnStat,
-  formatsNeedingStats,
-  type ColumnStat,
-  type ResolvedCellFormat,
-} from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-  Props,
-  SelectionPoint,
-  SelectionRange,
-  CellEditState,
-  FilterOperator,
-  FilterOption,
-  MenuPosition,
-} from "./SvGrid.types";
-import {
-  cfTextStyle,
-  fmtStat,
-  getCellKey,
-  resolveClassList,
-  toDateInputValue,
-  toDateTimeLocalInputValue,
-  getEditableInputValue,
-  getEditorInputType,
-  toValueArray,
-  getOptionLabel,
-  getOptionColor,
-  colorfulChipStyle,
-  getEditorClass,
-  asDate,
-  clampMenuX,
-  cssEscape,
-  rawToNumber,
-  formatFacetNumber,
-  formatFacetDate,
-} from "./SvGrid.helpers";
-import { createGridApi } from "./build-api";
-import { createClipboard } from "./clipboard";
-import {
-  filterOperatorOptions,
-  fallbackOperatorOption,
-  TEXT_OPERATORS,
-  NUMBER_OPERATORS,
-  DATE_OPERATORS,
-  CHECKBOX_OPERATORS,
-  operatorOption,
-  operatorsForColumn,
-  defaultOperatorFor,
-  operatorLabelFor,
-} from "./filter-operators";
-import {
-  type FacetBucket,
-  isBucketableColumn,
-  buildBuckets,
-  isInBucket,
-} from "./facet-buckets";
-import {
-  getColumnBaseValue,
-  isGroupRow,
-  toolPanelHeaderLabel,
-  formatSummaryNumeric,
-  getColumnAlign,
-  getPinnedCellValue,
-  getColumnAccessorValue,
-  columnDefMatchesId,
-} from "./cell-values";
 
 export function createColumns<
   TFeatures extends TableFeatures = TableFeatures,
@@ -186,13 +71,18 @@ export function createColumns<
     if (!(ctx.props.enableColumnReorder ?? false)) return;
     ctx.colDragId = columnId;
     e.dataTransfer?.setData("text/plain", columnId);
-    e.dataTransfer!.effectAllowed = "move";
+    // Guarded, not asserted: `dataTransfer` is non-null in a real browser drag
+    // but null on a synthetic DragEvent. The `!` threw there, and because the
+    // throw landed after `colDragId` was set but before `colDropSide` was, the
+    // drop then silently no-op'd instead of surfacing the error. Matches the
+    // pattern row-drag.ts already uses.
+    if (e.dataTransfer) e.dataTransfer.effectAllowed = "move";
   }
 
   function onColumnHeaderDragOver(e: DragEvent, columnId: string) {
     if (!ctx.colDragId || ctx.colDragId === columnId) return;
     e.preventDefault();
-    e.dataTransfer!.dropEffect = "move";
+    if (e.dataTransfer) e.dataTransfer.dropEffect = "move";
     const rect = (e.currentTarget as HTMLElement).getBoundingClientRect();
     ctx.colDropSide = e.clientX < rect.left + rect.width / 2 ? "before" : "after";
     ctx.colDropOnId = columnId;

package/src/core.performance.test.ts

@@ -1,30 +1,30 @@
-import { describe, expect, it } from 'vitest'
-import { createCoreRowModel, createSortedRowModel, createSvGrid, sortFns, tableFeatures } from './index'
-
-describe('core performance smoke', () => {
-  it('handles large synthetic shape with bounded row model call', () => {
-    const columns = Array.from({ length: 50 }, (_, index) => ({
-      field: `c${index}`,
-      editorType: 'number' as const,
-    }))
-    const data = Array.from({ length: 5000 }, (_, rowIndex) => {
-      const row: Record<string, number> = {}
-      for (let col = 0; col < 50; col += 1) row[`c${col}`] = rowIndex + col
-      return row
-    })
-    const grid = createSvGrid({
-      _features: tableFeatures({}),
-      _rowModels: {
-        coreRowModel: createCoreRowModel(),
-        sortedRowModel: createSortedRowModel(sortFns),
-      },
-      columns,
-      data,
-      state: { sorting: [{ id: 'c0', desc: true }, { id: 'c1', desc: false }] },
-    })
-
-    const rows = grid.getRowModel().rows
-    expect(rows.length).toBe(5000)
-    expect(rows[0]?.getCellValueByColumnId('c0')).toBe(4999)
-  })
-})
+import { describe, expect, it } from 'vitest'
+import { createCoreRowModel, createSortedRowModel, createSvGrid, sortFns, tableFeatures } from './index'
+
+describe('core performance smoke', () => {
+  it('handles large synthetic shape with bounded row model call', () => {
+    const columns = Array.from({ length: 50 }, (_, index) => ({
+      field: `c${index}`,
+      editorType: 'number' as const,
+    }))
+    const data = Array.from({ length: 5000 }, (_, rowIndex) => {
+      const row: Record<string, number> = {}
+      for (let col = 0; col < 50; col += 1) row[`c${col}`] = rowIndex + col
+      return row
+    })
+    const grid = createSvGrid({
+      _features: tableFeatures({}),
+      _rowModels: {
+        coreRowModel: createCoreRowModel(),
+        sortedRowModel: createSortedRowModel(sortFns),
+      },
+      columns,
+      data,
+      state: { sorting: [{ id: 'c0', desc: true }, { id: 'c1', desc: false }] },
+    })
+
+    const rows = grid.getRowModel().rows
+    expect(rows.length).toBe(5000)
+    expect(rows[0]?.getCellValueByColumnId('c0')).toBe(4999)
+  })
+})