@surea11y/core 1.1.1 → 1.2.0

package/src/checks/automatic/tooltip-name-present.js

@@ -23,11 +23,10 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
+  const { document, helpers, rule } = ctx;
   const getEligibilityInfo = helpers && typeof helpers.getEligibilityInfo === 'function'
       ? helpers.getEligibilityInfo
       : null;
-  const safeRoot = root || document;
 
 
   function normalizeWs(s) {
@@ -91,7 +90,7 @@ function runInPage(ctx) {
   let applicableCount = 0;
 
   const selector = '[role="tooltip"]';
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector, safeRoot) : helpers.queryAll(selector, safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector) : helpers.queryAll(selector);
 
 
   function evaluate(el) {

package/src/checks/automatic/treeitem-name-present.js

@@ -23,11 +23,10 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
+  const { document, helpers, rule } = ctx;
   const getEligibilityInfo = helpers && typeof helpers.getEligibilityInfo === 'function'
       ? helpers.getEligibilityInfo
       : null;
-  const safeRoot = root || document;
 
 
   function normalizeWs(s) {
@@ -91,7 +90,7 @@ function runInPage(ctx) {
   let applicableCount = 0;
 
   const selector = "[role=\"treeitem\"]";
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector, safeRoot) : helpers.queryAll(selector, safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector) : helpers.queryAll(selector);
 
 
   function hasName(el) {

package/src/checks/automatic/valid-lang.js

@@ -47,12 +47,11 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   const BCP47_RE = /^[a-zA-Z]{2,3}(-[a-zA-Z0-9]{2,8})*$/;
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[lang]', safeRoot) : helpers.queryAll('[lang]', safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[lang]') : helpers.queryAll('[lang]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/accesskeys-manual.js

@@ -41,13 +41,7 @@ const meta = {
 
 function runInPage(ctx) {
   const { document, helpers, rule } = ctx;
-
-  let nodes = [];
-  try {
-    nodes = document.querySelectorAll('[accesskey]');
-  } catch {
-    nodes = [];
-  }
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[accesskey]') : helpers.queryAll('[accesskey]');
 
   const groups = new Map(); // normalized key -> elements[]
   for (const el of nodes) {

package/src/checks/manual/aria-checked-state-mismatch-manual.js

@@ -71,14 +71,13 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   function trim(v) { return (v == null ? '' : String(v)).trim(); }
 
   const nodes = helpers.queryAllSmart
-    ? helpers.queryAllSmart('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]', safeRoot)
-    : helpers.queryAll('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]', safeRoot);
+    ? helpers.queryAllSmart('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]')
+    : helpers.queryAll('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/aria-text-manual.js

@@ -46,13 +46,12 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   const FOCUSABLE_DESCENDANT_SELECTOR =
     'a[href], button, input, select, textarea, [tabindex], iframe, [contenteditable]:not([contenteditable="false"])';
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[role="text"]', safeRoot) : helpers.queryAll('[role="text"]', safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[role="text"]') : helpers.queryAll('[role="text"]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/empty-heading-manual.js

@@ -112,12 +112,7 @@ function runInPage(ctx) {
     return normalizeWs(el.getAttribute && el.getAttribute('title'));
   }
 
-  let nodes = [];
-  try {
-    nodes = document.querySelectorAll('h1, h2, h3, h4, h5, h6, [role]');
-  } catch {
-    nodes = [];
-  }
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('h1, h2, h3, h4, h5, h6, [role]') : helpers.queryAll('h1, h2, h3, h4, h5, h6, [role]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/empty-table-header-manual.js

@@ -94,15 +94,11 @@ function runInPage(ctx) {
     return '';
   }
 
-  let nodes = [];
-  try {
-    // Matches a widely-used reference engine's own empty-table-header selector exactly: a <th> with
-    // no conflicting explicit role, plus any element carrying an explicit
-    // columnheader/rowheader role (native or not).
-    nodes = document.querySelectorAll('th:not([role]), [role="columnheader"], [role="rowheader"]');
-  } catch {
-    nodes = [];
-  }
+  // Matches a widely-used reference engine's own empty-table-header selector exactly: a <th> with
+  // no conflicting explicit role, plus any element carrying an explicit
+  // columnheader/rowheader role (native or not).
+  const selector = 'th:not([role]), [role="columnheader"], [role="rowheader"]';
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector) : helpers.queryAll(selector);
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/focus-order-semantics-manual.js

@@ -48,8 +48,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   const NON_INTERACTIVE_ROLES = new Set([
     'generic', 'group', 'text', 'presentation', 'none', 'img', 'heading',
@@ -59,7 +58,7 @@ function runInPage(ctx) {
     'definition', 'paragraph', 'caption', 'status', 'alert', 'log', 'tooltip'
   ]);
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[tabindex][role]', safeRoot) : helpers.queryAll('[tabindex][role]', safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[tabindex][role]') : helpers.queryAll('[tabindex][role]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/heading-order-manual.js

@@ -72,12 +72,7 @@ function runInPage(ctx) {
     return m ? parseInt(m[1], 10) : 0;
   }
 
-  let nodes = [];
-  try {
-    nodes = document.querySelectorAll('h1, h2, h3, h4, h5, h6, [role]');
-  } catch {
-    nodes = [];
-  }
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('h1, h2, h3, h4, h5, h6, [role]') : helpers.queryAll('h1, h2, h3, h4, h5, h6, [role]');
 
   const headings = [];
   const seen = new Set();

package/src/checks/manual/identical-links-same-purpose-manual.js

@@ -52,14 +52,13 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   function normName(s) {
     return (s == null ? '' : String(s)).replace(/\s+/g, ' ').trim().toLowerCase();
   }
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('a[href]', safeRoot) : helpers.queryAll('a[href]', safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('a[href]') : helpers.queryAll('a[href]');
 
   const groups = new Map(); // normName -> [{ el, href }]
   let applicableCount = 0;

package/src/checks/manual/image-redundant-alt-manual.js

@@ -47,8 +47,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   function normalizeWs(s) {
     return String(s || '').replace(/\s+/g, ' ').trim();
@@ -67,7 +66,7 @@ function runInPage(ctx) {
     return normalizeWs(text);
   }
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('img[alt]', safeRoot) : helpers.queryAll('img[alt]', safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('img[alt]') : helpers.queryAll('img[alt]');
 
   const occurrences = [];
   let applicableCount = 0;

package/src/checks/manual/label-title-only-manual.js

@@ -45,11 +45,10 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, root, helpers, rule } = ctx;
-  const safeRoot = root || document;
+  const { document, helpers, rule } = ctx;
 
   const selector = 'input:not([type="hidden"]):not([type="submit"]):not([type="reset"]):not([type="button"]):not([type="image"]),select,textarea';
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector, safeRoot) : helpers.queryAll(selector, safeRoot);
+  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart(selector) : helpers.queryAll(selector);
 
   const labelsByFor = new Map();
   const allLabels = document.getElementsByTagName ? document.getElementsByTagName('label') : [];

package/src/checks/manual/landmark-banner-is-top-level-manual.js

@@ -52,7 +52,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { document, root, helpers, rule } = ctx;
 
   // Declared inside runInPage — see scripts/build-core.js header
   // ("runInPage MUST be self-contained").
@@ -81,25 +81,37 @@ function runInPage(ctx) {
     return raw.split(/\s+/)[0].toLowerCase();
   }
 
-  const SECTIONING_ANCESTORS = new Set(['article', 'aside', 'main', 'nav', 'section']);
-
-  function isSuppressedBySectioningAncestor(el) {
-    let p = el.parentElement;
-    while (p) {
-      const tag = p.tagName ? p.tagName.toLowerCase() : '';
-      if (SECTIONING_ANCESTORS.has(tag)) return true;
-      p = p.parentElement;
-    }
-    return false;
+  // Delegates to the shared helpers.hasLandmarkScopingAncestor for the
+  // question "does this element sit inside a sectioning-content/<main>
+  // ancestor that suppresses its conditional implicit role" — role-aware
+  // (an ancestor's bare TAG only counts when it carries no role attribute
+  // at all; an explicit role="dialog"-style override no longer suppresses)
+  // rather than a local tag-only copy. See that function's header comment
+  // in src/core/aria-helpers.js for the full algorithm and the real page
+  // (handsontable.com's docs-assistant side panel, an
+  // <aside role="dialog"> containing its own <header>) that surfaced this
+  // rule's own former tag-only copy as a false negative.
+  function hasSectioningAncestor(el, includeMain) {
+    return helpers && typeof helpers.hasLandmarkScopingAncestor === 'function'
+      ? helpers.hasLandmarkScopingAncestor(el, { includeMain })
+      : false;
   }
 
   function getImplicitLandmarkRole(el) {
     const tag = el.tagName ? el.tagName.toLowerCase() : '';
-    if (tag === 'header') return isSuppressedBySectioningAncestor(el) ? '' : 'banner';
-    if (tag === 'footer') return isSuppressedBySectioningAncestor(el) ? '' : 'contentinfo';
+    if (tag === 'header') return hasSectioningAncestor(el, true) ? '' : 'banner';
+    if (tag === 'footer') return hasSectioningAncestor(el, true) ? '' : 'contentinfo';
     if (tag === 'main') return 'main';
     if (tag === 'nav') return 'navigation';
-    if (tag === 'aside') return isSuppressedBySectioningAncestor(el) ? '' : 'complementary';
+    if (tag === 'aside') {
+      // A named <aside> is never suppressed, even when nested — matches
+      // landmark-unique's own verified-against-reference-engine precedent
+      // (that engine's real `aside` implicit-role function keeps
+      // "complementary" when the element has an accessible name, even
+      // inside sectioning content); propagated here for consistency.
+      if (!hasSectioningAncestor(el, false)) return 'complementary';
+      return getAccessibleLandmarkName(el) ? 'complementary' : '';
+    }
     if (tag === 'section') return getAccessibleLandmarkName(el) ? 'region' : '';
     if (tag === 'form') return getAccessibleLandmarkName(el) ? 'form' : '';
     return '';
@@ -115,9 +127,13 @@ function runInPage(ctx) {
   }
 
   function hasLandmarkAncestor(el) {
+    const scopeRoots = Array.isArray(root) ? root : (root ? [root] : []);
     let p = el.parentElement;
     while (p) {
       if (getLandmarkRole(p)) return true;
+      // Don't climb past the scanned scope -- see aria-helpers.js's
+      // hasLandmarkScopingAncestor for the same fix and rationale.
+      if (scopeRoots.includes(p)) break;
       p = p.parentElement;
     }
     return false;

package/src/checks/manual/landmark-contentinfo-is-top-level-manual.js

@@ -43,7 +43,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { document, root, helpers, rule } = ctx;
 
   function normalizeWs(s) {
     return String(s || '').replace(/\s+/g, ' ').trim();
@@ -70,25 +70,37 @@ function runInPage(ctx) {
     return raw.split(/\s+/)[0].toLowerCase();
   }
 
-  const SECTIONING_ANCESTORS = new Set(['article', 'aside', 'main', 'nav', 'section']);
-
-  function isSuppressedBySectioningAncestor(el) {
-    let p = el.parentElement;
-    while (p) {
-      const tag = p.tagName ? p.tagName.toLowerCase() : '';
-      if (SECTIONING_ANCESTORS.has(tag)) return true;
-      p = p.parentElement;
-    }
-    return false;
+  // Delegates to the shared helpers.hasLandmarkScopingAncestor for the
+  // question "does this element sit inside a sectioning-content/<main>
+  // ancestor that suppresses its conditional implicit role" — role-aware
+  // (an ancestor's bare TAG only counts when it carries no role attribute
+  // at all; an explicit role="dialog"-style override no longer suppresses)
+  // rather than a local tag-only copy. See that function's header comment
+  // in src/core/aria-helpers.js for the full algorithm and the real page
+  // (handsontable.com's docs-assistant side panel, an
+  // <aside role="dialog"> containing its own <header>) that surfaced this
+  // rule's own former tag-only copy as a false negative.
+  function hasSectioningAncestor(el, includeMain) {
+    return helpers && typeof helpers.hasLandmarkScopingAncestor === 'function'
+      ? helpers.hasLandmarkScopingAncestor(el, { includeMain })
+      : false;
   }
 
   function getImplicitLandmarkRole(el) {
     const tag = el.tagName ? el.tagName.toLowerCase() : '';
-    if (tag === 'header') return isSuppressedBySectioningAncestor(el) ? '' : 'banner';
-    if (tag === 'footer') return isSuppressedBySectioningAncestor(el) ? '' : 'contentinfo';
+    if (tag === 'header') return hasSectioningAncestor(el, true) ? '' : 'banner';
+    if (tag === 'footer') return hasSectioningAncestor(el, true) ? '' : 'contentinfo';
     if (tag === 'main') return 'main';
     if (tag === 'nav') return 'navigation';
-    if (tag === 'aside') return isSuppressedBySectioningAncestor(el) ? '' : 'complementary';
+    if (tag === 'aside') {
+      // A named <aside> is never suppressed, even when nested — matches
+      // landmark-unique's own verified-against-reference-engine precedent
+      // (that engine's real `aside` implicit-role function keeps
+      // "complementary" when the element has an accessible name, even
+      // inside sectioning content); propagated here for consistency.
+      if (!hasSectioningAncestor(el, false)) return 'complementary';
+      return getAccessibleLandmarkName(el) ? 'complementary' : '';
+    }
     if (tag === 'section') return getAccessibleLandmarkName(el) ? 'region' : '';
     if (tag === 'form') return getAccessibleLandmarkName(el) ? 'form' : '';
     return '';
@@ -104,9 +116,13 @@ function runInPage(ctx) {
   }
 
   function hasLandmarkAncestor(el) {
+    const scopeRoots = Array.isArray(root) ? root : (root ? [root] : []);
     let p = el.parentElement;
     while (p) {
       if (getLandmarkRole(p)) return true;
+      // Don't climb past the scanned scope -- see aria-helpers.js's
+      // hasLandmarkScopingAncestor for the same fix and rationale.
+      if (scopeRoots.includes(p)) break;
       p = p.parentElement;
     }
     return false;

package/src/checks/manual/landmark-main-is-top-level-manual.js

@@ -41,7 +41,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { document, root, helpers, rule } = ctx;
 
   function normalizeWs(s) {
     return String(s || '').replace(/\s+/g, ' ').trim();
@@ -68,25 +68,37 @@ function runInPage(ctx) {
     return raw.split(/\s+/)[0].toLowerCase();
   }
 
-  const SECTIONING_ANCESTORS = new Set(['article', 'aside', 'main', 'nav', 'section']);
-
-  function isSuppressedBySectioningAncestor(el) {
-    let p = el.parentElement;
-    while (p) {
-      const tag = p.tagName ? p.tagName.toLowerCase() : '';
-      if (SECTIONING_ANCESTORS.has(tag)) return true;
-      p = p.parentElement;
-    }
-    return false;
+  // Delegates to the shared helpers.hasLandmarkScopingAncestor for the
+  // question "does this element sit inside a sectioning-content/<main>
+  // ancestor that suppresses its conditional implicit role" — role-aware
+  // (an ancestor's bare TAG only counts when it carries no role attribute
+  // at all; an explicit role="dialog"-style override no longer suppresses)
+  // rather than a local tag-only copy. See that function's header comment
+  // in src/core/aria-helpers.js for the full algorithm and the real page
+  // (handsontable.com's docs-assistant side panel, an
+  // <aside role="dialog"> containing its own <header>) that surfaced this
+  // rule's own former tag-only copy as a false negative.
+  function hasSectioningAncestor(el, includeMain) {
+    return helpers && typeof helpers.hasLandmarkScopingAncestor === 'function'
+      ? helpers.hasLandmarkScopingAncestor(el, { includeMain })
+      : false;
   }
 
   function getImplicitLandmarkRole(el) {
     const tag = el.tagName ? el.tagName.toLowerCase() : '';
-    if (tag === 'header') return isSuppressedBySectioningAncestor(el) ? '' : 'banner';
-    if (tag === 'footer') return isSuppressedBySectioningAncestor(el) ? '' : 'contentinfo';
+    if (tag === 'header') return hasSectioningAncestor(el, true) ? '' : 'banner';
+    if (tag === 'footer') return hasSectioningAncestor(el, true) ? '' : 'contentinfo';
     if (tag === 'main') return 'main';
     if (tag === 'nav') return 'navigation';
-    if (tag === 'aside') return isSuppressedBySectioningAncestor(el) ? '' : 'complementary';
+    if (tag === 'aside') {
+      // A named <aside> is never suppressed, even when nested — matches
+      // landmark-unique's own verified-against-reference-engine precedent
+      // (that engine's real `aside` implicit-role function keeps
+      // "complementary" when the element has an accessible name, even
+      // inside sectioning content); propagated here for consistency.
+      if (!hasSectioningAncestor(el, false)) return 'complementary';
+      return getAccessibleLandmarkName(el) ? 'complementary' : '';
+    }
     if (tag === 'section') return getAccessibleLandmarkName(el) ? 'region' : '';
     if (tag === 'form') return getAccessibleLandmarkName(el) ? 'form' : '';
     return '';
@@ -102,9 +114,13 @@ function runInPage(ctx) {
   }
 
   function hasLandmarkAncestor(el) {
+    const scopeRoots = Array.isArray(root) ? root : (root ? [root] : []);
     let p = el.parentElement;
     while (p) {
       if (getLandmarkRole(p)) return true;
+      // Don't climb past the scanned scope -- see aria-helpers.js's
+      // hasLandmarkScopingAncestor for the same fix and rationale.
+      if (scopeRoots.includes(p)) break;
       p = p.parentElement;
     }
     return false;

package/src/checks/manual/landmark-no-duplicate-banner-manual.js

@@ -79,25 +79,37 @@ function runInPage(ctx) {
     return raw.split(/\s+/)[0].toLowerCase();
   }
 
-  const SECTIONING_ANCESTORS = new Set(['article', 'aside', 'main', 'nav', 'section']);
-
-  function isSuppressedBySectioningAncestor(el) {
-    let p = el.parentElement;
-    while (p) {
-      const tag = p.tagName ? p.tagName.toLowerCase() : '';
-      if (SECTIONING_ANCESTORS.has(tag)) return true;
-      p = p.parentElement;
-    }
-    return false;
+  // Delegates to the shared helpers.hasLandmarkScopingAncestor for the
+  // question "does this element sit inside a sectioning-content/<main>
+  // ancestor that suppresses its conditional implicit role" — role-aware
+  // (an ancestor's bare TAG only counts when it carries no role attribute
+  // at all; an explicit role="dialog"-style override no longer suppresses)
+  // rather than a local tag-only copy. See that function's header comment
+  // in src/core/aria-helpers.js for the full algorithm and the real page
+  // (handsontable.com's docs-assistant side panel, an
+  // <aside role="dialog"> containing its own <header>) that surfaced this
+  // rule's own former tag-only copy as a false negative.
+  function hasSectioningAncestor(el, includeMain) {
+    return helpers && typeof helpers.hasLandmarkScopingAncestor === 'function'
+      ? helpers.hasLandmarkScopingAncestor(el, { includeMain })
+      : false;
   }
 
   function getImplicitLandmarkRole(el) {
     const tag = el.tagName ? el.tagName.toLowerCase() : '';
-    if (tag === 'header') return isSuppressedBySectioningAncestor(el) ? '' : 'banner';
-    if (tag === 'footer') return isSuppressedBySectioningAncestor(el) ? '' : 'contentinfo';
+    if (tag === 'header') return hasSectioningAncestor(el, true) ? '' : 'banner';
+    if (tag === 'footer') return hasSectioningAncestor(el, true) ? '' : 'contentinfo';
     if (tag === 'main') return 'main';
     if (tag === 'nav') return 'navigation';
-    if (tag === 'aside') return isSuppressedBySectioningAncestor(el) ? '' : 'complementary';
+    if (tag === 'aside') {
+      // A named <aside> is never suppressed, even when nested — matches
+      // landmark-unique's own verified-against-reference-engine precedent
+      // (that engine's real `aside` implicit-role function keeps
+      // "complementary" when the element has an accessible name, even
+      // inside sectioning content); propagated here for consistency.
+      if (!hasSectioningAncestor(el, false)) return 'complementary';
+      return getAccessibleLandmarkName(el) ? 'complementary' : '';
+    }
     if (tag === 'section') return getAccessibleLandmarkName(el) ? 'region' : '';
     if (tag === 'form') return getAccessibleLandmarkName(el) ? 'form' : '';
     return '';

package/src/checks/manual/landmark-no-duplicate-contentinfo-manual.js

@@ -71,25 +71,37 @@ function runInPage(ctx) {
     return raw.split(/\s+/)[0].toLowerCase();
   }
 
-  const SECTIONING_ANCESTORS = new Set(['article', 'aside', 'main', 'nav', 'section']);
-
-  function isSuppressedBySectioningAncestor(el) {
-    let p = el.parentElement;
-    while (p) {
-      const tag = p.tagName ? p.tagName.toLowerCase() : '';
-      if (SECTIONING_ANCESTORS.has(tag)) return true;
-      p = p.parentElement;
-    }
-    return false;
+  // Delegates to the shared helpers.hasLandmarkScopingAncestor for the
+  // question "does this element sit inside a sectioning-content/<main>
+  // ancestor that suppresses its conditional implicit role" — role-aware
+  // (an ancestor's bare TAG only counts when it carries no role attribute
+  // at all; an explicit role="dialog"-style override no longer suppresses)
+  // rather than a local tag-only copy. See that function's header comment
+  // in src/core/aria-helpers.js for the full algorithm and the real page
+  // (handsontable.com's docs-assistant side panel, an
+  // <aside role="dialog"> containing its own <header>) that surfaced this
+  // rule's own former tag-only copy as a false negative.
+  function hasSectioningAncestor(el, includeMain) {
+    return helpers && typeof helpers.hasLandmarkScopingAncestor === 'function'
+      ? helpers.hasLandmarkScopingAncestor(el, { includeMain })
+      : false;
   }
 
   function getImplicitLandmarkRole(el) {
     const tag = el.tagName ? el.tagName.toLowerCase() : '';
-    if (tag === 'header') return isSuppressedBySectioningAncestor(el) ? '' : 'banner';
-    if (tag === 'footer') return isSuppressedBySectioningAncestor(el) ? '' : 'contentinfo';
+    if (tag === 'header') return hasSectioningAncestor(el, true) ? '' : 'banner';
+    if (tag === 'footer') return hasSectioningAncestor(el, true) ? '' : 'contentinfo';
     if (tag === 'main') return 'main';
     if (tag === 'nav') return 'navigation';
-    if (tag === 'aside') return isSuppressedBySectioningAncestor(el) ? '' : 'complementary';
+    if (tag === 'aside') {
+      // A named <aside> is never suppressed, even when nested — matches
+      // landmark-unique's own verified-against-reference-engine precedent
+      // (that engine's real `aside` implicit-role function keeps
+      // "complementary" when the element has an accessible name, even
+      // inside sectioning content); propagated here for consistency.
+      if (!hasSectioningAncestor(el, false)) return 'complementary';
+      return getAccessibleLandmarkName(el) ? 'complementary' : '';
+    }
     if (tag === 'section') return getAccessibleLandmarkName(el) ? 'region' : '';
     if (tag === 'form') return getAccessibleLandmarkName(el) ? 'form' : '';
     return '';

package/src/checks/manual/landmark-one-main-manual.js

@@ -61,6 +61,14 @@ const meta = {
   coverage: {}
 };
 
+// This check is inherently whole-document (does the PAGE have this
+// property?), not evaluable per-subtree -- notApplicable when contextSelector
+// scoped this run narrower than the whole document, or when
+// engineOptions.fragment:true was set (see helpers.isWholeDocumentScope).
+function applicability(ctx) {
+  return ctx.helpers.isWholeDocumentScope ? ctx.helpers.isWholeDocumentScope() : true;
+}
+
 function runInPage(ctx) {
   const { document, helpers, rule } = ctx;
 
@@ -148,4 +156,4 @@ function runInPage(ctx) {
   };
 }
 
-module.exports = { id, meta, runInPage };
+module.exports = { id, meta, runInPage, applicability };