@sun-asterisk/sunlint 1.3.16 → 1.3.17

package/rules/common/C033_separate_service_repository/README.md

@@ -2,23 +2,38 @@
 
 ## Rule Description
 
-Enforces proper separation between Service and Repository layers in your application architecture:
+**Mục tiêu:** Tách rõ ràng business logic và data access logic trong kiến trúc ứng dụng
 
-- **Services** should contain business logic and use repositories for data access
-- **Repositories** should contain only data access logic, no business rules
+### Nguyên tắc
+
+- ✅ **Repository** chỉ chứa các phương thức truy vấn dữ liệu cơ bản (CRUD)
+- ✅ **Service** chứa business logic và sử dụng Repository để truy vấn dữ liệu
+- ✅ Mỗi Service nên có một Repository tương ứng
+- ✅ Sử dụng dependency injection để inject Repository vào Service
+- ❌ Tránh viết business logic trong Repository
+- ❌ Service không nên trực tiếp gọi database/ORM
+
+### Lợi ích
+
+- 🔄 Tăng khả năng tái sử dụng và test
+- 🎯 Tách biệt rõ ràng giữa business logic và data access
+- 🔧 Dễ dàng thay đổi implementation của data access layer
+- 📈 Tăng tính maintainable của code
+- ✨ Tuân thủ nguyên tắc Single Responsibility
 
 ## Architecture
 
-This rule uses a **hybrid analysis approach**:
+Rule này sử dụng **hybrid analysis approach**:
 
-1. **Primary: Symbol-based Analysis** (using ts-morph)
-   - AST parsing and symbol resolution
-   - Accurate detection of database operations
-   - Excludes queue/job operations automatically
+1. **Primary: Symbol-based Analysis** (ts-morph AST)
+   - Phân tích semantic và symbol resolution
+   - Phát hiện chính xác database operations
+   - Kiểm tra dependency injection patterns
+   - Phát hiện business logic trong Repository
 
 2. **Fallback: Regex-based Analysis**
-   - Pattern matching for when symbol analysis fails
-   - Handles edge cases and complex code structures
+   - Pattern matching khi symbol analysis không khả dụng
+   - Xử lý edge cases và complex code structures
 
 ## Files Structure
 
@@ -33,20 +48,116 @@ C033_separate_service_repository/
 
 ## What this rule detects
 
-### Violations in Service files:
-- Direct database calls (`repository.createQueryBuilder()`, `dataSource.createQueryBuilder()`)
-- Direct ORM operations (`entity.save()`, `entity.find()`)
-- SQL queries embedded in service methods
-- **Excludes**: Queue/job operations (`job.remove()`, `job.isFailed()`, etc.)
+### 🚫 Violations in Service files
+
+- Direct database/ORM operations without Repository
+  - `findOne()`, `save()`, `update()`, `delete()`, `query()`
+  - `createQueryBuilder()`, `getRepository()`, `getConnection()`
+- Service không inject Repository qua constructor
+- Mixed business logic với data access trong cùng method
+
+### 🚫 Violations in Repository files
+
+- Business logic trong Repository methods
+  - Method names chứa: `validate`, `calculate`, `process`, `transform`
+  - Logic phức tạp: nhiều if/else, loops (>2 control structures)
+- Business calculations, validations, transformations
+- Complex workflows và business rules
+
+### 🚫 Violations in Controller files
+
+- Controller trực tiếp gọi database operations
+- Bỏ qua Service layer
 
-### Violations in Repository files:
-- Complex business logic (filtering, calculations, validations)
-- Business rules and workflows
-- Complex conditional logic for data processing
+### 🚫 Architecture violations
+
+- Service và Repository cùng trong một file
+- Không tách biệt concerns rõ ràng
 
 ## Examples
 
-See test cases in the standard test fixtures location:
+### ❌ BAD: Service directly accessing database
+
+```typescript
+// service-bad.ts
+class UserService {
+  async getUser(id: string) {
+    // VIOLATION: Direct database access in Service
+    return await this.dataSource
+      .getRepository(User)
+      .findOne({ where: { id } });
+  }
+}
+```
+
+### ✅ GOOD: Service uses Repository
+
+```typescript
+// user.service.ts
+class UserService {
+  constructor(
+    private readonly userRepository: UserRepository  // DI
+  ) {}
+  
+  async getUser(id: string) {
+    return await this.userRepository.findById(id);
+  }
+  
+  async validateAndCreateUser(data: CreateUserDto) {
+    // Business logic in Service
+    this.validate(data);
+    const user = this.transform(data);
+    return await this.userRepository.create(user);
+  }
+}
+
+// user.repository.ts  
+class UserRepository {
+  // Only CRUD operations
+  async findById(id: string) {
+    return await this.db.users.findOne({ where: { id } });
+  }
+  
+  async create(user: User) {
+    return await this.db.users.save(user);
+  }
+}
+```
+
+### ❌ BAD: Repository with business logic
+
+```typescript
+// repository-bad.ts
+class UserRepository {
+  async validateAndSave(user: User) {
+    // VIOLATION: Business logic in Repository
+    if (user.age < 18) {
+      throw new Error('User must be 18+');
+    }
+    
+    if (!user.email.includes('@')) {
+      throw new Error('Invalid email');
+    }
+    
+    return await this.save(user);
+  }
+}
+```
+
+### ✅ GOOD: Repository only handles data access
+
+```typescript
+// repository-good.ts
+class UserRepository {
+  // Simple CRUD - no business logic
+  async save(user: User) {
+    return await this.db.users.save(user);
+  }
+  
+  async findByEmail(email: string) {
+    return await this.db.users.findOne({ where: { email } });
+  }
+}
 
 - **Violations**: `examples/rule-test-fixtures/rules/C033_separate_service_repository/violations/test-cases.js`
 - **Clean code**: `examples/rule-test-fixtures/rules/C033_separate_service_repository/clean/good-examples.js`

package/rules/common/C033_separate_service_repository/analyzer.js

@@ -82,7 +82,7 @@ class C033Analyzer {
     // 1. Try Symbol-based analysis first (primary)
     if (this.config.useSymbolBased && this.semanticEngine?.project) {
       try {
-        const sourceFile = this.semanticEngine.project.getSourceFileByFilePath(filePath);
+        const sourceFile = this.semanticEngine.project.getSourceFile(filePath);
         if (sourceFile) {
           const violations = await this.symbolBasedAnalyzer.analyzeFileWithSymbols(filePath, options);