@sun-asterisk/sunlint 1.3.16 → 1.3.17

package/rules/common/C018_no_throw_generic_error/analyzer.js

@@ -23,7 +23,7 @@ class C018Analyzer {
     // Configuration
     this.config = {
       useSymbolBased: true,      // Primary approach
-      fallbackToRegex: true,     // Only when symbol fails completely
+      fallbackToRegex: false,     // Only when symbol fails completely
       symbolBasedOnly: false     // Can be set to true for pure mode
     };
 

package/rules/common/C018_no_throw_generic_error/symbol-based-analyzer.js

@@ -149,13 +149,37 @@ class C018SymbolBasedAnalyzer {
     const lineNumber = throwStatement.getStartLineNumber();
     const columnNumber = throwStatement.getStart() - throwStatement.getStartLinePos();
     const exp = throwStatement.getExpression();
+    if (!exp) return violations;
+
+    // ---------------------------
+    // Case: throw e (Identifier)
+    // ---------------------------
+    let current = throwStatement.getParent();
+    let insideInstanceofCheck = false;
+
+    // Walk up AST tree to detect if inside an if-statement using instanceof
+    while (current) {
+      if (current.getKind() === SyntaxKind.IfStatement) {
+        const condition = current.getExpression();
+        if (condition && condition.getText().includes('instanceof')) {
+          insideInstanceofCheck = true;
+          break;
+        }
+      }
+      current = current.getParent();
+    }
 
-    if (!exp) {
-      return violations; // No arguments to analyze;
+    if (insideInstanceofCheck) {
+      if (verbose) {
+        console.log(
+          `[C018] Skipping throw at line ${lineNumber} due to instanceof guard`
+        );
+      }
+      return violations; // ✅ Skip violation
     }
 
-    // Case: throw e (identifier)
     if (exp.getKind() === SyntaxKind.Identifier) {
+      // Direct rethrow: throw error;
       violations.push({
         ruleId: this.ruleId,
         severity: 'error',