@suffolklitlab/alkiln 5.12.0 → 5.13.0-logs1

package/lib/scope.js

@@ -13,14 +13,13 @@ const pdf_reader = require('./utils/pdf_reader');
 const session_vars = require('./utils/session_vars');
 const get_base_interview_url = require(`./docassemble/get_base_interview_url`);
 const time = require('./utils/time');
-const log = require('./utils/log');
+// const log = require('./utils/log');
 const { waitForTimeout } = require('./utils/time');
 const files = require('./utils/files' );
-const server = require('./docassemble/docassemble_api_interface');
+const da_api = require('./docassemble/docassemble_api_interface');
 const wrapPromiseWithTimeout = require('./cucumber_8_shim');
 const reports = require(`./utils/reports`);
 
-
 let ordinal_to_integer = {
   only: 0, first: 0, second: 1, third: 2, fourth: 3, fifth: 4,
   sixth: 5, seventh: 6, eighth: 7, ninth: 8, tenth: 9,
@@ -84,10 +83,16 @@ let toBase64 = function ( utf8_str, exclude_padding=true) {
 
 let proxies_regex = /(\bx\.)|(\bx\[)|(\[[ijklmn]\])/g;
 let da_base64_regex = /^[A-Za-z0-9+/]+$/;
+let log = null;
 
 module.exports = {
   trigger_not_needed_flag: `ALKiln: no trigger variable needed`,
 
+
+  set_log: function ({ log_obj }) {
+    log = log_obj;
+  },
+
   getSafeScenarioBaseFilename: async function( scope, { scenario }) {
     /** Return a string that's safe to be a filename. Include the Scenario
     *    description and tags.
@@ -171,7 +176,7 @@ module.exports = {
     // If something might be hidden or shown, wait extra time to let it hide or show
     // I think `.$()` does not use a timeout
     let showif = await scope.page.$('.dashowif');
-    if ( showif ) { await scope.page.waitForTimeout( scope.showif_timeout ); }
+    if ( showif ) { await time.waitForTimeout( scope.showif_timeout ); }
   },
 
   waitForTab: async function waitForTab(scope, { tab_id }) {
@@ -288,9 +293,7 @@ module.exports = {
     /** Tap a given element, detect navigation, and do appropriate related things.
     *  `click_promise can be any kind of Promise, including a Promise.all()
     */
-    let msg = `Cannot find the element to tap.`;
-    if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0102`, value: msg }); }
-    expect( elem, msg ).to.exist;
+    await scope.guard_against_missing_tap_element(scope, { elem });
 
     // Get the text on the button or link for a potential error message later
     let tapperText = await (await elem.getProperty('textContent')).jsonValue();
@@ -326,6 +329,14 @@ module.exports = {
     }  // ends try/catch
   },  // Ends scope.tapElementAndStayOnPage()
 
+  guard_against_missing_tap_element: async function(scope, { elem }) {
+    /** Handle the error message for a missing tap element, if it's missing. */
+    let msg = `Cannot find the element to tap.`;
+    if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0102`, value: msg }); }
+    expect( elem, msg ).to.exist;
+    return elem;
+  },
+
   // Handle server reload errors
   server_statuses: [],
   server_check_interval_ms: 1 * 1000,
@@ -339,7 +350,7 @@ module.exports = {
       // This code assumes a reasonable response time would be n seconds if the
       // server is up and that a server reload/restart won't take less than n seconds.
       // Also, it's non-blocking, so it doesn't slow down tests
-      let is_up = await server.is_server_responding({ timeout: scope.server_check_interval_ms });
+      let is_up = await da_api.is_server_responding({ timeout: scope.server_check_interval_ms });
       // Add status to the beginning of the list to make truncating easier
       scope.server_statuses.unshift( is_up );
 
@@ -501,7 +512,7 @@ module.exports = {
     if ( diff <= 0 ) { return false; }
 
     // If time hasn't expired, wait and then check again
-    await scope.page.waitForTimeout( 100 );
+    await time.waitForTimeout( 100 );
     await scope.detectDownloadComplete(scope, endTime);
 
     return false;
@@ -627,7 +638,7 @@ module.exports = {
       interview_url = `${ base_url }${ file_name }`;
     }
 
-    reports.addToReport(scope,{
+    reports.addToReport(scope, {
       code: `ALK0113`,
       type: `row info`,
       value: `Trying to load the interview at "${ interview_url }"`
@@ -638,7 +649,17 @@ module.exports = {
     // TODO: implement and use scope.handle_possible_timeout()
     try {
 
-      await scope.page.goto(interview_url, { waitUntil: 'domcontentloaded', timeout: scope.timeout })
+      await scope.page.goto(interview_url, { waitUntil: 'domcontentloaded', timeout: scope.timeout });
+      // Get interview session values, if possible, so we can delete the session later
+      let interview_vars = await scope.page.evaluate(async function() {
+        try {
+          // won't exist on non-da interview pages
+          return await get_interview_variables();
+        } catch (error) {
+          return null;
+        }
+      });
+      scope.set_interview_session_data( scope, { vars: interview_vars });
 
     } catch ( error ) {
 
@@ -676,12 +697,42 @@ module.exports = {
       });
       expect( load_result.error ).to.equal( '' );
     } else {
-      reports.addToReport(scope, { type: `row info`, code: `ALK0117`, value: `Successfully found the interview at "${ interview_url }"` });
+      reports.addToReport(scope, { type: `row info`, code: `ALK0117`, value: `Successfully found the interview` });
     }
 
     return scope.page;
   },  // Ends scope.load()
 
+  set_interview_session_data: function ( scope, { vars = null }) {
+    /** Sets this interview's session data for this scenario if it doesn't
+     *    already exist.
+     *
+     * @returns final_vars { object | null }
+     * @returns final_vars.i { str } File path of interview
+     * @returns final_vars.uid { str } UID of interview
+     * */
+    if ( vars && vars.i ) {
+      let scenario = scope.scenarios.get( scope.scenario_id );
+      if ( !scenario.interviews ) { scenario.interviews = {}; }
+      if ( !scenario.interviews[ vars.uid ] ) {
+        scenario.interviews[ vars.uid ] = vars;
+        log.debug({ code: `ALK0185`, context: `session_id_etc` },
+          `Saved new interview data. File path: ${ vars.i }. Session id: ${ vars.uid }.`
+        );
+      } else {
+        log.debug({ code: `ALK0186`, context: `session_id_etc` },
+          `Interview data already existed. File path: ${ vars.i }. Session id: ${ vars.uid }.`
+        );
+      }
+      return vars;
+    } else {
+      log.debug({ code: `ALK0187`, context: `session_id_etc` },
+        `Found no interview data.`
+      );
+      return null;
+    }
+  },  // Ends scope.set_interview_session_data()
+
   getLoadData: async function ( scope ) {
     /* Return elements that could load on the page, like #daMainQuestion
     * and #da-retry. If there's a system error on the page, return its main text.
@@ -771,7 +822,7 @@ module.exports = {
             if ( row_raw.length > 3 ) { more_or_less = `less`; }
             let bad_table_msg = `Your Story Table should have ${ more_or_less } than`
               + ` ${ row_raw.length } columns. Take another look at Story Table documentation at`
-              + ` https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#story-tables.`
+              + ` https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/writing#story-table.`
             reports.addToReport( scope, { type: `error`, code: `ALK0120`, value: bad_table_msg})
             throw Error(bad_table_msg);
           }
@@ -798,7 +849,7 @@ module.exports = {
           let not_in_env_msg = `ALKiln could not find the GitHub secret "${ row.flags.secret_name }".`
             + ` Check for a typo and check your workflow file.`
             + ` Read more about using GitHub secrets in your workflow file at`
-            + ` https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#github-secrets.`
+            + ` https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/writing#secrets.`
           reports.addToReport( scope, { type: `error`, code: `ALK0121`, value: not_in_env_msg });
           throw ReferenceError(not_in_env_msg);
         }
@@ -824,11 +875,9 @@ module.exports = {
       supported_table.push( result );
     }  // ends for every row
 
-    log.debug({
-      code: `ALK0122`,
-      type: `info`,
-      pre: `scope.normalizedTable():\n ${JSON.stringify( supported_table )}`
-    });
+    log.debug({ code: `ALK0122`, context: `table`, },
+      `scope.normalizedTable():`, supported_table
+    );
 
     return supported_table;
   },  // Ends scope.normalizeTable()
@@ -978,11 +1027,9 @@ module.exports = {
       fields.push( field_data );
     }  // ends for every node
 
-    log.debug({
-      code: `ALK0124`,
-      type: `info`,
-      pre: `page fields:\n${ JSON.stringify( fields )}`
-    });
+    log.debug({ code: `ALK0124`, context: `page fields`, },
+      fields
+    );
     return fields;
   },  // Ends scope.getAllFields()
 
@@ -1032,11 +1079,9 @@ module.exports = {
     /* Return variable names and values combined in ways that can
     * try to match table rows. Tables can have two properties:
     * variable name and value. */
-    log.debug({
-      code: `ALK0126`,
-      type: `info`,
-      pre: `scope.getPossibleTableRowMatchers() var_names: ${JSON.stringify(var_names)} values: ${JSON.stringify(values)}`
-    });
+    log.debug({ code: `ALK0126`, context: `matching`, },
+      `scope.getPossibleTableRowMatchers() var_names:`, var_names, `values:`, values
+    );
     let possible_table_rows = [];
     for ( let var_name of var_names ) {
       // Inputs like textareas don't have values
@@ -1317,6 +1362,7 @@ module.exports = {
     * setting fields, and an object for a DOM field, returns list of the
     * rows that match the DOM field. That list of story table rows may be empty.
     *
+    * Using a `trigger` column is deprecated, but still used in many tests in the wild.
     * For notes on trigger var, see https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#trigger
     * 
     * @param var_data {arr} - fields and the values they can be set to
@@ -1411,9 +1457,13 @@ module.exports = {
 
       // field/page trigger name is needed but is missing.
       if ( !page_trigger_name ) {
-        let page_trigger_warning = `A field on this page uses an index `
-          + `variable or a generic object, but the page is missing `
-          + `the ALKiln "trigger" variable's name. See `
+        let page_trigger_warning = `You are using a 3-column Story Table. If possible, you should `
+          + `think about switching to the newer, easier, 2-column Story Table. That will probably `
+          + `get rid of this warning. Read more at `
+          + `https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/trouble#deprecated-story-tables. `
+          + `If you still want to use this 3-column format, here is more info about the warning: `
+          + `A field on this page uses an index variable or a generic object in a 3-column `
+          + `Story Table, but the page is missing the ALKiln "trigger" variable's name. See `
           + `https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#a-missing-trigger-variable.`;
         reports.addToReport(scope, { type: `warning`, code: `ALK0127`, value: page_trigger_warning });
       }
@@ -1430,7 +1480,7 @@ module.exports = {
 
           // First, make the row data more readable to humans.
           let row_as_story_table = reports.convertToOriginalStoryTableRow( scope, { row_data: row_that_matches_this_field });
-          let row_trigger_warning = `This Story Table row needs a value in the "trigger" `
+          let row_trigger_warning = `This 3-column Story Table row needs a value in the "trigger" `
             + `column, but it is empty. The test might get unexpected results. See `
             + `https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#trigger.`
             + `\nThe rows:\n${ row_as_story_table }`;
@@ -1467,7 +1517,7 @@ module.exports = {
 
         let all_trigger_names_conflict_msg = `${ rows_that_match_field_names.length } `
           + `Story Table row(s) matched a field name, but didn't match a trigger `
-          + `variable. The Story Table might be missng a row or a trigger variable. `
+          + `variable. This 3-column Story Table might be missing a row or a trigger variable. `
           + `The test will have to ignore this field. See `
           + `https://suffolklitlab.org/docassemble-AssemblyLine-documentation/docs/alkiln/#trigger.`
           + `\nThe row(s) data:\n${ conflicts_as_story_table_rows.join( `\n` )}`
@@ -1506,17 +1556,13 @@ module.exports = {
       reports.addToReport(scope, { type: `warning`, code: `ALK0130`, value: multiple_matches_msg });
     }
 
-    log.debug({
-      code: `ALK0131`,
-      type: `info`,
-      pre: `final_matching_rows:\n${JSON.stringify( final_matching_rows )}`
-    });
+    log.debug({ code: `ALK0131`, context: `matching`, },
+      `final_matching_rows:`, final_matching_rows
+    );
     if ( final_matching_rows.length == 0) {
-      log.debug({
-        code: `ALK0132`,
-        type: `info`,
-        pre: `field:\n${JSON.stringify( field )}`
-      });
+      log.debug({ code: `ALK0132`, context: `matching`, },
+        `0 matching rows. Field:`, field
+      );
     }
 
     return final_matching_rows;
@@ -1582,7 +1628,7 @@ module.exports = {
         catch(err){ elem.style.background = 'Khaki'; }
         return elem.getAttribute('for') || elem.getAttribute('name'); 
       });
-      await scope.page.waitForTimeout( 400 );
+      await time.waitForTimeout( 400 );
     }
 
     // We use the last match. We wrote a warning for the user if there were
@@ -1602,11 +1648,9 @@ module.exports = {
 
   get_handle_from_field: async function ( scope, { field }) {
     /** Get the element's puppeteer handle using the field's selector. */
-    log.debug({
-      code: `ALK0133`,
-      type: `info`,
-      pre: `scope.get_handle_from_field() field.selector: ${JSON.stringify(field.selector)}`
-    });
+    log.debug({ code: `ALK0133`, },
+      `scope.get_handle_from_field() field.selector:`, field.selector
+    );
     let handle = await scope.page.evaluateHandle(( selector ) => {
       let elem = document.querySelector( selector );
       // If the element has a sibling that's a label, we need to
@@ -1805,7 +1849,7 @@ module.exports = {
       });
       if ( type === `radio` || type === `checkbox` ) {
 
-        let [label] = await handle.$x(`following-sibling::label`);
+        let [label] = await handle.$$(`xpath/.//following-sibling::label`);
         
         if ( session_vars.get_debug() ) {
           if ( answer.toLowerCase() === 'false' ) { await label.evaluate( elem => { elem.style.background = 'tomato'; }); }
@@ -2118,7 +2162,9 @@ module.exports = {
     * @param ensure_all_vars_used {bool} [false] = Default false. If true, errors if any
     *     object in var_data is not used during running of this function.
     */
-    log.debug({ type: `plain`, pre: `~~~~~~~~~~~~~~ scope.setFields() ~~~~~~~~~~~~~~` });
+    log.debug({ code: `ALK0221`, before: `~~~~~~~~~~~~~~\n`, },
+      `scope.setFields()`
+    );
 
     // Only record the page id once for each page to which we navigate
     let { id } = await scope.examinePageID( scope, 'none to match' );
@@ -2162,13 +2208,12 @@ module.exports = {
           // Accumulate number of times this row was used. Esp important for `.target_number`
           await scope.increment_row_use( scope, { row: row_used });
 
-          process.stdout.write(`\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
-
+          log.stdout({}, `\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
         }
       }  // ends for every non-submit-button field on the page
     }  // ends while fields are still being set
 
-    if ( session_vars.get_debug() ) { await scope.page.waitForTimeout(2000); }
+    if ( session_vars.get_debug() ) { await time.waitForTimeout(2000); }
 
     // Press a continue button with a story table variable name if it exists
     let did_navigate = false;
@@ -2208,7 +2253,7 @@ module.exports = {
           // }
 
           did_navigate = true;
-          process.stdout.write(`\x1b[36m${ 'v' }\x1b[0m`);  // pressed button successfully
+          log.stdout({}, `\x1b[36m${ 'v' }\x1b[0m`);  // pressed button successfully
           break;
 
         }  // ends if row_used
@@ -2255,7 +2300,7 @@ module.exports = {
       // }
 
       did_navigate = true;
-      process.stdout.write(`\x1b[36m${ '>' }\x1b[0m`);  // continued successfully
+      log.stdout({}, `\x1b[36m${ '>' }\x1b[0m`);  // continued successfully
     }  // ends if !did_navigate && ensure_navigation
 
     if ( did_navigate && scope.check_all_for_a11y ) {
@@ -2516,7 +2561,7 @@ module.exports = {
 
     // Attempt to solve weird race condition issues where page has not properly continued
     while ( curr_url === prev_url && !error.was_found && !timedOut ) {
-      await scope.page.waitForTimeout( 50 );
+      await time.waitForTimeout( 50 );
       curr_url = await scope.page.url();
       error = await scope.checkForError( scope );
     }
@@ -2537,10 +2582,10 @@ module.exports = {
 
     // All results are lists to match `$x`
     let possible_errors = {
-      complex_user_error: await scope.page.$$('.alert-danger'),
+      complex_user_error: await scope.page.$$(`.alert-danger`),
       // The below does not work if there's not a space between ':' and 'none'
-      simple_user_error: await scope.page.$x(`//*[contains(@class, "da-has-error")][not(contains(@style,"display: none"))]`),
-      system_error: await scope.page.$x( '//meta[@content="docassemble: Error"]' ),
+      simple_user_error: await scope.page.$$(`xpath/.//*[contains(@class, "da-has-error")][not(contains(@style,"display: none"))]`),
+      system_error: await scope.page.$$(`xpath/.//meta[@content="docassemble: Error"]` ),
     };
 
     let error_handlers = {};
@@ -2552,7 +2597,7 @@ module.exports = {
         // Also, if you're debugging and you close the window early, the process will still
         // take this long to exit after the tests finish. Not sure how to account for that.
         if ( session_vars.get_debug() ) {
-          await scope.page.waitForTimeout( ( scope.timeout - (1 * 1000)) );
+          await time.waitForTimeout( ( scope.timeout - (1 * 1000)) );
         }
         was_found = true;
         error_handlers[ error_key ] = possible_errors[ error_key ][0];
@@ -2657,7 +2702,7 @@ module.exports = {
     },  // Ends scope.steps.add_json_vars_to_report()
 
     link_works: async ( scope, linkText ) => {
-      let [link] = await scope.page.$x(`//a[contains(text(), "${ linkText }")]`);
+      let [link] = await scope.page.$$(`xpath/.//a[contains(text(), "${ linkText }")]`);
       let prop_obj = await link.getProperty( 'href' );
       let actual_url = await prop_obj.jsonValue();
 
@@ -2715,13 +2760,13 @@ module.exports = {
       /** Tap a link that doesn't navigate. Depends on the language of the text.
        *  TODO: This may be broken at this point.
        * */
-      const [link] = await scope.page.$x(`//a[contains(text(), "${phrase}")]`);
+      const [link] = await scope.page.$$(`xpath/.//a[contains(text(), "${phrase}")]`);
 
       let msg = `The term "${ phrase }" seems to be missing.`;
       if ( !link ) { reports.addToReport(scope, { type: `error`, code: `ALK0151`, value: msg }); }
       expect( link, msg ).to.exist;
       await scope.tapElementAndStayOnPage(scope, { elem: link });
-      await scope.page.waitForTimeout(10000);
+      await time.waitForTimeout(10000);
     },  // Ends scope.steps.tap_term()
 
     sign: async ( scope, name ) => {
@@ -2740,7 +2785,7 @@ module.exports = {
       * TODO: Properly wait for download to complete. See notes in
       * scope.js scope.detectDownloadComplete()
       */
-      let [elem] = await scope.page.$x(`//a[contains(@href, "${ filename }")]`);
+      let [elem] = await scope.page.$$(`xpath/.//a[contains(@href, "${ filename }")]`);
 
       let msg = `"${ filename }" seems to be missing. Cannot find a link to that document.`;
       if ( !elem ) { reports.addToReport(scope, { type: `error`, code: `ALK0152`, value: msg }); }
@@ -2893,7 +2938,9 @@ module.exports = {
       await scope.afterStep(scope, {waitForShowIf: true});
     },  // Ends scope.steps.set_al_address()
 
-    sign_in: async function ( scope, { email_secret_name, password_secret_name }) {
+    sign_in: async function ( scope, {
+      email_secret_name, password_secret_name, api_key_secret_name
+    }) {
       /** Allow the developer to log a user into their server using GitHub
       * secrets to authenticate.
       */
@@ -2946,24 +2993,118 @@ module.exports = {
       if ( password === undefined ) {
         reports.addToReport( scope, { type: `error`, code: `ALK0162`, value: password_msg })
       }
+      // Save API key to clean up interviews later. Nice to have, not critical
+      if ( api_key_secret_name ) {
+        let api_key = process.env[ api_key_secret_name ];
+        let api_key_msg = `The API key in the variable "${ api_key_secret_name }" is missing. Check for a typo in your test, workflow file, GitHub secret, or server config.`
+        if ( api_key === undefined ) {
+          reports.addToReport( scope, { type: `warning`, code: `ALK0199`, value: api_key_msg });
+        } else if ( api_key === `` ) {
+          reports.addToReport( scope, { type: `warning`, code: `ALK0200`,
+            value: `ALKiln found the API key in the variable "${ api_key_secret_name }", but it was empty. It had no text in it. Edit the value of the GitHub secret or server config variable called "${ api_key_secret_name }".` });
+        } else {
+          let access_info = await da_api.get_api_key_access_status({ api_key });
+          if ( !access_info.has_auth ) {
+          reports.addToReport( scope, { type: `warning`, code: `ALK0201`,
+            value: `The server rejected the API key in the variable "${ api_key_secret_name }". Does it exist on this server? Was it deleted somehow? You can always make a new one.` });
+          }
+          // Even if it doesn't have access, give it a shot anyway.
+          // Maybe we got something wrong.
+          scope.scenarios.get( scope.scenario_id ).api_keys.push( api_key );
+        }
+      }
 
       expect( email, email_msg ).to.not.equal( undefined );
       expect( password, password_msg ).to.not.equal( undefined );
 
-      // Try to log in
+      // Try to enter the information
       await scope.page.type( `#email`, email );
       await scope.page.type( `#password`, password );
-      let elem = await scope.page.$( `button[name="submit"]` );
-      await scope.tapElementAndNavigate( scope, { elem });
+      let elem = await scope.page.$( `button[type="submit"]` );
+      await scope.guard_against_missing_tap_element(scope, { elem });
 
-      reports.addToReport( scope, {
-        type: `row info`,
-        code: `ALK0163`,
-        value: `Signed into ${ session_vars.get_da_server_url() }/user/sign-in successfully.`
+      // Submit and see what happens
+      let winner = await scope.steps.race_sign_in_navigation( scope, { elem });
+      // Add the result to the report and possibly throw errors
+      if ( winner[0] === `success` ) {
+        reports.addToReport( scope, {
+          type: `row info`, code: `ALK0163`,
+          value: `Successfully signed into ${ login_url }`
+        });
+        await scope.afterStep(scope, {waitForShowIf: false});
+      } else if ( winner[0] === `failure` ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0209`,
+          value: `Failed to sign into ${ login_url }. Make sure you followed the instructions at https://assemblyline.suffolklitlab.org/docs/alkiln/writing/#sign-in.`
+        });
+        throw new Error( error_msg );
+      } else if ( winner[0] === `error` ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0210`,
+          value: `Error on sign in page at ${ login_url }. Try this by hand and then run the test again.`
+        });
+        throw new Error( error_msg );
+      }
+    },  // Ends scope.steps.sign_in()
+
+    race_sign_in_navigation: async function ( scope, { elem }) {
+      /** Wait for sign in navigation success or failure, or system error. */
+
+      // After everything, clean up incomplete promises
+      const controller = new AbortController;
+
+      // Redirect
+      let redirect_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() === 302;
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0204`, context: `nav`, },
+          `302 sign-in wait catch error:`, catch_info.name, catch_info,
+        );
       });
 
-      await scope.afterStep(scope, {waitForShowIf: false});
-    },  // Ends scope.steps.sign_in()
+      // Invalid credentials, no navigation, no sign in
+      let wrong_sign_in_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() >= 200 && response.status() < 300 && response.url().includes(`/sign-in`);
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0205`, context: `nav`, },
+          `200s sign-in wait catch error:`, catch_info.name, catch_info,
+        );
+      });
+
+      // System error
+      let error_promise = scope.page.waitForResponse(function ( response ) {
+        return response.status() >= 500 && response.status() < 600;
+      }, { signal: controller.signal })
+      .catch(( catch_info ) => {
+        log.debug({ code: `ALK0206`, context: `nav`, },
+          `500s sign-in wait catch error:`, catch_info.name, catch_info,
+        );
+      });
+
+      let click_promise = elem.click();  // MUST complete
+      const winner = await Promise.race([
+        Promise.all([ `success`, click_promise, redirect_promise ]),
+        Promise.all([ `failure`, click_promise, wrong_sign_in_promise ]),
+        Promise.all([ `error`, click_promise, error_promise ]),
+      ]).catch(function ( error ) {
+        let error_msg = reports.addToReport( scope, {
+          type: `error`, code: `ALK0207`,
+          value: `Unknown error waiting for results during sign in at ${ login_url }.`
+        });
+        throw new Error( error );
+      });
+
+      // Clean up unresolved promises
+      controller.abort();
+
+      log.debug({ code: `ALK0208`, context: `nav` },
+        `Sign-in winner:`, winner
+      );
+
+      return winner;
+    },
 
     set_random_page_vars: async ( scope ) => {
       /** Answer inputs randomly. */
@@ -2983,7 +3124,7 @@ module.exports = {
         } else {
           // Try to give a random answer for that element tag
           await scope.set_random_input_for[ field.tag ]( scope, { field: field });
-          process.stdout.write(`\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
+          log.stdout({}, `\x1b[36m${ '*' }\x1b[0m`);  // assumes var was set if no error occurred
         }
 
       }  // End for all page fields
@@ -3019,11 +3160,10 @@ module.exports = {
       }
       if (field == null) {
         // Just skip it? Shouldn't happen but has before. Dig in more
-        log.debug({
-          code: `ALK0164`,
-          type: `info`,
-          pre: `A random button field choice was null. These were the fields to choose from:\n${ JSON.stringify(fields, null, 2) }`,
-        });
+        log.debug({ code: `ALK0164`, context: `random`, },
+          `A random button field choice was null. These were the fields to choose from:`,
+          fields
+        );
         return;
       }
       let handle = await scope.get_handle_from_field( scope, { field: field });