@suffolklitlab/alkiln 5.12.0 → 5.13.0-logs1

package/lib/docassemble/setup.js

@@ -1,11 +1,11 @@
 #!/usr/bin/env node
 
-// TODO: Rename to playground_install?
-
 const child_process = require(`child_process`);
 
-const log = require(`../utils/log`);
+const Log = require(`../utils/log`);
 const session_vars = require(`../utils/session_vars` );
+const files = require(`../utils/files` );
+const time = require(`../utils/time` );
 
 const setup = async () => {
   /** In the docassemble testing account identified by the
@@ -18,9 +18,14 @@ const setup = async () => {
   let project_name = session_vars.get_project_base_name().replace(/[^A-Za-z0-9]/g, '') + `${Date.now()}`;
   session_vars.save_project_name( project_name );
 
-  log.info({ type: `setup`, code: `ALK0046`, pre: `Starting to upload this package to `
+  const starting_msg = `Starting to upload this package to `
     + `a new Project called ${project_name} in the Playground `
-    + `of your server's testing account. It may take a couple of minutes.` });
+    + `of your server's testing account. It may take a couple of minutes.`;
+  log.info({ code: `ALK0046`, context: `setup` },
+    starting_msg
+  );
+
+  // TODO: 1. Start listening to the normal console here (for debug logging)
 
   // dainstall . --apiurl https://site.org --apikey $API_KEY --playground --project=name
   // I think this won't run on windows? Why do I think this? Where on the
@@ -34,29 +39,37 @@ const setup = async () => {
       `--playground`, `--project=${ project_name }`
     ],
     // Prints messages from the process to the console while it's running
+    // result.stderr, result.stdout, etc. will be `null`
     { stdio: 'inherit', }
   );
 
-  // 403 is invalid API key, but I'm not sure how to output
-  // the response to find out the error code
+  // TODO: 2. Stop listening to the normal console here
 
+  // 403 is invalid API key, but I'm not sure how to output
+  // the response to find out the error code. stderr is `null`.
   if ( result.status !== 0 ) {
-    log.error({
-      type: `setup`,
-      code: `ALK0047`,
-      pre: `Status code ${ result.status }. Could not dainstall this package on your server. See above for more details.`
-    });
-    throw(result.stderr);
+    const install_err_msg = `Status code ${ result.status }. Could not `
+      + `dainstall this package on your server. See above for more details.`;
+    log.throw({ code: `ALK0047`, context: `setup`,
+      before: `☝️ ☝️ ☝️  Error data ☝️ ☝️ ☝️\n`,
+      error: `Error while installing project` },
+      install_err_msg
+    );
   }
 
-  log.success({
-    type: `setup`,
-    code: `ALK0048`,
-    pre: `ALKiln created a Project in your Playground named "${ project_name }"!`
-  });
+  log.success({ code: `ALK0048`, context: `setup`, },
+    `ALKiln created a Project in your Playground named "${ project_name }"!`
+  );
 };  // Ends setup();
 
-
-// Before everything, make sure all the required env vars exist
+// 1. session_vars - make sure all the required env vars exist
 session_vars.validateEnvironment();
+
+// 2. Prepare logs
+// Local devs: This will be separate from your test paths
+// unless you pass a `path` argument into the cucumber run command
+const argv = require(`minimist`)(process.argv.slice(2));
+const log = new Log({ path: argv.path, context: `setup` });
+
+// 3. run
 setup();

package/lib/docassemble/takedown.js

@@ -1,26 +1,46 @@
 #!/usr/bin/env node
 
 const da_i = require('./docassemble_api_interface');
-const log = require('../utils/log');
-const session_vars = require('../utils/session_vars' );
+const session_vars = require('../utils/session_vars');
+const Log = require('../utils/log');
 
 const takedown = async () => {
-  /* In the docassemble testing account identified by the
+  /** In the docassemble testing account identified by the
   *   DOCASSEMBLE_DEVELOPER_API_KEY secret, delete the
   *   Project created for this test.
   *   For local development, clean up project name file. */
-  log.info({ type: `takedown`, code: `ALK0177`, pre: `Trying to remove the docassemble Project from the testing account.` });
+  log.info({ code: `ALK0177`, context: `takedown`, },
+    `Trying to remove the docassemble Project from the testing account.`
+  );
   // Explicit try-catch prevents "Unhandled promise rejection error"
   // avoids showing confusing node errors to users that they shouldn't have to fix
   try {
     await da_i.delete_project();
     session_vars.delete_project_name();
-    log.success({ type: `takedown`, code: `ALK0178`, pre: `Test takedown has finished successfully!` });
+    log.info({ code: `ALK0178`, context: `takedown`, },
+      `Test takedown finished successfully!`
+    );
   } catch (error) {
-    log.error({type: `takedown`, code: `ALK0179`, pre: `Could not delete project`, data: JSON.stringify(error, null, 4)})
-    // we don't re-throw the exception, so make sure to exit with 1 to let GitHub Actions know the script failed
+    log.throw({ code: `ALK0179`, context: `takedown`, error: error },
+      `Unable to delete project`,
+    );
+    // we don't re-throw the exception, so make sure to exit
+    // with 1 to let GitHub Actions know the script failed
     process.exitCode = 1;
   }
+
+  // TODO: ? Build the final setup, run, & takedown verbose log
+  // file in here. Add to it in the GitHub action ?
 };
 
+// 1. session_vars - make sure all the required env vars exist
+session_vars.validateEnvironment();
+
+// 2. Prepare logs
+// Local devs: This will be separate from your test artifacts paths
+// unless you pass a `path` argument into the `cucumber` run command
+const argv = require(`minimist`)( process.argv.slice(2) );
+const log = new Log({ path: argv.path, context: `takedown` });
+
+// 3. run
 takedown();

package/lib/run_cucumber.js

@@ -1,13 +1,15 @@
 #!/usr/bin/env node
 
 const fs = require('fs');
+const path = require(`path`);
 const cucumber_api = require('@cucumber/cucumber/api');
 
-const log = require('./utils/log');  // These always log in the console
+const Log = require('./utils/log');
 const session_vars = require('./utils/session_vars');
 
 const SUMMARY_FILENAME = `cucumber-report.txt`;
 
+
 function build_config( command_args ) {
   // Turn all the paths to the sources folders into paths to the feature files
   let sources_paths = session_vars.get_sources_paths();
@@ -52,11 +54,14 @@ function build_config( command_args ) {
 };  // Ends build_config()
 
 
-(async function main() {
+async function main() {
   /** Create the cucumber config, run the tests, create and
   *   manipluate the output. */
+
   const environment = { cwd: process.cwd() };
-  log.info({ type: `run`, code: `ALK0049`, pre: `environment`, data: environment });
+  log.info({ code: `ALK0049`, context: `pre_run environment` },
+    environment
+  );
 
   // We'll use the user info to construct the possible paths to /sources
   let id = session_vars.get_user_id();
@@ -64,8 +69,9 @@ function build_config( command_args ) {
   let project = session_vars.get_user_project_name();
 
   // process.argv is a list of strings of commands and args.
-  // If using `npm run cucumber`, use `--` before `--sources=./foo`
-  let argv = require(`minimist`)( process.argv.slice(2), {
+  // If using `npm run cucumber` (as opposed to the bin commands),
+  // use `--` before `--sources=./foo`
+  const argv = require(`minimist`)( process.argv.slice(2), {
     default: {
       sources: [
         `./docassemble/*/data/sources`,  // In GitHub folder
@@ -84,35 +90,45 @@ function build_config( command_args ) {
   let one_dir_exists = session_vars.set_sources_paths( sources_list );
   if ( !one_dir_exists ) {
     // If we don't throw, it'll be more confusing when no tests run
-    let msg = `ALKiln can't find your "sources" folder(s). See above for details.`;
-    let code = `ALK0050`
-    log.error({ type: `run`, code: code, pre: msg });
-    throw new ReferenceError(`🤕 ${ code } run ERROR: ${ msg }`);
+    log.throw({ code: `ALK0050`, context: `pre_run`,
+      error: new ReferenceError(
+        `ALKiln can't find your "sources" folder(s). See above for details.`
+      ),
+    });
   }
   
   const { runConfiguration } = await cucumber_api.loadConfiguration({
     provided: build_config( argv ),
   }, environment);
-
-  log.info({ type: `run`, code: `ALK0051`, pre: `runConfiguration`, data: runConfiguration });
-
-  var path = require(`path`);
-  var codeDir = path.dirname(require.main.filename);
-  log.info({ type: `run`, code: `ALK0052`, pre: `working directory`, data: codeDir });
+  log.info({ code: `ALK0051`, context: `pre_run config`, },
+    runConfiguration
+  );
+
+  const codeDir = path.dirname(require.main.filename);
+  log.info({ code: `ALK0052`, context: `pre_run directory`, },
+    codeDir, `\n\n`
+  );
   const support = await cucumber_api.loadSupport({ support: {
     requireModules: [ `${ codeDir }/index.js` ],
     requirePaths: [ `${ codeDir }/index.js` ],
     importPaths: [],
   }, sources: {paths: []}}, environment);
 
-  log.info({ type: `run`, code: `ALK0053`, pre: `working directory`, data: codeDir });
-  log.info({ type: `plain`, pre: `\n\n` });
-
+  // ====================
+  // Run
+  // ====================
   const { success } = await cucumber_api.runCucumber({...runConfiguration, support});
+  // ====================
+
   if ( success ) {
-    log.success({ type: `run`, code: `ALK0054`, pre: `Tests succeeded!` });
+    log.success({ code: `ALK0054`, context: `post_run`, },
+      `Tests succeeded!`
+    );
   } else {
-    log.error({ type: `run`, code: `ALK0055`, pre: `The test run ran into something unexpected. Look above for more details.` });
+    // Don't want to throw error here, so don't pass error object
+    log.warn({ code: `ALK0055`, context: `post_run`, },
+      `The tests ran into something unexpected. Look above for more details.`
+    );
   }
   // Custom exit code. May overlap with other systems.
   // Best info I've found via stack overflow: https://tldp.org/LDP/abs/html/exitcodes.html
@@ -122,30 +138,64 @@ function build_config( command_args ) {
   // This is hardcoded information from `provide_config` above.
   // This code isn't used for anything other than detecting and removing color codes.
   let summary_file_name = SUMMARY_FILENAME;
-  fs.readFile(summary_file_name, 'utf8', (err, text) => {
-    if (err) {
-      log.error({ type: `internal run`, code: `ALK0056`, pre: `Failed to read cucumber report`, data: err });
+  fs.readFile(summary_file_name, 'utf8', (read_error, text) => {
+    if ( read_error ) {
+      // Something else will probably show an error that's more relevant
+      log.warn({ code: `ALK0056`, context: `post_run error`, },
+        `Failed to read cucumber report`, read_error
+      );
       return;
     }
 
     // Replace terminal color codes, if present
     // https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797#colors--graphics-mode
     text = text.replace(/\x1b\[[0-9][0-9]?[0-9]?m/g, '');
-
-    // Put it in the correct file in the correct folder
-    let artifacts_path = session_vars.get_artifacts_path_name();
+    // Add to the debug file
     try {
-      fs.appendFileSync( `${ artifacts_path }/${ log.debug_log_file }`, `\n\n${text}`);
+      // fs.appendFileSync( `${ artifacts_path }/${ log.debug_log_file }`, `\n\n${text}`);
+      log.debug({ code: `ALK0216`, context: `post_run`, },
+        `\n\n`, text
+      );
     } catch ( error ) {
-      log.info({ type: `internal run`, code: `ALK0182`, pre: `Something probably went wrong earlier. Look above for more details, but here's more info just in case: ALKiln was unable to write to ${ artifacts_path }/${ log.debug_log_file }.`, data: error });
+      log.warn({ code: `ALK0182`, context: `post_run error`, },
+        `Something probably went wrong earlier. Look above for more details. Problem when writing to ${ log.path }/${ log.debug_log_filename }.`,
+        error
+      );
     }
+
+    // Add to the non-passed test output file
     try {
-      // Add to a unexpected results file when tests themselves fail
+      // Save only non-passing test output to cut out cruft.
+      // cucumber only outputs non-success details anyway.
+      // Our reports only non-passing tests to this file.
       if ( exitCode === 50 ) {
-        fs.appendFileSync( `${ artifacts_path }/${ log.unexpected_filename }`, `\n\n${ text }` );
+        // fs.appendFileSync( `${ log.path }/${ Log.unexpected_filename }`, `\n\n${ text }` );
+        log.unexpected({ text });
       }
-    } catch ( error ) {
-      log.info({ type: `internal run`, code: `ALK0181`, pre: `Something probably went wrong earlier. Look above for more details, but here's more info just in case: ALKiln was unable to write to ${ artifacts_path }/${ log.unexpected_filename }.`, data: error });
+    } catch ( unexpected_file_error ) {
+      console.warn(
+        `🔎 ALK0181 internal WARNING: Something probably went wrong earlier. Problem when writing to ${ log.path }/${ log.unexpected_filename }`,
+        unexpected_file_error
+      );
     }
+
+    return;
   });
-})();
+}
+
+
+// 1. session_vars - make sure all the required env vars exist
+session_vars.validateEnvironment();
+
+// 2. Prepare logs
+// process.argv is a list of strings of commands and args.
+// If using `npm run cucumber` (as opposed to the bin commands),
+// use `--` before `--sources=./foo`
+const argv = require(`minimist`)( process.argv.slice(2) );
+// The artifacts folder might be getting created for the first
+// time right here. The tests themselves should avoid creating
+// their own file.
+const log = new Log({ path: argv.path, context: `run` });
+
+// 3. run
+main();