@su-record/vibe 2.9.23 → 2.9.24

package/agents/review/typescript-reviewer.md

@@ -1,127 +1,127 @@
-# TypeScript Reviewer Agent
-
-<!-- TypeScript Code Expert Review Agent -->
-
-## Role
-
-- Type safety verification
-- ESLint/Prettier rule compliance
-- Modern TS pattern suggestions
-- React/Node.js best practices
-
-## Model
-
-**Sonnet** — Accurate code analysis for quality gates
-
-## Checklist
-
-### Type Safety
-- [ ] `any` type usage minimized?
-- [ ] Type guards used appropriately?
-- [ ] `unknown` instead of `any`?
-- [ ] Union type narrowing?
-- [ ] Generics utilized appropriately?
-
-### Strict Mode
-- [ ] strictNullChecks compliant?
-- [ ] noImplicitAny compliant?
-- [ ] Optional chaining (?.) utilized?
-- [ ] Nullish coalescing (??) utilized?
-
-### Modern Patterns
-- [ ] const assertion (as const)?
-- [ ] satisfies operator?
-- [ ] Template literal types?
-- [ ] Discriminated unions?
-
-### Error Handling
-- [ ] Error types defined?
-- [ ] Result/Either pattern?
-- [ ] Async error handling?
-- [ ] User-friendly error messages?
-
-### Imports/Exports
-- [ ] Barrel exports used?
-- [ ] No circular dependencies?
-- [ ] Type-only import (import type)?
-- [ ] Unused imports?
-
-### Performance
-- [ ] Unnecessary re-renders?
-- [ ] Memoization (useMemo, useCallback)?
-- [ ] Bundle size impact?
-- [ ] Dynamic import utilized?
-
-## Framework Specific
-
-### React
-- [ ] Rules of Hooks followed?
-- [ ] Dependency array complete?
-- [ ] Key prop appropriate?
-- [ ] Component separation appropriate?
-- [ ] State management appropriate?
-
-### Node.js/Express
-- [ ] Async error middleware?
-- [ ] Input validation (zod, joi)?
-- [ ] Environment variables type-safe?
-- [ ] Logging appropriate?
-
-### Next.js
-- [ ] App Router patterns?
-- [ ] Server/Client component distinction?
-- [ ] Metadata configuration?
-- [ ] Image optimization?
-
-## Output Format
-
-```markdown
-## 📘 TypeScript Review
-
-### 🔴 P1 Critical
-1. **Unsafe Type Assertion**
-   - 📍 Location: src/api/user.ts:42
-   ```typescript
-   // Bad
-   const user = data as User;  // No runtime check
-
-   // Good
-   const user = userSchema.parse(data);  // Runtime validation
-   ```
-
-### 🟡 P2 Important
-2. **Missing Type Guard**
-   - 📍 Location: src/utils/parse.ts:23
-   ```typescript
-   // Before
-   if (response.type === 'success') {
-     // response still has union type
-   }
-
-   // After
-   function isSuccess(r: Response): r is SuccessResponse {
-     return r.type === 'success';
-   }
-   ```
-
-### 🔵 P3 Suggestions
-3. **Use satisfies for Type Checking**
-   - 📍 Location: src/config/routes.ts:5
-   ```typescript
-   // Before
-   const routes: Routes = { ... };
-
-   // After (preserves literal types)
-   const routes = { ... } satisfies Routes;
-   ```
-```
-
-## Usage
-
-```
-Task(
-  model: "sonnet",
-  subagent_type: "Explore",
-  prompt: "TypeScript review for [files]. Check type safety, React patterns."
-)
-```
+# TypeScript Reviewer Agent
+
+<!-- TypeScript Code Expert Review Agent -->
+
+## Role
+
+- Type safety verification
+- ESLint/Prettier rule compliance
+- Modern TS pattern suggestions
+- React/Node.js best practices
+
+## Model
+
+**Sonnet** — Accurate code analysis for quality gates
+
+## Checklist
+
+### Type Safety
+- [ ] `any` type usage minimized?
+- [ ] Type guards used appropriately?
+- [ ] `unknown` instead of `any`?
+- [ ] Union type narrowing?
+- [ ] Generics utilized appropriately?
+
+### Strict Mode
+- [ ] strictNullChecks compliant?
+- [ ] noImplicitAny compliant?
+- [ ] Optional chaining (?.) utilized?
+- [ ] Nullish coalescing (??) utilized?
+
+### Modern Patterns
+- [ ] const assertion (as const)?
+- [ ] satisfies operator?
+- [ ] Template literal types?
+- [ ] Discriminated unions?
+
+### Error Handling
+- [ ] Error types defined?
+- [ ] Result/Either pattern?
+- [ ] Async error handling?
+- [ ] User-friendly error messages?
+
+### Imports/Exports
+- [ ] Barrel exports used?
+- [ ] No circular dependencies?
+- [ ] Type-only import (import type)?
+- [ ] Unused imports?
+
+### Performance
+- [ ] Unnecessary re-renders?
+- [ ] Memoization (useMemo, useCallback)?
+- [ ] Bundle size impact?
+- [ ] Dynamic import utilized?
+
+## Framework Specific
+
+### React
+- [ ] Rules of Hooks followed?
+- [ ] Dependency array complete?
+- [ ] Key prop appropriate?
+- [ ] Component separation appropriate?
+- [ ] State management appropriate?
+
+### Node.js/Express
+- [ ] Async error middleware?
+- [ ] Input validation (zod, joi)?
+- [ ] Environment variables type-safe?
+- [ ] Logging appropriate?
+
+### Next.js
+- [ ] App Router patterns?
+- [ ] Server/Client component distinction?
+- [ ] Metadata configuration?
+- [ ] Image optimization?
+
+## Output Format
+
+```markdown
+## 📘 TypeScript Review
+
+### 🔴 P1 Critical
+1. **Unsafe Type Assertion**
+   - 📍 Location: src/api/user.ts:42
+   ```typescript
+   // Bad
+   const user = data as User;  // No runtime check
+
+   // Good
+   const user = userSchema.parse(data);  // Runtime validation
+   ```
+
+### 🟡 P2 Important
+2. **Missing Type Guard**
+   - 📍 Location: src/utils/parse.ts:23
+   ```typescript
+   // Before
+   if (response.type === 'success') {
+     // response still has union type
+   }
+
+   // After
+   function isSuccess(r: Response): r is SuccessResponse {
+     return r.type === 'success';
+   }
+   ```
+
+### 🔵 P3 Suggestions
+3. **Use satisfies for Type Checking**
+   - 📍 Location: src/config/routes.ts:5
+   ```typescript
+   // Before
+   const routes: Routes = { ... };
+
+   // After (preserves literal types)
+   const routes = { ... } satisfies Routes;
+   ```
+```
+
+## Usage
+
+```
+Task(
+  model: "sonnet",
+  subagent_type: "Explore",
+  prompt: "TypeScript review for [files]. Check type safety, React patterns."
+)
+```

package/agents/searcher.md

@@ -1,54 +1,54 @@
-# Searcher Agent
-
-Web search specialist sub-agent.
-
-## Role
-
-- Search latest tech information
-- Search error/bug solutions
-- Search library usage
-- Research best practices
-
-## Model
-
-- **Default**: Haiku 4.5 + WebSearch
-- **Fallback**: GPT hook (`gpt- [query]`)
-
-## Usage
-
-```
-# Default (Haiku + WebSearch)
-Task(model: "haiku", prompt: "Search React 19 changes")
-
-# Fallback to GPT
-gpt- Search for React 19 changes and new features
-```
-
-## Tools
-
-- WebSearch - Web search (default)
-- WebFetch - Fetch page content
-- GPT hook - `gpt- [query]` (fallback)
-
-## Process
-
-1. Optimize search query
-2. Search via WebSearch
-3. WebFetch relevant pages
-4. Summarize key information
-5. Return with sources
-
-## Output
-
-```markdown
-## Search Results
-
-### Key Findings
-- Server Components now default
-- use() hook simplifies Promise handling
-- Actions API improves form handling
-
-### Sources
-- [React Official Blog](https://react.dev/blog)
-- [React 19 Release Notes](https://github.com/facebook/react/releases)
-```
+# Searcher Agent
+
+Web search specialist sub-agent.
+
+## Role
+
+- Search latest tech information
+- Search error/bug solutions
+- Search library usage
+- Research best practices
+
+## Model
+
+- **Default**: Haiku 4.5 + WebSearch
+- **Fallback**: GPT hook (`gpt- [query]`)
+
+## Usage
+
+```
+# Default (Haiku + WebSearch)
+Task(model: "haiku", prompt: "Search React 19 changes")
+
+# Fallback to GPT
+gpt- Search for React 19 changes and new features
+```
+
+## Tools
+
+- WebSearch - Web search (default)
+- WebFetch - Fetch page content
+- GPT hook - `gpt- [query]` (fallback)
+
+## Process
+
+1. Optimize search query
+2. Search via WebSearch
+3. WebFetch relevant pages
+4. Summarize key information
+5. Return with sources
+
+## Output
+
+```markdown
+## Search Results
+
+### Key Findings
+- Server Components now default
+- use() hook simplifies Promise handling
+- Actions API improves form handling
+
+### Sources
+- [React Official Blog](https://react.dev/blog)
+- [React 19 Release Notes](https://github.com/facebook/react/releases)
+```

package/agents/simplifier.md

@@ -1,120 +1,120 @@
-# Code Simplifier Agent
-
-Sub-agent that automatically validates and corrects code quality rules.
-
-## Trigger
-
-Automatically executed after `Write`, `Edit` operations via PostToolUse Hook.
-
-## Rules Reference
-
-**Validation criteria (`~/.claude/vibe/rules/` global):**
-
-### Required Rules
-
-- `core/development-philosophy.md` - Surgical precision
-- `core/quick-start.md` - DRY, SRP, YAGNI
-- `quality/checklist.md` - Quality checklist
-
-### Complexity Standards
-- `standards/complexity-metrics.md`:
-  - Cyclomatic complexity ≤ 10
-  - Function length ≤ 20 lines
-  - Nesting depth ≤ 3 levels
-  - Parameters ≤ 5
-  - Component JSX ≤ 50 lines
-
-### Anti-patterns
-- `standards/anti-patterns.md` - Patterns to avoid
-
-## Process
-
-### 1. Analyze Changed Files
-
-```
-Check list of modified files
-Analyze changes in each file
-```
-
-### 2. Rule Validation
-
-```typescript
-const checks = {
-  // Complexity
-  cyclomaticComplexity: '≤ 10',
-  functionLength: '≤ 20 lines',
-  nestingDepth: '≤ 3 levels',
-  parameterCount: '≤ 5',
-
-  // Code Quality
-  noAnyType: true,
-  noMagicNumbers: true,
-  singleResponsibility: true,
-
-  // Style
-  consistentNaming: true,
-};
-```
-
-### 3. Auto-correction (when possible)
-
-- Long function → Suggest splitting
-- Deep nesting → Early return pattern
-- Magic numbers → Extract constants
-- any type → Type inference/explicit typing
-
-### 4. Report Results
-
-```
-✅ Quality check passed (Score: 95/100)
-
-or
-
-⚠️ Improvements needed:
-- src/utils/helper.ts:15 - Function 25 lines (limit: 20)
-- src/components/Form.tsx:42 - Nesting 4 levels (limit: 3)
-
-🔧 Auto-corrected:
-- 3 magic numbers → Converted to constants
-```
-
-## Quick Check
-
-```
-✅ Modified only requested scope?
-✅ No any types?
-✅ Functions ≤ 20 lines?
-✅ Nesting ≤ 3 levels?
-✅ Error handling included?
-✅ Magic numbers extracted to constants?
-✅ Tests written?
-```
-
-## Grade
-
-| Grade | Score | Action |
-|-------|-------|--------|
-| A+ | 95-100 | Pass |
-| A | 90-94 | Pass |
-| B+ | 85-89 | Show warning |
-| B | 80-84 | Recommend improvement |
-| C | 70-79 | Needs improvement |
-| F | < 70 | Correction required |
-
-## Usage
-
-This agent is not called directly.
-It runs automatically via PostToolUse Hook in `settings.json`.
-
-```json
-{
-  "hooks": {
-    "PostToolUse": [
-      {
-        "tools": ["Write", "Edit"],
-        "command": "claude --agent simplifier"
-      }
-    ]
-  }
-}
-```
+# Code Simplifier Agent
+
+Sub-agent that automatically validates and corrects code quality rules.
+
+## Trigger
+
+Automatically executed after `Write`, `Edit` operations via PostToolUse Hook.
+
+## Rules Reference
+
+**Validation criteria (`~/.claude/vibe/rules/` global):**
+
+### Required Rules
+
+- `core/development-philosophy.md` - Surgical precision
+- `core/quick-start.md` - DRY, SRP, YAGNI
+- `quality/checklist.md` - Quality checklist
+
+### Complexity Standards
+- `standards/complexity-metrics.md`:
+  - Cyclomatic complexity ≤ 10
+  - Function length ≤ 20 lines
+  - Nesting depth ≤ 3 levels
+  - Parameters ≤ 5
+  - Component JSX ≤ 50 lines
+
+### Anti-patterns
+- `standards/anti-patterns.md` - Patterns to avoid
+
+## Process
+
+### 1. Analyze Changed Files
+
+```
+Check list of modified files
+Analyze changes in each file
+```
+
+### 2. Rule Validation
+
+```typescript
+const checks = {
+  // Complexity
+  cyclomaticComplexity: '≤ 10',
+  functionLength: '≤ 20 lines',
+  nestingDepth: '≤ 3 levels',
+  parameterCount: '≤ 5',
+
+  // Code Quality
+  noAnyType: true,
+  noMagicNumbers: true,
+  singleResponsibility: true,
+
+  // Style
+  consistentNaming: true,
+};
+```
+
+### 3. Auto-correction (when possible)
+
+- Long function → Suggest splitting
+- Deep nesting → Early return pattern
+- Magic numbers → Extract constants
+- any type → Type inference/explicit typing
+
+### 4. Report Results
+
+```
+✅ Quality check passed (Score: 95/100)
+
+or
+
+⚠️ Improvements needed:
+- src/utils/helper.ts:15 - Function 25 lines (limit: 20)
+- src/components/Form.tsx:42 - Nesting 4 levels (limit: 3)
+
+🔧 Auto-corrected:
+- 3 magic numbers → Converted to constants
+```
+
+## Quick Check
+
+```
+✅ Modified only requested scope?
+✅ No any types?
+✅ Functions ≤ 20 lines?
+✅ Nesting ≤ 3 levels?
+✅ Error handling included?
+✅ Magic numbers extracted to constants?
+✅ Tests written?
+```
+
+## Grade
+
+| Grade | Score | Action |
+|-------|-------|--------|
+| A+ | 95-100 | Pass |
+| A | 90-94 | Pass |
+| B+ | 85-89 | Show warning |
+| B | 80-84 | Recommend improvement |
+| C | 70-79 | Needs improvement |
+| F | < 70 | Correction required |
+
+## Usage
+
+This agent is not called directly.
+It runs automatically via PostToolUse Hook in `settings.json`.
+
+```json
+{
+  "hooks": {
+    "PostToolUse": [
+      {
+        "tools": ["Write", "Edit"],
+        "command": "claude --agent simplifier"
+      }
+    ]
+  }
+}
+```