@su-record/vibe 2.8.52 → 2.8.53

package/skills/priority-todos/rubrics/prioritization.md

@@ -1,70 +1,70 @@
-# TODO Prioritization Rubric
-
-Use these criteria to assign P1, P2, or P3 to any TODO item.
-
-## P1 — Blocks Merge
-
-Assign P1 when ANY of the following is true:
-
-| Criterion | Example |
-|-----------|---------|
-| Security vulnerability | SQL injection, XSS, unprotected endpoint, leaked secret |
-| Data loss or corruption risk | Missing transaction, overwrite without backup |
-| Type safety bypass | `: any`, `as any`, `@ts-ignore` hiding a real error |
-| Production breakage | Throws uncaught exception on valid input |
-| Broken CI/test | Failing test committed (not pre-existing) |
-| Missing auth/authz check | Unauthenticated access to protected resource |
-| Regulatory non-compliance | GDPR PII without consent, HIPAA violation |
-
-**Decision rule**: Would this cause an incident if it shipped? → P1
-
----
-
-## P2 — Fix Before PR
-
-Assign P2 when ANY of the following is true AND it is not P1:
-
-| Criterion | Example |
-|-----------|---------|
-| Performance regression | O(n²) loop, N+1 query, synchronous blocking call |
-| Missing test coverage | New feature with no tests |
-| Architecture violation | Layer boundary crossed (service imports UI) |
-| `console.log` in committed code | Debug output in production path |
-| Function > 50 lines | Complexity limit exceeded |
-| Nesting depth > 4 | Readability and test difficulty |
-| Duplicate logic across 2+ files | Maintenance hazard; divergence risk |
-| TODO/FIXME without tracking ticket | Ambiguous ownership |
-
-**Decision rule**: Would a reviewer request changes on this in a PR review? → P2
-
----
-
-## P3 — Backlog
-
-Assign P3 when the issue is real but has no immediate consequence:
-
-| Criterion | Example |
-|-----------|---------|
-| Style inconsistency | Different quote styles, inconsistent naming |
-| Magic numbers with low risk | Timeout values, display constants |
-| Commented-out code | Dead code left behind |
-| Missing JSDoc on internal helpers | Not public API |
-| File nearing complexity limit | 150–200 lines, not there yet |
-| Refactoring opportunity | Could be cleaner but works correctly |
-
-**Decision rule**: Could this be deferred a week without risk? → P3
-
----
-
-## Upgrade / Downgrade Rules
-
-| Situation | Action |
-|-----------|--------|
-| P3 item appears in 3+ files | Upgrade to P2 (systemic issue) |
-| P2 item has no fix path identified | Keep P2, add a note |
-| P1 item is in dead code (never executed) | Downgrade to P2 with justification |
-| P2 item found in P1 audit | Upgrade to P1 if it compounds the P1 issue |
-
-## When Uncertain
-
-Default to the higher priority. It is cheaper to over-prioritize than to ship a P1 labeled as P3.
+# TODO Prioritization Rubric
+
+Use these criteria to assign P1, P2, or P3 to any TODO item.
+
+## P1 — Blocks Merge
+
+Assign P1 when ANY of the following is true:
+
+| Criterion | Example |
+|-----------|---------|
+| Security vulnerability | SQL injection, XSS, unprotected endpoint, leaked secret |
+| Data loss or corruption risk | Missing transaction, overwrite without backup |
+| Type safety bypass | `: any`, `as any`, `@ts-ignore` hiding a real error |
+| Production breakage | Throws uncaught exception on valid input |
+| Broken CI/test | Failing test committed (not pre-existing) |
+| Missing auth/authz check | Unauthenticated access to protected resource |
+| Regulatory non-compliance | GDPR PII without consent, HIPAA violation |
+
+**Decision rule**: Would this cause an incident if it shipped? → P1
+
+---
+
+## P2 — Fix Before PR
+
+Assign P2 when ANY of the following is true AND it is not P1:
+
+| Criterion | Example |
+|-----------|---------|
+| Performance regression | O(n²) loop, N+1 query, synchronous blocking call |
+| Missing test coverage | New feature with no tests |
+| Architecture violation | Layer boundary crossed (service imports UI) |
+| `console.log` in committed code | Debug output in production path |
+| Function > 50 lines | Complexity limit exceeded |
+| Nesting depth > 4 | Readability and test difficulty |
+| Duplicate logic across 2+ files | Maintenance hazard; divergence risk |
+| TODO/FIXME without tracking ticket | Ambiguous ownership |
+
+**Decision rule**: Would a reviewer request changes on this in a PR review? → P2
+
+---
+
+## P3 — Backlog
+
+Assign P3 when the issue is real but has no immediate consequence:
+
+| Criterion | Example |
+|-----------|---------|
+| Style inconsistency | Different quote styles, inconsistent naming |
+| Magic numbers with low risk | Timeout values, display constants |
+| Commented-out code | Dead code left behind |
+| Missing JSDoc on internal helpers | Not public API |
+| File nearing complexity limit | 150–200 lines, not there yet |
+| Refactoring opportunity | Could be cleaner but works correctly |
+
+**Decision rule**: Could this be deferred a week without risk? → P3
+
+---
+
+## Upgrade / Downgrade Rules
+
+| Situation | Action |
+|-----------|--------|
+| P3 item appears in 3+ files | Upgrade to P2 (systemic issue) |
+| P2 item has no fix path identified | Keep P2, add a note |
+| P1 item is in dead code (never executed) | Downgrade to P2 with justification |
+| P2 item found in P1 audit | Upgrade to P1 if it compounds the P1 issue |
+
+## When Uncertain
+
+Default to the higher priority. It is cheaper to over-prioritize than to ship a P1 labeled as P3.

package/skills/priority-todos/templates/todo-board.md

@@ -1,59 +1,59 @@
-# TODO Board: {{PROJECT_OR_FEATURE_NAME}}
-
-**Updated**: {{DATE}}
-**Branch**: {{GIT_BRANCH}}
-**Total open**: {{TOTAL_OPEN}} | P1: {{P1_COUNT}} | P2: {{P2_COUNT}} | P3: {{P3_COUNT}}
-
----
-
-## P1 — Blocks Merge ({{P1_COUNT}} open)
-
-> All P1 items must be resolved before this branch can be merged.
-
-| ID | Title | File:Line | Assigned | Status |
-|----|-------|-----------|----------|--------|
-| P1-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{ASSIGNEE_1}} | {{STATUS_1}} |
-| P1-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{ASSIGNEE_2}} | {{STATUS_2}} |
-
-{{#if P1_EMPTY}}
-_No P1 items. Merge is unblocked._
-{{/if}}
-
----
-
-## P2 — Fix Before PR ({{P2_COUNT}} open)
-
-> P2 items should be resolved before PR review. Warning only — does not block merge.
-
-| ID | Title | File:Line | Assigned | Status |
-|----|-------|-----------|----------|--------|
-| P2-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{ASSIGNEE_1}} | {{STATUS_1}} |
-| P2-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{ASSIGNEE_2}} | {{STATUS_2}} |
-
----
-
-## P3 — Backlog ({{P3_COUNT}} open)
-
-> P3 items do not block merge. Address during scheduled cleanup sessions.
-
-| ID | Title | File:Line | Notes |
-|----|-------|-----------|-------|
-| P3-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{NOTES_1}} |
-| P3-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{NOTES_2}} |
-
----
-
-## Completed (archived)
-
-| ID | Title | Resolved | PR/Commit |
-|----|-------|----------|-----------|
-| {{DONE_ID_1}} | {{DONE_TITLE_1}} | {{DONE_DATE_1}} | {{DONE_REF_1}} |
-
----
-
-## Merge Checklist
-
-- [ ] P1 count = 0
-- [ ] P2 items reviewed (resolved or documented)
-- [ ] index.md reflects current state
-- [ ] Completed items archived to `done/`
+# TODO Board: {{PROJECT_OR_FEATURE_NAME}}
+
+**Updated**: {{DATE}}
+**Branch**: {{GIT_BRANCH}}
+**Total open**: {{TOTAL_OPEN}} | P1: {{P1_COUNT}} | P2: {{P2_COUNT}} | P3: {{P3_COUNT}}
+
+---
+
+## P1 — Blocks Merge ({{P1_COUNT}} open)
+
+> All P1 items must be resolved before this branch can be merged.
+
+| ID | Title | File:Line | Assigned | Status |
+|----|-------|-----------|----------|--------|
+| P1-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{ASSIGNEE_1}} | {{STATUS_1}} |
+| P1-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{ASSIGNEE_2}} | {{STATUS_2}} |
+
+{{#if P1_EMPTY}}
+_No P1 items. Merge is unblocked._
+{{/if}}
+
+---
+
+## P2 — Fix Before PR ({{P2_COUNT}} open)
+
+> P2 items should be resolved before PR review. Warning only — does not block merge.
+
+| ID | Title | File:Line | Assigned | Status |
+|----|-------|-----------|----------|--------|
+| P2-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{ASSIGNEE_1}} | {{STATUS_1}} |
+| P2-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{ASSIGNEE_2}} | {{STATUS_2}} |
+
+---
+
+## P3 — Backlog ({{P3_COUNT}} open)
+
+> P3 items do not block merge. Address during scheduled cleanup sessions.
+
+| ID | Title | File:Line | Notes |
+|----|-------|-----------|-------|
+| P3-{{ID_1}} | {{TITLE_1}} | `{{FILE_1}}:{{LINE_1}}` | {{NOTES_1}} |
+| P3-{{ID_2}} | {{TITLE_2}} | `{{FILE_2}}:{{LINE_2}}` | {{NOTES_2}} |
+
+---
+
+## Completed (archived)
+
+| ID | Title | Resolved | PR/Commit |
+|----|-------|----------|-----------|
+| {{DONE_ID_1}} | {{DONE_TITLE_1}} | {{DONE_DATE_1}} | {{DONE_REF_1}} |
+
+---
+
+## Merge Checklist
+
+- [ ] P1 count = 0
+- [ ] P2 items reviewed (resolved or documented)
+- [ ] index.md reflects current state
+- [ ] Completed items archived to `done/`

package/skills/seo-checklist/SKILL.md

@@ -1,58 +1,58 @@
----
-name: seo-checklist
-tier: core
-description: "SEO gotchas for web development — easy-to-miss items that hurt search ranking. Covers meta tags, Open Graph, structured data (JSON-LD), sitemap, robots.txt, canonical URLs, and Naver/Google-specific requirements. Use when building or reviewing any public-facing web page, landing page, or marketing site. Must use this skill when user mentions SEO, search ranking, meta tags, or when deploying a web app that needs to be discoverable."
-triggers: [seo, search, meta, sitemap, schema, structured data, og, opengraph, google, naver]
-priority: 65
----
-
-# SEO Checklist
-
-## Pre-check (K1)
-
-> Is this a public-facing web page that needs search visibility? Internal tools, admin panels, and authenticated-only pages don't need SEO optimization.
-
-## Easy-to-Miss Gotchas
-
-### Meta & Social
-
-| Gotcha | Why It Hurts | Fix |
-|--------|-------------|-----|
-| Missing `<link rel="canonical">` | Duplicate content penalty from URL variants | Set canonical on every page, including paginated |
-| OG image wrong size | Cropped/pixelated on social share | Must be exactly **1200x630px** |
-| Same title/description on all pages | Google treats as duplicate content | Unique title (50-60 chars) + description (150-160 chars) per page |
-| Missing `og:type` | Defaults to "website" for articles | Set `article` for posts, `product` for products |
-
-### Technical
-
-| Gotcha | Why It Hurts | Fix |
-|--------|-------------|-----|
-| `robots.txt` blocks important pages | Pages not indexed | `Allow: /` for public, only block `/api/`, `/admin/` |
-| No sitemap or stale sitemap | Crawler misses new pages | Auto-generate, include `<lastmod>` with real dates |
-| `noindex` left in production | Entire site invisible | Verify `<meta name="robots">` in production build |
-| Images without `width`/`height` | CLS layout shift penalty | Always set dimensions + `loading="lazy"` for below-fold |
-
-### Core Web Vitals
-
-| Metric | Target | Common Miss |
-|--------|--------|-------------|
-| LCP | ≤2.5s | Hero image not preloaded — add `<link rel="preload">` |
-| INP | ≤200ms | Heavy JS on interaction — defer non-critical scripts |
-| CLS | ≤0.1 | Dynamic content without reserved space — set `min-height` |
-
-### Structured Data
-
-| Gotcha | Fix |
-|--------|-----|
-| JSON-LD not validated | Test with Google Rich Results Test before deploy |
-| Wrong `@type` | `Product` for products, `Article` for posts, `FAQPage` for FAQs |
-| Missing `BreadcrumbList` | Add breadcrumb schema for all non-root pages |
-
-## Done Criteria (K4)
-
-- [ ] Every page has unique title, description, canonical URL
-- [ ] OG images are 1200x630px on all shareable pages
-- [ ] `robots.txt` and `sitemap.xml` present and correct
-- [ ] Structured data validates in Rich Results Test
-- [ ] Core Web Vitals green (LCP ≤2.5s, INP ≤200ms, CLS ≤0.1)
-- [ ] No `noindex` tags in production
+---
+name: seo-checklist
+tier: core
+description: "SEO gotchas for web development — easy-to-miss items that hurt search ranking. Covers meta tags, Open Graph, structured data (JSON-LD), sitemap, robots.txt, canonical URLs, and Naver/Google-specific requirements. Use when building or reviewing any public-facing web page, landing page, or marketing site. Must use this skill when user mentions SEO, search ranking, meta tags, or when deploying a web app that needs to be discoverable."
+triggers: [seo, search, meta, sitemap, schema, structured data, og, opengraph, google, naver]
+priority: 65
+---
+
+# SEO Checklist
+
+## Pre-check (K1)
+
+> Is this a public-facing web page that needs search visibility? Internal tools, admin panels, and authenticated-only pages don't need SEO optimization.
+
+## Easy-to-Miss Gotchas
+
+### Meta & Social
+
+| Gotcha | Why It Hurts | Fix |
+|--------|-------------|-----|
+| Missing `<link rel="canonical">` | Duplicate content penalty from URL variants | Set canonical on every page, including paginated |
+| OG image wrong size | Cropped/pixelated on social share | Must be exactly **1200x630px** |
+| Same title/description on all pages | Google treats as duplicate content | Unique title (50-60 chars) + description (150-160 chars) per page |
+| Missing `og:type` | Defaults to "website" for articles | Set `article` for posts, `product` for products |
+
+### Technical
+
+| Gotcha | Why It Hurts | Fix |
+|--------|-------------|-----|
+| `robots.txt` blocks important pages | Pages not indexed | `Allow: /` for public, only block `/api/`, `/admin/` |
+| No sitemap or stale sitemap | Crawler misses new pages | Auto-generate, include `<lastmod>` with real dates |
+| `noindex` left in production | Entire site invisible | Verify `<meta name="robots">` in production build |
+| Images without `width`/`height` | CLS layout shift penalty | Always set dimensions + `loading="lazy"` for below-fold |
+
+### Core Web Vitals
+
+| Metric | Target | Common Miss |
+|--------|--------|-------------|
+| LCP | ≤2.5s | Hero image not preloaded — add `<link rel="preload">` |
+| INP | ≤200ms | Heavy JS on interaction — defer non-critical scripts |
+| CLS | ≤0.1 | Dynamic content without reserved space — set `min-height` |
+
+### Structured Data
+
+| Gotcha | Fix |
+|--------|-----|
+| JSON-LD not validated | Test with Google Rich Results Test before deploy |
+| Wrong `@type` | `Product` for products, `Article` for posts, `FAQPage` for FAQs |
+| Missing `BreadcrumbList` | Add breadcrumb schema for all non-root pages |
+
+## Done Criteria (K4)
+
+- [ ] Every page has unique title, description, canonical URL
+- [ ] OG images are 1200x630px on all shareable pages
+- [ ] `robots.txt` and `sitemap.xml` present and correct
+- [ ] Structured data validates in Rich Results Test
+- [ ] Core Web Vitals green (LCP ≤2.5s, INP ≤200ms, CLS ≤0.1)
+- [ ] No `noindex` tags in production