@su-record/vibe 2.16.4 → 3.1.0

package/skills/vibe.review/SKILL.md

@@ -222,78 +222,76 @@ Read CLAUDE.md         -> Explicit tech stack declaration
 5. If no SPEC files exist → Skip (reviews work without SPEC too)
 ```
 
-### Phase 2: Parallel Agent Review (STACK-AWARE) via Orchestrator
+### Phase 2: Parallel Agent Review (STACK-AWARE)
 
-**Execution via Orchestrator (12+ agents in parallel):**
-```bash
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(o => o.review(['FILE_PATHS'], ['DETECTED_STACKS']).then(r => console.log(r.content[0].text)))"
-```
+**Spawn the reviewers as concurrent native subagents in ONE message** — one `code-reviewer` instance per focus plus `security-reviewer`, each scoped to the changed files:
 
-**Example:**
-```bash
-# Review changed files with TypeScript + React stack
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(o => o.review(['src/api/users.ts', 'src/components/Login.tsx'], ['TypeScript', 'React']).then(r => console.log(r.content[0].text)))"
 ```
+Task (code-reviewer): "Review [FILES] — focus: correctness"      (concurrent)
+Task (code-reviewer): "Review [FILES] — focus: data-integrity"   (concurrent)
+Task (code-reviewer): "Review [FILES] — focus: performance"      (concurrent)
+Task (code-reviewer): "Review [FILES] — focus: architecture"     (concurrent)
+Task (security-reviewer): "Review [FILES] for vulnerabilities"   (concurrent)
+```
+
+Stack-specific focus (`idioms`) is added when the diff touches that stack's files. Collect all results, then dedupe/merge findings before Phase 3.
 
-**Core Reviewers (Always Run):**
-| Agent | Focus |
+**Core Reviewers (Always Run — parallel `code-reviewer` instances, one per focus, plus `security-reviewer`):**
+| Agent (focus) | Focus |
 |-------|-------|
 | security-reviewer | OWASP Top 10, vulnerabilities |
-| data-integrity-reviewer | Data validation, constraints |
-| performance-reviewer | N+1 queries, memory leaks |
-| architecture-reviewer | Layer violations, cycles |
-| complexity-reviewer | Cyclomatic complexity, length |
-| simplicity-reviewer | Over-abstraction, dead code |
-| git-history-reviewer | Churn files, risk patterns |
-| test-coverage-reviewer | Missing tests, edge cases |
-
-**Stack-Specific Reviewers (Conditional):**
-| Agent | Condition |
+| code-reviewer (focus: correctness) | Logic errors, edge cases |
+| code-reviewer (focus: data-integrity) | Data validation, constraints |
+| code-reviewer (focus: performance) | N+1 queries, memory leaks |
+| code-reviewer (focus: architecture) | Layer violations, cycles |
+| code-reviewer (focus: complexity) | Cyclomatic complexity, length, over-abstraction, dead code |
+| code-reviewer (focus: git-history) | Churn files, risk patterns |
+| code-reviewer (focus: test-coverage) | Missing tests, edge cases |
+
+**Stack-Specific Review (Conditional — one extra `code-reviewer` instance):**
+| Agent (focus) | Condition |
 |-------|-----------|
-| python-reviewer | .py files in diff |
-| typescript-reviewer | .ts/.tsx files OR tsconfig |
-| rails-reviewer | Gemfile has rails |
-| react-reviewer | package.json has react |
+| code-reviewer (focus: idioms) | Language/framework files in diff (.py / .ts / .tsx / Gemfile rails / package.json react) — prompt states the detected stack |
 
 ### Phase 2.5: UI/UX Review Agents (Auto-triggered)
 
 > **활성화 조건**: 변경된 파일 중 UI 파일 존재 (`.tsx`, `.jsx`, `.vue`, `.svelte`, `.html`, `.css`, `.scss`)
 > **비활성화**: `.vibe/config.json`에 `"uiUxAnalysis": false` 설정
 
-**기존 12+ 리뷰 에이전트와 병렬 실행:**
+**기존 Phase 2 리뷰 에이전트와 병렬 실행 — `design-reviewer` 인스턴스 3개 (관점별):**
 
-| Agent | Role | Output |
+| Agent (관점) | Role | Output |
 |-------|------|--------|
-| ⑥ ux-compliance-reviewer | UX 가이드라인 준수 검증 | P1/P2/P3 findings |
-| ⑦ ui-a11y-auditor | WCAG 2.1 AA 접근성 감사 | P1/P2/P3 findings |
-| ⑧ ui-antipattern-detector | UI 안티패턴 + 디자인 시스템 일관성 | P1/P2/P3 findings |
+| ⑥ design-reviewer (UX 준수) | UX 가이드라인 준수 검증 | P1/P2/P3 findings |
+| ⑦ design-reviewer (접근성) | WCAG 2.1 AA 접근성 감사 | P1/P2/P3 findings |
+| ⑧ design-reviewer (안티패턴) | UI 안티패턴 + 디자인 시스템 일관성 | P1/P2/P3 findings |
 
 **실행 방법 — 기존 Phase 2 에이전트와 병렬 실행:**
 
 ```text
 # ⑥ UX 준수 검증 (Haiku)
-Task(subagent_type="ux-compliance-reviewer",
+Task(subagent_type="design-reviewer",
   prompt="Review UI files for UX guideline compliance: {changed_ui_files}. Use core_ui_search against ux-guidelines and web-interface domains.")
 
 # ⑦ 접근성 감사 (Haiku)
-Task(subagent_type="ui-a11y-auditor",
+Task(subagent_type="design-reviewer",
   prompt="Audit UI files for WCAG 2.1 AA compliance: {changed_ui_files}.")
 
 # ⑧ 안티패턴 검출 (Haiku)
-Task(subagent_type="ui-antipattern-detector",
+Task(subagent_type="design-reviewer",
   prompt="Detect UI anti-patterns in: {changed_ui_files}. Check against MASTER.md if exists at .vibe/design-system/{project}/MASTER.md.")
 ```
 
 #### Visual P1 Baseline
 
 - 프로젝트 루트에 `DESIGN.md` 가 존재하면 **시각 P1 의 1 차 baseline** 으로 사용한다 (§2 Color Palette / §7 Do's & Don'ts).
-- `DESIGN.md` 부재 시 기존 폴백을 사용 (WCAG 2.1 AA + `MASTER.md` + design-audit 기본 5 차원).
+- `DESIGN.md` 부재 시 기존 폴백을 사용 (WCAG 2.1 AA + `MASTER.md` + design-review(audit 모드) 기본 5 차원).
 - v1 범위: hex 컬러 드리프트만 P1 후보. spacing / font 드리프트는 Phase 2+ 에서 추가.
 - 안티패턴 검출(⑧) 은 `DESIGN.md §7` 의 "DON'T" 항목을 우선 규칙으로 사용한다.
 
 **findings 통합**: ⑥⑦⑧ findings를 기존 findings[]와 병합 → P1/P2/P3 통합 정렬
 
-**⑦ Critical finding 에스컬레이션**: ui-a11y-auditor의 P1 finding은 Review Debate Team(Phase 4.5)에 자동 포함
+**⑦ Critical finding 에스컬레이션**: design-reviewer(접근성)의 P1 finding은 Review Debate(Phase 4.5)에 자동 포함
 
 ### Phase 2.7: Boundary Mismatch Detection (Integration Coherence)
 
@@ -362,36 +360,36 @@ P3 NICE-TO-HAVE (Enhancement) - N issues
 4. [STYLE] Consider extracting helper function
 ```
 
-### Phase 4.5: Agent Teams — Review Debate
+### Phase 4.5: Review Debate (parallel native subagents)
 
-> **팀 정의**: `agents/teams/review-debate-team.md` 참조 (Code Review 컨텍스트)
-> 설정: `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1` + `teammateMode: in-process` (`~/.claude/settings.json` 전역 — postinstall 자동 설정)
+> P1/P2 findings 를 검증하기 위해 네이티브 서브에이전트를 병렬로 스폰한다 —
+> `security-reviewer` + `code-reviewer` 인스턴스(서로 다른 focus)가 각 finding 을 교차 검증(validate / upgrade / downgrade / remove)한다.
 
 **토론 결과 예시:**
 
 ```
 🤝 REVIEW DEBATE RESULTS
 
-Team Consensus (4 reviewers):
+Consensus (4 parallel reviewers):
 
 ✅ Validated P1 (unanimous):
   1. [SECURITY] SQL Injection — 4/4 agree critical
 
 ⬆️ Upgraded P2→P1 (debate result):
-  2. [PERF] Unbounded query — architecture-reviewer pointed out
-     cascading failure risk under load → team agreed P1
+  2. [PERF] Unbounded query — code-reviewer (focus: architecture) pointed out
+     cascading failure risk under load → agreed P1
 
 ⬇️ Downgraded P1→P2 (debate result):
-  3. [SECURITY] CSRF on read-only endpoint — simplicity-reviewer
-     noted endpoint has no side effects → team agreed P2
+  3. [SECURITY] CSRF on read-only endpoint — code-reviewer (focus: complexity)
+     noted endpoint has no side effects → agreed P2
 
 ❌ Removed (false positive):
-  4. [ARCH] "Circular dependency" — architecture-reviewer confirmed
+  4. [ARCH] "Circular dependency" — code-reviewer (focus: architecture) confirmed
      this is intentional bi-directional reference, not a cycle
 
-🆕 New findings (team discussion):
+🆕 New findings (cross-review discussion):
   5. [DATA] Race condition in concurrent updates — emerged from
-     security + performance discussion
+     security + performance cross-review
 ```
 
 ### Phase 5: Auto-Fix (P1/P2)
@@ -452,7 +450,7 @@ Examples:
 CODE REVIEW SUMMARY
 PR #123: Add user authentication
 
-Reviewers: 13 agents
+Reviewers: security-reviewer + 8 code-reviewer instances (per-focus) + 3 design-reviewer instances (UI)
 ⏱️ Started: {start_time}
 ⏱️ Completed: {getCurrentTime 결과}
 
@@ -519,8 +517,6 @@ node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/tools/index
 |------|---------|-------------|
 | `validateCodeQuality` | Code quality check | Overall code quality scan |
 | `analyzeComplexity` | Complexity metrics | Check function complexity |
-| `findSymbol` | Find definitions | Locate implementations |
-| `findReferences` | Find all usages | Track symbol usage |
 | `saveMemory` | Save findings | Store important review findings |
 
 ### Example Tool Usage in Review

package/skills/vibe.run/SKILL.md

@@ -278,7 +278,7 @@ SPEC changes and code changes must be in the **same commit**.
 
 ### 3. Scenario-by-Scenario Implementation
 
-> Read `references/parallel-agents.md` for full parallel exploration patterns, background agents, agent team selection, and model routing.
+> Read `references/parallel-agents.md` for full parallel exploration patterns, background agents, parallel subagent group selection, and model routing.
 
 **For each scenario:**
 1. [Parallel exploration] Task(haiku) × 3 — related code, deps, patterns
@@ -287,8 +287,7 @@ SPEC changes and code changes must be in the **same commit**.
 4. [Auto-fix loop] On failure: collect evidence → root cause → fix → re-verify
 
 **UI/UX Design Intelligence (auto-triggered before Phase 1 if UI keywords in SPEC):**
-- Task(haiku, `ui-stack-implementer`): framework-specific component guidelines
-- Task(haiku, `ui-dataviz-advisor`): chart/viz library advice (conditional on chart keywords)
+- Task(haiku, `design-system-gen`): framework-specific component guidelines + chart/viz library advice (viz advice conditional on chart keywords)
 - Load `.vibe/design-system/{project}/MASTER.md` if present
 
 ### 4. Brand Assets (New project only)
@@ -346,8 +345,6 @@ node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/tools/index
 
 | Tool | Purpose |
 |------|---------|
-| `findSymbol` | Find symbol definitions |
-| `findReferences` | Find all references |
 | `analyzeComplexity` | Analyze code complexity |
 | `validateCodeQuality` | Validate code quality |
 | `saveMemory` | Save important decisions |

package/skills/vibe.run/references/parallel-agents.md

@@ -1,6 +1,6 @@
 # Parallel Agents & Model Orchestration — Full Reference
 
-> Loaded by vibe.run SKILL.md when parallel execution patterns, agent teams, or model selection details are needed.
+> Loaded by vibe.run SKILL.md when parallel execution patterns, parallel subagent groups, or model selection details are needed.
 
 ## Model Orchestration (Intelligent Routing)
 
@@ -28,13 +28,15 @@ Automatically select optimal model based on **task complexity analysis**.
 | Bug fix | -3 |
 | Documentation | -5 |
 
-### Agent Tier System
+### Agent × Model Selection
 
-| Agent | Low (Haiku) | Medium (Sonnet) | High (Opus) |
+Tier-variant agents were consolidated — the model is a Task parameter, not a separate agent:
+
+| Agent | Low | Medium | High |
 |-------|-------------|-----------------|-------------|
-| explorer | explorer-low | explorer-medium | explorer |
-| implementer | implementer-low | implementer-medium | implementer |
-| architect | architect-low | architect-medium | architect |
+| Explore (native) | `model: "haiku"` | `model: "sonnet"` | `model: "opus"` |
+| implementer | `model: "haiku"` | `model: "sonnet"` | `model: "opus"` |
+| architect | `model: "haiku"` | `model: "sonnet"` | `model: "opus"` |
 
 ### Task Calls by Role
 
@@ -122,33 +124,18 @@ Automatically select optimal model based on **task complexity analysis**.
 → 3x slower, wastes time
 ```
 
-### Background Agent Pattern (ULTRAWORK) via Orchestrator
+### Background Agent Pattern (autonomous + parallel ACT)
 
-```bash
-# Start background agent (doesn't block)
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(o => o.runAgent('Phase 2 prep: Analyze auth API endpoints', 'phase2-prep').then(r => console.log(r.content[0].text)))"
-
-# Multiple backgrounds in parallel
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(async o => {
-  await Promise.all([
-    o.runAgent('Phase 2 prep: Analyze auth API endpoints', 'phase2-prep'),
-    o.runAgent('Pre-generate test cases for login form', 'test-prep'),
-    o.runAgent('Find existing validation patterns', 'pattern-finder')
-  ]);
-  console.log('All background agents started');
-})"
-```
+Use the harness's native background subagents — spawn them in one message and continue working; completion notifications arrive automatically:
 
-**Check background agent status:**
-```bash
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(o => console.log(o.status().content[0].text))"
 ```
-
-**Get result when ready:**
-```bash
-node -e "import('{{VIBE_PATH_URL}}/node_modules/@su-record/vibe/dist/infra/orchestrator/index.js').then(o => o.getResult('SESSION_ID').then(r => console.log(r.content[0].text)))"
+Task (Explore, background): "Phase 2 prep: Analyze auth API endpoints"
+Task (tester, background): "Pre-generate test cases for login form"
+Task (Explore, background): "Find existing validation patterns"
 ```
 
+No status polling is needed — the harness re-invokes you when each background agent completes. (구 자체 오케스트레이터 runAgent/status/getResult 체계는 제거됨 — 네이티브 background subagent 가 대체.)
+
 ### Phase Execution Flow (ULTRAWORK Pipeline)
 
 ```
@@ -198,81 +185,29 @@ Phase N+1 Start (IMMEDIATE — exploration already done!)
 - Test cases pre-generated during implementation
 - Cache stays warm across parallel tasks
 
-## Agent Teams
-
-### Dev Team (Full)
-
-> **팀 정의**: `agents/teams/dev-team.md` 참조
-> 설정: `CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1` + `teammateMode: in-process`
-
-**활성화 조건:**
-- ULTRAWORK 모드 + 3개 이상 시나리오
-- 또는 복잡도 점수 20+ (High)
-
-### Lite Team (Normal Mode)
-
-> **팀 정의**: `agents/teams/lite-team.md` 참조
-
-**활성화 조건:**
-- 일반 모드 + 3개 이상 시나리오
-- 복잡도 점수 8-19 (Medium)
-- 단순 구현(1-2 파일, 시나리오 2개 이하)에서는 기존 병렬 모드 유지
-
-**팀 선택 기준:**
-
-| 조건 | 팀 |
-|------|-----|
-| 시나리오 1-2개, 파일 1-2개 | 기존 병렬 모드 (팀 없음) |
-| 시나리오 3개+, 일반 모드 | **Lite Team (3명)** |
-| ULTRAWORK 또는 복잡도 20+ | Dev Team Full (4명) |
-
-### Review Team
-
-> **팀 정의**: `agents/teams/review-debate-team.md` 참조
-
-**활성화 조건:**
-- `/vibe.review` 실행 후 P1 또는 P2 이슈 2개 이상 발견 시
-- Agent Teams 환경변수 활성화 상태
-
-### Debug Team
-
-> **팀 정의**: `agents/teams/debug-team.md` 참조
-
-**활성화 조건:**
-- 동일 빌드/테스트 실패 3회 이상
-- architecture-level uncertainty during review (stuck on root cause)
-
-### Research Team
-
-> **팀 정의**: `agents/teams/research-team.md` 참조
-
-**활성화 조건:**
-- `/vibe.spec` Step 3 리서치 단계
-- Agent Teams 환경변수 활성화 상태
-
-### Security Team
-
-> **팀 정의**: `agents/teams/security-team.md` 참조
-
-**활성화 조건:**
-- auth, payment, user-data, crypto 관련 파일 변경 감지 시
-- 또는 수동으로 `security` 키워드 지정 시
-
-### Migration Team
+## Parallel Subagent Groups
 
-> **팀 정의**: `agents/teams/migration-team.md` 참조
+> 별도 "팀" 에이전트는 없다 — 상황별로 **네이티브 서브에이전트를 병렬 스폰**한다
+> (단일 메시지, 다중 Task 호출). 아래는 상황 → 병렬 구성 매핑.
 
-**활성화 조건:**
-- package.json 주요 의존성 버전 변경 감지 시
-- 또는 수동으로 `migration` 키워드 지정 시
+**병렬 구성 선택 기준:**
 
-### Fullstack Team
+| 조건 | 병렬 구성 |
+|------|-----------|
+| 시나리오 1-2개, 파일 1-2개 | 기존 병렬 모드 (추가 구성 없음) |
+| 시나리오 3개+, 일반 모드 | implementer + tester + Explore (3 병렬) |
+| ULTRAWORK 또는 복잡도 20+ | architect + implementer + tester + code-reviewer (4 병렬) |
 
-> **팀 정의**: `agents/teams/fullstack-team.md` 참조
+**상황별 병렬 스폰:**
 
-**활성화 조건:**
-- SPEC에 frontend + backend 파일이 모두 포함된 경우
-- 또는 수동으로 `fullstack` 키워드 지정 시
+| 상황 | 활성화 조건 | 병렬 서브에이전트 |
+|------|------------|------------------|
+| Review Debate | `/vibe.review` 후 P1/P2 이슈 2개 이상 | security-reviewer + code-reviewer 인스턴스(focus별) |
+| Debug | 동일 빌드/테스트 실패 3회 이상, 또는 root cause stuck | build-error-resolver + Explore + code-reviewer (focus: correctness) |
+| Research | `/vibe.spec` Step 3 리서치 단계 | Explore × N + native WebSearch |
+| Security | auth/payment/user-data/crypto 파일 변경, 또는 `security` 키워드 | security-reviewer + code-reviewer (focus: data-integrity) |
+| Migration | package.json 주요 의존성 버전 변경, 또는 `migration` 키워드 | Explore(변경 영향 조사) + implementer + tester |
+| Fullstack | SPEC에 frontend + backend 파일 모두 포함, 또는 `fullstack` 키워드 | implementer(FE) + implementer(BE) + tester |
 
 ## External LLM Usage (When Enabled)