@stigmer/react 3.6.0 → 3.7.0

package/src/schedule/__tests__/ScheduleDetailView.test.tsx

@@ -4,7 +4,15 @@ import type { ReactNode } from "react";
 import { clone, create } from "@bufbuild/protobuf";
 import { timestampFromDate } from "@bufbuild/protobuf/wkt";
 import { ScheduleSchema, type Schedule } from "@stigmer/protos/ai/stigmer/agentic/schedule/v1/api_pb";
+import {
+  ScheduleTriggerResultSchema,
+  ScheduleRunListSchema,
+  ScheduleRunSchema,
+  ScheduleRunOutcome,
+  ScheduleRunOrigin,
+} from "@stigmer/protos/ai/stigmer/agentic/schedule/v1/io_pb";
 import { ApiResourceKind } from "@stigmer/protos/ai/stigmer/commons/apiresource/apiresourcekind/api_resource_kind_pb";
+import { Harness } from "@stigmer/protos/ai/stigmer/agentic/session/v1/enum_pb";
 import { StigmerContext } from "../../context";
 import { FetchCacheContext } from "../../internal/FetchCacheProvider";
 import { ScheduleDetailView } from "../ScheduleDetailView";
@@ -32,6 +40,15 @@ function makeSchedule(overrides?: {
   enabled?: boolean;
   pausedReason?: string;
   lastExecutionId?: string;
+  cron?: string;
+  consecutiveFailures?: number;
+  environmentRefs?: readonly { org: string; slug: string }[];
+  harness?: Harness;
+  runConfig?: {
+    modelName?: string;
+    maxCostUsd?: number;
+    maxToolRounds?: number;
+  };
 }): Schedule {
   return create(ScheduleSchema, {
     apiVersion: "agentic.stigmer.ai/v1",
@@ -43,7 +60,7 @@ function makeSchedule(overrides?: {
       org: "isc",
     },
     spec: {
-      cron: "0 9 * * *",
+      cron: overrides?.cron ?? "0 9 * * *",
       timeZone: "Asia/Kolkata",
       enabled: overrides?.enabled ?? true,
       target: {
@@ -51,6 +68,15 @@ function makeSchedule(overrides?: {
         value: {
           agentRef: { kind: ApiResourceKind.agent, org: "isc", slug: "fee-reminder" },
           message: "Send today's fee reminders.",
+          environmentRefs: (overrides?.environmentRefs ?? []).map((r) => ({
+            kind: ApiResourceKind.environment,
+            org: r.org,
+            slug: r.slug,
+          })),
+          ...(overrides?.harness !== undefined
+            ? { harness: overrides.harness }
+            : {}),
+          ...(overrides?.runConfig ? { runConfig: overrides.runConfig } : {}),
         },
       },
     },
@@ -58,7 +84,8 @@ function makeSchedule(overrides?: {
       nextFireAt: timestampFromDate(new Date(NOW.getTime() + 3 * 3_600_000)),
       lastFireAt: timestampFromDate(new Date(NOW.getTime() - 5 * 60_000)),
       lastExecutionId: overrides?.lastExecutionId ?? "aex_01run",
-      consecutiveFailures: overrides?.pausedReason ? 5 : 0,
+      consecutiveFailures:
+        overrides?.consecutiveFailures ?? (overrides?.pausedReason ? 5 : 0),
       pausedReason: overrides?.pausedReason ?? "",
     },
   });
@@ -69,9 +96,12 @@ interface MockClient {
     getByReference: ReturnType<typeof vi.fn>;
     resume: ReturnType<typeof vi.fn>;
     trigger: ReturnType<typeof vi.fn>;
+    listRuns: ReturnType<typeof vi.fn>;
     delete: ReturnType<typeof vi.fn>;
   };
   manifest: { apply: ReturnType<typeof vi.fn> };
+  // The environments inline editor's picker lists the org's environments.
+  environment: { list: ReturnType<typeof vi.fn> };
 }
 
 function makeClient(schedule: Schedule): MockClient {
@@ -79,7 +109,18 @@ function makeClient(schedule: Schedule): MockClient {
     schedule: {
       getByReference: vi.fn().mockResolvedValue(schedule),
       resume: vi.fn().mockResolvedValue(schedule),
-      trigger: vi.fn().mockResolvedValue(schedule),
+      // The synchronous trigger answers with the run's real outcome
+      // (DD-017 D-6) — a started run by default.
+      trigger: vi.fn().mockResolvedValue(
+        create(ScheduleTriggerResultSchema, {
+          outcome: ScheduleRunOutcome.STARTED,
+          executionId: "aex_01triggered",
+          schedule,
+        }),
+      ),
+      listRuns: vi.fn().mockResolvedValue(
+        create(ScheduleRunListSchema, { items: [], totalCount: 0 }),
+      ),
       delete: vi.fn().mockResolvedValue(schedule),
     },
     manifest: {
@@ -93,6 +134,9 @@ function makeClient(schedule: Schedule): MockClient {
         message: doc.message,
       })),
     },
+    environment: {
+      list: vi.fn().mockResolvedValue({ items: [], totalCount: 0 }),
+    },
   };
 }
 
@@ -125,8 +169,10 @@ describe("ScheduleDetailView", () => {
     renderView(makeClient(makeSchedule()));
 
     await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // The cadence humanizes into plain English (the stored time zone is
+    // part of the sentence); the raw cron stays as the precise record.
+    expect(screen.getByText("Every day at 09:00 (Asia/Kolkata)")).toBeTruthy();
     expect(screen.getByText("0 9 * * *")).toBeTruthy();
-    expect(screen.getByText("Asia/Kolkata")).toBeTruthy();
     expect(screen.getByText("isc/fee-reminder")).toBeTruthy();
     expect(screen.getByText("Send today's fee reminders.")).toBeTruthy();
     expect(screen.getByText("in 3h")).toBeTruthy();
@@ -203,12 +249,68 @@ describe("ScheduleDetailView", () => {
     );
   });
 
-  it("disables Run now when the schedule cannot fire", async () => {
-    renderView(makeClient(makeSchedule({ enabled: false })));
+  it("offers 'Enable & run now' on a disabled schedule (DD-017 D-5)", async () => {
+    const client = makeClient(makeSchedule({ enabled: false }));
+    renderView(client);
 
     await screen.findByText("Schedule is disabled");
-    const runButton = screen.getByRole("button", { name: "Run now" });
-    expect((runButton as HTMLButtonElement).disabled).toBe(true);
+    // No plain "Run now": a disabled schedule cannot fire server-side, so
+    // the staged-test flow is one click that enables THEN fires.
+    expect(screen.queryByRole("button", { name: "Run now" })).toBeNull();
+    const enableAndRun = screen.getByRole("button", { name: "Enable & run now" });
+    expect((enableAndRun as HTMLButtonElement).disabled).toBe(false);
+
+    fireEvent.click(enableAndRun);
+    await screen.findByText("Enable and run this schedule now?");
+    fireEvent.click(screen.getByText("Enable & run"));
+
+    // Enable (a full-proto re-apply) THEN fire.
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    expect(doc.message.spec?.enabled).toBe(true);
+    await waitFor(() =>
+      expect(client.schedule.trigger).toHaveBeenCalledWith("sch_01example"),
+    );
+  });
+
+  it("navigates to the execution on a started run", async () => {
+    const onNavigateToExecution = vi.fn();
+    const client = makeClient(makeSchedule());
+    renderView(client, { onNavigateToExecution });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("button", { name: "Run now" }));
+    await screen.findByText("Run this schedule now?");
+    fireEvent.click(screen.getByText("Start run"));
+
+    await waitFor(() =>
+      expect(onNavigateToExecution).toHaveBeenCalledWith("aex_01triggered"),
+    );
+  });
+
+  it("renders the run history from the fire ledger", async () => {
+    const client = makeClient(makeSchedule());
+    client.schedule.listRuns.mockResolvedValue(
+      create(ScheduleRunListSchema, {
+        totalCount: 1,
+        items: [
+          create(ScheduleRunSchema, {
+            scheduleId: "sch_01example",
+            origin: ScheduleRunOrigin.CRON,
+            outcome: ScheduleRunOutcome.REFUSED,
+            reason:
+              "run refused: MCP server 'isc-gym' requires environment variable 'ISC_MCP_SHARED_SECRET'",
+            nominalFireTime: timestampFromDate(new Date(NOW.getTime() - 60_000)),
+          }),
+        ],
+      }),
+    );
+    renderView(client);
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // The refusal reason — invisible before the ledger — is now on screen.
+    await screen.findByText(/ISC_MCP_SHARED_SECRET/);
+    expect(screen.getByText("Refused")).toBeTruthy();
   });
 
   it("navigates through the callback seams (DD-004)", async () => {
@@ -257,4 +359,325 @@ describe("ScheduleDetailView", () => {
 
     expect(schedule.spec?.enabled).toBe(original.spec?.enabled);
   });
+
+  // -------------------------------------------------------------------------
+  // Cadence humanization
+  // -------------------------------------------------------------------------
+
+  it("falls back to the raw cron for expressions outside the builder's shapes", async () => {
+    renderView(makeClient(makeSchedule({ cron: "*/5 9-17 * * 1-5" })));
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // Unrecognized shape: the raw expression IS the primary display —
+    // no invented sentence — with the time zone shown alongside.
+    expect(screen.getByText("*/5 9-17 * * 1-5")).toBeTruthy();
+    expect(screen.getByText("Asia/Kolkata")).toBeTruthy();
+    expect(screen.queryByText(/^Every /)).toBeNull();
+  });
+
+  // -------------------------------------------------------------------------
+  // Failure streak
+  // -------------------------------------------------------------------------
+
+  it("renders a plain 0 for a healthy failure streak", async () => {
+    renderView(makeClient(makeSchedule()));
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    expect(screen.getByText("Failure streak")).toBeTruthy();
+    expect(screen.getByText("0")).toBeTruthy();
+    expect(screen.queryByText(/consecutive failed/)).toBeNull();
+  });
+
+  it("explains a non-zero failure streak in plain language", async () => {
+    renderView(makeClient(makeSchedule({ consecutiveFailures: 2 })));
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    expect(screen.getByText("2 consecutive failed runs")).toBeTruthy();
+    // The copy stays qualitative: the pause threshold is server config
+    // the API does not expose, so no hardcoded denominator.
+    expect(
+      screen.getByText(/pauses the schedule automatically/),
+    ).toBeTruthy();
+    expect(screen.getByText(/Manual runs never count/)).toBeTruthy();
+  });
+
+  // -------------------------------------------------------------------------
+  // Tabs — Overview and the paginated Runs tab
+  // -------------------------------------------------------------------------
+
+  it("splits into Overview and Runs tabs, with the run count as badge", async () => {
+    const client = makeClient(makeSchedule());
+    client.schedule.listRuns.mockResolvedValue(
+      create(ScheduleRunListSchema, {
+        totalCount: 12,
+        items: [
+          create(ScheduleRunSchema, {
+            scheduleId: "sch_01example",
+            origin: ScheduleRunOrigin.CRON,
+            outcome: ScheduleRunOutcome.COMPLETED,
+            nominalFireTime: timestampFromDate(new Date(NOW.getTime() - 60_000)),
+          }),
+        ],
+      }),
+    );
+    renderView(client);
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // The badge fills in once the (separate) runs fetch resolves.
+    await waitFor(() => {
+      const tabs = screen.getAllByRole("tab");
+      expect(tabs.map((t) => t.textContent)).toEqual(["Overview", "Runs12"]);
+    });
+    // Overview is the default: definition on screen, no full table.
+    expect(screen.getByText("Target agent")).toBeTruthy();
+
+    fireEvent.click(screen.getByRole("tab", { name: /Runs/ }));
+    await screen.findByRole("table", { name: "Run history" });
+    expect(screen.queryByText("Target agent")).toBeNull();
+  });
+
+  it("pages through the run history (the hook's pagination, finally used)", async () => {
+    const client = makeClient(makeSchedule());
+    client.schedule.listRuns.mockImplementation(
+      async (req: { pageInfo?: { num: number; size: number } }) =>
+        create(ScheduleRunListSchema, {
+          totalCount: 30,
+          items: Array.from(
+            { length: Math.min(req.pageInfo?.size ?? 25, 30) },
+            (_, i) =>
+              create(ScheduleRunSchema, {
+                scheduleId: "sch_01example",
+                origin: ScheduleRunOrigin.CRON,
+                outcome: ScheduleRunOutcome.COMPLETED,
+                nominalFireTime: timestampFromDate(
+                  new Date(NOW.getTime() - (i + 1) * 60_000),
+                ),
+              }),
+          ),
+        }),
+    );
+    renderView(client);
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("tab", { name: /Runs/ }));
+    await screen.findByText("Page 1 of 2");
+
+    fireEvent.click(screen.getByRole("button", { name: "Next" }));
+    await waitFor(() => {
+      const pageTwoCall = client.schedule.listRuns.mock.calls.find((call) => {
+        const req = call[0] as { pageInfo?: { num: number; size: number } };
+        return req.pageInfo?.num === 2 && req.pageInfo?.size === 25;
+      });
+      expect(pageTwoCall).toBeTruthy();
+    });
+    await screen.findByText("Page 2 of 2");
+  });
+
+  it("links the Overview recent-runs strip to the Runs tab", async () => {
+    const client = makeClient(makeSchedule());
+    client.schedule.listRuns.mockImplementation(
+      async (req: { pageInfo?: { num: number; size: number } }) =>
+        create(ScheduleRunListSchema, {
+          totalCount: 12,
+          items: Array.from(
+            { length: Math.min(req.pageInfo?.size ?? 25, 12) },
+            (_, i) =>
+              create(ScheduleRunSchema, {
+                scheduleId: "sch_01example",
+                origin: ScheduleRunOrigin.CRON,
+                outcome: ScheduleRunOutcome.COMPLETED,
+                nominalFireTime: timestampFromDate(
+                  new Date(NOW.getTime() - (i + 1) * 60_000),
+                ),
+              }),
+          ),
+        }),
+    );
+    renderView(client);
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(
+      await screen.findByRole("button", { name: "View all 12 runs" }),
+    );
+    await screen.findByRole("table", { name: "Run history" });
+  });
+
+  // -------------------------------------------------------------------------
+  // Inline editing — every save re-applies the FULL proto (never a
+  // down-converted input, which would silently wipe fields)
+  // -------------------------------------------------------------------------
+
+  it("does not offer inline editing without the editable prop", async () => {
+    renderView(makeClient(makeSchedule()));
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByText("Send today's fee reminders."));
+    expect(screen.queryByRole("textbox")).toBeNull();
+    expect(screen.queryByRole("button", { name: "Edit cadence" })).toBeNull();
+  });
+
+  it("never offers an edit affordance for the immutable target agent", async () => {
+    renderView(makeClient(makeSchedule()), { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // The mutable fields have editors; the server-immutable target does not.
+    expect(screen.getByRole("button", { name: "Edit cadence" })).toBeTruthy();
+    expect(
+      screen.queryByRole("button", { name: /edit target/i }),
+    ).toBeNull();
+  });
+
+  it("saves an edited message by re-applying the full proto", async () => {
+    const client = makeClient(makeSchedule());
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByText("Send today's fee reminders."));
+    const textarea = await screen.findByRole("textbox");
+    fireEvent.change(textarea, {
+      target: { value: "Send this week's fee reminders." },
+    });
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    const target =
+      doc.message.spec?.target?.case === "agent"
+        ? doc.message.spec.target.value
+        : undefined;
+    expect(target?.message).toBe("Send this week's fee reminders.");
+    // Full-proto write: everything the editor did not touch survives.
+    expect(doc.message.metadata?.id).toBe("sch_01example");
+    expect(doc.message.spec?.cron).toBe("0 9 * * *");
+    expect(doc.message.spec?.enabled).toBe(true);
+    expect(target?.agentRef?.slug).toBe("fee-reminder");
+  });
+
+  it("saves an edited cadence through the custom-cron escape hatch", async () => {
+    const client = makeClient(makeSchedule());
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("button", { name: "Edit cadence" }));
+    // The stored cron round-trips into the preset picker; Custom
+    // prefills from it rather than starting blank.
+    fireEvent.click(screen.getByRole("radio", { name: "Custom cron" }));
+    fireEvent.change(screen.getByLabelText("Cron expression"), {
+      target: { value: "0 9 * * 1-5" },
+    });
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    expect(doc.message.spec?.cron).toBe("0 9 * * 1-5");
+    // The time zone rides along with the cadence editor, unchanged here.
+    expect(doc.message.spec?.timeZone).toBe("Asia/Kolkata");
+  });
+
+  it("saves an edited budget, preserving the model and the API-only tool rounds", async () => {
+    const client = makeClient(
+      makeSchedule({
+        harness: Harness.CURSOR,
+        runConfig: { modelName: "composer-2", maxToolRounds: 15 },
+      }),
+    );
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("button", { name: "Edit budget" }));
+    fireEvent.change(screen.getByLabelText("Budget per run (USD)"), {
+      target: { value: "2.5" },
+    });
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    const target =
+      doc.message.spec?.target?.case === "agent"
+        ? doc.message.spec.target.value
+        : undefined;
+    expect(target?.runConfig?.maxCostUsd).toBe(2.5);
+    // The budget editor owns exactly one field — everything else the
+    // run config stores survives the save.
+    expect(target?.runConfig?.modelName).toBe("composer-2");
+    expect(target?.runConfig?.maxToolRounds).toBe(15);
+    expect(target?.harness).toBe(Harness.CURSOR);
+  });
+
+  it("resetting engine & model unpins both, preserving the budget", async () => {
+    const client = makeClient(
+      makeSchedule({
+        harness: Harness.CURSOR,
+        runConfig: { modelName: "composer-2", maxCostUsd: 2.5 },
+      }),
+    );
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    // The read view names the pinned engine and model.
+    expect(screen.getByText("Cursor · composer-2")).toBeTruthy();
+
+    fireEvent.click(
+      screen.getByRole("button", { name: "Edit engine and model" }),
+    );
+    fireEvent.click(
+      screen.getByRole("button", { name: "Reset to platform default" }),
+    );
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    const target =
+      doc.message.spec?.target?.case === "agent"
+        ? doc.message.spec.target.value
+        : undefined;
+    // Model and harness are one atomic choice: unpinning the model
+    // unpins the engine with it (the platform defaults apply again)...
+    expect(target?.harness).toBe(Harness.UNSPECIFIED);
+    expect(target?.runConfig?.modelName).toBe("");
+    // ...while the budget the editor does not own survives.
+    expect(target?.runConfig?.maxCostUsd).toBe(2.5);
+  });
+
+  it("round-trips environment references with the environment kind stamped", async () => {
+    const client = makeClient(
+      makeSchedule({
+        environmentRefs: [{ org: "isc", slug: "isc-mcp-credentials" }],
+      }),
+    );
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("button", { name: "Edit environments" }));
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    await waitFor(() => expect(client.manifest.apply).toHaveBeenCalledOnce());
+    const doc = client.manifest.apply.mock.calls[0][0] as { message: Schedule };
+    const target =
+      doc.message.spec?.target?.case === "agent"
+        ? doc.message.spec.target.value
+        : undefined;
+    expect(target?.environmentRefs).toHaveLength(1);
+    expect(target?.environmentRefs?.[0].slug).toBe("isc-mcp-credentials");
+    expect(target?.environmentRefs?.[0].kind).toBe(
+      ApiResourceKind.environment,
+    );
+  });
+
+  it("keeps the editor open with the server's message on a failed save", async () => {
+    const client = makeClient(makeSchedule());
+    client.manifest.apply.mockRejectedValueOnce(
+      new Error("spec.cron must have exactly 5 fields"),
+    );
+    renderView(client, { editable: true });
+
+    await screen.findByRole("heading", { name: "daily-fee-reminders" });
+    fireEvent.click(screen.getByRole("button", { name: "Edit cadence" }));
+    fireEvent.click(screen.getByRole("button", { name: "Save" }));
+
+    // The server's message lands next to the field; the editor stays
+    // open so the draft is not lost (DD-006).
+    await screen.findByText(/must have exactly 5 fields/);
+    expect(screen.getByRole("button", { name: "Save" })).toBeTruthy();
+  });
 });