@stigmer/react 3.6.0 → 3.7.0

package/src/schedule/ScheduleForm.tsx

@@ -2,12 +2,24 @@
 
 import { useCallback, useState, type FormEvent } from "react";
 import { cn } from "@stigmer/theme";
-import { getUserMessage, type ResourceRef } from "@stigmer/sdk";
+import {
+  getUserMessage,
+  type ResourceRef,
+  type RunConfigInput,
+} from "@stigmer/sdk";
 import type { Schedule } from "@stigmer/protos/ai/stigmer/agentic/schedule/v1/api_pb";
+import { ApiResourceVisibility } from "@stigmer/protos/ai/stigmer/commons/apiresource/enum_pb";
 import { Popover } from "@base-ui/react/popover";
 import { AgentPicker } from "../agent/AgentPicker.js";
+import { EnvironmentPicker } from "../environment/EnvironmentPicker.js";
+import { useGitHubConnection } from "../github/useGitHubConnection.js";
+import { ModelSelector } from "../models/ModelSelector.js";
+import { toProtoHarness, type HarnessOption } from "../models/harness.js";
+import { toProtoServiceTier, type ServiceTierOption } from "../models/service-tier.js";
 import { Switch } from "../switch/Switch.js";
 import { useStigmerPortalContainer } from "../portal-container.js";
+import { useWorkspaceEntries } from "../workspace/useWorkspaceEntries.js";
+import { WorkspaceEditor } from "../workspace/WorkspaceEditor.js";
 import { CadenceField } from "./CadenceField.js";
 import { TimeZoneField, browserTimeZone } from "./TimeZoneField.js";
 import { useCreateSchedule } from "./useCreateSchedule.js";
@@ -33,7 +45,7 @@ export interface ScheduleFormProps {
   readonly className?: string;
 }
 
-/** spec.proto pins AgentTarget.message to 8192 characters. */
+/** invocation.proto pins AgentInvocation.message to 8192 characters. */
 const MESSAGE_MAX_LEN = 8192;
 /** Show the remaining-characters counter once within this margin. */
 const MESSAGE_COUNTER_THRESHOLD = 500;
@@ -41,10 +53,13 @@ const MESSAGE_COUNTER_THRESHOLD = 500;
 /**
  * Single-page form for creating a {@link Schedule}.
  *
- * Collects the four things a user decides about a schedule — which
- * agent, what message, when ({@link CadenceField}, generating the cron
- * expression from human-friendly presets), and whether it starts
- * enabled — then creates it via {@link useCreateSchedule}.
+ * The form speaks the composer's vocabulary (DD-018 D-5): a schedule is
+ * a saved run — which agent, what message, what workspace, which
+ * engine and model, what budget — plus a cadence. It reuses the
+ * composer's own pickers ({@link ModelSelector}, {@link WorkspaceEditor})
+ * so the interactive and scheduled surfaces cannot drift, minus only
+ * what unattended makes impossible (no local folders, no attachments,
+ * no approval-mode choice).
  *
  * Enabled defaults to OFF, deliberately: it matches the proto/YAML
  * default (an omitted `enabled` is false) and the platform's
@@ -83,6 +98,32 @@ export function ScheduleForm({
   const [timeZone, setTimeZone] = useState(browserTimeZone);
   const [enabled, setEnabled] = useState(false);
   const [pickerOpen, setPickerOpen] = useState(false);
+  const [environmentRefs, setEnvironmentRefs] = useState<ResourceRef[]>([]);
+
+  // Engine & model are one atomic choice: picking a model pins BOTH the
+  // harness and the model (the registry scopes models per harness, so a
+  // model without its harness is meaningless). Empty model = nothing
+  // pinned = the platform defaults apply to both. Browsing harnesses in
+  // the popover without picking a model pins nothing.
+  const [modelName, setModelName] = useState("");
+  const [modelHarness, setModelHarness] = useState<HarnessOption>("cursor");
+  // Service tier rides the model choice (#357): the ModelSelector renders
+  // the fast toggle only for models whose registry entry prices a fast
+  // variant, and resets it when the user switches to one that does not.
+  // No model pinned = no tier pinned (fast requires a model, and the form's
+  // reset button clears both).
+  const [serviceTier, setServiceTier] = useState<ServiceTierOption>("standard");
+
+  const [budgetUsd, setBudgetUsd] = useState("");
+
+  // Workspace the fresh per-fire session clones — git sources only
+  // (write-time validated server-side: no client is connected at fire
+  // time to serve a local folder). The GitHub repo picker lights up
+  // when the user already has a connection; otherwise the editor's
+  // manual URL+branch input applies, with no OAuth flow forced into
+  // this form.
+  const workspace = useWorkspaceEntries();
+  const gitHub = useGitHubConnection(org);
 
   const trimmedName = name.trim();
   const trimmedMessage = message.trim();
@@ -108,6 +149,7 @@ export function ScheduleForm({
       if (!canSubmit || !agentRef) return;
 
       clearError();
+      const runConfig = buildRunConfig(modelName, budgetUsd, serviceTier);
       try {
         const schedule = await create({
           name: trimmedName,
@@ -115,7 +157,20 @@ export function ScheduleForm({
           cron,
           timeZone,
           enabled,
-          agent: { agentRef, message: trimmedMessage },
+          agent: {
+            agentRef,
+            message: trimmedMessage,
+            // The harness travels with the model it was picked under;
+            // no model means no harness — the platform defaults apply.
+            ...(modelName !== ""
+              ? { harness: toProtoHarness(modelHarness) }
+              : {}),
+            ...(workspace.hasEntries
+              ? { workspaceEntries: workspace.toInput() }
+              : {}),
+            ...(environmentRefs.length > 0 ? { environmentRefs } : {}),
+            ...(runConfig ? { runConfig } : {}),
+          },
         });
         onComplete?.(schedule);
       } catch {
@@ -133,6 +188,12 @@ export function ScheduleForm({
       timeZone,
       enabled,
       trimmedMessage,
+      environmentRefs,
+      modelName,
+      modelHarness,
+      serviceTier,
+      budgetUsd,
+      workspace,
       onComplete,
     ],
   );
@@ -224,6 +285,53 @@ export function ScheduleForm({
         )}
       </div>
 
+      {/* Workspace — what each fire's fresh session operates on
+          (DD-018 D-4). Git sources only; the server refuses local
+          folders at write time because no client is connected when a
+          schedule fires. */}
+      <div className="space-y-1">
+        <span className={labelClasses}>
+          Workspace{" "}
+          <span className="font-normal text-muted-foreground">(optional)</span>
+        </span>
+        <WorkspaceEditor
+          workspace={workspace}
+          gitHubConnection={gitHub.isConnected ? gitHub : undefined}
+          enableGitHub
+          enableLocal={false}
+          disabled={isCreating}
+        />
+        <p className={hintClasses}>
+          Each run clones these repositories fresh. Private repositories need
+          a <code className="font-mono">GITHUB_TOKEN</code> in one of this
+          schedule&rsquo;s environments; public ones need nothing.
+        </p>
+      </div>
+
+      {/* Environments — how a tool-using agent becomes schedulable
+          (DD-017 D-2). Only org-shared environments resolve for a
+          schedule fire, so the picker is filtered to visibility_org —
+          the same credential surface a channel binding uses. */}
+      <div className="space-y-1">
+        <span id="stgm-new-schedule-env-label" className={labelClasses}>
+          Environments <span className="font-normal text-muted-foreground">(optional)</span>
+        </span>
+        <EnvironmentPicker
+          org={org}
+          value={environmentRefs}
+          onChange={setEnvironmentRefs}
+          disabled={isCreating}
+          filterEnvironment={(env) =>
+            env.metadata?.visibility === ApiResourceVisibility.visibility_org
+          }
+        />
+        <p className={hintClasses}>
+          Bind org-shared credentials (for example an MCP server&rsquo;s secret)
+          so the agent&rsquo;s tools work on an unattended fire. Without this, an
+          agent whose tools need credentials will be refused every run.
+        </p>
+      </div>
+
       {/* Cadence */}
       <div className="space-y-1">
         <span className={labelClasses}>Runs</span>
@@ -235,6 +343,75 @@ export function ScheduleForm({
         />
       </div>
 
+      {/* Engine & model — the composer's own picker (DD-018 D-5),
+          replacing the free-text model box whose typos surfaced as
+          fire-time failures. Nothing is pinned until a model is picked. */}
+      <div className="space-y-1">
+        <span className={labelClasses}>
+          Engine &amp; model{" "}
+          <span className="font-normal text-muted-foreground">(optional)</span>
+        </span>
+        <div className="flex items-center gap-2">
+          <ModelSelector
+            value={modelName}
+            onValueChange={setModelName}
+            initialHarness={modelHarness}
+            onHarnessChange={setModelHarness}
+            serviceTier={serviceTier}
+            onServiceTierChange={setServiceTier}
+            placeholderLabel="Platform default"
+            disabled={isCreating}
+          />
+          {modelName !== "" && (
+            <button
+              type="button"
+              onClick={() => {
+                setModelName("");
+                setServiceTier("standard");
+              }}
+              disabled={isCreating}
+              className={cn(
+                "rounded-md px-2 py-1 text-[0.65rem] text-muted-foreground",
+                "hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
+                "disabled:pointer-events-none disabled:opacity-50",
+              )}
+            >
+              Reset to platform default
+            </button>
+          )}
+        </div>
+        <p className={hintClasses}>
+          Runs use the platform&rsquo;s default engine and model unless you
+          pick one here. Picking a model pins the engine it belongs to.
+        </p>
+      </div>
+
+      {/* Budget — the one run bound that matters for an unattended
+          surface: nobody is watching a 3 AM fire (DD-018 D-5). Clamped
+          by the platform profile; tool-round bounds stay API-only. */}
+      <div className="space-y-1">
+        <label htmlFor="stgm-new-schedule-budget" className={labelClasses}>
+          Budget per run (USD){" "}
+          <span className="font-normal text-muted-foreground">(optional)</span>
+        </label>
+        <input
+          id="stgm-new-schedule-budget"
+          type="number"
+          min="0"
+          step="any"
+          value={budgetUsd}
+          onChange={(e) => setBudgetUsd(e.target.value)}
+          placeholder="platform default"
+          disabled={isCreating}
+          className={cn(inputClasses, "sm:max-w-48")}
+        />
+        <p className={hintClasses}>
+          Each run stops when it reaches this spend. You can lower the
+          platform&rsquo;s per-run cap, never raise it past the
+          platform&rsquo;s ceiling.
+        </p>
+      </div>
+
       {/* Time zone */}
       <div className="space-y-1">
         <label htmlFor="stgm-new-schedule-tz" className={labelClasses}>
@@ -318,6 +495,39 @@ export function ScheduleForm({
 
 const labelClasses = "block text-xs font-medium text-foreground";
 const hintClasses = "text-[0.65rem] text-muted-foreground";
+
+/**
+ * Assemble a {@link RunConfigInput} from the model choice and budget, or
+ * `undefined` when both are unset — an all-empty run_config carries no
+ * meaning, and omitting it keeps the schedule on the platform defaults
+ * (the server's own "empty = inherit" contract, DD-017 D-3 as carried
+ * into DD-018 D-2). Non-numeric or negative budgets are dropped rather
+ * than sent; the proto's `gte = 0` constraint would reject them anyway,
+ * and a blank field must not become a zero override. `max_tool_rounds`
+ * is deliberately not collected here — an implementation knob, not a
+ * user concept; API-reachable for operators (DD-018 D-5).
+ */
+function buildRunConfig(
+  modelName: string,
+  budgetUsd: string,
+  serviceTier: ServiceTierOption,
+): RunConfigInput | undefined {
+  const model = modelName.trim();
+  const cost = Number.parseFloat(budgetUsd);
+
+  const config: RunConfigInput = {};
+  if (model !== "") config.modelName = model;
+  if (Number.isFinite(cost) && cost > 0) config.maxCostUsd = cost;
+  // Carried only when the user actively chose fast AND pinned a model
+  // (fast is a per-model price; the server refuses it without one). An
+  // untouched toggle stays absent — unspecified-vs-explicit is a
+  // load-bearing ledger distinction (#357).
+  if (serviceTier === "fast" && model !== "") {
+    config.serviceTier = toProtoServiceTier(serviceTier);
+  }
+
+  return Object.keys(config).length > 0 ? config : undefined;
+}
 const inputClasses = cn(
   "w-full rounded-md border border-input bg-background px-2.5 py-1.5 text-xs text-foreground",
   "placeholder:text-muted-foreground",