@stigmer/react 3.1.2 → 3.1.4

package/src/execution/__tests__/ArtifactRow.test.tsx

@@ -0,0 +1,139 @@
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { render, screen, fireEvent, cleanup } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import type { Stigmer } from "@stigmer/sdk";
+import { ExecutionArtifactSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
+import { ExecutionArtifactKind } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { StigmerContext } from "../../context";
+import { ArtifactRow } from "../ArtifactRow";
+
+function fileArtifact(name: string, sandboxPath = `.stigmer/${name}`) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.FILE,
+    sizeBytes: 2048n,
+    sandboxPath,
+    storageKey: `artifacts/aex_1/${name}`,
+  });
+}
+
+function dirArtifact(name: string) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.DIRECTORY,
+    sizeBytes: 4096n,
+    sandboxPath: `.stigmer/${name}`,
+    storageKey: `artifacts/aex_1/${name}`,
+  });
+}
+
+const getArtifactDownloadUrl = vi.fn().mockResolvedValue({ downloadUrl: "" });
+
+function createStigmerMock(): Stigmer {
+  return {
+    agentExecution: { getArtifactDownloadUrl },
+  } as unknown as Stigmer;
+}
+
+function renderRow(props: Partial<Parameters<typeof ArtifactRow>[0]> = {}) {
+  const merged = {
+    artifact: fileArtifact("notes.md"),
+    executionId: "aex_1",
+    onOpen: vi.fn(),
+    ...props,
+  } as Parameters<typeof ArtifactRow>[0];
+  return render(
+    <StigmerContext.Provider value={createStigmerMock()}>
+      <ul>
+        <ArtifactRow {...merged} />
+      </ul>
+    </StigmerContext.Provider>,
+  );
+}
+
+afterEach(() => {
+  cleanup();
+  getArtifactDownloadUrl.mockClear();
+});
+
+describe("ArtifactRow — presentation", () => {
+  it("renders a file-type icon, the name, and the formatted size", () => {
+    renderRow({ artifact: fileArtifact("notes.md") });
+    const open = screen.getByText("notes.md").closest("button")!;
+    expect(open.querySelector("svg")).toBeTruthy();
+    expect(screen.getByText("2.0 KB")).toBeTruthy();
+  });
+
+  it("appends a trailing slash for a directory artifact", () => {
+    renderRow({ artifact: dirArtifact("return-policy") });
+    // The name span's own text is "return-policy" + "/".
+    expect(screen.getByText("return-policy/")).toBeTruthy();
+  });
+
+  it("shows the parent-directory subtitle only on a name collision", () => {
+    const artifact = fileArtifact("agent.yaml", "/workspace/configs/agent.yaml");
+    const { rerender } = renderRow({ artifact, hasNameCollision: true });
+    expect(screen.getByText("configs/")).toBeTruthy();
+
+    rerender(
+      <StigmerContext.Provider value={createStigmerMock()}>
+        <ul>
+          <ArtifactRow artifact={artifact} executionId="aex_1" onOpen={vi.fn()} />
+        </ul>
+      </StigmerContext.Provider>,
+    );
+    expect(screen.queryByText("configs/")).toBeNull();
+  });
+});
+
+describe("ArtifactRow — nested-interactive avoidance (DD-22)", () => {
+  it("renders the Download control as a SIBLING of the open button, never nested", () => {
+    renderRow({ artifact: fileArtifact("notes.md") });
+    const open = screen.getByText("notes.md").closest("button")!;
+    const download = screen.getByLabelText("Download notes.md");
+    expect(download.tagName).toBe("BUTTON");
+    // A <button> inside a <button> is a WCAG 4.1.2 nested-interactive violation.
+    expect(open.contains(download)).toBe(false);
+  });
+});
+
+describe("ArtifactRow — open / activate interaction (file-tree parity)", () => {
+  it("fires onOpen on a single click of the open target", () => {
+    const onOpen = vi.fn();
+    renderRow({ onOpen });
+    fireEvent.click(screen.getByText("notes.md"));
+    expect(onOpen).toHaveBeenCalledTimes(1);
+  });
+
+  it("fires onActivate on a double-click when provided", () => {
+    const onActivate = vi.fn();
+    renderRow({ onActivate });
+    fireEvent.doubleClick(screen.getByText("notes.md"));
+    expect(onActivate).toHaveBeenCalledTimes(1);
+  });
+
+  it("binds no double-click handler when onActivate is omitted (harmless)", () => {
+    const onOpen = vi.fn();
+    renderRow({ onOpen });
+    // With no onActivate, a dblclick fires nothing (onOpen only responds to click).
+    fireEvent.doubleClick(screen.getByText("notes.md"));
+    expect(onOpen).not.toHaveBeenCalled();
+  });
+});
+
+describe("ArtifactRow — download", () => {
+  it("mints a download URL for the artifact's storage key on Download click", () => {
+    renderRow({ artifact: fileArtifact("notes.md") });
+    fireEvent.click(screen.getByLabelText("Download notes.md"));
+    expect(getArtifactDownloadUrl).toHaveBeenCalledTimes(1);
+    expect(getArtifactDownloadUrl.mock.calls[0][0]).toMatchObject({
+      executionId: "aex_1",
+      storageKey: "artifacts/aex_1/notes.md",
+    });
+  });
+
+  it("labels the Download control 'Download ZIP' for a directory", () => {
+    renderRow({ artifact: dirArtifact("return-policy") });
+    expect(screen.getByTitle("Download ZIP")).toBeTruthy();
+  });
+});

package/src/execution/__tests__/ArtifactsWidget.test.tsx

@@ -0,0 +1,78 @@
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { render, screen, fireEvent, cleanup } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import type { Stigmer } from "@stigmer/sdk";
+import { AgentExecutionSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/api_pb";
+import { ExecutionArtifactSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
+import {
+  ExecutionArtifactKind,
+  ExecutionPhase,
+} from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { StigmerContext } from "../../context";
+import { ArtifactsWidget } from "../ArtifactsWidget";
+
+function artifact(name: string) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.FILE,
+    sizeBytes: 1024n,
+    sandboxPath: `.stigmer/${name}`,
+    storageKey: `artifacts/aex_1/${name}`,
+  });
+}
+
+const execution = create(AgentExecutionSchema, {
+  metadata: { id: "aex_1" },
+  status: {
+    phase: ExecutionPhase.EXECUTION_COMPLETED,
+    artifacts: [artifact("agent.yaml"), artifact("notes.md")],
+  },
+});
+
+/** Modal content fetch — keep pending so nothing rejects during the test. */
+function createStigmerMock(): Stigmer {
+  return {
+    agentExecution: {
+      getArtifactContent: vi.fn().mockReturnValue(new Promise(() => {})),
+      getArtifactDownloadUrl: vi.fn().mockResolvedValue({ downloadUrl: "" }),
+    },
+  } as unknown as Stigmer;
+}
+
+function renderWidget(executions = [execution]) {
+  return render(
+    <StigmerContext.Provider value={createStigmerMock()}>
+      <ArtifactsWidget executions={executions} org="acme" />
+    </StigmerContext.Provider>,
+  );
+}
+
+afterEach(cleanup);
+
+describe("ArtifactsWidget — dense list (panel-less)", () => {
+  it("renders nothing when there are no artifacts", () => {
+    const { container } = renderWidget([]);
+    expect(container.firstChild).toBeNull();
+  });
+
+  it("renders a heading, count, and one dense row per artifact (no ArtifactCard chrome)", () => {
+    renderWidget();
+    expect(screen.getByRole("heading", { name: "Artifacts" })).toBeTruthy();
+    // Count badge reflects the two deduped artifacts.
+    expect(screen.getByText("2")).toBeTruthy();
+    expect(screen.getAllByRole("listitem")).toHaveLength(2);
+    expect(screen.getByText("agent.yaml")).toBeTruthy();
+    expect(screen.getByText("notes.md")).toBeTruthy();
+    // The retired ArtifactCard rendered a "Preview" button and role="article".
+    expect(screen.queryByText("Preview")).toBeNull();
+    expect(screen.queryByRole("article")).toBeNull();
+    expect(screen.getByLabelText("Download agent.yaml")).toBeTruthy();
+  });
+
+  it("opens the preview modal (the panel-less fallback) on a row click", () => {
+    renderWidget();
+    expect(document.querySelector("dialog")).toBeNull();
+    fireEvent.click(screen.getByText("notes.md"));
+    expect(document.querySelector("dialog")).toBeTruthy();
+  });
+});

package/src/execution/__tests__/FileChangeProgressBar.test.tsx

@@ -0,0 +1,125 @@
+/**
+ * FileChangeProgressBar — the live "N files changed so far" strip for a running
+ * turn (DD-32). These tests cover its own responsibilities: emptiness, the
+ * summary count + aggregate stat, the expandable per-file list with its cap
+ * overflow, zero-count hiding, and that only the count is an aria-live region.
+ */
+
+import { describe, it, expect, afterEach } from "vitest";
+import { render, screen, fireEvent, cleanup } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import {
+  FileChangeProgressSchema,
+  FileChangeProgressEntrySchema,
+  type FileChangeProgress,
+} from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/filereview_pb";
+import { FileChangeKind } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { FileChangeProgressBar } from "../FileChangeProgressBar";
+
+function entry(path: string, kind: FileChangeKind, added: number, removed: number) {
+  return create(FileChangeProgressEntrySchema, {
+    pathBefore: kind === FileChangeKind.ADD ? "" : path,
+    pathAfter: kind === FileChangeKind.DELETE ? "" : path,
+    kind,
+    linesAdded: added,
+    linesRemoved: removed,
+  });
+}
+
+function progress(overrides: Partial<FileChangeProgress> = {}): FileChangeProgress {
+  return create(FileChangeProgressSchema, {
+    changeSetId: "exec:0",
+    filesChanged: 2,
+    linesAdded: 7,
+    linesRemoved: 3,
+    entries: [
+      entry("src/a.ts", FileChangeKind.ADD, 5, 0),
+      entry("src/b.ts", FileChangeKind.MODIFY, 2, 3),
+    ],
+    capturedAt: "2026-07-05T00:00:00Z",
+    ...overrides,
+  });
+}
+
+afterEach(() => cleanup());
+
+describe("FileChangeProgressBar", () => {
+  it("renders nothing when progress is undefined", () => {
+    const { container } = render(<FileChangeProgressBar progress={undefined} />);
+    expect(container.firstChild).toBeNull();
+  });
+
+  it("renders nothing when zero files have changed (revert-to-clean)", () => {
+    const { container } = render(
+      <FileChangeProgressBar
+        progress={progress({ filesChanged: 0, entries: [], linesAdded: 0, linesRemoved: 0 })}
+      />,
+    );
+    expect(container.firstChild).toBeNull();
+  });
+
+  it("shows the summary count and aggregate +N −M", () => {
+    render(<FileChangeProgressBar progress={progress()} />);
+    expect(screen.getByText(/2 files changing/)).toBeTruthy();
+    expect(screen.getByText("+7")).toBeTruthy();
+    expect(screen.getByText("-3")).toBeTruthy();
+  });
+
+  it("uses the singular noun for a single file", () => {
+    render(
+      <FileChangeProgressBar
+        progress={progress({ filesChanged: 1, entries: [entry("only.ts", FileChangeKind.ADD, 1, 0)] })}
+      />,
+    );
+    expect(screen.getByText(/1 file changing/)).toBeTruthy();
+  });
+
+  it("puts only the count in an aria-live region, not the per-file list", () => {
+    render(<FileChangeProgressBar progress={progress()} />);
+    const live = screen.getByText(/2 files changing/);
+    expect(live.getAttribute("aria-live")).toBe("polite");
+    // The expandable list is not part of any live region.
+    fireEvent.click(screen.getByRole("button", { name: /2 files changing/ }));
+    const link = screen.getByText("a.ts");
+    expect(link.closest("[aria-live]")).toBeNull();
+  });
+
+  it("expands to a per-file list on click and collapses again", () => {
+    render(<FileChangeProgressBar progress={progress()} />);
+    expect(screen.queryByText("a.ts")).toBeNull();
+
+    const toggle = screen.getByRole("button", { name: /2 files changing/ });
+    fireEvent.click(toggle);
+    expect(screen.getByText("a.ts")).toBeTruthy();
+    expect(screen.getByText("b.ts")).toBeTruthy();
+    expect(toggle.getAttribute("aria-expanded")).toBe("true");
+
+    fireEvent.click(toggle);
+    expect(screen.queryByText("a.ts")).toBeNull();
+  });
+
+  it("shows an honest overflow line when the entry list is capped", () => {
+    // 5 files changed but only 2 entries carried → "… and 3 more".
+    render(<FileChangeProgressBar progress={progress({ filesChanged: 5 })} />);
+    fireEvent.click(screen.getByRole("button", { name: /5 files changing/ }));
+    expect(screen.getByText(/and 3 more/)).toBeTruthy();
+  });
+
+  it("hides the per-file stat when both counts are zero (binary/secret)", () => {
+    render(
+      <FileChangeProgressBar
+        progress={progress({
+          filesChanged: 1,
+          linesAdded: 0,
+          linesRemoved: 0,
+          entries: [entry(".env", FileChangeKind.MODIFY, 0, 0)],
+        })}
+      />,
+    );
+    fireEvent.click(screen.getByRole("button", { name: /1 file changing/ }));
+    // The secret path is present…
+    expect(screen.getByText(".env")).toBeTruthy();
+    // …but no +0 −0 stat is rendered anywhere.
+    expect(screen.queryByText("+0")).toBeNull();
+  });
+});

package/src/execution/__tests__/FileReviewCard.test.tsx

@@ -248,6 +248,16 @@ describe("FileReviewCard", () => {
   });
 
   describe("multi-file set (per-file controls)", () => {
+    it("starts a complete multi-file set collapsed in diff mode — auto-expansion is list-mode only", () => {
+      // Diff mode's expanded body is every full diff with NO height cap (the
+      // workflow file-review list); auto-expanding a multi-file set there
+      // would dump every diff open on mount. Only the compact list mode
+      // (showDiffs=false, the dock) starts multi-file sets expanded.
+      render(<FileReviewCard fileChangeSet={multiChangeSet()} onSubmit={noop} />);
+      expect(document.querySelector('[data-cursor-target="file-diff"]')).toBeNull();
+      expect(screen.getByRole("button", { name: "Review" })).toBeTruthy();
+    });
+
     it("renders a Keep/Discard radio per file plus whole-set controls", () => {
       render(<FileReviewCard fileChangeSet={multiChangeSet()} onSubmit={noop} />);
       expandCard();
@@ -848,11 +858,12 @@ describe("FileReviewCard", () => {
   // cases mirror the decision cases above without the diff DOM. The default
   // (showDiffs unset) stays covered by every other suite in this file.
   describe("list mode (showDiffs=false)", () => {
+    /** Open a still-collapsed card's file inventory (single complete file). */
     function expandFiles() {
       fireEvent.click(screen.getByRole("button", { name: "Files" }));
     }
 
-    it("labels the expander 'Files' and renders inert list rows with no diff DOM", () => {
+    it("starts a multi-file set expanded — the per-file controls are the honest decision surface", () => {
       render(
         <FileReviewCard
           fileChangeSet={multiChangeSet()}
@@ -860,17 +871,65 @@ describe("FileReviewCard", () => {
           showDiffs={false}
         />,
       );
-      expandFiles();
+      // No expander click: the list rows and per-file controls are immediately
+      // visible, with no diff DOM (the transcript's stamped rows own the diffs).
       expect(document.querySelector('[data-cursor-target="file-diff"]')).toBeNull();
       expect(
         document.querySelectorAll('[data-cursor-target="file-review-list-row"]'),
       ).toHaveLength(2);
-      // Filename-first path text, full path available on hover — and no
-      // link/copy affordance (the list is an inventory, not navigation).
+      expect(screen.getByRole("button", { name: "Hide" })).toBeTruthy();
+      // Filename-first linked path (FilePathLink: copy fallback without a
+      // provider — an accessible button, never a bare span), full path on hover.
       expect(screen.getByText("a.ts")).toBeTruthy();
       expect(screen.getByText("b.ts")).toBeTruthy();
+      expect(screen.getByRole("button", { name: /Copy path: src\/a\.ts/ })).toBeTruthy();
       expect(screen.getByTitle("src/a.ts")).toBeTruthy();
-      expect(screen.queryByRole("link")).toBeNull();
+    });
+
+    it("keeps a single complete file collapsed behind the 'Files' expander", () => {
+      render(
+        <FileReviewCard fileChangeSet={changeSet()} onSubmit={noop} showDiffs={false} />,
+      );
+      expect(
+        document.querySelector('[data-cursor-target="file-review-list-row"]'),
+      ).toBeNull();
+      fireEvent.click(screen.getByRole("button", { name: "Files" }));
+      expect(
+        document.querySelector('[data-cursor-target="file-review-list-row"]'),
+      ).toBeTruthy();
+    });
+
+    it("shows per-file +N −M from the capture-time counts, hiding the stat when no count exists", () => {
+      const counted = create(CapturedFileChangeSchema, {
+        id: "fc1",
+        pathBefore: "src/a.ts",
+        pathAfter: "src/a.ts",
+        kind: FileChangeKind.MODIFY,
+        captureClass: FileCaptureClass.GIT_TRACKED,
+        before: inline("old\n"),
+        after: inline("new\n"),
+        fileDigest: "d-fc1",
+        diffComplete: true,
+        linesAdded: 37,
+        linesRemoved: 2,
+      });
+      render(
+        <FileReviewCard
+          fileChangeSet={multiChangeSet({ fc1: counted })}
+          onSubmit={noop}
+          showDiffs={false}
+        />,
+      );
+      const rows = document.querySelectorAll('[data-cursor-target="file-review-list-row"]');
+      // fc1 carries counts; fc2 (legacy fixture, zero counts) shows no stat —
+      // never a misleading "+0 -0". The bar also aggregates the set's counts,
+      // so exactly two stats render: the bar's and fc1's row.
+      const stats = document.querySelectorAll('[data-cursor-target="file-review-line-stats"]');
+      expect(rows).toHaveLength(2);
+      expect(stats).toHaveLength(2);
+      expect(stats[0].textContent).toBe("+37 -2");
+      expect(stats[1].textContent).toBe("+37 -2");
+      expect(screen.getAllByLabelText("37 added, 2 removed")).toHaveLength(2);
     });
 
     it("marks each file with its change-kind letter (A/M/D)", () => {
@@ -899,7 +958,7 @@ describe("FileReviewCard", () => {
           showDiffs={false}
         />,
       );
-      expandFiles();
+      // A multi-file list-mode set starts expanded — the letters are visible.
       expect(screen.getByLabelText("added").textContent).toBe("A");
       expect(screen.getByLabelText("deleted").textContent).toBe("D");
     });
@@ -937,7 +996,7 @@ describe("FileReviewCard", () => {
           showDiffs={false}
         />,
       );
-      expandFiles();
+      // Starts expanded (multi-file list mode) — the row control is live.
       fireEvent.click(screen.getByRole("radio", { name: "Keep src/a.ts" }));
       expect(onSubmit).toHaveBeenCalledWith(FileDecisionAction.APPROVE, {
         scope: FileDecisionScope.FILE,

package/src/execution/__tests__/MessageThread.test.tsx

@@ -844,7 +844,7 @@ describe("MessageThread", () => {
       />,
     );
 
-    const buildBtn = screen.getByRole("button", { name: /build from plan/i });
+    const buildBtn = screen.getByRole("button", { name: "Build" });
     expect(buildBtn).toBeTruthy();
 
     fireEvent.click(buildBtn);

package/src/execution/__tests__/PlanArtifactCard.test.tsx

@@ -85,7 +85,7 @@ describe("PlanArtifactCard — compact document card", () => {
     expect(getArtifactContent).not.toHaveBeenCalled();
   });
 
-  it("offers exactly one primary 'Build from plan' action that calls onImplement", () => {
+  it("offers exactly one primary 'Build' action that calls onImplement", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -96,15 +96,15 @@ describe("PlanArtifactCard — compact document card", () => {
       />,
     );
 
-    fireEvent.click(screen.getByText("Build from plan"));
+    fireEvent.click(screen.getByRole("button", { name: "Build" }));
     expect(onImplement).toHaveBeenCalledTimes(1);
   });
 
-  it("hides 'Build from plan' when onImplement is not provided", () => {
+  it("hides 'Build' when onImplement is not provided", () => {
     renderCard(
       <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
     );
-    expect(screen.queryByText("Build from plan")).toBeNull();
+    expect(screen.queryByRole("button", { name: "Build" })).toBeNull();
   });
 
   it("shows the pending label while the approved plan uploads (buildPending)", () => {
@@ -121,12 +121,12 @@ describe("PlanArtifactCard — compact document card", () => {
 
     // The primary reads as in-progress and stays disabled — no double-submits
     // while the upload precedes the implement turn.
-    expect(screen.queryByText("Build from plan")).toBeNull();
+    expect(screen.queryByRole("button", { name: "Build" })).toBeNull();
     const button = screen.getByText("Starting build…").closest("button")!;
     expect(button.disabled).toBe(true);
   });
 
-  it("disables 'Build from plan' when disabled", () => {
+  it("disables 'Build' when disabled", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -138,12 +138,44 @@ describe("PlanArtifactCard — compact document card", () => {
       />,
     );
 
-    const button = screen.getByText("Build from plan").closest("button")!;
+    const button = screen.getByRole("button", { name: "Build" }) as HTMLButtonElement;
     expect(button.disabled).toBe(true);
     fireEvent.click(button);
     expect(onImplement).not.toHaveBeenCalled();
   });
 
+  it("copies the plan text to the clipboard on demand", async () => {
+    const writeText = vi.fn().mockResolvedValue(undefined);
+    vi.stubGlobal("navigator", { clipboard: { writeText } });
+    const getArtifactContent = vi
+      .fn()
+      .mockResolvedValue({ content: new TextEncoder().encode("# Plan\n\nsteps") });
+    const getArtifactDownloadUrl = vi.fn();
+    const stigmer = {
+      agentExecution: { getArtifactContent, getArtifactDownloadUrl },
+    } as unknown as Stigmer;
+
+    render(
+      withStigmer(
+        <PlanArtifactCard executionId="aex_1" artifact={planArtifact} org="acme" />,
+        stigmer,
+      ),
+    );
+
+    fireEvent.click(screen.getByRole("button", { name: "Copy plan" }));
+
+    // Content is fetched at click time from the stable storage key, then
+    // written to the clipboard — the card never pre-fetches on mount.
+    expect(getArtifactContent).toHaveBeenCalledTimes(1);
+    const req = getArtifactContent.mock.calls[0][0];
+    expect(req.executionId).toBe("aex_1");
+    expect(req.storageKey).toBe("artifacts/aex_1/plan.md");
+    await screen.findByRole("button", { name: "Copied" });
+    expect(writeText).toHaveBeenCalledWith("# Plan\n\nsteps");
+
+    vi.unstubAllGlobals();
+  });
+
   it("downloads the artifact on demand via a freshly minted URL", async () => {
     const { stigmer, getArtifactDownloadUrl } = createStigmerMock();
     render(
@@ -152,7 +184,7 @@ describe("PlanArtifactCard — compact document card", () => {
         stigmer,
       ),
     );
-    fireEvent.click(screen.getByText("Download"));
+    fireEvent.click(screen.getByRole("button", { name: "Download plan.md" }));
     // The URL is resolved at click time from the stable storage key — never a
     // baked, expirable URL.
     expect(getArtifactDownloadUrl).toHaveBeenCalledTimes(1);
@@ -229,8 +261,8 @@ describe("PlanArtifactCard — Cmd/Ctrl+Enter accelerator (card-scoped)", () =>
   });
 });
 
-describe("PlanArtifactCard — Open full (org-gated preview)", () => {
-  it("opens the shared preview modal when 'Open full' is clicked", () => {
+describe("PlanArtifactCard — Open plan modal fallback (org-gated preview)", () => {
+  it("opens the shared preview modal when the open icon is clicked (no onOpenPlan)", () => {
     const { stigmer } = createStigmerMock();
     render(
       withStigmer(
@@ -242,14 +274,14 @@ describe("PlanArtifactCard — Open full (org-gated preview)", () => {
     // No dialog before the user opens it.
     expect(document.querySelector("dialog")).toBeNull();
 
-    fireEvent.click(screen.getByText("Open full"));
+    fireEvent.click(screen.getByRole("button", { name: "Open plan" }));
 
     const dialog = document.querySelector("dialog");
     expect(dialog).toBeTruthy();
     expect(dialog!.getAttribute("aria-label")).toBe("Preview plan.md");
   });
 
-  it("hides 'Open full' when org is absent (modal needs org), keeping Build + Download", () => {
+  it("hides the open action when org is absent (modal needs org), keeping Build + Download", () => {
     const onImplement = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -258,14 +290,16 @@ describe("PlanArtifactCard — Open full (org-gated preview)", () => {
         onImplement={onImplement}
       />,
     );
-    expect(screen.queryByText("Open full")).toBeNull();
-    expect(screen.queryByText("Build from plan")).not.toBeNull();
-    expect(screen.queryByText("Download")).not.toBeNull();
+    expect(screen.queryByRole("button", { name: "Open plan" })).toBeNull();
+    expect(screen.queryByRole("button", { name: "Build" })).not.toBeNull();
+    expect(
+      screen.queryByRole("button", { name: "Download plan.md" }),
+    ).not.toBeNull();
   });
 });
 
 describe("PlanArtifactCard — Open plan (panel-first review)", () => {
-  it("replaces the modal secondary with 'Open plan' when onOpenPlan is provided", () => {
+  it("routes the open action to the panel when onOpenPlan is provided (no modal)", () => {
     const onOpenPlan = vi.fn();
     renderCard(
       <PlanArtifactCard
@@ -277,9 +311,9 @@ describe("PlanArtifactCard — Open plan (panel-first review)", () => {
     );
 
     // One review affordance, not two: the facet supersedes the modal.
-    expect(screen.queryByText("Open full")).toBeNull();
+    expect(screen.getAllByRole("button", { name: "Open plan" })).toHaveLength(1);
 
-    fireEvent.click(screen.getByText("Open plan"));
+    fireEvent.click(screen.getByRole("button", { name: "Open plan" }));
     expect(onOpenPlan).toHaveBeenCalledTimes(1);
     expect(document.querySelector("dialog")).toBeNull();
   });

package/src/execution/__tests__/PlanCompletionCard.test.tsx

@@ -3,7 +3,7 @@ import { render, fireEvent, cleanup } from "@testing-library/react";
 import { PlanCompletionCard } from "../PlanCompletionCard";
 
 describe("PlanCompletionCard", () => {
-  it("renders the card with status text and a 'Build from plan' button", () => {
+  it("renders the card with status text and a 'Build' button", () => {
     const { container } = render(<PlanCompletionCard onImplement={() => {}} />);
 
     const root = container.firstElementChild as HTMLElement;
@@ -13,7 +13,7 @@ describe("PlanCompletionCard", () => {
 
     const button = root.querySelector("button");
     expect(button).toBeTruthy();
-    expect(button!.textContent).toContain("Build from plan");
+    expect(button!.textContent).toContain("Build");
 
     expect(root.textContent).toContain("Plan complete");
     cleanup();