@stigmer/react 3.1.2 → 3.1.4

package/src/execution/PlanArtifactCard.tsx

@@ -1,10 +1,11 @@
 "use client";
 
-import { memo, useState } from "react";
+import { memo, useState, type ReactNode } from "react";
 import { cn } from "@stigmer/theme";
 import type { ExecutionArtifact } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
 import { ArtifactPreviewModal } from "./ArtifactPreviewModal.js";
 import { formatArtifactSize } from "./artifact-utils.js";
+import { useArtifactCopy } from "./useArtifactCopy.js";
 import { useArtifactDownload } from "./useArtifactDownload.js";
 import { useBuildFromPlanHotkey } from "./use-build-from-plan-hotkey.js";
 
@@ -21,20 +22,20 @@ export interface PlanArtifactCardProps {
    */
   readonly title?: string;
   /**
-   * Organization slug. Required for the "Open full" modal (the shared
+   * Organization slug. Required for the open-in-modal fallback (the shared
    * {@link ArtifactPreviewModal} uses it for its detection/apply pipeline and
-   * to fetch the content). When omitted, "Open full" is hidden — the prominent
-   * "Build from plan" action and "Download" remain.
+   * to fetch the content). When omitted, that fallback is hidden — the
+   * prominent "Build" action and the download icon remain.
    */
   readonly org?: string;
-  /** Called when the user clicks "Build from plan". Hidden when omitted. */
+  /** Called when the user clicks "Build". Hidden when omitted. */
   readonly onImplement?: () => void;
   /**
    * Opens the plan in the session panel's plan document tab — the
    * side-by-side review/refine surface. When provided it REPLACES the
-   * modal-based "Open full" secondary with "Open plan" (one review
-   * affordance, not two). When omitted (hosts without a session panel) the
-   * modal remains.
+   * modal-based open fallback (one review affordance, not two). When
+   * omitted (hosts without a session panel) the same "Open plan" icon
+   * opens the preview modal instead.
    */
   readonly onOpenPlan?: () => void;
   /** Disables the primary CTA (e.g., while an execution is active). */
@@ -52,9 +53,15 @@ export interface PlanArtifactCardProps {
  * the panel carries the document.
  *
  * Anatomy: a document-style identity block (plan icon, the plan's title, a
- * `plan.md · size` meta line) with the actions trailing — **Open plan** and
- * **Download** as subdued secondaries and one prominent, themeable primary,
- * **Build from plan** — so the next step is unmistakable.
+ * `<name> · size` meta line) with the actions trailing — open, copy, and
+ * download as icon-only secondaries (labelled via `aria-label`/`title`) and
+ * one prominent, themeable primary, **Build** — so the next step is
+ * unmistakable.
+ *
+ * Action-label rule (shared with `PlanStreamingCard`, which keeps its
+ * labelled "Open plan"): a lone secondary keeps its text label; a row of
+ * secondaries competing with a primary collapses to icons, so the primary
+ * carries the card's one visible verb.
  *
  * Only the LATEST plan's card carries `onImplement`; a superseded plan's card
  * is review-only (its `onOpenPlan` opens the document read-only), so a stale
@@ -76,6 +83,7 @@ export const PlanArtifactCard = memo(function PlanArtifactCard({
 }: PlanArtifactCardProps) {
   const [previewOpen, setPreviewOpen] = useState(false);
   const handleKeyDown = useBuildFromPlanHotkey(onImplement, disabled);
+  const { copy, isCopying, copied } = useArtifactCopy(executionId);
   const { download, isDownloading } = useArtifactDownload(executionId);
 
   return (
@@ -103,53 +111,41 @@ export const PlanArtifactCard = memo(function PlanArtifactCard({
         </div>
       </div>
 
-      <div className="ml-auto flex flex-wrap items-center gap-x-3 gap-y-1.5">
+      <div className="ml-auto flex flex-wrap items-center gap-x-1.5 gap-y-1.5">
         {onOpenPlan ? (
-          <button
-            type="button"
+          <IconAction
+            label="Open plan"
             onClick={onOpenPlan}
-            className={cn(
-              "inline-flex items-center gap-1 text-xs font-medium text-muted-foreground transition-colors hover:text-foreground",
-              FOCUS_RING,
-            )}
-          >
-            <ExpandIcon />
-            Open plan
-          </button>
+            icon={<EyeIcon />}
+          />
         ) : (
           org && (
-            <button
-              type="button"
+            <IconAction
+              label="Open plan"
               onClick={() => setPreviewOpen(true)}
-              className={cn(
-                "inline-flex items-center gap-1 text-xs font-medium text-muted-foreground transition-colors hover:text-foreground",
-                FOCUS_RING,
-              )}
-            >
-              <ExpandIcon />
-              Open full
-            </button>
+              icon={<EyeIcon />}
+            />
           )
         )}
-        <button
-          type="button"
+        <IconAction
+          label={copied ? "Copied" : isCopying ? "Copying…" : "Copy plan"}
+          onClick={() => copy(artifact.storageKey)}
+          disabled={isCopying}
+          icon={copied ? <CheckIcon /> : <CopyIcon />}
+        />
+        <IconAction
+          label={isDownloading ? "Preparing…" : `Download ${artifact.name}`}
           onClick={() => download(artifact.storageKey, artifact.name)}
           disabled={isDownloading}
-          className={cn(
-            "inline-flex items-center gap-1 text-xs font-medium text-muted-foreground transition-colors hover:text-foreground disabled:opacity-50",
-            FOCUS_RING,
-          )}
-        >
-          <DownloadIcon />
-          {isDownloading ? "Preparing…" : "Download"}
-        </button>
+          icon={<DownloadIcon />}
+        />
         {onImplement && (
           <button
             type="button"
             disabled={disabled}
             onClick={onImplement}
             className={cn(
-              "inline-flex items-center gap-1.5 rounded-md px-3 py-1.5",
+              "ml-1.5 inline-flex items-center gap-1.5 rounded-md px-3 py-1.5",
               "text-xs font-medium transition-colors",
               "bg-primary text-primary-foreground hover:bg-primary-hover",
               "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
@@ -157,13 +153,18 @@ export const PlanArtifactCard = memo(function PlanArtifactCard({
             )}
           >
             <ImplementIcon />
-            {buildPending ? "Starting build…" : "Build from plan"}
+            {buildPending ? "Starting build…" : "Build"}
           </button>
         )}
       </div>
 
-      {/* "Open full" reuses the shared artifact preview popup — the single place
-          that fetches/renders plan content (with Copy + Source/Rendered). */}
+      <div role="status" aria-live="polite" aria-atomic="true" className="sr-only">
+        {copied && "Plan copied to clipboard"}
+      </div>
+
+      {/* The modal open fallback reuses the shared artifact preview popup —
+          the single place that fetches/renders plan content (with Copy +
+          Source/Rendered). */}
       {org && previewOpen && (
         <ArtifactPreviewModal
           artifact={artifact}
@@ -182,6 +183,41 @@ export const PlanArtifactCard = memo(function PlanArtifactCard({
 const FOCUS_RING =
   "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:rounded-sm";
 
+/**
+ * An icon-only secondary action. The accessible name doubles as the hover
+ * tooltip (native `title` — the codebase's tooltip pattern), and the padded
+ * hit area keeps the target comfortable despite the compact glyph.
+ */
+function IconAction({
+  label,
+  onClick,
+  icon,
+  disabled,
+}: {
+  readonly label: string;
+  readonly onClick: () => void;
+  readonly icon: ReactNode;
+  readonly disabled?: boolean;
+}) {
+  return (
+    <button
+      type="button"
+      aria-label={label}
+      title={label}
+      onClick={onClick}
+      disabled={disabled}
+      className={cn(
+        "inline-flex items-center rounded-md p-1.5 text-muted-foreground",
+        "transition-colors hover:bg-muted hover:text-foreground",
+        "disabled:pointer-events-none disabled:opacity-50",
+        FOCUS_RING,
+      )}
+    >
+      {icon}
+    </button>
+  );
+}
+
 function PlanIcon() {
   return (
     <svg
@@ -223,8 +259,8 @@ function ImplementIcon() {
 function DownloadIcon() {
   return (
     <svg
-      width="10"
-      height="10"
+      width="13"
+      height="13"
       viewBox="0 0 12 12"
       fill="none"
       stroke="currentColor"
@@ -241,21 +277,63 @@ function DownloadIcon() {
   );
 }
 
-function ExpandIcon() {
+function CopyIcon() {
+  return (
+    <svg
+      width="13"
+      height="13"
+      viewBox="0 0 12 12"
+      fill="none"
+      stroke="currentColor"
+      strokeWidth="1.2"
+      strokeLinecap="round"
+      strokeLinejoin="round"
+      className="shrink-0"
+      aria-hidden="true"
+    >
+      <rect x="4" y="4" width="6.5" height="6.5" rx="1" />
+      <path d="M8 4V2.5C8 1.95 7.55 1.5 7 1.5H2.5C1.95 1.5 1.5 1.95 1.5 2.5V7C1.5 7.55 1.95 8 2.5 8H4" />
+    </svg>
+  );
+}
+
+/** A check glyph — transient confirmation that the copy succeeded. */
+function CheckIcon() {
   return (
     <svg
-      width="10"
-      height="10"
+      width="13"
+      height="13"
       viewBox="0 0 12 12"
       fill="none"
       stroke="currentColor"
       strokeWidth="1.5"
       strokeLinecap="round"
       strokeLinejoin="round"
+      className="shrink-0 text-success"
+      aria-hidden="true"
+    >
+      <path d="M2 6.5L4.5 9L10 3" />
+    </svg>
+  );
+}
+
+/** An eye glyph — "view/open the plan to read it". */
+function EyeIcon() {
+  return (
+    <svg
+      width="13"
+      height="13"
+      viewBox="0 0 16 16"
+      fill="none"
+      stroke="currentColor"
+      strokeWidth="1.5"
+      strokeLinecap="round"
+      strokeLinejoin="round"
       className="shrink-0"
       aria-hidden="true"
     >
-      <path d="M7 1.5h3.5V5M10.5 1.5L6.5 5.5M5 10.5H1.5V7M1.5 10.5l4-4" />
+      <path d="M1.5 8S4 3.5 8 3.5s6.5 4.5 6.5 4.5-2.5 4.5-6.5 4.5S1.5 8 1.5 8Z" />
+      <circle cx="8" cy="8" r="1.75" />
     </svg>
   );
 }

package/src/execution/PlanCompletionCard.tsx

@@ -6,7 +6,7 @@ import { useBuildFromPlanHotkey } from "./use-build-from-plan-hotkey.js";
 
 /** Props for {@link PlanCompletionCard}. */
 export interface PlanCompletionCardProps {
-  /** Called when the user clicks the "Build from plan" button. */
+  /** Called when the user clicks the "Build" button. */
   readonly onImplement?: () => void;
   /** Disables the CTA button (e.g., while an execution is active). */
   readonly disabled?: boolean;
@@ -20,9 +20,9 @@ export interface PlanCompletionCardProps {
  * a plan whose upload failed). When a plan artifact exists, the richer
  * `PlanArtifactCard` is shown instead.
  *
- * Mirrors `PlanArtifactCard`'s hierarchy — one prominent, themeable "Build from
- * plan" primary action with the same card-scoped `Cmd/Ctrl+Enter` accelerator —
- * so the two cards feel like the same affordance. The consumer wires the action
+ * Mirrors `PlanArtifactCard`'s hierarchy — one prominent, themeable "Build"
+ * primary action with the same card-scoped `Cmd/Ctrl+Enter` accelerator — so
+ * the two cards feel like the same affordance. The consumer wires the action
  * to switch the interaction mode to Agent and submit the implement turn.
  *
  * Renders nothing when `onImplement` is not provided, so the card is fully
@@ -67,7 +67,7 @@ export const PlanCompletionCard = memo(function PlanCompletionCard({
         )}
       >
         <ImplementIcon />
-        Build from plan
+        Build
       </button>
     </div>
   );

package/src/execution/PlanStreamingCard.tsx

@@ -2,7 +2,6 @@
 
 import { memo } from "react";
 import { cn } from "@stigmer/theme";
-import { PLAN_ARTIFACT_NAME } from "../library/detect-plan-artifact.js";
 import { formatArtifactSize } from "./artifact-utils.js";
 
 /** Props for {@link PlanStreamingCard}. */
@@ -34,8 +33,13 @@ export interface PlanStreamingCardProps {
  * The live counterpart of {@link PlanArtifactCard} — a streaming Plan turn's
  * compact stand-in in the thread while the plan document renders live in the
  * session panel's plan tab. Same anatomy as the completed card (icon, title,
- * `plan.md · size` meta, trailing actions) so the completion handoff reads as
- * the same card settling, not a new element appearing.
+ * a `Writing… · size` meta, trailing actions) so the completion handoff reads
+ * as the same card settling, not a new element appearing.
+ *
+ * The meta line deliberately omits a filename: the artifact's name is derived
+ * from the plan's title, which is still streaming in, so a name shown here
+ * would change under the user when the plan settles. The completed card
+ * introduces the final `<slug>_<id>.plan.md` name once it exists.
  *
  * Deliberately action-light: "Open plan" is the only affordance. Download and
  * Build require the published artifact, which does not exist until the turn
@@ -72,8 +76,6 @@ export const PlanStreamingCard = memo(function PlanStreamingCard({
           {title ?? "Writing plan…"}
         </div>
         <div className="text-[0.65rem] text-muted-foreground-faint">
-          {PLAN_ARTIFACT_NAME}
-          <span aria-hidden="true"> · </span>
           <span role="status">Writing…</span>
           <span aria-hidden="true"> · </span>
           <span className="tabular-nums">{formatArtifactSize(sizeBytes)}</span>
@@ -89,7 +91,7 @@ export const PlanStreamingCard = memo(function PlanStreamingCard({
             "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:rounded-sm",
           )}
         >
-          <ExpandIcon />
+          <EyeIcon />
           Open plan
         </button>
       )}
@@ -117,12 +119,13 @@ function PlanIcon({ className }: { readonly className?: string }) {
   );
 }
 
-function ExpandIcon() {
+/** An eye glyph — "view/open the plan to read it" (matches PlanArtifactCard). */
+function EyeIcon() {
   return (
     <svg
-      width="10"
-      height="10"
-      viewBox="0 0 12 12"
+      width="11"
+      height="11"
+      viewBox="0 0 16 16"
       fill="none"
       stroke="currentColor"
       strokeWidth="1.5"
@@ -131,7 +134,8 @@ function ExpandIcon() {
       className="shrink-0"
       aria-hidden="true"
     >
-      <path d="M7 1.5h3.5V5M10.5 1.5L6.5 5.5M5 10.5H1.5V7M1.5 10.5l4-4" />
+      <path d="M1.5 8S4 3.5 8 3.5s6.5 4.5 6.5 4.5-2.5 4.5-6.5 4.5S1.5 8 1.5 8Z" />
+      <circle cx="8" cy="8" r="1.75" />
     </svg>
   );
 }

package/src/execution/__tests__/ArtifactContentBody.test.tsx

@@ -0,0 +1,131 @@
+import { describe, it, expect, afterEach } from "vitest";
+import { render, screen, cleanup } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import { ExecutionArtifactSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
+import { ExecutionArtifactKind } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { ArtifactContentBody } from "../ArtifactContentBody";
+import type { SkillPackageDetection } from "../../library/detect-skill-package";
+
+const NOT_SKILL: SkillPackageDetection = { detected: false };
+
+function fileArtifact(name: string) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.FILE,
+    sizeBytes: 64n,
+  });
+}
+
+function dirArtifact(name: string, entries: string[]) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.DIRECTORY,
+    sizeBytes: 512n,
+    entries,
+  });
+}
+
+afterEach(cleanup);
+
+describe("ArtifactContentBody — file states", () => {
+  it("renders a loading skeleton", () => {
+    render(
+      <ArtifactContentBody
+        artifact={fileArtifact("notes.txt")}
+        content={null}
+        contentType={null}
+        isLoading
+        error={null}
+        isTruncated={false}
+        skillDetection={NOT_SKILL}
+      />,
+    );
+    expect(screen.getByLabelText("Loading content")).toBeTruthy();
+  });
+
+  it("renders an error message", () => {
+    render(
+      <ArtifactContentBody
+        artifact={fileArtifact("notes.txt")}
+        content={null}
+        contentType={null}
+        isLoading={false}
+        error={new Error("boom")}
+        isTruncated={false}
+        skillDetection={NOT_SKILL}
+      />,
+    );
+    expect(screen.getByText("boom")).toBeTruthy();
+  });
+
+  it("renders the binary / unavailable state when content is null and settled", () => {
+    render(
+      <ArtifactContentBody
+        artifact={fileArtifact("image.bin")}
+        content={null}
+        contentType={null}
+        isLoading={false}
+        error={null}
+        isTruncated={false}
+        skillDetection={NOT_SKILL}
+      />,
+    );
+    expect(screen.getByText(/Content not available for preview/)).toBeTruthy();
+  });
+
+  it("renders text content", () => {
+    render(
+      <ArtifactContentBody
+        artifact={fileArtifact("notes.txt")}
+        content={"hello from the artifact"}
+        contentType={"text/plain"}
+        isLoading={false}
+        error={null}
+        isTruncated={false}
+        skillDetection={NOT_SKILL}
+      />,
+    );
+    expect(screen.getByText(/hello from the artifact/)).toBeTruthy();
+  });
+});
+
+describe("ArtifactContentBody — directory state", () => {
+  it("lists directory entries", () => {
+    render(
+      <ArtifactContentBody
+        artifact={dirArtifact("pack", ["SKILL.md", "run.sh"])}
+        content={null}
+        contentType={null}
+        isLoading={false}
+        error={null}
+        isTruncated={false}
+        skillDetection={NOT_SKILL}
+      />,
+    );
+    expect(screen.getByText("Files (2)")).toBeTruthy();
+    expect(screen.getByText("SKILL.md")).toBeTruthy();
+    expect(screen.getByText("run.sh")).toBeTruthy();
+  });
+
+  it("shows the skill banner when a skill package is detected", () => {
+    const detection = {
+      detected: true,
+      skillName: "My Skill",
+      skillDescription: "does things",
+      fileCount: 2,
+    } as unknown as SkillPackageDetection;
+    render(
+      <ArtifactContentBody
+        artifact={dirArtifact("pack", ["SKILL.md"])}
+        content={null}
+        contentType={null}
+        isLoading={false}
+        error={null}
+        isTruncated={false}
+        skillDetection={detection}
+      />,
+    );
+    expect(screen.getByText("My Skill")).toBeTruthy();
+    expect(screen.getByText("does things")).toBeTruthy();
+  });
+});

package/src/execution/__tests__/ArtifactDocument.test.tsx

@@ -0,0 +1,100 @@
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { render, screen, cleanup, waitFor } from "@testing-library/react";
+import { create } from "@bufbuild/protobuf";
+import type { Stigmer } from "@stigmer/sdk";
+import { ExecutionArtifactSchema } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/artifact_pb";
+import { ExecutionArtifactKind } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import { StigmerContext } from "../../context";
+import { ArtifactDocument } from "../ArtifactDocument";
+
+function fileArtifact(name: string) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.FILE,
+    sizeBytes: 64n,
+    storageKey: `artifacts/aex_1/${name}`,
+    contentHash: "hash-1",
+  });
+}
+
+function dirArtifact(name: string) {
+  return create(ExecutionArtifactSchema, {
+    name,
+    kind: ExecutionArtifactKind.DIRECTORY,
+    sizeBytes: 512n,
+    storageKey: `artifacts/aex_1/${name}`,
+    entries: ["a.txt", "b.txt"],
+  });
+}
+
+function stigmerReturning(text: string): Stigmer {
+  return {
+    agentExecution: {
+      getArtifactContent: vi.fn().mockResolvedValue({
+        content: new TextEncoder().encode(text),
+        contentType: "text/plain",
+        truncated: false,
+      }),
+    },
+  } as unknown as Stigmer;
+}
+
+function renderDoc(stigmer: Stigmer, artifact = fileArtifact("notes.txt")) {
+  return render(
+    <StigmerContext.Provider value={stigmer}>
+      <ArtifactDocument
+        artifact={artifact}
+        executionId="aex_1"
+        org="acme"
+        isTerminal
+      />
+    </StigmerContext.Provider>,
+  );
+}
+
+const AGENT_YAML = [
+  "apiVersion: agentic.stigmer.ai/v1",
+  "kind: Agent",
+  "metadata:",
+  "  name: my-agent",
+  "spec: {}",
+  "",
+].join("\n");
+
+afterEach(cleanup);
+
+describe("ArtifactDocument", () => {
+  it("renders the toolbar (name + Download) and the fetched content", async () => {
+    renderDoc(stigmerReturning("hello document"));
+
+    expect(screen.getByRole("article", { name: "Artifact notes.txt" })).toBeTruthy();
+    expect(screen.getByText("notes.txt")).toBeTruthy();
+    expect(screen.getByText("Download")).toBeTruthy();
+    await waitFor(() => expect(screen.getByText(/hello document/)).toBeTruthy());
+    expect(screen.getByText("Copy")).toBeTruthy();
+  });
+
+  it("surfaces resource detection and an Apply CTA for a detected Agent", async () => {
+    renderDoc(stigmerReturning(AGENT_YAML), fileArtifact("agent.yaml"));
+
+    await waitFor(() => expect(screen.getByText("Agent detected")).toBeTruthy());
+    expect(screen.getByText("Apply to acme")).toBeTruthy();
+  });
+
+  it("renders a directory artifact with a Download ZIP action and no Copy", () => {
+    render(
+      <StigmerContext.Provider value={stigmerReturning("")}>
+        <ArtifactDocument
+          artifact={dirArtifact("pack")}
+          executionId="aex_1"
+          org="acme"
+          isTerminal
+        />
+      </StigmerContext.Provider>,
+    );
+
+    expect(screen.getByText("Download ZIP")).toBeTruthy();
+    expect(screen.queryByText("Copy")).toBeNull();
+    expect(screen.getByText("Files (2)")).toBeTruthy();
+  });
+});

package/src/execution/__tests__/ArtifactPreviewModal.test.tsx

@@ -26,8 +26,8 @@ function withStigmer(children: ReactNode) {
 
 afterEach(cleanup);
 
-describe("ArtifactPreviewContent — Build from plan action", () => {
-  it("renders a 'Build from plan' button only when onImplement is provided", () => {
+describe("ArtifactPreviewContent — Build action", () => {
+  it("renders a 'Build' button only when onImplement is provided", () => {
     const { rerender } = render(
       withStigmer(
         <ArtifactPreviewContent
@@ -39,7 +39,7 @@ describe("ArtifactPreviewContent — Build from plan action", () => {
         />,
       ),
     );
-    expect(screen.queryByText("Build from plan")).toBeNull();
+    expect(screen.queryByText("Build")).toBeNull();
 
     rerender(
       withStigmer(
@@ -53,10 +53,10 @@ describe("ArtifactPreviewContent — Build from plan action", () => {
         />,
       ),
     );
-    expect(screen.getByText("Build from plan")).toBeTruthy();
+    expect(screen.getByText("Build")).toBeTruthy();
   });
 
-  it("calls onImplement then closes the modal when 'Build from plan' is clicked", () => {
+  it("calls onImplement then closes the modal when 'Build' is clicked", () => {
     const calls: string[] = [];
     const onImplement = vi.fn(() => calls.push("implement"));
     const onClose = vi.fn(() => calls.push("close"));
@@ -74,7 +74,7 @@ describe("ArtifactPreviewContent — Build from plan action", () => {
       ),
     );
 
-    fireEvent.click(screen.getByText("Build from plan"));
+    fireEvent.click(screen.getByText("Build"));
 
     expect(onImplement).toHaveBeenCalledTimes(1);
     expect(onClose).toHaveBeenCalledTimes(1);