@stigmer/react 3.1.17 → 3.2.1

package/src/workspace/WorkspaceSurface.tsx

@@ -28,8 +28,11 @@ import { FileViewer, type FileViewerHandle } from "./FileViewer.js";
 import { EditorTabs, editorTabDomId } from "./EditorTabs.js";
 import { ExplorerTree } from "./ExplorerTree.js";
 
-/** The built-in rail views every surface has. */
-const BUILT_IN_VIEWS = ["files", "search"] as const;
+/** The surface's built-in rail views (offered by default, opt-out per host). */
+const ALL_BUILT_IN_VIEWS = ["files", "search"] as const;
+
+/** Identifier of a built-in rail view. */
+export type BuiltInViewId = (typeof ALL_BUILT_IN_VIEWS)[number];
 
 /**
  * A host-injected rail view: an icon in the activity rail whose content
@@ -52,6 +55,16 @@ export interface SurfaceRailView {
   readonly badge?: number;
   /** Sidebar content rendered while this view is active. */
   readonly content: ReactNode;
+  /**
+   * The content OWNS its chrome: render it in a bare full-height slot with
+   * no sidebar header and no padded scroll wrapper. For self-managing views
+   * — a header + fixed tab strip + internally-scrolling body (the workflow
+   * Inspect facet) — where the default envelope would double the header and
+   * nest scroll containers. Flat, single-scroll facets (Config, Changes,
+   * Artifacts, Usage) omit it and keep the shared envelope.
+   * @default false
+   */
+  readonly fitted?: boolean;
 }
 
 /**
@@ -104,6 +117,15 @@ export interface WorkspaceSurfaceProps {
   readonly view?: string;
   /** Called when the user picks a rail view. */
   readonly onViewChange?: (viewId: string) => void;
+  /**
+   * Which built-in rail views the surface offers, in rail order. Defaults to
+   * all of them; hosts without a workspace file source pass `[]` so the rail
+   * carries only their injected `extraViews` — an honest facet-only surface
+   * instead of inert Explorer/Search icons (DD-011: opt-in behavior change,
+   * backward-compatible default). The workflow execution panel does this
+   * until a workspace-source slice wires a lister.
+   */
+  readonly builtInViews?: readonly BuiltInViewId[];
   /**
    * Host-injected rail views, rendered after the built-in Explorer/Search.
    * Their `content` renders in the sidebar pane; the editor area stays for
@@ -186,6 +208,7 @@ export function WorkspaceSurface({
   searcher,
   view,
   onViewChange,
+  builtInViews = ALL_BUILT_IN_VIEWS,
   extraViews,
   virtualDocuments,
   onRemoveEntry,
@@ -215,11 +238,13 @@ export function WorkspaceSurface({
   );
 
   // A stale id (e.g. a contextual extra view that disappeared) degrades to the
-  // explorer rather than an empty sidebar.
+  // first OFFERED view rather than an empty sidebar — hardcoding "files" would
+  // strand a builtInViews={[]} host on a view its rail doesn't render.
   const isKnownView =
-    (BUILT_IN_VIEWS as readonly string[]).includes(requestedView) ||
+    (builtInViews as readonly string[]).includes(requestedView) ||
     (extraViews?.some((v) => v.id === requestedView) ?? false);
-  const activeView = isKnownView ? requestedView : "files";
+  const fallbackView = builtInViews[0] ?? extraViews?.[0]?.id ?? "files";
+  const activeView = isKnownView ? requestedView : fallbackView;
   const activeExtraView = extraViews?.find((v) => v.id === activeView);
 
   return (
@@ -227,6 +252,7 @@ export function WorkspaceSurface({
       <ActivityRail
         view={activeView}
         onViewChange={handleViewChange}
+        builtInViews={builtInViews}
         extraViews={extraViews}
       />
       <ResizableSplit
@@ -297,15 +323,22 @@ interface RailItem {
 function ActivityRail({
   view,
   onViewChange,
+  builtInViews,
   extraViews,
 }: {
   readonly view: string;
   readonly onViewChange: (next: string) => void;
+  readonly builtInViews: readonly BuiltInViewId[];
   readonly extraViews: readonly SurfaceRailView[] | undefined;
 }) {
-  const items: readonly RailItem[] = [
+  const builtInItems: readonly RailItem[] = [
     { id: "files", label: "Explorer", icon: <FilesIcon /> },
     { id: "search", label: "Search", icon: <SearchIcon /> },
+  ];
+  const items: readonly RailItem[] = [
+    ...builtInItems.filter((item) =>
+      (builtInViews as readonly string[]).includes(item.id),
+    ),
     ...(extraViews ?? []),
   ];
 
@@ -573,6 +606,17 @@ function SearchModeToggle({
 // ---------------------------------------------------------------------------
 
 function ExtraViewSidebar({ view }: { readonly view: SurfaceRailView }) {
+  if (view.fitted) {
+    // A fitted view owns its chrome (header, tab strip, scroll) — hand it a
+    // bare full-height slot. A shared header or scroll wrapper here would
+    // double the header and nest scroll containers around a component that
+    // already manages both.
+    return (
+      <div className="flex h-full min-h-0 flex-col border-r border-border">
+        {view.content}
+      </div>
+    );
+  }
   return (
     <div className="flex h-full min-h-0 flex-col border-r border-border">
       <SidebarHeader title={view.label} />

package/src/workspace/__tests__/WorkspaceSurface.test.tsx

@@ -229,6 +229,38 @@ describe("WorkspaceSurface extraViews", () => {
     expect(screen.getByRole("tab", { name: /main\.go/ })).toBeTruthy();
   });
 
+  it("hands a fitted view a bare slot — no sidebar heading, no padded scroll wrapper", () => {
+    // A fitted view (the workflow Inspect facet) owns its header, tab strip,
+    // and scroll; the shared envelope would double the header and nest
+    // scroll containers.
+    const fittedView = {
+      id: "inspect",
+      label: "Inspect",
+      icon: <span />,
+      fitted: true,
+      content: <div data-testid="fitted-probe" />,
+    };
+    renderSurface({ extraViews: [fittedView] });
+    fireEvent.click(screen.getByRole("radio", { name: "Inspect" }));
+
+    const probe = screen.getByTestId("fitted-probe");
+    // No SidebarHeader (the rail button carries the label as a title
+    // attribute, not text — so any "Inspect" text would be the heading).
+    expect(screen.queryByText("Inspect")).toBeNull();
+    // The content's wrapper is the bare sidebar column, not the padded
+    // scroll envelope the default path applies.
+    expect(probe.parentElement!.className).not.toContain("overflow-y-auto");
+    expect(probe.parentElement!.className).not.toContain("px-3");
+  });
+
+  it("keeps the shared envelope (heading + padded scroll) for unfitted views", () => {
+    renderSurface({ extraViews: [configView] });
+    fireEvent.click(screen.getByRole("radio", { name: "Config" }));
+    const probe = screen.getByTestId("config-probe");
+    expect(probe.parentElement!.className).toContain("overflow-y-auto");
+    expect(screen.getByText("Config")).toBeTruthy();
+  });
+
   it("supports controlled view selection via view/onViewChange", () => {
     const onViewChange = vi.fn();
     renderSurface({
@@ -314,6 +346,47 @@ describe("WorkspaceSurface extraViews", () => {
   });
 });
 
+// ---------------------------------------------------------------------------
+// builtInViews opt-in (DD-011) — hosts without a workspace file source scope
+// the rail to their injected facets (the workflow execution panel today).
+// ---------------------------------------------------------------------------
+
+describe("WorkspaceSurface builtInViews", () => {
+  it("offers Explorer and Search by default (backward-compatible)", () => {
+    renderSurface();
+    expect(screen.getByRole("radio", { name: "Explorer" })).toBeTruthy();
+    expect(screen.getByRole("radio", { name: "Search" })).toBeTruthy();
+  });
+
+  it("renders a facet-only rail with builtInViews={[]}", () => {
+    renderSurface({ builtInViews: [], extraViews: [configView] });
+    expect(screen.queryByRole("radio", { name: "Explorer" })).toBeNull();
+    expect(screen.queryByRole("radio", { name: "Search" })).toBeNull();
+    expect(screen.getByRole("radio", { name: "Config" })).toBeTruthy();
+  });
+
+  it("falls back to the first injected view — never a hidden built-in — for a stale view id", () => {
+    // A hardcoded "files" fallback would strand a facet-only host on a view
+    // its rail doesn't render (blank sidebar).
+    renderSurface({
+      builtInViews: [],
+      extraViews: [configView],
+      view: "inspect",
+    });
+    expect(screen.getByTestId("config-probe")).toBeTruthy();
+    expect(
+      screen.getByRole("radio", { name: "Config" }).getAttribute("aria-checked"),
+    ).toBe("true");
+    expect(screen.queryByTestId("explorer-probe")).toBeNull();
+  });
+
+  it("can offer a subset of built-ins", () => {
+    renderSurface({ builtInViews: ["files"] });
+    expect(screen.getByRole("radio", { name: "Explorer" })).toBeTruthy();
+    expect(screen.queryByRole("radio", { name: "Search" })).toBeNull();
+  });
+});
+
 // ---------------------------------------------------------------------------
 // Host-injected virtual documents — editor tabs that are not workspace files
 // (the session's plan.md today). Same open/pin/close semantics as file tabs;
@@ -397,6 +470,43 @@ describe("WorkspaceSurface virtualDocuments", () => {
     expect(body.className).toContain("overflow-x-hidden");
     expect(body.className).toContain("min-w-0");
   });
+
+  it("mounts ONLY the active virtual document — inactive tabs stay unmounted", () => {
+    // Load-bearing for streaming documents (the workflow's agent-execution
+    // transcripts): an inactive tab's content must not exist in the tree at
+    // all, so its fetch/stream hooks never run (DD-LIVE-006 — only the
+    // visible surface streams). A hidden-but-mounted body would keep every
+    // open transcript's subscription alive.
+    const mounts: string[] = [];
+    function Probe({ id }: { readonly id: string }) {
+      mounts.push(id);
+      return <div data-testid={`doc-${id}`} />;
+    }
+    const TRANSCRIPT_ENTRY_ID = virtualEntryId("agentexec");
+    renderSurface({
+      virtualDocuments: [
+        {
+          entryId: TRANSCRIPT_ENTRY_ID,
+          path: "aex_1/first-call",
+          content: <Probe id="first" />,
+        },
+        {
+          entryId: TRANSCRIPT_ENTRY_ID,
+          path: "aex_2/second-call",
+          content: <Probe id="second" />,
+        },
+      ],
+      editors: [
+        { entryId: TRANSCRIPT_ENTRY_ID, path: "aex_1/first-call", preview: false },
+        { entryId: TRANSCRIPT_ENTRY_ID, path: "aex_2/second-call", preview: false },
+      ],
+      selectedFile: { entryId: TRANSCRIPT_ENTRY_ID, path: "aex_2/second-call" },
+    });
+
+    expect(screen.getByTestId("doc-second")).toBeTruthy();
+    expect(screen.queryByTestId("doc-first")).toBeNull();
+    expect(mounts).not.toContain("first");
+  });
 });
 
 // ---------------------------------------------------------------------------

package/src/workspace/index.ts

@@ -51,11 +51,14 @@ export type { WorkspaceContentSearchProps } from "./WorkspaceContentSearch.js";
 // The highlight helper (findHighlightRanges) stays @internal, like matchWorkspaceFiles.
 export { FileViewer } from "./FileViewer.js";
 export type { FileViewerProps, FileViewerHandle } from "./FileViewer.js";
+export { PanelChip } from "./PanelChip.js";
+export type { PanelChipProps } from "./PanelChip.js";
 export { WorkspaceSurface } from "./WorkspaceSurface.js";
 export type {
   WorkspaceSurfaceProps,
   SurfaceRailView,
   SurfaceVirtualDocument,
+  BuiltInViewId,
 } from "./WorkspaceSurface.js";
 // Virtual-document identity helpers: hosts mint collision-proof entry ids for
 // SurfaceVirtualDocument tabs and detect them in file-only code paths.