@stigmer/react 3.1.17 → 3.2.1

package/src/workflow/WorkflowExecutionViewer.tsx

@@ -3,27 +3,95 @@
 import { memo, useCallback, useEffect, useMemo, useRef, useState, type ReactNode } from "react";
 import { cn } from "@stigmer/theme";
 import { WorkflowTaskStatus, ExecutionPhase } from "@stigmer/protos/ai/stigmer/agentic/workflowexecution/v1/enum_pb";
+import type { WorkflowTask } from "@stigmer/protos/ai/stigmer/agentic/workflowexecution/v1/api_pb";
 import { WorkflowTaskKind } from "@stigmer/protos/ai/stigmer/agentic/workflow/v1/enum_pb";
 import { useWorkflowExecution } from "./useWorkflowExecution.js";
 import { useWorkflowExecutionEventStream } from "./useWorkflowExecutionEventStream.js";
 import { useWorkflowExecutionArtifacts } from "./useWorkflowExecutionArtifacts.js";
+import {
+  useWorkflowExecutionFileChanges,
+  type UseWorkflowExecutionFileChangesReturn,
+} from "./useWorkflowExecutionFileChanges.js";
 import { useWorkflowExecutionActions } from "./useWorkflowExecutionActions.js";
 import { WorkflowExecutionHeader } from "./WorkflowExecutionHeader.js";
-import { WorkflowExecutionTimeline, type WorkflowExecutionTimelineProps } from "./WorkflowExecutionTimeline.js";
-import { WaterfallTimeline } from "./waterfall/index.js";
-import { WorkflowExecutionCostPanel } from "./WorkflowExecutionCostPanel.js";
-import { WorkflowExecutionArtifactPanel } from "./WorkflowExecutionArtifactPanel.js";
 import { WorkflowRepairCard } from "./WorkflowRepairCard.js";
 import { WorkflowExecutionGraph } from "./WorkflowExecutionGraph.js";
-import type { DerivedTaskState } from "../internal/store/workflow-execution-event-store.js";
-import { ExecutionInspector } from "./execution-inspector/index.js";
+import type { DerivedCostSummary, DerivedTaskState } from "../internal/store/workflow-execution-event-store.js";
 import { ExecutionComparisonPicker } from "./execution-comparison/ExecutionComparisonPicker.js";
 import { ExecutionComparisonView } from "./execution-comparison/ExecutionComparisonView.js";
-import { WorkflowExecutionApprovalCard } from "./WorkflowExecutionApprovalCard.js";
-import { WorkflowFileReviewList, type WorkflowFileDecisionSubmit } from "./WorkflowFileReviewList.js";
-import type { WorkflowPendingApproval, WorkflowPendingFileReview } from "@stigmer/protos/ai/stigmer/agentic/workflowexecution/v1/api_pb";
-import type { ApprovalAction } from "@stigmer/protos/ai/stigmer/agentic/agentexecution/v1/enum_pb";
+import type { Artifact } from "@stigmer/protos/ai/stigmer/agentic/artifact/v1/api_pb";
 import { ResizableSplit } from "../internal/ResizableSplit.js";
+import { useWorkspaceEditors } from "../internal/store/index.js";
+import { ARTIFACT_DOCUMENT_ENTRY_ID } from "../execution/artifact-document.js";
+import {
+  FILE_CHANGE_DOCUMENT_ENTRY_ID,
+  fileChangeTabPath,
+} from "../execution/file-change-document.js";
+import {
+  AGENT_EXECUTION_DOCUMENT_ENTRY_ID,
+  parseAgentExecutionTabPath,
+} from "../execution/agent-execution-document.js";
+import { FileChangeDiff } from "../execution/FileChangesView.js";
+import {
+  WorkflowAgentExecutionDocument,
+  type WorkflowAgentExecutionHitl,
+} from "./WorkflowAgentExecutionDocument.js";
+import {
+  WorkspaceSurface,
+  type SurfaceVirtualDocument,
+} from "../workspace/WorkspaceSurface.js";
+import { PanelChip } from "../workspace/PanelChip.js";
+import {
+  useWorkflowExecutionPanel,
+  workflowArtifactTabPath,
+  type WorkflowExecutionPanelController,
+} from "./useWorkflowExecutionPanel.js";
+import { useWorkflowExecutionRailViews } from "./useWorkflowExecutionRailViews.js";
+import {
+  DIAGNOSIS_DOCUMENT_ENTRY_ID,
+  DIAGNOSIS_DOCUMENT_PATH,
+} from "./diagnosis-document.js";
+import { WorkflowArtifactDocument } from "./WorkflowArtifactDocument.js";
+import {
+  WorkflowTaskThread,
+  type WorkflowThreadHitl,
+} from "./thread/WorkflowTaskThread.js";
+import { useExecutionAnnouncements } from "./useExecutionAnnouncements.js";
+import {
+  useApprovalBoundary,
+  type ApprovalBoundaryCrossing,
+} from "./useApprovalBoundary.js";
+
+// ---------------------------------------------------------------------------
+// Center-column view (S9: Thread | Graph toggle; Thread is the default)
+// ---------------------------------------------------------------------------
+
+/** The center-column view of the execution viewer. */
+type CenterView = "thread" | "graph";
+
+// Versioned key (S9). The unversioned S8 key is deliberately ABANDONED, not
+// migrated: S8 shipped the thread as an opt-in preview with Graph as the
+// default, so a stored S8 value records exploration of that preview — not a
+// deliberate preference against the thread-primary product direction. The
+// version bump gives every user one fresh landing on the new default;
+// choices made from there persist.
+const CENTER_VIEW_STORAGE_KEY = "stgm-wf-exec-center-view.v2";
+const LEGACY_CENTER_VIEW_STORAGE_KEY = "stgm-wf-exec-center-view";
+
+/**
+ * Read the persisted center view, defaulting to the thread (the T02
+ * thread-primary pivot). Same lazy-`useState` + `localStorage` pattern as
+ * `ResizableSplit`'s persisted width.
+ */
+function readStoredCenterView(): CenterView {
+  try {
+    const stored = localStorage.getItem(CENTER_VIEW_STORAGE_KEY);
+    if (stored === "thread" || stored === "graph") return stored;
+  } catch {
+    /* localStorage may be unavailable */
+  }
+  return "thread";
+}
 
 /** Props for {@link WorkflowExecutionViewer}. */
 export interface WorkflowExecutionViewerProps {
@@ -43,8 +111,6 @@ export interface WorkflowExecutionViewerProps {
    * application handles navigation to the workflow editor (DD-004).
    */
   readonly onNavigateToWorkflowEditor?: (yaml: string, workflowSlug: string) => void;
-  /** Additional action elements to render in the sidebar inspector footer. */
-  readonly additionalActions?: ReactNode;
   /**
    * Host-supplied action elements rendered in the header action group
    * (e.g. a Share control). Routing/auth-agnostic per DD-004.
@@ -64,9 +130,14 @@ export interface WorkflowExecutionViewerProps {
 /**
  * Top-level composed viewer for a single workflow execution.
  *
- * Wires together all execution hooks and sub-components into a
- * two-region layout: an event timeline (main area) and a context
- * sidebar (tasks, budget, artifacts).
+ * Wires together all execution hooks and sub-components into a two-column
+ * layout: the center column (the session-style task thread by default, with
+ * the DAG graph behind a view toggle — a passive visualization) and a single
+ * collapsible `WorkspaceSurface` panel carrying the execution-level facets
+ * (Artifacts/Changes/Usage on the rail) and the rich documents (transcripts,
+ * diffs, artifacts, AI diagnosis in the editor area). A task's detail —
+ * preview, I/O, errors, and every HITL decision surface — lives on its
+ * thread card, the single home for task data (T06).
  *
  * This component is designed to work identically whether rendered
  * in the Stigmer Console or embedded in a third-party dashboard.
@@ -85,7 +156,6 @@ export const WorkflowExecutionViewer = memo(function WorkflowExecutionViewer({
   org,
   onNavigateToAgentExecution,
   onNavigateToWorkflowEditor,
-  additionalActions,
   headerActions,
   nodesDraggable,
   className,
@@ -165,6 +235,14 @@ export const WorkflowExecutionViewer = memo(function WorkflowExecutionViewer({
         currentToolName: "",
         messagesCount: 0,
         toolCallsCount: 0,
+        // No event log → no truncated summaries and no gate record. The
+        // card body still renders full I/O from this same snapshot
+        // (`status.tasks[]`), so the fallback path is never a blank card
+        // (T04); a decided human_input degrades to its raw output there.
+        inputSummary: null,
+        outputSummary: null,
+        approvalRequest: null,
+        approvalResolution: null,
       });
     }
     return map;
@@ -173,37 +251,160 @@ export const WorkflowExecutionViewer = memo(function WorkflowExecutionViewer({
   const effectiveTaskStates = fallbackTaskStates ?? taskStates;
   const effectiveTotalTasks = fallbackTaskStates ? fallbackTaskStates.size : totalTasks;
 
-  const executionDurationMs = useMemo(() => {
-    const startedAt = execution?.status?.startedAt;
-    const completedAt = execution?.status?.completedAt;
-    if (startedAt && completedAt) {
-      return new Date(completedAt).getTime() - new Date(startedAt).getTime();
+  // Per-task snapshot lookup for the thread cards' I/O bodies (T04): an
+  // O(1) map, rebuilt only when the snapshot refetches — never on stream
+  // event appends — so memoized cards keep bailing during streaming.
+  const taskSnapshotsByName = useMemo(():
+    | ReadonlyMap<string, WorkflowTask>
+    | undefined => {
+    const tasks = execution?.status?.tasks;
+    if (!tasks || tasks.length === 0) return undefined;
+    const map = new Map<string, WorkflowTask>();
+    for (const t of tasks) {
+      if (t.taskName) map.set(t.taskName, t);
     }
-    return undefined;
-  }, [execution?.status?.startedAt, execution?.status?.completedAt]);
+    return map;
+  }, [execution?.status?.tasks]);
 
-  const {
-    artifacts,
-    isLoading: isLoadingArtifacts,
-  } = useWorkflowExecutionArtifacts(executionId);
+  const { artifacts } = useWorkflowExecutionArtifacts(executionId);
+
+  // File-change rollup across AGENT_CALL children (Changes facet). Owner-level
+  // like the artifacts hook — the fetched children must survive panel
+  // collapse/expand cycles (the panel's content unmounts while collapsed).
+  const fileChangesState = useWorkflowExecutionFileChanges({
+    executionId,
+    taskStates: effectiveTaskStates,
+    taskSnapshots: execution?.status?.tasks,
+  });
 
   const actions = useWorkflowExecutionActions(executionId, {
     onSuccess: refetchExecution,
   });
 
-  const [selectedTaskName, setSelectedTaskName] = useState<string | null>(null);
-  const [showDiagnosis, setShowDiagnosis] = useState(false);
+  // The child-gate HITL wiring — ONE bundle from the single actions
+  // instance, narrowed to the six child-gate fields, consumed by the
+  // in-place transcript documents (S5, as `WorkflowAgentExecutionHitl`), so
+  // a gate's spinner/error is pixel-identical on every surface. Deps are
+  // the individual fields (DD-010): the bundle's ref must survive unrelated
+  // churn on `actions` (a lifecycle action's isSubmitting flip), so
+  // consumers re-render only when a gate's own in-flight/error state moves.
+  const childGateHitl = useMemo<WorkflowAgentExecutionHitl>(
+    () => ({
+      submitApproval: actions.submitApproval,
+      approvalSubmittingToolCallIds: actions.approvalSubmittingToolCallIds,
+      approvalErrorsByToolCallId: actions.approvalErrorsByToolCallId,
+      submitFileDecision: actions.submitFileDecision,
+      fileDecisionSubmittingKeys: actions.fileDecisionSubmittingKeys,
+      fileDecisionErrorsByKey: actions.fileDecisionErrorsByKey,
+    }),
+    [
+      actions.submitApproval,
+      actions.approvalSubmittingToolCallIds,
+      actions.approvalErrorsByToolCallId,
+      actions.submitFileDecision,
+      actions.fileDecisionSubmittingKeys,
+      actions.fileDecisionErrorsByKey,
+    ],
+  );
+
+  // The thread's HITL bundle (T06): the child-gate fields PLUS the
+  // task-level (human_input) approval wiring — since the gating card is
+  // the only decision surface, the thread carries all three gate kinds.
+  // A separate memo from `childGateHitl` so a human_input decision's
+  // in-flight flip re-renders the gating card, never the open transcript
+  // documents (DD-010).
+  const threadHitl = useMemo<WorkflowThreadHitl>(
+    () => ({
+      ...childGateHitl,
+      submitTaskApproval: actions.submitTaskApproval,
+      taskApprovalSubmittingTaskNames: actions.taskApprovalSubmittingTaskNames,
+      taskApprovalErrorsByTaskName: actions.taskApprovalErrorsByTaskName,
+    }),
+    [
+      childGateHitl,
+      actions.submitTaskApproval,
+      actions.taskApprovalSubmittingTaskNames,
+      actions.taskApprovalErrorsByTaskName,
+    ],
+  );
+
+  // The execution-level workspace panel (facets + virtual document
+  // tabs). The controller lives at the owner level — the editors-store
+  // SUBSCRIPTION stays inside ExecutionWorkspacePanel so tab churn re-renders
+  // only the panel subtree, never the streaming graph (DD-009/DD-010).
+  const panel = useWorkflowExecutionPanel();
+
   const [showComparePicker, setShowComparePicker] = useState(false);
   const [compareTargetId, setCompareTargetId] = useState<string | null>(null);
 
-  const handleDiagnose = useCallback(() => {
-    setShowDiagnosis(true);
+  // Center-column view (S8/S9). Both views stay mounted with the inactive
+  // one CSS-hidden — the `collapsedPane` discipline — so toggling never
+  // remounts React Flow or drops the event stream (DD-009).
+  const [centerView, setCenterView] = useState<CenterView>(readStoredCenterView);
+  const handleCenterViewChange = useCallback((view: CenterView) => {
+    setCenterView(view);
+    try {
+      localStorage.setItem(CENTER_VIEW_STORAGE_KEY, view);
+    } catch {
+      /* quota or security error */
+    }
   }, []);
 
-  const handleCloseDiagnosis = useCallback(() => {
-    setShowDiagnosis(false);
+  // One-time cleanup of the abandoned S8 key (an effect, not the read path —
+  // reads must stay side-effect-free).
+  useEffect(() => {
+    try {
+      localStorage.removeItem(LEGACY_CENTER_VIEW_STORAGE_KEY);
+    } catch {
+      /* localStorage may be unavailable */
+    }
   }, []);
 
+  // Screen reader announcements for task state changes. Owned by the viewer
+  // (not the graph): `display:none` removes content from the accessibility
+  // tree, so a live region inside the CSS-hidden graph would go silent in
+  // Thread view. One always-visible announcer serves both center views.
+  const announcement = useExecutionAnnouncements(effectiveTaskStates);
+
+  // Terminal-phase snapshot refetch (T04, DD-T04-4). While a run streams,
+  // the cards' collapsed lines and bodies work from the TRUNCATED event
+  // summaries; the full per-task output lands on `status.tasks[]` only when
+  // the runner persists the terminal snapshot. The stream store's stage is
+  // the live end-of-run signal (`"complete"` on the terminal event) — the
+  // snapshot's own `phase` cannot be the trigger, since it only moves on a
+  // refetch (the circularity behind the stale "Pending" header, R1-5).
+  // Scoped to the live→complete TRANSITION: a terminal-replay mount starts
+  // at "complete" without ever streaming and already fetched a settled
+  // snapshot, so it must not refetch again.
+  const prevStreamStageRef = useRef(streamState.stage);
+  useEffect(() => {
+    const prev = prevStreamStageRef.current;
+    prevStreamStageRef.current = streamState.stage;
+    if (
+      streamState.stage === "complete" &&
+      (prev === "streaming" || prev === "reconnecting")
+    ) {
+      refetchExecution();
+    }
+  }, [streamState.stage, refetchExecution]);
+
+  // Snapshot freshness across HITL boundaries (S9, the drawer's
+  // replacement). A `waiting_approval` boundary crossing — in EITHER
+  // direction — means the mount snapshot's gate lists are stale → refetch
+  // (stale-while-revalidate; no skeleton): the thread's in-card gates read
+  // those lists. No auto-select accompanies it (T06 — selection is gone):
+  // the gating card is amber, carries its decision surface, and the aria
+  // announcer + auto-follow + jump-to-latest cover attention. Gated on
+  // `isRunning` so terminal-execution history replay (which crosses the
+  // boundary for long-decided gates) never refetches.
+  const handleApprovalBoundary = useCallback(
+    (_crossing: ApprovalBoundaryCrossing) => {
+      refetchExecution();
+    },
+    [refetchExecution],
+  );
+  useApprovalBoundary(effectiveTaskStates, isRunning, handleApprovalBoundary);
+
   const handleOpenComparePicker = useCallback(() => {
     setShowComparePicker(true);
   }, []);
@@ -272,10 +473,26 @@ export const WorkflowExecutionViewer = memo(function WorkflowExecutionViewer({
         streamState={streamState}
         costSummary={costSummary}
         actions={actions}
-        onDiagnose={org ? handleDiagnose : undefined}
-        isDiagnosing={showDiagnosis}
+        // Diagnose opens (or focuses) the singleton diagnosis document tab —
+        // the tab itself is the "diagnosis is active" state, so there is no
+        // owner-level isDiagnosing boolean to keep in sync (SSOT).
+        onDiagnose={org ? panel.openDiagnosis : undefined}
         onCompare={handleOpenComparePicker}
-        headerActions={headerActions}
+        headerActions={
+          <>
+            {headerActions}
+            {/* The panel's always-mounted toggle — always-on now that the
+                Usage facet gives the panel data-independent content (its
+                empty state is honest even before any usage accrues). The
+                badge stays the artifact count: artifacts are countable
+                collateral, usage is a continuous quantity. */}
+            <PanelChip
+              isOpen={panel.isOpen}
+              onToggle={panel.isOpen ? panel.closePanel : panel.openPanel}
+              badgeCount={artifacts.length}
+            />
+          </>
+        }
       />
 
       {/* Comparison picker dialog */}
@@ -329,102 +546,340 @@ export const WorkflowExecutionViewer = memo(function WorkflowExecutionViewer({
         </div>
       )}
 
-      <div className="flex min-h-0 flex-1 flex-col">
-        {/* Primary area: Execution graph + resizable inspector */}
-        <ResizableSplit
-          defaultSize={showDiagnosis ? 440 : 384}
-          minSize={280}
-          maxSize={800}
-          storageKey="stgm-wf-exec-inspector-width"
-          primary={
-            <WorkflowExecutionGraph
+      {/* Outer split: the graph-dominant content vs. the execution workspace
+          panel. Toggling goes through `collapsedPane` (CSS, not conditional
+          structure) so both children keep stable tree positions and an
+          open/close never remounts the React Flow graph or reconnects the
+          event stream (DD-009) — the same invariant the session viewer's
+          panel split holds for its conversation. */}
+      <ResizableSplit
+        resizablePane="secondary"
+        collapsedPane={panel.isOpen ? "none" : "secondary"}
+        defaultSize={560}
+        minSize={360}
+        maxSize={960}
+        storageKey="stgm-wf-exec-panel-width"
+        ariaLabel="Resize execution panel"
+        className="min-h-0 flex-1"
+        primary={
+      <div className="flex h-full min-h-0 flex-1 flex-col">
+        {/* Center-column view switcher (S8). Graph is the default; the
+            thread is the session-style card-per-task view (T02 pivot). */}
+        <CenterViewSwitcher view={centerView} onChange={handleCenterViewChange} />
+
+        {/* One always-visible live region for task state changes — see the
+            ownership note on `announcement` above. */}
+        <div role="log" aria-live="polite" aria-atomic="false" className="sr-only">
+          {announcement}
+        </div>
+
+        {/* Primary area: thread and graph, both mounted, inactive one
+            CSS-hidden (stable tree positions — no React Flow remount, no
+            stream reconnect, expanded cards survive a toggle). The thread
+            card is the single home for a task's detail (T06); the graph is
+            a passive topology visualization. */}
+        <div
+          data-center-view="thread"
+          className={cn("min-h-0 flex-1", centerView !== "thread" && "hidden")}
+        >
+          <WorkflowTaskThread
+            taskStates={effectiveTaskStates}
+            totalTasks={effectiveTotalTasks}
+            isRunning={isRunning}
+            onOpenAgentExecution={panel.openAgentExecution}
+            // In-card HITL (S10/T06): all three gate kinds decide on the
+            // gating card, backed by the snapshot gate lists (kept fresh
+            // by the approval boundary's refetch above).
+            hitl={threadHitl}
+            pendingApprovals={execution?.status?.pendingApprovals}
+            pendingFileReviews={execution?.status?.pendingFileReviews}
+            // Full per-task I/O for the card bodies (T04) — an O(1)
+            // per-card snapshot lookup.
+            taskSnapshotsByName={taskSnapshotsByName}
+            className="h-full"
+          />
+        </div>
+        <div
+          data-center-view="graph"
+          className={cn("min-h-0 flex-1", centerView !== "graph" && "hidden")}
+        >
+          <WorkflowExecutionGraph
+            executionId={executionId}
+            execution={execution}
+            taskStates={effectiveTaskStates}
+            // Gated on the graph being visible: camera moves against a
+            // display:none (zero-size) viewport are degenerate.
+            followExecution={isRunning && centerView === "graph"}
+            // The viewer owns the one always-visible announcer above; the
+            // graph's own would go silent while CSS-hidden in Thread view.
+            announceTaskStates={false}
+            nodesDraggable={nodesDraggable}
+            className="h-full"
+          />
+        </div>
+      </div>
+        }
+        secondary={
+          // Content unmounts while collapsed (matching the session panel
+          // region); the editors store lives on the controller, so open tabs
+          // survive a collapse/expand cycle.
+          panel.isOpen ? (
+            <ExecutionWorkspacePanel
+              panel={panel}
               executionId={executionId}
-              execution={execution}
+              org={org}
+              artifacts={artifacts}
+              fileChangesState={fileChangesState}
+              costSummary={costSummary}
               taskStates={effectiveTaskStates}
-              onTaskSelect={setSelectedTaskName}
-              onAutoSelectTask={setSelectedTaskName}
-              followExecution={isRunning}
-              nodesDraggable={nodesDraggable}
-              className="h-full"
+              onNavigateToAgentExecution={onNavigateToAgentExecution}
+              onApplyFix={onNavigateToWorkflowEditor ? handleApplyFix : undefined}
+              transcriptHitl={childGateHitl}
             />
-          }
-          secondary={
-            <aside className="flex h-full flex-col overflow-hidden">
-              {showDiagnosis && org ? (
+          ) : null
+        }
+      />
+      </>
+      )}
+    </div>
+  );
+});
+
+// ---------------------------------------------------------------------------
+// Execution workspace panel — WorkspaceSurface + facets (Artifacts/Changes/Usage)
+// ---------------------------------------------------------------------------
+
+/**
+ * The workflow analog of the session viewer's panel region: subscribes to the
+ * open-editor group (keeping that subscription out of the streaming owner),
+ * assembles the rail facets, and resolves open virtual-document tabs back to
+ * their records (artifact tabs → `Artifact`, file-change tabs → the current
+ * net `FileChange`, transcript tabs → their child id, the diagnosis tab →
+ * `WorkflowRepairCard`).
+ */
+function ExecutionWorkspacePanel({
+  panel,
+  executionId,
+  org,
+  artifacts,
+  fileChangesState,
+  costSummary,
+  taskStates,
+  onNavigateToAgentExecution,
+  onApplyFix,
+  transcriptHitl,
+}: {
+  readonly panel: WorkflowExecutionPanelController;
+  readonly executionId: string;
+  readonly org?: string;
+  readonly artifacts: readonly Artifact[];
+  readonly fileChangesState: UseWorkflowExecutionFileChangesReturn;
+  readonly costSummary: DerivedCostSummary;
+  readonly taskStates: ReadonlyMap<string, DerivedTaskState>;
+  readonly onNavigateToAgentExecution?: (agentExecutionId: string) => void;
+  /** "Apply Fix" from the diagnosis document — host-routed (DD-004). */
+  readonly onApplyFix?: (yaml: string) => void;
+  /** Workflow-level HITL wiring for open transcript documents (S5). */
+  readonly transcriptHitl: WorkflowAgentExecutionHitl;
+}) {
+  const { editors, activeFile } = useWorkspaceEditors(panel.editorsStore);
+
+  // The Changes list highlights the row of the open diff tab — only a
+  // file-change document's path counts (an artifact tab must not highlight a
+  // coincidentally-named change).
+  const activeFileChangePath =
+    activeFile?.entryId === FILE_CHANGE_DOCUMENT_ENTRY_ID
+      ? activeFile.path
+      : null;
+
+  const railViews = useWorkflowExecutionRailViews({
+    artifacts,
+    onOpenArtifact: panel.openArtifact,
+    onActivateArtifact: panel.pinArtifact,
+    fileChanges: fileChangesState.fileChanges,
+    fileChangesLoading: fileChangesState.isLoading,
+    fileChangesRefetching: fileChangesState.isRefetching,
+    fileChangesError: fileChangesState.error,
+    activeFileChangePath,
+    onOpenFileChange: panel.openFileChange,
+    costSummary,
+    taskStates,
+  });
+
+  // Resolve open artifact tabs to their records by the same tab-path identity
+  // used to open them (single source of truth). A tab whose artifact vanished
+  // (e.g. expired and dropped from a refetch) degrades to an honest notice
+  // rather than vanishing.
+  const artifactByTabPath = useMemo(
+    () => new Map(artifacts.map((a) => [workflowArtifactTabPath(a), a])),
+    [artifacts],
+  );
+  // File-change tabs resolve the same way: tab path → net FileChange. The
+  // rollup is re-derived at task boundaries, so an open tab always renders
+  // the CURRENT net diff for its path (never a stale copy captured at open
+  // time); a path that dropped out of the rollup degrades to a notice.
+  const fileChangeByTabPath = useMemo(
+    () =>
+      new Map(
+        fileChangesState.fileChanges.map((c) => [fileChangeTabPath(c), c]),
+      ),
+    [fileChangesState.fileChanges],
+  );
+  const virtualDocuments = useMemo<readonly SurfaceVirtualDocument[]>(
+    () =>
+      editors
+        .filter(
+          (editor) =>
+            editor.entryId === ARTIFACT_DOCUMENT_ENTRY_ID ||
+            editor.entryId === FILE_CHANGE_DOCUMENT_ENTRY_ID ||
+            editor.entryId === AGENT_EXECUTION_DOCUMENT_ENTRY_ID ||
+            editor.entryId === DIAGNOSIS_DOCUMENT_ENTRY_ID,
+        )
+        .map((editor) => {
+          if (editor.entryId === DIAGNOSIS_DOCUMENT_ENTRY_ID) {
+            // The singleton AI-diagnosis conversation (opened by the header's
+            // Diagnose button via `panel.openDiagnosis`). Keyed by the fixed
+            // path so the streaming diagnosis flow survives unrelated editor
+            // churn; its close button closes the tab — the tab IS the
+            // "diagnosis is active" state.
+            return {
+              entryId: DIAGNOSIS_DOCUMENT_ENTRY_ID,
+              path: editor.path,
+              content: (
                 <WorkflowRepairCard
+                  key={editor.path}
                   executionId={executionId}
-                  org={org}
-                  onApplyFix={onNavigateToWorkflowEditor ? handleApplyFix : undefined}
-                  onClose={handleCloseDiagnosis}
-                  className="h-full"
+                  org={org ?? ""}
+                  onApplyFix={onApplyFix}
+                  onClose={() =>
+                    panel.closeEditor(
+                      DIAGNOSIS_DOCUMENT_ENTRY_ID,
+                      DIAGNOSIS_DOCUMENT_PATH,
+                    )
+                  }
                 />
-              ) : (
-                <div className="flex min-h-0 flex-1 flex-col overflow-hidden">
-                  <ExecutionInspector
-                    selectedTaskName={selectedTaskName}
-                    events={events}
-                    taskStates={effectiveTaskStates}
-                    taskSnapshots={execution?.status?.tasks ?? undefined}
-                    onNavigateToAgentExecution={onNavigateToAgentExecution}
-                    pendingApprovals={execution?.status?.pendingApprovals}
-                    onSubmitApproval={actions.submitApproval}
-                    approvalSubmittingToolCallIds={actions.approvalSubmittingToolCallIds}
-                    approvalErrorsByToolCallId={actions.approvalErrorsByToolCallId}
-                    onSubmitTaskApproval={actions.submitTaskApproval}
-                    taskApprovalSubmittingTaskNames={actions.taskApprovalSubmittingTaskNames}
-                    taskApprovalErrorsByTaskName={actions.taskApprovalErrorsByTaskName}
-                    className="min-h-0 flex-1"
-                  />
-
-                  <div className="border-t border-[var(--stgm-border,#e5e5e5)]">
-                    <WorkflowExecutionCostPanel costSummary={costSummary} />
-                  </div>
-
-                  {artifacts.length > 0 && (
-                    <div className="border-t border-[var(--stgm-border,#e5e5e5)]">
-                      <WorkflowExecutionArtifactPanel artifacts={artifacts} />
-                    </div>
-                  )}
-
-                  {additionalActions && (
-                    <div className="border-t border-[var(--stgm-border,#e5e5e5)] px-3 py-2">
-                      {additionalActions}
-                    </div>
-                  )}
+              ),
+            };
+          }
+          if (editor.entryId === AGENT_EXECUTION_DOCUMENT_ENTRY_ID) {
+            // The tab path CARRIES the child id (no lookup map — unlike the
+            // artifact/change families, a transcript needs only its id to
+            // fetch/stream itself). The suffix is the AGENT_CALL task name;
+            // its live state provides the agent slug for the header.
+            const childExecutionId = parseAgentExecutionTabPath(editor.path);
+            const taskName = editor.path.slice(childExecutionId.length + 1);
+            return {
+              entryId: AGENT_EXECUTION_DOCUMENT_ENTRY_ID,
+              path: editor.path,
+              // Keyed by tab path so the mounted fetch/stream survives
+              // unrelated editors churn while this tab stays active.
+              content: (
+                <WorkflowAgentExecutionDocument
+                  key={editor.path}
+                  childExecutionId={childExecutionId}
+                  taskName={taskName}
+                  agentSlug={taskStates.get(taskName)?.agentSlug || undefined}
+                  onNavigateToAgentExecution={onNavigateToAgentExecution}
+                  hitl={transcriptHitl}
+                />
+              ),
+            };
+          }
+          if (editor.entryId === FILE_CHANGE_DOCUMENT_ENTRY_ID) {
+            const change = fileChangeByTabPath.get(editor.path);
+            return {
+              entryId: FILE_CHANGE_DOCUMENT_ENTRY_ID,
+              path: editor.path,
+              content: change ? (
+                <div className="mx-auto w-full max-w-5xl px-4 py-4">
+                  <FileChangeDiff key={editor.path} change={change} />
                 </div>
-              )}
-            </aside>
+              ) : (
+                <FileChangeUnavailableNotice />
+              ),
+            };
           }
-        />
-
-        {/* Bottom panel: Waterfall (default) + Event Log tabs */}
-        <ExecutionBottomPanel
-          events={events}
-          streamState={streamState}
-          executionStartIso={execution.status?.startedAt ?? ""}
-          executionDurationMs={executionDurationMs}
-          selectedTaskName={selectedTaskName}
-          onTaskSelect={setSelectedTaskName}
-          onNavigateToAgentExecution={onNavigateToAgentExecution}
-          taskStates={effectiveTaskStates}
-          onSubmitTaskApproval={actions.submitTaskApproval}
-          taskApprovalSubmittingTaskNames={actions.taskApprovalSubmittingTaskNames}
-          taskApprovalErrorsByTaskName={actions.taskApprovalErrorsByTaskName}
-          pendingApprovals={execution?.status?.pendingApprovals}
-          onSubmitApproval={actions.submitApproval}
-          approvalSubmittingToolCallIds={actions.approvalSubmittingToolCallIds}
-          approvalErrorsByToolCallId={actions.approvalErrorsByToolCallId}
-          pendingFileReviews={execution?.status?.pendingFileReviews}
-          onSubmitFileDecision={actions.submitFileDecision}
-          fileDecisionSubmittingKeys={actions.fileDecisionSubmittingKeys}
-          fileDecisionErrorsByKey={actions.fileDecisionErrorsByKey}
-        />
-      </div>
-      </>
-      )}
+          const artifact = artifactByTabPath.get(editor.path);
+          return {
+            entryId: ARTIFACT_DOCUMENT_ENTRY_ID,
+            path: editor.path,
+            content: artifact ? (
+              <WorkflowArtifactDocument key={editor.path} artifact={artifact} />
+            ) : (
+              <ArtifactUnavailableNotice />
+            ),
+          };
+        }),
+    [
+      editors,
+      artifactByTabPath,
+      fileChangeByTabPath,
+      taskStates,
+      onNavigateToAgentExecution,
+      transcriptHitl,
+      executionId,
+      org,
+      onApplyFix,
+      panel.closeEditor,
+    ],
+  );
+
+  return (
+    <WorkspaceSurface
+      entries={[]}
+      lister={undefined}
+      reader={undefined}
+      // Facet-only rail until a workspace-source slice wires a lister —
+      // inert Explorer/Search icons would be dishonest chrome here.
+      builtInViews={[]}
+      view={panel.view}
+      onViewChange={panel.setView}
+      extraViews={railViews}
+      virtualDocuments={virtualDocuments}
+      editors={editors}
+      selectedFile={activeFile}
+      onOpenFile={panel.openFile}
+      onActivateEditor={panel.activateEditor}
+      onPinEditor={panel.pinEditor}
+      onCloseEditor={panel.closeEditor}
+      onCollapse={panel.closePanel}
+      className="h-full"
+    />
+  );
+}
+
+function FileChangeUnavailableNotice() {
+  return (
+    <div
+      role="status"
+      className="mx-auto flex w-full max-w-3xl flex-col items-center gap-1 px-4 py-8 text-center"
+    >
+      <p className="text-xs font-medium text-foreground">
+        This file change is no longer available.
+      </p>
+      <p className="text-xs text-muted-foreground">
+        The rollup was refreshed and this file no longer appears among the
+        execution&apos;s changes.
+      </p>
     </div>
   );
-});
+}
+
+function ArtifactUnavailableNotice() {
+  return (
+    <div
+      role="status"
+      className="mx-auto flex w-full max-w-3xl flex-col items-center gap-1 px-4 py-8 text-center"
+    >
+      <p className="text-xs font-medium text-foreground">
+        This artifact is no longer available.
+      </p>
+      <p className="text-xs text-muted-foreground">
+        It may have expired or been removed from storage.
+      </p>
+    </div>
+  );
+}
 
 function LoadingSkeleton() {
   return (
@@ -446,178 +901,43 @@ function LoadingSkeleton() {
 
 
 // ---------------------------------------------------------------------------
-// Tabbed bottom panel: Waterfall + Event Log + Approvals
+// Center-column view switcher (S9: Thread | Graph — thread-primary order)
 // ---------------------------------------------------------------------------
 
-type BottomTab = "waterfall" | "events" | "approvals";
-
-function ExecutionBottomPanel({
-  events,
-  streamState,
-  executionStartIso,
-  executionDurationMs,
-  selectedTaskName,
-  onTaskSelect,
-  onNavigateToAgentExecution,
-  taskStates,
-  onSubmitTaskApproval,
-  taskApprovalSubmittingTaskNames,
-  taskApprovalErrorsByTaskName,
-  pendingApprovals,
-  onSubmitApproval,
-  approvalSubmittingToolCallIds,
-  approvalErrorsByToolCallId,
-  pendingFileReviews,
-  onSubmitFileDecision,
-  fileDecisionSubmittingKeys,
-  fileDecisionErrorsByKey,
+/**
+ * Slim segmented control above the center column. A radiogroup (the two
+ * views are mutually exclusive), matching the facet rail's radio semantics.
+ * Thread leads: it is the primary view (T02 pivot); the DAG is the
+ * secondary, topology-oriented lens.
+ */
+function CenterViewSwitcher({
+  view,
+  onChange,
 }: {
-  events: WorkflowExecutionTimelineProps["events"];
-  streamState: WorkflowExecutionTimelineProps["streamState"];
-  executionStartIso: string;
-  executionDurationMs?: number;
-  selectedTaskName: string | null;
-  onTaskSelect: (taskName: string) => void;
-  onNavigateToAgentExecution?: (id: string) => void;
-  taskStates: ReadonlyMap<string, DerivedTaskState>;
-  onSubmitTaskApproval: WorkflowExecutionTimelineProps["onSubmitTaskApproval"];
-  taskApprovalSubmittingTaskNames: ReadonlySet<string>;
-  taskApprovalErrorsByTaskName: ReadonlyMap<string, Error>;
-  pendingApprovals?: readonly WorkflowPendingApproval[];
-  onSubmitApproval?: (toolCallId: string, action: ApprovalAction, comment?: string) => Promise<unknown>;
-  approvalSubmittingToolCallIds: ReadonlySet<string>;
-  approvalErrorsByToolCallId: ReadonlyMap<string, Error>;
-  pendingFileReviews?: readonly WorkflowPendingFileReview[];
-  onSubmitFileDecision: WorkflowFileDecisionSubmit;
-  fileDecisionSubmittingKeys: ReadonlySet<string>;
-  fileDecisionErrorsByKey: ReadonlyMap<string, Error>;
+  readonly view: CenterView;
+  readonly onChange: (view: CenterView) => void;
 }) {
-  const [collapsed, setCollapsed] = useState(false);
-  const [activeTab, setActiveTab] = useState<BottomTab>("waterfall");
-  const prevHitlCountRef = useRef(0);
-
-  const approvalCount = pendingApprovals?.length ?? 0;
-  const fileReviewCount = pendingFileReviews?.length ?? 0;
-  // Both HITL kinds (tool approvals + file reviews) share the one "Approvals" tab.
-  const hitlCount = approvalCount + fileReviewCount;
-  const hasHitl = hitlCount > 0;
-
-  // Auto-switch to the Approvals tab when a new HITL gate (approval or file
-  // review) arrives; leave it when everything is resolved.
-  useEffect(() => {
-    if (hitlCount > prevHitlCountRef.current && hitlCount > 0) {
-      setActiveTab("approvals");
-      setCollapsed(false);
-    }
-    if (hitlCount === 0 && activeTab === "approvals") {
-      setActiveTab("waterfall");
-    }
-    prevHitlCountRef.current = hitlCount;
-  }, [hitlCount, activeTab]);
-
   return (
-    <div className="border-t border-[var(--stgm-border,#e5e5e5)]">
-      {/* Tab bar */}
-      <div className="flex items-center gap-0 border-b border-[var(--stgm-border,#e5e5e5)]">
-        <button
-          type="button"
-          onClick={() => setCollapsed(!collapsed)}
-          className="flex items-center gap-1.5 px-3 py-1.5 text-xs text-[var(--stgm-muted-foreground,#737373)] hover:bg-[var(--stgm-muted,#f5f5f5)]"
-          aria-label={collapsed ? "Expand bottom panel" : "Collapse bottom panel"}
-        >
-          <svg
-            width="10"
-            height="10"
-            viewBox="0 0 10 10"
-            className={cn("transition-transform", !collapsed && "rotate-180")}
-            aria-hidden="true"
-          >
-            <path d="M2 4L5 7L8 4" fill="none" stroke="currentColor" strokeWidth="1.5" strokeLinecap="round" strokeLinejoin="round" />
-          </svg>
-        </button>
-
-        <TabButton
-          label="Waterfall"
-          isActive={activeTab === "waterfall"}
-          onClick={() => { setActiveTab("waterfall"); setCollapsed(false); }}
-        />
-        <TabButton
-          label={`Events (${events.length})`}
-          isActive={activeTab === "events"}
-          onClick={() => { setActiveTab("events"); setCollapsed(false); }}
-        />
-        {hasHitl && (
-          <TabButton
-            label={`Approvals (${hitlCount})`}
-            isActive={activeTab === "approvals"}
-            onClick={() => { setActiveTab("approvals"); setCollapsed(false); }}
-          />
-        )}
-      </div>
-
-      {/* Panel content */}
-      {!collapsed && (
-        <div className="h-52">
-          {activeTab === "waterfall" && (
-            <WaterfallTimeline
-              events={events}
-              streamState={streamState}
-              executionStartIso={executionStartIso}
-              executionDurationMs={executionDurationMs}
-              selectedTaskName={selectedTaskName}
-              onTaskSelect={onTaskSelect}
-              className="h-full"
-            />
-          )}
-          {activeTab === "events" && (
-            <WorkflowExecutionTimeline
-              events={events}
-              streamState={streamState}
-              onNavigateToAgentExecution={onNavigateToAgentExecution}
-              taskStates={taskStates}
-              onSubmitTaskApproval={onSubmitTaskApproval}
-              taskApprovalSubmittingTaskNames={taskApprovalSubmittingTaskNames}
-              taskApprovalErrorsByTaskName={taskApprovalErrorsByTaskName}
-              className="h-full"
-            />
-          )}
-          {activeTab === "approvals" && (
-            <div className="h-full overflow-y-auto px-4 py-3">
-              <div className="space-y-3">
-                {pendingApprovals && onSubmitApproval && pendingApprovals.map((pa) => {
-                  const toolCallId = pa.approval?.toolCallId ?? "";
-                  return (
-                    <WorkflowExecutionApprovalCard
-                      key={toolCallId || pa.childAgentExecutionId}
-                      prompt={pa.approval?.message || `Tool "${pa.approval?.toolName}" requires approval`}
-                      toolCallId={toolCallId}
-                      approvers={[]}
-                      timeoutSeconds={0}
-                      onSubmitApproval={onSubmitApproval}
-                      isSubmitting={approvalSubmittingToolCallIds.has(toolCallId)}
-                      error={approvalErrorsByToolCallId.get(toolCallId) ?? null}
-                    />
-                  );
-                })}
-                {pendingFileReviews && pendingFileReviews.length > 0 && (
-                  <WorkflowFileReviewList
-                    pendingFileReviews={pendingFileReviews}
-                    onSubmitFileDecision={onSubmitFileDecision}
-                    submittingDecisionKeys={fileDecisionSubmittingKeys}
-                    decisionErrors={fileDecisionErrorsByKey}
-                    onNavigateToAgentExecution={onNavigateToAgentExecution}
-                  />
-                )}
-              </div>
-            </div>
-          )}
-        </div>
-      )}
+    <div
+      role="radiogroup"
+      aria-label="Center view"
+      className="flex items-center gap-0.5 border-b border-[var(--stgm-border,#e5e5e5)] px-2 py-1"
+    >
+      <CenterViewButton
+        label="Thread"
+        isActive={view === "thread"}
+        onClick={() => onChange("thread")}
+      />
+      <CenterViewButton
+        label="Graph"
+        isActive={view === "graph"}
+        onClick={() => onChange("graph")}
+      />
     </div>
   );
 }
 
-function TabButton({
+function CenterViewButton({
   label,
   isActive,
   onClick,
@@ -629,11 +949,13 @@ function TabButton({
   return (
     <button
       type="button"
+      role="radio"
+      aria-checked={isActive}
       onClick={onClick}
       className={cn(
-        "px-3 py-1.5 text-xs font-medium transition-colors",
+        "rounded px-2 py-0.5 text-xs font-medium transition-colors",
         isActive
-          ? "border-b-2 border-[var(--stgm-primary,#3b82f6)] text-[var(--stgm-foreground,#171717)]"
+          ? "bg-[var(--stgm-muted,#f5f5f5)] text-[var(--stgm-foreground,#171717)]"
           : "text-[var(--stgm-muted-foreground,#737373)] hover:text-[var(--stgm-foreground,#171717)]",
       )}
     >
@@ -641,3 +963,4 @@ function TabButton({
     </button>
   );
 }
+