@splitsoftware/splitio-commons 2.0.3-rc.0 → 2.0.3

package/esm/storages/pluggable/index.js

@@ -7,7 +7,7 @@ import { EventsCachePluggable } from './EventsCachePluggable';
 import { wrapperAdapter, METHODS_TO_PROMISE_WRAP } from './wrapperAdapter';
 import { isObject } from '../../utils/lang';
 import { getStorageHash, validatePrefix } from '../KeyBuilder';
-import { CONSUMER_PARTIAL_MODE, STORAGE_PLUGGABLE } from '../../utils/constants';
+import { CONSUMER_PARTIAL_MODE, DEBUG, NONE, STORAGE_PLUGGABLE } from '../../utils/constants';
 import { ImpressionsCacheInMemory } from '../inMemory/ImpressionsCacheInMemory';
 import { EventsCacheInMemory } from '../inMemory/EventsCacheInMemory';
 import { ImpressionCountsCacheInMemory } from '../inMemory/ImpressionCountsCacheInMemory';
@@ -51,26 +51,30 @@ export function PluggableStorage(options) {
     validatePluggableStorageOptions(options);
     var prefix = validatePrefix(options.prefix);
     function PluggableStorageFactory(params) {
-        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
+        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, impressionsMode = _a.sync.impressionsMode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
         var metadata = metadataBuilder(settings);
         var keys = new KeyBuilderSS(prefix, metadata);
         var wrapper = wrapperAdapter(log, options.wrapper);
-        var isSynchronizer = mode === undefined; // If mode is not defined, the synchronizer is running
+        var isSyncronizer = mode === undefined; // If mode is not defined, the synchronizer is running
         var isPartialConsumer = mode === CONSUMER_PARTIAL_MODE;
-        var telemetry = shouldRecordTelemetry(params) || isSynchronizer ?
+        var telemetry = shouldRecordTelemetry(params) || isSyncronizer ?
             isPartialConsumer ?
                 new TelemetryCacheInMemory() :
                 new TelemetryCachePluggable(log, keys, wrapper) :
             undefined;
-        var impressionCountsCache = isPartialConsumer ?
-            new ImpressionCountsCacheInMemory() :
-            new ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper);
-        var uniqueKeysCache = isPartialConsumer ?
-            settings.core.key === undefined ? new UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS() :
-            new UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper);
+        var impressionCountsCache = impressionsMode !== DEBUG || isSyncronizer ?
+            isPartialConsumer ?
+                new ImpressionCountsCacheInMemory() :
+                new ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper) :
+            undefined;
+        var uniqueKeysCache = impressionsMode === NONE || isSyncronizer ?
+            isPartialConsumer ?
+                settings.core.key === undefined ? new UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS() :
+                new UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper) :
+            undefined;
         // Connects to wrapper and emits SDK_READY event on main client
         var connectPromise = wrapper.connect().then(function () {
-            if (isSynchronizer) {
+            if (isSyncronizer) {
                 // In standalone or producer mode, clear storage if SDK key or feature flag filter has changed
                 return wrapper.get(keys.buildHashKey()).then(function (hash) {
                     var currentHash = getStorageHash(settings);
@@ -86,9 +90,9 @@ export function PluggableStorage(options) {
             }
             else {
                 // Start periodic flush of async storages if not running synchronizer (producer mode)
-                if (impressionCountsCache.start)
+                if (impressionCountsCache && impressionCountsCache.start)
                     impressionCountsCache.start();
-                if (uniqueKeysCache.start)
+                if (uniqueKeysCache && uniqueKeysCache.start)
                     uniqueKeysCache.start();
                 if (telemetry && telemetry.recordConfig)
                     telemetry.recordConfig();
@@ -109,9 +113,9 @@ export function PluggableStorage(options) {
             uniqueKeys: uniqueKeysCache,
             // Stop periodic flush and disconnect the underlying storage
             destroy: function () {
-                return Promise.all(isSynchronizer ? [] : [
-                    impressionCountsCache.stop && impressionCountsCache.stop(),
-                    uniqueKeysCache.stop && uniqueKeysCache.stop(),
+                return Promise.all(isSyncronizer ? [] : [
+                    impressionCountsCache && impressionCountsCache.stop && impressionCountsCache.stop(),
+                    uniqueKeysCache && uniqueKeysCache.stop && uniqueKeysCache.stop(),
                 ]).then(function () { return wrapper.disconnect(); });
             },
             // emits SDK_READY event on shared clients and returns a reference to the storage

package/esm/sync/streaming/pushManager.js

@@ -306,12 +306,14 @@ export function pushManagerFactory(params, pollingManager) {
                 // Reconnects in case of a new client.
                 // Run in next event-loop cycle to save authentication calls
                 // in case multiple clients are created in the current cycle.
-                setTimeout(function checkForReconnect() {
-                    if (connectForNewClient) {
-                        connectForNewClient = false;
-                        connectPush();
-                    }
-                }, 0);
+                if (this.isRunning()) {
+                    setTimeout(function checkForReconnect() {
+                        if (connectForNewClient) {
+                            connectForNewClient = false;
+                            connectPush();
+                        }
+                    }, 0);
+                }
             }
         },
         // [Only for client-side]

package/esm/sync/submitters/impressionCountsSubmitter.js

@@ -26,6 +26,8 @@ var IMPRESSIONS_COUNT_RATE = 1800000; // 30 minutes
  */
 export function impressionCountsSubmitterFactory(params) {
     var log = params.settings.log, postTestImpressionsCount = params.splitApi.postTestImpressionsCount, impressionCounts = params.storage.impressionCounts;
-    // retry impressions counts only once.
-    return submitterFactory(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
+    if (impressionCounts) {
+        // retry impressions counts only once.
+        return submitterFactory(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
+    }
 }

package/esm/sync/submitters/submitterManager.js

@@ -6,11 +6,14 @@ import { uniqueKeysSubmitterFactory } from './uniqueKeysSubmitter';
 export function submitterManagerFactory(params) {
     var submitters = [
         impressionsSubmitterFactory(params),
-        eventsSubmitterFactory(params),
-        impressionCountsSubmitterFactory(params),
-        uniqueKeysSubmitterFactory(params)
+        eventsSubmitterFactory(params)
     ];
+    var impressionCountsSubmitter = impressionCountsSubmitterFactory(params);
+    if (impressionCountsSubmitter)
+        submitters.push(impressionCountsSubmitter);
     var telemetrySubmitter = telemetrySubmitterFactory(params);
+    if (params.storage.uniqueKeys)
+        submitters.push(uniqueKeysSubmitterFactory(params));
     return {
         // `onlyTelemetry` true if SDK is created with userConsent not GRANTED
         start: function (onlyTelemetry) {

package/esm/sync/syncManagerOnline.js

@@ -115,6 +115,8 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
                 if (!pollingManager)
                     return;
                 var mySegmentsSyncTask = pollingManager.add(matchingKey, readinessManager, storage);
+                if (syncEnabled && pushManager)
+                    pushManager.add(matchingKey, mySegmentsSyncTask);
                 if (running) {
                     if (syncEnabled) {
                         if (pushManager) {
@@ -128,7 +130,6 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
                                 // of segments since `syncAll` was already executed when starting the main client
                                 mySegmentsSyncTask.execute();
                             }
-                            pushManager.add(matchingKey, mySegmentsSyncTask);
                         }
                         else {
                             if (storage.splits.usesSegments())

package/esm/trackers/eventTracker.js

@@ -22,7 +22,7 @@ export function eventTrackerFactory(settings, eventsCache, whenInit, integration
                 whenInit(function () {
                     // Wrap in a timeout because we don't want it to be blocking.
                     setTimeout(function () {
-                        // copy of event, to avoid unexpected behaviour if modified by integrations
+                        // copy of event, to avoid unexpected behavior if modified by integrations
                         var eventDataCopy = objectAssign({}, eventData);
                         if (properties)
                             eventDataCopy.properties = objectAssign({}, properties);

package/esm/trackers/impressionsTracker.js

@@ -4,37 +4,38 @@ import { IMPRESSIONS_TRACKER_SUCCESS, ERROR_IMPRESSIONS_TRACKER, ERROR_IMPRESSIO
 import { CONSENT_DECLINED, DEDUPED, QUEUED } from '../utils/constants';
 /**
  * Impressions tracker stores impressions in cache and pass them to the listener and integrations manager if provided.
+ *
+ * @param impressionsCache - cache to save impressions
+ * @param metadata - runtime metadata (ip, hostname and version)
+ * @param impressionListener - optional impression listener
+ * @param integrationsManager - optional integrations manager
+ * @param strategy - strategy for impressions tracking.
  */
-export function impressionsTrackerFactory(settings, impressionsCache, noneStrategy, strategy, whenInit, integrationsManager, telemetryCache) {
+export function impressionsTrackerFactory(settings, impressionsCache, strategy, whenInit, integrationsManager, telemetryCache) {
     var log = settings.log, impressionListener = settings.impressionListener, _a = settings.runtime, ip = _a.ip, hostname = _a.hostname, version = settings.version;
     return {
         track: function (impressions, attributes) {
             if (settings.userConsent === CONSENT_DECLINED)
                 return;
-            var impressionsToStore = impressions.filter(function (_a) {
-                var impression = _a[0], track = _a[1];
-                return track === false ?
-                    noneStrategy.process(impression) :
-                    strategy.process(impression);
-            });
-            var impressionsLength = impressions.length;
-            var impressionsToStoreLength = impressionsToStore.length;
-            if (impressionsToStoreLength) {
-                var res = impressionsCache.track(impressionsToStore.map(function (item) { return item[0]; }));
+            var impressionsCount = impressions.length;
+            var _a = strategy.process(impressions), impressionsToStore = _a.impressionsToStore, impressionsToListener = _a.impressionsToListener, deduped = _a.deduped;
+            var impressionsToListenerCount = impressionsToListener.length;
+            if (impressionsToStore.length > 0) {
+                var res = impressionsCache.track(impressionsToStore);
                 // If we're on an async storage, handle error and log it.
                 if (thenable(res)) {
                     res.then(function () {
-                        log.info(IMPRESSIONS_TRACKER_SUCCESS, [impressionsLength]);
+                        log.info(IMPRESSIONS_TRACKER_SUCCESS, [impressionsCount]);
                     }).catch(function (err) {
-                        log.error(ERROR_IMPRESSIONS_TRACKER, [impressionsLength, err]);
+                        log.error(ERROR_IMPRESSIONS_TRACKER, [impressionsCount, err]);
                     });
                 }
                 else {
                     // Record when impressionsCache is sync only (standalone mode)
                     // @TODO we are not dropping impressions on full queue yet, so DROPPED stats are not recorded
                     if (telemetryCache) {
-                        telemetryCache.recordImpressionStats(QUEUED, impressionsToStoreLength);
-                        telemetryCache.recordImpressionStats(DEDUPED, impressionsLength - impressionsToStoreLength);
+                        telemetryCache.recordImpressionStats(QUEUED, impressionsToStore.length);
+                        telemetryCache.recordImpressionStats(DEDUPED, deduped);
                     }
                 }
             }
@@ -42,8 +43,8 @@ export function impressionsTrackerFactory(settings, impressionsCache, noneStrate
             if (impressionListener || integrationsManager) {
                 var _loop_1 = function (i) {
                     var impressionData = {
-                        // copy of impression, to avoid unexpected behaviour if modified by integrations or impressionListener
-                        impression: objectAssign({}, impressions[i][0]),
+                        // copy of impression, to avoid unexpected behavior if modified by integrations or impressionListener
+                        impression: objectAssign({}, impressionsToListener[i]),
                         attributes: attributes,
                         ip: ip,
                         hostname: hostname,
@@ -65,7 +66,7 @@ export function impressionsTrackerFactory(settings, impressionsCache, noneStrate
                         });
                     });
                 };
-                for (var i = 0; i < impressionsLength; i++) {
+                for (var i = 0; i < impressionsToListenerCount; i++) {
                     _loop_1(i);
                 }
             }

package/esm/trackers/strategy/strategyDebug.js

@@ -2,13 +2,20 @@
  * Debug strategy for impressions tracker. Wraps impressions to store and adds previousTime if it corresponds
  *
  * @param impressionsObserver - impression observer. Previous time (pt property) is included in impression instances
- * @returns Debug strategy
+ * @returns IStrategyResult
  */
 export function strategyDebugFactory(impressionsObserver) {
     return {
-        process: function (impression) {
-            impression.pt = impressionsObserver.testAndSet(impression);
-            return true;
+        process: function (impressions) {
+            impressions.forEach(function (impression) {
+                // Adds previous time if it is enabled
+                impression.pt = impressionsObserver.testAndSet(impression);
+            });
+            return {
+                impressionsToStore: impressions,
+                impressionsToListener: impressions,
+                deduped: 0
+            };
         }
     };
 }

package/esm/trackers/strategy/strategyNone.js

@@ -1,20 +1,25 @@
 /**
  * None strategy for impressions tracker.
  *
- * @param impressionCounts - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
+ * @param impressionsCounter - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
  * @param uniqueKeysTracker - unique keys tracker in charge of tracking the unique keys per split.
- * @returns None strategy
+ * @returns IStrategyResult
  */
-export function strategyNoneFactory(impressionCounts, uniqueKeysTracker) {
+export function strategyNoneFactory(impressionsCounter, uniqueKeysTracker) {
     return {
-        process: function (impression) {
-            var now = Date.now();
-            // Increments impression counter per featureName
-            impressionCounts.track(impression.feature, now, 1);
-            // Keep track by unique key
-            uniqueKeysTracker.track(impression.keyName, impression.feature);
-            // Do not store impressions
-            return false;
+        process: function (impressions) {
+            impressions.forEach(function (impression) {
+                var now = Date.now();
+                // Increments impression counter per featureName
+                impressionsCounter.track(impression.feature, now, 1);
+                // Keep track by unique key
+                uniqueKeysTracker.track(impression.keyName, impression.feature);
+            });
+            return {
+                impressionsToStore: [],
+                impressionsToListener: impressions,
+                deduped: 0
+            };
         }
     };
 }

package/esm/trackers/strategy/strategyOptimized.js

@@ -3,19 +3,29 @@ import { truncateTimeFrame } from '../../utils/time';
  * Optimized strategy for impressions tracker. Wraps impressions to store and adds previousTime if it corresponds
  *
  * @param impressionsObserver - impression observer. previous time (pt property) is included in impression instances
- * @param impressionCounts - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
- * @returns Optimized strategy
+ * @param impressionsCounter - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
+ * @returns IStrategyResult
  */
-export function strategyOptimizedFactory(impressionsObserver, impressionCounts) {
+export function strategyOptimizedFactory(impressionsObserver, impressionsCounter) {
     return {
-        process: function (impression) {
-            impression.pt = impressionsObserver.testAndSet(impression);
-            var now = Date.now();
-            // Increments impression counter per featureName
-            if (impression.pt)
-                impressionCounts.track(impression.feature, now, 1);
-            // Checks if the impression should be added in queue to be sent
-            return (!impression.pt || impression.pt < truncateTimeFrame(now)) ? true : false;
+        process: function (impressions) {
+            var impressionsToStore = [];
+            impressions.forEach(function (impression) {
+                impression.pt = impressionsObserver.testAndSet(impression);
+                var now = Date.now();
+                // Increments impression counter per featureName
+                if (impression.pt)
+                    impressionsCounter.track(impression.feature, now, 1);
+                // Checks if the impression should be added in queue to be sent
+                if (!impression.pt || impression.pt < truncateTimeFrame(now)) {
+                    impressionsToStore.push(impression);
+                }
+            });
+            return {
+                impressionsToStore: impressionsToStore,
+                impressionsToListener: impressions,
+                deduped: impressions.length - impressionsToStore.length
+            };
         }
     };
 }

package/esm/utils/settingsValidation/index.js

@@ -136,7 +136,7 @@ export function settingsValidation(config, validationParams) {
             withDefaults.core.key = 'localhost_key';
         }
         else {
-            // Keeping same behaviour than JS SDK: if settings key or TT are invalid,
+            // Keeping same behavior than JS SDK: if settings key or TT are invalid,
             // `false` value is used as bound key/TT of the default client, which leads to some issues.
             // @ts-ignore, @TODO handle invalid keys as a non-recoverable error?
             withDefaults.core.key = validateKey(log, maybeKey, LOG_PREFIX_CLIENT_INSTANTIATION);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.0.3-rc.0",
+  "version": "2.0.3",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/dtos/types.ts

@@ -208,8 +208,7 @@ export interface ISplit {
   configurations?: {
     [treatmentName: string]: string
   },
-  sets?: string[],
-  trackImpressions?: boolean
+  sets?: string[]
 }
 
 // Split definition used in offline mode

package/src/evaluator/index.ts

@@ -156,14 +156,12 @@ function getEvaluation(
       return evaluation.then(result => {
         result.changeNumber = split.getChangeNumber();
         result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
-        result.track = splitJSON.trackImpressions;
 
         return result;
       });
     } else {
       evaluation.changeNumber = split.getChangeNumber(); // Always sync and optional
       evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
-      evaluation.track = splitJSON.trackImpressions;
     }
   }
 

package/src/evaluator/matchers/large_segment.ts

@@ -1,18 +1,11 @@
 import { MaybeThenable } from '../../dtos/types';
 import { ISegmentsCacheBase } from '../../storages/types';
-import { thenable } from '../../utils/promise/thenable';
 
 export function largeSegmentMatcherContext(largeSegmentName: string, storage: { largeSegments?: ISegmentsCacheBase }) {
 
   return function largeSegmentMatcher(key: string): MaybeThenable<boolean> {
     const isInLargeSegment = storage.largeSegments ? storage.largeSegments.isInSegment(largeSegmentName, key) : false;
 
-    if (thenable(isInLargeSegment)) {
-      isInLargeSegment.then(result => {
-        return result;
-      });
-    }
-
     return isInLargeSegment;
   };
 }

package/src/evaluator/matchers/segment.ts

@@ -1,18 +1,11 @@
 import { MaybeThenable } from '../../dtos/types';
 import { ISegmentsCacheBase } from '../../storages/types';
-import { thenable } from '../../utils/promise/thenable';
 
 export function segmentMatcherContext(segmentName: string, storage: { segments: ISegmentsCacheBase }) {
 
   return function segmentMatcher(key: string): MaybeThenable<boolean> {
     const isInSegment = storage.segments.isInSegment(segmentName, key);
 
-    if (thenable(isInSegment)) {
-      isInSegment.then(result => {
-        return result;
-      });
-    }
-
     return isInSegment;
   };
 }

package/src/evaluator/types.ts

@@ -25,7 +25,7 @@ export interface IEvaluation {
   config?: string | null
 }
 
-export type IEvaluationResult = IEvaluation & { treatment: string; track?: boolean }
+export type IEvaluationResult = IEvaluation & { treatment: string }
 
 export type ISplitEvaluator = (log: ILogger, key: SplitIO.SplitKey, splitName: string, attributes: SplitIO.Attributes | undefined, storage: IStorageSync | IStorageAsync) => MaybeThenable<IEvaluation>
 

package/src/listeners/browser.ts

@@ -8,6 +8,7 @@ import { IResponse, ISplitApi } from '../services/types';
 import { ISettings } from '../types';
 import SplitIO from '../../types/splitio';
 import { ImpressionsPayload } from '../sync/submitters/types';
+import { OPTIMIZED, DEBUG, NONE } from '../utils/constants';
 import { objectAssign } from '../utils/lang/objectAssign';
 import { CLEANUP_REGISTERING, CLEANUP_DEREGISTERING } from '../logger/constants';
 import { ISyncManager } from '../sync/types';
@@ -77,9 +78,10 @@ export class BrowserSignalListener implements ISignalListener {
 
     // Flush impressions & events data if there is user consent
     if (isConsentGranted(this.settings)) {
+      const sim = this.settings.sync.impressionsMode;
       const extraMetadata = {
         // sim stands for Sync/Split Impressions Mode
-        sim: this.settings.sync.impressionsMode
+        sim: sim === OPTIMIZED ? OPTIMIZED : sim === DEBUG ? DEBUG : NONE
       };
 
       this._flushData(events + '/testImpressions/beacon', this.storage.impressions, this.serviceApi.postTestImpressionsBulk, this.fromImpressionsCollector, extraMetadata);

package/src/listeners/node.ts

@@ -56,7 +56,7 @@ export class NodeSignalListener implements ISignalListener {
       // Cleaned up, remove handlers.
       this.stop();
 
-      // This handler prevented the default behaviour, start again.
+      // This handler prevented the default behavior, start again.
       // eslint-disable-next-line no-undef
       process.kill(process.pid, SIGTERM);
     };
@@ -72,7 +72,7 @@ export class NodeSignalListener implements ISignalListener {
     }
 
     if (thenable(handlerResult)) {
-      // Always exit, even with errors. The promise is returned for UT purposses.
+      // Always exit, even with errors. The promise is returned for UT purposes.
       return handlerResult.then(wrapUp).catch(wrapUp);
     } else {
       wrapUp();

package/src/sdkClient/client.ts

@@ -34,11 +34,11 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
     const stopTelemetryTracker = telemetryTracker.trackEval(withConfig ? TREATMENT_WITH_CONFIG : TREATMENT);
 
     const wrapUp = (evaluationResult: IEvaluationResult) => {
-      const queue: [impression: SplitIO.ImpressionDTO, track?: boolean][] = [];
+      const queue: SplitIO.ImpressionDTO[] = [];
       const treatment = processEvaluation(evaluationResult, featureFlagName, key, attributes, withConfig, methodName, queue);
       impressionsTracker.track(queue, attributes);
 
-      stopTelemetryTracker(queue[0] && queue[0][0].label);
+      stopTelemetryTracker(queue[0] && queue[0].label);
       return treatment;
     };
 
@@ -59,14 +59,14 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
     const stopTelemetryTracker = telemetryTracker.trackEval(withConfig ? TREATMENTS_WITH_CONFIG : TREATMENTS);
 
     const wrapUp = (evaluationResults: Record<string, IEvaluationResult>) => {
-      const queue: [impression: SplitIO.ImpressionDTO, track?: boolean][] = [];
+      const queue: SplitIO.ImpressionDTO[] = [];
       const treatments: Record<string, SplitIO.Treatment | SplitIO.TreatmentWithConfig> = {};
       Object.keys(evaluationResults).forEach(featureFlagName => {
         treatments[featureFlagName] = processEvaluation(evaluationResults[featureFlagName], featureFlagName, key, attributes, withConfig, methodName, queue);
       });
       impressionsTracker.track(queue, attributes);
 
-      stopTelemetryTracker(queue[0] && queue[0][0].label);
+      stopTelemetryTracker(queue[0] && queue[0].label);
       return treatments;
     };
 
@@ -87,7 +87,7 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
     const stopTelemetryTracker = telemetryTracker.trackEval(method);
 
     const wrapUp = (evaluationResults: Record<string, IEvaluationResult>) => {
-      const queue: [impression: SplitIO.ImpressionDTO, track?: boolean][] = [];
+      const queue: SplitIO.ImpressionDTO[] = [];
       const treatments: Record<string, SplitIO.Treatment | SplitIO.TreatmentWithConfig> = {};
       const evaluations = evaluationResults;
       Object.keys(evaluations).forEach(featureFlagName => {
@@ -95,7 +95,7 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
       });
       impressionsTracker.track(queue, attributes);
 
-      stopTelemetryTracker(queue[0] && queue[0][0].label);
+      stopTelemetryTracker(queue[0] && queue[0].label);
       return treatments;
     };
 
@@ -128,25 +128,25 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
     attributes: SplitIO.Attributes | undefined,
     withConfig: boolean,
     invokingMethodName: string,
-    queue: [impression: SplitIO.ImpressionDTO, track?: boolean][]
+    queue: SplitIO.ImpressionDTO[]
   ): SplitIO.Treatment | SplitIO.TreatmentWithConfig {
     const matchingKey = getMatching(key);
     const bucketingKey = getBucketing(key);
 
-    const { treatment, label, changeNumber, config = null, track } = evaluation;
+    const { treatment, label, changeNumber, config = null } = evaluation;
     log.info(IMPRESSION, [featureFlagName, matchingKey, treatment, label]);
 
     if (validateSplitExistence(log, readinessManager, featureFlagName, label, invokingMethodName)) {
       log.info(IMPRESSION_QUEUEING);
-      queue.push([{
+      queue.push({
         feature: featureFlagName,
         keyName: matchingKey,
         treatment,
         time: Date.now(),
         bucketingKey,
         label,
-        changeNumber: changeNumber as number,
-      }, track]);
+        changeNumber: changeNumber as number
+      });
     }
 
     if (withConfig) {

package/src/sdkClient/sdkClient.ts

@@ -61,7 +61,7 @@ export function sdkClientFactory(params: ISdkFactoryContext, isSharedClient?: bo
           releaseApiKey(settings.core.authorizationKey);
           telemetryTracker.sessionLength();
           signalListener && signalListener.stop();
-          uniqueKeysTracker.stop();
+          uniqueKeysTracker && uniqueKeysTracker.stop();
         }
 
         // Stop background jobs

package/src/sdkFactory/index.ts

@@ -13,7 +13,7 @@ import { strategyDebugFactory } from '../trackers/strategy/strategyDebug';
 import { strategyOptimizedFactory } from '../trackers/strategy/strategyOptimized';
 import { strategyNoneFactory } from '../trackers/strategy/strategyNone';
 import { uniqueKeysTrackerFactory } from '../trackers/uniqueKeysTracker';
-import { DEBUG, OPTIMIZED } from '../utils/constants';
+import { NONE, OPTIMIZED } from '../utils/constants';
 
 /**
  * Modular SDK factory
@@ -59,16 +59,21 @@ export function sdkFactory(params: ISdkFactoryParams): SplitIO.ISDK | SplitIO.IA
   const integrationsManager = integrationsManagerFactory && integrationsManagerFactory({ settings, storage, telemetryTracker });
 
   const observer = impressionsObserverFactory();
-  const uniqueKeysTracker = uniqueKeysTrackerFactory(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory());
-
-  const noneStrategy = strategyNoneFactory(storage.impressionCounts, uniqueKeysTracker);
-  const strategy = impressionsMode === OPTIMIZED ?
-    strategyOptimizedFactory(observer, storage.impressionCounts) :
-    impressionsMode === DEBUG ?
-      strategyDebugFactory(observer) :
-      noneStrategy;
+  const uniqueKeysTracker = impressionsMode === NONE ? uniqueKeysTrackerFactory(log, storage.uniqueKeys!, filterAdapterFactory && filterAdapterFactory()) : undefined;
+
+  let strategy;
+  switch (impressionsMode) {
+    case OPTIMIZED:
+      strategy = strategyOptimizedFactory(observer, storage.impressionCounts!);
+      break;
+    case NONE:
+      strategy = strategyNoneFactory(storage.impressionCounts!, uniqueKeysTracker!);
+      break;
+    default:
+      strategy = strategyDebugFactory(observer);
+  }
 
-  const impressionsTracker = impressionsTrackerFactory(settings, storage.impressions, noneStrategy, strategy, whenInit, integrationsManager, storage.telemetry);
+  const impressionsTracker = impressionsTrackerFactory(settings, storage.impressions, strategy, whenInit, integrationsManager, storage.telemetry);
   const eventTracker = eventTrackerFactory(settings, storage.events, whenInit, integrationsManager, storage.telemetry);
 
   // splitApi is used by SyncManager and Browser signal listener
@@ -94,7 +99,7 @@ export function sdkFactory(params: ISdkFactoryParams): SplitIO.ISDK | SplitIO.IA
     // We will just log and allow for the SDK to end up throwing an SDK_TIMEOUT event for devs to handle.
     validateAndTrackApiKey(log, settings.core.authorizationKey);
     readiness.init();
-    uniqueKeysTracker.start();
+    uniqueKeysTracker && uniqueKeysTracker.start();
     syncManager && syncManager.start();
     signalListener && signalListener.start();
 

package/src/sdkFactory/types.ts

@@ -46,7 +46,7 @@ export interface ISdkFactoryContext {
   eventTracker: IEventTracker,
   telemetryTracker: ITelemetryTracker,
   storage: IStorageSync | IStorageAsync,
-  uniqueKeysTracker: IUniqueKeysTracker,
+  uniqueKeysTracker?: IUniqueKeysTracker,
   signalListener?: ISignalListener
   splitApi?: ISplitApi
   syncManager?: ISyncManager,

package/src/sdkManager/index.ts

@@ -31,8 +31,7 @@ function objectToView(splitObject: ISplit | null): SplitIO.SplitView | null {
     treatments: collectTreatments(splitObject),
     configs: splitObject.configurations || {},
     sets: splitObject.sets || [],
-    defaultTreatment: splitObject.defaultTreatment,
-    trackImpressions: splitObject.trackImpressions !== false
+    defaultTreatment: splitObject.defaultTreatment
   };
 }