@splitsoftware/splitio-commons 2.0.3-rc.0 → 2.0.3

package/CHANGES.txt

@@ -1,6 +1,5 @@
-2.1.0 (January XX, 2025)
- - Added `trackImpressions` property to SDK Manager's `SplitView` type.
- - Updated implementation of the impressions tracker and strategies to support feature flags with impressions tracking disabled.
+2.0.3 (January 9, 2025)
+ - Bugfixing - Properly handle rejected promises when using targeting rules with segment matchers in consumer modes (e.g., Redis and Pluggable storages).
 
 2.0.2 (December 3, 2024)
  - Updated the factory `init` and `destroy` methods to support re-initialization after destruction. This update ensures compatibility of the React SDK with React Strict Mode, where the factory's `init` and `destroy` effects are executed an extra time to validate proper resource cleanup.

package/LICENSE

@@ -1,4 +1,4 @@
-Copyright © 2024 Split Software, Inc.
+Copyright © 2025 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

package/README.md

@@ -14,7 +14,7 @@ This library is compatible with JavaScript ES5 and above.
 Please see [Contributors Guide](CONTRIBUTORS-GUIDE.md) to find all you need to submit a Pull Request (PR).
 
 ## License
-Licensed under the Apache License, Version 2.0. See: [Apache License](http://www.apache.org/licenses/).
+Licensed under the Apache License, Version 2.0. See: [Apache License](https://www.apache.org/licenses/).
 
 ## About Split
 
@@ -46,4 +46,4 @@ For a comprehensive list of open source projects visit our [Github page](https:/
 
 **Learn more about Split:**
 
-Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](http://help.split.io) for more detailed information.
+Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](https://help.split.io) for more detailed information.

package/cjs/evaluator/index.js

@@ -104,14 +104,12 @@ function getEvaluation(log, splitJSON, key, attributes, storage) {
             return evaluation.then(function (result) {
                 result.changeNumber = split_1.getChangeNumber();
                 result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
-                result.track = splitJSON.trackImpressions;
                 return result;
             });
         }
         else {
             evaluation.changeNumber = split_1.getChangeNumber(); // Always sync and optional
             evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
-            evaluation.track = splitJSON.trackImpressions;
         }
     }
     return evaluation;

package/cjs/evaluator/matchers/large_segment.js

@@ -1,15 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.largeSegmentMatcherContext = void 0;
-var thenable_1 = require("../../utils/promise/thenable");
 function largeSegmentMatcherContext(largeSegmentName, storage) {
     return function largeSegmentMatcher(key) {
         var isInLargeSegment = storage.largeSegments ? storage.largeSegments.isInSegment(largeSegmentName, key) : false;
-        if ((0, thenable_1.thenable)(isInLargeSegment)) {
-            isInLargeSegment.then(function (result) {
-                return result;
-            });
-        }
         return isInLargeSegment;
     };
 }

package/cjs/evaluator/matchers/segment.js

@@ -1,15 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.segmentMatcherContext = void 0;
-var thenable_1 = require("../../utils/promise/thenable");
 function segmentMatcherContext(segmentName, storage) {
     return function segmentMatcher(key) {
         var isInSegment = storage.segments.isInSegment(segmentName, key);
-        if ((0, thenable_1.thenable)(isInSegment)) {
-            isInSegment.then(function (result) {
-                return result;
-            });
-        }
         return isInSegment;
     };
 }

package/cjs/listeners/browser.js

@@ -3,8 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.BrowserSignalListener = void 0;
 var impressionsSubmitter_1 = require("../sync/submitters/impressionsSubmitter");
 var impressionCountsSubmitter_1 = require("../sync/submitters/impressionCountsSubmitter");
+var constants_1 = require("../utils/constants");
 var objectAssign_1 = require("../utils/lang/objectAssign");
-var constants_1 = require("../logger/constants");
+var constants_2 = require("../logger/constants");
 var consent_1 = require("../consent");
 var VISIBILITYCHANGE_EVENT = 'visibilitychange';
 var PAGEHIDE_EVENT = 'pagehide';
@@ -27,7 +28,7 @@ var BrowserSignalListener = /** @class */ (function () {
      * Called when SplitFactory is initialized, it adds event listeners to close streaming and flush impressions and events.
      */
     BrowserSignalListener.prototype.start = function () {
-        this.settings.log.debug(constants_1.CLEANUP_REGISTERING, [EVENT_NAME]);
+        this.settings.log.debug(constants_2.CLEANUP_REGISTERING, [EVENT_NAME]);
         if (typeof document !== 'undefined' && document.addEventListener) {
             // Flush data whenever the page is hidden or unloaded.
             document.addEventListener(VISIBILITYCHANGE_EVENT, this.flushDataIfHidden);
@@ -43,7 +44,7 @@ var BrowserSignalListener = /** @class */ (function () {
      * Called when client is destroyed, it removes event listeners.
      */
     BrowserSignalListener.prototype.stop = function () {
-        this.settings.log.debug(constants_1.CLEANUP_DEREGISTERING, [EVENT_NAME]);
+        this.settings.log.debug(constants_2.CLEANUP_DEREGISTERING, [EVENT_NAME]);
         if (typeof document !== 'undefined' && document.removeEventListener) {
             document.removeEventListener(VISIBILITYCHANGE_EVENT, this.flushDataIfHidden);
         }
@@ -62,9 +63,10 @@ var BrowserSignalListener = /** @class */ (function () {
         var _a = this.settings.urls, events = _a.events, telemetry = _a.telemetry;
         // Flush impressions & events data if there is user consent
         if ((0, consent_1.isConsentGranted)(this.settings)) {
+            var sim = this.settings.sync.impressionsMode;
             var extraMetadata = {
                 // sim stands for Sync/Split Impressions Mode
-                sim: this.settings.sync.impressionsMode
+                sim: sim === constants_1.OPTIMIZED ? constants_1.OPTIMIZED : sim === constants_1.DEBUG ? constants_1.DEBUG : constants_1.NONE
             };
             this._flushData(events + '/testImpressions/beacon', this.storage.impressions, this.serviceApi.postTestImpressionsBulk, this.fromImpressionsCollector, extraMetadata);
             this._flushData(events + '/events/beacon', this.storage.events, this.serviceApi.postEventsBulk);

package/cjs/listeners/node.js

@@ -43,7 +43,7 @@ var NodeSignalListener = /** @class */ (function () {
         var wrapUp = function () {
             // Cleaned up, remove handlers.
             _this.stop();
-            // This handler prevented the default behaviour, start again.
+            // This handler prevented the default behavior, start again.
             // eslint-disable-next-line no-undef
             process.kill(process.pid, SIGTERM);
         };
@@ -56,7 +56,7 @@ var NodeSignalListener = /** @class */ (function () {
             this.settings.log.error(constants_1.LOG_PREFIX_CLEANUP + "Error with Split SDK graceful shutdown: " + err);
         }
         if ((0, thenable_1.thenable)(handlerResult)) {
-            // Always exit, even with errors. The promise is returned for UT purposses.
+            // Always exit, even with errors. The promise is returned for UT purposes.
             return handlerResult.then(wrapUp).catch(wrapUp);
         }
         else {

package/cjs/sdkClient/client.js

@@ -33,7 +33,7 @@ function clientFactory(params) {
             var queue = [];
             var treatment = processEvaluation(evaluationResult, featureFlagName, key, attributes, withConfig, methodName, queue);
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0][0].label);
+            stopTelemetryTracker(queue[0] && queue[0].label);
             return treatment;
         };
         var evaluation = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -57,7 +57,7 @@ function clientFactory(params) {
                 treatments[featureFlagName] = processEvaluation(evaluationResults[featureFlagName], featureFlagName, key, attributes, withConfig, methodName, queue);
             });
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0][0].label);
+            stopTelemetryTracker(queue[0] && queue[0].label);
             return treatments;
         };
         var evaluations = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -83,7 +83,7 @@ function clientFactory(params) {
                 treatments[featureFlagName] = processEvaluation(evaluations[featureFlagName], featureFlagName, key, attributes, withConfig, methodName, queue);
             });
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0][0].label);
+            stopTelemetryTracker(queue[0] && queue[0].label);
             return treatments;
         };
         var evaluations = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -106,19 +106,19 @@ function clientFactory(params) {
     function processEvaluation(evaluation, featureFlagName, key, attributes, withConfig, invokingMethodName, queue) {
         var matchingKey = (0, key_1.getMatching)(key);
         var bucketingKey = (0, key_1.getBucketing)(key);
-        var treatment = evaluation.treatment, label = evaluation.label, changeNumber = evaluation.changeNumber, _a = evaluation.config, config = _a === void 0 ? null : _a, track = evaluation.track;
+        var treatment = evaluation.treatment, label = evaluation.label, changeNumber = evaluation.changeNumber, _a = evaluation.config, config = _a === void 0 ? null : _a;
         log.info(constants_2.IMPRESSION, [featureFlagName, matchingKey, treatment, label]);
         if ((0, splitExistence_1.validateSplitExistence)(log, readinessManager, featureFlagName, label, invokingMethodName)) {
             log.info(constants_2.IMPRESSION_QUEUEING);
-            queue.push([{
-                    feature: featureFlagName,
-                    keyName: matchingKey,
-                    treatment: treatment,
-                    time: Date.now(),
-                    bucketingKey: bucketingKey,
-                    label: label,
-                    changeNumber: changeNumber,
-                }, track]);
+            queue.push({
+                feature: featureFlagName,
+                keyName: matchingKey,
+                treatment: treatment,
+                time: Date.now(),
+                bucketingKey: bucketingKey,
+                label: label,
+                changeNumber: changeNumber
+            });
         }
         if (withConfig) {
             return {

package/cjs/sdkClient/sdkClient.js

@@ -50,7 +50,7 @@ function sdkClientFactory(params, isSharedClient) {
                 (0, apiKey_1.releaseApiKey)(settings.core.authorizationKey);
                 telemetryTracker.sessionLength();
                 signalListener && signalListener.stop();
-                uniqueKeysTracker.stop();
+                uniqueKeysTracker && uniqueKeysTracker.stop();
             }
             // Stop background jobs
             syncManager && syncManager.stop();

package/cjs/sdkFactory/index.js

@@ -51,14 +51,19 @@ function sdkFactory(params) {
     var telemetryTracker = (0, telemetryTracker_1.telemetryTrackerFactory)(storage.telemetry, platform.now);
     var integrationsManager = integrationsManagerFactory && integrationsManagerFactory({ settings: settings, storage: storage, telemetryTracker: telemetryTracker });
     var observer = impressionsObserverFactory();
-    var uniqueKeysTracker = (0, uniqueKeysTracker_1.uniqueKeysTrackerFactory)(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory());
-    var noneStrategy = (0, strategyNone_1.strategyNoneFactory)(storage.impressionCounts, uniqueKeysTracker);
-    var strategy = impressionsMode === constants_3.OPTIMIZED ?
-        (0, strategyOptimized_1.strategyOptimizedFactory)(observer, storage.impressionCounts) :
-        impressionsMode === constants_3.DEBUG ?
-            (0, strategyDebug_1.strategyDebugFactory)(observer) :
-            noneStrategy;
-    var impressionsTracker = (0, impressionsTracker_1.impressionsTrackerFactory)(settings, storage.impressions, noneStrategy, strategy, whenInit, integrationsManager, storage.telemetry);
+    var uniqueKeysTracker = impressionsMode === constants_3.NONE ? (0, uniqueKeysTracker_1.uniqueKeysTrackerFactory)(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory()) : undefined;
+    var strategy;
+    switch (impressionsMode) {
+        case constants_3.OPTIMIZED:
+            strategy = (0, strategyOptimized_1.strategyOptimizedFactory)(observer, storage.impressionCounts);
+            break;
+        case constants_3.NONE:
+            strategy = (0, strategyNone_1.strategyNoneFactory)(storage.impressionCounts, uniqueKeysTracker);
+            break;
+        default:
+            strategy = (0, strategyDebug_1.strategyDebugFactory)(observer);
+    }
+    var impressionsTracker = (0, impressionsTracker_1.impressionsTrackerFactory)(settings, storage.impressions, strategy, whenInit, integrationsManager, storage.telemetry);
     var eventTracker = (0, eventTracker_1.eventTrackerFactory)(settings, storage.events, whenInit, integrationsManager, storage.telemetry);
     // splitApi is used by SyncManager and Browser signal listener
     var splitApi = splitApiFactory && splitApiFactory(settings, platform, telemetryTracker);
@@ -77,7 +82,7 @@ function sdkFactory(params) {
         // We will just log and allow for the SDK to end up throwing an SDK_TIMEOUT event for devs to handle.
         (0, apiKey_1.validateAndTrackApiKey)(log, settings.core.authorizationKey);
         readiness.init();
-        uniqueKeysTracker.start();
+        uniqueKeysTracker && uniqueKeysTracker.start();
         syncManager && syncManager.start();
         signalListener && signalListener.start();
         initCallbacks.forEach(function (cb) { return cb(); });

package/cjs/sdkManager/index.js

@@ -28,8 +28,7 @@ function objectToView(splitObject) {
         treatments: collectTreatments(splitObject),
         configs: splitObject.configurations || {},
         sets: splitObject.sets || [],
-        defaultTreatment: splitObject.defaultTreatment,
-        trackImpressions: splitObject.trackImpressions !== false
+        defaultTreatment: splitObject.defaultTreatment
     };
 }
 function objectsToViews(splitObjects) {

package/cjs/storages/inLocalStorage/index.js

@@ -28,7 +28,7 @@ function InLocalStorage(options) {
             params.settings.log.warn(constants_1.LOG_PREFIX + 'LocalStorage API is unavailable. Falling back to default MEMORY storage');
             return (0, InMemoryStorageCS_1.InMemoryStorageCSFactory)(params);
         }
-        var settings = params.settings, _a = params.settings, log = _a.log, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
+        var settings = params.settings, _a = params.settings, log = _a.log, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
         var matchingKey = (0, key_1.getMatching)(settings.core.key);
         var keys = new KeyBuilderCS_1.KeyBuilderCS(prefix, matchingKey);
         var expirationTimestamp = Date.now() - browser_1.DEFAULT_CACHE_EXPIRATION_IN_MILLIS;
@@ -40,10 +40,10 @@ function InLocalStorage(options) {
             segments: segments,
             largeSegments: largeSegments,
             impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-            impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
+            impressionCounts: impressionsMode !== constants_2.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
             events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
             telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-            uniqueKeys: new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS(),
+            uniqueKeys: impressionsMode === constants_2.NONE ? new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() : undefined,
             destroy: function () { },
             // When using shared instantiation with MEMORY we reuse everything but segments (they are customer per key).
             shared: function (matchingKey) {
@@ -55,7 +55,6 @@ function InLocalStorage(options) {
                     impressionCounts: this.impressionCounts,
                     events: this.events,
                     telemetry: this.telemetry,
-                    uniqueKeys: this.uniqueKeys,
                     destroy: function () { }
                 };
             },

package/cjs/storages/inMemory/InMemoryStorage.js

@@ -15,17 +15,17 @@ var UniqueKeysCacheInMemory_1 = require("./UniqueKeysCacheInMemory");
  * @param params - parameters required by EventsCacheSync
  */
 function InMemoryStorageFactory(params) {
-    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
+    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, _c = _a.sync, impressionsMode = _c.impressionsMode, __splitFiltersValidation = _c.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
     var segments = new SegmentsCacheInMemory_1.SegmentsCacheInMemory();
     var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-        impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
+        impressionCounts: impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
         events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
         telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-        uniqueKeys: new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory(),
+        uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : undefined,
         destroy: function () { }
     };
     // @TODO revisit storage logic in localhost mode

package/cjs/storages/inMemory/InMemoryStorageCS.js

@@ -15,7 +15,7 @@ var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
  * @param params - parameters required by EventsCacheSync
  */
 function InMemoryStorageCSFactory(params) {
-    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
+    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, _c = _a.sync, impressionsMode = _c.impressionsMode, __splitFiltersValidation = _c.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
     var segments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var largeSegments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
@@ -24,10 +24,10 @@ function InMemoryStorageCSFactory(params) {
         segments: segments,
         largeSegments: largeSegments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-        impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
+        impressionCounts: impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
         events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
         telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-        uniqueKeys: new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS(),
+        uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() : undefined,
         destroy: function () { },
         // When using shared instantiation with MEMORY we reuse everything but segments (they are unique per key)
         shared: function () {
@@ -39,7 +39,6 @@ function InMemoryStorageCSFactory(params) {
                 impressionCounts: this.impressionCounts,
                 events: this.events,
                 telemetry: this.telemetry,
-                uniqueKeys: this.uniqueKeys,
                 destroy: function () { }
             };
         },

package/cjs/storages/inRedis/SplitsCacheInRedis.js

@@ -241,9 +241,9 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
             this.log.error(constants_1.LOG_PREFIX + this.redisError);
             return Promise.reject(this.redisError);
         }
-        var splits = {};
         var keys = names.map(function (name) { return _this.keys.buildSplitKey(name); });
         return (_a = this.redis).mget.apply(_a, keys).then(function (splitDefinitions) {
+            var splits = {};
             names.forEach(function (name, idx) {
                 var split = splitDefinitions[idx];
                 splits[name] = split && JSON.parse(split);

package/cjs/storages/inRedis/index.js

@@ -23,18 +23,20 @@ function InRedisStorage(options) {
     var RD = require('./RedisAdapter').RedisAdapter;
     var prefix = (0, KeyBuilder_1.validatePrefix)(options.prefix);
     function InRedisStorageFactory(params) {
-        var onReadyCb = params.onReadyCb, settings = params.settings, log = params.settings.log;
+        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, impressionsMode = _a.sync.impressionsMode;
         var metadata = (0, utils_1.metadataBuilder)(settings);
         var keys = new KeyBuilderSS_1.KeyBuilderSS(prefix, metadata);
         var redisClient = new RD(log, options.options || {});
         var telemetry = new TelemetryCacheInRedis_1.TelemetryCacheInRedis(log, keys, redisClient);
-        var impressionCountsCache = new ImpressionCountsCacheInRedis_1.ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient);
-        var uniqueKeysCache = new UniqueKeysCacheInRedis_1.UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient);
+        var impressionCountsCache = impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInRedis_1.ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient) : undefined;
+        var uniqueKeysCache = impressionsMode === constants_1.NONE ? new UniqueKeysCacheInRedis_1.UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient) : undefined;
         // subscription to Redis connect event in order to emit SDK_READY event on consumer mode
         redisClient.on('connect', function () {
             onReadyCb();
-            impressionCountsCache.start();
-            uniqueKeysCache.start();
+            if (impressionCountsCache)
+                impressionCountsCache.start();
+            if (uniqueKeysCache)
+                uniqueKeysCache.start();
             // Synchronize config
             telemetry.recordConfig();
         });
@@ -49,10 +51,12 @@ function InRedisStorage(options) {
             // When using REDIS we should:
             // 1- Disconnect from the storage
             destroy: function () {
-                return Promise.all([
-                    impressionCountsCache.stop(),
-                    uniqueKeysCache.stop()
-                ]).then(function () { redisClient.disconnect(); });
+                var promises = [];
+                if (impressionCountsCache)
+                    promises.push(impressionCountsCache.stop());
+                if (uniqueKeysCache)
+                    promises.push(uniqueKeysCache.stop());
+                return Promise.all(promises).then(function () { redisClient.disconnect(); });
                 // @TODO check that caches works as expected when redisClient is disconnected
             }
         };

package/cjs/storages/pluggable/index.js

@@ -54,26 +54,30 @@ function PluggableStorage(options) {
     validatePluggableStorageOptions(options);
     var prefix = (0, KeyBuilder_1.validatePrefix)(options.prefix);
     function PluggableStorageFactory(params) {
-        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
+        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, impressionsMode = _a.sync.impressionsMode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
         var metadata = (0, utils_1.metadataBuilder)(settings);
         var keys = new KeyBuilderSS_1.KeyBuilderSS(prefix, metadata);
         var wrapper = (0, wrapperAdapter_1.wrapperAdapter)(log, options.wrapper);
-        var isSynchronizer = mode === undefined; // If mode is not defined, the synchronizer is running
+        var isSyncronizer = mode === undefined; // If mode is not defined, the synchronizer is running
         var isPartialConsumer = mode === constants_1.CONSUMER_PARTIAL_MODE;
-        var telemetry = (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) || isSynchronizer ?
+        var telemetry = (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) || isSyncronizer ?
             isPartialConsumer ?
                 new TelemetryCacheInMemory_1.TelemetryCacheInMemory() :
                 new TelemetryCachePluggable_1.TelemetryCachePluggable(log, keys, wrapper) :
             undefined;
-        var impressionCountsCache = isPartialConsumer ?
-            new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() :
-            new ImpressionCountsCachePluggable_1.ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper);
-        var uniqueKeysCache = isPartialConsumer ?
-            settings.core.key === undefined ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() :
-            new UniqueKeysCachePluggable_1.UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper);
+        var impressionCountsCache = impressionsMode !== constants_1.DEBUG || isSyncronizer ?
+            isPartialConsumer ?
+                new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() :
+                new ImpressionCountsCachePluggable_1.ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper) :
+            undefined;
+        var uniqueKeysCache = impressionsMode === constants_1.NONE || isSyncronizer ?
+            isPartialConsumer ?
+                settings.core.key === undefined ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() :
+                new UniqueKeysCachePluggable_1.UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper) :
+            undefined;
         // Connects to wrapper and emits SDK_READY event on main client
         var connectPromise = wrapper.connect().then(function () {
-            if (isSynchronizer) {
+            if (isSyncronizer) {
                 // In standalone or producer mode, clear storage if SDK key or feature flag filter has changed
                 return wrapper.get(keys.buildHashKey()).then(function (hash) {
                     var currentHash = (0, KeyBuilder_1.getStorageHash)(settings);
@@ -89,9 +93,9 @@ function PluggableStorage(options) {
             }
             else {
                 // Start periodic flush of async storages if not running synchronizer (producer mode)
-                if (impressionCountsCache.start)
+                if (impressionCountsCache && impressionCountsCache.start)
                     impressionCountsCache.start();
-                if (uniqueKeysCache.start)
+                if (uniqueKeysCache && uniqueKeysCache.start)
                     uniqueKeysCache.start();
                 if (telemetry && telemetry.recordConfig)
                     telemetry.recordConfig();
@@ -112,9 +116,9 @@ function PluggableStorage(options) {
             uniqueKeys: uniqueKeysCache,
             // Stop periodic flush and disconnect the underlying storage
             destroy: function () {
-                return Promise.all(isSynchronizer ? [] : [
-                    impressionCountsCache.stop && impressionCountsCache.stop(),
-                    uniqueKeysCache.stop && uniqueKeysCache.stop(),
+                return Promise.all(isSyncronizer ? [] : [
+                    impressionCountsCache && impressionCountsCache.stop && impressionCountsCache.stop(),
+                    uniqueKeysCache && uniqueKeysCache.stop && uniqueKeysCache.stop(),
                 ]).then(function () { return wrapper.disconnect(); });
             },
             // emits SDK_READY event on shared clients and returns a reference to the storage

package/cjs/sync/streaming/pushManager.js

@@ -309,12 +309,14 @@ function pushManagerFactory(params, pollingManager) {
                 // Reconnects in case of a new client.
                 // Run in next event-loop cycle to save authentication calls
                 // in case multiple clients are created in the current cycle.
-                setTimeout(function checkForReconnect() {
-                    if (connectForNewClient) {
-                        connectForNewClient = false;
-                        connectPush();
-                    }
-                }, 0);
+                if (this.isRunning()) {
+                    setTimeout(function checkForReconnect() {
+                        if (connectForNewClient) {
+                            connectForNewClient = false;
+                            connectPush();
+                        }
+                    }, 0);
+                }
             }
         },
         // [Only for client-side]

package/cjs/sync/submitters/impressionCountsSubmitter.js

@@ -30,7 +30,9 @@ var IMPRESSIONS_COUNT_RATE = 1800000; // 30 minutes
  */
 function impressionCountsSubmitterFactory(params) {
     var log = params.settings.log, postTestImpressionsCount = params.splitApi.postTestImpressionsCount, impressionCounts = params.storage.impressionCounts;
-    // retry impressions counts only once.
-    return (0, submitter_1.submitterFactory)(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
+    if (impressionCounts) {
+        // retry impressions counts only once.
+        return (0, submitter_1.submitterFactory)(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
+    }
 }
 exports.impressionCountsSubmitterFactory = impressionCountsSubmitterFactory;

package/cjs/sync/submitters/submitterManager.js

@@ -9,11 +9,14 @@ var uniqueKeysSubmitter_1 = require("./uniqueKeysSubmitter");
 function submitterManagerFactory(params) {
     var submitters = [
         (0, impressionsSubmitter_1.impressionsSubmitterFactory)(params),
-        (0, eventsSubmitter_1.eventsSubmitterFactory)(params),
-        (0, impressionCountsSubmitter_1.impressionCountsSubmitterFactory)(params),
-        (0, uniqueKeysSubmitter_1.uniqueKeysSubmitterFactory)(params)
+        (0, eventsSubmitter_1.eventsSubmitterFactory)(params)
     ];
+    var impressionCountsSubmitter = (0, impressionCountsSubmitter_1.impressionCountsSubmitterFactory)(params);
+    if (impressionCountsSubmitter)
+        submitters.push(impressionCountsSubmitter);
     var telemetrySubmitter = (0, telemetrySubmitter_1.telemetrySubmitterFactory)(params);
+    if (params.storage.uniqueKeys)
+        submitters.push((0, uniqueKeysSubmitter_1.uniqueKeysSubmitterFactory)(params));
     return {
         // `onlyTelemetry` true if SDK is created with userConsent not GRANTED
         start: function (onlyTelemetry) {

package/cjs/sync/syncManagerOnline.js

@@ -118,6 +118,8 @@ function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFactory) {
                 if (!pollingManager)
                     return;
                 var mySegmentsSyncTask = pollingManager.add(matchingKey, readinessManager, storage);
+                if (syncEnabled && pushManager)
+                    pushManager.add(matchingKey, mySegmentsSyncTask);
                 if (running) {
                     if (syncEnabled) {
                         if (pushManager) {
@@ -131,7 +133,6 @@ function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFactory) {
                                 // of segments since `syncAll` was already executed when starting the main client
                                 mySegmentsSyncTask.execute();
                             }
-                            pushManager.add(matchingKey, mySegmentsSyncTask);
                         }
                         else {
                             if (storage.splits.usesSegments())

package/cjs/trackers/eventTracker.js

@@ -25,7 +25,7 @@ function eventTrackerFactory(settings, eventsCache, whenInit, integrationsManage
                 whenInit(function () {
                     // Wrap in a timeout because we don't want it to be blocking.
                     setTimeout(function () {
-                        // copy of event, to avoid unexpected behaviour if modified by integrations
+                        // copy of event, to avoid unexpected behavior if modified by integrations
                         var eventDataCopy = (0, objectAssign_1.objectAssign)({}, eventData);
                         if (properties)
                             eventDataCopy.properties = (0, objectAssign_1.objectAssign)({}, properties);