@spinnaker/google 2026.2.2 → 2026.3.0

package/src/loadBalancer/configure/http/listeners/listener.component.html

@@ -1,245 +0,0 @@
-<hr ng-if="$ctrl.index > 0" />
-<div class="container-fluid form-horizontal">
-  <ng-form name="listener">
-    <div class="modal-body">
-      <div class="form-group">
-        <div
-          class="col-md-12 well"
-          ng-show="listener.stackName.$dirty || listener.detailName.$dirty || !$ctrl.listener.created"
-          ng-class="{
-            'alert-danger': listener.listenerName.$error.validateUnique,
-            'alert-info': !listener.listenerName.$error.validateUnique
-          }"
-        >
-          <strong>Your listener will be named:</strong>
-          <span>{{ $ctrl.getName($ctrl.listener, $ctrl.application.name) }}</span>
-          <!-- Angular does not seem to run length validation on hidden inputs, hence the text + display:none -->
-          <input
-            type="text"
-            style="display: none"
-            ng-maxlength="63"
-            class="form-control input-sm"
-            ng-model="$ctrl.listener.name"
-            ng-readonly="$ctrl.listener.created"
-            validate-unique="$ctrl.existingListenerNames()"
-            validate-ignore-case="true"
-            name="listenerName"
-          />
-          <validation-error
-            ng-if="listener.listenerName.$error.validateUnique || $ctrl.localListenerHasSameName()"
-            message="There is already a listener in {{ $ctrl.command.loadBalancer.credentials }} with that name."
-          >
-          </validation-error>
-        </div>
-
-        <div class="col-md-2 sm-label-right">Stack <help-field key="aws.loadBalancer.stack"></help-field></div>
-        <div class="col-md-3">
-          <input
-            type="text"
-            class="form-control input-sm"
-            ng-model="$ctrl.listener.stack"
-            ng-readonly="$ctrl.listener.created"
-            name="stackName"
-            ng-change="$ctrl.updateName($ctrl.listener, $ctrl.application.name)"
-            ng-pattern="/^[a-z0-9]*$/"
-          />
-        </div>
-        <div class="col-md-2 sm-label-right">Detail <help-field key="gce.loadBalancer.detail"></help-field></div>
-
-        <div class="col-md-3">
-          <input
-            type="text"
-            class="form-control input-sm"
-            ng-model="$ctrl.listener.detail"
-            ng-readonly="$ctrl.listener.created"
-            name="detailName"
-            ng-change="$ctrl.updateName($ctrl.listener, $ctrl.application.name)"
-            ng-pattern="/^[a-z0-9-]*$/"
-          />
-        </div>
-
-        <div class="col-md-1">
-          <button class="btn btn-sm btn-default" ng-click="$ctrl.deleteListener()">
-            <span class="glyphicon glyphicon-trash visible-lg-inline"></span>
-            <span>Delete</span>
-          </button>
-        </div>
-      </div>
-
-      <div class="form-group" ng-if="$ctrl.command.loadBalancer.loadBalancerType === 'INTERNAL_MANAGED'">
-        <div class="col-md-2 sm-label-right">Subnet</div>
-        <div class="col-md-8">
-          <select
-            class="form-control input-sm"
-            ng-model="$ctrl.listener.subnet"
-            ng-disabled="$ctrl.listener.created"
-            ng-required="true"
-          >
-            <option
-              ng-repeat="subnet in $ctrl.getSubnets()"
-              value="{{ subnet }}"
-              ng-selected="$ctrl.listener.subnet === subnet"
-            >
-              {{ subnet }}
-            </option>
-          </select>
-        </div>
-      </div>
-
-      <div class="form-group" ng-if="$ctrl.command.loadBalancer.loadBalancerType === 'INTERNAL_MANAGED'">
-        <div class="col-md-2 sm-label-right">Internal IP</div>
-        <div class="col-md-8">
-          <select
-            class="form-control input-sm"
-            ng-model="$ctrl.listener.ipAddress"
-            ng-disabled="$ctrl.listener.created"
-            ng-required="true"
-          >
-            <option
-              ng-repeat="address in $ctrl.getInternalAddresses()"
-              value="{{ address.address }}"
-              ng-selected="$ctrl.listener.ipAddress === address.address"
-            >
-              {{ address.name }}
-            </option>
-          </select>
-        </div>
-      </div>
-
-      <div class="form-group">
-        <div class="col-md-2 sm-label-right">Port<help-field key="gce.httpLoadBalancer.port"></help-field></div>
-        <div class="col-md-3">
-          <ui-select
-            ng-model="$ctrl.listener.port"
-            ng-disabled="$ctrl.listener.created"
-            ng-change="$ctrl.onPortChanged($ctrl.listener)"
-            required
-            class="form-control input-sm"
-          >
-            <ui-select-match>
-              <span>{{ $select.selected }}</span>
-            </ui-select-match>
-            <ui-select-choices repeat="choice as choice in [8080, 80, 443]">
-              <span>{{ choice }}</span>
-            </ui-select-choices>
-          </ui-select>
-        </div>
-      </div>
-      <!-- Certificate controls on a separate row to avoid exceeding Bootstrap's 12-column
-           grid when cert-source radios are visible (Port 2+3 + CertSrc 2+3 + Cert 2+3+1 = 16). -->
-      <div class="form-group" ng-if="$ctrl.isHttps($ctrl.listener.port)">
-        <div class="col-md-2 sm-label-right" ng-if="$ctrl.supportsCertificateMap()">Certificate Source</div>
-        <div class="col-md-3" ng-if="$ctrl.supportsCertificateMap()">
-          <label class="radio-inline">
-            <input
-              type="radio"
-              ng-model="$ctrl.listener.certificateSource"
-              value="certificate"
-              ng-change="$ctrl.onCertificateSourceChanged($ctrl.listener)"
-            />
-            Certificate
-          </label>
-          <label class="radio-inline">
-            <input
-              type="radio"
-              ng-model="$ctrl.listener.certificateSource"
-              value="certificateMap"
-              ng-change="$ctrl.onCertificateSourceChanged($ctrl.listener)"
-            />
-            Certificate Map
-          </label>
-        </div>
-        <div class="col-md-2 sm-label-right">
-          <span ng-if="$ctrl.listener.certificateSource !== 'certificateMap'">Certificate</span>
-          <span ng-if="$ctrl.listener.certificateSource === 'certificateMap'">Certificate Map</span>
-          <help-field
-            ng-if="$ctrl.listener.certificateSource !== 'certificateMap'"
-            key="gce.httpLoadBalancer.certificate"
-            class="help-field-absolute"
-          ></help-field>
-          <help-field
-            ng-if="$ctrl.listener.certificateSource === 'certificateMap'"
-            key="gce.httpLoadBalancer.certificateMap"
-            class="help-field-absolute"
-          ></help-field>
-        </div>
-        <div class="col-md-3" ng-if="$ctrl.listener.certificateSource !== 'certificateMap'">
-          <ui-select
-            ng-model="$ctrl.listener.certificate"
-            ng-change="$ctrl.onCertificateSelected($ctrl.listener)"
-            ng-required="$ctrl.isHttps($ctrl.listener.port) && $ctrl.listener.certificateSource !== 'certificateMap'"
-            class="form-control input-sm"
-          >
-            <ui-select-match allow-clear placeholder="Select...">{{ $select.selected }}</ui-select-match>
-            <ui-select-choices repeat="certificate in $ctrl.getCertificates() | filter: $select.search">
-              <span ng-bind-html="certificate | highlight: $select.search"></span>
-            </ui-select-choices>
-          </ui-select>
-        </div>
-        <div class="col-md-3" ng-if="$ctrl.listener.certificateSource === 'certificateMap'">
-          <input
-            type="text"
-            class="form-control input-sm"
-            name="certificateMap"
-            ng-model="$ctrl.listener.certificateMap"
-            ng-change="$ctrl.onCertificateMapChanged($ctrl.listener)"
-            ng-required="$ctrl.isHttps($ctrl.listener.port) && $ctrl.listener.certificateSource === 'certificateMap'"
-            ng-pattern="$ctrl.certificateMapPattern"
-            placeholder="certificate-map-name"
-          />
-        </div>
-        <div
-          class="col-md-1"
-          style="padding-left: 0; margin-top: 4px"
-          ng-if="$ctrl.listener.certificateSource !== 'certificateMap'"
-        >
-          <gce-cache-refresh
-            cache-key="certificates"
-            render-compact="true"
-            on-refresh="$ctrl.command.onCertificateRefresh($ctrl.command)"
-          ></gce-cache-refresh>
-        </div>
-      </div>
-
-      <div class="form-group" ng-if="$ctrl.command.loadBalancer.loadBalancerType === 'HTTP'">
-        <div class="col-md-2 sm-label-right">
-          External IP
-          <help-field key="gce.httpLoadBalancer.externalIP" class="help-field-absolute"></help-field>
-        </div>
-        <div class="col-md-5">
-          <gce-address-selector
-            address-list="$ctrl.command.backingData.addresses"
-            read-only="$ctrl.listener.created"
-            account="$ctrl.command.loadBalancer.credentials"
-            initial-ip-address="$ctrl.listener.ipAddress"
-            on-address-select="$ctrl.onAddressSelect(address)"
-          ></gce-address-selector>
-        </div>
-        <div class="col-md-1" style="padding-left: 0; margin-top: 4px">
-          <gce-cache-refresh
-            ng-if="!$ctrl.listener.created"
-            cache-key="addresses"
-            render-compact="true"
-            on-refresh="$ctrl.command.onAddressRefresh($ctrl.command)"
-          ></gce-cache-refresh>
-        </div>
-      </div>
-
-      <div class="form-group">
-        <div class="col-md-7 col-md-offset-2" ng-if="listener.stackName.$error.pattern">
-          <validation-error message="Stack can only contain lowercase letters and numbers."></validation-error>
-        </div>
-        <div class="col-md-7 col-md-offset-2" ng-if="listener.detailName.$error.pattern">
-          <validation-error
-            message="Detail can only contain lowercase letters, numbers, and dashes(-)."
-          ></validation-error>
-        </div>
-        <div class="col-md-7 col-md-offset-2" ng-if="listener.certificateMap.$error.pattern">
-          <validation-error
-            message="Certificate map can only contain lowercase letters, numbers, and dashes(-), and must start with a letter."
-          ></validation-error>
-        </div>
-      </div>
-    </div>
-  </ng-form>
-</div>

package/src/loadBalancer/configure/http/listeners/listener.component.js

@@ -1,164 +0,0 @@
-'use strict';
-
-import { module } from 'angular';
-import _ from 'lodash';
-
-import { GCE_ADDRESS_SELECTOR } from '../../common/addressSelector.component';
-
-export const GOOGLE_LOADBALANCER_CONFIGURE_HTTP_LISTENERS_LISTENER_COMPONENT =
-  'spinnaker.deck.gce.httpLoadBalancer.listener.component';
-export const name = GOOGLE_LOADBALANCER_CONFIGURE_HTTP_LISTENERS_LISTENER_COMPONENT; // for backwards compatibility
-module(GOOGLE_LOADBALANCER_CONFIGURE_HTTP_LISTENERS_LISTENER_COMPONENT, [GCE_ADDRESS_SELECTOR]).component(
-  'gceListener',
-  {
-    bindings: {
-      command: '=',
-      listener: '=',
-      deleteListener: '&',
-      index: '=',
-      application: '=',
-    },
-    templateUrl: require('./listener.component.html'),
-    controller: function () {
-      this.$onInit = () => {
-        this.certificates = this.command.backingData.certificates;
-        const loadBalancerMap = this.command.backingData.loadBalancerMap;
-
-        this.getName = (listener, applicationName) => {
-          const listenerName = [applicationName, listener.stack || '', listener.detail || ''].join('-');
-          return _.trimEnd(listenerName, '-');
-        };
-
-        this.getCertificates = () => {
-          return this.command.backingData.certificates
-            .filter((certificate) => certificate.account === this.command.loadBalancer.credentials)
-            .map((certificate) => certificate.name);
-        };
-
-        this.getSubnets = () => {
-          const ret = this.command.backingData.subnetMap[this.command.loadBalancer.network]
-            .filter((subnet) => subnet.region === this.command.loadBalancer.region)
-            .map((subnet) => subnet.name);
-          return _.uniq(ret);
-        };
-
-        this.getInternalAddresses = () => {
-          return this.command.backingData.addresses.filter(
-            (address) =>
-              address.addressType === 'INTERNAL' && address.subnetwork.split('/').pop() === this.listener.subnet,
-          );
-        };
-
-        this.updateName = (listener, appName) => {
-          listener.name = this.getName(listener, appName);
-        };
-
-        this.localListenerHasSameName = () => {
-          return (
-            this.command.loadBalancer.listeners.filter((listener) => listener.name === this.listener.name).length > 1
-          );
-        };
-
-        this.existingListenerNames = () => {
-          return _.get(loadBalancerMap, [this.command.loadBalancer.credentials, 'listeners']);
-        };
-
-        this.isHttps = (port) => port === 443 || port === '443';
-        // certificateMap writes are only supported on global external/classic HTTPS proxies (HTTP
-        // type). INTERNAL_MANAGED regional proxies do not support certificateMap per GCP docs.
-        this.supportsCertificateMap = () => this.command.loadBalancer.loadBalancerType === 'HTTP';
-        this.certificateMapPattern = /^[a-z]([-a-z0-9]*[a-z0-9])?$/;
-        // Extracts the short resource name from a certificateMap value. Users may paste a full
-        // Certificate Manager URL (e.g. //certificatemanager.googleapis.com/projects/p/locations/
-        // global/certificateMaps/my-map); only the last path segment (the map name) is stored.
-        // The server reconstructs the full URL using GCEUtil.buildCertificateMapUrl.
-        this.getCertificateMapName = (certificateMap) => {
-          if (!_.isString(certificateMap)) {
-            return certificateMap;
-          }
-          const normalized = certificateMap.trim();
-          return normalized ? _.last(normalized.split('/')) : normalized;
-        };
-
-        // Reconcile the XOR between certificate and certificateMap on a listener. Ensures only
-        // one is active at a time. Also infers certificateSource for existing listeners that were
-        // created before the certificateSource field existed (backward compat).
-        this.syncCertificateState = (listener) => {
-          if (!this.supportsCertificateMap()) {
-            listener.certificateSource = 'certificate';
-            listener.certificateMap = null;
-            return;
-          }
-
-          if (!listener.certificateSource) {
-            listener.certificateSource = listener.certificateMap ? 'certificateMap' : 'certificate';
-          }
-
-          if (listener.certificateSource === 'certificateMap') {
-            listener.certificate = null;
-            if (_.isString(listener.certificateMap)) {
-              listener.certificateMap = this.getCertificateMapName(listener.certificateMap);
-            }
-          } else {
-            listener.certificateMap = null;
-          }
-        };
-
-        this.onCertificateSourceChanged = (listener) => {
-          if (!this.supportsCertificateMap()) {
-            listener.certificateSource = 'certificate';
-            listener.certificateMap = null;
-            return;
-          }
-
-          if (listener.certificateSource === 'certificateMap') {
-            listener.certificate = null;
-          } else {
-            listener.certificateMap = null;
-          }
-        };
-
-        this.onCertificateSelected = (listener) => {
-          if (listener.certificate) {
-            listener.certificateSource = 'certificate';
-            listener.certificateMap = null;
-          }
-        };
-
-        this.onCertificateMapChanged = (listener) => {
-          if (_.isString(listener.certificateMap)) {
-            listener.certificateMap = this.getCertificateMapName(listener.certificateMap);
-          }
-          if (listener.certificateMap) {
-            listener.certificateSource = 'certificateMap';
-            listener.certificate = null;
-          }
-        };
-
-        this.onPortChanged = (listener) => {
-          if (!this.isHttps(listener.port)) {
-            listener.certificate = null;
-            listener.certificateMap = null;
-            listener.certificateSource = 'certificate';
-          } else {
-            this.syncCertificateState(listener);
-          }
-        };
-
-        if (!this.listener.name) {
-          this.updateName(this.listener, this.application.name);
-        }
-
-        this.onPortChanged(this.listener);
-
-        this.onAddressSelect = (address) => {
-          if (address) {
-            this.listener.ipAddress = address.address;
-          } else {
-            this.listener.ipAddress = null;
-          }
-        };
-      };
-    },
-  },
-);

package/src/loadBalancer/configure/http/listeners/listener.component.spec.js

@@ -1,125 +0,0 @@
-import { mock } from 'angular';
-
-describe('Component: gceListener', () => {
-  let $componentController;
-
-  beforeEach(mock.module(require('./listener.component').name));
-
-  beforeEach(
-    mock.inject((_$componentController_) => {
-      $componentController = _$componentController_;
-    }),
-  );
-
-  function buildBindings(listenerOverrides = {}, loadBalancerOverrides = {}) {
-    return {
-      command: {
-        backingData: {
-          certificates: [],
-          loadBalancerMap: {},
-          subnetMap: { default: [] },
-          addresses: [],
-        },
-        loadBalancer: {
-          credentials: 'test-account',
-          loadBalancerType: 'HTTP',
-          network: 'default',
-          region: 'us-central1',
-          ...loadBalancerOverrides,
-        },
-      },
-      listener: {
-        name: 'app-main',
-        port: 443,
-        certificate: null,
-        certificateMap: null,
-        created: false,
-        ...listenerOverrides,
-      },
-      deleteListener: () => {},
-      index: 0,
-      application: { name: 'app' },
-    };
-  }
-
-  function buildController(listenerOverrides = {}, loadBalancerOverrides = {}) {
-    const ctrl = $componentController('gceListener', {}, buildBindings(listenerOverrides, loadBalancerOverrides));
-    ctrl.$onInit();
-    return ctrl;
-  }
-
-  it('clears certificate when switching to certificateMap source', () => {
-    const ctrl = buildController({ certificate: 'legacy-cert', certificateSource: 'certificate' });
-
-    ctrl.listener.certificateSource = 'certificateMap';
-    ctrl.onCertificateSourceChanged(ctrl.listener);
-
-    expect(ctrl.listener.certificate).toBeNull();
-  });
-
-  it('clears certificateMap when switching to certificate source', () => {
-    const ctrl = buildController({
-      certificate: null,
-      certificateMap: 'cm',
-      certificateSource: 'certificateMap',
-    });
-
-    ctrl.listener.certificateSource = 'certificate';
-    ctrl.onCertificateSourceChanged(ctrl.listener);
-
-    expect(ctrl.listener.certificateMap).toBeNull();
-  });
-
-  it('forces certificate source for internal managed load balancers', () => {
-    const ctrl = buildController(
-      {
-        certificateMap: 'cm',
-        certificateSource: 'certificateMap',
-      },
-      { loadBalancerType: 'INTERNAL_MANAGED' },
-    );
-
-    expect(ctrl.listener.certificateSource).toBe('certificate');
-    expect(ctrl.listener.certificateMap).toBeNull();
-  });
-
-  it('clears cert fields when listener port changes away from HTTPS', () => {
-    const ctrl = buildController({
-      certificate: 'legacy-cert',
-      certificateMap: 'cm',
-      certificateSource: 'certificateMap',
-    });
-
-    ctrl.listener.port = 80;
-    ctrl.onPortChanged(ctrl.listener);
-
-    expect(ctrl.listener.certificate).toBeNull();
-    expect(ctrl.listener.certificateMap).toBeNull();
-    expect(ctrl.listener.certificateSource).toBe('certificate');
-  });
-
-  it('normalizes certificateMap URLs to map names', () => {
-    const ctrl = buildController({
-      certificate: null,
-      certificateMap: '//certificatemanager.googleapis.com/projects/p/locations/global/certificateMaps/cm',
-      certificateSource: 'certificateMap',
-    });
-
-    expect(ctrl.listener.certificateMap).toBe('cm');
-  });
-
-  it('validates certificateMap names with expected regex edge cases', () => {
-    const ctrl = buildController();
-
-    const validNames = ['a', 'my-map', 'm1', 'map-123', 'a-b-c-1'];
-    const invalidNames = ['', '1map', '-map', 'map-', 'map_name', 'map.name', 'Map'];
-
-    validNames.forEach((name) => {
-      expect(ctrl.certificateMapPattern.test(name)).toBe(true);
-    });
-
-    invalidNames.forEach((name) => {
-      expect(ctrl.certificateMapPattern.test(name)).toBe(false);
-    });
-  });
-});

package/src/loadBalancer/configure/http/listeners/listeners.html

@@ -1,17 +0,0 @@
-<ng-form name="listeners">
-  <gce-listener
-    command="ctrl.command"
-    delete-listener="ctrl.remove('listeners', $index)"
-    index="$index"
-    application="ctrl.application"
-    listener="listener"
-    ng-repeat="listener in ctrl.command.loadBalancer.listeners"
-  ></gce-listener>
-  <div class="row">
-    <div class="col-md-12">
-      <button class="add-new btn btn-block" ng-click="ctrl.add('listeners')">
-        <span class="glyphicon glyphicon-plus-sign"></span> Add listener
-      </button>
-    </div>
-  </div>
-</ng-form>

package/src/loadBalancer/configure/http/pathRule/pathRule.component.html

@@ -1,51 +0,0 @@
-<hr />
-<div class="form-group">
-  <div class="col-md-4 sm-label-right">
-    Paths
-    <help-field key="gce.httpLoadBalancer.pathRule.paths"> </help-field>
-  </div>
-  <div class="col-md-4">
-    <ui-select
-      multiple
-      tagging
-      tagging-label=""
-      ng-model="$ctrl.pathRule.paths"
-      sortable="true"
-      class="form-control input-sm"
-      required
-    >
-      <ui-select-match>{{ $item }}</ui-select-match>
-      <ui-select-choices repeat="path in []">
-        {{ path }}
-      </ui-select-choices>
-    </ui-select>
-  </div>
-  <div class="col-md-1">
-    <button class="btn btn-sm btn-default" ng-click="$ctrl.deletePathRule()">
-      <span class="glyphicon glyphicon-trash visible-lg-inline"></span>
-      <span>Delete</span>
-    </button>
-  </div>
-</div>
-
-<div class="form-group">
-  <div class="col-md-4 sm-label-right">
-    <b>Backend Service</b>
-  </div>
-  <div class="col-md-4">
-    <ui-select
-      ng-model="$ctrl.pathRule.backendService"
-      on-select="$ctrl.command.onBackendServiceSelected($item, $ctrl.command)"
-      class="form-control input-sm"
-    >
-      <ui-select-match placeholder="Select...">
-        {{ $select.selected }}
-      </ui-select-match>
-      <ui-select-choices
-        repeat="backendService in $ctrl.command.getAllBackendServices($ctrl.command) | filter: $select.search"
-      >
-        <div ng-bind-html="backendService | highlight: $select.search"></div>
-      </ui-select-choices>
-    </ui-select>
-  </div>
-</div>

package/src/loadBalancer/configure/http/pathRule/pathRule.component.js

@@ -1,16 +0,0 @@
-'use strict';
-
-import { module } from 'angular';
-
-export const GOOGLE_LOADBALANCER_CONFIGURE_HTTP_PATHRULE_PATHRULE_COMPONENT =
-  'spinnaker.deck.gce.httpLoadBalancer.pathRule.component';
-export const name = GOOGLE_LOADBALANCER_CONFIGURE_HTTP_PATHRULE_PATHRULE_COMPONENT; // for backwards compatibility
-module(GOOGLE_LOADBALANCER_CONFIGURE_HTTP_PATHRULE_PATHRULE_COMPONENT, []).component('gcePathRule', {
-  bindings: {
-    pathRule: '=',
-    command: '=',
-    index: '=',
-    deletePathRule: '&',
-  },
-  templateUrl: require('./pathRule.component.html'),
-});