@spinnaker/google 2026.2.2 → 2026.3.0

package/src/loadBalancer/configure/common/commonCreateLoadBalancer.html

@@ -1,41 +0,0 @@
-<form name="form" class="form-horizontal">
-  <div ng-if="!ctrl.accounts" style="height: 200px" class="horizontal center middle">
-    <loading-spinner size="'small'"></loading-spinner>
-  </div>
-  <v2-modal-wizard
-    heading="Create New Load Balancer"
-    ng-if="ctrl.accounts"
-    task-monitor="ctrl.taskMonitor"
-    dismiss="$dismiss()"
-  >
-    <v2-wizard-page key="location" label="Location" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.location"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page key="listener" label="Listener" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.listener"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page
-      key="backendService"
-      label="Backend Service"
-      ng-if="ctrl.hasBackendService"
-      mark-complete-on-view="false"
-    >
-      <ng-include src="ctrl.pages.backendService"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page key="healthCheck" label="Health Check" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.healthCheck"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page key="advancedSettings" label="Advanced Settings" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.advancedSettings"></ng-include>
-    </v2-wizard-page>
-  </v2-modal-wizard>
-  <div class="modal-footer">
-    <button ng-disabled="ctrl.taskMonitor.submitting" class="btn btn-default" ng-click="ctrl.cancel()">Cancel</button>
-    <submit-button
-      is-disabled="form.$invalid || ctrl.taskMonitor.submitting"
-      submitting="ctrl.taskMonitor.submitting"
-      on-click="ctrl.submit()"
-      is-new="ctrl.isNew"
-    ></submit-button>
-  </div>
-</form>

package/src/loadBalancer/configure/common/commonEditLoadBalancer.html

@@ -1,38 +0,0 @@
-<form name="form" class="form-horizontal">
-  <div ng-if="!ctrl.accounts" style="height: 200px" class="horizontal center middle">
-    <loading-spinner size="'small'"></loading-spinner>
-  </div>
-  <v2-modal-wizard
-    heading="Edit {{ctrl.loadBalancer.name}}: {{ctrl.loadBalancer.region}}: {{ctrl.loadBalancer.credentials}}"
-    ng-if="ctrl.accounts"
-    task-monitor="ctrl.taskMonitor"
-    dismiss="$dismiss()"
-  >
-    <v2-wizard-page key="listener" label="Listener" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.listener"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page
-      key="backendService"
-      label="Backend Service"
-      ng-if="ctrl.hasBackendService"
-      mark-complete-on-view="false"
-    >
-      <ng-include src="ctrl.pages.backendService"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page key="healthCheck" label="Health Check" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.healthCheck"></ng-include>
-    </v2-wizard-page>
-    <v2-wizard-page key="advancedSettings" label="Advanced Settings" mark-complete-on-view="false">
-      <ng-include src="ctrl.pages.advancedSettings"></ng-include>
-    </v2-wizard-page>
-  </v2-modal-wizard>
-  <div class="modal-footer">
-    <button ng-disabled="taskMonitor.submitting" class="btn btn-default" ng-click="ctrl.cancel()">Cancel</button>
-    <submit-button
-      is-disabled="form.$invalid || ctrl.taskMonitor.submitting"
-      submitting="ctrl.taskMonitor.submitting"
-      on-click="ctrl.submit()"
-      is-new="ctrl.isNew"
-    ></submit-button>
-  </div>
-</form>

package/src/loadBalancer/configure/common/commonHealthCheckPage.html

@@ -1,16 +0,0 @@
-<gce-health-check-selector
-  health-checks-by-account-and-type="ctrl.healthChecksByAccountAndType"
-  existing-health-check-names="ctrl.existingHealthCheckNames"
-  credentials="ctrl.loadBalancer.credentials"
-  health-check="ctrl.loadBalancer.backendService.healthCheck"
-></gce-health-check-selector>
-
-<div class="form-group small" style="margin-top: 20px">
-  <div class="col-md-offset-2 col-md-6">
-    <gce-cache-refresh
-      cache-key="healthChecks"
-      cache-key-alias="health checks"
-      on-refresh="ctrl.onHealthCheckRefresh()"
-    ></gce-cache-refresh>
-  </div>
-</div>

package/src/loadBalancer/configure/common/commonLoadBalancer.controller.ts

@@ -1,56 +0,0 @@
-import type { StateService } from '@uirouter/angularjs';
-import type { IScope } from 'angular';
-import type { IModalInstanceService } from 'angular-ui-bootstrap';
-import { trimEnd } from 'lodash';
-
-import type { Application } from '@spinnaker/core';
-import { InfrastructureCaches } from '@spinnaker/core';
-import type { IGceLoadBalancer } from '../../../domain/loadBalancer';
-
-export class CommonGceLoadBalancerCtrl {
-  public static $inject = ['$scope', 'application', '$uibModalInstance', '$state'];
-  constructor(
-    public $scope: IScope,
-    public application: Application,
-    public $uibModalInstance: IModalInstanceService,
-    private $state: StateService,
-  ) {}
-
-  public onTaskComplete(loadBalancer: IGceLoadBalancer): void {
-    InfrastructureCaches.clearCache('healthChecks');
-    this.application.getDataSource('loadBalancers').refresh();
-    this.application
-      .getDataSource('loadBalancers')
-      .onNextRefresh(this.$scope, () => this.onApplicationRefresh(loadBalancer));
-  }
-
-  public cancel(): void {
-    this.$uibModalInstance.dismiss();
-  }
-
-  public getName(lb: IGceLoadBalancer, application: Application): string {
-    const loadBalancerName = [application.name, lb.stack || '', lb.detail || ''].join('-');
-    return trimEnd(loadBalancerName, '-');
-  }
-
-  private onApplicationRefresh(loadBalancer: IGceLoadBalancer): void {
-    // If the user has already closed the modal, do not navigate to the new details view
-    if (this.$scope.$$destroyed) {
-      return;
-    }
-    this.$uibModalInstance.close();
-
-    const newStateParams = {
-      name: loadBalancer.loadBalancerName,
-      accountId: loadBalancer.credentials,
-      region: loadBalancer.region,
-      provider: 'gce',
-    };
-
-    if (!this.$state.includes('**.loadBalancerDetails')) {
-      this.$state.go('.loadBalancerDetails', newStateParams);
-    } else {
-      this.$state.go('^.loadBalancerDetails', newStateParams);
-    }
-  }
-}

package/src/loadBalancer/configure/common/commonLoadBalancerCommandBuilder.service.ts

@@ -1,87 +0,0 @@
-import { module } from 'angular';
-import _ from 'lodash';
-
-import type { IAccount, ILoadBalancersByAccount, INetwork, ISubnet, LoadBalancerReader } from '@spinnaker/core';
-import { AccountService, LOAD_BALANCER_READ_SERVICE, NetworkReader, SubnetReader } from '@spinnaker/core';
-import type { GceCertificateReader, IGceCertificate } from '../../../certificate/certificate.reader';
-import { GCE_CERTIFICATE_READER } from '../../../certificate/certificate.reader';
-import type { IGceHealthCheck } from '../../../domain/healthCheck';
-import type { GceHealthCheckReader } from '../../../healthCheck/healthCheck.read.service';
-import { GCE_HEALTH_CHECK_READER } from '../../../healthCheck/healthCheck.read.service';
-
-export class GceCommonLoadBalancerCommandBuilder {
-  private dataFetchers: { [key: string]: Function } = {
-    existingLoadBalancerNamesByAccount: (): PromiseLike<_.Dictionary<any>> => {
-      return this.loadBalancerReader.listLoadBalancers('gce').then((loadBalancerList: ILoadBalancersByAccount[]) => {
-        return _.chain(loadBalancerList)
-          .map('accounts')
-          .flatten()
-          .groupBy('name') // account name
-          .mapValues((regionWrappers) =>
-            _.chain(regionWrappers)
-              .map('regions')
-              .flatten()
-              .map('loadBalancers')
-              .flatten()
-              .map('name') // load balancer name
-              .value(),
-          )
-          .value();
-      });
-    },
-    accounts: (): PromiseLike<IAccount[]> => AccountService.listAccounts('gce'),
-    networks: (): PromiseLike<INetwork[]> => NetworkReader.listNetworksByProvider('gce'),
-    subnets: (): PromiseLike<ISubnet[]> => SubnetReader.listSubnetsByProvider('gce'),
-    healthChecks: (): PromiseLike<IGceHealthCheck[]> => this.gceHealthCheckReader.listHealthChecks(),
-    certificates: (): PromiseLike<IGceCertificate[]> => this.gceCertificateReader.listCertificates(),
-  };
-
-  public static $inject = ['$q', 'loadBalancerReader', 'gceHealthCheckReader', 'gceCertificateReader'];
-  constructor(
-    private $q: ng.IQService,
-    private loadBalancerReader: LoadBalancerReader,
-    private gceHealthCheckReader: GceHealthCheckReader,
-    private gceCertificateReader: GceCertificateReader,
-  ) {}
-
-  public getBackingData(dataTypes: string[]): PromiseLike<any> {
-    const promises = dataTypes.reduce(
-      (promisesByDataType: { [dataType: string]: PromiseLike<any> }, dataType: string) => {
-        if (this.dataFetchers[dataType]) {
-          promisesByDataType[dataType] = this.dataFetchers[dataType]();
-        }
-        return promisesByDataType;
-      },
-      {},
-    );
-
-    return this.$q.all(promises);
-  }
-
-  public groupHealthChecksByAccountAndType(
-    healthChecks: IGceHealthCheck[],
-  ): { [account: string]: { [healthCheckType: string]: IGceHealthCheck[] } } {
-    return _.chain(healthChecks)
-      .groupBy('account')
-      .mapValues((grouped: IGceHealthCheck[]) => _.groupBy(grouped, 'healthCheckType'))
-      .value();
-  }
-
-  public groupHealthCheckNamesByAccount(
-    healthChecks: IGceHealthCheck[],
-    namesToOmit: string[],
-  ): { [account: string]: string[] } {
-    return _.chain(healthChecks)
-      .groupBy('account')
-      .mapValues((grouped: IGceHealthCheck[]) => _.chain(grouped).map('name').difference(namesToOmit).value())
-      .value() as { [account: string]: string[] };
-  }
-}
-
-export const GCE_COMMON_LOAD_BALANCER_COMMAND_BUILDER = 'spinnaker.gce.commonLoadBalancerCommandBuilder.service';
-
-module(GCE_COMMON_LOAD_BALANCER_COMMAND_BUILDER, [
-  LOAD_BALANCER_READ_SERVICE,
-  GCE_CERTIFICATE_READER,
-  GCE_HEALTH_CHECK_READER,
-]).service('gceCommonLoadBalancerCommandBuilder', GceCommonLoadBalancerCommandBuilder);

package/src/loadBalancer/configure/common/healthCheck.component.html

@@ -1,179 +0,0 @@
-<ng-form name="healthCheckForm" novalidate>
-  <div class="container-fluid form-horizontal">
-    <div class="form-group">
-      <div class="col-md-12 well alert-danger" ng-if="healthCheckForm.healthCheckName.$error.validateUnique">
-        <validation-error message="There is already a health check with that name."></validation-error>
-      </div>
-      <div
-        class="col-md-12 well alert-danger"
-        ng-if="healthCheckForm.healthCheckName.$error.pattern || healthCheckForm.healthCheckName.$error.max"
-      >
-        <validation-error
-          message="Name must start with a lowercase letter followed by up to 62 lowercase letters,
-                   numbers, or hyphens, and cannot end with a hyphen."
-        >
-        </validation-error>
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">Protocol</div>
-      <div class="col-md-4">
-        <select
-          class="form-control input-sm"
-          ng-change="$ctrl.onProtocolChange()"
-          ng-options="protocol as protocol for protocol in ['HTTP', 'HTTPS', 'TCP', 'SSL', 'HTTP2', 'GRPC']"
-          ng-model="$ctrl.healthCheck.healthCheckType"
-        ></select>
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">Name</div>
-
-      <div class="col-md-4" ng-if="$ctrl.editExisting">
-        <ui-select
-          ng-model="$ctrl.healthCheckPlaceholder"
-          on-select="$ctrl.onHealthCheckSelect($item)"
-          class="form-control input-sm"
-        >
-          <ui-select-match placeholder="Select...">
-            {{ $select.selected.name }}
-          </ui-select-match>
-          <ui-select-choices
-            repeat="healthCheck in $ctrl.existingHealthChecksForProtocol | filter: {name: $select.search}"
-          >
-            <div ng-bind-html="healthCheck.name | highlight: $select.search"></div>
-          </ui-select-choices>
-        </ui-select>
-      </div>
-      <div class="col-md-4" ng-if="!$ctrl.editExisting">
-        <input
-          class="form-control input-sm"
-          novalidate
-          type="text"
-          ng-pattern="/^[a-z]([-a-z0-9]*[a-z0-9])?$/"
-          name="healthCheckName"
-          max="63"
-          required
-          validate-unique="$ctrl.existingHealthCheckNames"
-          ng-model-options="{ debounce: 250 }"
-          ng-change="$ctrl.onHealthCheckNameChange($ctrl.healthCheckPlaceholder.name)"
-          ng-model="$ctrl.healthCheckPlaceholder.name"
-        />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-6 col-md-offset-4">
-        <a href class="small" ng-if="!$ctrl.editExisting" ng-click="$ctrl.toggleEditExisting()"
-          >Toggle for list of existing health checks</a
-        >
-        <a href class="small" ng-if="$ctrl.editExisting" ng-click="$ctrl.toggleEditExisting()">Toggle for text input</a>
-      </div>
-    </div>
-
-    <div
-      class="form-group"
-      ng-if="
-        $ctrl.healthCheck.healthCheckType === 'HTTP' ||
-        $ctrl.healthCheck.healthCheckType === 'HTTPS' ||
-        $ctrl.healthCheck.healthCheckType === 'HTTP2'
-      "
-    >
-      <div class="col-md-4 sm-label-right">Request Path</div>
-      <div class="col-md-4">
-        <input class="form-control input-sm" required ng-model="$ctrl.healthCheck.requestPath" />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">Port</div>
-      <div class="col-md-4">
-        <input
-          type="number"
-          class="form-control input-sm"
-          required
-          min="1"
-          max="65535"
-          ng-model="$ctrl.healthCheck.port"
-        />
-      </div>
-    </div>
-
-    <div class="form-group" ng-if="$ctrl.healthCheck.healthCheckType === 'GRPC'">
-      <div class="col-md-4 sm-label-right">Service Name</div>
-      <div class="col-md-4">
-        <input
-          class="form-control input-sm"
-          ng-model="$ctrl.healthCheck.grpcServiceName"
-          placeholder="com.example.HealthService"
-        />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">
-        <b>Timeout</b><help-field key="loadBalancer.advancedSettings.healthTimeout"></help-field>
-      </div>
-      <div class="col-md-4">
-        <input
-          class="form-control input-sm"
-          type="number"
-          min="0"
-          max="{{:: $ctrl.max}}"
-          required
-          ng-model="$ctrl.healthCheck.timeoutSec"
-        />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">
-        <b>Interval</b><help-field key="gce.loadBalancer.advancedSettings.healthInterval"></help-field>
-      </div>
-      <div class="col-md-4">
-        <input
-          class="form-control input-sm"
-          type="number"
-          min="0"
-          max="{{:: $ctrl.max}}"
-          required
-          ng-model="$ctrl.healthCheck.checkIntervalSec"
-        />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">
-        <b>Healthy Threshold</b><help-field key="gce.loadBalancer.advancedSettings.healthyThreshold"></help-field>
-      </div>
-      <div class="col-md-4">
-        <input
-          class="form-control input-sm"
-          type="number"
-          min="0"
-          max="{{:: $ctrl.max}}"
-          required
-          ng-model="$ctrl.healthCheck.healthyThreshold"
-        />
-      </div>
-    </div>
-
-    <div class="form-group">
-      <div class="col-md-4 sm-label-right">
-        <b>Unhealthy Threshold</b><help-field key="gce.loadBalancer.advancedSettings.unhealthyThreshold"></help-field>
-      </div>
-      <div class="col-md-4">
-        <input
-          class="form-control input-sm"
-          type="number"
-          min="0"
-          max="{{:: $ctrl.max}}"
-          required
-          ng-model="$ctrl.healthCheck.unhealthyThreshold"
-        />
-      </div>
-    </div>
-  </div>
-</ng-form>

package/src/loadBalancer/configure/common/healthCheck.component.ts

@@ -1,82 +0,0 @@
-import type { IController } from 'angular';
-import { module } from 'angular';
-import { get } from 'lodash';
-
-import type { IGceHealthCheck } from '../../../domain/index';
-
-class HealthCheckCreateCtrl implements IController {
-  public healthCheck: IGceHealthCheck;
-  public healthCheckPlaceholder: IGceHealthCheck;
-  public healthChecksByAccountAndType: { [account: string]: { [healthCheckType: string]: IGceHealthCheck[] } };
-  public editExisting = false;
-  public existingHealthChecksForProtocol: IGceHealthCheck[];
-  public existingHealthCheckNames: string[];
-  public credentials: string;
-  public max = Number.MAX_SAFE_INTEGER;
-
-  public static $inject = ['$scope'];
-  constructor(private $scope: ng.IScope) {}
-
-  public $onInit(): void {
-    if (this.healthCheck.name) {
-      this.healthCheckPlaceholder = this.healthCheck;
-      this.existingHealthChecksForProtocol = this.healthChecksByAccountAndType[this.credentials][
-        this.healthCheck.healthCheckType
-      ];
-      this.editExisting = true;
-    } else {
-      this.existingHealthChecksForProtocol = this.healthChecksByAccountAndType[this.credentials]['TCP'];
-    }
-
-    this.$scope.$watch('$ctrl.credentials', () => this.setExistingHealthChecksForProtocol());
-  }
-
-  public onProtocolChange(): void {
-    delete this.healthCheck.name;
-    delete this.healthCheckPlaceholder;
-    this.setExistingHealthChecksForProtocol();
-  }
-
-  public setExistingHealthChecksForProtocol() {
-    this.existingHealthChecksForProtocol =
-      get<{}, IGceHealthCheck[]>(this, [
-        'healthChecksByAccountAndType',
-        this.credentials,
-        this.healthCheck.healthCheckType,
-      ]) || [];
-
-    if (!this.existingHealthChecksForProtocol.find((healthCheck) => healthCheck.name === this.healthCheck.name)) {
-      delete this.healthCheck.name;
-      delete this.healthCheckPlaceholder;
-    }
-  }
-
-  public toggleEditExisting(): void {
-    this.editExisting = !this.editExisting;
-    delete this.healthCheck.name;
-    delete this.healthCheckPlaceholder;
-  }
-
-  public onHealthCheckSelect(selectedHealthCheck: IGceHealthCheck): void {
-    Object.assign(this.healthCheck, selectedHealthCheck);
-  }
-
-  public onHealthCheckNameChange(typedName: string): void {
-    this.healthCheck.name = typedName;
-  }
-}
-
-const healthCheckCreateComponent: ng.IComponentOptions = {
-  bindings: {
-    healthCheck: '=',
-    credentials: '<',
-    healthChecksByAccountAndType: '<',
-    existingHealthCheckNames: '<',
-  },
-  templateUrl: require('./healthCheck.component.html'),
-  controller: HealthCheckCreateCtrl,
-};
-
-export const GCE_HEALTH_CHECK_SELECTOR_COMPONENT = 'spinnaker.gce.healthCheckSelector.component';
-
-module(GCE_HEALTH_CHECK_SELECTOR_COMPONENT, []).component('gceHealthCheckSelector', healthCheckCreateComponent);

package/src/loadBalancer/configure/gceL4LoadBalancerPipeline.spec.js

@@ -1,143 +0,0 @@
-import { ApplicationModelBuilder } from '@spinnaker/core';
-import { GCE_INTERNAL_LOAD_BALANCER_CTRL } from './internal/gceCreateInternalLoadBalancer.controller';
-import { GCE_SSL_LOAD_BALANCER_CTRL } from './ssl/gceCreateSslLoadBalancer.controller';
-import { GCE_TCP_LOAD_BALANCER_CTRL } from './tcp/gceCreateTcpLoadBalancer.controller';
-
-function buildApp() {
-  return ApplicationModelBuilder.createApplicationForTests('app', {
-    key: 'loadBalancers',
-    lazy: true,
-    defaultData: [],
-  });
-}
-
-describe('GCE L4 load balancer controllers (pipeline mode)', function () {
-  describe('gceSslLoadBalancerCtrl', function () {
-    beforeEach(() => {
-      window.module(GCE_SSL_LOAD_BALANCER_CTRL);
-    });
-
-    it(
-      'closes with a pipeline command',
-      window.inject(function ($controller, $rootScope) {
-        const modalInstance = { close: jasmine.createSpy('close'), dismiss: jasmine.createSpy('dismiss') };
-        const loadBalancer = {
-          loadBalancerName: 'ssl-lb',
-          backendService: { healthCheck: { healthCheckType: 'TCP' } },
-          instances: [],
-          credentials: 'test',
-          region: 'global',
-        };
-
-        const ctrl = $controller('gceSslLoadBalancerCtrl', {
-          $scope: $rootScope.$new(),
-          application: buildApp(),
-          $uibModalInstance: modalInstance,
-          loadBalancer,
-          gceCommonLoadBalancerCommandBuilder: {},
-          isNew: true,
-          forPipelineConfig: true,
-          wizardSubFormValidation: {},
-          $state: {},
-        });
-
-        ctrl.submit();
-
-        expect(modalInstance.close).toHaveBeenCalledWith(
-          jasmine.objectContaining({
-            loadBalancerName: 'ssl-lb',
-            cloudProvider: 'gce',
-            healthCheck: {},
-          }),
-        );
-      }),
-    );
-  });
-
-  describe('gceTcpLoadBalancerCtrl', function () {
-    beforeEach(() => {
-      window.module(GCE_TCP_LOAD_BALANCER_CTRL);
-    });
-
-    it(
-      'closes with a pipeline command',
-      window.inject(function ($controller, $rootScope) {
-        const modalInstance = { close: jasmine.createSpy('close'), dismiss: jasmine.createSpy('dismiss') };
-        const loadBalancer = {
-          loadBalancerName: 'tcp-lb',
-          backendService: { healthCheck: { healthCheckType: 'TCP' } },
-          instances: [],
-          credentials: 'test',
-          region: 'global',
-        };
-
-        const ctrl = $controller('gceTcpLoadBalancerCtrl', {
-          $scope: $rootScope.$new(),
-          application: buildApp(),
-          $uibModalInstance: modalInstance,
-          loadBalancer,
-          gceCommonLoadBalancerCommandBuilder: {},
-          isNew: true,
-          forPipelineConfig: true,
-          wizardSubFormValidation: {},
-          $state: {},
-        });
-
-        ctrl.submit();
-
-        expect(modalInstance.close).toHaveBeenCalledWith(
-          jasmine.objectContaining({
-            loadBalancerName: 'tcp-lb',
-            cloudProvider: 'gce',
-            healthCheck: {},
-          }),
-        );
-      }),
-    );
-  });
-
-  describe('gceInternalLoadBalancerCtrl', function () {
-    beforeEach(() => {
-      window.module(GCE_INTERNAL_LOAD_BALANCER_CTRL);
-    });
-
-    it(
-      'closes with a pipeline command',
-      window.inject(function ($controller, $rootScope) {
-        const modalInstance = { close: jasmine.createSpy('close'), dismiss: jasmine.createSpy('dismiss') };
-        const loadBalancer = {
-          loadBalancerName: 'internal-lb',
-          backendService: { healthCheck: { healthCheckType: 'TCP' } },
-          instances: [],
-          ports: '80, 8080',
-          credentials: 'test',
-          region: 'us-west-2',
-        };
-
-        const ctrl = $controller('gceInternalLoadBalancerCtrl', {
-          $scope: $rootScope.$new(),
-          application: buildApp(),
-          $uibModalInstance: modalInstance,
-          loadBalancer,
-          gceCommonLoadBalancerCommandBuilder: {},
-          isNew: true,
-          forPipelineConfig: true,
-          wizardSubFormValidation: {},
-          gceXpnNamingService: {},
-          $state: {},
-        });
-
-        ctrl.submit();
-
-        expect(modalInstance.close).toHaveBeenCalledWith(
-          jasmine.objectContaining({
-            loadBalancerName: 'internal-lb',
-            cloudProvider: 'gce',
-            healthCheck: {},
-            ports: ['80', '8080'],
-          }),
-        );
-      }),
-    );
-  });
-});