@spinnaker/core 0.24.1 → 0.26.0

package/src/pipeline/details/StageFailureMessage.tsx

@@ -73,33 +73,19 @@ export class StageFailureMessage extends React.Component<IStageFailureMessagePro
   }
 
   public render() {
-    const { message, messages, stage } = this.props;
+    const { message, messages } = this.props;
     const { isFailed, failedTask, failedExecutionId, failedStageName, failedStageId } = this.state;
 
-    let stageMessages = message && !messages.length ? [message] : messages;
-    if (stageMessages.length > 0) {
+    if (isFailed || failedTask || message || messages.length) {
       const exceptionTitle = isFailed ? (messages.length ? 'Exceptions' : 'Exception') : 'Warning';
-
-      // expression evaluation warnings can get really long and hide actual failure messages, source
-      // filter out expression evaluation failure messages if either:
-      // - there was a stage failure (and failed expressions don't fail the stage)
-      // - expression evaluation was explicitly disabled for the stage(as Orca still processes expressions and populates
-      //   warnings when evaluation is disabled disabled)
-      const shouldFilterExpressionFailures =
-        (isFailed && !stage.context?.failOnFailedExpressions) || stage.context?.skipExpressionEvaluation;
-
-      if (shouldFilterExpressionFailures) {
-        stageMessages = stageMessages.filter((m) => !m.startsWith('Failed to evaluate'));
-
-        if (stageMessages.length === 0) {
-          // no messages to be displayed after filtering
-          return null;
-        }
-      }
-
-      const displayMessages = stageMessages.map((m, i) => (
-        <Markdown key={i} message={m || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
-      ));
+      const displayMessages =
+        message || !messages.length ? (
+          <Markdown message={message || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
+        ) : (
+          messages.map((m, i) => (
+            <Markdown key={i} message={m || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
+          ))
+        );
 
       if (displayMessages) {
         return (

package/src/pipeline/executions/Executions.tsx

@@ -4,6 +4,7 @@ import React from 'react';
 import type { Subscription } from 'rxjs';
 
 import type { Application } from '../../application';
+import type { IDefaultTagFilterConfig } from '../../application/config/defaultTagFilter/DefaultTagFilterConfig';
 import { CreatePipeline } from '../config/CreatePipeline';
 import { CreatePipelineButton } from '../create/CreatePipelineButton';
 import type { IExecution, IPipeline, IPipelineCommand } from '../../domain';
@@ -74,6 +75,16 @@ export class Executions extends React.Component<IExecutionsProps, IExecutionsSta
     }
   };
 
+  private loadDefaultFilters = (): void => {
+    const defaultTags = this.props.app.attributes.defaultFilteredTags;
+    if (defaultTags != null) {
+      this.props.app.attributes.defaultFilteredTags.forEach((defaultTag: IDefaultTagFilterConfig) => {
+        ExecutionState.filterModel.asFilterModel.sortFilter.tags[`${defaultTag.tagName}:${defaultTag.tagValue}`] = true;
+      });
+      this.updateExecutionGroups(true);
+    }
+  };
+
   private clearFilters = (): void => {
     ExecutionFilterService.clearFilters();
     this.updateExecutionGroups(true);
@@ -235,6 +246,8 @@ export class Executions extends React.Component<IExecutionsProps, IExecutionsSta
       () => this.dataInitializationFailure(),
     );
 
+    this.loadDefaultFilters();
+
     $q.all([app.executions.ready(), app.pipelineConfigs.ready()]).then(() => {
       this.updateExecutionGroups();
       const nameOrIdToStart = ReactInjector.$stateParams.startManualExecution;

package/src/pipeline/index.ts

@@ -23,3 +23,5 @@ export * from './manualExecution/TriggerTemplate';
 export * from './service/ExecutionsTransformer';
 export * from './service/execution.service';
 export * from './status/ArtifactList';
+export * from './config/stages/bakeManifest/utils/getBakedArtifacts';
+export * from './config/stages/bakeManifest/utils/getContentReference';

package/src/pipeline/status/ExecutionCancellationReason.tsx

@@ -7,7 +7,7 @@ interface IExecutionCancellationReasonProps {
 }
 
 export function ExecutionCancellationReason({ cancellationReason }: IExecutionCancellationReasonProps) {
-  const [isExpanded, setIsExpanded] = React.useState(false);
+  const [isExpanded, setIsExpanded] = React.useState(true);
   return (
     <>
       <div className="execution-cancellation-reason-button">

package/src/presentation/forms/inputs/NumberConcurrencyInput.tsx

@@ -0,0 +1,29 @@
+import React from 'react';
+
+import { useInternalValidator } from './hooks';
+import type { IFormInputProps, OmitControlledInputPropsFrom } from './interface';
+import { orEmptyString, validationClassName } from './utils';
+import type { IValidator } from '../validation';
+import { composeValidators, Validators } from '../validation';
+
+interface INumberInputProps extends IFormInputProps, OmitControlledInputPropsFrom<React.InputHTMLAttributes<any>> {
+  inputClassName?: string;
+}
+
+const isNumber = (val: any): val is number => typeof val === 'number';
+
+export function NumberConcurrencyInput(props: INumberInputProps) {
+  const { value, validation, inputClassName, ...otherProps } = props;
+
+  const minMaxValidator: IValidator = (val: any, label?: string) => {
+    const minValidator = isNumber(props.min) ? Validators.minValue(props.min) : undefined;
+    const maxValidator = isNumber(props.max) ? Validators.maxValue(props.max) : undefined;
+    const validator = composeValidators([minValidator, maxValidator]);
+    return validator ? validator(val, label) : null;
+  };
+
+  useInternalValidator(validation, minMaxValidator);
+
+  const className = `NumberInput form-control ${orEmptyString(inputClassName)} ${validationClassName(validation)}`;
+  return <input className={className} type="number" value={orEmptyString(value)} {...otherProps} />;
+}