@spinnaker/core 0.24.1 → 0.26.0

package/dist/manifest/ManifestYaml.d.ts

@@ -1,7 +1,13 @@
 /// <reference types="react" />
-export interface IManifestYamlProps {
+declare type IManifestYamlProps = {
     linkName: string;
-    manifestText: string;
     modalTitle: string;
-}
-export declare function ManifestYaml(props: IManifestYamlProps): JSX.Element;
+} & ({
+    manifestText: string;
+    manifestUri?: never;
+} | {
+    manifestText?: never;
+    manifestUri: string;
+});
+export declare function ManifestYaml({ linkName, modalTitle, manifestText, manifestUri }: IManifestYamlProps): JSX.Element;
+export {};

package/dist/pipeline/config/stages/bakeManifest/ManifestRenderers.d.ts

@@ -1,8 +1,10 @@
 export declare enum ManifestRenderers {
     HELM2 = "HELM2",
     HELM3 = "HELM3",
+    HELMFILE = "HELMFILE",
     KUSTOMIZE = "KUSTOMIZE",
     KUSTOMIZE4 = "KUSTOMIZE4"
 }
 export declare const HELM_RENDERERS: Readonly<ManifestRenderers[]>;
+export declare const HELMFILE_RENDERER: Readonly<ManifestRenderers>;
 export declare const KUSTOMIZE_RENDERERS: Readonly<ManifestRenderers[]>;

package/dist/pipeline/config/stages/bakeManifest/helmfile/BakeHelmfileConfigForm.d.ts

@@ -0,0 +1,18 @@
+import React from 'react';
+import type { IFormikStageConfigInjectedProps } from '../../FormikStageConfig';
+export interface IBakeHelmfileConfigFormState {
+    gitRepoArtifactAccountNames: string[];
+}
+export declare class BakeHelmfileConfigForm extends React.Component<IFormikStageConfigInjectedProps, IBakeHelmfileConfigFormState> {
+    constructor(props: IFormikStageConfigInjectedProps);
+    private static readonly excludedArtifactTypes;
+    componentDidMount(): void;
+    private onTemplateArtifactEdited;
+    private onTemplateArtifactSelected;
+    private addInputArtifact;
+    private removeInputArtifact;
+    private getInputArtifact;
+    private outputNameChange;
+    private overrideChanged;
+    render(): JSX.Element;
+}

package/dist/pipeline/config/stages/bakeManifest/utils/getBakedArtifacts.d.ts

@@ -0,0 +1,4 @@
+import type { IArtifact, IExecutionContext } from '../../../../../domain';
+export declare const getBakedArtifacts: (context: IExecutionContext) => Array<IArtifact & {
+    reference: string;
+}>;

package/dist/pipeline/config/stages/bakeManifest/utils/getContentReference.d.ts

@@ -0,0 +1 @@
+export declare const getContentReference: (uri: string) => string;

package/dist/pipeline/config/triggers/artifacts/ArtifactService.d.ts

@@ -1,4 +1,7 @@
 export declare class ArtifactService {
     static getArtifactNames(type: string, accountName: string): PromiseLike<string[]>;
     static getArtifactVersions(type: string, accountName: string, artifactName: string): PromiseLike<string[]>;
+    static getArtifactByContentReference(contentRef: string): PromiseLike<{
+        reference: string;
+    }>;
 }

package/dist/pipeline/config/triggers/cdevents/CDEventsTrigger.d.ts

@@ -0,0 +1,7 @@
+/// <reference types="react" />
+import type { FormikProps } from 'formik';
+import type { ICDEventsTrigger } from '../../../../domain';
+export interface ICDEventsTriggerProps {
+    formik: FormikProps<ICDEventsTrigger>;
+}
+export declare function CDEventsTrigger(cdeventsTriggerProps: ICDEventsTriggerProps): JSX.Element;

package/dist/pipeline/config/triggers/cdevents/cdevents.trigger.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/pipeline/config/triggers/index.d.ts

@@ -1,4 +1,5 @@
 import './artifactory/artifactory.trigger';
+import './cdevents/cdevents.trigger';
 import './concourse/concourse.trigger';
 import './cron/cron.trigger';
 import './git/git.trigger';

package/dist/pipeline/executions/Executions.d.ts

@@ -24,6 +24,7 @@ export declare class Executions extends React.Component<IExecutionsProps, IExecu
     private filterCountOptions;
     constructor(props: IExecutionsProps);
     private setReloadingForFilters;
+    private loadDefaultFilters;
     private clearFilters;
     private forceUpdateExecutionGroups;
     private updateExecutionGroups;

package/dist/pipeline/index.d.ts

@@ -23,3 +23,5 @@ export * from './manualExecution/TriggerTemplate';
 export * from './service/ExecutionsTransformer';
 export * from './service/execution.service';
 export * from './status/ArtifactList';
+export * from './config/stages/bakeManifest/utils/getBakedArtifacts';
+export * from './config/stages/bakeManifest/utils/getContentReference';

package/dist/presentation/forms/inputs/NumberConcurrencyInput.d.ts

@@ -0,0 +1,7 @@
+import React from 'react';
+import type { IFormInputProps, OmitControlledInputPropsFrom } from './interface';
+interface INumberInputProps extends IFormInputProps, OmitControlledInputPropsFrom<React.InputHTMLAttributes<any>> {
+    inputClassName?: string;
+}
+export declare function NumberConcurrencyInput(props: INumberInputProps): JSX.Element;
+export {};

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/core",
   "license": "Apache-2.0",
-  "version": "0.24.1",
+  "version": "0.26.0",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -120,5 +120,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "eb226ee64d23c8c34be5ace816809a2262917e3f"
+  "gitHead": "581f9d4358d0c90a385df0119a7ae0a41b81c1cb"
 }

package/src/application/config/applicationConfig.controller.js

@@ -8,6 +8,7 @@ import { CORE_APPLICATION_CONFIG_APPLICATIONSNAPSHOTSECTION_COMPONENT } from './
 import { CHAOS_MONKEY_CONFIG_COMPONENT } from '../../chaosMonkey/chaosMonkeyConfig.component';
 import { SETTINGS } from '../../config/settings';
 import { APPLICATION_DATA_SOURCE_EDITOR } from './dataSources/applicationDataSourceEditor.component';
+import { DEFAULT_TAG_FILTER_CONFIG } from './defaultTagFilter/defaultTagFilterConfig.component';
 import { DELETE_APPLICATION_SECTION } from './deleteApplicationSection.module';
 import { CORE_APPLICATION_CONFIG_LINKS_APPLICATIONLINKS_COMPONENT } from './links/applicationLinks.component';
 import { ApplicationWriter } from '../service/ApplicationWriter';
@@ -25,6 +26,7 @@ module(CORE_APPLICATION_CONFIG_APPLICATIONCONFIG_CONTROLLER, [
   CHAOS_MONKEY_CONFIG_COMPONENT,
   TRAFFIC_GUARD_CONFIG_COMPONENT,
   CORE_APPLICATION_CONFIG_LINKS_APPLICATIONLINKS_COMPONENT,
+  DEFAULT_TAG_FILTER_CONFIG,
 ]).controller('ApplicationConfigController', [
   '$state',
   'app',
@@ -63,6 +65,30 @@ module(CORE_APPLICATION_CONFIG_APPLICATIONCONFIG_CONTROLLER, [
         });
     };
 
+    this.defaultTagFilterProps = {
+      isSaving: false,
+      saveError: false,
+    };
+    this.updateDefaultTagFilterConfigs = (tagConfigs /* IDefaultTagFilterConfig[] */) => {
+      const applicationAttributes = cloneDeep(this.application.attributes);
+      applicationAttributes.defaultFilteredTags = tagConfigs;
+      $scope.$applyAsync(() => {
+        this.defaultTagFilterProps.isSaving = true;
+        this.defaultTagFilterProps.saveError = false;
+      });
+      ApplicationWriter.updateApplication(applicationAttributes)
+        .then(() => {
+          $scope.$applyAsync(() => {
+            this.defaultTagFilterProps.isSaving = false;
+            this.application.attributes = applicationAttributes;
+          });
+        })
+        .catch(() => {
+          this.defaultTagFilterProps.isSaving = false;
+          this.defaultTagFilterProps.saveError = true;
+        });
+    };
+
     this.notifications = [];
     this.updateNotifications = (notifications) => {
       $scope.$applyAsync(() => {

package/src/application/config/applicationConfig.view.html

@@ -54,6 +54,15 @@
       >
       </custom-banner-config>
     </page-section>
+    <page-section key="default-filters" label="Default Filters">
+      <default-tag-filter-config
+        default-tag-filter-configs="config.application.attributes.defaultFilteredTags"
+        is-saving="config.defaultTagFilterProps.isSaving"
+        save-error="config.defaultTagFilterProps.saveError"
+        update-default-tag-filter-configs="config.updateDefaultTagFilterConfigs"
+      >
+      </default-tag-filter-config>
+    </page-section>
     <page-section key="delete" label="Delete Application">
       <delete-application-section application="config.application"></delete-application-section>
     </page-section>

package/src/application/config/defaultTagFilter/DefaultTagFilterConfig.spec.tsx

@@ -0,0 +1,75 @@
+import { shallow } from 'enzyme';
+import React from 'react';
+
+import type { IDefaultTagFilterConfig } from './DefaultTagFilterConfig';
+import { DefaultTagFilterConfig } from './DefaultTagFilterConfig';
+import { noop } from '../../../utils';
+
+describe('<DefaultTagFilterConfig />', () => {
+  let tagConfigs: IDefaultTagFilterConfig[];
+  let wrapper: any;
+
+  beforeEach(() => {
+    tagConfigs = getTestDefaultFilterTagConfigs();
+    wrapper = shallow(
+      <DefaultTagFilterConfig
+        defaultTagFilterConfigs={tagConfigs}
+        isSaving={false}
+        saveError={false}
+        updateDefaultTagFilterConfigs={noop}
+      />,
+    );
+  });
+
+  describe('view', () => {
+    it('renders a row for each banner config', () => {
+      expect(wrapper.find('.default-filter-config-row').length).toEqual(tagConfigs.length);
+    });
+    it('renders an "add" button', () => {
+      expect(wrapper.find('.add-new').length).toEqual(1);
+    });
+  });
+
+  describe('functionality', () => {
+    it('update default tag filter config', () => {
+      expect(wrapper.state('defaultTagFilterConfigsEditing')).toEqual(tagConfigs);
+      wrapper
+        .find('textarea')
+        .at(1)
+        .simulate('change', { target: { value: 'hello' } });
+      const updatedConfigs = [
+        {
+          ...tagConfigs[0],
+          tagValue: 'hello',
+        },
+        {
+          ...tagConfigs[1],
+        },
+      ];
+      expect(wrapper.state('defaultTagFilterConfigsEditing')).toEqual(updatedConfigs);
+    });
+    it('add default filter tag config', () => {
+      expect(wrapper.state('defaultTagFilterConfigsEditing').length).toEqual(2);
+      wrapper.find('.add-new').simulate('click');
+      expect(wrapper.state('defaultTagFilterConfigsEditing').length).toEqual(3);
+    });
+    it('remove default filter tag config', () => {
+      expect(wrapper.state('defaultTagFilterConfigsEditing').length).toEqual(2);
+      wrapper.find('.default-filter-config-remove').at(1).simulate('click');
+      expect(wrapper.state('defaultTagFilterConfigsEditing').length).toEqual(1);
+    });
+  });
+});
+
+export function getTestDefaultFilterTagConfigs(): IDefaultTagFilterConfig[] {
+  return [
+    {
+      tagName: 'Pipeline Type',
+      tagValue: 'Deployment Pipelines',
+    },
+    {
+      tagName: 'Pipeline Type',
+      tagValue: 'Repair Pipelines',
+    },
+  ];
+}

package/src/application/config/defaultTagFilter/DefaultTagFilterConfig.tsx

@@ -0,0 +1,161 @@
+import { isEqual } from 'lodash';
+import React from 'react';
+
+import { ConfigSectionFooter } from '../footer/ConfigSectionFooter';
+import { noop } from '../../../utils';
+
+import './defaultTagFilterConfig.less';
+
+export interface IDefaultTagFilterConfig {
+  tagName: string;
+  tagValue: string;
+}
+
+export interface IDefaultTagFilterProps {
+  defaultTagFilterConfigs: IDefaultTagFilterConfig[];
+  isSaving: boolean;
+  saveError: boolean;
+  updateDefaultTagFilterConfigs: (defaultTagFilterConfigs: IDefaultTagFilterConfig[]) => void;
+}
+
+export interface IDefaultTagFilterState {
+  defaultTagFilterConfigsEditing: IDefaultTagFilterConfig[];
+}
+
+export class DefaultTagFilterConfig extends React.Component<IDefaultTagFilterProps, IDefaultTagFilterState> {
+  public static defaultProps: Partial<IDefaultTagFilterProps> = {
+    defaultTagFilterConfigs: [],
+    isSaving: false,
+    saveError: false,
+    updateDefaultTagFilterConfigs: noop,
+  };
+
+  constructor(props: IDefaultTagFilterProps) {
+    super(props);
+    this.state = {
+      defaultTagFilterConfigsEditing: props.defaultTagFilterConfigs,
+    };
+  }
+
+  private onTagNameChange = (idx: number, text: string) => {
+    this.setState({
+      defaultTagFilterConfigsEditing: this.state.defaultTagFilterConfigsEditing.map((config, i) => {
+        if (i === idx) {
+          return {
+            ...config,
+            tagName: text,
+          };
+        }
+        return config;
+      }),
+    });
+  };
+
+  private onTagValueChange = (idx: number, text: string) => {
+    this.setState({
+      defaultTagFilterConfigsEditing: this.state.defaultTagFilterConfigsEditing.map((config, i) => {
+        if (i === idx) {
+          return {
+            ...config,
+            tagValue: text,
+          };
+        }
+        return config;
+      }),
+    });
+  };
+
+  private addFilterTag = (): void => {
+    this.setState({
+      defaultTagFilterConfigsEditing: this.state.defaultTagFilterConfigsEditing.concat([
+        {
+          tagName: 'Name of the tag (E.g. Pipeline Type)',
+          tagValue: 'Value of the tag (E.g. Default Pipelines)',
+        } as IDefaultTagFilterConfig,
+      ]),
+    });
+  };
+
+  private removeFilterTag = (idx: number): void => {
+    this.setState({
+      defaultTagFilterConfigsEditing: this.state.defaultTagFilterConfigsEditing.filter((_config, i) => i !== idx),
+    });
+  };
+
+  private isDirty = (): boolean => {
+    return !isEqual(this.props.defaultTagFilterConfigs, this.state.defaultTagFilterConfigsEditing);
+  };
+
+  private onRevertClicked = (): void => {
+    this.setState({
+      defaultTagFilterConfigsEditing: this.props.defaultTagFilterConfigs,
+    });
+  };
+
+  private onSaveClicked = (): void => {
+    this.props.updateDefaultTagFilterConfigs(this.state.defaultTagFilterConfigsEditing);
+  };
+
+  public render() {
+    return (
+      <div className="default-filter-config-container">
+        <div className="default-filter-config-description">
+          Default Tag filters allow you to specify which tags are immediately filtered to when the pipeline execution
+          page is loaded in.
+        </div>
+        <div className="col-md-10 col-md-offset-1">
+          <table className="table table-condensed">
+            <thead>
+              <tr>
+                <th>Tag Name</th>
+                <th>Tag Value</th>
+              </tr>
+            </thead>
+            <tbody>
+              {this.state.defaultTagFilterConfigsEditing.map((defaultTagFilter, idx) => (
+                <tr key={idx} className="default-filter-config-row">
+                  <td>
+                    <textarea
+                      className="form-control input-sm"
+                      onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) =>
+                        this.onTagNameChange(idx, e.target.value)
+                      }
+                      value={defaultTagFilter.tagName}
+                    />
+                  </td>
+                  <td>
+                    <textarea
+                      className="form-control input-sm"
+                      onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) =>
+                        this.onTagValueChange(idx, e.target.value)
+                      }
+                      value={defaultTagFilter.tagValue}
+                    />
+                  </td>
+                  <td>
+                    <button className="link default-filter-config-remove" onClick={() => this.removeFilterTag(idx)}>
+                      <span className="glyphicon glyphicon-trash" />
+                    </button>
+                  </td>
+                </tr>
+              ))}
+            </tbody>
+          </table>
+        </div>
+        <div className="col-md-10 col-md-offset-1">
+          <button className="btn btn-block add-new" onClick={this.addFilterTag}>
+            <span className="glyphicon glyphicon-plus-sign" /> Add Default Filter
+          </button>
+        </div>
+        <ConfigSectionFooter
+          isDirty={this.isDirty()}
+          isValid={true}
+          isSaving={this.props.isSaving}
+          saveError={false}
+          onRevertClicked={this.onRevertClicked}
+          onSaveClicked={this.onSaveClicked}
+        />
+      </div>
+    );
+  }
+}

package/src/application/config/defaultTagFilter/defaultTagFilterConfig.component.ts

@@ -0,0 +1,15 @@
+import { module } from 'angular';
+import { react2angular } from 'react2angular';
+import { DefaultTagFilterConfig } from './DefaultTagFilterConfig';
+import { withErrorBoundary } from '../../../presentation/SpinErrorBoundary';
+
+export const DEFAULT_TAG_FILTER_CONFIG = 'spinnaker.micros.application.defaultTagFilterConfig.component';
+module(DEFAULT_TAG_FILTER_CONFIG, []).component(
+  'defaultTagFilterConfig',
+  react2angular(withErrorBoundary(DefaultTagFilterConfig, 'defaultTagFilterConfig'), [
+    'defaultTagFilterConfigs',
+    'isSaving',
+    'saveError',
+    'updateDefaultTagFilterConfigs',
+  ]),
+);

package/src/application/config/defaultTagFilter/defaultTagFilterConfig.less

@@ -0,0 +1,8 @@
+.default-filter-config-container {
+  display: flex;
+  flex-direction: column;
+}
+
+.default-filter-config-description {
+  margin-bottom: 10px;
+}

package/src/artifact/ArtifactIconService.ts

@@ -44,6 +44,7 @@ ArtifactIconService.registerType(ArtifactTypePatterns.CUSTOM_OBJECT, unknownArti
 ArtifactIconService.registerType(ArtifactTypePatterns.DOCKER_IMAGE, dockerIcon);
 ArtifactIconService.registerType(ArtifactTypePatterns.KUBERNETES, kubernetesIcon);
 ArtifactIconService.registerType(ArtifactTypePatterns.EMBEDDED_BASE64, embeddedBase64Icon);
+ArtifactIconService.registerType(ArtifactTypePatterns.REMOTE_BASE64, embeddedBase64Icon);
 ArtifactIconService.registerType(ArtifactTypePatterns.GCS_OBJECT, gcsObjectIcon);
 ArtifactIconService.registerType(ArtifactTypePatterns.GITHUB_FILE, gitHubFileIcon);
 ArtifactIconService.registerType(ArtifactTypePatterns.GIT_REPO, gitRepoIcon);

package/src/artifact/ArtifactTypes.ts

@@ -7,6 +7,7 @@ export const ArtifactTypePatterns: IArtifactTypePatterns = {
   CUSTOM_OBJECT: /custom\/object/,
   DOCKER_IMAGE: /docker\/image/,
   EMBEDDED_BASE64: /embedded\/base64/,
+  REMOTE_BASE64: /remote\/base64/,
   GCS_OBJECT: /gcs\/object/,
   GITHUB_FILE: /github\/file/,
   GIT_REPO: /git\/repo/,

package/src/config/settings.ts

@@ -34,6 +34,7 @@ export interface IFeatures {
   executionMarkerInformationModal?: boolean;
   fiatEnabled?: boolean;
   iapRefresherEnabled?: boolean;
+  lambdaAdditionalStages?: boolean;
   managedDelivery?: boolean;
   mdGitIntegration?: boolean;
   managedServiceAccounts?: boolean;

package/src/domain/IArtifact.ts

@@ -12,3 +12,6 @@ export interface IArtifact {
   kind?: string; // TODO delete
   customKind?: boolean; // TODO delete
 }
+
+export const ARTIFACT_TYPE_EMBEDDED = 'embedded/base64';
+export const ARTIFACT_TYPE_REMOTE = 'remote/base64';

package/src/domain/ITrigger.ts

@@ -91,6 +91,10 @@ export interface IWebhookTrigger extends ITrigger {
   payloadConstraints: { [key: string]: string };
 }
 
+export interface ICDEventsTrigger extends IWebhookTrigger {
+  attributeConstraints: { [key: string]: string };
+}
+
 export interface IWerckerTrigger extends IBuildTrigger {
   app: string;
   pipeline: string;

package/src/help/help.contents.ts

@@ -178,6 +178,11 @@ const helpContents: { [key: string]: string } = {
       <p>When provided, only a webhook with a payload containing at least the specified key/value pairs will be allowed to trigger this pipeline. For example, if you wanted to lock down the systems/users that can trigger this pipeline via this webhook, you could require the key "secret" and value "something-secret" as a constraint.</p>
       <p>The constraint values may be supplied as regex.</p>
   `,
+  'pipeline.config.trigger.cdevents.attributeConstraints': `
+      <p>CDEvents messages will have mandatory headers id, source, specversion, type accompanying the payload called <b>attributes</b>.</p>
+      <p>When provided, only a CDEvents message with attributes containing at least the specified key/value pairs will be allowed to trigger this pipeline.</p>
+      <p>The constraint value is a java regex string.</p>
+  `,
   'pipeline.config.trigger.pubsub.attributeConstraints': `
       <p>Pubsub messages can have system-specific metadata accompanying the payload called <b>attributes</b>.</p>
       <p>When provided, only a pubsub message with attributes containing at least the specified key/value pairs will be allowed to trigger this pipeline.</p>
@@ -307,6 +312,11 @@ const helpContents: { [key: string]: string } = {
   'pipeline.config.bake.manifest.kustomize.filePath': `
     <p>This is the relative path to the kustomization.yaml file within your Git repo.</p>
     <p>e.g.: <b>examples/wordpress/mysql/kustomization.yaml</b></p>`,
+  'pipeline.config.bake.manifest.helmfile.filePath': `
+    <p>This is the relative path to the directory containing the helmfile.yaml file within your Git repo.</p>
+    <p>e.g.: <b>chart/helmfile.yml</b></p>`,
+  'pipeline.config.bake.manifest.helmfile.name':
+    '<p> Name is used to set the expected artifact in the Produces Artifact section. </p>',
   'pipeline.config.bake.cf.manifest.name':
     '<p> Name should be the same as the expected artifact in the Produces Artifact section. </p>',
   'pipeline.config.bake.cf.manifest.templateArtifact': `

package/src/manifest/ManifestYaml.tsx

@@ -1,26 +1,48 @@
 import React from 'react';
 import { Modal } from 'react-bootstrap';
+import { ArtifactService } from '../pipeline/config/triggers/artifacts/ArtifactService';
+import { decodeUnicodeBase64 } from '../utils';
 
-export interface IManifestYamlProps {
+type IManifestYamlProps = {
   linkName: string;
-  manifestText: string;
   modalTitle: string;
-}
+} & ({ manifestText: string; manifestUri?: never } | { manifestText?: never; manifestUri: string });
 
-export function ManifestYaml(props: IManifestYamlProps) {
+export function ManifestYaml({ linkName, modalTitle, manifestText, manifestUri }: IManifestYamlProps) {
   const [modalVisible, setModalVisible] = React.useState<boolean>(false);
   const toggle = () => setModalVisible(!modalVisible);
+  const [fetchedManifestText, setFetchedManifestText] = React.useState<string>('Loading...');
+  const [error, setError] = React.useState<string | null>(null);
+
+  React.useEffect(() => {
+    if (manifestUri) {
+      ArtifactService.getArtifactByContentReference(manifestUri)
+        .then((manifest) => setFetchedManifestText(decodeUnicodeBase64(manifest.reference)))
+        .catch((e) => setError(`Error: ${typeof e !== 'string' ? e.data?.message ?? JSON.stringify(e) : e}`));
+    }
+  }, []);
+
   return (
     <>
       <a key="modal-link" onClick={toggle} className="clickable">
-        {props.linkName}
+        {linkName}
       </a>
       <Modal key="modal" show={modalVisible} onHide={toggle}>
         <Modal.Header closeButton={true}>
-          <h3>{props.modalTitle}</h3>
+          <h3>{modalTitle}</h3>
         </Modal.Header>
         <Modal.Body>
-          <textarea readOnly={true} rows={15} className="code" value={props.manifestText} />
+          {error ? (
+            <div className="alert alert-warning">
+              <p>{error}</p>
+            </div>
+          ) : null}
+          <textarea
+            readOnly={true}
+            rows={15}
+            className="code"
+            value={manifestUri ? fetchedManifestText : manifestText}
+          />
         </Modal.Body>
         <Modal.Footer>
           <button className="btn btn-primary" onClick={toggle}>

package/src/pipeline/config/stages/bakeManifest/BakeManifestConfig.tsx

@@ -4,7 +4,7 @@ import React from 'react';
 
 import { BakeManifestStageForm, validateProducedArtifacts } from './BakeManifestStageForm';
 import { FormikStageConfig } from '../FormikStageConfig';
-import { HELM_RENDERERS } from './ManifestRenderers';
+import { HELM_RENDERERS, HELMFILE_RENDERER } from './ManifestRenderers';
 import type { IStageConfigProps } from '../common';
 import type { IExpectedArtifact, IStage } from '../../../../domain';
 import { FormValidator } from '../../../../presentation';
@@ -46,6 +46,9 @@ export function validateBakeManifestStage(stage: IStage): FormikErrors<IStage> {
   if (HELM_RENDERERS.includes(stage.templateRenderer)) {
     formValidator.field('outputName', 'Name').required();
   }
+  if (HELMFILE_RENDERER === stage.templateRenderer) {
+    formValidator.field('outputName', 'Name').required();
+  }
 
   return formValidator.validateForm();
 }