@spinnaker/amazon 0.8.14 → 0.11.0

package/src/serverGroup/configure/wizard/pages/ServerGroupCapacity.tsx

@@ -1,11 +1,12 @@
-import { Field, FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
+import { Field } from 'formik';
 import React from 'react';
 
-import { IServerGroupCommand, IWizardPageComponent } from '@spinnaker/core';
+import type { IServerGroupCommand, IWizardPageComponent } from '@spinnaker/core';
 
 import { CapacitySelector } from '../capacity/CapacitySelector';
 import { MinMaxDesired } from '../capacity/MinMaxDesired';
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupCapacityProps {
   formik: FormikProps<IServerGroupCommand>;

package/src/serverGroup/configure/wizard/pages/ServerGroupInstanceType.tsx

@@ -1,11 +1,12 @@
-import { FormikErrors, FormikProps } from 'formik';
+import type { FormikErrors, FormikProps } from 'formik';
 import React from 'react';
 
-import { IWizardPageComponent, NgReact } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { NgReact } from '@spinnaker/core';
 import { AWSProviderSettings } from '../../../../aws.settings';
 
 import { CpuCreditsToggle } from '../instanceType/CpuCreditsToggle';
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupInstanceTypeProps {
   formik: FormikProps<IAmazonServerGroupCommand>;

package/src/serverGroup/configure/wizard/pages/ServerGroupLoadBalancers.tsx

@@ -1,10 +1,11 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
-import { Option } from 'react-select';
+import type { Option } from 'react-select';
 
-import { HelpField, IWizardPageComponent, ReactInjector, TetheredSelect } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { HelpField, ReactInjector, TetheredSelect } from '@spinnaker/core';
 
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupLoadBalancersProps {
   hideLoadBalancers?: boolean;

package/src/serverGroup/configure/wizard/pages/ServerGroupSecurityGroups.tsx

@@ -1,11 +1,11 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import { IWizardPageComponent } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
 
 import { SecurityGroupSelector } from '../securityGroups/SecurityGroupSelector';
 import { ServerGroupSecurityGroupsRemoved } from '../securityGroups/ServerGroupSecurityGroupsRemoved';
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupSecurityGroupsProps {
   formik: FormikProps<IAmazonServerGroupCommand>;

package/src/serverGroup/configure/wizard/pages/ServerGroupZones.tsx

@@ -1,10 +1,10 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import { IWizardPageComponent } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
 
 import { AvailabilityZoneSelector } from '../../../AvailabilityZoneSelector';
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupZonesProps {
   formik: FormikProps<IAmazonServerGroupCommand>;

package/src/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettings.tsx

@@ -1,10 +1,10 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import { Application, IWizardPageComponent } from '@spinnaker/core';
+import type { Application, IWizardPageComponent } from '@spinnaker/core';
 
 import { ServerGroupAdvancedSettingsInner } from './ServerGroupAdvancedSettingsInner';
-import { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
 
 export interface IServerGroupAdvancedSettingsProps {
   app: Application;

package/src/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsCommon.tsx

@@ -1,12 +1,13 @@
 import { Field } from 'formik';
 import React from 'react';
-import Select, { Option } from 'react-select';
+import type { Option } from 'react-select';
+import Select from 'react-select';
 
 import { HelpField, MapEditor, PlatformHealthOverride } from '@spinnaker/core';
 
-import { IServerGroupAdvancedSettingsProps } from './ServerGroupAdvancedSettings';
+import type { IServerGroupAdvancedSettingsProps } from './ServerGroupAdvancedSettings';
 import { AWSProviderSettings } from '../../../../../aws.settings';
-import { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
 
 export class ServerGroupAdvancedSettingsCommon extends React.Component<IServerGroupAdvancedSettingsProps> {
   private duplicateKeys = false;

package/src/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsInner.tsx

@@ -1,11 +1,12 @@
-import { FormikErrors } from 'formik';
+import type { FormikErrors } from 'formik';
 import React from 'react';
 
-import { IWizardPageComponent, Overridable } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { Overridable } from '@spinnaker/core';
 
-import { IServerGroupAdvancedSettingsProps } from './ServerGroupAdvancedSettings';
+import type { IServerGroupAdvancedSettingsProps } from './ServerGroupAdvancedSettings';
 import { ServerGroupAdvancedSettingsCommon } from './ServerGroupAdvancedSettingsCommon';
-import { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../../serverGroupConfiguration.service';
 
 @Overridable('aws.serverGroup.advancedSettings')
 export class ServerGroupAdvancedSettingsInner

package/src/serverGroup/configure/wizard/securityGroups/SecurityGroupSelector.tsx

@@ -1,17 +1,11 @@
 import React from 'react';
-import { Option } from 'react-select';
+import type { Option } from 'react-select';
 import VirtualizedSelect from 'react-virtualized-select';
 
-import {
-  FirewallLabels,
-  HelpField,
-  InfrastructureCaches,
-  ISecurityGroup,
-  ReactInjector,
-  timestamp,
-} from '@spinnaker/core';
+import type { ISecurityGroup } from '@spinnaker/core';
+import { FirewallLabels, HelpField, InfrastructureCaches, ReactInjector, timestamp } from '@spinnaker/core';
 
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface ISecurityGroupSelectorProps {
   command: IAmazonServerGroupCommand;

package/src/serverGroup/configure/wizard/securityGroups/ServerGroupSecurityGroupsRemoved.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 
 import { FirewallLabels, noop } from '@spinnaker/core';
 
-import { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
+import type { IAmazonServerGroupCommand } from '../../serverGroupConfiguration.service';
 
 export interface IServerGroupSecurityGroupsRemovedProps {
   command?: IAmazonServerGroupCommand;

package/src/serverGroup/details/AmazonServerGroupActions.tsx

@@ -2,13 +2,11 @@ import { filter, find, get, orderBy } from 'lodash';
 import React from 'react';
 import { Dropdown, MenuItem, Tooltip } from 'react-bootstrap';
 
+import type { IOwnerOption, IServerGroupActionsProps, IServerGroupJob } from '@spinnaker/core';
 import {
   AddEntityTagLinks,
   ClusterTargetBuilder,
   ConfirmationModalService,
-  IOwnerOption,
-  IServerGroupActionsProps,
-  IServerGroupJob,
   ManagedMenuItem,
   ModalInjector,
   Overridable,
@@ -17,14 +15,12 @@ import {
   SETTINGS,
 } from '@spinnaker/core';
 
-import { IAmazonServerGroupCommand } from '../configure';
+import type { IAmazonServerGroupCommand } from '../configure';
 import { AmazonCloneServerGroupModal } from '../configure/wizard/AmazonCloneServerGroupModal';
-import { IAmazonServerGroup, IAmazonServerGroupView } from '../../domain';
+import type { IAmazonServerGroup, IAmazonServerGroupView } from '../../domain';
 import { AwsReactInjector } from '../../reactShims';
-import {
-  AmazonResizeServerGroupModal,
-  IAmazonResizeServerGroupModalProps,
-} from './resize/AmazonResizeServerGroupModal';
+import type { IAmazonResizeServerGroupModalProps } from './resize/AmazonResizeServerGroupModal';
+import { AmazonResizeServerGroupModal } from './resize/AmazonResizeServerGroupModal';
 
 export interface IAmazonServerGroupActionsProps extends IServerGroupActionsProps {
   serverGroup: IAmazonServerGroupView;
@@ -289,54 +285,58 @@ export class AmazonServerGroupActions extends React.Component<IAmazonServerGroup
     const entityTagTargets: IOwnerOption[] = ClusterTargetBuilder.buildClusterTargets(serverGroup);
 
     return (
-      <Dropdown className="dropdown" id="server-group-actions-dropdown">
-        <Dropdown.Toggle className="btn btn-sm btn-primary dropdown-toggle">Server Group Actions</Dropdown.Toggle>
-        <Dropdown.Menu className="dropdown-menu">
-          {this.isRollbackEnabled() && (
-            <ManagedMenuItem resource={serverGroup} application={app} onClick={this.rollbackServerGroup}>
-              Rollback
-            </ManagedMenuItem>
-          )}
-          {this.isRollbackEnabled() && <li role="presentation" className="divider" />}
-          <AmazonServerGroupActionsResize application={app} serverGroup={serverGroup} />
-          {!serverGroup.isDisabled && (
-            <ManagedMenuItem resource={serverGroup} application={app} onClick={this.disableServerGroup}>
-              Disable
-            </ManagedMenuItem>
-          )}
-          {this.hasDisabledInstances() && !this.isEnableLocked() && (
-            <ManagedMenuItem resource={serverGroup} application={app} onClick={this.enableServerGroup}>
-              Enable
-            </ManagedMenuItem>
-          )}
-          {this.isEnableLocked() && (
-            <li className="disabled">
-              <Tooltip value="Cannot enable this server group until resize operation completes" placement="left">
-                <a>
-                  <span className="small glyphicon glyphicon-lock" /> Enable
+      <>
+        {SETTINGS.awsAdHocInfraWritesEnabled && (
+          <Dropdown className="dropdown" id="server-group-actions-dropdown">
+            <Dropdown.Toggle className="btn btn-sm btn-primary dropdown-toggle">Server Group Actions</Dropdown.Toggle>
+            <Dropdown.Menu className="dropdown-menu">
+              {this.isRollbackEnabled() && (
+                <ManagedMenuItem resource={serverGroup} application={app} onClick={this.rollbackServerGroup}>
+                  Rollback
+                </ManagedMenuItem>
+              )}
+              {this.isRollbackEnabled() && <li role="presentation" className="divider" />}
+              <AmazonServerGroupActionsResize application={app} serverGroup={serverGroup} />
+              {!serverGroup.isDisabled && (
+                <ManagedMenuItem resource={serverGroup} application={app} onClick={this.disableServerGroup}>
+                  Disable
+                </ManagedMenuItem>
+              )}
+              {this.hasDisabledInstances() && !this.isEnableLocked() && (
+                <ManagedMenuItem resource={serverGroup} application={app} onClick={this.enableServerGroup}>
+                  Enable
+                </ManagedMenuItem>
+              )}
+              {this.isEnableLocked() && (
+                <li className="disabled">
+                  <Tooltip value="Cannot enable this server group until resize operation completes" placement="left">
+                    <a>
+                      <span className="small glyphicon glyphicon-lock" /> Enable
+                    </a>
+                  </Tooltip>
+                </li>
+              )}
+              <ManagedMenuItem resource={serverGroup} application={app} onClick={this.destroyServerGroup}>
+                Destroy
+              </ManagedMenuItem>
+              <li>
+                <a className="clickable" onClick={this.cloneServerGroup}>
+                  Clone
                 </a>
-              </Tooltip>
-            </li>
-          )}
-          <ManagedMenuItem resource={serverGroup} application={app} onClick={this.destroyServerGroup}>
-            Destroy
-          </ManagedMenuItem>
-          <li>
-            <a className="clickable" onClick={this.cloneServerGroup}>
-              Clone
-            </a>
-          </li>
-          {showEntityTags && (
-            <AddEntityTagLinks
-              component={serverGroup}
-              application={app}
-              entityType="serverGroup"
-              ownerOptions={entityTagTargets}
-              onUpdate={() => app.serverGroups.refresh()}
-            />
-          )}
-        </Dropdown.Menu>
-      </Dropdown>
+              </li>
+              {showEntityTags && (
+                <AddEntityTagLinks
+                  component={serverGroup}
+                  application={app}
+                  entityType="serverGroup"
+                  ownerOptions={entityTagTargets}
+                  onUpdate={() => app.serverGroups.refresh()}
+                />
+              )}
+            </Dropdown.Menu>
+          </Dropdown>
+        )}
+      </>
     );
   }
 }

package/src/serverGroup/details/amazonServerGroupDetailsGetter.ts

@@ -1,8 +1,9 @@
 import { isEmpty } from 'lodash';
 import { Observable } from 'rxjs';
 
-import { AccountService, IServerGroupDetailsProps, ISubnet, ServerGroupReader, SubnetReader } from '@spinnaker/core';
-import { IAmazonLoadBalancer, IAmazonServerGroup, IAmazonServerGroupView } from '../../domain';
+import type { IServerGroupDetailsProps, ISubnet } from '@spinnaker/core';
+import { AccountService, ServerGroupReader, SubnetReader } from '@spinnaker/core';
+import type { IAmazonLoadBalancer, IAmazonServerGroup, IAmazonServerGroupView } from '../../domain';
 import { AwsReactInjector } from '../../reactShims';
 
 import { AutoScalingProcessService } from './scalingProcesses/AutoScalingProcessService';

package/src/serverGroup/details/resize/AmazonResizeServerGroupModal.tsx

@@ -1,17 +1,15 @@
-import { Form, Formik, FormikErrors, FormikProps } from 'formik';
+import type { Formik, FormikErrors, FormikProps } from 'formik';
+import { Form } from 'formik';
 import { pickBy } from 'lodash';
 import React from 'react';
 import { Modal } from 'react-bootstrap';
 
+import type { Application, ICapacity, IModalComponentProps, IServerGroupJob } from '@spinnaker/core';
 import {
-  Application,
   CheckboxInput,
   confirmNotManaged,
   FormikFormField,
   HelpField,
-  ICapacity,
-  IModalComponentProps,
-  IServerGroupJob,
   MinMaxDesiredChanges,
   ModalClose,
   noop,
@@ -26,7 +24,7 @@ import {
   ValidationMessage,
 } from '@spinnaker/core';
 import { AwsModalFooter } from '../../../common';
-import { IAmazonServerGroup } from '../../../domain';
+import type { IAmazonServerGroup } from '../../../domain';
 
 export interface IAmazonResizeServerGroupModalProps extends IModalComponentProps {
   application: Application;

package/src/serverGroup/details/scalingPolicy/CreateScalingPolicyButton.tsx

@@ -1,12 +1,15 @@
 import React from 'react';
 
-import { Application, ReactModal } from '@spinnaker/core';
-import { IAmazonServerGroupView } from '../../../domain';
+import type { Application } from '@spinnaker/core';
+import { ReactModal } from '@spinnaker/core';
+import type { IAmazonServerGroupView } from '../../../domain';
 import { AwsReactInjector } from '../../../reactShims';
 
-import { IUpsertTargetTrackingModalProps, UpsertTargetTrackingModal } from './targetTracking/UpsertTargetTrackingModal';
+import type { IUpsertTargetTrackingModalProps } from './targetTracking/UpsertTargetTrackingModal';
+import { UpsertTargetTrackingModal } from './targetTracking/UpsertTargetTrackingModal';
 import { PolicyTypeSelectionModal } from './upsert/PolicyTypeSelectionModal';
-import { IUpsertScalingPolicyModalProps, UpsertScalingPolicyModal } from './upsert/UpsertScalingPolicyModal';
+import type { IUpsertScalingPolicyModalProps } from './upsert/UpsertScalingPolicyModal';
+import { UpsertScalingPolicyModal } from './upsert/UpsertScalingPolicyModal';
 
 export interface ICreateScalingPolicyButtonProps {
   application: Application;

package/src/serverGroup/details/scalingPolicy/ScalingPolicySummary.tsx

@@ -1,8 +1,29 @@
-import { Application, IServerGroup } from '@spinnaker/core';
-import { IScalingPolicy } from '../../../domain';
+import * as React from 'react';
+
+import type { Application, IServerGroup } from '@spinnaker/core';
+
+import { StepPolicySummary } from './StepPolicySummary';
+import type { IScalingPolicyView, ITargetTrackingPolicy } from '../../../domain';
+import { TargetTrackingSummary } from './targetTracking/TargetTrackingSummary';
+
+import './scalingPolicySummary.component.less';
 
 export interface IScalingPolicySummaryProps {
-  policy: IScalingPolicy;
-  serverGroup: IServerGroup;
   application: Application;
+  policy: IScalingPolicyView;
+  serverGroup: IServerGroup;
 }
+
+export const ScalingPolicySummary = ({ application, policy, serverGroup }: IScalingPolicySummaryProps) => {
+  if (policy.policyType === 'TargetTrackingScaling') {
+    return (
+      <TargetTrackingSummary
+        application={application}
+        policy={policy as ITargetTrackingPolicy}
+        serverGroup={serverGroup}
+      />
+    );
+  }
+
+  return <StepPolicySummary application={application} policy={policy} serverGroup={serverGroup} />;
+};

package/src/serverGroup/details/scalingPolicy/ScalingPolicyWriter.ts

@@ -1,5 +1,6 @@
-import { Application, IJob, IMetricAlarmDimension, IServerGroup, ITask, TaskExecutor } from '@spinnaker/core';
-import {
+import type { Application, IJob, IMetricAlarmDimension, IServerGroup, ITask } from '@spinnaker/core';
+import { TaskExecutor } from '@spinnaker/core';
+import type {
   AlarmComparisonOperator,
   AlarmStatisticType,
   IScalingPolicy,

package/src/serverGroup/details/scalingPolicy/StepPolicySummary.less

@@ -0,0 +1,10 @@
+.StepPolicySummary {
+  .HoverablePopover {
+    text-decoration: none;
+  }
+
+  .actions {
+    margin: 0 0 15px 0;
+    border-bottom: 1px solid var(--color-alto);
+  }
+}

package/src/serverGroup/details/scalingPolicy/StepPolicySummary.tsx

@@ -0,0 +1,122 @@
+import * as React from 'react';
+
+import {
+  CloudProviderRegistry,
+  ConfirmationModalService,
+  HoverablePopover,
+  ReactModal,
+  robotToHuman,
+  TaskExecutor,
+} from '@spinnaker/core';
+import type { Application, IServerGroup } from '@spinnaker/core';
+
+import type { IAmazonServerGroup, IScalingPolicyView } from '../../../domain';
+import { AlarmSummary } from './popover/AlarmSummary';
+import { StepPolicyPopoverContent } from './popover/StepPolicyPopoverContent';
+
+import './StepPolicySummary.less';
+
+export interface IStepPolicySummaryProps {
+  application: Application;
+  policy: IScalingPolicyView;
+  serverGroup: IServerGroup;
+}
+
+interface IDeletePolicyJob {
+  type: string;
+  cloudProvider: string;
+  credentials: string;
+  region: string;
+  policyName?: string;
+  scalingPolicyID?: string;
+  serverGroupName: string;
+}
+
+export const StepPolicySummary = ({ application, policy, serverGroup }: IStepPolicySummaryProps) => {
+  const provider = serverGroup.type || serverGroup.cloudProvider || 'aws';
+  const providerConfig = CloudProviderRegistry.getValue(provider, 'serverGroup');
+  const policyTitle = provider === 'aws' ? policy.policyName : policy.id;
+
+  const UpsertModalComponent = providerConfig.UpsertStepPolicyModal;
+
+  const editPolicy = () => {
+    const upsertProps = {
+      app: application,
+      policy,
+      serverGroup,
+    };
+
+    const modalProps = { dialogClassName: 'wizard-modal modal-lg' };
+    ReactModal.show<typeof UpsertModalComponent>(UpsertModalComponent, upsertProps, modalProps);
+  };
+  const deletePolicy = () => {
+    const taskMonitor = {
+      application,
+      title: `Deleting scaling policy ${policyTitle}`,
+    };
+
+    const jobToSubmit: IDeletePolicyJob = {
+      type: 'deleteScalingPolicy',
+      cloudProvider: provider,
+      credentials: serverGroup.account,
+      region: serverGroup.region,
+      scalingPolicyID: policy.id,
+      serverGroupName: serverGroup.name,
+    };
+
+    if (provider === 'aws') {
+      delete jobToSubmit.scalingPolicyID;
+      jobToSubmit.policyName = policy.policyName;
+    }
+
+    ConfirmationModalService.confirm({
+      header: `Really delete ${policyTitle}?`,
+      buttonText: 'Delete scaling policy',
+      account: serverGroup.account,
+      taskMonitorConfig: taskMonitor,
+      submitMethod: () =>
+        TaskExecutor.executeTask({
+          application,
+          description: `Delete scaling policy ${policyTitle}`,
+          job: [jobToSubmit],
+        }),
+    });
+  };
+
+  if (!policy.alarms?.length) {
+    return <div>No alarms configured for this policy - it's safe to delete.</div>;
+  }
+
+  return (
+    <div className="StepPolicySummary">
+      <div>
+        {policy.alarms.map((a) => (
+          <div key={`step-summary-${policy.policyName}`}>
+            <HoverablePopover
+              Component={() => (
+                <StepPolicyPopoverContent policy={policy} serverGroup={serverGroup as IAmazonServerGroup} />
+              )}
+              placement="left"
+              title={policy.policyName}
+            >
+              <div>
+                <div className="label label-default">{robotToHuman(policy.policyType).toUpperCase()}</div>
+                <AlarmSummary alarm={a} />
+              </div>
+            </HoverablePopover>
+            <div className="actions">
+              <button className="btn btn-xs btn-link" onClick={editPolicy}>
+                <span className="glyphicon glyphicon-cog"></span>
+                <span className="sr-only">Edit policy</span>
+              </button>
+              <button className="btn btn-xs btn-link" onClick={deletePolicy}>
+                <span className="glyphicon glyphicon-trash"></span>
+                <span className="sr-only">Delete policy</span>
+              </button>
+            </div>
+          </div>
+        ))}
+      </div>
+    </div>
+  );
+};

package/src/serverGroup/details/scalingPolicy/alarmBasedSummary.template.html

@@ -1,5 +1,5 @@
-<alarm-based-summary
+<step-policy-summary
   policy="$ctrl.policy"
   server-group="$ctrl.serverGroup"
   application="$ctrl.application"
-></alarm-based-summary>
+></step-policy-summary>

package/src/serverGroup/details/scalingPolicy/chart/DateLineChart.tsx

@@ -1,20 +1,22 @@
-import {
+import type {
   CartesianScaleOptions,
-  Chart,
   ChartConfiguration,
   ChartDataset,
+  LinearScaleOptions,
+  TimeScaleOptions,
+  TooltipItem,
+} from 'chart.js';
+import {
+  Chart,
   Filler,
   Legend,
   LinearScale,
-  LinearScaleOptions,
   LineController,
   LineElement,
   PointElement,
   TimeScale,
-  TimeScaleOptions,
   Title,
   Tooltip,
-  TooltipItem,
 } from 'chart.js';
 import 'chartjs-adapter-luxon';
 import * as React from 'react';

package/src/serverGroup/details/scalingPolicy/chart/MetricAlarmChart.tsx

@@ -1,20 +1,15 @@
 import { module } from 'angular';
 import * as React from 'react';
 import { react2angular } from 'react2angular';
-import { Observable } from 'rxjs';
+import type { Observable } from 'rxjs';
 
-import {
-  CloudMetricsReader,
-  ICloudMetricStatistics,
-  Spinner,
-  useData,
-  useForceUpdate,
-  useObservable,
-} from '@spinnaker/core';
+import type { ICloudMetricStatistics } from '@spinnaker/core';
+import { CloudMetricsReader, Spinner, useData, useForceUpdate, useObservable } from '@spinnaker/core';
 import { withErrorBoundary } from '@spinnaker/core';
 
-import { DateLineChart, IDateLine } from './DateLineChart';
-import { IAmazonServerGroup, IScalingPolicyAlarm } from '../../../../domain';
+import type { IDateLine } from './DateLineChart';
+import { DateLineChart } from './DateLineChart';
+import type { IAmazonServerGroup, IScalingPolicyAlarm } from '../../../../domain';
 
 interface IMetricAlarmChartProps {
   serverGroup: IAmazonServerGroup;

package/src/serverGroup/details/scalingPolicy/detailsSummary.component.ts

@@ -1,9 +1,10 @@
-import { IComponentOptions, IController, module } from 'angular';
+import type { IComponentOptions, IController } from 'angular';
+import { module } from 'angular';
 
-import { Application, IServerGroup } from '@spinnaker/core';
+import type { Application, IServerGroup } from '@spinnaker/core';
 
 import { ScalingPolicyTypeRegistry } from './ScalingPolicyTypeRegistry';
-import { IScalingPolicy } from '../../../domain';
+import type { IScalingPolicy } from '../../../domain';
 
 export class ScalingPolicyDetailsSummaryController implements IController {
   public templateUrl: string;

package/src/serverGroup/details/scalingPolicy/index.ts

@@ -3,7 +3,11 @@ export { MetricAlarmChart } from './chart/MetricAlarmChart';
 export * from './ScalingPolicyTypeRegistry';
 export * from './CreateScalingPolicyButton';
 export * from './ScalingPolicyWriter';
+export * from './StepPolicySummary';
+export * from './ScalingPolicySummary';
 export * from './targetTracking/TargetTrackingAdditionalSettings';
 export * from './targetTracking/TargetMetricFields';
 export * from './targetTracking/TargetTrackingChart';
+export { UpsertTargetTrackingModal as AmazonUpsertTargetTrackingModal } from './targetTracking/UpsertTargetTrackingModal';
+export * from './targetTracking/TargetTrackingSummary';
 export * from './upsert';