@spinnaker/amazon 0.8.14 → 0.11.0

package/dist/vpc/VpcTag.d.ts

@@ -1,3 +1,4 @@
+/// <reference types="react" />
 export interface IVpcTagProps {
     vpcId: string;
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/amazon",
   "license": "Apache-2.0",
-  "version": "0.8.14",
+  "version": "0.11.0",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -13,7 +13,7 @@
     "lib": "npm run build"
   },
   "dependencies": {
-    "@spinnaker/core": "^0.11.7",
+    "@spinnaker/core": "^0.14.1",
     "@uirouter/angularjs": "1.0.26",
     "@uirouter/core": "6.0.8",
     "@uirouter/react": "1.0.7",
@@ -39,15 +39,15 @@
     "rxjs": "6.6.7"
   },
   "devDependencies": {
-    "@spinnaker/eslint-plugin": "^1.1.1",
+    "@spinnaker/eslint-plugin": "^3.0.0",
     "@spinnaker/mocks": "1.0.7",
-    "@spinnaker/scripts": "^0.2.0",
+    "@spinnaker/scripts": "^0.2.2",
     "@types/angular": "1.6.26",
     "@types/angular-ui-bootstrap": "0.13.41",
     "@types/classnames": "2.2.0",
     "@types/enzyme": "3.10.3",
     "@types/lodash": "4.14.64",
-    "@types/react": "16.8.13",
+    "@types/react": "16.14.10",
     "@types/react-bootstrap": "0.32.5",
     "@types/react-select": "1.3.4",
     "@types/react-sortable-hoc": "0.6.2",
@@ -55,5 +55,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "5b8914288d87ce58b67de4720ebc623b18a3be3e"
+  "gitHead": "b36e5fa30e23cd60007e6839b0dab5e41bd410d5"
 }

package/src/aws.module.ts

@@ -1,6 +1,6 @@
 import { module } from 'angular';
 
-import { CloudProviderRegistry, DeploymentStrategyRegistry } from '@spinnaker/core';
+import { CloudProviderRegistry, DeploymentStrategyRegistry, SETTINGS } from '@spinnaker/core';
 
 import { COMMON_MODULE } from './common/common.module';
 import './deploymentStrategy/rollingPush.strategy';
@@ -47,6 +47,12 @@ import { AWS_SECURITY_GROUP_MODULE } from './securityGroup/securityGroup.module'
 import { AmazonCloneServerGroupModal } from './serverGroup/configure/wizard/AmazonCloneServerGroupModal';
 import { AmazonServerGroupActions } from './serverGroup/details/AmazonServerGroupActions';
 import { amazonServerGroupDetailsGetter } from './serverGroup/details/amazonServerGroupDetailsGetter';
+import {
+  AmazonUpsertScalingPolicyModal,
+  AmazonUpsertTargetTrackingModal,
+  TargetTrackingChart,
+} from './serverGroup/details/scalingPolicy';
+
 import {
   AdvancedSettingsDetailsSection,
   AmazonCapacityDetailsSection,
@@ -111,6 +117,7 @@ module(AMAZON_MODULE, [
 ]).config(() => {
   CloudProviderRegistry.registerProvider('aws', {
     name: 'Amazon',
+    adHocInfrastructureWritesEnabled: SETTINGS.awsAdHocInfraWritesEnabled,
     logo: {
       path: amazonLogo,
     },
@@ -141,6 +148,9 @@ module(AMAZON_MODULE, [
       commandBuilder: 'awsServerGroupCommandBuilder',
       configurationService: 'awsServerGroupConfigurationService',
       scalingActivitiesEnabled: true,
+      TargetTrackingChart,
+      UpsertStepPolicyModal: AmazonUpsertScalingPolicyModal,
+      UpsertTargetTrackingModal: AmazonUpsertTargetTrackingModal,
     },
     instance: {
       instanceTypeService: 'awsInstanceTypeService',

package/src/aws.settings.ts

@@ -1,4 +1,5 @@
-import { IProviderSettings, SETTINGS } from '@spinnaker/core';
+import type { IProviderSettings } from '@spinnaker/core';
+import { SETTINGS } from '@spinnaker/core';
 
 export interface IClassicLaunchAllowlist {
   region: string;

package/src/certificates/AmazonCertificateReader.ts

@@ -1,7 +1,7 @@
 import { groupBy, sortBy } from 'lodash';
 
 import { AccountService, CertificateReader } from '@spinnaker/core';
-import { IAmazonCertificate } from '../domain';
+import type { IAmazonCertificate } from '../domain';
 
 export class AmazonCertificateReader {
   public static listCertificates(): PromiseLike<{ [accountId: string]: IAmazonCertificate[] }> {

package/src/common/AwsModalFooter.tsx

@@ -2,7 +2,8 @@ import React from 'react';
 import { ModalFooter } from 'react-bootstrap';
 import { map, take } from 'rxjs/operators';
 
-import { AccountService, IAccountDetails, UserVerification } from '@spinnaker/core';
+import type { IAccountDetails } from '@spinnaker/core';
+import { AccountService, UserVerification } from '@spinnaker/core';
 
 export interface IAwsModalFooterProps {
   account: string;

package/src/common/footer.component.ts

@@ -1,4 +1,5 @@
-import { IComponentOptions, module } from 'angular';
+import type { IComponentOptions } from 'angular';
+import { module } from 'angular';
 
 const footerComponent: IComponentOptions = {
   bindings: {

package/src/deploymentStrategy/AdditionalFields.tsx

@@ -1,9 +1,10 @@
 import React from 'react';
 
-import { HelpField, IDeploymentStrategyAdditionalFieldsProps } from '@spinnaker/core';
+import type { IDeploymentStrategyAdditionalFieldsProps } from '@spinnaker/core';
+import { HelpField } from '@spinnaker/core';
 
 import { AWSProviderSettings } from '../aws.settings';
-import { IRollingPushCommand } from './rollingPush.strategy';
+import type { IRollingPushCommand } from './rollingPush.strategy';
 
 export interface IRollingPushStrategyAdditionalFieldsProps extends IDeploymentStrategyAdditionalFieldsProps {
   command: IRollingPushCommand;

package/src/deploymentStrategy/rollingPush.strategy.ts

@@ -1,4 +1,5 @@
-import { DeploymentStrategyRegistry, IServerGroupCommand } from '@spinnaker/core';
+import type { IServerGroupCommand } from '@spinnaker/core';
+import { DeploymentStrategyRegistry } from '@spinnaker/core';
 
 import { AdditionalFields } from './AdditionalFields';
 import { AWSProviderSettings } from '../aws.settings';

package/src/domain/IAmazonCertificate.ts

@@ -1,4 +1,4 @@
-import { ICertificate } from '@spinnaker/core';
+import type { ICertificate } from '@spinnaker/core';
 
 export interface IAmazonCertificate extends ICertificate {
   arn: string;

package/src/domain/IAmazonFunction.ts

@@ -1,4 +1,4 @@
-import { IFunction, IFunctionDeleteCommand, IFunctionUpsertCommand } from '@spinnaker/core';
+import type { IFunction, IFunctionDeleteCommand, IFunctionUpsertCommand } from '@spinnaker/core';
 
 export interface IAmazonFunction extends IFunction {
   credentials?: string;

package/src/domain/IAmazonFunctionSourceData.ts

@@ -1,4 +1,4 @@
-import { IFunctionSourceData } from '@spinnaker/core';
+import type { IFunctionSourceData } from '@spinnaker/core';
 
 export interface IAmazonFunctionSourceData extends IFunctionSourceData {
   account: string;
@@ -10,6 +10,7 @@ export interface IAmazonFunctionSourceData extends IFunctionSourceData {
   publish: boolean;
   description: string;
   eventSourceMappings: string[];
+  aliasConfigurations: string[];
   functionArn: string;
   handler: string;
   layers: string;

package/src/domain/IAmazonHealth.ts

@@ -1,4 +1,4 @@
-import { IHealth, ILoadBalancerHealth } from '@spinnaker/core';
+import type { IHealth, ILoadBalancerHealth } from '@spinnaker/core';
 
 export interface IAmazonHealth extends IHealth {
   targetGroups: IAmazonTargetGroupHealth[];

package/src/domain/IAmazonInstance.ts

@@ -1,5 +1,5 @@
-import { IInstance } from '@spinnaker/core';
-import { IAmazonSecurityGroup } from './IAmazonSecurityGroup';
+import type { IInstance } from '@spinnaker/core';
+import type { IAmazonSecurityGroup } from './IAmazonSecurityGroup';
 
 interface IInstancePlacement {
   containerIp: string;

package/src/domain/IAmazonLaunchTemplate.ts

@@ -1,4 +1,4 @@
-import { IBlockDeviceMapping } from './IAmazonBlockDeviceMapping';
+import type { IBlockDeviceMapping } from './IAmazonBlockDeviceMapping';
 
 export interface IIamInstanceProfile {
   arn?: string;

package/src/domain/IAmazonLoadBalancer.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   IInstance,
   IInstanceCounts,
   ILoadBalancer,
@@ -7,9 +7,9 @@ import {
   ISubnet,
 } from '@spinnaker/core';
 
-import { IAmazonLoadBalancerSourceData } from './IAmazonLoadBalancerSourceData';
-import { IAmazonServerGroup } from './IAmazonServerGroup';
-import { IAuthenticateOidcActionConfig } from '../loadBalancer/OidcConfigReader';
+import type { IAmazonLoadBalancerSourceData } from './IAmazonLoadBalancerSourceData';
+import type { IAmazonServerGroup } from './IAmazonServerGroup';
+import type { IAuthenticateOidcActionConfig } from '../loadBalancer/OidcConfigReader';
 
 export type ClassicListenerProtocol = 'HTTP' | 'HTTPS' | 'TCP' | 'SSL';
 export type ALBListenerProtocol = 'HTTP' | 'HTTPS';

package/src/domain/IAmazonLoadBalancerSourceData.ts

@@ -1,8 +1,8 @@
-import { ILoadBalancerSourceData } from '@spinnaker/core';
+import type { ILoadBalancerSourceData } from '@spinnaker/core';
 
-import { IListenerAction, NLBListenerProtocol } from './IAmazonLoadBalancer';
+import type { IListenerAction, NLBListenerProtocol } from './IAmazonLoadBalancer';
 
-import { IListenerRule } from './IAmazonLoadBalancer';
+import type { IListenerRule } from './IAmazonLoadBalancer';
 
 export interface IAmazonContainerServerGroupSourceData {
   detachedInstances: string[];

package/src/domain/IAmazonScalingPolicy.ts

@@ -1,4 +1,5 @@
-import { IScalingPolicy, IScalingPolicyAlarm, IStepAdjustment } from './IScalingPolicy';
+import type { IScalingPolicy, IScalingPolicyAlarm, IStepAdjustment } from './IScalingPolicy';
+import type { ITargetTrackingConfiguration } from './ITargetTrackingPolicy';
 
 export interface IScalingAdjustmentView extends IStepAdjustment {
   operator: string;
@@ -16,6 +17,7 @@ export interface IScalingPolicyView extends IScalingPolicy, IScalingAdjustmentVi
   alarms: IScalingPolicyAlarmView[];
   stepAdjustments: IStepAdjustmentView[];
   operator: string;
+  targetTrackingConfiguration?: ITargetTrackingConfiguration;
 }
 
 export interface IStepAdjustmentView extends IScalingAdjustmentView, IStepAdjustment {

package/src/domain/IAmazonServerGroup.ts

@@ -1,9 +1,9 @@
-import { IAccountDetails, IAsg, IServerGroup } from '@spinnaker/core';
+import type { IAccountDetails, IAsg, IServerGroup } from '@spinnaker/core';
 
-import { IAmazonLaunchTemplate } from './IAmazonLaunchTemplate';
-import { IScalingPolicyView } from './IAmazonScalingPolicy';
-import { IScalingPolicy } from './IScalingPolicy';
-import { ISuspendedProcess } from './IScalingProcess';
+import type { IAmazonLaunchTemplate } from './IAmazonLaunchTemplate';
+import type { IScalingPolicyView } from './IAmazonScalingPolicy';
+import type { IScalingPolicy } from './IScalingPolicy';
+import type { ISuspendedProcess } from './IScalingProcess';
 
 export interface IAmazonAsg extends IAsg {
   availabilityZones: string[];

package/src/domain/IScalingPolicy.ts

@@ -1,4 +1,4 @@
-import { IMetricAlarmDimension } from '@spinnaker/core';
+import type { IMetricAlarmDimension } from '@spinnaker/core';
 
 export interface IScalingPolicyAlarm {
   alarmName?: string;

package/src/domain/ITargetTrackingPolicy.ts

@@ -1,4 +1,4 @@
-import { AlarmStatisticType, IScalingPolicy } from './IScalingPolicy';
+import type { AlarmStatisticType, IScalingPolicy } from './IScalingPolicy';
 
 export interface ITargetTrackingPolicy extends IScalingPolicy {
   autoScalingGroupName?: string;

package/src/function/CreateLambdaFunction.tsx

@@ -1,16 +1,8 @@
 import { cloneDeep } from 'lodash';
 import React from 'react';
 
-import {
-  FunctionWriter,
-  IFunctionModalProps,
-  noop,
-  ReactInjector,
-  ReactModal,
-  TaskMonitor,
-  WizardModal,
-  WizardPage,
-} from '@spinnaker/core';
+import type { IFunctionModalProps } from '@spinnaker/core';
+import { FunctionWriter, noop, ReactInjector, ReactModal, TaskMonitor, WizardModal, WizardPage } from '@spinnaker/core';
 
 import { ExecutionRole } from './configure/ExecutionRole';
 import { FunctionBasicInformation } from './configure/FunctionBasicInformation';
@@ -19,7 +11,7 @@ import { FunctionEnvironmentVariables } from './configure/FunctionEnvironmentVar
 import { FunctionSettings } from './configure/FunctionSettings';
 import { FunctionTags } from './configure/FunctionTags';
 import { Network } from './configure/Network';
-import { IAmazonFunction, IAmazonFunctionUpsertCommand } from '../domain';
+import type { IAmazonFunction, IAmazonFunctionUpsertCommand } from '../domain';
 import { AwsFunctionTransformer } from './function.transformer';
 
 export interface IAmazonCreateFunctionProps extends IFunctionModalProps {

package/src/function/configure/ExecutionRole.tsx

@@ -1,10 +1,11 @@
-import { FormikErrors, FormikProps } from 'formik';
+import type { FormikErrors, FormikProps } from 'formik';
 import React from 'react';
 
-import { FormikFormField, FormValidator, IWizardPageComponent, TextInput } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { FormikFormField, FormValidator, TextInput } from '@spinnaker/core';
 import { iamRoleValidator } from '../../aws.validators';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 export interface IExecutionRoleProps {
   formik: FormikProps<IAmazonFunctionUpsertCommand>;

package/src/function/configure/FunctionBasicInformation.tsx

@@ -1,25 +1,23 @@
 import classNames from 'classnames';
-import { FormikErrors, FormikProps } from 'formik';
+import type { FormikErrors, FormikProps } from 'formik';
 import React from 'react';
-import { combineLatest as observableCombineLatest, from as observableFrom, Observable, Subject } from 'rxjs';
+import type { Observable } from 'rxjs';
+import { combineLatest as observableCombineLatest, from as observableFrom, Subject } from 'rxjs';
 import { distinctUntilChanged, map, shareReplay, switchMap, takeUntil, withLatestFrom } from 'rxjs/operators';
 
+import type { Application, IAccount, IRegion, IWizardPageComponent } from '@spinnaker/core';
 import {
   AccountService,
-  Application,
   CheckboxInput,
   FormikFormField,
   FormValidator,
   HelpField,
-  IAccount,
-  IRegion,
-  IWizardPageComponent,
   ReactSelectInput,
   TextInput,
 } from '@spinnaker/core';
 import { s3BucketNameValidator } from '../../aws.validators';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 const availableRuntimes = [
   'nodejs10.x',

package/src/function/configure/FunctionDebugAndErrorHandling.tsx

@@ -1,17 +1,11 @@
-import { FormikErrors, FormikProps } from 'formik';
+import type { FormikErrors, FormikProps } from 'formik';
 import React from 'react';
 
-import {
-  FormikFormField,
-  FormValidator,
-  HelpField,
-  IWizardPageComponent,
-  ReactSelectInput,
-  TextInput,
-} from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { FormikFormField, FormValidator, HelpField, ReactSelectInput, TextInput } from '@spinnaker/core';
 import { awsArnValidator } from '../../aws.validators';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 export interface IFunctionDebugAndErrorHandlingProps {
   formik: FormikProps<IAmazonFunctionUpsertCommand>;

package/src/function/configure/FunctionEnvironmentVariables.tsx

@@ -1,17 +1,11 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import {
-  FormikFormField,
-  FormValidator,
-  HelpField,
-  IWizardPageComponent,
-  MapEditorInput,
-  TextInput,
-} from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { FormikFormField, FormValidator, HelpField, MapEditorInput, TextInput } from '@spinnaker/core';
 import { awsArnValidator } from '../../aws.validators';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 export interface IFunctionEnvironmentVariablesProps {
   formik: FormikProps<IAmazonFunctionUpsertCommand>;

package/src/function/configure/FunctionSettings.tsx

@@ -1,9 +1,10 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import { FormikFormField, HelpField, IWizardPageComponent, NumberInput, TextInput } from '@spinnaker/core';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { FormikFormField, HelpField, NumberInput, TextInput } from '@spinnaker/core';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 export interface IFunctionSettingsProps {
   formik: FormikProps<IAmazonFunctionUpsertCommand>;

package/src/function/configure/FunctionTags.tsx

@@ -1,10 +1,11 @@
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
 import React from 'react';
 
-import { FormikFormField, FormValidator, IWizardPageComponent, MapEditorInput } from '@spinnaker/core';
+import type { IWizardPageComponent } from '@spinnaker/core';
+import { FormikFormField, FormValidator, MapEditorInput } from '@spinnaker/core';
 import { awsTagsValidator } from '../../aws.validators';
-import { IAmazonFunction } from '../../domain';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunction } from '../../domain';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 
 export interface IFunctionTagsProps {
   formik: FormikProps<IAmazonFunctionUpsertCommand>;

package/src/function/configure/Network.tsx

@@ -1,26 +1,28 @@
-import { FormikErrors, FormikProps } from 'formik';
+import type { FormikErrors, FormikProps } from 'formik';
 import { forOwn, uniqBy } from 'lodash';
 import React from 'react';
-import { Option } from 'react-select';
+import type { Option } from 'react-select';
 import { combineLatest as observableCombineLatest, from as observableFrom, Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
-import {
+import type {
   Application,
-  FormikFormField,
-  HelpField,
   IAccount,
   IRegion,
   ISecurityGroupsByAccountSourceData,
   ISubnet,
   IVpc,
   IWizardPageComponent,
+} from '@spinnaker/core';
+import {
+  FormikFormField,
+  HelpField,
   ReactInjector,
   ReactSelectInput,
   SubnetReader,
   TetheredSelect,
 } from '@spinnaker/core';
-import { IAmazonFunctionUpsertCommand } from '../../index';
+import type { IAmazonFunctionUpsertCommand } from '../../index';
 import { VpcReader } from '../../vpc';
 
 export interface ISubnetOption {

package/src/function/details/AmazonFunctionDetails.tsx

@@ -3,18 +3,11 @@ import React from 'react';
 import { from as observableFrom, Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
-import {
-  AccountTag,
-  Application,
-  CollapsibleSection,
-  Details,
-  IFunction,
-  IOverridableProps,
-  Overrides,
-} from '@spinnaker/core';
+import type { Application, IFunction, IOverridableProps } from '@spinnaker/core';
+import { AccountTag, CollapsibleSection, Details, Overrides } from '@spinnaker/core';
 
 import { FunctionActions } from './FunctionActions';
-import { IAmazonFunction, IAmazonFunctionSourceData } from '../../domain';
+import type { IAmazonFunction, IAmazonFunctionSourceData } from '../../domain';
 import { AwsReactInjector } from '../../reactShims';
 
 export interface IFunctionFromStateParams {
@@ -138,6 +131,26 @@ export class AmazonFunctionDetails extends React.Component<IAmazonFunctionDetail
       </dl>
     );
 
+    const aliasConfigurationDetails = (
+      <dl className="horizontal-when-filters-collapsed dl-horizontal dl-narrow">
+        {functionDef.aliasConfigurations && functionDef.aliasConfigurations.length !== 0
+          ? functionDef.aliasConfigurations.map((value: any) => (
+              <>
+                <h5>
+                  <strong>Alias Details</strong>
+                </h5>
+                <dl>
+                  <dt>Name</dt>
+                  <dd>{value.name}</dd>
+                  <dt>ARN</dt>
+                  <dd>{value.aliasArn}</dd>
+                </dl>
+              </>
+            ))
+          : 'None'}
+      </dl>
+    );
+
     const functionDetailsSection = (
       <CollapsibleSection heading="Function Details">{functionDetails}</CollapsibleSection>
     );
@@ -146,6 +159,10 @@ export class AmazonFunctionDetails extends React.Component<IAmazonFunctionDetail
       <CollapsibleSection heading="Event Source Details">{eventSourceDetails}</CollapsibleSection>
     );
 
+    const aliasConfigurationDetailsSection = (
+      <CollapsibleSection heading="Alias Configuration Details">{aliasConfigurationDetails}</CollapsibleSection>
+    );
+
     return (
       <Details loading={this.state.loading}>
         {isEmpty(this.state.functionDef) ? (
@@ -172,6 +189,9 @@ export class AmazonFunctionDetails extends React.Component<IAmazonFunctionDetail
         {!isEmpty(this.state.functionDef) && !isEmpty(this.state.functionDef.eventSourceMappings)
           ? eventSourceDetailsSection
           : ''}
+        {!isEmpty(this.state.functionDef) && !isEmpty(this.state.functionDef.aliasConfigurations)
+          ? aliasConfigurationDetailsSection
+          : ''}
       </Details>
     );
   }

package/src/function/details/FunctionActions.spec.tsx

@@ -1,7 +1,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import { Application } from '@spinnaker/core';
+import { Application, SETTINGS } from '@spinnaker/core';
 import { IAmazonFunction, FunctionActions } from '../../index';
 
 describe('FunctionActions', () => {
@@ -9,6 +9,7 @@ describe('FunctionActions', () => {
     let app = { name: 'app' } as Application;
 
     let functionDef = { functionName: 'app-function' } as IAmazonFunction;
+    SETTINGS.awsAdHocInfraWritesEnabled = true;
 
     const wrapper = shallow(
       <FunctionActions
@@ -26,4 +27,26 @@ describe('FunctionActions', () => {
 
     expect(dropDown.childAt(0).text()).toEqual('Function Actions');
   });
+
+  it('should not render DropdownToggle if awsAdHocInfraWritesEnabled is false', () => {
+    let app = { name: 'app' } as Application;
+
+    let functionDef = { functionName: 'app-function' } as IAmazonFunction;
+    SETTINGS.awsAdHocInfraWritesEnabled = false;
+
+    const wrapper = shallow(
+      <FunctionActions
+        app={app}
+        functionDef={functionDef}
+        functionFromParams={{
+          account: 'test-account',
+          region: 'us-east-1',
+          functionName: 'function-name',
+        }}
+      />,
+    );
+
+    let dropDown = wrapper.find('div');
+    expect(dropDown.children().length).toEqual(0);
+  });
 });