@sovovs/bycli 1.8.0 → 2.0.0

package/clis/twitter/post.test.js

@@ -1,258 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './post.js';
-
-vi.mock('node:fs', async (importOriginal) => {
-    const actual = await importOriginal();
-    return {
-        ...actual,
-        statSync: vi.fn((p, _opts) => {
-            if (String(p).includes('missing'))
-                return undefined;
-            return { isFile: () => true };
-        }),
-        readFileSync: vi.fn(() => Buffer.from([0x89, 0x50, 0x4e, 0x47])),
-    };
-});
-
-vi.mock('node:path', async (importOriginal) => {
-    const actual = await importOriginal();
-    return {
-        ...actual,
-        resolve: vi.fn((p) => `/abs/${p}`),
-        extname: vi.fn((p) => {
-            const m = p.match(/\.[^.]+$/);
-            return m ? m[0] : '';
-        }),
-    };
-});
-
-function makePage(evaluateResults = [], overrides = {}) {
-    const evaluate = vi.fn();
-    for (const result of evaluateResults) {
-        evaluate.mockResolvedValueOnce(result);
-    }
-    evaluate.mockResolvedValue({ ok: true });
-
-    return {
-        goto: vi.fn().mockResolvedValue(undefined),
-        wait: vi.fn().mockResolvedValue(undefined),
-        evaluate,
-        setFileInput: vi.fn().mockResolvedValue(undefined),
-        insertText: vi.fn().mockResolvedValue(undefined),
-        ...overrides,
-    };
-}
-
-describe('twitter post command', () => {
-    const getCommand = () => getRegistry().get('twitter/post');
-
-    it('registers created tweet id/url columns', () => {
-        const command = getCommand();
-        expect(command?.columns).toEqual(['status', 'message', 'text', 'id', 'url']);
-    });
-
-    it('posts text-only tweet successfully through the current compose route', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true }, // focus composer
-            { ok: true }, // verify native insertText
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' }, // verify submit completed
-        ]);
-
-        const result = await command.func(page, { text: 'hello world' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'hello world' }]);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/compose/post', { waitUntil: 'load', settleMs: 2500 });
-        expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="tweetTextarea_0"]', timeout: 15 });
-        expect(page.insertText).toHaveBeenCalledWith('hello world');
-    });
-
-    it('returns the created tweet URL from the success toast when available', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true },
-            { ok: true },
-            { ok: true },
-            {
-                ok: true,
-                message: 'Tweet posted successfully.',
-                id: '2054239044884693381',
-                url: 'https://x.com/darthjajaj6z/status/2054239044884693381',
-            },
-        ]);
-
-        const result = await command.func(page, { text: 'with url' });
-
-        expect(result).toEqual([{
-            status: 'success',
-            message: 'Tweet posted successfully.',
-            text: 'with url',
-            id: '2054239044884693381',
-            url: 'https://x.com/darthjajaj6z/status/2054239044884693381',
-        }]);
-    });
-
-    it('returns failed when text area not found', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: false, message: 'Could not find the tweet composer text area. Are you logged in?' },
-        ]);
-
-        const result = await command.func(page, { text: 'hello' });
-
-        expect(result).toEqual([{ status: 'failed', message: 'Could not find the tweet composer text area. Are you logged in?', text: 'hello' }]);
-        expect(page.insertText).not.toHaveBeenCalled();
-    });
-
-    it('throws when more than 4 images', async () => {
-        const command = getCommand();
-        const page = makePage();
-        await expect(command.func(page, { text: 'hi', images: 'a.png,b.png,c.png,d.png,e.png' })).rejects.toThrow('Too many images: 5 (max 4)');
-    });
-
-    it('throws when image file does not exist', async () => {
-        const command = getCommand();
-        const page = makePage();
-        await expect(command.func(page, { text: 'hi', images: 'missing.png' })).rejects.toThrow('Not a valid file');
-    });
-
-    it('throws on unsupported image format', async () => {
-        const command = getCommand();
-        const page = makePage();
-        await expect(command.func(page, { text: 'hi', images: 'photo.bmp' })).rejects.toThrow('Unsupported image format');
-    });
-
-    it('falls back to DataTransfer upload when page.setFileInput is not available', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true }, // DataTransfer fallback
-            { ok: true, previewCount: 1 }, // upload polling
-            { ok: true }, // focus composer
-            { ok: true }, // verify native insertText
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' },
-        ], { setFileInput: undefined });
-
-        const result = await command.func(page, { text: 'hi', images: 'a.png' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'hi' }]);
-        expect(page.evaluate.mock.calls[0][0]).toContain('new DataTransfer()');
-        expect(page.evaluate.mock.calls[0][0]).toContain('Could not assign files to input');
-    });
-
-    it('falls back to DataTransfer upload when CDP rejects file input as not allowed', async () => {
-        const command = getCommand();
-        const setFileInput = vi.fn().mockRejectedValue(new Error('NotAllowedError: Not allowed'));
-        const page = makePage([
-            { ok: true }, // DataTransfer fallback
-            { ok: true, previewCount: 1 }, // upload polling
-            { ok: true }, // focus composer
-            { ok: true }, // verify native insertText
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' },
-        ], { setFileInput });
-
-        const result = await command.func(page, { text: 'with fallback', images: 'a.png' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'with fallback' }]);
-        expect(setFileInput).toHaveBeenCalledWith(['/abs/a.png'], 'input[type="file"][data-testid="fileInput"]');
-        expect(page.evaluate.mock.calls[0][0]).toContain('new DataTransfer()');
-    });
-
-    it('uploads images before inserting text so media re-renders cannot erase the tweet text', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true, previewCount: 2 }, // upload polling returns true
-            { ok: true }, // focus composer
-            { ok: true }, // verify native insertText
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' }, // verify submit completed
-        ]);
-
-        const result = await command.func(page, { text: 'with images', images: 'a.png,b.png' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'with images' }]);
-        expect(page.wait).toHaveBeenNthCalledWith(2, { selector: 'input[type="file"][data-testid="fileInput"]', timeout: 20 });
-        expect(page.setFileInput).toHaveBeenCalledWith(['/abs/a.png', '/abs/b.png'], 'input[type="file"][data-testid="fileInput"]');
-        expect(page.insertText).toHaveBeenCalledWith('with images');
-        expect(page.setFileInput.mock.invocationCallOrder[0]).toBeLessThan(page.insertText.mock.invocationCallOrder[0]);
-
-        const uploadScript = page.evaluate.mock.calls[0][0];
-        expect(uploadScript).toContain('[data-testid="attachments"]');
-        expect(uploadScript).toContain('buttonReady');
-    });
-
-    it('prefers nativeType when available because bridge insert-text can miss Draft.js after media upload', async () => {
-        const command = getCommand();
-        const nativeType = vi.fn().mockResolvedValue(undefined);
-        const page = makePage([
-            { ok: true }, // focus composer
-            { ok: true }, // verify nativeType
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' },
-        ], { nativeType });
-
-        const result = await command.func(page, { text: 'native type' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'native type' }]);
-        expect(nativeType).toHaveBeenCalledWith('native type');
-        expect(page.insertText).not.toHaveBeenCalled();
-    });
-
-    it('treats X success toast as completed even if stale composer nodes remain', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true }, // focus composer
-            { ok: true }, // verify native insertText
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' }, // verify submit completed
-        ]);
-
-        await command.func(page, { text: 'toast success' });
-
-        const submitScript = page.evaluate.mock.calls[3][0];
-        expect(submitScript).toContain('successToast');
-        expect(submitScript).toContain('your post was sent');
-    });
-
-    it('returns failed when image upload times out', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: false, message: 'Image upload timed out (30s).' },
-        ]);
-
-        const result = await command.func(page, { text: 'timeout', images: 'a.png' });
-
-        expect(result).toEqual([{ status: 'failed', message: 'Image upload timed out (30s).', text: 'timeout' }]);
-        expect(page.insertText).not.toHaveBeenCalled();
-    });
-
-    it('falls back to DOM insertion when native insertText is unavailable', async () => {
-        const command = getCommand();
-        const page = makePage([
-            { ok: true }, // focus composer
-            { ok: true }, // fallback DOM insertion
-            { ok: true }, // click post
-            { ok: true, message: 'Tweet posted successfully.' },
-        ], { insertText: undefined });
-
-        const result = await command.func(page, { text: 'fallback text' });
-
-        expect(result).toEqual([{ status: 'success', message: 'Tweet posted successfully.', text: 'fallback text' }]);
-        expect(page.evaluate.mock.calls[1][0]).toContain("execCommand('insertText'");
-    });
-
-    it('validates images before navigating to compose page', async () => {
-        const command = getCommand();
-        const page = makePage();
-        await expect(command.func(page, { text: 'hi', images: 'missing.png' })).rejects.toThrow('Not a valid file');
-        expect(page.goto).not.toHaveBeenCalled();
-    });
-
-    it('throws when no browser session', async () => {
-        const command = getCommand();
-        await expect(command.func(null, { text: 'hi' })).rejects.toThrow('Browser session required for twitter post');
-    });
-});

package/clis/twitter/profile.test.js

@@ -1,39 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, AuthRequiredError } from '@sovovs/bycli/errors';
-import './profile.js';
-
-describe('twitter profile command', () => {
-    it('rejects invalid explicit usernames before navigation', async () => {
-        const command = getRegistry().get('twitter/profile');
-        const page = {
-            goto: vi.fn(),
-            wait: vi.fn(),
-            getCookies: vi.fn(),
-            evaluate: vi.fn(),
-        };
-
-        await expect(command.func(page, { username: 'viewer/extra' })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.getCookies).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('rejects route-like AppTabBar hrefs instead of navigating to that route profile', async () => {
-        const command = getRegistry().get('twitter/profile');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn(),
-            evaluate: vi.fn(async (script) => {
-                if (String(script).includes('AppTabBar_Profile_Link')) return '/home';
-                throw new Error(`Unexpected evaluate: ${String(script).slice(0, 80)}`);
-            }),
-        };
-
-        await expect(command.func(page, {})).rejects.toBeInstanceOf(AuthRequiredError);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/home');
-        expect(page.goto).toHaveBeenCalledTimes(1);
-        expect(page.getCookies).not.toHaveBeenCalled();
-    });
-});

package/clis/twitter/quote.test.js

@@ -1,194 +0,0 @@
-import * as fs from 'node:fs';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import { describe, expect, it, vi } from 'vitest';
-import { ArgumentError, CommandExecutionError } from '@sovovs/bycli/errors';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { __test__ } from './quote.js';
-import './quote.js';
-import { createPageMock } from '../test-utils.js';
-
-describe('twitter quote helpers', () => {
-    it('builds the quote composer URL with the source tweet attached as ?url=...', () => {
-        const composeUrl = __test__.buildQuoteComposerUrl('https://x.com/alice/status/2040254679301718161?s=20');
-        // The full source URL is round-tripped via encodeURIComponent — decoding it
-        // back must yield the original URL. This guards against accidental drops of
-        // query parameters or fragment characters in future refactors.
-        const parsed = new URL(composeUrl);
-        expect(parsed.origin + parsed.pathname).toBe('https://x.com/compose/post');
-        expect(parsed.searchParams.get('url')).toBe('https://x.com/alice/status/2040254679301718161?s=20');
-    });
-
-    it('rejects malformed URLs before any browser interaction', () => {
-        expect(() => __test__.buildQuoteComposerUrl('https://x.com/alice/home')).toThrow(/Could not extract tweet ID/);
-        expect(() => __test__.buildQuoteComposerUrl('not a url')).toThrow(/Invalid tweet URL/);
-        expect(() => __test__.buildQuoteComposerUrl('https://evil.com/?next=https://x.com/alice/status/2040254679301718161')).toThrow(ArgumentError);
-    });
-});
-
-describe('twitter quote command', () => {
-    it('navigates to the quote composer and reports success when the script confirms', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        expect(cmd?.func).toBeTypeOf('function');
-        const page = createPageMock([
-            { ok: true, message: 'Quote tweet posted successfully.' },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'great take',
-        });
-        expect(page.goto).toHaveBeenCalledWith(
-            'https://x.com/compose/post?url=https%3A%2F%2Fx.com%2Falice%2Fstatus%2F2040254679301718161',
-            { waitUntil: 'load', settleMs: 2500 },
-        );
-        expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="tweetTextarea_0"]', timeout: 15 });
-        expect(page.wait).toHaveBeenNthCalledWith(2, 3);
-        const script = page.evaluate.mock.calls[0][0];
-        // Quote-attachment guard: the script must verify the quoted card rendered
-        // before submitting; otherwise we'd silently post a plain tweet without
-        // the quote attachment. Detection now uses the shared helper's
-        // __twHasLinkToTarget(document) — JSDOM coverage in shared.test.js
-        // proves it does an exact (not substring) match on the status id.
-        expect(script).toContain('Quote target did not render');
-        expect(script).toContain('document.execCommand');
-        expect(script).toContain('tweetButton');
-        expect(script).toContain('__twHasLinkToTarget(document)');
-        expect(script).toContain('__twGetStatusIdFromHref');
-        expect(script).toContain('Quote tweet submission did not complete before timeout');
-        expect(script).toContain('[role="alert"], [data-testid="toast"]');
-        expect(result).toEqual([
-            {
-                status: 'success',
-                message: 'Quote tweet posted successfully.',
-                text: 'great take',
-            },
-        ]);
-    });
-
-    it('uploads a local image through the quote composer when --image is provided', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        expect(cmd?.func).toBeTypeOf('function');
-        const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bycli-twitter-quote-'));
-        const imagePath = path.join(tempDir, 'banner.png');
-        fs.writeFileSync(imagePath, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
-        const setFileInput = vi.fn().mockResolvedValue(undefined);
-        const page = createPageMock([
-            { ok: true, previewCount: 1 },
-            { ok: true, message: 'Quote tweet posted successfully.' },
-        ], {
-            setFileInput,
-        });
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'check this',
-            image: imagePath,
-        });
-        expect(page.goto).toHaveBeenCalledWith(
-            'https://x.com/compose/post?url=https%3A%2F%2Fx.com%2Falice%2Fstatus%2F2040254679301718161',
-            { waitUntil: 'load', settleMs: 2500 },
-        );
-        expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="tweetTextarea_0"]', timeout: 15 });
-        expect(page.wait).toHaveBeenNthCalledWith(2, { selector: 'input[type="file"][data-testid="fileInput"]', timeout: 20 });
-        expect(setFileInput).toHaveBeenCalledWith([imagePath], 'input[type="file"][data-testid="fileInput"]');
-        expect(result).toEqual([
-            {
-                status: 'success',
-                message: 'Quote tweet posted successfully.',
-                text: 'check this',
-                image: imagePath,
-            },
-        ]);
-        fs.rmSync(tempDir, { recursive: true, force: true });
-    });
-
-    it('downloads a remote image before uploading when --image-url is provided', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        expect(cmd?.func).toBeTypeOf('function');
-        const fetchMock = vi.fn().mockResolvedValue({
-            ok: true,
-            headers: {
-                get: vi.fn().mockReturnValue('image/png'),
-            },
-            arrayBuffer: vi.fn().mockResolvedValue(Uint8Array.from([0x89, 0x50, 0x4e, 0x47]).buffer),
-        });
-        vi.stubGlobal('fetch', fetchMock);
-        const setFileInput = vi.fn().mockResolvedValue(undefined);
-        const page = createPageMock([
-            { ok: true, previewCount: 1 },
-            { ok: true, message: 'Quote tweet posted successfully.' },
-        ], {
-            setFileInput,
-        });
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'remote attach',
-            'image-url': 'https://example.com/banner',
-        });
-        expect(fetchMock).toHaveBeenCalledWith('https://example.com/banner');
-        expect(setFileInput).toHaveBeenCalledTimes(1);
-        const uploadedPath = setFileInput.mock.calls[0][0][0];
-        expect(uploadedPath).toMatch(/bycli-twitter-.*\/image\.png$/);
-        // Per-call tmp dir is removed in the adapter's finally block.
-        expect(fs.existsSync(uploadedPath)).toBe(false);
-        expect(result).toEqual([
-            {
-                status: 'success',
-                message: 'Quote tweet posted successfully.',
-                text: 'remote attach',
-                'image-url': 'https://example.com/banner',
-            },
-        ]);
-        vi.unstubAllGlobals();
-    });
-
-    it('rejects using --image and --image-url together', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        const page = createPageMock([]);
-        await expect(cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'nope',
-            image: '/tmp/a.png',
-            'image-url': 'https://example.com/a.png',
-        })).rejects.toThrow(CommandExecutionError);
-    });
-
-    it('returns a failed row when the quote target fails to render', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        expect(cmd?.func).toBeTypeOf('function');
-        const page = createPageMock([
-            { ok: false, message: 'Quote target did not render in the composer. The source tweet may be deleted or restricted.' },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'orphaned quote',
-        });
-        expect(result).toEqual([
-            {
-                status: 'failed',
-                message: 'Quote target did not render in the composer. The source tweet may be deleted or restricted.',
-                text: 'orphaned quote',
-            },
-        ]);
-        // Only the textarea wait should run when ok is false (no extra 3s post-submit wait).
-        expect(page.wait).toHaveBeenCalledTimes(1);
-    });
-
-    it('throws CommandExecutionError when no page is provided', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        await expect(cmd.func(undefined, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-            text: 'hi',
-        })).rejects.toThrow(CommandExecutionError);
-    });
-
-    it('rejects invalid tweet URLs before navigation', async () => {
-        const cmd = getRegistry().get('twitter/quote');
-        const page = createPageMock([]);
-        await expect(cmd.func(page, {
-            url: 'https://x.com.evil.com/alice/status/2040254679301718161',
-            text: 'hi',
-        })).rejects.toThrow(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-});