@sovovs/bycli 1.8.0 → 2.0.0

package/clis/twitter/following.test.js

@@ -1,338 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, AuthRequiredError, CommandExecutionError, EmptyResultError } from '@sovovs/bycli/errors';
-import { __test__ } from './following.js';
-
-describe('twitter following helpers', () => {
-    it('falls back when queryId contains unsafe characters', () => {
-        expect(__test__.sanitizeQueryId('safe_Query-123', 'fallback')).toBe('safe_Query-123');
-        expect(__test__.sanitizeQueryId('bad"id', 'fallback')).toBe('fallback');
-        expect(__test__.sanitizeQueryId('bad/id', 'fallback')).toBe('fallback');
-        expect(__test__.sanitizeQueryId(null, 'fallback')).toBe('fallback');
-    });
-
-    it('builds following url with cursor', () => {
-        const url = __test__.buildFollowingUrl('query123', '42', 20, 'cursor-1');
-        expect(url).toContain('/i/api/graphql/query123/Following');
-        expect(decodeURIComponent(url)).toContain('"userId":"42"');
-        expect(decodeURIComponent(url)).toContain('"count":20');
-        expect(decodeURIComponent(url)).toContain('"cursor":"cursor-1"');
-    });
-
-    it('builds following url without cursor', () => {
-        const url = __test__.buildFollowingUrl('query123', '42', 20);
-        expect(url).toContain('/i/api/graphql/query123/Following');
-        expect(decodeURIComponent(url)).not.toContain('"cursor"');
-    });
-
-    it('extracts user from result', () => {
-        const user = __test__.extractUser({
-            __typename: 'User',
-            core: { screen_name: 'alice', name: 'Alice' },
-            legacy: { description: 'bio text', followers_count: 100 },
-        });
-        expect(user).toMatchObject({
-            screen_name: 'alice',
-            name: 'Alice',
-            bio: 'bio text',
-            followers: 100,
-        });
-    });
-
-    it('returns null for non-User typename', () => {
-        expect(__test__.extractUser({ __typename: 'Tweet' })).toBeNull();
-        expect(__test__.extractUser(null)).toBeNull();
-        expect(__test__.extractUser(undefined)).toBeNull();
-    });
-
-    it('falls back to legacy screen_name if core is missing', () => {
-        const user = __test__.extractUser({
-            __typename: 'User',
-            legacy: { screen_name: 'bob', name: 'Bob', description: '', followers_count: 0 },
-        });
-        expect(user?.screen_name).toBe('bob');
-    });
-
-    it('parses following timeline with users and cursor', () => {
-        const payload = {
-            data: {
-                user: {
-                    result: {
-                        timeline_v2: {
-                            timeline: {
-                                instructions: [{
-                                    entries: [
-                                        {
-                                            entryId: 'user-1',
-                                            content: {
-                                                itemContent: {
-                                                    user_results: {
-                                                        result: {
-                                                            __typename: 'User',
-                                                            core: { screen_name: 'bob', name: 'Bob' },
-                                                            legacy: { description: 'hello', followers_count: 50 },
-                                                        },
-                                                    },
-                                                },
-                                            },
-                                        },
-                                        {
-                                            entryId: 'user-2',
-                                            content: {
-                                                itemContent: {
-                                                    user_results: {
-                                                        result: {
-                                                            __typename: 'User',
-                                                            core: { screen_name: 'carol', name: 'Carol' },
-                                                            legacy: { description: 'world', followers_count: 200 },
-                                                        },
-                                                    },
-                                                },
-                                            },
-                                        },
-                                        {
-                                            entryId: 'cursor-bottom-1',
-                                            content: {
-                                                entryType: 'TimelineTimelineCursor',
-                                                cursorType: 'Bottom',
-                                                value: 'next-cursor',
-                                            },
-                                        },
-                                    ],
-                                }],
-                            },
-                        },
-                    },
-                },
-            },
-        };
-        const result = __test__.parseFollowing(payload);
-        expect(result.users).toHaveLength(2);
-        expect(result.users[0]).toMatchObject({ screen_name: 'bob', name: 'Bob', followers: 50 });
-        expect(result.users[1]).toMatchObject({ screen_name: 'carol', name: 'Carol', followers: 200 });
-        expect(result.nextCursor).toBe('next-cursor');
-    });
-
-    it('handles cursor-bottom entryId pattern', () => {
-        const payload = {
-            data: {
-                user: {
-                    result: {
-                        timeline: {
-                            timeline: {
-                                instructions: [{
-                                    entries: [
-                                        {
-                                            entryId: 'cursor-bottom-0',
-                                            content: {
-                                                itemContent: { value: 'cursor-val' },
-                                            },
-                                        },
-                                    ],
-                                }],
-                            },
-                        },
-                    },
-                },
-            },
-        };
-        const result = __test__.parseFollowing(payload);
-        expect(result.nextCursor).toBe('cursor-val');
-        expect(result.users).toHaveLength(0);
-    });
-
-    it('returns empty users and null cursor for missing instructions', () => {
-        const result = __test__.parseFollowing({ data: { user: { result: {} } } });
-        expect(result.users).toHaveLength(0);
-        expect(result.nextCursor).toBeNull();
-    });
-
-    it('returns empty for completely empty payload', () => {
-        const result = __test__.parseFollowing({});
-        expect(result.users).toHaveLength(0);
-        expect(result.nextCursor).toBeNull();
-    });
-
-    it('normalizes screen names for CLI and profile-link inputs', () => {
-        expect(__test__.normalizeScreenName('@elonmusk')).toBe('elonmusk');
-        expect(__test__.normalizeScreenName('/elonmusk')).toBe('elonmusk');
-        expect(__test__.normalizeScreenName('  @@alice  ')).toBe('alice');
-        expect(__test__.normalizeScreenName('/home')).toBe('');
-        expect(__test__.normalizeScreenName('/elonmusk/extra')).toBe('');
-    });
-});
-
-function followingPayload(users, cursor) {
-    return {
-        data: {
-            user: {
-                result: {
-                    timeline_v2: {
-                        timeline: {
-                            instructions: [{
-                                entries: [
-                                    ...users.map((name) => ({
-                                        entryId: `user-${name}`,
-                                        content: {
-                                            itemContent: {
-                                                user_results: {
-                                                    result: {
-                                                        __typename: 'User',
-                                                        core: { screen_name: name, name: name.toUpperCase() },
-                                                        legacy: { description: `${name} bio`, followers_count: 10 },
-                                                    },
-                                                },
-                                            },
-                                        },
-                                    })),
-                                    ...(cursor ? [{
-                                        entryId: `cursor-bottom-${cursor}`,
-                                        content: {
-                                            entryType: 'TimelineTimelineCursor',
-                                            cursorType: 'Bottom',
-                                            value: cursor,
-                                        },
-                                    }] : []),
-                                ],
-                            }],
-                        },
-                    },
-                },
-            },
-        },
-    };
-}
-
-function bridgeEnvelope(data) {
-    return { session: 'site:twitter', data };
-}
-
-function createFollowingPage(followingResponses, { ct0 = 'token', userLookup = { userId: '42' }, envelope = false } = {}) {
-    const page = {
-        goto: vi.fn().mockResolvedValue(undefined),
-        wait: vi.fn().mockResolvedValue(undefined),
-        getCookies: vi.fn(async () => (ct0 ? [{ name: 'ct0', value: ct0 }] : [])),
-        evaluate: vi.fn(async (script, ...args) => {
-            const wrap = (value) => envelope ? bridgeEnvelope(value) : value;
-            if (typeof script === 'function') {
-                const haystack = [script.toString(), ...args.map((arg) => String(arg))].join('\n');
-                if (haystack.includes('/UserByScreenName')) return wrap(userLookup);
-                if (haystack.includes('/Following')) return wrap(followingResponses.shift() || followingPayload([], null));
-                if (haystack.includes('AppTabBar_Profile_Link')) return wrap('/viewer');
-                throw new Error(`Unexpected evaluate function: ${haystack.slice(0, 80)}`);
-            }
-            if (script.includes('operationName')) return null;
-            if (script.includes('/UserByScreenName')) return wrap(userLookup);
-            if (script.includes('/Following')) return wrap(followingResponses.shift() || followingPayload([], null));
-            if (script.includes('AppTabBar_Profile_Link')) return wrap('/viewer');
-            throw new Error(`Unexpected evaluate script: ${script.slice(0, 80)}`);
-        }),
-    };
-    return page;
-}
-
-describe('twitter following command', () => {
-    it('paginates with cursor, deduplicates users, strips @, and respects limit', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([
-            followingPayload(['alice', 'bob'], 'cursor-1'),
-            followingPayload(['bob', 'carol', 'dave'], null),
-        ]);
-
-        const rows = await command.func(page, { user: '@elonmusk', limit: 3 });
-
-        expect(rows.map((row) => row.screen_name)).toEqual(['alice', 'bob', 'carol']);
-        expect(page.getCookies).toHaveBeenCalledWith({ url: 'https://x.com' });
-        const callText = (call) => call.map((part) => typeof part === 'function' ? part.toString() : String(part)).join('\n');
-        const userLookupScript = callText(page.evaluate.mock.calls.find((call) => callText(call).includes('/UserByScreenName')) || []);
-        expect(decodeURIComponent(userLookupScript)).toContain('"screen_name":"elonmusk"');
-        expect(decodeURIComponent(userLookupScript)).not.toContain('"screen_name":"@elonmusk"');
-        const followingCalls = page.evaluate.mock.calls.filter((call) => callText(call).includes('/Following'));
-        expect(followingCalls).toHaveLength(2);
-        expect(decodeURIComponent(callText(followingCalls[1]))).toContain('"cursor":"cursor-1"');
-    });
-
-    it('rejects invalid limits before navigating', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([]);
-
-        await expect(command.func(page, { user: 'elonmusk', limit: 0 })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-    });
-
-    it('rejects invalid explicit users before cookies or navigation', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([]);
-
-        await expect(command.func(page, { user: 'elonmusk/extra', limit: 10 })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.getCookies).not.toHaveBeenCalled();
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('rejects route-like AppTabBar hrefs as AuthRequiredError', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([]);
-        page.evaluate.mockImplementation(async (script, ...args) => {
-            const haystack = [typeof script === 'function' ? script.toString() : String(script), ...args.map((arg) => String(arg))].join('\n');
-            if (haystack.includes('AppTabBar_Profile_Link')) return '/home';
-            throw new Error(`Unexpected evaluate: ${haystack.slice(0, 80)}`);
-        });
-
-        await expect(command.func(page, { limit: 10 })).rejects.toBeInstanceOf(AuthRequiredError);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/home');
-    });
-
-    it('maps first-page auth failures to AuthRequiredError', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([{ error: 401 }]);
-
-        await expect(command.func(page, { user: 'elonmusk', limit: 10 })).rejects.toBeInstanceOf(AuthRequiredError);
-    });
-
-    it('does not silently return partial rows when a later page fails', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([
-            followingPayload(['alice'], 'cursor-1'),
-            { error: 429 },
-        ]);
-
-        await expect(command.func(page, { user: 'elonmusk', limit: 10 })).rejects.toBeInstanceOf(CommandExecutionError);
-    });
-
-    it('maps user lookup auth failures to AuthRequiredError', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([], { userLookup: { error: 403 } });
-
-        await expect(command.func(page, { user: 'elonmusk', limit: 10 })).rejects.toBeInstanceOf(AuthRequiredError);
-    });
-
-    it('unwraps Browser Bridge envelopes for user lookup and following payloads', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([followingPayload(['alice'], null)], { envelope: true });
-
-        const rows = await command.func(page, { user: 'elonmusk', limit: 10 });
-
-        expect(rows.map((row) => row.screen_name)).toEqual(['alice']);
-        const callText = (call) => call.map((part) => typeof part === 'function' ? part.toString() : String(part)).join('\n');
-        const followingCall = page.evaluate.mock.calls.find((call) => callText(call).includes('/Following')) || [];
-        const followingUrl = String(followingCall[1] || '');
-        expect(decodeURIComponent(followingUrl)).toContain('"userId":"42"');
-        expect(decodeURIComponent(followingUrl)).not.toContain('[object Object]');
-    });
-
-    it('fails fast when the following timeline is empty', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([followingPayload([], null)]);
-
-        await expect(command.func(page, { user: 'elonmusk', limit: 10 })).rejects.toBeInstanceOf(EmptyResultError);
-    });
-
-    it('surfaces the private-following privacy hint when result.timeline is empty', async () => {
-        const command = getRegistry().get('twitter/following');
-        const page = createFollowingPage([{ data: { user: { result: { __typename: 'User', timeline: {} } } } }]);
-
-        await expect(command.func(page, { user: 'simonw', limit: 10 }))
-            .rejects.toMatchObject({ hint: expect.stringContaining('following list to private') });
-    });
-});

package/clis/twitter/hide-reply.test.js

@@ -1,76 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { ArgumentError, CommandExecutionError } from '@sovovs/bycli/errors';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './hide-reply.js';
-import { createPageMock } from '../test-utils.js';
-
-describe('twitter hide-reply command', () => {
-    it('navigates to the reply URL and reports success when the hide-reply script confirms', async () => {
-        const cmd = getRegistry().get('twitter/hide-reply');
-        expect(cmd?.func).toBeTypeOf('function');
-        const page = createPageMock([
-            { ok: true, message: 'Reply successfully hidden.' },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        });
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/alice/status/2040254679301718161');
-        expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="primaryColumn"]' });
-        expect(page.wait).toHaveBeenNthCalledWith(2, 2);
-        const script = page.evaluate.mock.calls[0][0];
-        // Article-scoped More menu lookup — without scoping, the bare
-        // [aria-label="More"] selector grabs the parent tweet's More menu and
-        // silently hides the wrong reply (or fails because the parent is not a
-        // reply you authored).
-        expect(script).toContain('moreMenu.click()');
-        expect(script).toContain('[role="menuitem"]');
-        expect(script).toContain("'Hide reply'");
-        expect(script).toContain('hideItem.click()');
-        // Article scoping comes from the shared helper (buildTwitterArticleScopeSource):
-        // emits __twHasLinkToTarget + __twGetStatusIdFromHref + the anchored
-        // tweet-path regex. JSDOM-level coverage lives in shared.test.js.
-        expect(script).toContain('__twHasLinkToTarget');
-        expect(script).toContain('__twGetStatusIdFromHref');
-        expect(script).toContain("document.querySelectorAll('article')");
-        expect(result).toEqual([
-            { status: 'success', message: 'Reply successfully hidden.' },
-        ]);
-    });
-
-    it('returns a failed row without re-waiting when the hide-reply script reports a UI mismatch', async () => {
-        const cmd = getRegistry().get('twitter/hide-reply');
-        const page = createPageMock([
-            {
-                ok: false,
-                message: 'Could not find "Hide reply" option. This may not be a reply on your tweet.',
-            },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        });
-        expect(result).toEqual([
-            {
-                status: 'failed',
-                message: 'Could not find "Hide reply" option. This may not be a reply on your tweet.',
-            },
-        ]);
-        expect(page.wait).toHaveBeenCalledTimes(1);
-    });
-
-    it('throws CommandExecutionError when no page is provided', async () => {
-        const cmd = getRegistry().get('twitter/hide-reply');
-        await expect(cmd.func(undefined, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        })).rejects.toThrow(CommandExecutionError);
-    });
-
-    it('rejects invalid tweet URLs before navigation', async () => {
-        const cmd = getRegistry().get('twitter/hide-reply');
-        const page = createPageMock([]);
-        await expect(cmd.func(page, {
-            url: 'https://x.com.evil.com/alice/status/2040254679301718161',
-        })).rejects.toThrow(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-});

package/clis/twitter/like.test.js

@@ -1,73 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { ArgumentError, CommandExecutionError } from '@sovovs/bycli/errors';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './like.js';
-import { createPageMock } from '../test-utils.js';
-
-describe('twitter like command', () => {
-    it('navigates to the tweet URL and reports success when the like script confirms', async () => {
-        const cmd = getRegistry().get('twitter/like');
-        expect(cmd?.func).toBeTypeOf('function');
-        const page = createPageMock([
-            { ok: true, message: 'Tweet successfully liked.' },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        });
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/alice/status/2040254679301718161');
-        expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="primaryColumn"]' });
-        expect(page.wait).toHaveBeenNthCalledWith(2, 2);
-        const script = page.evaluate.mock.calls[0][0];
-        // Idempotency: looks for the unlike button (already-liked path) before clicking.
-        expect(script).toContain("targetArticle?.querySelector('[data-testid=\"like\"]')");
-        expect(script).toContain("targetArticle?.querySelector('[data-testid=\"unlike\"]')");
-        expect(script).toContain('likeBtn.click()');
-        // Article scoping comes from the shared helper (buildTwitterArticleScopeSource):
-        // emits __twHasLinkToTarget + __twGetStatusIdFromHref + the anchored
-        // tweet-path regex. JSDOM-level coverage lives in shared.test.js.
-        expect(script).toContain('__twHasLinkToTarget');
-        expect(script).toContain('__twGetStatusIdFromHref');
-        expect(script).toContain("document.querySelectorAll('article')");
-        expect(result).toEqual([
-            { status: 'success', message: 'Tweet successfully liked.' },
-        ]);
-    });
-
-    it('returns a failed row without re-waiting when the like script reports a UI mismatch', async () => {
-        const cmd = getRegistry().get('twitter/like');
-        const page = createPageMock([
-            {
-                ok: false,
-                message: 'Could not find the Like button on this tweet after waiting 10 seconds. Are you logged in?',
-            },
-        ]);
-        const result = await cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        });
-        expect(result).toEqual([
-            {
-                status: 'failed',
-                message: 'Could not find the Like button on this tweet after waiting 10 seconds. Are you logged in?',
-            },
-        ]);
-        // Only the primaryColumn wait should run when ok is false.
-        expect(page.wait).toHaveBeenCalledTimes(1);
-    });
-
-    it('throws CommandExecutionError when no page is provided', async () => {
-        const cmd = getRegistry().get('twitter/like');
-        await expect(cmd.func(undefined, {
-            url: 'https://x.com/alice/status/2040254679301718161',
-        })).rejects.toThrow(CommandExecutionError);
-    });
-
-    it('rejects invalid tweet URLs before navigation', async () => {
-        const cmd = getRegistry().get('twitter/like');
-        const page = createPageMock([]);
-        await expect(cmd.func(page, {
-            url: 'https://x.com/alice/status/2040254679301718161/photo/1',
-        })).rejects.toThrow(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-});